Re: [FFmpeg-devel] [PATCH] avformat/hls: Fixes overwriting existing #EXT-X-PROGRAM-DATE-TIME value in HLS playlist

2020-11-24 Thread Steven Liu
> 2020年11月25日 下午1:16,Vignesh Ravichandran 写道: > > Bug ID: 8989 > > This is is due to the following behavior in the current code: > 1. The initial_prog_date_time gets set to the current local time > 2. The existing playlist (.m3u8) file gets parsed and the segments present > are added to the

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fixes #EXT-X-PROGRAM-DATE-TIME value of existing segments from getting over written with new value when appending new segments to an existing playlist file

2020-11-24 Thread Vignesh Ravichandran
I have amended the commit message and resubmitted the patch - http://ffmpeg.org/pipermail/ffmpeg-devel/2020-November/272924.html Please review. Thanks, Vignesh On Wed, Nov 25, 2020 at 8:38 AM Steven Liu wrote: > Vignesh Ravichandran 于2020年11月21日周六 > 下午11:22写道: > > > > Signed-off-by: Vignesh

[FFmpeg-devel] [PATCH] avformat/hls: Fixes overwriting existing #EXT-X-PROGRAM-DATE-TIME value in HLS playlist

2020-11-24 Thread Vignesh Ravichandran
Bug ID: 8989 This is is due to the following behavior in the current code: 1. The initial_prog_date_time gets set to the current local time 2. The existing playlist (.m3u8) file gets parsed and the segments present are added to the variant stream 3. The new segment is created and added 4. The

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fixes #EXT-X-PROGRAM-DATE-TIME value of existing segments from getting over written with new value when appending new segments to an existing playlist file

2020-11-24 Thread Steven Liu
Vignesh Ravichandran 于2020年11月21日周六 下午11:22写道: > > Signed-off-by: Vignesh Ravichandran > --- > libavformat/hlsenc.c | 35 +++ > 1 file changed, 31 insertions(+), 4 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index

Re: [FFmpeg-devel] [PATCH] avformat/flacenc: Fix memleak when writing attached pictures fails

2020-11-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The FLAC muxer currently stores an attached picture corresponding to an > AVStream in AVStream.priv_data. The AVPacket contained therein is > unreferenced after it has been written. The AVPacket structure itself is > then freed generically as AVStream.priv_data. > > And this

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/mpeg12enc: Deprecate using MPEG-2 intra VLC table for mpeg1video

2020-11-24 Thread Andreas Rheinhardt
Marton Balint: > > > On Tue, 24 Nov 2020, James Almer wrote: > >> On 11/24/2020 11:41 AM, Andreas Rheinhardt wrote: >>> This option just creates broken output because an MPEG-1 bitstream >>> can't signal whether MPEG-2 intra VLC tables have been used. > > If the output was really broken with

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/mpeg12enc: Deprecate using MPEG-2 intra VLC table for mpeg1video

2020-11-24 Thread Andreas Rheinhardt
James Almer: > On 11/24/2020 11:41 AM, Andreas Rheinhardt wrote: >> This option just creates broken output because an MPEG-1 bitstream >> can't signal whether MPEG-2 intra VLC tables have been used. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> Missing version bump. >> >>   doc/APIchanges 

Re: [FFmpeg-devel] [PATCH v2 030/162] avcodec/rv10: Make initializing static RV10 VLCs thread-safe

2020-11-24 Thread Andreas Rheinhardt
Moritz Barsnick: > On Fri, Nov 20, 2020 at 08:19:03 +0100, Andreas Rheinhardt wrote: >> +static av_cold void rv10_init_static(void) >> +{ >> +INIT_VLC_STATIC(_dc_lum, DC_VLC_BITS, 256, >> +rv_lum_bits, 1, 1, >> +rv_lum_code, 2, 2, 16384); >>

Re: [FFmpeg-devel] [PATCH] avfilter: add asupcut filter

2020-11-24 Thread Moritz Barsnick
On Mon, Nov 23, 2020 at 19:52:23 +0100, Paul B Mahol wrote: > +@item cutoff > +Set cutoff frequency in herz. Allowed range is 2 to 192000. Nit: Hertz (with "tz" and capitalized). Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] libavformat/avidec.c: remove duplicated conversion

2020-11-24 Thread Michael Niedermayer
On Mon, Nov 23, 2020 at 10:54:58AM -0800, Thierry Foucu wrote: > ff_riff_info_conv deals with riff metadata already, so, not need to add > those metadata in avi_metadata_conv > --- > libavformat/avidec.c | 8 > 1 file changed, 8 deletions(-) > > diff --git a/libavformat/avidec.c

Re: [FFmpeg-devel] [PATCH v2 030/162] avcodec/rv10: Make initializing static RV10 VLCs thread-safe

2020-11-24 Thread Moritz Barsnick
On Fri, Nov 20, 2020 at 08:19:03 +0100, Andreas Rheinhardt wrote: > +static av_cold void rv10_init_static(void) > +{ > +INIT_VLC_STATIC(_dc_lum, DC_VLC_BITS, 256, > +rv_lum_bits, 1, 1, > +rv_lum_code, 2, 2, 16384); > +

Re: [FFmpeg-devel] New Ticket #9006

2020-11-24 Thread Marton Balint
On Tue, 24 Nov 2020, Deep Thought wrote: I have opened a ticket explaining a problem with the code for merge_pmt_versions. Attached is also a patch which fixes this problem. The main idea is the following: for the INITIAL pmt, the old code finds matching streams by 1) checking the

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/mpeg12enc: Deprecate using MPEG-2 intra VLC table for mpeg1video

2020-11-24 Thread Marton Balint
On Tue, 24 Nov 2020, James Almer wrote: On 11/24/2020 11:41 AM, Andreas Rheinhardt wrote: This option just creates broken output because an MPEG-1 bitstream can't signal whether MPEG-2 intra VLC tables have been used. If the output was really broken with this option then IMHO the

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/mpeg12enc: Deprecate using MPEG-2 intra VLC table for mpeg1video

2020-11-24 Thread James Almer
On 11/24/2020 11:41 AM, Andreas Rheinhardt wrote: This option just creates broken output because an MPEG-1 bitstream can't signal whether MPEG-2 intra VLC tables have been used. Signed-off-by: Andreas Rheinhardt --- Missing version bump. doc/APIchanges | 3 +++

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/mpeg12enc: Use ff_thread_once() for static initializations

2020-11-24 Thread Michael Niedermayer
On Tue, Nov 24, 2020 at 03:41:20PM +0100, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpeg12enc.c | 20 > 1 file changed, 12 insertions(+), 8 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/mpeg12enc: Always initialize MPEG-2 intra VLC table lengths

2020-11-24 Thread Michael Niedermayer
On Tue, Nov 24, 2020 at 03:41:19PM +0100, Andreas Rheinhardt wrote: > The MPEG-1/2 encoders initialize several tables once during the first > time one of the encoders is initialized; the table for MPEG-2 intra VLC > lengths is only initialized if it is used for this encoder instance. > This

[FFmpeg-devel] [PATCH 4/4] avcodec/mpeg12enc: Deprecate using MPEG-2 intra VLC table for mpeg1video

2020-11-24 Thread Andreas Rheinhardt
This option just creates broken output because an MPEG-1 bitstream can't signal whether MPEG-2 intra VLC tables have been used. Signed-off-by: Andreas Rheinhardt --- Missing version bump. doc/APIchanges | 3 +++ libavcodec/mpeg12enc.c | 7 +-- 2 files changed, 8 insertions(+), 2

[FFmpeg-devel] [PATCH 3/4] avcodec/mpeg12enc: Reindentation

2020-11-24 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12enc.c | 114 - 1 file changed, 55 insertions(+), 59 deletions(-) diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c index b069f2db64..2466db8a91 100644 --- a/libavcodec/mpeg12enc.c +++

[FFmpeg-devel] [PATCH 2/4] avcodec/mpeg12enc: Use ff_thread_once() for static initializations

2020-11-24 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12enc.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c index eee4af0adc..b069f2db64 100644 --- a/libavcodec/mpeg12enc.c +++ b/libavcodec/mpeg12enc.c @@

[FFmpeg-devel] [PATCH 1/4] avcodec/mpeg12enc: Always initialize MPEG-2 intra VLC table lengths

2020-11-24 Thread Andreas Rheinhardt
The MPEG-1/2 encoders initialize several tables once during the first time one of the encoders is initialized; the table for MPEG-2 intra VLC lengths is only initialized if it is used for this encoder instance. This implies that if the first MPEG-1/2 encoder to be initialized does not use it, it

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fixes #EXT-X-PROGRAM-DATE-TIME value of existing segments from getting over written with new value when appending new segments to an existing playlist file

2020-11-24 Thread Vignesh Ravichandran
Friendly reminder for review. Thank you. Thanks, Vignesh On Sat, Nov 21, 2020 at 8:44 PM Vignesh Ravichandran < vignesh.ravichandra...@gmail.com> wrote: > Signed-off-by: Vignesh Ravichandran > --- > libavformat/hlsenc.c | 35 +++ > 1 file changed, 31

Re: [FFmpeg-devel] [PATCH] avcodec/dxva2_av1: use correct grain parameters with update_grain = 0

2020-11-24 Thread Guangxin Xu
Hi Hendrik, two related questions: 1. Seems it's a generic code. Could we handle this in the av1dec.c? 2. For the current code, what's happened if frame A ref to B, B ref to C. and both A, B has update_grain == 0. thanks On Tue, Nov 24, 2020 at 4:42 AM James Almer wrote: > On 11/23/2020 8:38

Re: [FFmpeg-devel] [PATCH 0/6] Add support for utilizing av1c as extradata

2020-11-24 Thread Jan Ekström
On Mon, Nov 23, 2020 at 10:11 PM James Almer wrote: > > On 11/23/2020 4:10 PM, Jan Ekström wrote: > > Until now an API user with a non-libavformat MP4 or Matroska demuxer > > would have had to manually filter the extradata to skip the first four > > bytes when passing data to libavcodec, so that