[FFmpeg-devel] [PATCH v2] avcodec/mpegvideo_motion: Improve check to remove dead code

2021-02-04 Thread Andreas Rheinhardt
Several compile-time checks can be improved because mcsel is not used for MPEG-1/2 (it is only used for MPEG-4) and because MPEG-1/2 is the only user of ff_mpv_motion that uses MV_TYPE_16X8 and MV_TYPE_DMV. Signed-off-by: Andreas Rheinhardt --- Fixed a precedence issue in the first hunk below.

Re: [FFmpeg-devel] [PATCH 2/6] ffbuild/common: Make deletion of templates possible

2021-02-04 Thread Andreas Rheinhardt
Andreas Rheinhardt: > If a target to be built includes a template file, the target's .d file > includes the template file as a prerequisite; if the code were changed so > that the template file no longer exists, one would get an error from > make that it has no rule for the template file target.

Re: [FFmpeg-devel] [PATCH v3] ffmpeg: add -fpsmax to clamp output framerate

2021-02-04 Thread Gyan Doshi
Will push in 12h if no further changes. On 03-02-2021 07:42 pm, Gyan Doshi wrote: Useful when encoding in batch or with aberrant inputs. --- doc/ffmpeg.texi | 7 +++ fftools/ffmpeg.c | 7 ++- fftools/ffmpeg.h | 3 +++ fftools/ffmpeg_opt.c | 23

Re: [FFmpeg-devel] [PATCH] libavcodec/gifenc: Only write palette entries that actually used

2021-02-04 Thread Andreas Rheinhardt
Derek Buitenhuis: > On 04/02/2021 17:26, Paul B Mahol wrote: >> How would that work? >> I'm not against if that does not break existing usage. > > Somethng like '-no_global_paltte 1' to not use a global > palette, and write a palette each frame. Default would be > off, so curent behavior is

Re: [FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-04 Thread Bohan Li
Thanks for the review! Indeed the buf string does not play any role here. I have removed it in the new patch. Bohan On Thu, Feb 4, 2021 at 1:02 PM Bohan Li wrote: > This key & value API can greatly help with users who wants to try > libaom-av1 specific options that are not supported by ffmpeg

Re: [FFmpeg-devel] [PATCH 8/8] avformat/nutdec: Check timebase count against main header length

2021-02-04 Thread Michael Niedermayer
On Sat, Dec 19, 2020 at 12:22:08AM +0100, Michael Niedermayer wrote: > Fixes: Timeout (long -> 3ms) > Fixes: > 28514/clusterfuzz-testcase-minimized-ffmpeg_dem_NUT_fuzzer-6078669009321984 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/cdxl: rework probe and fix sample rate and frame rate

2021-02-04 Thread Paul B Mahol
That file is simply broken. On Thu, Feb 4, 2021 at 10:38 PM Michael Niedermayer wrote: > On Wed, Feb 03, 2021 at 11:58:25PM +, Paul B Mahol wrote: > > ffmpeg | branch: master | Paul B Mahol | Wed Feb 3 > 23:06:51 2021 +0100| [a8b3a51790bf5bcc498844e1cd6f0097ecb455c1] | > committer: Paul B

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/cdxl: rework probe and fix sample rate and frame rate

2021-02-04 Thread Michael Niedermayer
On Wed, Feb 03, 2021 at 11:58:25PM +, Paul B Mahol wrote: > ffmpeg | branch: master | Paul B Mahol | Wed Feb 3 > 23:06:51 2021 +0100| [a8b3a51790bf5bcc498844e1cd6f0097ecb455c1] | committer: > Paul B Mahol > > avformat/cdxl: rework probe and fix sample rate and frame rate > > >

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/vp9dsp_template: Fix integer overflows in itxfm_wrapper

2021-02-04 Thread Michael Niedermayer
On Mon, Nov 23, 2020 at 01:42:59AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147483641 + 32 cannot be represented in type > 'int' > Fixes: > 27452/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP9_fuzzer-5078752576667648 > > Found-by: continuous fuzzing process >

[FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-04 Thread Bohan Li
This key & value API can greatly help with users who wants to try libaom-av1 specific options that are not supported by ffmpeg options. As was previously discussed in this thread: https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2020-October/271658. The commit that added the API to libaom:

Re: [FFmpeg-devel] [PATCH 4/8] avformat/mxfdec: Fix file position addition

2021-02-04 Thread James Almer
On 2/4/2021 3:43 PM, Tomas Härdin wrote: mån 2021-02-01 klockan 23:31 +0100 skrev Michael Niedermayer: Not sure this is the best solution, maybe a more general solution limiting the avio_tell() output to less than 63bit would be a better option Probably, since this is likely to happen in more

[FFmpeg-devel] [PATCH 06/50] avcodec/mpegvideo_enc: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavcodec/mpegvideo_enc.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 34dcf8c313..411cadeae7 100644 --- a/libavcodec/mpegvideo_enc.c +++

[FFmpeg-devel] [PATCH 07/50] avcodec/pthread_frame: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavcodec/pthread_frame.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c index 4429a4d59c..7bcb9a7bcc 100644 --- a/libavcodec/pthread_frame.c +++

[FFmpeg-devel] [PATCH 01/50] avcodec/packet: deprecate av_init_packet()

2021-02-04 Thread James Almer
Once removed, sizeof(AVPacket) will stop being a part of the public ABI. Signed-off-by: James Almer --- libavcodec/avpacket.c | 23 +++ libavcodec/packet.h| 23 +++ libavcodec/version.h | 3 +++ libavformat/avformat.h | 4 4 files changed,

[FFmpeg-devel] [PATCH 08/50] avcodec/tdsc: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavcodec/tdsc.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavcodec/tdsc.c b/libavcodec/tdsc.c index 7c888b6ec8..9e7381c2bb 100644 --- a/libavcodec/tdsc.c +++ b/libavcodec/tdsc.c @@ -53,6 +53,7 @@ typedef struct

[FFmpeg-devel] [PATCH 05/50] avcodec/libxvid: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavcodec/libxvid.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c index 857077dc3b..d880558893 100644 --- a/libavcodec/libxvid.c +++ b/libavcodec/libxvid.c @@ -685,10 +685,12 @@

[FFmpeg-devel] [PATCH 10/50] avcodec/webp: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavcodec/webp.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/libavcodec/webp.c b/libavcodec/webp.c index 6de6a5c036..5a7aebc587 100644 --- a/libavcodec/webp.c +++ b/libavcodec/webp.c @@ -189,6 +189,7 @@ typedef

[FFmpeg-devel] [PATCH 50/50] fftools/ffplay: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- fftools/ffplay.c | 204 +-- 1 file changed, 127 insertions(+), 77 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 9ff0425163..d48edc0797 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -36,6

[FFmpeg-devel] [PATCH 49/50] fftools/ffmpeg: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- fftools/ffmpeg.c | 318 +++ fftools/ffmpeg.h | 4 + fftools/ffmpeg_opt.c | 5 +- 3 files changed, 177 insertions(+), 150 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index d7c833be63..2667f226b4

[FFmpeg-devel] [PATCH 48/50] fftools/ffprobe: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- fftools/ffprobe.c | 34 +++--- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 3453aa09ff..68fecd61e5 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -2465,14 +2465,12

[FFmpeg-devel] [PATCH 47/50] doc/examples/vaapi_transcode: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- doc/examples/vaapi_transcode.c | 45 -- 1 file changed, 26 insertions(+), 19 deletions(-) diff --git a/doc/examples/vaapi_transcode.c b/doc/examples/vaapi_transcode.c index 279d20f636..5fc09dd1d3 100644 ---

[FFmpeg-devel] [PATCH 46/50] doc/examples/vaapi_encode: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- doc/examples/vaapi_encode.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/doc/examples/vaapi_encode.c b/doc/examples/vaapi_encode.c index 707939db37..66cb949cdc 100644 --- a/doc/examples/vaapi_encode.c +++

[FFmpeg-devel] [PATCH 45/50] doc/examples/transcoding: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- doc/examples/transcoding.c | 48 ++ 1 file changed, 28 insertions(+), 20 deletions(-) diff --git a/doc/examples/transcoding.c b/doc/examples/transcoding.c index 5aff08c135..6ca3089330 100644 --- a/doc/examples/transcoding.c +++

[FFmpeg-devel] [PATCH 44/50] doc/examples/transcode_aac: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- doc/examples/transcode_aac.c | 46 +--- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c index e0c76f5b35..73786ab59b 100644 ---

[FFmpeg-devel] [PATCH 43/50] doc/examples/demuxing_decoding: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- doc/examples/demuxing_decoding.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/doc/examples/demuxing_decoding.c b/doc/examples/demuxing_decoding.c index 803e35d25c..db5e0cb951 100644 ---

[FFmpeg-devel] [PATCH 42/50] tests/api/api-flac-test: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- tests/api/api-flac-test.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/tests/api/api-flac-test.c b/tests/api/api-flac-test.c index 3fea3258f3..4ce62ed8ba 100644 --- a/tests/api/api-flac-test.c +++

[FFmpeg-devel] [PATCH 41/50] tools/target_bsf_fuzzer: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- tools/target_bsf_fuzzer.c | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/tools/target_bsf_fuzzer.c b/tools/target_bsf_fuzzer.c index 8781a93ac3..bab809162a 100644 --- a/tools/target_bsf_fuzzer.c +++

[FFmpeg-devel] [PATCH 40/50] tools/target_dem_fuzzer: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- tools/target_dem_fuzzer.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/tools/target_dem_fuzzer.c b/tools/target_dem_fuzzer.c index 8ff98af945..af1840b359 100644 --- a/tools/target_dem_fuzzer.c +++ b/tools/target_dem_fuzzer.c @@

[FFmpeg-devel] [PATCH 39/50] tools/target_dec_fuzzer: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- tools/target_dec_fuzzer.c | 73 +++ 1 file changed, 36 insertions(+), 37 deletions(-) diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c index affa6e3b51..84e59000b8 100644 --- a/tools/target_dec_fuzzer.c +++

[FFmpeg-devel] [PATCH 38/50] tools/pktdumper: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- tools/pktdumper.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/tools/pktdumper.c b/tools/pktdumper.c index 16a965b756..c51f5c8922 100644 --- a/tools/pktdumper.c +++ b/tools/pktdumper.c @@ -54,7 +54,7 @@ int main(int

[FFmpeg-devel] [PATCH 37/50] avfilter/vf_uspp: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavfilter/vf_uspp.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_uspp.c b/libavfilter/vf_uspp.c index 8b39f53c3d..8c75207593 100644 --- a/libavfilter/vf_uspp.c +++ b/libavfilter/vf_uspp.c @@ -51,6 +51,7 @@

[FFmpeg-devel] [PATCH 36/50] avfilter/vf_mcdeint: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavfilter/vf_mcdeint.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_mcdeint.c b/libavfilter/vf_mcdeint.c index bc7b3230d3..26baf94adb 100644 --- a/libavfilter/vf_mcdeint.c +++ b/libavfilter/vf_mcdeint.c @@ -74,6

[FFmpeg-devel] [PATCH 35/50] avdevice/xcbgrab: stop using av_init_packet()

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavdevice/xcbgrab.c | 4 1 file changed, 4 deletions(-) diff --git a/libavdevice/xcbgrab.c b/libavdevice/xcbgrab.c index 95bdc8ab9d..908e189b35 100644 --- a/libavdevice/xcbgrab.c +++ b/libavdevice/xcbgrab.c @@ -184,8 +184,6 @@ static int

[FFmpeg-devel] [PATCH 34/50] avdevice/decklink_dec: stop using av_init_packet()

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- I only removed the calls to av_init_packet() here because i can't test this code at all, so i'll leave it to the maintainer. libavdevice/decklink_dec.cpp | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/libavdevice/decklink_dec.cpp

[FFmpeg-devel] [PATCH 33/50] avformat/tests/movenc: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/tests/movenc.c | 81 -- 1 file changed, 42 insertions(+), 39 deletions(-) diff --git a/libavformat/tests/movenc.c b/libavformat/tests/movenc.c index 1d15d97ad9..04155dde76 100644 --- a/libavformat/tests/movenc.c +++

[FFmpeg-devel] [PATCH 32/50] avformat/tests/fifo_muxer: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/tests/fifo_muxer.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/libavformat/tests/fifo_muxer.c b/libavformat/tests/fifo_muxer.c index 5127a8aadb..3458c3eefd 100644 ---

[FFmpeg-devel] [PATCH 31/50] avformat/wc3movie: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/wc3movie.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/libavformat/wc3movie.c b/libavformat/wc3movie.c index 76e945d261..1fe582945a 100644 --- a/libavformat/wc3movie.c +++ b/libavformat/wc3movie.c @@ -69,7

[FFmpeg-devel] [PATCH 30/50] avformat/subtitles: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/jacosubdec.c | 2 +- libavformat/mpeg.c | 4 +-- libavformat/mpsubdec.c | 4 +-- libavformat/subtitles.c | 64 +++- libavformat/subtitles.h | 2 +- libavformat/tedcaptionsdec.c | 4 +--

[FFmpeg-devel] [PATCH 27/50] avformat/rtpdec: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/rtpdec.c| 2 +- libavformat/rtpdec_qt.c | 63 - 2 files changed, 38 insertions(+), 27 deletions(-) diff --git a/libavformat/rtpdec.c b/libavformat/rtpdec.c index d592e34893..fd4601e654 100644 ---

[FFmpeg-devel] [PATCH 29/50] avformat/utils: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/internal.h | 1 + libavformat/options.c | 5 ++- libavformat/utils.c| 100 +++-- 3 files changed, 62 insertions(+), 44 deletions(-) diff --git a/libavformat/internal.h b/libavformat/internal.h index

[FFmpeg-devel] [PATCH 28/50] avformat/rtpenc_mpegts: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/rtpenc_mpegts.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/libavformat/rtpenc_mpegts.c b/libavformat/rtpenc_mpegts.c index 7d7377db7a..50cebf68a3 100644 --- a/libavformat/rtpenc_mpegts.c +++

[FFmpeg-devel] [PATCH 23/50] avformat/mux: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/internal.h | 5 + libavformat/mux.c | 44 ++ libavformat/options.c | 6 ++ libavformat/utils.c| 1 + 4 files changed, 35 insertions(+), 21 deletions(-) diff --git a/libavformat/internal.h

[FFmpeg-devel] [PATCH 24/50] avformat/movenc: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/movenc.c | 116 --- libavformat/movenc.h | 4 +- libavformat/movenchint.c | 19 --- 3 files changed, 85 insertions(+), 54 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index

[FFmpeg-devel] [PATCH 22/50] avformat/matroskaenc: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/matroskaenc.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 233c472b8f..012442f7f2 100644 --- a/libavformat/matroskaenc.c +++

[FFmpeg-devel] [PATCH 26/50] avformat/mpegtsenc: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/mpegtsenc.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 45f8d5f373..baf303dc60 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@

[FFmpeg-devel] [PATCH 25/50] avformat/mpegts: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/mpegts.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index e283ec09d7..6e0d9d7496 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@

[FFmpeg-devel] [PATCH 21/50] avformat/matroskadec: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/matroskadec.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 374831baa3..9fad78c78b 100644 --- a/libavformat/matroskadec.c +++

[FFmpeg-devel] [PATCH 20/50] avformat/hls: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/hls.c | 73 +-- 1 file changed, 39 insertions(+), 34 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index af2468ad9b..dfc91fd5cb 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@

[FFmpeg-devel] [PATCH 19/50] avformat/flacdec: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/flacdec.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/libavformat/flacdec.c b/libavformat/flacdec.c index 6aca4755a1..7852a79d39 100644 --- a/libavformat/flacdec.c +++ b/libavformat/flacdec.c @@ -259,7

[FFmpeg-devel] [PATCH 18/50] avformat/id3v2: replace call to av_init_packet()

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/id3v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c index 97f6cc8a68..3800f21ef9 100644 --- a/libavformat/id3v2.c +++ b/libavformat/id3v2.c @@ -1159,7 +1159,7 @@ int

[FFmpeg-devel] [PATCH 17/50] avformat/flac_picture: replace call to av_init_packet()

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/flac_picture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/flac_picture.c b/libavformat/flac_picture.c index 53e24b28b7..f15cfa877a 100644 --- a/libavformat/flac_picture.c +++ b/libavformat/flac_picture.c @@ -165,7

[FFmpeg-devel] [PATCH 16/50] avformat/dv: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- This one must be committed after the upcoming major bump, as it changes the return value of an avpriv function. libavdevice/iec61883.c | 2 +- libavformat/dv.c | 56 -- 2 files changed, 38 insertions(+), 20

[FFmpeg-devel] [PATCH 15/50] avformat/avienc: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/avienc.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/libavformat/avienc.c b/libavformat/avienc.c index 1b2cb529b9..58bd081fcb 100644 --- a/libavformat/avienc.c +++ b/libavformat/avienc.c @@ -85,6 +85,8 @@

[FFmpeg-devel] [PATCH 14/50] avformat/avidec: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/avidec.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/libavformat/avidec.c b/libavformat/avidec.c index 79000f3e81..0dd447aa7f 100644 --- a/libavformat/avidec.c +++ b/libavformat/avidec.c @@ -59,7 +59,7

[FFmpeg-devel] [PATCH 13/50] avformat/asfdec_o: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/asfdec_o.c | 63 -- 1 file changed, 36 insertions(+), 27 deletions(-) diff --git a/libavformat/asfdec_o.c b/libavformat/asfdec_o.c index c1d90360b4..34ae541934 100644 --- a/libavformat/asfdec_o.c +++

[FFmpeg-devel] [PATCH 12/50] avformat/amvenc: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavformat/amvenc.c | 41 + 1 file changed, 25 insertions(+), 16 deletions(-) diff --git a/libavformat/amvenc.c b/libavformat/amvenc.c index 4d4ec7a2b1..5d13b618f4 100644 --- a/libavformat/amvenc.c +++

[FFmpeg-devel] [PATCH 09/50] avcodec/tiff: use av_packet_alloc() to allocate AVPackets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavcodec/tiff.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index f68f9818ad..c92c4170ab 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@ -58,6 +58,7 @@ typedef struct

[FFmpeg-devel] [PATCH 11/50] avcodec/tests/avpacket: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavcodec/tests/avpacket.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/libavcodec/tests/avpacket.c b/libavcodec/tests/avpacket.c index 90b72341f4..7a70ade4c3 100644 --- a/libavcodec/tests/avpacket.c +++

[FFmpeg-devel] [PATCH 04/50] avcodec/mmal: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavcodec/mmaldec.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/libavcodec/mmaldec.c b/libavcodec/mmaldec.c index cb15ac072a..ed51d74de5 100644 --- a/libavcodec/mmaldec.c +++ b/libavcodec/mmaldec.c @@ -776,12 +776,17 @@

[FFmpeg-devel] [PATCH 03/50] avcodec/frame_thread_encoder: remove av_init_packet() call

2021-02-04 Thread James Almer
The packet was allocated with av_packet_alloc(), so it's redundant. Signed-off-by: James Almer --- libavcodec/frame_thread_encoder.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/frame_thread_encoder.c b/libavcodec/frame_thread_encoder.c index

[FFmpeg-devel] [PATCH 02/50] avcodec/cri: use av_packet_alloc() to allocate packets

2021-02-04 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cri.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/libavcodec/cri.c b/libavcodec/cri.c index efbccf4fee..8aadab7703 100644 --- a/libavcodec/cri.c +++ b/libavcodec/cri.c @@ -37,6 +37,7 @@ typedef struct

[FFmpeg-devel] [PATCH 00/50 v2] deprecate av_init_packet() and sizeof(AVPacket) as part of the ABI

2021-02-04 Thread James Almer
As the subject says, this puts AVPacket in line with AVFrame, allowing easier extensibility of the struct, and preventing some corner cases when packets are used uninitialized on stack. Compared to V1, i included the entire set here, plus a few changes to ffplay and avformat/utils. This removes

Re: [FFmpeg-devel] [PATCH 4/8] avformat/mxfdec: Fix file position addition

2021-02-04 Thread Tomas Härdin
mån 2021-02-01 klockan 23:31 +0100 skrev Michael Niedermayer: > Not sure this is the best solution, maybe a more general solution > limiting the avio_tell() output to less than 63bit would be a better > option Probably, since this is likely to happen in more places > Fixes: signed integer

Re: [FFmpeg-devel] [PATCH] libavcodec/gifenc: Only write palette entries that actually used

2021-02-04 Thread Derek Buitenhuis
On 04/02/2021 17:26, Paul B Mahol wrote: > How would that work? > I'm not against if that does not break existing usage. Somethng like '-no_global_paltte 1' to not use a global palette, and write a palette each frame. Default would be off, so curent behavior is maintained. - Derek

Re: [FFmpeg-devel] [PATCH v7 3/3] avformat/mxfenc: prefer to use the configured metadata

2021-02-04 Thread Tomas Härdin
tis 2021-02-02 klockan 20:47 +0800 skrev lance.lmw...@gmail.com: > From: Limin Wang > > The metadata company_name, product_name, product_version from input > file will be deleted to avoid overwriting information > Please to test with below commands: > ./ffmpeg -i ../fate-suite/mxf/Sony-1.mxf

Re: [FFmpeg-devel] [PATCH v7 2/3] avformat/mxf: add platform local tag

2021-02-04 Thread Tomas Härdin
tis 2021-02-02 klockan 20:47 +0800 skrev lance.lmw...@gmail.com: > From: Limin Wang > > Please check the string of platform with below command: > ./ffmpeg -i ../fate-suite/mxf/Sony-1.mxf -c:v copy -c:a copy out.mxf > ./ffmpeg -i out.mxf > > application_platform: Lavf (linux) > >

Re: [FFmpeg-devel] [PATCH v7 1/3] avformat/mxfdec: set toolkit version metadata

2021-02-04 Thread Tomas Härdin
tis 2021-02-02 klockan 20:47 +0800 skrev lance.lmw...@gmail.com: > From: Limin Wang > > Please check the string of toolkit version with below command: > ./ffmpeg -i ../fate-suite/mxf/Sony-1.mxf -c:v copy -c:a copy out.mxf > ./ffmpeg -i out.mxf > > toolkit_version : 58.65.101.0.0 > >

Re: [FFmpeg-devel] [PATCH] libavcodec/gifenc: Only write palette entries that actually used

2021-02-04 Thread Paul B Mahol
On Thu, Feb 4, 2021 at 6:15 PM Derek Buitenhuis wrote: > On 04/02/2021 17:09, Derek Buitenhuis wrote: > > Accidentally left it in, removed it now. > > > > Further, I forgot to add re-mapping of the frame values > > for the case where the user-provided palette is not > > front-loaded (e.g. it has

Re: [FFmpeg-devel] [PATCH] libavcodec/gifenc: Only write palette entries that actually used

2021-02-04 Thread Derek Buitenhuis
On 04/02/2021 17:07, Paul B Mahol wrote: > You first init array to 0 and than use memset? Accidentally left it in, removed it now. Further, I forgot to add re-mapping of the frame values for the case where the user-provided palette is not front-loaded (e.g. it has gaps), so I'll send a v2. -

Re: [FFmpeg-devel] [PATCH] libavcodec/gifenc: Only write palette entries that actually used

2021-02-04 Thread Derek Buitenhuis
On 04/02/2021 17:09, Derek Buitenhuis wrote: > Accidentally left it in, removed it now. > > Further, I forgot to add re-mapping of the frame values > for the case where the user-provided palette is not > front-loaded (e.g. it has gaps), so I'll send a v2. Another case to consider is that we

Re: [FFmpeg-devel] [PATCH] libavcodec/gifenc: Only write palette entries that actually used

2021-02-04 Thread Paul B Mahol
On Thu, Feb 4, 2021 at 5:57 PM Derek Buitenhuis wrote: > GIF palette entries are not compressed, and writing 256 entries, > which can be up to every frame, uses a significant amount of > space, especially in extreme cases, where palettes can be very > small. > > Example, first six seconds of

[FFmpeg-devel] [PATCH] libavcodec/gifenc: Only write palette entries that actually used

2021-02-04 Thread Derek Buitenhuis
GIF palette entries are not compressed, and writing 256 entries, which can be up to every frame, uses a significant amount of space, especially in extreme cases, where palettes can be very small. Example, first six seconds of Tears of Steel, palette generated with libimagequant, 320x240

[FFmpeg-devel] [PATCH] avfilter: add colorize filter

2021-02-04 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 27 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_colorize.c | 306 ++ 4 files changed, 335 insertions(+) create mode 100644 libavfilter/vf_colorize.c

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/mxpegdec: fix SOF counting

2021-02-04 Thread Michael Niedermayer
On Thu, Dec 03, 2020 at 10:11:38AM +0100, Michael Niedermayer wrote: > Fixes: Timeout (>10sec -> 15ms) > Fixes: > 27652/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MXPEG_fuzzer-5125920868007936 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/rscc: Check inflated_buf size whan it is used

2021-02-04 Thread Michael Niedermayer
On Sun, Nov 22, 2020 at 04:37:33PM +0100, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 27434/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RSCC_fuzzer-5196757675540480 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/4] Remove unnecessary mem.h inclusions

2021-02-04 Thread Anton Khirnov
Quoting Nicolas George (2021-02-04 15:48:03) > Anton Khirnov (12021-02-04): > > I don't think we have an official project policy on this, but I would > > be in favor of something like: > > > > All installed headers are only guaranteed to provide those > > identifiers that are explicitly

[FFmpeg-devel] [PATCH 4/4] avutil/common: Move everything inside inclusion guards

2021-02-04 Thread Andreas Rheinhardt
libavutil/common.h is a public header that provides generic math functions whereas libavutil/intmath.h is a private header that contains plattform-specific optimized versions of said math functions. common.h includes intmath.h (when building the FFmpeg libraries) so that the optimized versions are

[FFmpeg-devel] [PATCH 3/4] avcodec/mpegvideo_motion: Remove unnecessary headers

2021-02-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_motion.c | 5 - 1 file changed, 5 deletions(-) diff --git a/libavcodec/mpegvideo_motion.c b/libavcodec/mpegvideo_motion.c index aed11dccd7..3f2de29c4e 100644 --- a/libavcodec/mpegvideo_motion.c +++ b/libavcodec/mpegvideo_motion.c @@

[FFmpeg-devel] [PATCH 2/4] avcodec/mpegvideo_motion: Reindentation

2021-02-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_motion.c | 115 +- 1 file changed, 57 insertions(+), 58 deletions(-) diff --git a/libavcodec/mpegvideo_motion.c b/libavcodec/mpegvideo_motion.c index d065542967..aed11dccd7 100644 ---

[FFmpeg-devel] [PATCH 1/4] avcodec/mpegvideo_motion: Improve check to remove dead code

2021-02-04 Thread Andreas Rheinhardt
Several compile-time checks can be improved because mcsel is not used for MPEG-1/2 (it is only used for MPEG-4) and because MPEG-1/2 is the only user of ff_mpv_motion that uses MV_TYPE_16X8 and MV_TYPE_DMV. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_motion.c | 12 1

Re: [FFmpeg-devel] [PATCH 1/4] Remove unnecessary mem.h inclusions

2021-02-04 Thread Nicolas George
Anton Khirnov (12021-02-04): > I don't think we have an official project policy on this, but I would > be in favor of something like: > > All installed headers are only guaranteed to provide those > identifiers that are explicitly declared in them. Users must not > rely on an

Re: [FFmpeg-devel] REQUEST: remove photocd_pipe demuxer as there is no parser

2021-02-04 Thread Jean-Baptiste Kempf
On Thu, 4 Feb 2021, at 15:31, Paul B Mahol wrote: > On Thu, Feb 4, 2021 at 3:25 PM Jean-Baptiste Kempf wrote: > > > On Wed, 3 Feb 2021, at 11:38, Paul B Mahol wrote: > > > I hereby request also to remove commit rights from Carl Eugen Hoyos for > > > committing hacky and broken code. > > > > This

Re: [FFmpeg-devel] REQUEST: remove photocd_pipe demuxer as there is no parser

2021-02-04 Thread James Almer
On 2/3/2021 7:38 AM, Paul B Mahol wrote: This is only some of problems and some of formats I spotted. There was no parser for webp either until i wrote one a few months ago, and lavf had no trouble reading webp images from for example the file protocol. It simply didn't work with non

Re: [FFmpeg-devel] [PATCH 1/4] Remove unnecessary mem.h inclusions

2021-02-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2021-02-04 12:06:15) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2021-02-04 01:05:05) > >> Thanks for the report. I have only checked for whether the relevant > >> translation unit uses any of the alloc/free functions (because > >> DECLARE_ALIGNED is already

Re: [FFmpeg-devel] REQUEST: remove photocd_pipe demuxer as there is no parser

2021-02-04 Thread Paul B Mahol
On Thu, Feb 4, 2021 at 3:25 PM Jean-Baptiste Kempf wrote: > On Wed, 3 Feb 2021, at 11:38, Paul B Mahol wrote: > > I hereby request also to remove commit rights from Carl Eugen Hoyos for > > committing hacky and broken code. > > This is not the right tone for this mailing list. > I said nothing

Re: [FFmpeg-devel] REQUEST: remove photocd_pipe demuxer as there is no parser

2021-02-04 Thread Jean-Baptiste Kempf
On Wed, 3 Feb 2021, at 11:38, Paul B Mahol wrote: > I hereby request also to remove commit rights from Carl Eugen Hoyos for > committing hacky and broken code. This is not the right tone for this mailing list. -- Jean-Baptiste Kempf - President +33 672 704 734

Re: [FFmpeg-devel] [PATCH] avformat: add binka demuxer

2021-02-04 Thread Paul B Mahol
Will apply soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/af_amix: add sum option

2021-02-04 Thread Paul B Mahol
Will apply soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/4] Remove unnecessary mem.h inclusions

2021-02-04 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2021-02-04 01:05:05) >> Thanks for the report. I have only checked for whether the relevant >> translation unit uses any of the alloc/free functions (because >> DECLARE_ALIGNED is already provided by mem_internal.h), but I have not >> taken into account

[FFmpeg-devel] [PATCH v2 4/4] avcodec/aarch64/hevcdsp: add sao_band NEON

2021-02-04 Thread Josh Dekker
Only works for 8x8. Signed-off-by: Josh Dekker --- libavcodec/aarch64/Makefile | 3 +- libavcodec/aarch64/hevcdsp_init_aarch64.c | 7 ++ libavcodec/aarch64/hevcdsp_sao_neon.S | 87 +++ 3 files changed, 96 insertions(+), 1 deletion(-) create mode 100644

[FFmpeg-devel] [PATCH v2 1/4] avcodec/aarch64/hevcdsp: port SIMD idct functions

2021-02-04 Thread Josh Dekker
From: Reimar Döffinger Makes SIMD-optimized 8x8 and 16x16 idcts for 8 and 10 bit depth available on aarch64. For a UHD HDR (10 bit) sample video these were consuming the most time and this optimization reduced overall decode time from 19.4s to 16.4s, approximately 15% speedup. Test sample was

[FFmpeg-devel] [PATCH v2 2/4] avcodec/aarch64/hevcdsp: port add_residual functions

2021-02-04 Thread Josh Dekker
From: Reimar Döffinger Speedup is fairly small, around 1.5%, but these are fairly simple. Signed-off-by: Josh Dekker --- libavcodec/aarch64/hevcdsp_idct_neon.S| 190 ++ libavcodec/aarch64/hevcdsp_init_aarch64.c | 24 +++ 2 files changed, 214 insertions(+) diff --git

[FFmpeg-devel] [PATCH v2 3/4] avcodec/aarch64/hevcdsp: add idct_dc NEON

2021-02-04 Thread Josh Dekker
Signed-off-by: Josh Dekker --- libavcodec/aarch64/hevcdsp_idct_neon.S| 54 +++ libavcodec/aarch64/hevcdsp_init_aarch64.c | 16 +++ 2 files changed, 70 insertions(+) diff --git a/libavcodec/aarch64/hevcdsp_idct_neon.S b/libavcodec/aarch64/hevcdsp_idct_neon.S index

[FFmpeg-devel] [PATCH v2 0/4] avcodec/aarch64/hevcdsp

2021-02-04 Thread Josh Dekker
Hi, Rebases the unpushed part of my patches on top of Reimar's set. Also implements Martin's suggestions except 'unrolling the loop' for SAO band function, will update the band function when I fix non 8x8 cases. -- Josh ___ ffmpeg-devel mailing

[FFmpeg-devel] Re: [PATCH 1/3] avcodec/mjpegdec: Cleanup ff_smvjpeg_decoder()

2021-02-04 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-12-20 22:15:22) > Fixes: memleaks > Fixes: > 28533/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMVJPEG_fuzzer-6242529653686272 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/hapdec: Check that compressed_offset is non negative

2021-02-04 Thread Anton Khirnov
Quoting Michael Niedermayer (2021-01-30 20:28:26) > Fixes: out of array access > Fixes: > 29345/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HAP_fuzzer-5401813482340352 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

[FFmpeg-devel] Re: [PATCH] fix for https://trac.ffmpeg.org/ticket/9057

2021-02-04 Thread Anton Khirnov
Quoting Carl Eugen Hoyos (2021-02-03 23:05:08) > Am Do., 21. Jan. 2021 um 17:59 Uhr schrieb : > > > > From: KM > > > > --- > > libavcodec/aacdec_template.c | 11 +++ > > 1 file changed, 7 insertions(+), 4 deletions(-) > > > > diff --git a/libavcodec/aacdec_template.c

Re: [FFmpeg-devel] [PATCH 1/4] Remove unnecessary mem.h inclusions

2021-02-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2021-02-04 01:05:05) > Thanks for the report. I have only checked for whether the relevant > translation unit uses any of the alloc/free functions (because > DECLARE_ALIGNED is already provided by mem_internal.h), but I have not > taken into account stuff that is