[FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: fix potential memory leak.

2021-02-16 Thread Wonkap Jang
While parsing ref_frame_config, AVdictionary needs to be manually deallocated. --- libavcodec/libvpxenc.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 284cb9a108..b552590b7b 100644 ---

[FFmpeg-devel] [PATCH v6 5/9] avcodec/h2645_parse: add nal header parser for h266/vvc

2021-02-16 Thread Nuo Mi
--- libavcodec/h2645_parse.c | 74 ++-- 1 file changed, 71 insertions(+), 3 deletions(-) diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c index a36ef4f5a0..35f9d035a9 100644 --- a/libavcodec/h2645_parse.c +++ b/libavcodec/h2645_parse.c @@ -1,5

[FFmpeg-devel] [PATCH v6 0/9] add vvc raw demuxer, muxer, parser, metadata bsf

2021-02-16 Thread Nuo Mi
Changes since v5: Change PSType.name from char* to char[4]. Fix build error for ci(ubuntu 18.04) Mark Thompson (1): cbs_h2645: refact, use cbs_h2645_replace_ps to replace cbs_h26*_replace_*ps Nuo Mi (8): avcodec/vvc: add shared header for vvc avformat: add vvc raw demux avcodec: add

[FFmpeg-devel] [PATCH v6 3/9] avformat: add vvc raw demux

2021-02-16 Thread Nuo Mi
--- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/vvcdec.c | 61 3 files changed, 63 insertions(+) create mode 100644 libavformat/vvcdec.c diff --git a/libavformat/Makefile b/libavformat/Makefile index

[FFmpeg-devel] [PATCH v6 7/9] avformat: add h266/vvc muxer

2021-02-16 Thread Nuo Mi
--- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/rawenc.c | 25 + 3 files changed, 27 insertions(+) diff --git a/libavformat/Makefile b/libavformat/Makefile index 2b9d0eee7f..d3a755a47a 100644 --- a/libavformat/Makefile +++

Re: [FFmpeg-devel] [PATCH v2] avcodec/libvpxenc: fix potential memory leak.

2021-02-16 Thread James Zern
On Tue, Feb 16, 2021 at 2:29 PM Wonkap Jang wrote: > > While parsing ref_frame_config, AVdictionary needs to be manually > deallocated. > --- > libavcodec/libvpxenc.c | 20 +--- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/libvpxenc.c

Re: [FFmpeg-devel] [PATCH v1] avcodec/libvpxenc: fix potential memory leak.

2021-02-16 Thread James Zern
On Tue, Feb 16, 2021 at 4:17 PM Wonkap Jang wrote: > > On Tue, Feb 16, 2021 at 1:02 PM James Zern > wrote: > [...] > > > > > > > > while ((en2 = > > av_dict_get(ctx->vpx_ref_frame_config, "", en2, AV_DICT_IGNORE_SUFFIX))) { > > > @@ -1604,6 +1605,8 @@ static int

[FFmpeg-devel] [PATCH v6 1/9] cbs_h2645: refact, use cbs_h2645_replace_ps to replace cbs_h26*_replace_*ps

2021-02-16 Thread Nuo Mi
From: Mark Thompson --- libavcodec/cbs_h2645.c | 167 +++-- 1 file changed, 126 insertions(+), 41 deletions(-) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index 6005d46e0d..57c419aa05 100644 --- a/libavcodec/cbs_h2645.c +++

[FFmpeg-devel] [PATCH v6 2/9] avcodec/vvc: add shared header for vvc

2021-02-16 Thread Nuo Mi
--- libavcodec/vvc.h | 142 +++ 1 file changed, 142 insertions(+) create mode 100644 libavcodec/vvc.h diff --git a/libavcodec/vvc.h b/libavcodec/vvc.h new file mode 100644 index 00..ca15297d7a --- /dev/null +++ b/libavcodec/vvc.h @@ -0,0

[FFmpeg-devel] [PATCH v6 9/9] avcodec: add vvc metadata bsf

2021-02-16 Thread Nuo Mi
We run following command with all 265 VTM-11.0 clips: ffmpeg -i in.bit -c:v copy -bsf vvc_metadata -f vvc out.bit The output bitstream can get same yuv as original. --- configure | 1 + libavcodec/Makefile| 1 + libavcodec/bitstream_filters.c | 1 +

[FFmpeg-devel] [PATCH v6 8/9] avcodec/cbs_h2645: vvc, do not skip nals for nuh_layer_id > 0

2021-02-16 Thread Nuo Mi
--- libavcodec/cbs_h2645.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index d39464ba49..e46613fab3 100644 --- a/libavcodec/cbs_h2645.c +++ b/libavcodec/cbs_h2645.c @@ -604,8 +604,9 @@ static int

[FFmpeg-devel] [PATCH v6 6/9] avcodec: add vvc parser

2021-02-16 Thread Nuo Mi
--- configure | 1 + libavcodec/Makefile | 1 + libavcodec/parsers.c| 1 + libavcodec/vvc_parser.c | 310 4 files changed, 313 insertions(+) create mode 100644 libavcodec/vvc_parser.c diff --git a/configure b/configure index

Re: [FFmpeg-devel] [PATCH V2 08/10] libavutil: add side data AVDnnBoundingBox for dnn based detect/classify filters

2021-02-16 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Guo, > Yejun > Sent: 2021年2月16日 18:37 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V2 08/10] libavutil: add side data > AVDnnBoundingBox for dnn based detect/classify filters > > > > >

Re: [FFmpeg-devel] [PATCH v1] avcodec/libvpxenc: fix potential memory leak.

2021-02-16 Thread Wonkap Jang
On Tue, Feb 16, 2021 at 1:02 PM James Zern wrote: > Hi, > > On Mon, Feb 15, 2021 at 10:37 PM Wonkap Jang > wrote: > > > > While parsing ref_frame_config, AVdictionary needs to be manually > > deallocated. > > --- > > libavcodec/libvpxenc.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > >

Re: [FFmpeg-devel] [PATCH] fix for https://trac.ffmpeg.org/ticket/9057

2021-02-16 Thread Carl Eugen Hoyos
Am Do., 21. Jan. 2021 um 17:59 Uhr schrieb : > > From: KM > > --- > libavcodec/aacdec_template.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c > index fbe3074..3c2dbe3 100644 > ---

Re: [FFmpeg-devel] [PATCH]libavfi/pseudocolor: Add missing braces around initializers

2021-02-16 Thread Paul B Mahol
On Tue, Feb 16, 2021 at 11:44 PM James Almer wrote: > On 2/16/2021 7:43 PM, Paul B Mahol wrote: > > There are already 3 variants of this patch on list. > > Can you apply the first one that's confirmed to be correct? > I use clang 11. compiler ___ >

Re: [FFmpeg-devel] [PATCH]libavfi/pseudocolor: Add missing braces around initializers

2021-02-16 Thread James Almer
On 2/16/2021 7:43 PM, Paul B Mahol wrote: There are already 3 variants of this patch on list. Can you apply the first one that's confirmed to be correct? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH]libavfi/pseudocolor: Add missing braces around initializers

2021-02-16 Thread Paul B Mahol
There are already 3 variants of this patch on list. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

[FFmpeg-devel] [PATCH]libavfi/pseudocolor: Add missing braces around initializers

2021-02-16 Thread Carl Eugen Hoyos
Hi, attached patch fixes many warnings when compiling with gcc 10. Please comment, Carl Eugen From 721a6444d30c65b3bb69e0ef2154bc9b2c2ffa8f Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Tue, 16 Feb 2021 23:36:04 +0100 Subject: [PATCH] lavfi/pseudocolor: Add missing braces around

[FFmpeg-devel] [PATCH v2] avcodec/libvpxenc: fix potential memory leak.

2021-02-16 Thread Wonkap Jang
While parsing ref_frame_config, AVdictionary needs to be manually deallocated. --- libavcodec/libvpxenc.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 284cb9a108..e71ae54f34 100644 ---

[FFmpeg-devel] [PATCH] avfilter/vf_ssim: add slice threading

2021-02-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_ssim.c | 196 ++ 1 file changed, 141 insertions(+), 55 deletions(-) diff --git a/libavfilter/vf_ssim.c b/libavfilter/vf_ssim.c index 4efc807f37..dc0af79dbf 100644 --- a/libavfilter/vf_ssim.c +++

Re: [FFmpeg-devel] [PATCH v1] avcodec/libvpxenc: fix potential memory leak.

2021-02-16 Thread James Zern
Hi, On Mon, Feb 15, 2021 at 10:37 PM Wonkap Jang wrote: > > While parsing ref_frame_config, AVdictionary needs to be manually > deallocated. > --- > libavcodec/libvpxenc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index

Re: [FFmpeg-devel] [PATCH 4/6] Revert "avcodec/pngdec: fix possible race condition with APNG decoding"

2021-02-16 Thread Paul B Mahol
Do you have actual proof for such claims? There is no point in reverting commit if that commit fixed some behavior. On Tue, Feb 16, 2021 at 9:26 PM Anton Khirnov wrote: > This reverts commit 63231fa8d30f41045658d6c382b00fe1ebe18d05. It did not > actually fix the cited issue, nor is the issue a

[FFmpeg-devel] [PATCH] avfilter/vf_psnr: add support for slice threading

2021-02-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_psnr.c | 126 +- 1 file changed, 89 insertions(+), 37 deletions(-) diff --git a/libavfilter/vf_psnr.c b/libavfilter/vf_psnr.c index 0d6bbad42f..0d0c0f35aa 100644 --- a/libavfilter/vf_psnr.c +++

Re: [FFmpeg-devel] [PATCH 2/6] lavc: split LSCR decoder out of PNG decoder

2021-02-16 Thread Paul B Mahol
I do not like this. On Tue, Feb 16, 2021 at 9:26 PM Anton Khirnov wrote: > It shares very little code with pngdec, so keeping them together only > makes the code harder to read. > --- > libavcodec/Makefile | 2 +- > libavcodec/lscrdec.c | 279 +++ >

[FFmpeg-devel] [PATCH 2/6] lavc: split LSCR decoder out of PNG decoder

2021-02-16 Thread Anton Khirnov
It shares very little code with pngdec, so keeping them together only makes the code harder to read. --- libavcodec/Makefile | 2 +- libavcodec/lscrdec.c | 279 +++ libavcodec/png.h | 5 + libavcodec/pngdec.c | 174 +-- 4

[FFmpeg-devel] [PATCH 6/6] tests/fate/apng: add a test for APNG_DISPOSE_OP_PREVIOUS

2021-02-16 Thread Anton Khirnov
--- tests/fate/apng.mak | 3 + tests/ref/fate/apng-dispose-previous | 139 +++ 2 files changed, 142 insertions(+) create mode 100644 tests/ref/fate/apng-dispose-previous diff --git a/tests/fate/apng.mak b/tests/fate/apng.mak index

[FFmpeg-devel] [PATCH 3/6] lavc/lscrdec: drop unapplicable private capabilities

2021-02-16 Thread Anton Khirnov
FF_CODEC_CAP_ALLOCATE_PROGRESS makes no sense because the decoder does not support frame threading. FF_CODEC_CAP_SKIP_FRAME_FILL_PARAM makes no sense because the decoder does not handle skip_frame. --- libavcodec/lscrdec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[FFmpeg-devel] [PATCH 4/6] Revert "avcodec/pngdec: fix possible race condition with APNG decoding"

2021-02-16 Thread Anton Khirnov
This reverts commit 63231fa8d30f41045658d6c382b00fe1ebe18d05. It did not actually fix the cited issue, nor is the issue a race. It will be fixed properly in the following commit. --- libavcodec/pngdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/pngdec.c

[FFmpeg-devel] [PATCH 5/6] pngdec: fix and simplify apng reference handling

2021-02-16 Thread Anton Khirnov
Current code is very confused and confusing. It uses two different reference frames - "previous" and "last" - when only one is really necessary. It also confuses the two, leading to incorrect output with APNG_DISPOSE_OP_PREVIOUS mode. Fixes #9017. --- libavcodec/pngdec.c | 93

[FFmpeg-devel] [PATCH 1/6] tests: add a test for LSCR

2021-02-16 Thread Anton Khirnov
--- tests/fate/video.mak | 3 +++ tests/ref/fate/lscr | 21 + 2 files changed, 24 insertions(+) create mode 100644 tests/ref/fate/lscr diff --git a/tests/fate/video.mak b/tests/fate/video.mak index a5f3107c38..4b2c4ab665 100644 --- a/tests/fate/video.mak +++

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/libopusdec: Enable FEC/PLC

2021-02-16 Thread Lynne
Feb 16, 2021, 20:07 by ceffm...@gmail.com: > Am Di., 16. Feb. 2021 um 15:02 Uhr schrieb Philip-Dylan Gleonec > : > >> >> Adds FEC/PLC support to libopus. The lost packets are detected as a >> discontinuity in the audio stream. When a discontinuity is used, this >> patch tries to decode the FEC

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/libopusdec: Enable FEC/PLC

2021-02-16 Thread Carl Eugen Hoyos
Am Di., 16. Feb. 2021 um 15:02 Uhr schrieb Philip-Dylan Gleonec : > > Adds FEC/PLC support to libopus. The lost packets are detected as a > discontinuity in the audio stream. When a discontinuity is used, this > patch tries to decode the FEC data. If FEC data is present in the > packet, it is

Re: [FFmpeg-devel] [PATCH]lavc/pnm_parser: Add a pfm parser

2021-02-16 Thread Carl Eugen Hoyos
Am Di., 16. Feb. 2021 um 19:28 Uhr schrieb Andreas Rheinhardt : > > Carl Eugen Hoyos: > > Am Di., 16. Feb. 2021 um 00:56 Uhr schrieb Andreas Rheinhardt > > : > >> > >> Carl Eugen Hoyos: > >>> Hi! > >>> > >>> Attached patch is necessary for a new pfm demuxer. > >>> > >>> Please comment, Carl Eugen

Re: [FFmpeg-devel] [PATCH]lavc/pnm_parser: Add a pfm parser

2021-02-16 Thread Andreas Rheinhardt
Carl Eugen Hoyos: > Am Di., 16. Feb. 2021 um 00:56 Uhr schrieb Andreas Rheinhardt > : >> >> Carl Eugen Hoyos: >>> Hi! >>> >>> Attached patch is necessary for a new pfm demuxer. >>> >>> Please comment, Carl Eugen >>> >> Can't we just wait and increment the number of codec_ids >> a parser can

Re: [FFmpeg-devel] [PATCH]lavc/pnm_parser: Add a pfm parser

2021-02-16 Thread Carl Eugen Hoyos
Am Di., 16. Feb. 2021 um 00:56 Uhr schrieb Andreas Rheinhardt : > > Carl Eugen Hoyos: > > Hi! > > > > Attached patch is necessary for a new pfm demuxer. > > > > Please comment, Carl Eugen > > > Can't we just wait and increment the number of codec_ids > a parser can support at the next bump? I

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp8: Move end check into MB loop in vp78_decode_mv_mb_modes()

2021-02-16 Thread Michael Niedermayer
On Tue, Feb 16, 2021 at 06:48:05PM +1100, Peter Ross wrote: > On Mon, Feb 15, 2021 at 09:23:11PM +0100, Michael Niedermayer wrote: > > Fixes: Timeout (long -> 5sec) > > Fixes: > > 30269/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP7_fuzzer-5430325004075008 > > > > Found-by: continuous

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mov: Check element count in mov_metadata_hmmt()

2021-02-16 Thread Michael Niedermayer
On Mon, Feb 15, 2021 at 09:23:12PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 30325/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-6048395703746560 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 3/3] avformat/rmdec: Check codec_length without overflow

2021-02-16 Thread Michael Niedermayer
On Mon, Feb 15, 2021 at 09:38:44PM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: signed integer overflow: 2147483647 + 64 cannot be represented in > > type 'int' > > Fixes: > > 30333/clusterfuzz-testcase-minimized-ffmpeg_dem_RM_fuzzer-5175286983426048 > > > > Found-by:

Re: [FFmpeg-devel] [PATCH] Moves yuv2yuvX_sse3 to yasm, unrolls main loop and other small optimizations for ~20% speedup.

2021-02-16 Thread Alan Kelly
Looks like there are no comments, is this OK to be applied? Thanks On Tue, Feb 9, 2021 at 6:25 PM Paul B Mahol wrote: > Will apply in no comments. > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org >

Re: [FFmpeg-devel] [PATCH v2] hwcontext_vaapi: introduce AV_HWFRAME_MAP_{SEPARATE, COMBINED}_PLANES

2021-02-16 Thread Lynne
Feb 16, 2021, 11:59 by cont...@emersion.fr: > This allows callers to ask for separate or combined plane formats. > > Combined formats are desirable in many scenarios, for instance when > directly importing the DMA-BUFs into APIs such as GL (as a single > EGLImage), KMS or Wayland. > > This patch

Re: [FFmpeg-devel] [PATCH 2/7] tools/target_dec_fuzzer: count all video decoding failures in the new API

2021-02-16 Thread Michael Niedermayer
On Wed, Feb 03, 2021 at 12:13:29AM +0100, Michael Niedermayer wrote: > The next commit depends on this > > Signed-off-by: Michael Niedermayer > --- > tools/target_dec_fuzzer.c | 7 +++ > 1 file changed, 7 insertions(+) will apply [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 7/8] tools/target_dec_fuzzer: Update maxpixels_per_frame for low thresholds

2021-02-16 Thread Michael Niedermayer
On Mon, Feb 01, 2021 at 11:31:15PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 29990/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSS2_fuzzer-5469155073589248 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 4/4] tools/target_dec_fuzzer: Adjust threshold for theora

2021-02-16 Thread Michael Niedermayer
On Sat, Jan 30, 2021 at 04:00:21PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 29226/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_THEORA_fuzzer-6195092572471296 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 3/6] tools/target_dec_fuzzer: adjust threshold for cook

2021-02-16 Thread Michael Niedermayer
On Sat, Jan 23, 2021 at 11:10:53PM +0100, Michael Niedermayer wrote: > Fixes: Timeout (long -> 3ms) > Fixes: > 29134/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_COOK_fuzzer-5192822695264256 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 4/5] tools/target_dec_fuzzer: Adjust threshold for wavpack

2021-02-16 Thread Michael Niedermayer
On Thu, Jan 21, 2021 at 01:03:45AM +0100, Michael Niedermayer wrote: > Fixes: Timeout (long -> 4sec) > Fixes: > 29064/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-5104450901508096 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/5] tools/target_dec_fuzzer: Adjust threshold for MSA1

2021-02-16 Thread Michael Niedermayer
On Thu, Jan 21, 2021 at 01:03:42AM +0100, Michael Niedermayer wrote: > Fixes: Timeout (too long to wait -> 1ms) > Fixes: > 29048/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSA1_fuzzer-5733703473037312 > > Found-by: continuous fuzzing process >

[FFmpeg-devel] Date for dev meeting

2021-02-16 Thread Jean-Baptiste Kempf
Hello, It's been a while since we have had a meeting for quite some time and because FOSDEM did not happen IRL, it would be nice to meet again. Please give your preferences for a date here: https://framadate.org/ffmpeg-dev-2021 Current agenda proposals are open. Thx for voting quickly. --

Re: [FFmpeg-devel] [PATCH] libavfilter: avoid UB nullptr-with-offset.

2021-02-16 Thread Jeremy Leconte
You're right, it's just a case of NULL + 0. The problem is that it gets caught by clang -fsanitize=undefined. On Tue, Feb 16, 2021 at 4:59 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Jeremy Leconte: > > --- > > libavfilter/vf_scale.c | 2 +- > > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH] avcodec/pngdec: use correct frame for none disposition

2021-02-16 Thread Anton Khirnov
Quoting Paul B Mahol (2021-02-14 17:10:19) > Signed-off-by: Paul B Mahol > --- > libavcodec/pngdec.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c > index 61642b7cbe..f0e2a0cad4 100644 > --- a/libavcodec/pngdec.c > +++

Re: [FFmpeg-devel] [PATCH] libavfilter: avoid UB nullptr-with-offset.

2021-02-16 Thread Jeremy Leconte
Andreas Rheinhardt: > Is this just a case of NULL + 0 or is the offset != 0? > > - Andreas > You're right, it's just a case of NULL + 0. My issue is that it gets caught by clang -fsanitize=undefined. Jeremy ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] libavfilter: avoid UB nullptr-with-offset.

2021-02-16 Thread Andreas Rheinhardt
Jeremy Leconte: > --- > libavfilter/vf_scale.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c > index 58eee96744..98cef5eb4b 100644 > --- a/libavfilter/vf_scale.c > +++ b/libavfilter/vf_scale.c > @@ -631,7 +631,7 @@ static

[FFmpeg-devel] [PATCH] libavfilter: avoid UB nullptr-with-offset.

2021-02-16 Thread Jeremy Leconte
--- libavfilter/vf_scale.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index 58eee96744..98cef5eb4b 100644 --- a/libavfilter/vf_scale.c +++ b/libavfilter/vf_scale.c @@ -631,7 +631,7 @@ static int scale_slice(AVFilterLink

Re: [FFmpeg-devel] [PATCH v2] cbs_h2645: Implement replace-PS with a table rather than many functions

2021-02-16 Thread James Almer
On 2/16/2021 12:16 PM, Nuo Mi wrote: On Tue, Feb 16, 2021 at 7:20 AM Mark Thompson wrote: While this is mode source code, it generates less binary code and can be more cleanly extended to H.266. --- On 14/02/2021 19:45, Andreas Rheinhardt wrote: Nuo Mi: From: Mark Thompson Hi Andreas &

Re: [FFmpeg-devel] [PATCH] avfilter/buffersrc: simplify av_buffersrc_add_frame_flags()

2021-02-16 Thread James Almer
On 2/16/2021 12:25 PM, Nicolas George wrote: James Almer (12021-02-07): Signed-off-by: James Almer --- libavfilter/buffersrc.c | 38 -- 1 file changed, 8 insertions(+), 30 deletions(-) Sorry, forgot to look at it. Looks ok, thanks. Regards, Applied,

Re: [FFmpeg-devel] [PATCH] avfilter/buffersrc: simplify av_buffersrc_add_frame_flags()

2021-02-16 Thread Nicolas George
James Almer (12021-02-07): > Signed-off-by: James Almer > --- > libavfilter/buffersrc.c | 38 -- > 1 file changed, 8 insertions(+), 30 deletions(-) Sorry, forgot to look at it. Looks ok, thanks. Regards, -- Nicolas George signature.asc Description:

Re: [FFmpeg-devel] [PATCH v2] cbs_h2645: Implement replace-PS with a table rather than many functions

2021-02-16 Thread Nuo Mi
On Tue, Feb 16, 2021 at 7:20 AM Mark Thompson wrote: > While this is mode source code, it generates less binary code and can be > more cleanly extended to H.266. > --- > On 14/02/2021 19:45, Andreas Rheinhardt wrote: > > Nuo Mi: > >> From: Mark Thompson > > Hi Andreas & Mark, thanks for the

[FFmpeg-devel] [PATCH] avcodec/libopusenc: reload packet loss at encode

2021-02-16 Thread Philip-Dylan Gleonec
An estimation of packet loss is required by libopus to compute its FEC data. Currently, this estimation is constant, and can not be changed after configuration. This means an application using libopus through ffmpeg can not adapt the packet loss estimation when the network quality degrades. This

Re: [FFmpeg-devel] [PATCH] avfilter/buffersrc: simplify av_buffersrc_add_frame_flags()

2021-02-16 Thread James Almer
On 2/7/2021 11:29 AM, James Almer wrote: Signed-off-by: James Almer --- libavfilter/buffersrc.c | 38 -- 1 file changed, 8 insertions(+), 30 deletions(-) diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c index bf30f54177..da1cf9941e 100644

[FFmpeg-devel] [PATCH 1/1] avcodec/libopusdec: Enable FEC/PLC

2021-02-16 Thread Philip-Dylan Gleonec
Adds FEC/PLC support to libopus. The lost packets are detected as a discontinuity in the audio stream. When a discontinuity is used, this patch tries to decode the FEC data. If FEC data is present in the packet, it is decoded, otherwise audio is re-created through PLC. This patch is based on

[FFmpeg-devel] [PATCH 0/1] [FFmpeg-devel, WIP] libopusdec: Enable FEC/PLC

2021-02-16 Thread Philip-Dylan Gleonec
Hello, As part of GNU Jami development, I've picked up this patch and worked to complete and validate it. The few changes I've made are mostly to add checks to manage errors and different cases, notably video vs audio containers. I have tested the feature with opus stream encapsulated in mkv,

Re: [FFmpeg-devel] [PATCH] avfilter: add vif filter

2021-02-16 Thread Paul B Mahol
will apply soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2] hwcontext_vaapi: introduce AV_HWFRAME_MAP_{SEPARATE, COMBINED}_PLANES

2021-02-16 Thread Simon Ser
This allows callers to ask for separate or combined plane formats. Combined formats are desirable in many scenarios, for instance when directly importing the DMA-BUFs into APIs such as GL (as a single EGLImage), KMS or Wayland. This patch was tested with the following Mesa MR:

Re: [FFmpeg-devel] [PATCH V2 08/10] libavutil: add side data AVDnnBoundingBox for dnn based detect/classify filters

2021-02-16 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Mark > Thompson > Sent: 2021年2月16日 7:48 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH V2 08/10] libavutil: add side data > AVDnnBoundingBox for dnn based detect/classify filters > > On 11/02/2021 08:15, Guo,