Re: [FFmpeg-devel] [PATCH] rtpenc_mpegts: add AVClass to the muxer context

2021-03-31 Thread Gyan Doshi
On 2021-04-01 00:24, Anton Khirnov wrote: Quoting Gyan Doshi (2021-03-31 15:15:18) --- libavformat/rtpenc_mpegts.c | 1 + 1 file changed, 1 insertion(+) Will backport to 4.4 diff --git a/libavformat/rtpenc_mpegts.c b/libavformat/rtpenc_mpegts.c index 9f95b3a4e8..da17b1d776 100644 ---

Re: [FFmpeg-devel] [PATCH V6 6/6] lavfi: add filter dnn_detect for object detection

2021-03-31 Thread Guo, Yejun
> -Original Message- > From: Guo, Yejun > Sent: 2021年3月26日 16:10 > To: ffmpeg-devel@ffmpeg.org > Cc: Guo, Yejun > Subject: [PATCH V6 6/6] lavfi: add filter dnn_detect for object detection > > Below are the example steps to do object detection: > > 1. download and install

[FFmpeg-devel] Creating a real-time subtitle source

2021-03-31 Thread Sean Dunn
I would like to modify ffmpeg to accept real time SRT data from a tcp listener. This is my first dive into ffmpeg's architecture. So far in my prototype, I've been able to mark the tcp listener as non-blocking (returning EAGAIN), but I have an issue with the emitted subtitle packets, and I'd like

Re: [FFmpeg-devel] [PATCH] mov: Skip computing SAR from invalid display matrix elements

2021-03-31 Thread Vittorio Giovara
On Wed, Mar 31, 2021 at 8:54 PM Anton Khirnov wrote: > Quoting Vittorio Giovara (2021-03-31 18:43:02) > > On Wed, Mar 31, 2021 at 2:41 PM Anton Khirnov wrote: > > > > > Quoting Vittorio Giovara (2021-03-30 18:55:27) > > > > Hello, > > > > I was debugging an issue with a video file containing an

Re: [FFmpeg-devel] [PATCH] tests/matroska: Add test for remuxing annex B H.264 into Matroska

2021-03-31 Thread Andreas Rheinhardt
James Almer: > On 3/31/2021 4:19 PM, Andreas Rheinhardt wrote: >> Signed-off-by: Andreas Rheinhardt >> --- >> Will apply this patch tomorrow unless there are objections. >> >>   tests/fate/matroska.mak    | 17 >>   tests/ref/fate/matroska-h264-remux | 65

Re: [FFmpeg-devel] [PATCH] tests/matroska: Add test for remuxing annex B H.264 into Matroska

2021-03-31 Thread James Almer
On 3/31/2021 4:19 PM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- Will apply this patch tomorrow unless there are objections. tests/fate/matroska.mak| 17 tests/ref/fate/matroska-h264-remux | 65 ++ 2 files changed, 82

Re: [FFmpeg-devel] [PATCH 00/17] Various undefined behaviour fixes

2021-03-31 Thread Andreas Rheinhardt
On Sat, Mar 27, 2021 at 2:31 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Hello, > > attached patches fix several instances of undefined behaviour > encountered when running the FATE suite. > > - Andreas > > Will apply this patchset tomorrow (without the FF_PTR_ADD macro; the

[FFmpeg-devel] [PATCH 1/2] libavdevice/gdigrab: make region window click-throughable

2021-03-31 Thread 1160386205
From: He Yang <1160386...@qq.com> the region window created by option `-show_region`, though only 3 pixel width, is not click-throughable. Signed-off-by: He Yang <1160386...@qq.com> --- libavdevice/gdigrab.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH 2/2] libavdevice/gdigrab: create a separate thread for handling window messages

2021-03-31 Thread 1160386205
From: He Yang <1160386...@qq.com> Windows message processing should start as soon as the window is created. otherwise, Windows may think ffmpeg is not responding. for example the window may got stucked (by clicking at it) in the previous code while ffmpeg is querying the user whether to overwrite

[FFmpeg-devel] [PATCH] tests/matroska: Add test for remuxing annex B H.264 into Matroska

2021-03-31 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- Will apply this patch tomorrow unless there are objections. tests/fate/matroska.mak| 17 tests/ref/fate/matroska-h264-remux | 65 ++ 2 files changed, 82 insertions(+) create mode 100644

[FFmpeg-devel] Re: [PATCH] rtpenc_mpegts: add AVClass to the muxer context

2021-03-31 Thread Anton Khirnov
Quoting Gyan Doshi (2021-03-31 15:15:18) > --- > libavformat/rtpenc_mpegts.c | 1 + > 1 file changed, 1 insertion(+) > > Will backport to 4.4 > diff --git a/libavformat/rtpenc_mpegts.c b/libavformat/rtpenc_mpegts.c > index 9f95b3a4e8..da17b1d776 100644 > --- a/libavformat/rtpenc_mpegts.c > +++

Re: [FFmpeg-devel] [PATCH] mov: Skip computing SAR from invalid display matrix elements

2021-03-31 Thread Anton Khirnov
Quoting Vittorio Giovara (2021-03-31 18:43:02) > On Wed, Mar 31, 2021 at 2:41 PM Anton Khirnov wrote: > > > Quoting Vittorio Giovara (2021-03-30 18:55:27) > > > Hello, > > > I was debugging an issue with a video file containing an invalid > > > display matrix, probably produced by a non

Re: [FFmpeg-devel] [PATCH] avformat/mov: Ignore multiple STSC / STCO

2021-03-31 Thread Michael Niedermayer
On Wed, Mar 24, 2021 at 07:24:30PM +0100, Michael Niedermayer wrote: > Fixes: STSC / STCO inconsistency and assertion failure > Fixes: crbug1184666.mp4 > > Found-by: Chromium ASAN fuzzer > Reviewed-by: Matt Wolenetz > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 12

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/mpegvideo: Update chroma_?_shift in ff_mpv_common_frame_size_change()

2021-03-31 Thread Michael Niedermayer
On Mon, Mar 22, 2021 at 09:58:32PM +0100, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 31201/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-4627865612189696.fuzz > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 4/6] avformat/mov: Do not zero memory that is written too or unused

2021-03-31 Thread Michael Niedermayer
On Mon, Mar 22, 2021 at 09:58:31PM +0100, Michael Niedermayer wrote: > Fixes: OOM > Fixes: > 31220/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-6033383962574848 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mpc8: check for size overflow in mpc8_get_chunk_header()

2021-03-31 Thread Michael Niedermayer
On Thu, Mar 18, 2021 at 12:17:26AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: -9223372036854775760 - 50 cannot be > represented in type 'long' > Fixes: > 31673/clusterfuzz-testcase-minimized-ffmpeg_dem_MPC8_fuzzer-580134751869337 > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/mpegpicture: Keep ff_mpeg_framesize_alloc() failure state consistent

2021-03-31 Thread Michael Niedermayer
On Fri, Mar 19, 2021 at 04:26:11PM +0100, Michael Niedermayer wrote: > On Thu, Mar 18, 2021 at 09:57:11PM +0100, Andreas Rheinhardt wrote: > > Michael Niedermayer: > > > Fixes: null pointer dereference > > > Fixes: ff_put_pixels16_sse2.mp4 > > > > > > Found-by: Rafael Dutra > > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/h264_slice: Check input SPS in ff_h264_update_thread_context()

2021-03-31 Thread Michael Niedermayer
On Tue, Mar 23, 2021 at 12:34:16AM +0100, Michael Niedermayer wrote: > On Mon, Mar 22, 2021 at 10:12:47PM +0100, Hendrik Leppkes wrote: > > On Mon, Mar 22, 2021 at 10:05 PM Michael Niedermayer > > wrote: > > > > > > Fixes: crash > > > Fixes: check_pkt.mp4 > > > > > > Found-by: Rafael Dutra > > >

Re: [FFmpeg-devel] [PATCH 1/7] avformat/utils: Extend overflow check in dts wrap in compute_pkt_fields()

2021-03-31 Thread Michael Niedermayer
On Wed, Feb 03, 2021 at 12:13:28AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: -9223372032574480351 - 4294967296 cannot be > represented in type 'long long' > Fixes: > 30022/clusterfuzz-testcase-minimized-ffmpeg_dem_KUX_fuzzer-5568610275819520 > > Found-by: continuous

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/cfhd: More strictly check tag order and multiplicity

2021-03-31 Thread Paul B Mahol
I can not reproduce any crash either with address sanitizer or valgrind with samples you provided. Are you sure this apply to master? On Tue, Mar 30, 2021 at 7:50 PM Paul B Mahol wrote: > Please share files privately, do not apply non fix for this issue. > > Give up with such this non-solution.

Re: [FFmpeg-devel] [PATCH] mov: Skip computing SAR from invalid display matrix elements

2021-03-31 Thread Vittorio Giovara
On Wed, Mar 31, 2021 at 2:41 PM Anton Khirnov wrote: > Quoting Vittorio Giovara (2021-03-30 18:55:27) > > Hello, > > I was debugging an issue with a video file containing an invalid > > display matrix, probably produced by a non conforming software. > > > > The content of the matrix is: > >

Re: [FFmpeg-devel] [PATCH v2] examples/decode_video: flush parser to fix missing frame

2021-03-31 Thread myp...@gmail.com
On Thu, Sep 24, 2020 at 2:01 AM Zhao Zhili wrote: > > To reproduce, run decode_video with a single frame sample. No frame > was decoded before the patch. > --- > doc/examples/decode_video.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_scale: Fix adding 0 to NULL (which is UB) in scale_slice()

2021-03-31 Thread Michael Niedermayer
On Mon, Mar 15, 2021 at 09:47:44AM +0100, Michael Niedermayer wrote: > Found-by: Jeremy Leconte > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_scale.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) will apply [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH v3 2/5] avcodec/mips: Refine get_cabac_inline_mips.

2021-03-31 Thread Michael Niedermayer
On Tue, Mar 30, 2021 at 08:51:52PM +0800, Shiyou Yin wrote: > 1. Refined function get_cabac_inline_mips. > 2. Optimize function get_cabac_bypass and get_cabac_bypass_sign. > > Speed of decoding h264: 4.89x ==> 5.05x(tested on 3A4000). > --- > libavcodec/mips/cabac.h | 131 >

[FFmpeg-devel] [PATCH] rtpenc_mpegts: add AVClass to the muxer context

2021-03-31 Thread Gyan Doshi
--- libavformat/rtpenc_mpegts.c | 1 + 1 file changed, 1 insertion(+) Will backport to 4.4 diff --git a/libavformat/rtpenc_mpegts.c b/libavformat/rtpenc_mpegts.c index 9f95b3a4e8..da17b1d776 100644 --- a/libavformat/rtpenc_mpegts.c +++ b/libavformat/rtpenc_mpegts.c @@ -25,6 +25,7 @@ #include

Re: [FFmpeg-devel] [PATCH 1/3] avformat/rtpenc_mpegts: allow options for mpeg-ts muxer

2021-03-31 Thread Anton Khirnov
Quoting Gyan Doshi (2021-03-23 06:37:32) > --- > libavformat/rtpenc_mpegts.c | 24 +++- > 1 file changed, 23 insertions(+), 1 deletion(-) > > diff --git a/libavformat/rtpenc_mpegts.c b/libavformat/rtpenc_mpegts.c > index 28522f8913..d501d09590 100644 > ---

Re: [FFmpeg-devel] [PATCH] mov: Skip computing SAR from invalid display matrix elements

2021-03-31 Thread Anton Khirnov
Quoting Vittorio Giovara (2021-03-30 18:55:27) > Hello, > I was debugging an issue with a video file containing an invalid > display matrix, probably produced by a non conforming software. > > The content of the matrix is: > :0 65536 0 > 0001: -1

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegenc: Fix segfault when freeing incomplete context

2021-03-31 Thread Michael Niedermayer
On Wed, Mar 31, 2021 at 12:26:24AM +0200, Andreas Rheinhardt wrote: > When allocating the MJpegContext fails (or if the dimensions run afoul > of the 65500x65500 limit), an attempt to free a subbuffer of said > context leads to a segfault in ff_mjpeg_encode_close(). > Seems to be a regression

Re: [FFmpeg-devel] [PATCH] mov: Skip computing SAR from invalid display matrix elements

2021-03-31 Thread Vittorio Giovara
On Tue, Mar 30, 2021 at 11:28 PM Carl Eugen Hoyos wrote: > Am Di., 30. März 2021 um 19:24 Uhr schrieb Vittorio Giovara > : > > > > Hello, > > I was debugging an issue with a video file containing an invalid > > display matrix, probably produced by a non conforming software. > > > > The content

Re: [FFmpeg-devel] [mips] Optimize H264 decoding for MIPS platform.

2021-03-31 Thread 殷时友
Could you please help to merge these patches. > 2021年3月30日 下午8:51,Shiyou Yin 写道: > > v2: Fixed a build error in [PATCH 2/5]. > v3: add patch 4/5. > > [PATCH v3 1/5] avcodec/mips: Restore the initialization sequence of > [PATCH v3 2/5] avcodec/mips: Refine get_cabac_inline_mips. > [PATCH v3

[FFmpeg-devel] [PATCH 2/2] doc/ffprobe.xsd: Clean-up choice indicator definitions

2021-03-31 Thread Tobias Rapp
Remove the unneeded wrapping sequence element. Also the minOccurs/maxOccurs occurrence inicators on the inner element definitions can be removed. Signed-off-by: Tobias Rapp --- doc/ffprobe.xsd | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git

[FFmpeg-devel] [PATCH 1/2] fftools/ffprobe: Remove check on show_frames and show_packets in XML writer

2021-03-31 Thread Tobias Rapp
The "packets_and_frames" element has been added to ffprobe.xsd in 0c9f0da0f7656059e9bd41931d250aafddf35ea3 but apparently removing the check in ffprobe.c has been forgotten. Signed-off-by: Tobias Rapp --- fftools/ffprobe.c | 7 --- 1 file changed, 7 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 2/4] avformat/ttmlenc: enable writing out additional header values

2021-03-31 Thread Andreas Rheinhardt
Jan Ekström: > On Tue, Mar 30, 2021 at 12:19 PM Andreas Rheinhardt > wrote: >> >> Jan Ekström: >>> From: Jan Ekström >>> >>> This way the encoder may pass on the following values to the muxer: >>> 1) Additional root "tt" element attributes, such as the subtitle >>>canvas reference size. >>>

Re: [FFmpeg-devel] [PATCH V6 6/6] lavfi: add filter dnn_detect for object detection

2021-03-31 Thread Guo, Yejun
> -Original Message- > From: Guo, Yejun > Sent: 2021年3月26日 16:10 > To: ffmpeg-devel@ffmpeg.org > Cc: Guo, Yejun > Subject: [PATCH V6 6/6] lavfi: add filter dnn_detect for object detection > > Below are the example steps to do object detection: > > 1. download and install

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffprobe: Add missing dispositions

2021-03-31 Thread Tobias Rapp
On 30.03.2021 19:51, Marton Balint wrote: [...] I wonder if a fate test testing the XML output of ffprobe can be extended to do a validation of the XML via the XSD so this does not gets forgatten... I agree that would be great. But I guess we cannot depend on a tool like xmllint being

Re: [FFmpeg-devel] [PATCH 2/4] avformat/ttmlenc: enable writing out additional header values

2021-03-31 Thread Jan Ekström
On Tue, Mar 30, 2021 at 12:19 PM Andreas Rheinhardt wrote: > > Jan Ekström: > > From: Jan Ekström > > > > This way the encoder may pass on the following values to the muxer: > > 1) Additional root "tt" element attributes, such as the subtitle > >canvas reference size. > > 2) Anything before

Re: [FFmpeg-devel] [PATCH 1/2] tls_openssl: Improve quality of printed error messages, pass IO error codes through

2021-03-31 Thread Martin Storsjö
On Fri, 26 Mar 2021, Martin Storsjö wrote: Print every error in the stack, if more than one, and don't print bogus errors if there's none logged within OpenSSL. Retain the underlying IO error code, print an error message out of it, and pass the error code on to the caller. ---