Re: [FFmpeg-devel] [PATCH] avformat/movenc: Fix tfdt out of sync

2021-07-19 Thread 胡玮文
Hi Martin, OK, here I provide some codes to demo this bug. Many of these are copied from libavformat/tests/movenc.c #include #include #include #include static const uint8_t h264_extradata[] = { 0x01, 0x4d, 0x40, 0x1e, 0xff, 0xe1, 0x00, 0x02, 0x67, 0x4d, 0x01, 0x00, 0x02, 0x68, 0xef };

Re: [FFmpeg-devel] [PATCH] avformat/gifdec: log loop count

2021-07-19 Thread Gyan Doshi
Will push in an hour. On 2021-07-19 16:25, Gyan Doshi wrote: --- libavformat/gifdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/gifdec.c b/libavformat/gifdec.c index c20bde1781..1977f46e3a 100644 --- a/libavformat/gifdec.c +++ b/libavformat/gifdec.c @@ -247,6 +247,7 @@ s

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc.c: Fix the trc support for iec61966-2-1 (sRGB)

2021-07-19 Thread Rick Kern
On Thu, Jul 15, 2021 at 12:47 AM Hao Guan wrote: > --- > libavcodec/videotoolboxenc.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c > index 4eaabed5d8..61eb6e1921 100644 > --- a/libavcodec/videotoolboxenc.c > +++ b/libavc

[FFmpeg-devel] [PATCH] avformat/hlsenc: set http options before use delete http method

2021-07-19 Thread Steven Liu
Fix ticket: 9338 Set options which set by user from parent options. Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 151ef6ec8f..5272ecabbb 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/

[FFmpeg-devel] [PATCH v1] avcodec/v4l2_context: resume the decoding process after source change event received.

2021-07-19 Thread Ming Qian
client need to resume the decoding process after it dequeues the source change event. no matter what's the return value of v4l2_resolution_changed(). if the client doesn't resume the decoding process, the decoder may keep waiting in documentation of v4l2 stateful decoder, we can see the following

Re: [FFmpeg-devel] [PATCH] avdevice/avfoundation: remove first_audio_pts and first_pts

2021-07-19 Thread Andreas Rheinhardt
Steven Liu: > From: Steven Liu > > Because these two member of AVFContext not be used. > > Signed-off-by: Steven Liu > --- > libavdevice/avfoundation.m | 4 > 1 file changed, 4 deletions(-) > > diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m > index bad3760159..5b4de

[FFmpeg-devel] [PATCH] avdevice/avfoundation: remove first_audio_pts and first_pts

2021-07-19 Thread Steven Liu
From: Steven Liu Because these two member of AVFContext not be used. Signed-off-by: Steven Liu --- libavdevice/avfoundation.m | 4 1 file changed, 4 deletions(-) diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m index bad3760159..5b4dea826c 100644 --- a/libavdevice/avf

[FFmpeg-devel] [PATCH] avdevice/avfoundation: remove first_audio_pts and first_pts

2021-07-19 Thread Steven Liu
Because these two member of AVFContext not be used. Signed-off-by: Steven Liu --- libavdevice/avfoundation.m | 4 1 file changed, 4 deletions(-) diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m index bad3760159..5b4dea826c 100644 --- a/libavdevice/avfoundation.m +++ b/l

Re: [FFmpeg-devel] [PATCH] libavformat/id3v2: Read full null seperated list for text info frames

2021-07-19 Thread Lode Willems
Could someone please review this patch? On 7/04/2021 01:22, Lode Willems wrote: All id3v2.4 text information frames are null separated lists: https://id3.org/id3v2.4.0-frames This change reads all values into the metadata dictionary without changing the outputs of ffmpeg or ffprobe Relevant ti

Re: [FFmpeg-devel] libavcodec/mpeg12dec.c: Check return value of init_get_bits

2021-07-19 Thread Andreas Rheinhardt
Thierry Foucu: > --- > libavcodec/mpeg12dec.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c > index b27ed5bd6d..edca202f0e 100644 > --- a/libavcodec/mpeg12dec.c > +++ b/libavcodec/mpeg12dec.c > @@ -1341,8 +1341,11 @@ s

[FFmpeg-devel] libavcodec/mpeg12dec.c: Check return value of init_get_bits

2021-07-19 Thread Thierry Foucu
--- libavcodec/mpeg12dec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index b27ed5bd6d..edca202f0e 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -1341,8 +1341,11 @@ static int mpeg1_decode_picture(AV

Re: [FFmpeg-devel] [PATCH] lavu/cpu: Use av_cpu_ prefix

2021-07-19 Thread Andreas Rheinhardt
Thilo Borgmann: > Am 19.07.21 um 23:51 schrieb James Almer: >> On 7/19/2021 6:47 PM, Thilo Borgmann wrote: >>> Am 19.07.21 um 23:20 schrieb James Almer: On 7/19/2021 6:19 PM, Andreas Rheinhardt wrote: > Thilo Borgmann: >> Hi, >> >> $subject for the new force cpu count function.

Re: [FFmpeg-devel] [PATCH] avpacket: ABI bump additions

2021-07-19 Thread Lynne
8 Jul 2021, 21:20 by andreas.rheinha...@outlook.com: > Lynne: > >> Apr 26, 2021, 03:27 by andreas.rheinha...@outlook.com: >> >>> Lynne: >>> From 097aed2ac33dda0bb2052d8b0402711ce95079ba Mon Sep 17 00:00:00 2001 From: Lynne Date: Sat, 23 Jan 2021 19:56:18 +0100 Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH] lavu/cpu: Use av_cpu_ prefix

2021-07-19 Thread James Almer
On 7/19/2021 6:58 PM, Andreas Rheinhardt wrote: Thilo Borgmann: Am 19.07.21 um 23:20 schrieb James Almer: On 7/19/2021 6:19 PM, Andreas Rheinhardt wrote: Thilo Borgmann: Hi, $subject for the new force cpu count function. Thanks, Thilo I just wanted to complain that you did not modify API

Re: [FFmpeg-devel] [PATCH] lavu/cpu: Use av_cpu_ prefix

2021-07-19 Thread Thilo Borgmann
Am 19.07.21 um 23:51 schrieb James Almer: > On 7/19/2021 6:47 PM, Thilo Borgmann wrote: >> Am 19.07.21 um 23:20 schrieb James Almer: >>> On 7/19/2021 6:19 PM, Andreas Rheinhardt wrote: Thilo Borgmann: > Hi, > > $subject for the new force cpu count function. > > Thanks,

Re: [FFmpeg-devel] [PATCH] lavu/cpu: Use av_cpu_ prefix

2021-07-19 Thread Andreas Rheinhardt
Thilo Borgmann: > Am 19.07.21 um 23:20 schrieb James Almer: >> On 7/19/2021 6:19 PM, Andreas Rheinhardt wrote: >>> Thilo Borgmann: Hi, $subject for the new force cpu count function. Thanks, Thilo >>> >>> I just wanted to complain that you did not modify APIchanges

Re: [FFmpeg-devel] [PATCH] lavu/cpu: Use av_cpu_ prefix

2021-07-19 Thread James Almer
On 7/19/2021 6:47 PM, Thilo Borgmann wrote: Am 19.07.21 um 23:20 schrieb James Almer: On 7/19/2021 6:19 PM, Andreas Rheinhardt wrote: Thilo Borgmann: Hi, $subject for the new force cpu count function. Thanks, Thilo I just wanted to complain that you did not modify APIchanges as well; but

Re: [FFmpeg-devel] [PATCH] lavu/cpu: Use av_cpu_ prefix

2021-07-19 Thread Thilo Borgmann
Am 19.07.21 um 23:20 schrieb James Almer: > On 7/19/2021 6:19 PM, Andreas Rheinhardt wrote: >> Thilo Borgmann: >>> Hi, >>> >>> $subject for the new force cpu count function. >>> >>> Thanks, >>> Thilo >>> >> >> I just wanted to complain that you did not modify APIchanges as well; >> but then I notic

Re: [FFmpeg-devel] [PATCH] lavu/cpu: Use av_cpu_ prefix

2021-07-19 Thread James Almer
On 7/19/2021 6:19 PM, Andreas Rheinhardt wrote: Thilo Borgmann: Hi, $subject for the new force cpu count function. Thanks, Thilo I just wanted to complain that you did not modify APIchanges as well; but then I noticed that there is no entry there for this new function. But there should be.

Re: [FFmpeg-devel] [PATCH] lavu/cpu: Use av_cpu_ prefix

2021-07-19 Thread Andreas Rheinhardt
Thilo Borgmann: > Hi, > > $subject for the new force cpu count function. > > Thanks, > Thilo > I just wanted to complain that you did not modify APIchanges as well; but then I noticed that there is no entry there for this new function. But there should be. - Andreas ___

[FFmpeg-devel] [PATCH] lavu/cpu: Use av_cpu_ prefix

2021-07-19 Thread Thilo Borgmann
Hi, $subject for the new force cpu count function. Thanks, Thilo From aedfcef85560c38b32dc898c32caa4c42fca97db Mon Sep 17 00:00:00 2001 From: Thilo Borgmann Date: Mon, 19 Jul 2021 23:11:58 +0200 Subject: [PATCH] lavu/cpu: Use av_cpu_ prefix --- fftools/cmdutils.c | 2 +- libavutil/cpu.c| 2

Re: [FFmpeg-devel] [PATCH] lavu/cpu: Use consistent av_cpu_ prefix for all functions

2021-07-19 Thread Thilo Borgmann
Am 19.07.21 um 22:53 schrieb Andreas Rheinhardt: > Thilo Borgmann: >> --- >> fftools/cmdutils.c | 8 >> libavcodec/x86/aacencdsp_init.c | 2 +- >> libavcodec/x86/aacpsdsp_init.c | 2 +- >> libavcodec/x86/ac3dsp_init.c|

Re: [FFmpeg-devel] [PATCH 5/5] avfilter/af_drmeter: Check that there is data

2021-07-19 Thread Michael Niedermayer
On Sun, Jun 06, 2021 at 03:47:57PM +0200, Michael Niedermayer wrote: > Fixes: floating point division by 0 > Fixes: -nan is outside the range of representable values of type 'int' > Fixes: Ticket8307 > > Signed-off-by: Michael Niedermayer > --- > libavfilter/af_drmeter.c | 5 + > 1 file chan

Re: [FFmpeg-devel] [PATCH 4/5] avfilter/vf_fftdnoiz: Use lrintf() in export_row8()

2021-07-19 Thread Michael Niedermayer
On Sun, Jun 06, 2021 at 03:47:56PM +0200, Michael Niedermayer wrote: > Fixes: 1.04064e+10 is outside the range of representable values of type 'int' > Fixes: Ticket 8279 > > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_fftdnoiz.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [FFmpeg-devel] [PATCH 1/3] avformat/matroskadec: Reset state also on failure in matroska_reset_status()

2021-07-19 Thread Andreas Rheinhardt
Michael Niedermayer: > On Fri, Jul 02, 2021 at 06:17:58PM +0200, Andreas Rheinhardt wrote: >> Michael Niedermayer: >>> The calling code does not handle failures and will fail with assertion >>> failures later. >>> Seeking can always fail even when the position was previously read. >>> >>> Fixes: A

Re: [FFmpeg-devel] [PATCH 3/5] avfilter/vf_mestimate: Check b_count

2021-07-19 Thread Michael Niedermayer
On Sun, Jun 06, 2021 at 03:47:55PM +0200, Michael Niedermayer wrote: > Fixes: left shift of negative value -1 > Fixes: Ticket8270 > > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_mestimate.c | 3 +++ > 1 file changed, 3 insertions(+) will apply [...] -- Michael GnuPG fingerp

Re: [FFmpeg-devel] [PATCH] lavu/cpu: Use consistent av_cpu_ prefix for all functions

2021-07-19 Thread James Almer
On 7/19/2021 5:43 PM, Thilo Borgmann wrote: Hi, as requested in review of [1]. Does this require some version bump? Thanks, Thilo [1] [PATCH] fftools/cmdutils.c: Add cmd line option to override detection of cpu count This is a breaking change. You're removing existing public functions. Wha

Re: [FFmpeg-devel] [PATCH] lavu/cpu: Use consistent av_cpu_ prefix for all functions

2021-07-19 Thread Andreas Rheinhardt
Thilo Borgmann: > --- > fftools/cmdutils.c | 8 > libavcodec/x86/aacencdsp_init.c | 2 +- > libavcodec/x86/aacpsdsp_init.c | 2 +- > libavcodec/x86/ac3dsp_init.c| 4 ++-- > libavcodec/x86/alacdsp_init.c |

Re: [FFmpeg-devel] [PATCH] lavu/cpu: Use consistent av_cpu_ prefix for all functions

2021-07-19 Thread Thilo Borgmann
Am 19.07.21 um 22:48 schrieb Andreas Rheinhardt: > Thilo Borgmann: >> Hi, >> >> as requested in review of [1]. Does this require some version bump? >> > > This has not been requested; quite the opposite: > > Anton Khirnov: >> Sadly we cannot change existing function names. But at least new >> fun

Re: [FFmpeg-devel] [PATCH] lavu/cpu: Use consistent av_cpu_ prefix for all functions

2021-07-19 Thread Andreas Rheinhardt
Thilo Borgmann: > Hi, > > as requested in review of [1]. Does this require some version bump? > This has not been requested; quite the opposite: Anton Khirnov: > Sadly we cannot change existing function names. But at least new > functions can use consistent namespacing. You are changing existi

Re: [FFmpeg-devel] [PATCH] fftools/cmdutils.c: Add cmd line option to override detection of cpu count

2021-07-19 Thread Thilo Borgmann
Am 16.07.21 um 14:16 schrieb James Almer: > On 6/6/2021 7:44 AM, Thilo Borgmann wrote: >> Hi, >> >> Am 05.06.21 um 16:33 schrieb Anton Khirnov: >>> Quoting Thilo Borgmann (2021-06-05 14:29:05) Hi, add an option to override auto-detection of cpu count. Defaults to auto-detection

[FFmpeg-devel] [PATCH] lavu/cpu: Use consistent av_cpu_ prefix for all functions

2021-07-19 Thread Thilo Borgmann
Hi, as requested in review of [1]. Does this require some version bump? Thanks, Thilo [1] [PATCH] fftools/cmdutils.c: Add cmd line option to override detection of cpu count From 7b7659db29240b0ee48b469987546a793fcfa3b1 Mon Sep 17 00:00:00 2001 From: Thilo Borgmann Date: Mon, 19 Jul 2021 22:40:

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Fix tfdt out of sync

2021-07-19 Thread Martin Storsjö
Hi, Thanks for the patch! I'll try to look into it in a while (I'm a bit swamped and short on time at the moment), hopefully within a couple days or so. On Sun, 18 Jul 2021, Hu Weiwen wrote: Fix an edge case when auto flushing an empty fragment, and the previous fragment has inaccurate dura

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Add new variant source_no_drop to the force_key_frames option

2021-07-19 Thread Thilo Borgmann
Am 16.07.21 um 22:31 schrieb Mattias Wadman: > On Fri, Jul 16, 2021 at 9:51 AM Thilo Borgmann > wrote: > >> Am 04.07.21 um 21:23 schrieb Michael Niedermayer: >>> On Sun, Jun 20, 2021 at 09:48:29PM +0200, Thilo Borgmann wrote: Hi, adds a new variant to the -force_key_frames option "

Re: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg: accelerate seeking while reading input at native frame rate

2021-07-19 Thread Linjie Fu
On Mon, Jul 19, 2021 at 3:32 PM Gyan Doshi wrote: > > > On 2021-07-19 12:48, Gyan Doshi wrote: > > > > > > On 2021-07-18 22:23, Linjie Fu wrote: > >> On Sun, Jul 18, 2021 at 8:57 PM Gyan Doshi wrote: > >>> > >>> > >>> On 2021-07-18 15:37, Linjie Fu wrote: > On Sun, Jul 18, 2021 at 5:26 PM G

Re: [FFmpeg-devel] [PATCH] avdevice/avfoundation: remove first_audio_pts and first_pts

2021-07-19 Thread Thilo Borgmann
Am 19.07.21 um 14:03 schrieb Steven Liu: > Because these two member of AVFContext not be used. > > Signed-off-by: Steven Liu > --- > libavdevice/avfoundation.m | 4 > 1 file changed, 4 deletions(-) > > diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m > index bad3760159.

[FFmpeg-devel] [PATCH] avdevice/avfoundation: remove first_audio_pts and first_pts

2021-07-19 Thread Steven Liu
Because these two member of AVFContext not be used. Signed-off-by: Steven Liu --- libavdevice/avfoundation.m | 4 1 file changed, 4 deletions(-) diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m index bad3760159..5b4dea826c 100644 --- a/libavdevice/avfoundation.m +++ b/l

[FFmpeg-devel] [PATCH v2 2/2] avformat/movenc: add support for TTML muxing

2021-07-19 Thread Jan Ekström
From: Jan Ekström Includes basic support for both the ISMV ('dfxp') and MP4 ('stpp') methods. This initial version also foregoes fragmentation support in case the built-in sample squashing is to be utilized, as this eases the initial review. Additionally, add basic tests for both muxing modes in

[FFmpeg-devel] [PATCH v2 0/2] TTML in MP4, part 1

2021-07-19 Thread Jan Ekström
To keep it simpler this first part includes only non-fragmented use cases if the built-in sample squashing is utilized. Contains the basic mapping code as well as the function that writes out the squashed documents. Works with both subtitle-only output as well as with other streams. In a separate

[FFmpeg-devel] [PATCH v2 1/2] avformat/ttml: split TTML paragraph based or not check into header

2021-07-19 Thread Jan Ekström
From: Jan Ekström This way it can be re-utilized in movenc. Signed-off-by: Jan Ekström --- libavformat/ttmlenc.c | 9 ++--- libavformat/ttmlenc.h | 39 +++ 2 files changed, 41 insertions(+), 7 deletions(-) create mode 100644 libavformat/ttmlenc.h diff

[FFmpeg-devel] [PATCH] avformat/gifdec: log loop count

2021-07-19 Thread Gyan Doshi
--- libavformat/gifdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/gifdec.c b/libavformat/gifdec.c index c20bde1781..1977f46e3a 100644 --- a/libavformat/gifdec.c +++ b/libavformat/gifdec.c @@ -247,6 +247,7 @@ static int gif_read_ext(AVFormatContext *s) if (sb_s

[FFmpeg-devel] "Will apply" (was: avformat/subtitles: Deduplicate subtitles' read_(packet|seek|close))

2021-07-19 Thread Nicolas George
Andreas Rheinhardt (12021-07-18): > Will apply. I have seen more and more of these "will apply" messages, but I am doubting their usefulness. "Applied" messages are useful to close the discussion. People reading the archives know that the patch is there, the bug is fixed, the feature is added. Th

Re: [FFmpeg-devel] [PATCH] avfilter/vf_signature: Initialize all houghspace elements

2021-07-19 Thread Jai Luthra
Planning to push it in 24h - if there are no objections. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsu

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Fix declaration-after-statement warning

2021-07-19 Thread Nicolas George
Andreas Rheinhardt (12021-07-18): > I pushed this to fix the warning, although I'd like to hear other > peoples' opinion on whether the warning should no longer be enabled. I personally consider it is good code hygiene to group variable declarations. It reduces diff noise when we need to use the

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: add support for TTML muxing

2021-07-19 Thread Jan Ekström
On Mon, Jul 12, 2021 at 4:20 PM Martin Storsjö wrote: > > On Tue, 22 Jun 2021, Jan Ekström wrote: > > > From: Jan Ekström > > > > Includes basic support for both the ISMV ('dfxp') and MP4 ('stpp') > > methods. This initial version also foregoes fragmentation support > > as this eases the initial

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Fix declaration-after-statement warning

2021-07-19 Thread Nicolas George
"zhilizhao(赵志立)" (12021-07-19): > For clang, `-Wdeclaration-after-statement` has no effect with -std=c99. Looks like a clang bug: you asked for the warning, it should give it. Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Fix declaration-after-statement warning

2021-07-19 Thread zhilizhao(赵志立)
> On Jul 19, 2021, at 3:23 AM, Andreas Rheinhardt > wrote: > > Andreas Rheinhardt: >> Signed-off-by: Andreas Rheinhardt >> --- >> What is actually the reason that we stick to this C90 rule? >> Is it because of compability with ancient compilers? (Given that we >> already require several C99 f

Re: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg: accelerate seeking while reading input at native frame rate

2021-07-19 Thread Gyan Doshi
On 2021-07-19 12:48, Gyan Doshi wrote: On 2021-07-18 22:23, Linjie Fu wrote: On Sun, Jul 18, 2021 at 8:57 PM Gyan Doshi wrote: On 2021-07-18 15:37, Linjie Fu wrote: On Sun, Jul 18, 2021 at 5:26 PM Gyan Doshi wrote: On 2021-07-18 13:35, Linjie Fu wrote: On Sun, Jul 18, 2021 at 1:21 P

Re: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg: accelerate seeking while reading input at native frame rate

2021-07-19 Thread Gyan Doshi
On 2021-07-18 22:23, Linjie Fu wrote: On Sun, Jul 18, 2021 at 8:57 PM Gyan Doshi wrote: On 2021-07-18 15:37, Linjie Fu wrote: On Sun, Jul 18, 2021 at 5:26 PM Gyan Doshi wrote: On 2021-07-18 13:35, Linjie Fu wrote: On Sun, Jul 18, 2021 at 1:21 PM Gyan Doshi wrote: On 2021-07-18 10:42

[FFmpeg-devel] [PATCH] avdevice/avfoundation: continue to try get packet if not in observed_quit mode

2021-07-19 Thread Steven Liu
move unlock_frames before return in observed_quit mode. before patch: ./ffmpeg -f avfoundation -i ":0" -y out.wav say something to microphone ffplay out.wav will hear some noise, because not get enough samples from devices after patch: ./ffmpeg -f avfoundation -i ":0" -y out.wav say something to m

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Fix declaration-after-statement warning

2021-07-19 Thread Gyan Doshi
On 2021-07-19 00:53, Andreas Rheinhardt wrote: Andreas Rheinhardt: Signed-off-by: Andreas Rheinhardt --- What is actually the reason that we stick to this C90 rule? Is it because of compability with ancient compilers? (Given that we already require several C99 features, I doubt that there ar