Re: [FFmpeg-devel] [PATCH v3 1/1] avcodec/vp6: return value check for init_get_bits

2021-08-25 Thread Maryam Ebrahimzadeh
Thanks, So when will you apply this? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v5 1/1] avcodec/vc1dec: Return value check for init_get_bits

2021-08-25 Thread Maryam Ebrahimzadeh
Thanks, So when will you apply this? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Missing sudo on make install in INSTALL.md

2021-08-25 Thread zhilizhao(赵志立)
> I tried try `make install` on my machine and I got: >install: cannot create regular file '/usr/local/share/man/man1/ffmpeg.1': > Permission denied >install: cannot create regular file '/usr/local/share/man/man1/ffprobe.1': > Permission denied >install: cannot create regular file >

[FFmpeg-devel] Missing sudo on make install in INSTALL.md

2021-08-25 Thread Jan Poonthong
0001-Missing-sudo-on-make-install.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with

Re: [FFmpeg-devel] [PATCH] h274: remove optimization pragma

2021-08-25 Thread Jan Poonthong
I didn't really understand what you meant. So I should install nasm and run ./configure or just ./configure --disable-x86asm? On Thu, Aug 26, 2021 at 2:24 AM Lynne wrote: > This results in warnings on compilers which don't support it, > objections were raised during the review process about it

Re: [FFmpeg-devel] Sending patch to FFMPEG

2021-08-25 Thread Jan Poonthong
Makes sense, but there is no mentioning of nasm is recommended . Is there any down side of --disable x86? On Thu, Aug 26, 2021 at 2:12 AM Lynne wrote: > 5 Aug 2021, 21:05 by janpoonthong...@gmail.com: > > > If I'm missing something, please let me know. > > > > We've recommended nasm instead of

[FFmpeg-devel] [PATCH v5 6/6] doc/filters.texi: Include dnn_processing in docs of sr and derain filter

2021-08-25 Thread Shubhanshu Saxena
Signed-off-by: Shubhanshu Saxena --- doc/filters.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 7aff920311..4da1cdc2aa 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -9982,7 +9982,7 @@ Note that different backends

[FFmpeg-devel] [PATCH v5 5/6] lavfi/dnn: Rename InferenceItem to LastLevelTaskItem

2021-08-25 Thread Shubhanshu Saxena
This patch renames the InferenceItem to LastLevelTaskItem in the three backends to avoid confusion among the meanings of these structs. The following are the renames done in this patch: 1. extract_inference_from_task -> extract_lltask_from_task 2. InferenceItem -> LastLevelTaskItem 3.

[FFmpeg-devel] [PATCH v5 4/6] libavfilter: Remove Async Flag from DNN Filter Side

2021-08-25 Thread Shubhanshu Saxena
Remove async flag from filter's perspective after the unification of async and sync modes in the DNN backend. Signed-off-by: Shubhanshu Saxena --- doc/filters.texi | 14 -- libavfilter/dnn/dnn_backend_tf.c | 7 +++ libavfilter/dnn_filter_common.c | 7 ---

[FFmpeg-devel] [PATCH v5 3/6] libavfilter: Remove synchronous functions from DNN filters

2021-08-25 Thread Shubhanshu Saxena
This commit removes the unused sync mode specific code from the DNN filters since the sync and async mode are now unified from the filters' perspective. Signed-off-by: Shubhanshu Saxena --- libavfilter/vf_dnn_detect.c | 71 +--- libavfilter/vf_dnn_processing.c | 84

Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: Adjust incorrect error output

2021-08-25 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Wang, Fei W > Sent: Tuesday, 24 August 2021 07:32 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: Adjust incorrect > error output > > On Tue, 2021-08-24 at 02:45 +, Soft Works wrote: > > >

[FFmpeg-devel] [PATCH v5 2/6] libavfilter: Unify Execution Modes in DNN Filters

2021-08-25 Thread Shubhanshu Saxena
This commit unifies the async and sync mode from the DNN filters' perspective. As of this commit, the Native backend only supports synchronous execution mode. Now the user can switch between async and sync mode by using the 'async' option in the backend_configs. The values can be 1 for async and

[FFmpeg-devel] [PATCH v5 1/6] lavfi/dnn: Task-based Inference in Native Backend

2021-08-25 Thread Shubhanshu Saxena
This commit rearranges the code in Native Backend to use the TaskItem for inference. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_native.c | 176 ++- libavfilter/dnn/dnn_backend_native.h | 2 + 2 files changed, 121 insertions(+), 57 deletions(-)

Re: [FFmpeg-devel] [PATCH v3] avcodec/h264dec: apply H.274 film grain

2021-08-25 Thread James Almer
On 8/25/2021 3:06 PM, Eoff, Ullysses A wrote: -Original Message- From: ffmpeg-devel On Behalf Of Niklas Haas Sent: Tuesday, August 17, 2021 12:55 PM To: ffmpeg-devel@ffmpeg.org Cc: Niklas Haas Subject: [FFmpeg-devel] [PATCH v3] avcodec/h264dec: apply H.274 film grain From: Niklas Haas

Re: [FFmpeg-devel] [PATCH] arm: hevc_qpel: Fix the assembly to work with non-multiple of 8 widths

2021-08-25 Thread Martin Storsjö
On Wed, 25 Aug 2021, Martin Storsjö wrote: This unbreaks the fate-checkasm-hevc_pel test on arm targets. The assembly assumed that the width passed to the DSP functions is a multiple of 8, while the checkasm test used other widths too. This wasn't noticed before, because the hevc_pel checkasm

Re: [FFmpeg-devel] [PATCH] tests/fate: move TTML-in-MP4 tests from subtitles.mak to mov.mak

2021-08-25 Thread Jan Ekström
On Wed, Aug 25, 2021 at 10:58 PM Martin Storsjö wrote: > > On Wed, 25 Aug 2021, Jan Ekström wrote: > > > subtitles.mak utilizes a more strict comparator and - to be honest - > > the tests feel more at home in this location. > > --- > > LGTM, although your commit message forgets to point out the

Re: [FFmpeg-devel] [PATCH] tests/fate: move TTML-in-MP4 tests from subtitles.mak to mov.mak

2021-08-25 Thread Martin Storsjö
On Wed, 25 Aug 2021, Jan Ekström wrote: subtitles.mak utilizes a more strict comparator and - to be honest - the tests feel more at home in this location. --- LGTM, although your commit message forgets to point out the relevant effect of it - we're not just doing this for sorting things in

[FFmpeg-devel] [PATCH] tests/fate: move TTML-in-MP4 tests from subtitles.mak to mov.mak

2021-08-25 Thread Jan Ekström
subtitles.mak utilizes a more strict comparator and - to be honest - the tests feel more at home in this location. --- tests/fate/mov.mak | 4 tests/fate/subtitles.mak| 4 tests/ref/fate/{sub-ttml-mp4-dfxp =>

[FFmpeg-devel] [PATCH] h274: remove optimization pragma

2021-08-25 Thread Lynne
This results in warnings on compilers which don't support it, objections were raised during the review process about it but went unnoticed, and the speed benefit is highly compiler and version specific, and also not very critical. We generally hand-write assembly to optimize loops like that,

[FFmpeg-devel] [PATCH] fate: Fix mp4 ttml tests on Windows

2021-08-25 Thread Martin Storsjö
Override the fate-sub-* wide comparison function of CMP=rawdiff back to the default, CMP=diff, which ignores line ending differences (where the ffprobe output contains CRLF line endings). Signed-off-by: Martin Storsjö --- tests/fate/subtitles.mak | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [FFmpeg-devel] Sending patch to FFMPEG

2021-08-25 Thread Lynne
5 Aug 2021, 21:05 by janpoonthong...@gmail.com: > If I'm missing something, please let me know. > We've recommended nasm instead of yasm for years now. You don't need to have nasm installed to compile, you can disable assembly optimizations. configure even tells you how, and forces you to in

[FFmpeg-devel] Sending patch to FFMPEG

2021-08-25 Thread Jan Poonthong
If I'm missing something, please let me know. 0001-Include-missing-documentation-for-yasm-in-INSTALL.md.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [PATCH v3] avcodec/h264dec: apply H.274 film grain

2021-08-25 Thread Eoff, Ullysses A
> -Original Message- > From: ffmpeg-devel On Behalf Of Niklas Haas > Sent: Tuesday, August 17, 2021 12:55 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Niklas Haas > Subject: [FFmpeg-devel] [PATCH v3] avcodec/h264dec: apply H.274 film grain > > From: Niklas Haas > > Because we need access to

Re: [FFmpeg-devel] [PATCH v2 3/3] avcodec/h264dec: apply H.274 film grain

2021-08-25 Thread Eoff, Ullysses A
> -Original Message- > From: ffmpeg-devel On Behalf Of Niklas Haas > Sent: Tuesday, August 17, 2021 12:26 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Niklas Haas > Subject: [FFmpeg-devel] [PATCH v2 3/3] avcodec/h264dec: apply H.274 film grain > > From: Niklas Haas > > Because we need

Re: [FFmpeg-devel] [PATCH 2/8] avformat/movenc: Avoid calling strlen multiple times

2021-08-25 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/wma: handle run_level_decode error

2021-08-25 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/8] avformat/vorbiscomment: Don't compute strlen twice

2021-08-25 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2] avfilter/vf_guided: support enhanced guided filter

2021-08-25 Thread Xuewei Meng
From: Xuewei Meng Check block algin Signed-off-by: Xuewei Meng --- libavfilter/vf_guided.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/libavfilter/vf_guided.c b/libavfilter/vf_guided.c index c030080..94318c0 100644 --- a/libavfilter/vf_guided.c +++

[FFmpeg-devel] [PATCH v1] avfilter/vf_guided: support enhanced guided filter

2021-08-25 Thread Xuewei Meng
From: Xuewei Meng Enhanced guided filter and fast enhanced guided filter are supported. The enhanced guided filter can better preserve edges for denoising tasks. And the box filter operation is optimized. Signed-off-by: Xuewei Meng --- doc/filters.texi| 14 +- libavfilter/vf_guided.c

Re: [FFmpeg-devel] [PATCH v2 1/5] libavfilter/x86/vf_gblur: add ff_postscale_slice_avx512()

2021-08-25 Thread Paul B Mahol
On Wed, Aug 25, 2021 at 3:51 PM James Almer wrote: > On 8/19/2021 3:58 AM, Paul B Mahol wrote: > > On Mon, Aug 16, 2021 at 1:49 PM James Almer wrote: > > > >> On 8/16/2021 6:27 AM, Wu, Jianhua wrote: > > Yes, but we don't want to use AVX512 on hardware that downclocks > >> heavily. >

Re: [FFmpeg-devel] [PATCH v2 1/5] libavfilter/x86/vf_gblur: add ff_postscale_slice_avx512()

2021-08-25 Thread James Almer
On 8/19/2021 3:58 AM, Paul B Mahol wrote: On Mon, Aug 16, 2021 at 1:49 PM James Almer wrote: On 8/16/2021 6:27 AM, Wu, Jianhua wrote: Yes, but we don't want to use AVX512 on hardware that downclocks heavily. It's okay. Should I updated the configure file to let the IceLake-AVX512 to

Re: [FFmpeg-devel] [PATCH v2 1/5] libavfilter/x86/vf_gblur: add ff_postscale_slice_avx512()

2021-08-25 Thread Paul B Mahol
will apply shortly ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Compatibility of different library versions (was: avformat: Add internal flags for AV(In|Out)putFormat)

2021-08-25 Thread Diederick C. Niehorster
Top-posting on purpose: Several core developers stated to be in favor of locking lavd<->lavf together at the minor version, for instance since it solves a lot of the problems the intimate linking between the two libraries creates. Should this be turned into a patch somehow (i'm not sure how to do

Re: [FFmpeg-devel] [PATCH 1/2] avformat hls fix to seek logic

2021-08-25 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] ffmpeg: fix loosing gaps between audio frame timestamps when filtering

2021-08-25 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- fftools/ffmpeg.c| 5 + fftools/ffmpeg.h| 1 + fftools/ffmpeg_opt.c| 1 + tests/ref/fate/adpcm-ima-smjpeg | 658 tests/ref/fate/dcinema-encode | 26 +- tests/ref/lavf/smjpeg

[FFmpeg-devel] [PATCH v4 7/7] libavfilter: Send only input frame for DNN Detect and Classify

2021-08-25 Thread Shubhanshu Saxena
This commit updates the following two filters to send only the input frame and send NULL as output frame instead of input frame to the DNN backends. 1. vf_dnn_detect 2. vf_dnn_classify Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_common.c | 2 +-

[FFmpeg-devel] [PATCH v4 6/7] doc/filters.texi: Include dnn_processing in docs of sr and derain filter

2021-08-25 Thread Shubhanshu Saxena
Signed-off-by: Shubhanshu Saxena --- doc/filters.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index d99368e64b..112adc5d94 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -9982,7 +9982,7 @@ Note that different backends

[FFmpeg-devel] [PATCH v4 5/7] lavfi/dnn: Rename InferenceItem to LastLevelTaskItem

2021-08-25 Thread Shubhanshu Saxena
This patch renames the InferenceItem to LastLevelTaskItem in the three backends to avoid confusion among the meanings of these structs. The following are the renames done in this patch: 1. extract_inference_from_task -> extract_lltask_from_task 2. InferenceItem -> LastLevelTaskItem 3.

[FFmpeg-devel] [PATCH v4 4/7] libavfilter: Remove Async Flag from DNN Filter Side

2021-08-25 Thread Shubhanshu Saxena
Remove async flag from filter's perspective after the unification of async and sync modes in the DNN backend. Signed-off-by: Shubhanshu Saxena --- doc/filters.texi | 14 -- libavfilter/dnn/dnn_backend_tf.c | 7 +++ libavfilter/dnn_filter_common.c | 7 ---

[FFmpeg-devel] [PATCH v4 3/7] libavfilter: Remove synchronous functions from DNN filters

2021-08-25 Thread Shubhanshu Saxena
This commit removes the unused sync mode specific code from the DNN filters since the sync and async mode are now unified from the filters' perspective. Signed-off-by: Shubhanshu Saxena --- libavfilter/vf_dnn_detect.c | 71 +--- libavfilter/vf_dnn_processing.c | 84

[FFmpeg-devel] [PATCH v4 2/7] libavfilter: Unify Execution Modes in DNN Filters

2021-08-25 Thread Shubhanshu Saxena
This commit unifies the async and sync mode from the DNN filters' perspective. As of this commit, the Native backend only supports synchronous execution mode. Now the user can switch between async and sync mode by using the 'async' option in the backend_configs. The values can be 1 for async and

[FFmpeg-devel] [PATCH v4 1/7] lavfi/dnn: Task-based Inference in Native Backend

2021-08-25 Thread Shubhanshu Saxena
This commit rearranges the code in Native Backend to use the TaskItem for inference. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_native.c | 176 ++- libavfilter/dnn/dnn_backend_native.h | 2 + 2 files changed, 121 insertions(+), 57 deletions(-)

Re: [FFmpeg-devel] [PATCH] configure: set IceLake-AVX512 as the minimum baseline

2021-08-25 Thread Wu, Jianhua
Ronald S. Bultje Wrote: > I'm OK with the current approach also. So I will not object to the current > patch anymore. > Hi Ronald, I am sorry I'm not familiar of the review flow. Does this proposal still need to be reviewed and approved by other maintainers? Or if it's acceptable, I added the

Re: [FFmpeg-devel] [PATCH v2 00/10] make QSV works with Intel's oneVPL

2021-08-25 Thread Xiang, Haihao
On Mon, 2021-08-23 at 05:06 +, Soft Works wrote: > > -Original Message- > > From: ffmpeg-devel On Behalf Of Xiang, > > Haihao > > Sent: Monday, 23 August 2021 06:29 > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH v2 00/10] make QSV works with Intel's > > oneVPL

[FFmpeg-devel] [PATCH] arm: hevc_qpel: Fix the assembly to work with non-multiple of 8 widths

2021-08-25 Thread Martin Storsjö
This unbreaks the fate-checkasm-hevc_pel test on arm targets. The assembly assumed that the width passed to the DSP functions is a multiple of 8, while the checkasm test used other widths too. This wasn't noticed before, because the hevc_pel checkasm tests (that were added in

Re: [FFmpeg-devel] [PATCH v5 1/1] avcodec/vc1dec: Return value check for init_get_bits

2021-08-25 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter: add hsvkey and hsvhold video filters

2021-08-25 Thread Paul B Mahol
will apply soon ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v4 0/2] TTML in MP4, part 1

2021-08-25 Thread Jan Ekström
On Mon, Aug 23, 2021 at 11:31 AM Jan Ekström wrote: > > On Mon, Aug 16, 2021 at 3:26 PM Jan Ekström wrote: > > > > To keep it simpler this first part includes only non-fragmented use > > cases if the built-in sample squashing is utilized. Contains the basic > > mapping code as well as the