Re: [FFmpeg-devel] [PATCH v8 12/13] avfilter/split_cc: Add split_cc filter for closed caption handling

2021-09-21 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Wednesday, 22 September 2021 06:55 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v8 12/13] avfilter/split_cc: Add split_cc > filter for closed caption handling > > Soft Works: > >

Re: [FFmpeg-devel] [PATCH v8 12/13] avfilter/split_cc: Add split_cc filter for closed caption handling

2021-09-21 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Andreas >> Rheinhardt >> Sent: Wednesday, 22 September 2021 05:50 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v8 12/13] avfilter/split_cc: Add split_cc >> filter for closed caption handling

Re: [FFmpeg-devel] [PATCH v8 05/13] avfilter/sbuffer: Add sbuffersrc and sbuffersink filters

2021-09-21 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Wednesday, 22 September 2021 06:26 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v8 05/13] avfilter/sbuffer: Add sbuffersrc > and sbuffersink filters > > Soft Works: > >

Re: [FFmpeg-devel] [PATCH] libavcodec/hevc_mp4toannexb_bsf: ignore extra data if possible

2021-09-21 Thread Xiang, Haihao
> LGTM. Thanks for reviewing the patch. Could someone please merge this patch if no more comment ? Regards Haihao > > On Fri, 10 Sept 2021 at 05:10, Haihao Xiang wrote: > > > > It is possible that an IRAP frame in input AVPacket has SPS and PPS, and > > these headers should take effect.

Re: [FFmpeg-devel] [PATCH v8 12/13] avfilter/split_cc: Add split_cc filter for closed caption handling

2021-09-21 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Wednesday, 22 September 2021 05:50 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v8 12/13] avfilter/split_cc: Add split_cc > filter for closed caption handling > > Soft Works: > >

Re: [FFmpeg-devel] [PATCH v8 05/13] avfilter/sbuffer: Add sbuffersrc and sbuffersink filters

2021-09-21 Thread Andreas Rheinhardt
Soft Works: > Signed-off-by: softworkz > --- > configure| 2 +- > libavfilter/allfilters.c | 10 +++--- > libavfilter/buffersink.c | 63 +++ > libavfilter/buffersink.h | 15 + > libavfilter/buffersrc.c | 72

Re: [FFmpeg-devel] [PATCH v8 06/13] avfilter/overlay_graphicsubs: Add overlay_graphicsubs and graphicsub2video filters

2021-09-21 Thread Andreas Rheinhardt
Soft Works: > - overlay_graphicsubs (VS -> V) > Overlay graphic subtitles onto a video stream > > - graphicsub2video {S -> V) > Converts graphic subtitles to video frames (with alpha) > Gets auto-inserted for retaining compatibility with > sub2video command lines > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH v8 07/13] fftools/ffmpeg: Replace sub2video with subtitle frame filtering

2021-09-21 Thread Andreas Rheinhardt
Soft Works: > This commit actually enables subtitle filtering in ffmpeg by > sending and receiving subtitle frames to and from a filtergraph. > > The heartbeat functionality from the previous sub2video implementation > is retained and applied to all subtitle frames (bitmap, text, ..). > > The

Re: [FFmpeg-devel] [PATCH v8 11/13] avfilter/stripstyles: Add stripstyles filter

2021-09-21 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Wednesday, 22 September 2021 05:28 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v8 11/13] avfilter/stripstyles: Add > stripstyles filter > > Soft Works: > > > > > >> -Original

Re: [FFmpeg-devel] [PATCH v8 12/13] avfilter/split_cc: Add split_cc filter for closed caption handling

2021-09-21 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Andreas >> Rheinhardt >> Sent: Wednesday, 22 September 2021 04:43 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v8 12/13] avfilter/split_cc: Add split_cc >> filter for closed caption handling

Re: [FFmpeg-devel] [PATCH v8 09/13] avfilter/textmod: Add textmod, censor and show_speaker filters

2021-09-21 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Andreas >> Rheinhardt >> Sent: Wednesday, 22 September 2021 05:08 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v8 09/13] avfilter/textmod: Add textmod, >> censor and show_speaker filters >>

[FFmpeg-devel] [PATCH v2 2/2] swscale: add input/output support for X2BGR10LE

2021-09-21 Thread Manuel Stoeckl
Signed-off-by: Manuel Stoeckl --- libswscale/input.c | 15 +-- libswscale/output.c | 9 - libswscale/utils.c | 1 + libswscale/yuv2rgb.c | 9 ++---

[FFmpeg-devel] [PATCH v2 1/2] lavu/pix_fmt: add pixel format for x2bgr10

2021-09-21 Thread Manuel Stoeckl
The new format (given in big/little endian forms) matches the existing X2RGB10 format, except with B and R channels switched. AV_PIX_FMT_X2BGR10 data often is created by OpenGL programs whose buffers use the GL_RGB10 internal format. Signed-off-by: Manuel Stoeckl --- doc/APIchanges

Re: [FFmpeg-devel] [PATCH v8 09/13] avfilter/textmod: Add textmod, censor and show_speaker filters

2021-09-21 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Wednesday, 22 September 2021 05:08 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v8 09/13] avfilter/textmod: Add textmod, > censor and show_speaker filters > [..] > This

Re: [FFmpeg-devel] [PATCH v8 11/13] avfilter/stripstyles: Add stripstyles filter

2021-09-21 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Andreas >> Rheinhardt >> Sent: Wednesday, 22 September 2021 04:48 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v8 11/13] avfilter/stripstyles: Add >> stripstyles filter >> >> Soft Works: >>>

Re: [FFmpeg-devel] [PATCH v8 11/13] avfilter/stripstyles: Add stripstyles filter

2021-09-21 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Wednesday, 22 September 2021 04:48 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v8 11/13] avfilter/stripstyles: Add > stripstyles filter > > Soft Works: > > > > > >> -Original

Re: [FFmpeg-devel] [PATCH v8 09/13] avfilter/textmod: Add textmod, censor and show_speaker filters

2021-09-21 Thread Andreas Rheinhardt
Soft Works: > - textmod {S -> S) > Modify subtitle text in a number of ways > > - censor {S -> S) > Censor subtitles using a word list > > - show_speaker {S -> S) > Prepend speaker names from ASS subtitles to the visible text lines > > Signed-off-by: softworkz > --- > doc/filters.texi

Re: [FFmpeg-devel] [PATCH v8 12/13] avfilter/split_cc: Add split_cc filter for closed caption handling

2021-09-21 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Wednesday, 22 September 2021 04:43 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v8 12/13] avfilter/split_cc: Add split_cc > filter for closed caption handling > > Soft Works: > >

Re: [FFmpeg-devel] [PATCH v8 11/13] avfilter/stripstyles: Add stripstyles filter

2021-09-21 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Andreas >> Rheinhardt >> Sent: Wednesday, 22 September 2021 03:58 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v8 11/13] avfilter/stripstyles: Add >> stripstyles filter >> >> Soft Works: >>>

Re: [FFmpeg-devel] [PATCH v8 12/13] avfilter/split_cc: Add split_cc filter for closed caption handling

2021-09-21 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Andreas >> Rheinhardt >> Sent: Wednesday, 22 September 2021 04:18 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v8 12/13] avfilter/split_cc: Add split_cc >> filter for closed caption handling

Re: [FFmpeg-devel] [PATCH v8 13/13] avfilter/graphicsub2text: Add new graphicsub2text filter (OCR)

2021-09-21 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Wednesday, 22 September 2021 04:26 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v8 13/13] avfilter/graphicsub2text: Add > new graphicsub2text filter (OCR) > > Soft Works: > > > >

Re: [FFmpeg-devel] [PATCH v8 12/13] avfilter/split_cc: Add split_cc filter for closed caption handling

2021-09-21 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Wednesday, 22 September 2021 04:18 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v8 12/13] avfilter/split_cc: Add split_cc > filter for closed caption handling > > > I wasn't sure

Re: [FFmpeg-devel] [PATCH v8 13/13] avfilter/graphicsub2text: Add new graphicsub2text filter (OCR)

2021-09-21 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Andreas >> Rheinhardt >> Sent: Wednesday, 22 September 2021 04:05 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v8 13/13] avfilter/graphicsub2text: Add >> new graphicsub2text filter (OCR) >>

Re: [FFmpeg-devel] [PATCH v8 12/13] avfilter/split_cc: Add split_cc filter for closed caption handling

2021-09-21 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Andreas >> Rheinhardt >> Sent: Wednesday, 22 September 2021 03:40 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v8 12/13] avfilter/split_cc: Add split_cc >> filter for closed caption handling

Re: [FFmpeg-devel] [PATCH v8 13/13] avfilter/graphicsub2text: Add new graphicsub2text filter (OCR)

2021-09-21 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Wednesday, 22 September 2021 04:05 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v8 13/13] avfilter/graphicsub2text: Add > new graphicsub2text filter (OCR) > > > + > > +static void

Re: [FFmpeg-devel] [PATCH v8 11/13] avfilter/stripstyles: Add stripstyles filter

2021-09-21 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Wednesday, 22 September 2021 03:58 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v8 11/13] avfilter/stripstyles: Add > stripstyles filter > > Soft Works: > > > > > >> -Original

Re: [FFmpeg-devel] [PATCH v8 13/13] avfilter/graphicsub2text: Add new graphicsub2text filter (OCR)

2021-09-21 Thread Andreas Rheinhardt
Soft Works: > Signed-off-by: softworkz > --- > configure| 1 + > doc/filters.texi | 55 ++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/sf_graphicsub2text.c | 326

Re: [FFmpeg-devel] [PATCH v8 12/13] avfilter/split_cc: Add split_cc filter for closed caption handling

2021-09-21 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Wednesday, 22 September 2021 03:40 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v8 12/13] avfilter/split_cc: Add split_cc > filter for closed caption handling > > Soft Works: > >

Re: [FFmpeg-devel] [PATCH v8 11/13] avfilter/stripstyles: Add stripstyles filter

2021-09-21 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Andreas >> Rheinhardt >> Sent: Wednesday, 22 September 2021 03:06 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v8 11/13] avfilter/stripstyles: Add >> stripstyles filter >> >> Soft Works: >>>

Re: [FFmpeg-devel] [PATCH v8 11/13] avfilter/stripstyles: Add stripstyles filter

2021-09-21 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Wednesday, 22 September 2021 03:06 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v8 11/13] avfilter/stripstyles: Add > stripstyles filter > > Soft Works: > > - stripstyles {S -> S)

Re: [FFmpeg-devel] [PATCH v8 12/13] avfilter/split_cc: Add split_cc filter for closed caption handling

2021-09-21 Thread Andreas Rheinhardt
Soft Works: > - split_cc {V -> VS) > Extract closed-caption (A53) data from video > frames as subtitle Frames > > ffmpeg -y -loglevel verbose -i > "https://streams.videolan.org/streams/ts/CC/NewsStream-608-ac3.ts; > -filter_complex >

Re: [FFmpeg-devel] [PATCH v8 11/13] avfilter/stripstyles: Add stripstyles filter

2021-09-21 Thread Andreas Rheinhardt
Soft Works: > - stripstyles {S -> S) > Remove all inline styles from subtitle events > > Signed-off-by: softworkz > --- > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/sf_stripstyles.c | 211 +++ > 3 files changed,

Re: [FFmpeg-devel] [PATCH v8 03/13] avfilter/subtitles: Add subtitles.c for subtitle frame allocation

2021-09-21 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Wednesday, 22 September 2021 02:00 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v8 03/13] avfilter/subtitles: Add > subtitles.c for subtitle frame allocation > > Soft Works: > >

Re: [FFmpeg-devel] [PATCH v8 03/13] avfilter/subtitles: Add subtitles.c for subtitle frame allocation

2021-09-21 Thread Andreas Rheinhardt
Soft Works: > Analog to avfilter/video.c and avfilter/audio.c > > Signed-off-by: softworkz > --- > libavfilter/Makefile| 1 + > libavfilter/avfilter.c | 4 +++ > libavfilter/internal.h | 1 + > libavfilter/subtitles.c | 61 + >

[FFmpeg-devel] [PATCH v8 13/13] avfilter/graphicsub2text: Add new graphicsub2text filter (OCR)

2021-09-21 Thread Soft Works
Signed-off-by: softworkz --- configure| 1 + doc/filters.texi | 55 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/sf_graphicsub2text.c | 326 +++ 5 files changed, 384

[FFmpeg-devel] [PATCH v8 12/13] avfilter/split_cc: Add split_cc filter for closed caption handling

2021-09-21 Thread Soft Works
- split_cc {V -> VS) Extract closed-caption (A53) data from video frames as subtitle Frames ffmpeg -y -loglevel verbose -i "https://streams.videolan.org/streams/ts/CC/NewsStream-608-ac3.ts; -filter_complex "[0:v]split_cc[vid1],textmod=mode=remove_chars:find='@',[vid1]overlay_textsubs"

[FFmpeg-devel] [PATCH v8 11/13] avfilter/stripstyles: Add stripstyles filter

2021-09-21 Thread Soft Works
- stripstyles {S -> S) Remove all inline styles from subtitle events Signed-off-by: softworkz --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/sf_stripstyles.c | 211 +++ 3 files changed, 213 insertions(+) create mode

[FFmpeg-devel] [PATCH v8 10/13] avcodec/ass_split: Extend ass dialog parsing

2021-09-21 Thread Soft Works
Signed-off-by: softworkz --- libavcodec/ass_split.c | 12 ++-- libavcodec/ass_split.h | 2 ++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/libavcodec/ass_split.c b/libavcodec/ass_split.c index 05c5453e53..e58585d3da 100644 --- a/libavcodec/ass_split.c +++

[FFmpeg-devel] [PATCH v8 09/13] avfilter/textmod: Add textmod, censor and show_speaker filters

2021-09-21 Thread Soft Works
- textmod {S -> S) Modify subtitle text in a number of ways - censor {S -> S) Censor subtitles using a word list - show_speaker {S -> S) Prepend speaker names from ASS subtitles to the visible text lines Signed-off-by: softworkz --- doc/filters.texi | 229

[FFmpeg-devel] [PATCH v8 08/13] avfilter/overlay_textsubs: Add overlay_textsubs and textsubs2video filters

2021-09-21 Thread Soft Works
- overlay_textsubs {VS -> V) Overlay text subtitles onto a video stream. - textsubs2video {S -> V) Converts text subtitles to video frames Signed-off-by: softworkz --- configure | 2 + doc/filters.texi | 69 libavfilter/Makefile

[FFmpeg-devel] [PATCH v8 07/13] fftools/ffmpeg: Replace sub2video with subtitle frame filtering

2021-09-21 Thread Soft Works
This commit actually enables subtitle filtering in ffmpeg by sending and receiving subtitle frames to and from a filtergraph. The heartbeat functionality from the previous sub2video implementation is retained and applied to all subtitle frames (bitmap, text, ..). The other part of sub2video

[FFmpeg-devel] [PATCH v8 06/13] avfilter/overlay_graphicsubs: Add overlay_graphicsubs and graphicsub2video filters

2021-09-21 Thread Soft Works
- overlay_graphicsubs (VS -> V) Overlay graphic subtitles onto a video stream - graphicsub2video {S -> V) Converts graphic subtitles to video frames (with alpha) Gets auto-inserted for retaining compatibility with sub2video command lines Signed-off-by: softworkz --- doc/filters.texi

[FFmpeg-devel] [PATCH v8 05/13] avfilter/sbuffer: Add sbuffersrc and sbuffersink filters

2021-09-21 Thread Soft Works
Signed-off-by: softworkz --- configure| 2 +- libavfilter/allfilters.c | 10 +++--- libavfilter/buffersink.c | 63 +++ libavfilter/buffersink.h | 15 + libavfilter/buffersrc.c | 72

[FFmpeg-devel] [PATCH v8 04/13] avfilter/avfilter: Handle subtitle frames

2021-09-21 Thread Soft Works
Signed-off-by: softworkz --- libavfilter/avfilter.c | 8 +--- libavfilter/avfiltergraph.c | 5 + libavfilter/formats.c | 14 ++ libavfilter/formats.h | 3 +++ 4 files changed, 27 insertions(+), 3 deletions(-) diff --git a/libavfilter/avfilter.c

[FFmpeg-devel] [PATCH v8 03/13] avfilter/subtitles: Add subtitles.c for subtitle frame allocation

2021-09-21 Thread Soft Works
Analog to avfilter/video.c and avfilter/audio.c Signed-off-by: softworkz --- libavfilter/Makefile| 1 + libavfilter/avfilter.c | 4 +++ libavfilter/internal.h | 1 + libavfilter/subtitles.c | 61 + libavfilter/subtitles.h | 44

[FFmpeg-devel] [PATCH v8 02/13] fftools/play, probe: Adjust for subtitle changes

2021-09-21 Thread Soft Works
Signed-off-by: softworkz --- fftools/ffplay.c | 79 --- fftools/ffprobe.c | 49 ++--- 2 files changed, 78 insertions(+), 50 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index ccea0e4578..470c652255 100644 ---

[FFmpeg-devel] [PATCH v8 01/13] global: Prepare AVFrame for subtitle handling

2021-09-21 Thread Soft Works
Root commit for adding subtitle filtering capabilities. In detail: - Add type (AVMediaType) field to AVFrame Replaces previous way of distinction which was based on checking width and height to determine whether a frame is audio or video - Add subtitle fields to AVFrame - Add new struct

[FFmpeg-devel] [PATCH v8 00/13] Subtitle Filtering

2021-09-21 Thread Soft Works
v8 Update: - Added new subtitle filters: graphicsub2text, censor, show_speaker (see below) - Added parameters to load words from file for textmod and censor - Copied copyright owners from vf_overlay to vf_overlay_graphicsubs - Remove "convenience" pointers (data) from AVSubtitleArea (not

[FFmpeg-devel] [PATCH 2/2] avcodec/apedec: Use unsigned in long_filter_ehigh_3830() to avoid undefined overflow

2021-09-21 Thread Michael Niedermayer
Fixes: signed integer overflow: -2145648640 - 3357696 cannot be represented in type 'int' Fixes: 38899/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-535881501756620 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 1/2] avformat/concatdec: Use FAIL() macro instead of direct return in concat_parse_script()

2021-09-21 Thread Michael Niedermayer
Fixes: memleak Fixes: 38893/clusterfuzz-testcase-minimized-ffmpeg_dem_CONCAT_fuzzer-4785231933079552 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/concatdec.c | 2 +- 1 file changed, 1

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/encode: Set AV_PKT_FLAG_KEY based upon AV_CODEC_PROP_INTRA_ONLY

2021-09-21 Thread James Almer
On 9/21/2021 7:35 PM, Andreas Rheinhardt wrote: James Almer: On 9/21/2021 7:18 PM, Andreas Rheinhardt wrote: Currently, the AV_PKT_FLAG_KEY is automatically set for audio encoders; yet this is wrong, as both MLP and TrueHD have non-keyframes. So set it based upon AV_CODEC_PROP_INTRA_ONLY (from

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/encode: Set AV_PKT_FLAG_KEY based upon AV_CODEC_PROP_INTRA_ONLY

2021-09-21 Thread Andreas Rheinhardt
James Almer: > On 9/21/2021 7:18 PM, Andreas Rheinhardt wrote: >> Currently, the AV_PKT_FLAG_KEY is automatically set for audio encoders; >> yet this is wrong, as both MLP and TrueHD have non-keyframes. So set it >> based upon AV_CODEC_PROP_INTRA_ONLY (from the corresponding >> AVCodecDescriptor)

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/encode: Set AV_PKT_FLAG_KEY based upon AV_CODEC_PROP_INTRA_ONLY

2021-09-21 Thread James Almer
On 9/21/2021 7:18 PM, Andreas Rheinhardt wrote: Currently, the AV_PKT_FLAG_KEY is automatically set for audio encoders; yet this is wrong, as both MLP and TrueHD have non-keyframes. So set it based upon AV_CODEC_PROP_INTRA_ONLY (from the corresponding AVCodecDescriptor) instead. This also sets

[FFmpeg-devel] [PATCH 5/5] avcodec/encoders: Remove redundant setting of AV_PKT_FLAG_KEY

2021-09-21 Thread Andreas Rheinhardt
It is now set generically for all those encoders whose corresponding AVCodecDescriptor has the AV_CODEC_PROP_INTRA_ONLY. Signed-off-by: Andreas Rheinhardt --- libavcodec/a64multienc.c| 1 - libavcodec/aliaspixenc.c| 1 - libavcodec/asvenc.c | 1 -

[FFmpeg-devel] [PATCH 4/5] avcodec/encode: Set AV_PKT_FLAG_KEY based upon AV_CODEC_PROP_INTRA_ONLY

2021-09-21 Thread Andreas Rheinhardt
Currently, the AV_PKT_FLAG_KEY is automatically set for audio encoders; yet this is wrong, as both MLP and TrueHD have non-keyframes. So set it based upon AV_CODEC_PROP_INTRA_ONLY (from the corresponding AVCodecDescriptor) instead. This also sets it for some video codecs, which is intended.

[FFmpeg-devel] [PATCH 3/5] avcodec/tests/codec_desc: Test for every AVCodec to have a descriptor

2021-09-21 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/tests/codec_desc.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/libavcodec/tests/codec_desc.c b/libavcodec/tests/codec_desc.c index c9b3497343..378e4c637f 100644 --- a/libavcodec/tests/codec_desc.c +++

[FFmpeg-devel] [PATCH 2/5] avcodec/codec_desc: Mark MLP as not being intra-only

2021-09-21 Thread Andreas Rheinhardt
It has sync frames. Signed-off-by: Andreas Rheinhardt --- libavcodec/codec_desc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index a06992fce8..d954f0a428 100644 --- a/libavcodec/codec_desc.c +++ b/libavcodec/codec_desc.c

[FFmpeg-devel] [PATCH 1/5] avcodec/mlpenc: Set AV_PKT_FLAG_KEY manually

2021-09-21 Thread Andreas Rheinhardt
TrueHD/MLP is one of the audio formats with keyframes. Currently, the generic encoding code just sets the keyframe flag for all returned packets, yet this is wrong for these encoders and will be changed in a future commit. So set the flag here for those packets that ought to have it.

Re: [FFmpeg-devel] [PATCH] ffmpeg_filter: don't try to autorotate frames with hwaccel pixel formats

2021-09-21 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of James Almer > Sent: Tuesday, 21 September 2021 14:33 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH] ffmpeg_filter: don't try to autorotate frames > with hwaccel pixel formats > > The transpose, rotate, hflip, and

[FFmpeg-devel] [PATCH] avcodec: add native Speex decoder

2021-09-21 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile|1 + libavcodec/allcodecs.c |1 + libavcodec/speexdata.h | 780 +++ libavcodec/speexdec.c | 1616 4 files changed, 2398 insertions(+) create mode 100644

Re: [FFmpeg-devel] [PATCH] avcodec: add native Speex decoder

2021-09-21 Thread Michael Niedermayer
On Tue, Sep 21, 2021 at 12:33:40AM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/Makefile|1 + > libavcodec/allcodecs.c |1 + > libavcodec/speexdata.h | 780 > libavcodec/speexdec.c | 1584 >

Re: [FFmpeg-devel] [PATCH] avformat/westwood_vqa: Store VQFL codebook chunks

2021-09-21 Thread Andreas Rheinhardt
Pekka Väänänen: > High color 15-bit VQA3 video streams contain high level chunks with > only codebook updates that shouldn't be considered new frames. Now > the demuxer stores a reference to such VQFL chunks and returns them > later along with a VQFR chunk with full frame data. > --- >

[FFmpeg-devel] [PATCH 4/4] libavformat/hls: correct indentation

2021-09-21 Thread Nachiket Tarate
Signed-off-by: Nachiket Tarate --- libavformat/hls.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 0feddb06e4..3c34d69538 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -2051,23

[FFmpeg-devel] [PATCH 3/4] libavformat/hls: add support for decryption of HLS media segments encrypted using SAMPLE-AES encryption method

2021-09-21 Thread Nachiket Tarate
Apple HTTP Live Streaming Sample Encryption: https://developer.apple.com/library/ios/documentation/AudioVideo/Conceptual/HLS_Sample_Encryption Signed-off-by: Nachiket Tarate --- libavformat/Makefile| 2 +- libavformat/hls.c | 128 +++--

[FFmpeg-devel] [PATCH 2/4] libavformat/mov: add support for 'cens', 'cbc1' and 'cbcs' encryption schemes specified in Common Encryption (CENC) standard

2021-09-21 Thread Nachiket Tarate
correct implementation of 'cenc' encryption scheme to support decryption of partial cipher blocks at the end of subsamples https://www.iso.org/standard/68042.html Signed-off-by: Nachiket Tarate --- libavformat/isom.h | 2 + libavformat/mov.c | 245

[FFmpeg-devel] [PATCH 1/4] libavcodec/adts_header: add frame_length field and avpriv function to parse AAC ADTS header

2021-09-21 Thread Nachiket Tarate
These will be used by HLS demuxer in case of sample decryption. Signed-off-by: Nachiket Tarate --- libavcodec/adts_header.c | 1 + libavcodec/adts_header.h | 15 +++ libavcodec/adts_parser.c | 31 +++ 3 files changed, 47 insertions(+) diff --git

[FFmpeg-devel] [PATCH] avformat/westwood_vqa: Store VQFL codebook chunks

2021-09-21 Thread Pekka Väänänen
High color 15-bit VQA3 video streams contain high level chunks with only codebook updates that shouldn't be considered new frames. Now the demuxer stores a reference to such VQFL chunks and returns them later along with a VQFR chunk with full frame data. --- libavformat/westwood_vqa.c | 51

[FFmpeg-devel] (no subject)

2021-09-21 Thread Pekka Väänänen
> This is a cosmetic change. It should not be part of a commit for a > functional change (unless you already have to touch that line anyway (in > which case you should beautify the line)). Fixed. > > +if (av_get_packet(pb, pkt, > > wsvqa->vqfl_chunk_size) < 0) > > +

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mlpenc: fix encoding stereo single stream in TrueHD

2021-09-21 Thread Anton Khirnov
Quoting Paul B Mahol (2021-09-21 08:53:17) > On Tue, Sep 21, 2021 at 8:43 AM Anton Khirnov wrote: > > > Quoting Paul B Mahol (2021-09-20 19:40:33) > > > On Mon, Sep 20, 2021 at 12:56 PM Anton Khirnov > > wrote: > > > > > > > Quoting Paul B Mahol (2021-09-18 19:21:05) > > > > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH] avformat/westwood_vqa: Store VQFL codebook chunks

2021-09-21 Thread Andreas Rheinhardt
Pekka Väänänen: > High color 15-bit VQA3 video streams contain high level chunks with > only codebook updates that shouldn't be considered new frames. Now > the demuxer stores a reference to such VQFL chunks and returns them > later along with a VQFR chunk with full frame data. > --- >

Re: [FFmpeg-devel] Westwood VQA3 demuxer additions

2021-09-21 Thread Pekka Väänänen
Thanks for the quick reply. > It's fine, but you do want to use ffio_ensure_seekback() to guarantee > success, preferably calling it at just the moment the stream is at the > position you're planning on rewinding back to. I realized that ffio_ensure_seekback() won't be enough because the

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_pel: fix stack-buffer-overflow

2021-09-21 Thread zhilizhao(赵志立)
> On Sep 21, 2021, at 10:40 PM, Andreas Rheinhardt > wrote: > > Martin Storsjö: >> On Tue, 21 Sep 2021, Zhao Zhili wrote: >> >>> ==225880==ERROR: AddressSanitizer: stack-buffer-overflow on address ... >>> READ of size 2 at 0x7fffe49ab400 thread T0 >>>#0 0x18301da in put_hevc_qpel_hv_9

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_pel: fix stack-buffer-overflow

2021-09-21 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Martin Storsjö: >> On Tue, 21 Sep 2021, Zhao Zhili wrote: >> >>> ==225880==ERROR: AddressSanitizer: stack-buffer-overflow on address ... >>> READ of size 2 at 0x7fffe49ab400 thread T0 >>>    #0 0x18301da in put_hevc_qpel_hv_9 >>> src/libavcodec/hevcdsp_template.c:666 >>>   

Re: [FFmpeg-devel] [PATCH] ffmpeg_filter: don't try to autorotate frames with hwaccel pixel formats

2021-09-21 Thread zhilizhao(赵志立)
> On Sep 21, 2021, at 8:32 PM, James Almer wrote: > > The transpose, rotate, hflip, and vflip filters don't support them. > Fixes ticket #9432. > > Signed-off-by: James Almer > --- > I'm surprised nobody tried to decode an mp4 video like those coming from a > cellphone camera using a hwaccel

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_pel: fix stack-buffer-overflow

2021-09-21 Thread Andreas Rheinhardt
Martin Storsjö: > On Tue, 21 Sep 2021, Zhao Zhili wrote: > >> ==225880==ERROR: AddressSanitizer: stack-buffer-overflow on address ... >> READ of size 2 at 0x7fffe49ab400 thread T0 >>    #0 0x18301da in put_hevc_qpel_hv_9 >> src/libavcodec/hevcdsp_template.c:666 >>    #1 0x6c6bc4 in

Re: [FFmpeg-devel] [PATCH] ffmpeg_filter: don't try to autorotate frames with hwaccel pixel formats

2021-09-21 Thread James Almer
On 9/21/2021 10:07 AM, Nicolas George wrote: James Almer (12021-09-21): The transpose, rotate, hflip, and vflip filters don't support them. Fixes ticket #9432. Signed-off-by: James Almer --- I'm surprised nobody tried to decode an mp4 video like those coming from a cellphone camera using a

Re: [FFmpeg-devel] [PATCH] ffmpeg_filter: don't try to autorotate frames with hwaccel pixel formats

2021-09-21 Thread Nicolas George
James Almer (12021-09-21): > The transpose, rotate, hflip, and vflip filters don't support them. > Fixes ticket #9432. > > Signed-off-by: James Almer > --- > I'm surprised nobody tried to decode an mp4 video like those coming from a > cellphone camera using a hwaccel decoder. This would have

Re: [FFmpeg-devel] [PATCH] ffmpeg_filter: don't try to autorotate frames with hwaccel pixel formats

2021-09-21 Thread Eoff, Ullysses A
> -Original Message- > From: ffmpeg-devel On Behalf Of James Almer > Sent: Tuesday, September 21, 2021 5:33 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH] ffmpeg_filter: don't try to autorotate frames > with hwaccel pixel formats > > The transpose, rotate, hflip, and

[FFmpeg-devel] [PATCH] ffmpeg_filter: don't try to autorotate frames with hwaccel pixel formats

2021-09-21 Thread James Almer
The transpose, rotate, hflip, and vflip filters don't support them. Fixes ticket #9432. Signed-off-by: James Almer --- I'm surprised nobody tried to decode an mp4 video like those coming from a cellphone camera using a hwaccel decoder. This would have been noticed much earlier.

Re: [FFmpeg-devel] [PATCH v1 1/1] avformat/amr: Return PATCHWELCOME on stereo files

2021-09-21 Thread Sun Zhenliang
ping. Anyone could review this ? > On Sep 18, 2021, at 20:40, Sun Zhenliang wrote: > > Ping. > 在 2021年9月17日 +0800 15:28,Sun Zhenliang ,写道: >> 在 2021年9月17日 +0800 14:49,Paul B Mahol ,写道: >>> Are stereo files available somewhere? Known way to encode? >> Here is the stereo file, >>

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_pel: fix stack-buffer-overflow

2021-09-21 Thread Martin Storsjö
On Tue, 21 Sep 2021, Zhao Zhili wrote: ==225880==ERROR: AddressSanitizer: stack-buffer-overflow on address ... READ of size 2 at 0x7fffe49ab400 thread T0 #0 0x18301da in put_hevc_qpel_hv_9 src/libavcodec/hevcdsp_template.c:666 #1 0x6c6bc4 in checkasm_check_hevc_qpel

Re: [FFmpeg-devel] [PATCH] configure: arm: Don't add -march= to the compiler if no preference was passed

2021-09-21 Thread Martin Storsjö
On Mon, 20 Sep 2021, Gianfranco Costamagna wrote: Hello, thanks! this fixes nicely my problem, and makes useless the two patches I posted here: please remove and drop: https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=4892 https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=4890

[FFmpeg-devel] [PATCH] checkasm/hevc_pel: fix stack-buffer-overflow

2021-09-21 Thread Zhao Zhili
==225880==ERROR: AddressSanitizer: stack-buffer-overflow on address ... READ of size 2 at 0x7fffe49ab400 thread T0 #0 0x18301da in put_hevc_qpel_hv_9 src/libavcodec/hevcdsp_template.c:666 #1 0x6c6bc4 in checkasm_check_hevc_qpel src/tests/checkasm/hevc_pel.c:97 #2 0x6cecc8 in

Re: [FFmpeg-devel] [PATCH] configure: arm: Don't add -march= to the compiler if no preference was passed

2021-09-21 Thread Janne Grunau
Hej, On 2021-09-20 13:00:40 +0300, Martin Storsjö wrote: > If no --cpu= option was passed to configure, we detect what the > compiler defaults to. This detected value was then fed back to the > rest of the configure logic, as if it was an explicit choice. > > This breaks on Ubuntu 21.10 with GCC

Re: [FFmpeg-devel] [PATCH 01/26] avfilter/af_afade: Remove redundant checks and assignments

2021-09-21 Thread Paul B Mahol
also rest of patch set lgtm, it is very trivial changes. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

Re: [FFmpeg-devel] [PATCH 26/26] avfilter/vf_geq: Simplify creating string

2021-09-21 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 05/26] avfilter/af_amerge: Remove always-false samplerate check

2021-09-21 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 04/26] avfilter/af_agate: Remove always-false samplerate check

2021-09-21 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 03/26] avfilter/af_sidechaincompress: Honour query_formats API, fix segfault

2021-09-21 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 06/26] avfilter/af_sidechaincompress: Remove always-false samplerate check

2021-09-21 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 02/26] avfilter/af_agate: Honour query_formats API, fix segfault

2021-09-21 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mlpenc: fix encoding stereo single stream in TrueHD

2021-09-21 Thread Paul B Mahol
On Tue, Sep 21, 2021 at 8:43 AM Anton Khirnov wrote: > Quoting Paul B Mahol (2021-09-20 19:40:33) > > On Mon, Sep 20, 2021 at 12:56 PM Anton Khirnov > wrote: > > > > > Quoting Paul B Mahol (2021-09-18 19:21:05) > > > > Signed-off-by: Paul B Mahol > > > > --- > > > > libavcodec/mlpenc.c | 2 +-

Re: [FFmpeg-devel] [PATCH 01/26] avfilter/af_afade: Remove redundant checks and assignments

2021-09-21 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 25/26] avfilter/vf_xfade: Remove always-false format check

2021-09-21 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mlpenc: fix encoding stereo single stream in TrueHD

2021-09-21 Thread Anton Khirnov
Quoting Paul B Mahol (2021-09-20 19:40:33) > On Mon, Sep 20, 2021 at 12:56 PM Anton Khirnov wrote: > > > Quoting Paul B Mahol (2021-09-18 19:21:05) > > > Signed-off-by: Paul B Mahol > > > --- > > > libavcodec/mlpenc.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Sure

[FFmpeg-devel] [PATCH 26/26] avfilter/vf_geq: Simplify creating string

2021-09-21 Thread Andreas Rheinhardt
Also fixes a Wformat-truncation warning from GCC. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_geq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavfilter/vf_geq.c b/libavfilter/vf_geq.c index 4a78336540..1dc59dc1fa 100644 --- a/libavfilter/vf_geq.c +++

[FFmpeg-devel] [PATCH 25/26] avfilter/vf_xfade: Remove always-false format check

2021-09-21 Thread Andreas Rheinhardt
This filter uses ff_set_common_formats_from_list(). Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_xfade.c | 4 1 file changed, 4 deletions(-) diff --git a/libavfilter/vf_xfade.c b/libavfilter/vf_xfade.c index eff8a8b854..b4edcbf1b4 100644 --- a/libavfilter/vf_xfade.c +++

[FFmpeg-devel] [PATCH 24/26] avfilter/vf_vif: Remove always-false format check

2021-09-21 Thread Andreas Rheinhardt
This filter uses ff_set_common_formats_from_list(). Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_vif.c | 4 1 file changed, 4 deletions(-) diff --git a/libavfilter/vf_vif.c b/libavfilter/vf_vif.c index da3069c1f6..ee7c67337d 100644 --- a/libavfilter/vf_vif.c +++

[FFmpeg-devel] [PATCH 23/26] avfilter/vf_threshold: Remove always-false format check

2021-09-21 Thread Andreas Rheinhardt
This filter uses ff_set_common_formats_from_list(). Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_threshold.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/libavfilter/vf_threshold.c b/libavfilter/vf_threshold.c index 828f7a8746..b6b93fef6f 100644 ---

[FFmpeg-devel] [PATCH 22/26] avfilter/vf_ssim: Remove always-false format check

2021-09-21 Thread Andreas Rheinhardt
This filter uses ff_set_common_formats_from_list(). Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_ssim.c | 4 1 file changed, 4 deletions(-) diff --git a/libavfilter/vf_ssim.c b/libavfilter/vf_ssim.c index 61a84ff990..14d7ab3ec6 100644 --- a/libavfilter/vf_ssim.c +++

  1   2   >