Re: [FFmpeg-devel] [PATCH] avcodec/h263: Fix global-buffer-overflow with noout flag2 set

2021-11-25 Thread Andreas Rheinhardt
Andreas Rheinhardt: > h263_get_motion_length() forgot to take an absolute value; > as a consequence, a negative index was used to access an array. > This leads to potential crashes, but mostly it just accesses what > is to the left of ff_mvtab (unless one uses ASAN), thereby defeating > the

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Take type limitations of AVFifo API into account

2021-11-25 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The types used by the AVFifo API are inconsistent: > av_fifo_(space|size)() returns an int; av_fifo_alloc() takes an > unsigned, other parts use size_t. This commit therefore ensures > that the size of the muxing_queue FIFO never exceeds INT_MAX. > > While just at it, also

Re: [FFmpeg-devel] [PATCH 2/2] Revert "Disable warnings for casting pointers to integers, there is nothing wrong with that."

2021-11-25 Thread Andreas Rheinhardt
Andreas Rheinhardt: > This reverts commit 5258f64a14713499cf84840b3ab3a1ee7cdcaeb8. > The premise of said commit (that conversions from pointer to int > are ok) is wrong: C99/C11 6.3.2.3 5: "Any pointer type may be converted > to an integer type. [...] If the result cannot be represented in the >

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/src_movie: add format_opts for the opened file

2021-11-25 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/filters.texi| 5 + > libavfilter/src_movie.c | 8 +++- > 2 files changed, 12 insertions(+), 1 deletion(-) > > diff --git a/doc/filters.texi b/doc/filters.texi > index c3ccaf9..6c35788 100644 >

[FFmpeg-devel] [PATCH V3 5/5] libavutil/hwcontext_vulkan: specify the modifier to create VKImage

2021-11-25 Thread Wenbin Chen
When vulkan image exports to drm, the tilling need to be VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT. Now add code to create vulkan image using this format. Now the following command line works: ffmpeg -hwaccel vaapi -hwaccel_device /dev/dri/renderD128 -hwaccel_output_format \ vaapi -i

[FFmpeg-devel] [PATCH V3 4/5] libavutil/hwcontext_vulkan: Add support to hwmap to software frame when using contiguous_planes flag.

2021-11-25 Thread Wenbin Chen
Add support to map vulkan frames to software frames when using contiguous_planes flag. Signed-off-by: Wenbin Chen --- libavutil/hwcontext_vulkan.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index

[FFmpeg-devel] [PATCH V3 3/5] libavutil/hwcontext_vulkan: Allocate vkFrame in one memory

2021-11-25 Thread Wenbin Chen
The vaapi can import external frame, but the planes of the external frames should be in the same drm object. A new option "contiguous_planes" is added to device. This flag tells device to allocate places in one memory. When device is derived from vaapi this flag will be enabled. A new flag

[FFmpeg-devel] [PATCH V3 2/5] libavutil/hwcontext_vaapi: Add a new nv12 format map to support vulkan frame

2021-11-25 Thread Wenbin Chen
Vulkan will map nv12 to R8 and GR88, so add this map to vaapi to support vulkan frame. Signed-off-by: Wenbin Chen --- libavutil/hwcontext_vaapi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c index 75acc851d6..994b744e4d 100644 ---

[FFmpeg-devel] [PATCH V3 1/5] hwcontext_vaapi: Use PRIME_2 memory type for modifiers.

2021-11-25 Thread Wenbin Chen
From: Bas Nieuwenhuizen This way we can pass explicit modifiers in. Sometimes the modifier matters for the number of memory planes that libva accepts, in particular when dealing with driver-compressed textures. Furthermore the driver might not actually be able to determine the implicit modifier

Re: [FFmpeg-devel] [PATCH 1/2] avformat/rtp: add localaddr for network interface selection

2021-11-25 Thread lance . lmwang
On Thu, Nov 25, 2021 at 10:09:17PM +0200, Martin Storsjö wrote: > On Thu, 25 Nov 2021, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > doc/protocols.texi | 4 > > libavformat/rtpproto.c | 17 ++--- > > libavformat/rtsp.c

Re: [FFmpeg-devel] [PATCH v2] lavu/avframe: add a time_base field

2021-11-25 Thread Marton Balint
On Thu, 25 Nov 2021, Lynne wrote: This adds a time_base field (currently unused), analogue to the AVPacket.time_base field. This allows for API clients to exchange AVFrames directly, without needing to plumb extra data from sources via side mechanisms. The objections raised before still

[FFmpeg-devel] [PATCH 2/2] avformat/mxf: add documentation for eia608_extract parameter

2021-11-25 Thread Marc-Antoine Arnaud
--- doc/demuxers.texi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index 23b6753602..587ce11c95 100644 --- a/doc/demuxers.texi +++ b/doc/demuxers.texi @@ -776,6 +776,9 @@ MXF demuxer. @table @option +@item -eia608_extract @var{bool} +Extract

[FFmpeg-devel] [PATCH 1/2] avformat/mxf: support MCA audio information

2021-11-25 Thread Marc-Antoine Arnaud
--- doc/demuxers.texi | 10 ++ libavformat/mxf.h | 1 + libavformat/mxfdec.c | 293 +- libavformat/version.h | 2 +- 4 files changed, 299 insertions(+), 7 deletions(-) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index

Re: [FFmpeg-devel] [PATCH 1/2] avformat/rtp: add localaddr for network interface selection

2021-11-25 Thread Martin Storsjö
On Thu, 25 Nov 2021, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- doc/protocols.texi | 4 libavformat/rtpproto.c | 17 ++--- libavformat/rtsp.c | 3 +++ libavformat/rtsp.h | 1 + 4 files changed, 22 insertions(+), 3 deletions(-)

[FFmpeg-devel] [PATCH] webp: implement FF_CODEC_CAP_SKIP_FRAME_FILL_PARAM

2021-11-25 Thread Alex Xu (Hello71)
Roughly doubles webp performance for common applications (ffmpeg, ffprobe, mpv) due to speeding up avformat_find_stream_info. Lossy needs no patches since vp8.c already implements skip_frame. Lossless needs hook to understand skip_frame. Also the "image data not found" message is fixed, which was

[FFmpeg-devel] [PATCH] avformat/img2dec: probe JFIF/Exif header

2021-11-25 Thread Alex Xu (Hello71)
Due to reasons, mpv doesn't pass filename when probing. mpv also sets default probescore threshold to 26. Since the current jpeg_probe implementation returns 25 until EOI, it means that the whole image needs to be probed to succeed. Worse, the whole image is not passed at once; increasingly large

[FFmpeg-devel] [PATCH] avfilter: add audio dynamic smooth filter

2021-11-25 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi| 20 + libavfilter/Makefile| 1 + libavfilter/af_adynamicsmooth.c | 142 libavfilter/allfilters.c| 1 + 4 files changed, 164 insertions(+) create mode 100644

[FFmpeg-devel] [PATCH] avcodec/mjpeg_parser: skip markers after EOI, not by size

2021-11-25 Thread Alex Xu (Hello71)
The check for m->size >= 0xF000 is intended to avoid skipping too much garbage data between JPEG frames in test_roman (thus missing next SOI), but it erroneously also skips valid markers between SOI and SOS. Instead of this, we should simply skip parsing markers other than SOI after EOI. That way,

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: fix stream index in verbose log message

2021-11-25 Thread Marton Balint
On Mon, 22 Nov 2021, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/mpegts.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 29a267436f..36ab7ab3af 100644 --- a/libavformat/mpegts.c +++

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: add missing version check for snddropdelay

2021-11-25 Thread Marton Balint
On Sat, 20 Nov 2021, lance.lmw...@gmail.com wrote: On Fri, Nov 19, 2021 at 09:29:01PM +0100, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/libsrt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c index

[FFmpeg-devel] [PATCH v16 16/16] fftools/ffmpeg: Use new frame-based subtitle encoding API

2021-11-25 Thread Soft Works
Signed-off-by: softworkz --- fftools/ffmpeg.c | 60 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index c697c12777..603b4c23e0 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -896,10

[FFmpeg-devel] [PATCH v16 15/16] avcodec/subtitles: Migrate subtitle encoders to frame-based API and provide a compatibility shim for the legacy api

2021-11-25 Thread Soft Works
Also introduce deferred loading of ass headers for all cases where it can't be taken from the context of a decoder. Signed-off-by: softworkz --- libavcodec/assenc.c| 81 - libavcodec/avcodec.h | 7 +++ libavcodec/dvbsubenc.c | 85

[FFmpeg-devel] [PATCH v16 14/16] avfilter/subscale: Add filter for scaling and/or re-arranging graphical subtitles

2021-11-25 Thread Soft Works
Signed-off-by: softworkz --- configure | 1 + doc/filters.texi | 164 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/sf_subscale.c | 883 ++ 5 files changed, 1050 insertions(+) create mode

[FFmpeg-devel] [PATCH v16 13/16] avfilter/graphicsub2text: Add new graphicsub2text filter (OCR)

2021-11-25 Thread Soft Works
Signed-off-by: softworkz --- configure| 1 + doc/filters.texi | 55 + libavfilter/Makefile | 2 + libavfilter/allfilters.c | 1 + libavfilter/sf_graphicsub2text.c | 354 +++ 5 files changed, 413

[FFmpeg-devel] [PATCH v16 12/16] avfilter/splitcc: Add splitcc filter for closed caption handling

2021-11-25 Thread Soft Works
- splitcc {V -> VS) Extract closed-caption (A53) data from video frames as subtitle Frames ffmpeg -y -loglevel verbose -i "https://streams.videolan.org/streams/ts/CC/NewsStream-608-ac3.ts; -filter_complex "[0:v]splitcc[vid1],textmod=mode=remove_chars:find='@',[vid1]overlay_textsubs"

[FFmpeg-devel] [PATCH v16 11/16] avfilter/stripstyles: Add stripstyles filter

2021-11-25 Thread Soft Works
- stripstyles {S -> S) Remove all inline styles from subtitle events Signed-off-by: softworkz --- doc/filters.texi | 37 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/sf_stripstyles.c | 196 +++ 4

[FFmpeg-devel] [PATCH v16 10/16] avfilter/textmod: Add textmod, censor and show_speaker filters

2021-11-25 Thread Soft Works
- textmod {S -> S) Modify subtitle text in a number of ways - censor {S -> S) Censor subtitles using a word list - show_speaker {S -> S) Prepend speaker names from ASS subtitles to the visible text lines Signed-off-by: softworkz --- doc/filters.texi | 206

[FFmpeg-devel] [PATCH v16 09/16] avfilter/overlaytextsubs: Add overlaytextsubs and textsubs2video filters

2021-11-25 Thread Soft Works
- overlaytextsubs {VS -> V) Overlay text subtitles onto a video stream. - textsubs2video {S -> V) Converts text subtitles to video frames Signed-off-by: softworkz --- configure| 2 + doc/filters.texi | 113 ++ libavfilter/Makefile |

[FFmpeg-devel] [PATCH v16 08/16] fftools/ffmpeg: Replace sub2video with subtitle frame filtering

2021-11-25 Thread Soft Works
This commit actually enables subtitle filtering in ffmpeg by sending and receiving subtitle frames to and from a filtergraph. The heartbeat functionality from the previous sub2video implementation is retained and applied to all subtitle frames (bitmap, text, ..). The other part of sub2video

[FFmpeg-devel] [PATCH v16 07/16] avfilter/overlaygraphicsubs: Add overlaygraphicsubs and graphicsub2video filters

2021-11-25 Thread Soft Works
- overlaygraphicsubs (VS -> V) Overlay graphic subtitles onto a video stream - graphicsub2video {S -> V) Converts graphic subtitles to video frames (with alpha) Gets auto-inserted for retaining compatibility with sub2video command lines Signed-off-by: softworkz --- doc/filters.texi

[FFmpeg-devel] [PATCH v16 06/16] avfilter/sbuffer: Add sbuffersrc and sbuffersink filters

2021-11-25 Thread Soft Works
Signed-off-by: softworkz --- configure| 2 +- libavfilter/allfilters.c | 2 ++ libavfilter/buffersink.c | 63 +++ libavfilter/buffersink.h | 15 + libavfilter/buffersrc.c | 72

[FFmpeg-devel] [PATCH v16 05/16] avfilter/avfilter: Handle subtitle frames

2021-11-25 Thread Soft Works
Signed-off-by: softworkz --- libavfilter/avfilter.c | 8 +--- libavfilter/avfilter.h | 11 +++ libavfilter/avfiltergraph.c | 5 + libavfilter/formats.c | 22 ++ libavfilter/formats.h | 3 +++ libavfilter/internal.h | 18

[FFmpeg-devel] [PATCH v16 04/16] avfilter/subtitles: Add subtitles.c for subtitle frame allocation

2021-11-25 Thread Soft Works
Analog to avfilter/video.c and avfilter/audio.c Signed-off-by: softworkz --- libavfilter/Makefile| 1 + libavfilter/avfilter.c | 4 +++ libavfilter/internal.h | 1 + libavfilter/subtitles.c | 63 + libavfilter/subtitles.h | 44

[FFmpeg-devel] [PATCH v16 03/16] fftools/play, probe: Adjust for subtitle changes

2021-11-25 Thread Soft Works
Signed-off-by: softworkz --- fftools/ffplay.c | 102 +- fftools/ffprobe.c | 48 ++ 2 files changed, 78 insertions(+), 72 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index e7b20be76b..0af32888da 100644 ---

[FFmpeg-devel] [PATCH v16 02/16] global: Move ass helper functions to avutil as avpriv_ and extend ass dialog parsing

2021-11-25 Thread Soft Works
Signed-off-by: softworkz --- libavcodec/Makefile | 56 +++ libavcodec/ass.h | 129 libavcodec/assdec.c | 2 +- libavcodec/assenc.c | 2 +-

[FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for subtitle handling

2021-11-25 Thread Soft Works
Root commit for adding subtitle filtering capabilities. In detail: - Add type (AVMediaType) field to AVFrame Replaces previous way of distinction which was based on checking width and height to determine whether a frame is audio or video - Add subtitle fields to AVFrame - Add new struct

[FFmpeg-devel] [PATCH v16 00/16] Subtitle Filtering

2021-11-25 Thread Soft Works
Root commit for adding subtitle filtering capabilities. In detail: - Add type (AVMediaType) field to AVFrame Replaces previous way of distinction which was based on checking width and height to determine whether a frame is audio or video - Add subtitle fields to AVFrame - Add new struct

[FFmpeg-devel] [PATCH v15 16/16] fftools/ffmpeg: Use new frame-based subtitle encoding API

2021-11-25 Thread Soft Works
Signed-off-by: softworkz --- fftools/ffmpeg.c | 60 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index c697c12777..603b4c23e0 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -896,10

[FFmpeg-devel] [PATCH v15 15/16] avcodec/subtitles: Migrate subtitle encoders to frame-based API and provide a compatibility shim for the legacy api

2021-11-25 Thread Soft Works
Also introduce deferred loading of ass headers for all cases where it can't be taken from the context of a decoder. Signed-off-by: softworkz --- libavcodec/assenc.c| 81 - libavcodec/avcodec.h | 7 +++ libavcodec/dvbsubenc.c | 85

[FFmpeg-devel] [PATCH v15 14/16] avfilter/subscale: Add filter for scaling and/or re-arranging graphical subtitles

2021-11-25 Thread Soft Works
Signed-off-by: softworkz --- configure | 1 + doc/filters.texi | 164 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/sf_subscale.c | 883 ++ 5 files changed, 1050 insertions(+) create mode

[FFmpeg-devel] [PATCH v15 13/16] avfilter/graphicsub2text: Add new graphicsub2text filter (OCR)

2021-11-25 Thread Soft Works
Signed-off-by: softworkz --- configure| 1 + doc/filters.texi | 55 + libavfilter/Makefile | 2 + libavfilter/allfilters.c | 1 + libavfilter/sf_graphicsub2text.c | 354 +++ 5 files changed, 413

[FFmpeg-devel] [PATCH v15 12/16] avfilter/splitcc: Add splitcc filter for closed caption handling

2021-11-25 Thread Soft Works
- splitcc {V -> VS) Extract closed-caption (A53) data from video frames as subtitle Frames ffmpeg -y -loglevel verbose -i "https://streams.videolan.org/streams/ts/CC/NewsStream-608-ac3.ts; -filter_complex "[0:v]splitcc[vid1],textmod=mode=remove_chars:find='@',[vid1]overlay_textsubs"

[FFmpeg-devel] [PATCH v15 11/16] avfilter/stripstyles: Add stripstyles filter

2021-11-25 Thread Soft Works
- stripstyles {S -> S) Remove all inline styles from subtitle events Signed-off-by: softworkz --- doc/filters.texi | 37 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/sf_stripstyles.c | 196 +++ 4

[FFmpeg-devel] [PATCH v15 10/16] avfilter/textmod: Add textmod, censor and show_speaker filters

2021-11-25 Thread Soft Works
- textmod {S -> S) Modify subtitle text in a number of ways - censor {S -> S) Censor subtitles using a word list - show_speaker {S -> S) Prepend speaker names from ASS subtitles to the visible text lines Signed-off-by: softworkz --- doc/filters.texi | 206

[FFmpeg-devel] [PATCH v15 09/16] avfilter/overlaytextsubs: Add overlaytextsubs and textsubs2video filters

2021-11-25 Thread Soft Works
- overlaytextsubs {VS -> V) Overlay text subtitles onto a video stream. - textsubs2video {S -> V) Converts text subtitles to video frames Signed-off-by: softworkz --- configure| 2 + doc/filters.texi | 113 ++ libavfilter/Makefile |

[FFmpeg-devel] [PATCH v15 08/16] fftools/ffmpeg: Replace sub2video with subtitle frame filtering

2021-11-25 Thread Soft Works
This commit actually enables subtitle filtering in ffmpeg by sending and receiving subtitle frames to and from a filtergraph. The heartbeat functionality from the previous sub2video implementation is retained and applied to all subtitle frames (bitmap, text, ..). The other part of sub2video

[FFmpeg-devel] [PATCH v15 05/16] avfilter/avfilter: Handle subtitle frames

2021-11-25 Thread Soft Works
Signed-off-by: softworkz --- libavfilter/avfilter.c | 8 +--- libavfilter/avfilter.h | 11 +++ libavfilter/avfiltergraph.c | 5 + libavfilter/formats.c | 22 ++ libavfilter/formats.h | 3 +++ libavfilter/internal.h | 18

[FFmpeg-devel] [PATCH v15 04/16] avfilter/subtitles: Add subtitles.c for subtitle frame allocation

2021-11-25 Thread Soft Works
Analog to avfilter/video.c and avfilter/audio.c Signed-off-by: softworkz --- libavfilter/Makefile| 1 + libavfilter/avfilter.c | 4 +++ libavfilter/internal.h | 1 + libavfilter/subtitles.c | 63 + libavfilter/subtitles.h | 44

[FFmpeg-devel] [PATCH v15 07/16] avfilter/overlaygraphicsubs: Add overlaygraphicsubs and graphicsub2video filters

2021-11-25 Thread Soft Works
- overlaygraphicsubs (VS -> V) Overlay graphic subtitles onto a video stream - graphicsub2video {S -> V) Converts graphic subtitles to video frames (with alpha) Gets auto-inserted for retaining compatibility with sub2video command lines Signed-off-by: softworkz --- doc/filters.texi

[FFmpeg-devel] [PATCH v15 06/16] avfilter/sbuffer: Add sbuffersrc and sbuffersink filters

2021-11-25 Thread Soft Works
Signed-off-by: softworkz --- configure| 2 +- libavfilter/allfilters.c | 2 ++ libavfilter/buffersink.c | 63 +++ libavfilter/buffersink.h | 15 + libavfilter/buffersrc.c | 72

[FFmpeg-devel] [PATCH v15 02/16] global: Move ass helper functions to avutil as avpriv_ and extend ass dialog parsing

2021-11-25 Thread Soft Works
Signed-off-by: softworkz --- libavcodec/Makefile | 56 +++ libavcodec/ass.h | 129 libavcodec/assdec.c | 2 +- libavcodec/assenc.c | 2 +-

[FFmpeg-devel] [PATCH v15 03/16] fftools/play, probe: Adjust for subtitle changes

2021-11-25 Thread Soft Works
Signed-off-by: softworkz --- fftools/ffplay.c | 102 +- fftools/ffprobe.c | 48 ++ 2 files changed, 78 insertions(+), 72 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index e7b20be76b..0af32888da 100644 ---

[FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-25 Thread Soft Works
Root commit for adding subtitle filtering capabilities. In detail: - Add type (AVMediaType) field to AVFrame Replaces previous way of distinction which was based on checking width and height to determine whether a frame is audio or video - Add subtitle fields to AVFrame - Add new struct

[FFmpeg-devel] [PATCH v15 00/16] *** SUBJECT HERE ***

2021-11-25 Thread Soft Works
Root commit for adding subtitle filtering capabilities. In detail: - Add type (AVMediaType) field to AVFrame Replaces previous way of distinction which was based on checking width and height to determine whether a frame is audio or video - Add subtitle fields to AVFrame - Add new struct

[FFmpeg-devel] [PATCH v2] lavu/avframe: add a time_base field

2021-11-25 Thread Lynne
This adds a time_base field (currently unused), analogue to the AVPacket.time_base field. This allows for API clients to exchange AVFrames directly, without needing to plumb extra data from sources via side mechanisms. Patch attached. >From 7a5b8fe31ff7e193ddd776daf8aac1c2c528d8d2 Mon Sep 17

Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-25 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Thursday, November 25, 2021 4:56 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for > subtitle handling > > Quoting Soft Works (2021-11-25 01:48:11)

[FFmpeg-devel] 5.0 release

2021-11-25 Thread Michael Niedermayer
Hi all just wanted to remind everyone of the plan (suggested by jb) to make the 5.0 release in december i dont know if that will work out but please avoid introducing risky changes until the release branch splits off and if you know of any regressions, security issues or other major bugs, please

Re: [FFmpeg-devel] [PATCH v2] avformat/mov: add option max_stts_delta

2021-11-25 Thread Michael Niedermayer
On Thu, Nov 25, 2021 at 10:51:15AM +0530, Gyan Doshi wrote: > > > On 2021-11-25 12:56 am, Michael Niedermayer wrote: > > On Wed, Nov 24, 2021 at 10:58:00AM +0530, Gyan Doshi wrote: > > > > > > On 2021-11-24 01:16 am, Michael Niedermayer wrote: > > > > On Tue, Nov 23, 2021 at 06:41:06PM +0530,

Re: [FFmpeg-devel] [PATCH v4 1/1] avutils/hwcontext: When deriving a hwdevice, search for existing device in both directions

2021-11-25 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Thursday, November 25, 2021 5:40 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v4 1/1] avutils/hwcontext: When deriving a > hwdevice, search for existing device in both directions >

Re: [FFmpeg-devel] [PATCH v3 1/1] fftools/ffprobe: print size of attachment streams (extradata_size)

2021-11-25 Thread Soft Works
Another attempt: Created on Linux and zipped... > -Original Message- > From: ffmpeg-devel On Behalf Of Michael > Niedermayer > Sent: Thursday, November 25, 2021 5:42 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v3 1/1] fftools/ffprobe: print

Re: [FFmpeg-devel] [PATCH] configure: do not include -lvulkan in vulkan's pkg-config check

2021-11-25 Thread Lynne
24 Nov 2021, 20:19 by d...@lynne.ee: > Also fixes the non-pkg-config check. > > Patch attached. > Ping. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH] doc/APIchanges: fix typo

2021-11-25 Thread Lynne
25 Nov 2021, 17:26 by an...@khirnov.net: > --- > doc/APIchanges | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/APIchanges b/doc/APIchanges > index 565f7e091e..51fc259d3f 100644 > --- a/doc/APIchanges > +++ b/doc/APIchanges > @@ -24,7 +24,7 @@ API changes, most

Re: [FFmpeg-devel] [PATCH v2 1/1] fftools/ffprobe: print size of attachment streams (extradata_size)

2021-11-25 Thread Michael Niedermayer
On Thu, Nov 25, 2021 at 05:42:27PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-11-25 17:38:59) > > On Thu, Nov 25, 2021 at 03:05:23AM +, Soft Works wrote: > > > Signed-off-by: softworkz > > > --- > > > v2: As suggested by Marton, I'm always prniting extradata_size now > >

Re: [FFmpeg-devel] [PATCH v2 1/1] fftools/ffprobe: print size of attachment streams (extradata_size)

2021-11-25 Thread Anton Khirnov
Quoting Michael Niedermayer (2021-11-25 17:38:59) > On Thu, Nov 25, 2021 at 03:05:23AM +, Soft Works wrote: > > Signed-off-by: softworkz > > --- > > v2: As suggested by Marton, I'm always prniting extradata_size now instead > > of an 'attachment_size' value. > > The downside is that a number

Re: [FFmpeg-devel] [PATCH v3 1/1] fftools/ffprobe: print size of attachment streams (extradata_size)

2021-11-25 Thread Michael Niedermayer
On Thu, Nov 25, 2021 at 10:32:21AM +, Soft Works wrote: > Signed-off-by: softworkz > --- > V3: Try sending long-line patch as attachment > > doc/ffprobe.xsd | 1 + > fftools/ffprobe.c | 1 + >

Re: [FFmpeg-devel] [PATCH v2 1/1] fftools/ffprobe: print size of attachment streams (extradata_size)

2021-11-25 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Michael > Niedermayer > Sent: Thursday, November 25, 2021 5:39 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] fftools/ffprobe: print size of > attachment streams (extradata_size) >

Re: [FFmpeg-devel] [PATCH v4 1/1] avutils/hwcontext: When deriving a hwdevice, search for existing device in both directions

2021-11-25 Thread Anton Khirnov
Quoting Soft Works (2021-11-25 03:41:32) > @@ -687,6 +720,11 @@ int av_hwdevice_ctx_create_derived_opts(AVBufferRef > **dst_ref_ptr, > ret = AVERROR(ENOMEM); > goto fail; > } > +tmp_ctx->internal->derived_devices[type] =

Re: [FFmpeg-devel] [PATCH v2 1/1] fftools/ffprobe: print size of attachment streams (extradata_size)

2021-11-25 Thread Michael Niedermayer
On Thu, Nov 25, 2021 at 03:05:23AM +, Soft Works wrote: > Signed-off-by: softworkz > --- > v2: As suggested by Marton, I'm always prniting extradata_size now instead of > an 'attachment_size' value. > The downside is that a number of tests need to be changed and probably, > Patchwork won't

Re: [FFmpeg-devel] [PATCH v15 08/16] fftools/ffmpeg: Replace sub2video with subtitle frame filtering

2021-11-25 Thread Michael Niedermayer
On Thu, Nov 25, 2021 at 12:48:33AM +, Soft Works wrote: > This commit actually enables subtitle filtering in ffmpeg by > sending and receiving subtitle frames to and from a filtergraph. > > The heartbeat functionality from the previous sub2video implementation > is retained and applied to all

Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-25 Thread Michael Niedermayer
On Thu, Nov 25, 2021 at 12:48:11AM +, Soft Works wrote: > Root commit for adding subtitle filtering capabilities. > In detail: > > - Add type (AVMediaType) field to AVFrame > Replaces previous way of distinction which was based on checking > width and height to determine whether a frame

[FFmpeg-devel] [PATCH] doc/APIchanges: fix typo

2021-11-25 Thread Anton Khirnov
--- doc/APIchanges | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 565f7e091e..51fc259d3f 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -24,7 +24,7 @@ API changes, most recent first: Add "disposition" AVOption to AVStream's class.

Re: [FFmpeg-devel] [PATCH v15 10/16] avfilter/textmod: Add textmod, censor and show_speaker filters

2021-11-25 Thread Michael Niedermayer
On Thu, Nov 25, 2021 at 12:48:38AM +, Soft Works wrote: > - textmod {S -> S) > Modify subtitle text in a number of ways > > - censor {S -> S) > Censor subtitles using a word list > > - show_speaker {S -> S) > Prepend speaker names from ASS subtitles to the visible text lines > >

Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-25 Thread Anton Khirnov
Quoting Soft Works (2021-11-25 01:48:11) > Root commit for adding subtitle filtering capabilities. > In detail: > > - Add type (AVMediaType) field to AVFrame > Replaces previous way of distinction which was based on checking > width and height to determine whether a frame is audio or video >

Re: [FFmpeg-devel] [PATCH 8/9] lavf/mov: drop a never-executed block

2021-11-25 Thread Gyan Doshi
On 2021-11-25 08:34 pm, Anton Khirnov wrote: MOVStts.duration is unsigned since 203b0e3561d. --- libavformat/mov.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 451cb78bbf..e85eeb0a0e 100644 --- a/libavformat/mov.c +++

[FFmpeg-devel] [PATCH 2/2] lavu/frame: clarify doxy

2021-11-25 Thread Anton Khirnov
AVFrame.data[] elements not used by the format should ALWAYS be null, hwaccel formats are not an exception. --- libavutil/frame.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavutil/frame.h b/libavutil/frame.h index f7be2340fd..b7be3fa441 100644 --- a/libavutil/frame.h

[FFmpeg-devel] [PATCH 1/2] lavu/frame: drop mentions of non-refcounted frames

2021-11-25 Thread Anton Khirnov
All frames we deal with should always be refcounted now. --- libavutil/frame.h | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavutil/frame.h b/libavutil/frame.h index 753234792e..f7be2340fd 100644 --- a/libavutil/frame.h +++ b/libavutil/frame.h @@ -314,6 +314,9

[FFmpeg-devel] [PATCH 2/9] lavf/v4l2: do not use a context variable unnecessarily

2021-11-25 Thread Anton Khirnov
fd is local to the loop iteration, it is better to store it on stack than modify the context. --- libavdevice/v4l2.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c index b5997fba33..777867db86 100644 ---

[FFmpeg-devel] [PATCH 9/9] lavf/protocols: avoid discarding const in avio_enum_protocols()

2021-11-25 Thread Anton Khirnov
Instead of storing the protocol pointer in the opaque iteration state, store just the index of the next protocol, similarly to how ff_urlcontext_child_class_iterate() works. --- libavformat/protocols.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

[FFmpeg-devel] [PATCH 7/9] lavf/img2enc: avoid a useless copy of the url

2021-11-25 Thread Anton Khirnov
img2enc keeps a private (and possibly truncated) copy of the url that is never modified. Just use AVFormatContext.url instead. --- libavformat/img2enc.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c index

[FFmpeg-devel] [PATCH 8/9] lavf/mov: drop a never-executed block

2021-11-25 Thread Anton Khirnov
MOVStts.duration is unsigned since 203b0e3561d. --- libavformat/mov.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 451cb78bbf..e85eeb0a0e 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -3965,16 +3965,6 @@ static void

[FFmpeg-devel] [PATCH 6/9] lavf/ftp: check for truncation in snprintf

2021-11-25 Thread Anton Khirnov
Silences e.g. the following warning in gcc 10: src/libavformat/ftp.c: In function ‘ftp_move’: src/libavformat/ftp.c:1122:46: warning: ‘%s’ directive output may be truncated writing up to 4095 bytes into a region of size 4091 [-Wformat-truncation=] 1122 | snprintf(command, sizeof(command),

[FFmpeg-devel] [PATCH 5/9] lavfi/vf_subtitles: stop using deprecated ass_set_aspect_ratio()

2021-11-25 Thread Anton Khirnov
It has been deprecated in favor of ass_set_pixel_aspect() since version 0.11.0, roughly ~2014. Even Debian oldoldstable (stretch) has 0.13. --- configure | 2 +- libavfilter/vf_subtitles.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure

[FFmpeg-devel] [PATCH 3/9] lavd/v4l2: reduce variable scope

2021-11-25 Thread Anton Khirnov
device and cap are local to the loop iteration, there is no need for them to retain their values. Especially for device it may be dangerous, since it points to av_malloc'ed data. --- libavdevice/v4l2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavdevice/v4l2.c

[FFmpeg-devel] [PATCH 1/9] lavd/jack: increase buffer size for snprintf()

2021-11-25 Thread Anton Khirnov
Maximum output size with a 32-bit int is 17 bytes, or 26 with a 64-bit int. Silences the following gcc 10 warning: src/libavdevice/jack.c: In function ‘audio_read_header’: src/libavdevice/jack.c:171:45: warning: ‘snprintf’ output may be truncated before the last format character

[FFmpeg-devel] [PATCH 4/9] lavd/v4l2: detect device name truncation

2021-11-25 Thread Anton Khirnov
Silences the following warning with gcc 10: src/libavdevice/v4l2.c: In function ‘v4l2_get_device_list’: src/libavdevice/v4l2.c:1042:64: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 251 [-Wformat-truncation=] 1042 | ret =

Re: [FFmpeg-devel] [PATCH 1/2] avformat/rtp: add localaddr for network interface selection

2021-11-25 Thread lance . lmwang
On Thu, Nov 25, 2021 at 12:56:24PM +0200, Martin Storsjö wrote: > On Thu, 25 Nov 2021, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > doc/protocols.texi | 4 > > libavformat/rtpproto.c | 17 ++--- > > libavformat/rtsp.c

Re: [FFmpeg-devel] [PATCH v15 00/16] *** SUBJECT HERE ***

2021-11-25 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Hendrik > Leppkes > Sent: Thursday, November 25, 2021 1:18 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v15 00/16] *** SUBJECT HERE *** > > On Thu, Nov 25, 2021 at 1:12 PM Soft Works

Re: [FFmpeg-devel] [PATCH v15 00/16] *** SUBJECT HERE ***

2021-11-25 Thread Hendrik Leppkes
On Thu, Nov 25, 2021 at 1:12 PM Soft Works wrote: > > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of James > > Almer > > Sent: Thursday, November 25, 2021 11:52 AM > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH v15 00/16] ***

Re: [FFmpeg-devel] [PATCH v15 00/16] *** SUBJECT HERE ***

2021-11-25 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of James Almer > Sent: Thursday, November 25, 2021 11:52 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v15 00/16] *** SUBJECT HERE *** > > Have all the concerns people had been addressed?

Re: [FFmpeg-devel] [PATCH] avformat/http: prevent truncation of sanitized_path

2021-11-25 Thread Anton Khirnov
Quoting James Almer (2021-06-09 22:01:02) > path1 and sanitized_path are both MAX_URL_SIZE bytes long, yet the latter is > copied from the former with the addition of one extra character. > > Should fix a -Wformat-truncation warning. > > Signed-off-by: James Almer > --- > libavformat/http.c |

Re: [FFmpeg-devel] [PATCH 1/2] avformat/rtp: add localaddr for network interface selection

2021-11-25 Thread Martin Storsjö
On Thu, 25 Nov 2021, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- doc/protocols.texi | 4 libavformat/rtpproto.c | 17 ++--- libavformat/rtsp.c | 3 +++ libavformat/rtsp.h | 1 + 4 files changed, 22 insertions(+), 3 deletions(-)

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: remove local localaddr array

2021-11-25 Thread Martin Storsjö
On Thu, 25 Nov 2021, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/udp.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index bbe5aec..b8b0e19 100644 --- a/libavformat/udp.c +++

Re: [FFmpeg-devel] [PATCH v15 00/16] *** SUBJECT HERE ***

2021-11-25 Thread James Almer
Have all the concerns people had been addressed? I'm also certain the design itself wasn't well received. This is big and needs more than 24 hours or just one person LGTMing it, so please wait. Also, patch 15/16 breaks FATE. Even if 16/16 fixes the tests, it will make bisecting annoying, so it

[FFmpeg-devel] [PATCH 2/2] avformat/udp: remove local localaddr array

2021-11-25 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/udp.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index bbe5aec..b8b0e19 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c @@ -623,7 +623,7 @@ end: /*

[FFmpeg-devel] [PATCH 1/2] avformat/rtp: add localaddr for network interface selection

2021-11-25 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/protocols.texi | 4 libavformat/rtpproto.c | 17 ++--- libavformat/rtsp.c | 3 +++ libavformat/rtsp.h | 1 + 4 files changed, 22 insertions(+), 3 deletions(-) diff --git a/doc/protocols.texi

Re: [FFmpeg-devel] [PATCH v3 7/7] avformat/rtp: support for RGB/BGR for rfc4175

2021-11-25 Thread lance . lmwang
On Wed, Nov 24, 2021 at 04:49:18PM +0100, Lynne wrote: > 24 Nov 2021, 16:27 by lance.lmw...@gmail.com: > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/rtpdec_rfc4175.c | 20 > > libavformat/rtpenc_rfc4175.c | 8 > >

[FFmpeg-devel] [PATCH v3 1/1] fftools/ffprobe: print size of attachment streams (extradata_size)

2021-11-25 Thread Soft Works
Signed-off-by: softworkz --- V3: Try sending long-line patch as attachment doc/ffprobe.xsd | 1 + fftools/ffprobe.c | 1 + tests/ref/fate/concat-demuxer-extended-lavf-mxf | 2 +-

Re: [FFmpeg-devel] [PATCH v3 2/2] avfilter: add a bflip_vulkan filter

2021-11-25 Thread Gyan Doshi
On 2021-11-25 03:28 pm, Lynne wrote: 25 Nov 2021, 10:39 by jianhua...@intel.com: Lynne: From: ffmpeg-devel On Behalf Of Lynne Sent: Thursday, November 25, 2021 5:33 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v3 2/2] avfilter: add a bflip_vulkan

Re: [FFmpeg-devel] [PATCH v3 2/2] avfilter: add a bflip_vulkan filter

2021-11-25 Thread Lynne
25 Nov 2021, 10:39 by jianhua...@intel.com: > Lynne: > >> From: ffmpeg-devel On Behalf Of >> Lynne >> Sent: Thursday, November 25, 2021 5:33 PM >> To: FFmpeg development discussions and patches > de...@ffmpeg.org> >> Subject: Re: [FFmpeg-devel] [PATCH v3 2/2] avfilter: add a bflip_vulkan >>

Re: [FFmpeg-devel] [PATCH v3 2/2] avfilter: add a bflip_vulkan filter

2021-11-25 Thread Wu, Jianhua
Lynne: > From: ffmpeg-devel On Behalf Of > Lynne > Sent: Thursday, November 25, 2021 5:33 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v3 2/2] avfilter: add a bflip_vulkan filter > > 25 Nov 2021, 10:22 by ffm...@gyani.pro: > > > > >

  1   2   >