[FFmpeg-devel] request to revert all patches that made cfr decoders vfr

This is the first warning to revert all patches that made cfr decoders vfr. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v3 0/5] Switch mmaldec to receive_frame API

While we are on the topic of mmaldec, would you mind reviewing and applying this patch as well: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210916134652.22781-1-cyph1...@gmail.com/ On Fri, Dec 10, 2021 at 11:48 AM Ming Shun Ho wrote: > > Built and tested successfully on a Rpi 3b+

[FFmpeg-devel] [PATCH V3 2/2] libavutil/hwcontext_opencl: fix a bug for mapping qsv frame to opencl

From: nyanmisaka mfxHDLPair was added to qsv, so modify qsv->opencl map function as well. Now the following commandline works: ffmpeg -v verbose -init_hw_device vaapi=va:/dev/dri/renderD128 \ -init_hw_device qsv=qs@va -init_hw_device opencl=ocl@va -filter_hw_device ocl \ -hwaccel qsv

[FFmpeg-devel] [PATCH V3 1/2] libavcodec/vaapi_decode: fix the problem that init_pool_size < nb_surface

For vaapi if the init_pool_size is not zero, the pool size is fixed. This means max surfaces is init_pool_size, but when mapping vaapi frame to qsv frame, the init_pool_size < nb_surface. The cause is that vaapi_decode_make_config() config the init_pool_size and it is called twice. The first time

Re: [FFmpeg-devel] [PATCH v3 0/5] Switch mmaldec to receive_frame API

Built and tested successfully on a Rpi 3b+ through mpv. Thanks for this patchset! On Thu, Dec 9, 2021 at 9:01 PM Andreas Rheinhardt wrote: > > This is an updated and extended version of [1] by Ho Ming Shun > together with some additions by me. Notice that I am unable > to test these patches

Re: [FFmpeg-devel] [PATCH V2 1/3] libavcodec/vaapi_decode: fix the problem that init_pool_size < nb_surface

> Quoting Wenbin Chen (2021-11-30 09:44:04) > > For vaapi if the init_pool_size is not zero, the pool size is fixed. > > This means max surfaces is init_pool_size, but when mapping vaapi > > frame to qsv frame, the init_pool_size < nb_surface. The cause is that > > vaapi_decode_make_config()

Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

> On Dec 10, 2021, at 3:11 AM, Thilo Borgmann wrote: > > Hi, > > add %{localtime_ms}, %{gmtime_ms} functions to the drawtext filter. Same as > %{localtime}/%{gmtime} but with additional millisecond part. > > sorry for delay, second version including review remarks: > > -get timing once >

[FFmpeg-devel] [PATCH] libavfilter/vf_overlay_qsv: Use format of first input to set output format for overlay_qsv

overlay_qsv hard coded to use nv12 as output format. Now use the format of the first input to set output format. Now the following command works: ffmpeg -hwaccel qsv -c:v hevc_qsv -i input_p010.265 -hwaccel qsv -c:v hevc_qsv \ -i input2_p010.265 -filter_complex

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

On Thu, 9 Dec 2021, Anton Khirnov wrote: Quoting Nicolas George (2021-12-09 11:31:54) Anton Khirnov (12021-12-09): I disagree. Technical limitations that were overcome 10 years ago should not guide new API design. In the case of amerge, it was not a technical limitation, merging several

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

On 12/9/2021 8:31 PM, Marton Balint wrote: On Fri, 10 Dec 2021, Hendrik Leppkes wrote: On Fri, Dec 10, 2021 at 12:06 AM Marton Balint wrote: On Thu, 9 Dec 2021, Anton Khirnov wrote: Quoting Lynne (2021-12-08 13:57:45) 8 Dec 2021, 13:16 by an...@khirnov.net: Quoting Lynne

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

On Fri, 10 Dec 2021, Hendrik Leppkes wrote: On Fri, Dec 10, 2021 at 12:06 AM Marton Balint wrote: On Thu, 9 Dec 2021, Anton Khirnov wrote: Quoting Lynne (2021-12-08 13:57:45) 8 Dec 2021, 13:16 by an...@khirnov.net: Quoting Lynne (2021-12-08 10:02:34) 8 Dec 2021, 02:06 by

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

On Fri, Dec 10, 2021 at 12:06 AM Marton Balint wrote: > > > > On Thu, 9 Dec 2021, Anton Khirnov wrote: > > > Quoting Lynne (2021-12-08 13:57:45) > >> 8 Dec 2021, 13:16 by an...@khirnov.net: > >> > >>> Quoting Lynne (2021-12-08 10:02:34) > >>> > 8 Dec 2021, 02:06 by jamr...@gmail.com: >

Re: [FFmpeg-devel] [PATCH 2/5] avfilter/af_astats: improve options descriptions

On Thu, Dec 09, 2021 at 10:41:17PM +0530, Gyan Doshi wrote: > > > On 2021-12-09 06:49 am, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/af_astats.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

On Thu, 9 Dec 2021, Anton Khirnov wrote: Quoting Lynne (2021-12-08 13:57:45) 8 Dec 2021, 13:16 by an...@khirnov.net: Quoting Lynne (2021-12-08 10:02:34) 8 Dec 2021, 02:06 by jamr...@gmail.com: From: Anton Khirnov The new API is more extensible and allows for custom layouts. More

Re: [FFmpeg-devel] [PATCH v2 1/4] lavu/frame: Add Dolby Vision metadata side data type

On Thu, 09 Dec 2021 17:21:58 + Derek Buitenhuis wrote: > On 12/8/2021 10:12 AM, Niklas Haas wrote: > > +/* based on guesswork, see mkvtoolnix and dovi_tool */ > > +int av_dovi_profile(const AVDOVIRpuDataHeader *hdr) > > +{ > > The correct way to find the profile is from the stream level >

Re: [FFmpeg-devel] [PATCH v20 02/20] avutil/frame: Prepare AVFrame\n for subtitle handling

Hi there. This is my first message to this list, so please excuse me if I unintendedly break some rule. I've read the debate between Soft Works and others, and would like to add something to it. I don't have a deep knowledge of the libs as other people here show. My knowledge comes from

[FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

Hi, add %{localtime_ms}, %{gmtime_ms} functions to the drawtext filter. Same as %{localtime}/%{gmtime} but with additional millisecond part. sorry for delay, second version including review remarks: -get timing once -also add gmtime_ms instead of just localtime_ms Thanks, ThiloFrom

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

On Thu, Dec 9, 2021 at 5:26 PM Nicolas George wrote: > Hendrik Leppkes (12021-12-09): > > It sounds like thats object audio, and should be driven separately, > > and not by the legacy channel identifiers. > > This is not exclusive. We have code that works with channel layouts > right now, and it

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/targa: Do not return images when there is no image in the tga

NACK On Thu, Dec 9, 2021 at 1:23 PM Michael Niedermayer wrote: > On Mon, Dec 06, 2021 at 10:58:31AM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2021-12-03 15:04:47) > > > On Sat, Sep 18, 2021 at 06:27:15PM +0200, Michael Niedermayer wrote: > > > > On Fri, Sep 17, 2021 at

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add Haihao Xiang for qsv

> -Original Message- > From: ffmpeg-devel On Behalf Of Zhong Li > Sent: Tuesday, June 08, 2021 7:12 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Zhong Li > Subject: [FFmpeg-devel] [PATCH] MAINTAINERS: Add Haihao Xiang for qsv > > Signed-off-by: Zhong Li > --- > MAINTAINERS | 2 +- > 1 file

Re: [FFmpeg-devel] [PATCH v2 1/4] lavu/frame: Add Dolby Vision metadata side data type

On 12/8/2021 10:12 AM, Niklas Haas wrote: > +/* based on guesswork, see mkvtoolnix and dovi_tool */ > +int av_dovi_profile(const AVDOVIRpuDataHeader *hdr) > +{ The correct way to find the profile is from the stream level DOVI configuration record side data, if available. - Derek

Re: [FFmpeg-devel] [PATCH 2/5] avfilter/af_astats: improve options descriptions

On 2021-12-09 06:49 am, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/af_astats.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/af_astats.c b/libavfilter/af_astats.c index d0810b5..776a8aa 100644 ---

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

Hendrik Leppkes (12021-12-09): > It sounds like thats object audio, and should be driven separately, > and not by the legacy channel identifiers. This is not exclusive. We have code that works with channel layouts right now, and it is important that the extensions work gracefully. For example,

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

On Thu, Dec 9, 2021 at 3:57 PM Nicolas George wrote: > > Hendrik Leppkes (12021-12-09): > > What kind of sense does a frame make that contains the same channel > > twice? > > Imagine an orchestra recording: > > Orchestra, front left > Orchestra, front center > Orchestra, front right > Orchestra,

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

Lynne (12021-12-09): > So I'm fine with your proposal to have 16-bit enum for the channel > ID and a 16-bit opaque. Though I'd like the opaque to be an > uint16_t instead of int opaque : 16. > And 16-bits does sound like enough for many channels and quite a > few flags, though the silent flag

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

9 Dec 2021, 15:57 by an...@khirnov.net: > Quoting Lynne (2021-12-09 15:42:42) > >> 9 Dec 2021, 15:24 by geo...@nsup.org: >> >> > Anton Khirnov (12021-12-09): >> > >> >> I see you repeating the same two arguments: >> >> - it was implemented like this in the past and therefore must keep >> >>

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

Quoting Lynne (2021-12-09 15:42:42) > 9 Dec 2021, 15:24 by geo...@nsup.org: > > > Anton Khirnov (12021-12-09): > > > >> I see you repeating the same two arguments: > >> - it was implemented like this in the past and therefore must keep > >> working exactly the same > >> - it might be useful

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

Hendrik Leppkes (12021-12-09): > What kind of sense does a frame make that contains the same channel > twice? Imagine an orchestra recording: Orchestra, front left Orchestra, front center Orchestra, front right Orchestra, low freq Orchestra, rear left Orchestra, rear center Winds, left Winds,

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

On Thu, Dec 9, 2021 at 3:42 PM Lynne wrote: > > 9 Dec 2021, 15:24 by geo...@nsup.org: > > > Anton Khirnov (12021-12-09): > > > >> I see you repeating the same two arguments: > >> - it was implemented like this in the past and therefore must keep > >> working exactly the same > >> - it might be

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

9 Dec 2021, 15:24 by geo...@nsup.org: > Anton Khirnov (12021-12-09): > >> I see you repeating the same two arguments: >> - it was implemented like this in the past and therefore must keep >> working exactly the same >> - it might be useful under some vaguely specified conditions >> >> Neither of

[FFmpeg-devel] [PATCH v2] avfilter/dnn: fix incompatible integer to pointer conversion warning

From: Limin Wang --- libavfilter/dnn/dnn_backend_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_common.c b/libavfilter/dnn/dnn_backend_common.c index 6a9c4cc..dd7bdf4 100644 --- a/libavfilter/dnn/dnn_backend_common.c +++

[FFmpeg-devel] [PATCH v2] avfilter/dnn: fix incompatible integer to pointer conversion warning

From: Limin Wang --- libavfilter/dnn/dnn_backend_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_common.c b/libavfilter/dnn/dnn_backend_common.c index 6a9c4cc..dd7bdf4 100644 --- a/libavfilter/dnn/dnn_backend_common.c +++

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

Anton Khirnov (12021-12-09): > I see you repeating the same two arguments: > - it was implemented like this in the past and therefore must keep > working exactly the same > - it might be useful under some vaguely specified conditions > > Neither of these strikes me as a good enough reason to

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

Quoting Nicolas George (2021-12-09 14:52:40) > Anton Khirnov (12021-12-09): > > I fail to see how that is an advantage. You can just as well create > > multiple instances of those single-stream filters instead of adding > > hacks into core APIs. > > Please think a little further: multiple

Re: [FFmpeg-devel] [PATCH 3/5] avfilter/dnn: fix the return value of async_thread_routine

On Thu, Dec 09, 2021 at 03:00:06PM +0100, Michael Niedermayer wrote: > On Thu, Dec 09, 2021 at 09:19:41AM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/dnn/dnn_backend_common.c | 7 +-- > > 1 file changed, 5

Re: [FFmpeg-devel] [PATCH 3/5] avfilter/dnn: fix the return value of async_thread_routine

On Thu, Dec 09, 2021 at 09:19:41AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/dnn/dnn_backend_common.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/dnn/dnn_backend_common.c >

Re: [FFmpeg-devel] [PATCH v2] libswresample/swresamplec: Err num(negative-size) was used as a function parameter

> 2021年12月9日 下午8:10，Michael Niedermayer 写道： > > On Wed, Dec 08, 2021 at 11:17:13AM +0800, Yu Yang wrote: >> If cannot allocate memory, ERROR(ENOMEM) '-12' as a parameter will be >> constantly being returned. >> When run resample() firstly, negative size param would cause buffer-overflow >>

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

Anton Khirnov (12021-12-09): > I fail to see how that is an advantage. You can just as well create > multiple instances of those single-stream filters instead of adding > hacks into core APIs. Please think a little further: multiple instances of the single-stream filters would not have access to

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

Quoting Nicolas George (2021-12-09 11:31:54) > Anton Khirnov (12021-12-09): > > I disagree. Technical limitations that were overcome 10 years ago should > > not guide new API design. > > In the case of amerge, it was not a technical limitation, merging > several streams into one so that they can

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

Lynne (12021-12-09): > "reserved" rather than "opaque"? > 16 bits for both? Could you keep the id as a plain (32-bit, on > a sane compiler) enum, since we may need to add flags, one > never knows, and make the opaque field a plain uint32_t? > 64-bits per channel overall isn't too bad. You wanted

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

Quoting Lynne (2021-12-09 12:21:14) > 9 Dec 2021, 11:14 by an...@khirnov.net: > > > Quoting Lynne (2021-12-08 13:53:52) > > > >> That's not a goal, it's anti-goal, and a cause for hysterical raisin > >> picking in the future. > >> Having an instantly debuggable structure rather than one that > >>

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

9 Dec 2021, 14:12 by an...@khirnov.net: > Quoting Lynne (2021-12-08 13:57:45) > >> 8 Dec 2021, 13:16 by an...@khirnov.net: >> >> > Quoting Lynne (2021-12-08 10:02:34) >> > >> >> 8 Dec 2021, 02:06 by jamr...@gmail.com: >> >> >> >> > From: Anton Khirnov >> >> > >> >> > The new API is more

Re: [FFmpeg-devel] [PATCH 3/5] avfilter/dnn: fix the return value of async_thread_routine

On Thu, Dec 09, 2021 at 11:55:14AM +, Guo, Yejun wrote: > > > -Original Message- > From: ffmpeg-devel On Behalf Of > lance.lmw...@gmail.com > Sent: 2021年12月9日 9:20 > To: ffmpeg-devel@ffmpeg.org > Cc: Limin Wang > Subject: [FFmpeg-devel] [PATCH 3/5] avfilter/dnn: fix the return

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

Quoting Lynne (2021-12-08 13:57:45) > 8 Dec 2021, 13:16 by an...@khirnov.net: > > > Quoting Lynne (2021-12-08 10:02:34) > > > >> 8 Dec 2021, 02:06 by jamr...@gmail.com: > >> > >> > From: Anton Khirnov > >> > > >> > The new API is more extensible and allows for custom layouts. > >> > More

[FFmpeg-devel] [PATCH v3 5/5] avcodec/mmaldec: Deduplicate AVClasses

Possible now that the child_class_next API is gone. Signed-off-by: Andreas Rheinhardt --- libavcodec/mmaldec.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/libavcodec/mmaldec.c b/libavcodec/mmaldec.c index 0c7df0a0bc..f8a7319cd6 100644 ---

[FFmpeg-devel] [PATCH v3 4/5] avcodec/mmaldec: Avoid creating unnecessary reference, simplify code

ffmal_add_packet() basically duplicated the logic in av_packet_make_refcounted() with the added twist that it always created a reference even if one is already available. This commit stops doing this. Signed-off-by: Andreas Rheinhardt --- libavcodec/mmaldec.c | 23 ++- 1

[FFmpeg-devel] [PATCH v3 3/5] avcodec/mmaldec: fix pointer type warning

From: Ho Ming Shun Signed-off-by: Ho Ming Shun --- libavcodec/mmaldec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mmaldec.c b/libavcodec/mmaldec.c index 68ecc68f17..3e11d487ab 100644 --- a/libavcodec/mmaldec.c +++ b/libavcodec/mmaldec.c @@ -656,7 +656,7 @@

[FFmpeg-devel] [PATCH v3 2/5] avcodec/mmaldec: re-use AVPacket for extra_data

From: Ho Ming Shun extra_data and normal packets (from ff_decode_get_packet) processing do not overlap, thus we can re-use the spare AVPacket to send to ffmmal_add_packet. Furthermore, this removes allocation of AVPacket on the stack and stops using deprecated av_init_packet. Signed-off-by: Ho

[FFmpeg-devel] [PATCH v3 1/5] avcodec/mmaldec: use decoupled dataflow

From: Ho Ming Shun MMAL is an fundamentally an asynchronous decoder, which was a bad fit for the legacy dataflow API. Often multiple packets are enqueued before a flood of frames are returned from MMAL. The previous lockstep dataflow meant that any delay in returning packets from the VPU would

[FFmpeg-devel] [PATCH v3 0/5] Switch mmaldec to receive_frame API

This is an updated and extended version of [1] by Ho Ming Shun together with some additions by me. Notice that I am unable to test these patches (not even compilation), so I hope that others (Ho Ming Shun) do so. [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2021-September/285992.html Andreas

Re: [FFmpeg-devel] [PATCH 5/7] avformat/mxfdec: Check for duplicate mxf_read_index_entry_array()

On Wed, Dec 08, 2021 at 12:41:43AM +0100, Tomas Härdin wrote: > sön 2021-12-05 klockan 22:19 +0100 skrev Michael Niedermayer: > > Fixes: memleak > > Fixes: 41596/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer- > > 6439060204290048 > > > > Found-by: continuous fuzzing process > >

Re: [FFmpeg-devel] [PATCH v22 22/23] avutil/ass_split: Add parsing of hard-space tags (\h)

> -Original Message- > From: ffmpeg-devel On Behalf Of Soft Works > Sent: Thursday, December 9, 2021 1:13 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v22 22/23] avutil/ass_split: Add parsing of > hard-space tags (\h) > > The \h tag in ASS/SSA is indicating a

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/apedec: Use 64bit in 4/3 calculation in do_apply_filter()

On Mon, Dec 06, 2021 at 03:50:34PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-12-06 12:01:09) > > On Mon, Dec 06, 2021 at 11:23:12AM +0100, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2021-12-03 18:19:54) > > > > Fixes: Integer overflow > > > > Fixes: > > > >

Re: [FFmpeg-devel] [PATCH 3/5] avfilter/dnn: fix the return value of async_thread_routine

On Thu, Dec 09, 2021 at 11:55:14AM +, Guo, Yejun wrote: > > > -Original Message- > From: ffmpeg-devel On Behalf Of > lance.lmw...@gmail.com > Sent: 2021年12月9日 9:20 > To: ffmpeg-devel@ffmpeg.org > Cc: Limin Wang > Subject: [FFmpeg-devel] [PATCH 3/5] avfilter/dnn: fix the return

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/targa: Do not return images when there is no image in the tga

On Mon, Dec 06, 2021 at 10:58:31AM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-12-03 15:04:47) > > On Sat, Sep 18, 2021 at 06:27:15PM +0200, Michael Niedermayer wrote: > > > On Fri, Sep 17, 2021 at 08:06:48PM +0200, Paul B Mahol wrote: > > > > On Fri, Sep 17, 2021 at 8:00 PM

Re: [FFmpeg-devel] [PATCH v22 02/23] avutil/frame: Prepare AVFrame for subtitle handling

Soft Works: > Root commit for adding subtitle filtering capabilities. > In detail: > > - Add type (AVMediaType) field to AVFrame > Replaces previous way of distinction which was based on checking > width and height to determine whether a frame is audio or video > - Add subtitle fields to

Re: [FFmpeg-devel] [PATCH v22 01/23] avcodec, avutil: Move enum AVSubtitleType to avutil, add new and deprecate old values

> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Thursday, December 9, 2021 1:17 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v22 01/23] avcodec, avutil: Move enum > AVSubtitleType to avutil, add new and deprecate old values >

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mxfdec: Check component_depth in mxf_get_color_range()

On Wed, Dec 08, 2021 at 12:38:56AM +0100, Tomas Härdin wrote: > lör 2021-12-04 klockan 22:32 +0100 skrev Michael Niedermayer: > > Fixes: shift exponent 4294967163 is too large for 32-bit type 'int' > > Fixes: 41449/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer- > > 6183636217495552 > >

Re: [FFmpeg-devel] [PATCH v22 01/23] avcodec, avutil: Move enum AVSubtitleType to avutil, add new and deprecate old values

Soft Works: > Signed-off-by: softworkz > --- > libavcodec/avcodec.h | 19 + > libavutil/Makefile | 1 + > libavutil/subfmt.h | 66 > libavutil/version.h | 1 + > 4 files changed, 69 insertions(+), 18 deletions(-) > create mode

[FFmpeg-devel] [PATCH v22 23/23] avcodec/webvttenc: convert hard-space tags to

Signed-off-by: softworkz --- libavcodec/webvttenc.c | 6 ++ tests/ref/fate/sub-webvttenc | 10 +- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/libavcodec/webvttenc.c b/libavcodec/webvttenc.c index 43dace6575..a4997969ee 100644 --- a/libavcodec/webvttenc.c

[FFmpeg-devel] [PATCH v22 22/23] avutil/ass_split: Add parsing of hard-space tags (\h)

The \h tag in ASS/SSA is indicating a non-breaking space. See https://github.com/Aegisub/aegisite/blob/master/source/docs/3.2/ASS_Tags.html.md The ass_split implementation is used by almost all text subtitle encoders and it didn't handle this tag. Interestingly, several tests are testing for \h

[FFmpeg-devel] [PATCH v22 21/23] doc/APIchanges: update for subtitle filtering changes

Signed-off-by: softworkz --- doc/APIchanges | 23 +++ libavcodec/version.h | 2 +- libavutil/version.h | 4 ++-- 3 files changed, 26 insertions(+), 3 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 2914ad6734..bb47faf13d 100644 --- a/doc/APIchanges

[FFmpeg-devel] [PATCH v22 20/23] avfilter/subscale: Add filter for scaling and/or re-arranging graphical subtitles

Signed-off-by: softworkz --- configure | 1 + doc/filters.texi | 164 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/sf_subscale.c | 883 ++ 5 files changed, 1050 insertions(+) create mode

[FFmpeg-devel] [PATCH v22 19/23] avfilter/graphicsub2text: Add new graphicsub2text filter (OCR)

Signed-off-by: softworkz --- configure| 1 + doc/filters.texi | 55 + libavfilter/Makefile | 2 + libavfilter/allfilters.c | 1 + libavfilter/sf_graphicsub2text.c | 354 +++ 5 files changed, 413

[FFmpeg-devel] [PATCH v22 18/23] avfilter/splitcc: Add splitcc filter for closed caption handling

- splitcc {V -> VS) Extract closed-caption (A53) data from video frames as subtitle Frames ffmpeg -y -loglevel verbose -i "https://streams.videolan.org/streams/ts/CC/NewsStream-608-ac3.ts; -filter_complex "[0:v]splitcc[vid1],textmod=mode=remove_chars:find='@',[vid1]overlay_textsubs"

[FFmpeg-devel] [PATCH v22 17/23] avfilter/stripstyles: Add stripstyles filter

- stripstyles {S -> S) Remove all inline styles from subtitle events Signed-off-by: softworkz --- doc/filters.texi | 37 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/sf_stripstyles.c | 196 +++ 4

[FFmpeg-devel] [PATCH v22 16/23] avfilter/textmod: Add textmod, censor and show_speaker filters

- textmod {S -> S) Modify subtitle text in a number of ways - censor {S -> S) Censor subtitles using a word list - show_speaker {S -> S) Prepend speaker names from ASS subtitles to the visible text lines Signed-off-by: softworkz --- doc/filters.texi | 206

[FFmpeg-devel] [PATCH v22 15/23] avfilter/overlaytextsubs: Add overlaytextsubs and textsubs2video filters

- overlaytextsubs {VS -> V) Overlay text subtitles onto a video stream. - textsubs2video {S -> V) Converts text subtitles to video frames Signed-off-by: softworkz --- configure| 2 + doc/filters.texi | 113 ++ libavfilter/Makefile |

[FFmpeg-devel] [PATCH v22 13/23] fftools/ffmpeg: Replace sub2video with subtitle frame filtering and use new frame-based subtitle encoding API

This commit actually enables subtitle filtering in ffmpeg by sending and receiving subtitle frames to and from a filtergraph. The heartbeat functionality from the previous sub2video implementation is retained and applied to all subtitle frames (bitmap, text, ..). The other part of sub2video

[FFmpeg-devel] [PATCH v22 14/23] avfilter/avfilter: Fix hardcoded input index

This fix targets (rare) cases where multiple input pads have a .filter_frame function. ff_request_frame_to_filter needs to call ff_request_frame with the correct input pad instead of the hardcoded first one. Signed-off-by: softworkz --- libavfilter/avfilter.c | 18 +- 1 file

[FFmpeg-devel] [PATCH v22 12/23] avfilter/overlaygraphicsubs: Add overlaygraphicsubs and graphicsub2video filters

- overlaygraphicsubs (VS -> V) Overlay graphic subtitles onto a video stream - graphicsub2video {S -> V) Converts graphic subtitles to video frames (with alpha) Gets auto-inserted for retaining compatibility with sub2video command lines Signed-off-by: softworkz --- doc/filters.texi

[FFmpeg-devel] [PATCH v22 11/23] avfilter/sbuffer: Add sbuffersrc and sbuffersink filters

Signed-off-by: softworkz --- configure| 2 +- libavfilter/allfilters.c | 2 ++ libavfilter/buffersink.c | 54 ++ libavfilter/buffersink.h | 7 libavfilter/buffersrc.c | 72 libavfilter/buffersrc.h | 1

[FFmpeg-devel] [PATCH v22 10/23] avfilter/avfilter: Handle subtitle frames

Signed-off-by: softworkz --- libavfilter/avfilter.c | 8 +--- libavfilter/avfilter.h | 11 +++ libavfilter/avfiltergraph.c | 5 + libavfilter/formats.c | 22 ++ libavfilter/formats.h | 3 +++ libavfilter/internal.h | 18

[FFmpeg-devel] [PATCH v22 09/23] avfilter/subtitles: Add subtitles.c for subtitle frame allocation

Analog to avfilter/video.c and avfilter/audio.c Signed-off-by: softworkz --- libavfilter/Makefile| 1 + libavfilter/avfilter.c | 4 +++ libavfilter/internal.h | 1 + libavfilter/subtitles.c | 63 + libavfilter/subtitles.h | 44

[FFmpeg-devel] [PATCH v22 08/23] fftools/play, probe: Adjust for subtitle changes

Signed-off-by: softworkz --- fftools/ffplay.c | 102 +- fftools/ffprobe.c | 48 ++ 2 files changed, 78 insertions(+), 72 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index e7b20be76b..0af32888da 100644 ---

[FFmpeg-devel] [PATCH v22 07/23] avcodec/subtitles: Replace deprecated enum values

Signed-off-by: softworkz --- libavcodec/ass.h | 2 +- libavcodec/assdec.c| 2 +- libavcodec/dvbsubdec.c | 2 +- libavcodec/dvdsubdec.c | 2 +- libavcodec/dvdsubenc.c | 2 +- libavcodec/pgssubdec.c | 2 +- libavcodec/xsubdec.c | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-)

[FFmpeg-devel] [PATCH v22 06/23] avcodec/subtitles: Migrate subtitle encoders to frame-based API and provide a compatibility shim for the legacy api

Signed-off-by: softworkz --- libavcodec/assenc.c| 90 + libavcodec/avcodec.h | 5 +- libavcodec/dvbsubenc.c | 96 +-- libavcodec/dvdsubenc.c | 100 +++-- libavcodec/encode.c| 63

[FFmpeg-devel] [PATCH v22 05/23] avcodec, avutil: Move ass helper functions to avutil as avpriv_ and extend ass dialog parsing

Signed-off-by: softworkz --- libavcodec/Makefile | 56 +++ libavcodec/ass.h | 147 ++ libavcodec/assdec.c | 2 +- libavcodec/assenc.c | 2 +-

[FFmpeg-devel] [PATCH v22 04/23] avfilter/subtitles: Update vf_subtitles to use new decoding api

Signed-off-by: softworkz --- libavfilter/vf_subtitles.c | 54 +- 1 file changed, 42 insertions(+), 12 deletions(-) diff --git a/libavfilter/vf_subtitles.c b/libavfilter/vf_subtitles.c index 3fc4eeb63d..66b2082894 100644 --- a/libavfilter/vf_subtitles.c +++

[FFmpeg-devel] [PATCH v22 03/23] avcodec/subtitles: Introduce new frame-based subtitle decoding API

- Add avcodec_decode_subtitle3 which takes subtitle frames, serving as compatibility shim to legacy subtitle decoding - Add additional methods for conversion between old and new API Signed-off-by: softworkz --- libavcodec/avcodec.h| 8 +- libavcodec/codec_desc.c | 11 +++

[FFmpeg-devel] [PATCH v22 02/23] avutil/frame: Prepare AVFrame for subtitle handling

Root commit for adding subtitle filtering capabilities. In detail: - Add type (AVMediaType) field to AVFrame Replaces previous way of distinction which was based on checking width and height to determine whether a frame is audio or video - Add subtitle fields to AVFrame - Add new struct

[FFmpeg-devel] [PATCH v22 01/23] avcodec, avutil: Move enum AVSubtitleType to avutil, add new and deprecate old values

Signed-off-by: softworkz --- libavcodec/avcodec.h | 19 + libavutil/Makefile | 1 + libavutil/subfmt.h | 66 libavutil/version.h | 1 + 4 files changed, 69 insertions(+), 18 deletions(-) create mode 100644 libavutil/subfmt.h diff

[FFmpeg-devel] [PATCH v22 00/23] Subtitle Filtering

New in V22 - Two new commits, implementing parsing of hard-space ASS tags (\h} The ccaption_dec decoder emits a lot of \h tags via splitcc which the encoders (all using ass_split) didn't handle properly - Combined APIchanges and version bumps into a single commit at the end - Moved new

Re: [FFmpeg-devel] [PATCH v2] libswresample/swresamplec: Err num(negative-size) was used as a function parameter

On Wed, Dec 08, 2021 at 11:17:13AM +0800, Yu Yang wrote: > If cannot allocate memory, ERROR(ENOMEM) '-12' as a parameter will be > constantly being returned. > When run resample() firstly, negative size param would cause buffer-overflow > and SEGV in swri_rematrix(). > When run swri_rematrix()

Re: [FFmpeg-devel] [PATCH 3/5] avfilter/dnn: fix the return value of async_thread_routine

-Original Message- From: ffmpeg-devel On Behalf Of lance.lmw...@gmail.com Sent: 2021年12月9日 9:20 To: ffmpeg-devel@ffmpeg.org Cc: Limin Wang Subject: [FFmpeg-devel] [PATCH 3/5] avfilter/dnn: fix the return value of async_thread_routine From: Limin Wang Signed-off-by: Limin Wang ---

Re: [FFmpeg-devel] [PATCH v2 3/4] avfilter/gblur_vulkan: fix incorrect semantics

Lynne: Sent: 2021年12月9日 19:26 To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2 3/4] avfilter/gblur_vulkan: fix incorrect semantics 9 Dec 2021, 10:36 by jianhua...@intel.com: >> The input and output are

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

On 12/9/2021 8:21 AM, Lynne wrote: 9 Dec 2021, 11:14 by an...@khirnov.net: Quoting Lynne (2021-12-08 13:53:52) That's not a goal, it's anti-goal, and a cause for hysterical raisin picking in the future. Having an instantly debuggable structure rather than one that Instantly debuggable

Re: [FFmpeg-devel] [PATCH v2 1/4] avfilter: add a transpose_vulkan filter

Lynne: Sent: 2021年12月9日 19:17 To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2 1/4] avfilter: add a transpose_vulkan filter 9 Dec 2021, 10:36 by jianhua...@intel.com: >> The following command is on how to

Re: [FFmpeg-devel] [PATCH v2 3/4] avfilter/gblur_vulkan: fix incorrect semantics

9 Dec 2021, 10:36 by jianhua...@intel.com: > The input and output are arrays of images, so it's better to use the plural > to align them to the variable name of VkDescriptorImageInfo. > > Signed-off-by: Wu Jianhua > --- > libavfilter/vf_gblur_vulkan.c | 60 +-- >

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

9 Dec 2021, 11:14 by an...@khirnov.net: > Quoting Lynne (2021-12-08 13:53:52) > >> That's not a goal, it's anti-goal, and a cause for hysterical raisin >> picking in the future. >> Having an instantly debuggable structure rather than one that >> > > Instantly debuggable structure? > > Again: very

Re: [FFmpeg-devel] [PATCH v2 1/4] avfilter: add a transpose_vulkan filter

9 Dec 2021, 10:36 by jianhua...@intel.com: > The following command is on how to apply transpose_vulkan filter: > ffmpeg -init_hw_device vulkan -i input.264 -vf \ > hwupload=extra_hw_frames=16,transpose_vulkan,hwdownload,format=yuv420p > output.264 > > Signed-off-by: Wu Jianhua > --- >

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

Anton Khirnov (12021-12-09): > It is not possible for them to behave "like that", because our current > channel layout API does not support duplicated channels at all. They behave like in the sense they output channels from several sources in a single stream of AVFrame. They could not properly

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

Quoting Lynne (2021-12-08 13:53:52) > That's not a goal, it's anti-goal, and a cause for hysterical raisin > picking in the future. > Having an instantly debuggable structure rather than one that Instantly debuggable structure? Again: very very little code needs to store actual AVChannels. In

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

Quoting Nicolas George (2021-12-08 16:08:54) > Anton Khirnov (12021-12-08): > We get to decide what is a valid use case and what is not. And in this > case, since the devices and filter I quoted already behave like that, It is not possible for them to behave "like that", because our current

[FFmpeg-devel] [PATCH v2 4/4] avfilter/flip_vulkan: fix incorrect semantics

The input and output are arrays of images, so it's better to use the plural to align them to the variable name of VkDescriptorImageInfo. Signed-off-by: Wu Jianhua --- libavfilter/vf_flip_vulkan.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff

[FFmpeg-devel] [PATCH v2 3/4] avfilter/gblur_vulkan: fix incorrect semantics

The input and output are arrays of images, so it's better to use the plural to align them to the variable name of VkDescriptorImageInfo. Signed-off-by: Wu Jianhua --- libavfilter/vf_gblur_vulkan.c | 60 +-- 1 file changed, 30 insertions(+), 30 deletions(-) diff

[FFmpeg-devel] [PATCH v2 1/4] avfilter: add a transpose_vulkan filter

The following command is on how to apply transpose_vulkan filter: ffmpeg -init_hw_device vulkan -i input.264 -vf \ hwupload=extra_hw_frames=16,transpose_vulkan,hwdownload,format=yuv420p output.264 Signed-off-by: Wu Jianhua --- configure | 1 + libavfilter/Makefile

[FFmpeg-devel] [PATCH v2 2/4] avfilter/vf_transpose: fix un-checked potential memory allocation failure

Signed-off-by: Wu Jianhua --- libavfilter/vf_transpose.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_transpose.c b/libavfilter/vf_transpose.c index f9f0d70cd5..b964daeee3 100644 --- a/libavfilter/vf_transpose.c +++

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec/vpp_qsv: Copy side data from input to output frame

> -Original Message- > From: ffmpeg-devel On Behalf Of Xiang, > Haihao > Sent: Thursday, December 9, 2021 9:35 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec/vpp_qsv: Copy side data > from input to output frame > > On Tue, 2021-12-07 at 12:39

Re: [FFmpeg-devel] [PATCH] libavutil/hwcontext_qsv: clean padding when upload qsv frames

On Thu, 2021-12-02 at 15:40 +0800, Wenbin Chen wrote: > When we upload a frame that is not padded as MSDK requires, we create a > new AVFrame to copy data. The frame's padding data is uninitialized so > it brings run to run problem. For example, If we run the following > command serveral times we

  1   2   >