Re: [FFmpeg-devel] [PATCH] avcodec/libx264: add warning log when droping picture at 'h264_select_output_frame'

2021-12-28 Thread Steven Liu
> 2021年12月29日 下午2:59,zozobreak 写道: > > since there is only debug log 'no picture ooo' when droping a picture, > I spent much time to troubleshooting a wrong sps 'num_reorder_frames' param > changed by webrtc's 'ParseAndRewriteSps', > FFmpeg keeped silence about this error, so a warning log is

[FFmpeg-devel] [PATCH] avcodec/libx264: add warning log when droping picture at 'h264_select_output_frame'

2021-12-28 Thread zozobreak
since there is only debug log 'no picture ooo' when droping a picture, I spent much time to troubleshooting a wrong sps 'num_reorder_frames' param changed by webrtc's 'ParseAndRewriteSps', FFmpeg keeped silence about this error, so a warning log is much helpfull about this. Signed-off-by:

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/qsvdec: Implement SEI parsing for QSV decoders

2021-12-28 Thread Xiang, Haihao
On Mon, 2021-11-29 at 18:51 +, Soft Works wrote: > Signed-off-by: softworkz > --- > libavcodec/qsvdec.c | 210 > 1 file changed, 210 insertions(+) > > diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c > index 8bce9f2cf0..62f3e65455 100644 >

[FFmpeg-devel] [PATCH] libx264: Set min build version to 158

2021-12-28 Thread Matt Oliver
Was "[PATCH] libx264: Do not explicitly set X264_API_IMPORTS" Setting X264_API_IMPORTS only affects msvc builds and it breaks linking to static builds (although is required for shared builds). This flag is set by x264 in its pkgconfig as required since build 158

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/hevcdec: make set_side_data() accessible

2021-12-28 Thread Xiang, Haihao
On Mon, 2021-11-29 at 18:51 +, Soft Works wrote: > Signed-off-by: softworkz > --- > libavcodec/hevcdec.c | 112 +-- > libavcodec/hevcdec.h | 2 + > 2 files changed, 57 insertions(+), 57 deletions(-) > > diff --git a/libavcodec/hevcdec.c

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: add support for Screen Content Coding (SCC) extension

2021-12-28 Thread Xiang, Haihao
> -Original Message- > From: Xiang, Haihao > Sent: Monday, September 28, 2020 16:21 > To: ffmpeg-devel@ffmpeg.org > Cc: Xiang, Haihao > Subject: [FFmpeg-devel][PATCH] lavc/qsvenc: add support for Screen Content > Coding (SCC) extension > > This patch adds support for SCC encoding on

Re: [FFmpeg-devel] [PATCH 1/2] lavc/qsv: allow to add more parameter buffers to QSV frame

2021-12-28 Thread Xiang, Haihao
On Tue, 2021-03-23 at 11:00 +0800, Haihao Xiang wrote: > --- > libavcodec/qsv.c | 27 +++ > libavcodec/qsv_internal.h | 8 +++- > libavcodec/qsvdec.c | 8 +--- > 3 files changed, 39 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/qsv.c

Re: [FFmpeg-devel] [PATCH] lavc/qsvdec: needn't free the string for AV_OPT_TYPE_STRING AVOption

2021-12-28 Thread Xiang, Haihao
On Fri, 2021-01-29 at 08:54 +0800, Haihao Xiang wrote: > The string for AV_OPT_TYPE_STRING AVOption gets freed by av_opt_free() > when closing the AVCodecContext > > Signed-off-by: Haihao Xiang > --- > libavcodec/qsvdec.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH, v2] lavf/vf_deinterlace_vaapi: flush queued frame for field in DeinterlacingBob

2021-12-28 Thread Xiang, Haihao
> -Original Message- > From: ffmpeg-devel On Behalf Of Linjie > Fu > Sent: Wednesday, September 18, 2019 16:20 > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie > Subject: [FFmpeg-devel] [PATCH, v2] lavf/vf_deinterlace_vaapi: flush queued > frame for field in DeinterlacingBob > > For

Re: [FFmpeg-devel] [PATCH v6 01/03] libavdevice/avfoundation.m: use AudioConvert, extend supported formats

2021-12-28 Thread Aman Karmani
On Tue, Dec 28, 2021 at 2:50 PM Romain Beauxis wrote: > This is the first patch of a series of 3 that fix, cleanup and enhance the > avfoundation implementation for libavdevice. > > The patches have been submitted a couple of times now and have > received very nice feedback for the last two

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m_dec: dequeue frame if input isn't ready

2021-12-28 Thread Andriy Gelman
On Mon, 27. Dec 03:18, Cameron Gutman wrote: > On 12/27/21 00:17, Andriy Gelman wrote: > > On Tue, 14. Dec 02:12, Cameron Gutman wrote: > >> The V4L2M2M API operates asynchronously, so multiple packets can > >> be enqueued before getting a batch of frames back. Since it was > >> only possible to

Re: [FFmpeg-devel] [PATCH] hevcdec: skip slices with missing PPS instead of skipping the entire packet

2021-12-28 Thread James Almer
On 12/28/2021 7:01 PM, Hendrik Leppkes wrote: On Tue, Dec 28, 2021 at 3:26 PM James Almer wrote: On 12/28/2021 10:49 AM, Hendrik Leppkes wrote: Aborting decoding of the entire packet on a missing PPS can result in missing the actual PPS on streams with badly ordered NALs, where the

[FFmpeg-devel] [PATCH v6 03/03] libavdevice/avfoundation.m: Allow to select devices by unique ID

2021-12-28 Thread Romain Beauxis
This is the third patch of a series of 3 that cleanup and enhance the avfoundation implementation for libavdevice. Changes: v2: None v3: * Switched unique ID to use system-prodvided unique ID * Implemented unique IDs for screen capture v4: Cleanup v5: Fix indentation/wrapping V6: None This

[FFmpeg-devel] [PATCH v6 02/03] libavdevice/avfoundation.m: Replace mutex-based concurrency handling in avfoundation.m by a thread-safe fifo queue with maximum length

2021-12-28 Thread Romain Beauxis
This is the second patch of a series of 3 that cleanup and enhance the avfoundation implementation for libavdevice. Changes: v2: None v3: Switched queue implementation to CMSimpleQueue v4: None v5: Fix indentation/wrapping V6: Fix audio/video frame queue cleanup logic This patch fixes the

[FFmpeg-devel] [PATCH v6 01/03] libavdevice/avfoundation.m: use AudioConvert, extend supported formats

2021-12-28 Thread Romain Beauxis
This is the first patch of a series of 3 that fix, cleanup and enhance the avfoundation implementation for libavdevice. The patches have been submitted a couple of times now and have received very nice feedback for the last two however but they do not seem to have been considered for inclusion

Re: [FFmpeg-devel] [PATCH] hevcdec: skip slices with missing PPS instead of skipping the entire packet

2021-12-28 Thread Hendrik Leppkes
On Tue, Dec 28, 2021 at 3:26 PM James Almer wrote: > > On 12/28/2021 10:49 AM, Hendrik Leppkes wrote: > > Aborting decoding of the entire packet on a missing PPS can result in > > missing the actual PPS on streams with badly ordered NALs, where the > > SPS/PPS/VPS are stitched to the back of the

Re: [FFmpeg-devel] GitHub Integration

2021-12-28 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Niklas Haas > Sent: Tuesday, December 28, 2021 10:22 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] GitHub Integration > > On Tue, 28 Dec 2021 00:59:58 +1000 Zane van Iperen > wrote: > > > > > > On 27/12/21 11:41,

Re: [FFmpeg-devel] GitHub Integration

2021-12-28 Thread Niklas Haas
On Tue, 28 Dec 2021 00:59:58 +1000 Zane van Iperen wrote: > > > On 27/12/21 11:41, lance.lmw...@gmail.com wrote: > > On Sun, Dec 26, 2021 at 04:37:54PM -0500, Ronald S. Bultje wrote: > >> Hi, > >> > >> On Sun, Dec 26, 2021 at 3:21 PM Soft Works wrote: > >> > >>> I'm not sure. My

Re: [FFmpeg-devel] [PATCH 3/3] libavutil/hwcontext_opencl: fix a bug for mapping qsv frame to opencl

2021-12-28 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Mark > Thompson > Sent: Tuesday, December 28, 2021 1:54 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 3/3] libavutil/hwcontext_opencl: fix a bug > for mapping qsv frame to opencl > > On 28/12/2021 01:17,

Re: [FFmpeg-devel] [PATCH] avformat/mov: correct 0 valued entries in stts

2021-12-28 Thread Gyan Doshi
On 2021-12-28 05:18 am, Michael Niedermayer wrote: On Tue, Dec 28, 2021 at 01:33:54AM +0530, Gyan Doshi wrote: On 2021-12-28 12:38 am, Michael Niedermayer wrote: On Mon, Dec 27, 2021 at 11:27:10AM +0530, Gyan Doshi wrote: As per ISO 14496-12, sample duration of 0 is invalid except for the

[FFmpeg-devel] [PATCH v2] avformat/mov: adjust 0 values in stts

2021-12-28 Thread Gyan Doshi
As per ISO 14496-12, sample duration of 0 is invalid except for the last entry. However, some files may use it to stall dts progress in order to recover from a desync. In addition, catch and fix 0 value for sample count. --- v2: adjust dts if 0 duration is encountered libavformat/mov.c | 14

[FFmpeg-devel] [PATCH v4] avformat/mov: add option max_stts_delta

2021-12-28 Thread Gyan Doshi
Very high stts sample deltas may occasionally be intended but usually they are written in error or used to store a negative value for dts correction when treated as signed 32-bit integers. This option lets the user set an upper limit, beyond which the delta is clamped to 1. Values greater than

[FFmpeg-devel] [RFC v2] avdevice: lock to minor version of avformat

2021-12-28 Thread Diederick Niehorster
As per discussion on the list ( https://ffmpeg.org/pipermail/ffmpeg-devel/2021-June/281513.html, see especially https://ffmpeg.org/pipermail/ffmpeg-devel/2021-June/281586.html), to resolve the the unholy ABI-relationship between libavdevice and libavformat and allow easier working on the part of

Re: [FFmpeg-devel] [PATCH] hevcdec: skip slices with missing PPS instead of skipping the entire packet

2021-12-28 Thread James Almer
On 12/28/2021 10:49 AM, Hendrik Leppkes wrote: Aborting decoding of the entire packet on a missing PPS can result in missing the actual PPS on streams with badly ordered NALs, where the SPS/PPS/VPS are stitched to the back of the previous frame, instead of the beginning of the next frame.

[FFmpeg-devel] [PATCH] hevcdec: skip slices with missing PPS instead of skipping the entire packet

2021-12-28 Thread Hendrik Leppkes
Aborting decoding of the entire packet on a missing PPS can result in missing the actual PPS on streams with badly ordered NALs, where the SPS/PPS/VPS are stitched to the back of the previous frame, instead of the beginning of the next frame. Instead, skip the undecodable slice, and let the

Re: [FFmpeg-devel] [RFC] avdevice: lock to minor version of avformat

2021-12-28 Thread Diederick C. Niehorster
FWIW, the macro #define AV_MAKE_MAJOR_MINOR_FUNC_NAME(name,major,minor) AV_GLUE(av,name)AV_GLUE(_version_,major)AV_GLUE(_,minor) doesn't compile on patchwork (https://patchwork.ffmpeg.org/check/49062/), but worked fine for me on MSVC. Is MSVC non-compliant somehow? Suggestions appreciated, I'm no

Re: [FFmpeg-devel] [PATCH 3/3] libavutil/hwcontext_opencl: fix a bug for mapping qsv frame to opencl

2021-12-28 Thread Mark Thompson
On 28/12/2021 01:17, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Mark Thompson Sent: Tuesday, December 28, 2021 12:46 AM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH 3/3] libavutil/hwcontext_opencl: fix a bug for mapping qsv frame to opencl On

Re: [FFmpeg-devel] [PATCH 1/5] avformat/movenc: remove unused argument from get_sample_flags()

2021-12-28 Thread zhilizhao(赵志立)
Ping again. > On Dec 13, 2021, at 11:03 AM, zhilizhao(赵志立) wrote: > > Ping for patch 1-3. > >> On Dec 3, 2021, at 1:06 PM, Zhao Zhili wrote: >> >> --- >> libavformat/movenc.c | 12 ++-- >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/libavformat/movenc.c

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/libx26[45]: add udu_sei option to import user data unregistered SEIs

2021-12-28 Thread lance . lmwang
On Tue, Dec 28, 2021 at 10:12:43AM +0800, "zhilizhao(赵志立)" wrote: > > > > On Dec 28, 2021, at 9:29 AM, lance.lmw...@gmail.com wrote: > > > > On Sat, Dec 25, 2021 at 10:46:52PM +0800, lance.lmw...@gmail.com wrote: > >> From: Limin Wang > >> > >> Most of user data unregistered SEIs are privated

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: set base address for V plane

2021-12-28 Thread Xiang, Haihao
On Mon, 2021-12-13 at 14:40 +0800, Haihao Xiang wrote: > The SDK checks Data.V when using system memory for VP9 encoding. This > fixed the error below: > > $ ffmpeg -qsv_device /dev/dri/renderD129 -f lavfi -i yuvtestsrc -c:v > vp9_qsv -f null - > > [vp9_qsv @ 0x55b8387cbe90] Error during