[FFmpeg-devel] [PATCH 4/4] avcodec/svq1enc: Use unsigned for parameter >= 0 to workaround GCC bug

2022-07-10 Thread Andreas Rheinhardt
encode_block() in svq1enc.c looks like the following: static int encode_block(int block[7][256], int level) { int best_score = 0; for (unsigned x = 0; x < level; x++) { int v = block[1][x]; block[level][x] = 0; best_score += v * v; } if (level > 0 &&

[FFmpeg-devel] [PATCH 3/4] avcodec/h264_loopfilter: Fix incorrect function parameter array size

2022-07-10 Thread Andreas Rheinhardt
filter_mb_mbaff_edgev() and filter_mb_mbaff_edgecv() have a function parameter whose expected size depends upon another parameter: It is 2 * bsi + 1 (with bsi always being 1 or 2). This array is declared as const int16_t[7], yet some of the callers with bsi == 1 call it with only an const

[FFmpeg-devel] [PATCH 2/4] avcodec/snowenc: Don't pass int[2] as parameter declared as int[3]

2022-07-10 Thread Andreas Rheinhardt
check_block_inter() currently does this when calling check_block(). This leads to a -Wstringop-overflow= warning when compiling with GCC 12.1. Given that the main part of the body of check_block() consists of an "if (intra) { ... } else { ... }" which is true iff check_block() is not called from

[FFmpeg-devel] [PATCH 1/4] avformat/asfcrypt: Fix wrong array length in function declaration

2022-07-10 Thread Andreas Rheinhardt
multiswap_step() and multiswap_inv_step() both only require six keys; in all current callers, these keys are part of an array of twelve keys, yet in some of these callers the keys given to these functions point to the second half of these twelve keys, so that only six keys are available to these

Re: [FFmpeg-devel] [PATCH] avcodec/aarch64: Access externs via GOT with PIC

2022-07-10 Thread Triang3l
oh no… I have no idea what's happening, all the newlines in the previous email were destroyed, sorry ugggh… let's try without disabling rich text in the Samsung client this time :/Hi Martin, thanks for a quick and detailed review!Oops, Thunderbird (or something else in the chain) has added

Re: [FFmpeg-devel] [PATCH] avcodec/aarch64: Access externs via GOT with PIC

2022-07-10 Thread Triang3l
Hi Martin, thanks for a quick and detailed review!Oops, Thunderbird (or something else in the chain) has added an extraneous space in the beginning of every line, though the +- deltas seem to be unaffected. I can try sending the patch some other way if needed, like as a binary attachment, or

Re: [FFmpeg-devel] [PATCH v3 1/4] libavutil/dovi_meta: Add nlq_pivots to AVDOVIDataMapping

2022-07-10 Thread quietvoid
On 10/07/2022 19.12, Andreas Rheinhardt wrote: quietvoid: The NLQ pivots are not documented but should be present in the header for profile 7 RPU format. It has been verified using Dolby's verification toolkit. Signed-off-by: quietvoid --- libavcodec/dovi_rpu.c | 9 -

Re: [FFmpeg-devel] [PATCH v3 1/4] libavutil/dovi_meta: Add nlq_pivots to AVDOVIDataMapping

2022-07-10 Thread Andreas Rheinhardt
quietvoid: > The NLQ pivots are not documented but should be present > in the header for profile 7 RPU format. > It has been verified using Dolby's verification toolkit. > > Signed-off-by: quietvoid > --- > libavcodec/dovi_rpu.c | 9 - > libavutil/dovi_meta.h | 1 + > 2 files changed, 9

Re: [FFmpeg-devel] [PATCH v3 0/4] DOVI: Add NLQ pivots to AVDOVIDataMapping

2022-07-10 Thread quietvoid
On 17/06/2022 16.35, quietvoid wrote: The NLQ pivots are not documented but should be present in the header for profile 7 RPU format. It has been verified using Dolby's verification toolkit. With the pivots parsed, the parsed values for num_{x,y}_partitions are correct and usually equal to 1.

Re: [FFmpeg-devel] [PATCH] avcodec/aarch64: Access externs via GOT with PIC

2022-07-10 Thread Martin Storsjö
On Mon, 11 Jul 2022, Martin Storsjö wrote: Hi, Thanks for your patch! While the patch probably is worthwhile to pursue, ffmpeg does work on Android 6 and newer (with the aarch64 assembly), so there's some gaps/misses in the reasoning in the patch description. On Sun, 10 Jul 2022, Triang3l

Re: [FFmpeg-devel] [PATCH] avcodec/aarch64: Access externs via GOT with PIC

2022-07-10 Thread Martin Storsjö
Hi, Thanks for your patch! While the patch probably is worthwhile to pursue, ffmpeg does work on Android 6 and newer (with the aarch64 assembly), so there's some gaps/misses in the reasoning in the patch description. On Sun, 10 Jul 2022, Triang3l wrote: To support PIC, all AArch64 assembly

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/vf_zscale: remove some unneeded initializations

2022-07-10 Thread Paul B Mahol
This was not critical at all, please revert. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/vf_zscale: remove some unneeded initializations

2022-07-10 Thread Marton Balint
On Fri, 8 Jul 2022, Marton Balint wrote: Signed-off-by: Marton Balint --- libavfilter/vf_zscale.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index 44cb4b9c61..6861eef278 100644 --- a/libavfilter/vf_zscale.c +++

[FFmpeg-devel] [PATCH] avcodec/aarch64: Access externs via GOT with PIC

2022-07-10 Thread Triang3l
Android, starting from version 6 (API level 23, from the year 2015), requires all shared libraries to be position-independent, and refuses to load shared libraries (which are the most common native binary type on Android as in Android applications, native code is placed in shared libraries

Re: [FFmpeg-devel] [PATCH v3] ffmpeg: add option -isync

2022-07-10 Thread Anton Khirnov
Quoting Gyan Doshi (2022-07-10 20:02:38) > > > On 2022-07-10 10:46 pm, Anton Khirnov wrote: > > Quoting Gyan Doshi (2022-07-08 05:56:21) > >> > >> On 2022-07-07 03:11 pm, Anton Khirnov wrote: > >>> Quoting Gyan Doshi (2022-07-04 18:29:12) > This is a per-file input option that adjusts an

[FFmpeg-devel] [PATCH] avdevice/avdevice: fix return value of avdevice_list_devices()

2022-07-10 Thread Marton Balint
According to API docs avdevice_list_devices(), avdevice_list_input_sources() and avdevice_list_input_sinks() should return the number of autodetected devices on success. This is redundant with AVDeviceInfoList->nb_devices so it was not noticed earlier that none of the underlying device list

Re: [FFmpeg-devel] [PATCH v1] avformat/imfdec: preserve stream information

2022-07-10 Thread Pierre-Anthony Lemieux
On Sun, Jul 3, 2022 at 2:13 PM Andreas Rheinhardt wrote: > > Pierre-Anthony Lemieux: > > On Sun, Jul 3, 2022 at 12:15 PM Andreas Rheinhardt > > wrote: > >> > >> Pierre-Anthony Lemieux: > >>> On Sun, Jul 3, 2022 at 11:28 AM Andreas Rheinhardt > >>> wrote: > > p...@sandflow.com: > >

Re: [FFmpeg-devel] [PATCH v3] ffmpeg: add option -isync

2022-07-10 Thread Gyan Doshi
On 2022-07-10 10:46 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-07-08 05:56:21) On 2022-07-07 03:11 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-07-04 18:29:12) This is a per-file input option that adjusts an input's timestamps with reference to another input, so that emitted

Re: [FFmpeg-devel] [PATCH v3] ffmpeg: add option -isync

2022-07-10 Thread Anton Khirnov
Quoting Gyan Doshi (2022-07-08 05:56:21) > > > On 2022-07-07 03:11 pm, Anton Khirnov wrote: > > Quoting Gyan Doshi (2022-07-04 18:29:12) > >> This is a per-file input option that adjusts an input's timestamps > >> with reference to another input, so that emitted packet timestamps > >> account

Re: [FFmpeg-devel] [PATCH v3] ffmpeg: add option -isync

2022-07-10 Thread Anton Khirnov
Quoting Gyan Doshi (2022-07-09 21:56:10) > > > On 2022-07-10 01:13 am, Paul B Mahol wrote: > > On Sat, Jul 9, 2022 at 8:28 PM Gyan Doshi wrote: > > > >> > >> On 2022-07-08 09:26 am, Gyan Doshi wrote: > >>> > >>> On 2022-07-07 03:11 pm, Anton Khirnov wrote: > Quoting Gyan Doshi (2022-07-04

Re: [FFmpeg-devel] [PATCH v2][GSoC'22] Chromakey CUDA

2022-07-10 Thread Timo Rothenpieler
Applied with some minor stylistic changes and cleanups Thanks! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/pcm-dvdenc: Remove unused extra_sample(s|_count)

2022-07-10 Thread Paul B Mahol
LGTM to whole set. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 3/3] fate/pcm: Add pcm_dvd transcode tests

2022-07-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- I could also move these tests to a file of their own if desired. tests/fate/pcm.mak | 31 ++ tests/ref/fate/pcm_dvd-16-1-48000 | 11 tests/ref/fate/pcm_dvd-16-1-96000 | 26 tests/ref/fate/pcm_dvd-16-2-48000 | 26

[FFmpeg-devel] [PATCH 2/3] avcodec/pcm-dvdenc: Fix encoding 24bit samples

2022-07-10 Thread Andreas Rheinhardt
The earlier code ignored the lower 16 bits and instead used the highest 8 bits twice. Signed-off-by: Andreas Rheinhardt --- libavcodec/pcm-dvdenc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/pcm-dvdenc.c b/libavcodec/pcm-dvdenc.c index

[FFmpeg-devel] [PATCH 1/3] avcodec/pcm-dvdenc: Remove unused extra_sample(s|_count)

2022-07-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/pcm-dvdenc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/pcm-dvdenc.c b/libavcodec/pcm-dvdenc.c index 6bab1e0aaa..c7f1d46ba3 100644 --- a/libavcodec/pcm-dvdenc.c +++ b/libavcodec/pcm-dvdenc.c @@ -31,8 +31,6 @@ typedef struct

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/amfenc: Add missing profiles

2022-07-10 Thread Marton Balint
On Thu, 13 Jan 2022, Michael Fabian 'Xaymar' Dirks wrote: From: Michael Fabian 'Xaymar' Dirks Adds the missing profiles to the '-help encoder=xxx_amf' list, even if the user may never need these. --- libavcodec/amfenc_h264.c | 11 ++- libavcodec/amfenc_hevc.c | 1 + 2 files changed,

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/amfenc: Set all color metadata for AMF

2022-07-10 Thread Marton Balint
On Thu, 13 Jan 2022, Michael Fabian 'Xaymar' Dirks wrote: From: Michael Fabian 'Xaymar' Dirks Fixes the color information in the output from the AMD encoder being wrong, which led to weird transcoding results. This problem appeared out of thin air, and I've been unable to tie it to a