[FFmpeg-devel] trac issues

2022-08-27 Thread Michael Niedermayer
Hi all someone reported issues with disappearing mail and server load for trac Ive setup SPF for trac, which may have been the reason for gmail blocking mails from it ive also increased the number or processes x threads handling trac requests not sure that was the issue but trac/wsgi had signific

Re: [FFmpeg-devel] [PATCH] avformat/mov: don't read duration from mvhd atom

2022-08-27 Thread Michael Niedermayer
On Sat, Aug 27, 2022 at 04:41:39PM -0300, James Almer wrote: > On 8/16/2022 4:22 PM, Michael Niedermayer wrote: > > On Mon, Aug 15, 2022 at 08:14:42PM -0300, James Almer wrote: > > > This duration is equal to the longest duration in all track's tkhd atoms, > > > which > > > may be comprised of the

Re: [FFmpeg-devel] [PATCH] avformat/mov: don't read duration from mvhd atom

2022-08-27 Thread James Almer
On 8/16/2022 4:22 PM, Michael Niedermayer wrote: On Mon, Aug 15, 2022 at 08:14:42PM -0300, James Almer wrote: This duration is equal to the longest duration in all track's tkhd atoms, which may be comprised of the sum of all edit lists in each track. Empty edit lists in tracks represent start_ti

[FFmpeg-devel] [PATCH v4] libavcodec: Set hidden visibility on global symbols accessed from AArch64 assembly

2022-08-27 Thread Martin Storsjö
The AArch64 assembly accesses those symbols directly, without indirection via e.g. the GOT on ELF. In order for this not to require text relocations, those symbols need to be resolved fully at link time, i.e. those symbols can't be interposable. Normally, so far, this is achieved when linking shar

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-27 Thread Baptiste Coudurier
On Aug 27, 2022, at 4:30 AM, Tomas Härdin wrote: > > lör 2022-08-27 klockan 09:53 +0200 skrev Paul B Mahol: >> On Sat, Aug 27, 2022 at 9:30 AM Tomas Härdin >> wrote: >> >>> ons 2022-08-24 klockan 23:03 +0200 skrev Michael Niedermayer: Also we have regression tests, external libs make that

Re: [FFmpeg-devel] [PATCH v2] avformat/imfdec: check track valid before use it

2022-08-27 Thread Pierre-Anthony Lemieux
On Sat, Aug 27, 2022 at 5:25 AM Steven Liu wrote: > > Pierre-Anthony Lemieux 于2022年8月27日周六 00:06写道: > > > > On Fri, Aug 26, 2022 at 9:01 AM Andreas Rheinhardt > > wrote: > > > > > > Pierre-Anthony Lemieux: > > > > On Fri, Aug 26, 2022 at 1:37 AM Andreas Rheinhardt > > > > wrote: > > > >> > > >

[FFmpeg-devel] [PATCH v2 3/3] fftools/ffmpeg_opt: Check creation of new program

2022-08-27 Thread Andreas Rheinhardt
Fixes Coverity issue #1512413. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg_opt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index ccb79d920c..eddd421b70 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -2753,6 +2753,8

[FFmpeg-devel] [PATCH v2 2/3] fftools: Use report_error_then_exit_program() for allocation failures

2022-08-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- fftools/cmdutils.c | 21 + fftools/ffmpeg.c| 25 ++- fftools/ffmpeg_filter.c | 10 +++--- fftools/ffmpeg_opt.c| 70 - fftools/ffprobe.c | 6 ++-- fftools/opt_common.c|

[FFmpeg-devel] [PATCH v2 1/3] fftools/cmdutils: Add function to report error before exit

2022-08-27 Thread Andreas Rheinhardt
This is designed to improve and unify error handling for allocation failures for the many (often small) allocations that we have in the fftools. These typically either don't return an error message or an error message that is not really helpful to the user and can be replaced by a generic error mes

Re: [FFmpeg-devel] [PATCH 1/3] fftools/cmdutils: Add function to report error before exit

2022-08-27 Thread Andreas Rheinhardt
James Almer: > > > On 8/27/2022 10:55 AM, Andreas Rheinhardt wrote: >> This is designed to improve and unify error handling for >> allocation failures for the many (often small) allocations that we have >> in the fftools. These typically either don't return an error message >> or an error message

Re: [FFmpeg-devel] [PATCH 1/3] fftools/cmdutils: Add function to report error before exit

2022-08-27 Thread James Almer
On 8/27/2022 10:55 AM, Andreas Rheinhardt wrote: This is designed to improve and unify error handling for allocation failures for the many (often small) allocations that we have in the fftools. These typically either don't return an error message or an error message that is not really helpful

[FFmpeg-devel] [PATCH 3/3] fftools/ffmpeg_opt: Check creation of new program

2022-08-27 Thread Andreas Rheinhardt
Fixes Coverity issue #1512413. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg_opt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index b0b8ecc868..74427cf80d 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -2753,6 +2753,8

[FFmpeg-devel] [PATCH 2/3] fftools: Use report_error_then_exit_program() for allocation failures

2022-08-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- fftools/cmdutils.c | 21 + fftools/ffmpeg.c| 25 ++- fftools/ffmpeg_filter.c | 10 +++--- fftools/ffmpeg_opt.c| 70 - fftools/ffprobe.c | 6 ++-- fftools/opt_common.c|

[FFmpeg-devel] [PATCH 1/3] fftools/cmdutils: Add function to report error before exit

2022-08-27 Thread Andreas Rheinhardt
This is designed to improve and unify error handling for allocation failures for the many (often small) allocations that we have in the fftools. These typically either don't return an error message or an error message that is not really helpful to the user and can be replaced by a generic error mes

Re: [FFmpeg-devel] [PATCH v2] avformat/imfdec: check track valid before use it

2022-08-27 Thread Steven Liu
Pierre-Anthony Lemieux 于2022年8月27日周六 00:06写道: > > On Fri, Aug 26, 2022 at 9:01 AM Andreas Rheinhardt > wrote: > > > > Pierre-Anthony Lemieux: > > > On Fri, Aug 26, 2022 at 1:37 AM Andreas Rheinhardt > > > wrote: > > >> > > >> Steven Liu: > > >>> fix CID: 1512414 > > >>> And return AVERROR_INVALI

Re: [FFmpeg-devel] Discrepancy between comments for AVX512 flags

2022-08-27 Thread Henrik Gramner
> On Sat, Aug 27, 2022 at 12:04 AM James Darnley wrote: > I think the feature selection is fine as-is, if you want to clarify > the comments go ahead. AVX512 wouldn't be useful with a subset even > smaller then what the plain AVX512 is looking for (there is also no > CPUs with any smaller set, afa

Re: [FFmpeg-devel] [PATCH 12/21] avcodec/roqvideoenc: Remove internal.h inclusion

2022-08-27 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Possible since c954cf1e1b766a0d1992d5be0a8be0055a8e1a6a. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/roqvideoenc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavcodec/roqvideoenc.c b/libavcodec/roqvideoenc.c > index 0a418c3b89..9f03107d81 100644

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-27 Thread Tomas Härdin
lör 2022-08-27 klockan 09:53 +0200 skrev Paul B Mahol: > On Sat, Aug 27, 2022 at 9:30 AM Tomas Härdin > wrote: > > > ons 2022-08-24 klockan 23:03 +0200 skrev Michael Niedermayer: > > > Also we have regression tests, external libs make that impossible > > > as the version of external libs can chan

Re: [FFmpeg-devel] External Library Dependencies and Testability

2022-08-27 Thread Paul B Mahol
On Sat, Aug 27, 2022 at 11:30 AM Soft Works wrote: > Hi, > > I don’t want to get involved in the ipfsgateway discussion, but the part > about > external library version dependencies and testability reminded me of some > recent thoughts: I wonder whether it wouldn’t make sense to maintain a > vers

[FFmpeg-devel] External Library Dependencies and Testability

2022-08-27 Thread Soft Works
Hi, I don’t want to get involved in the ipfsgateway discussion, but the part about external library version dependencies and testability reminded me of some recent thoughts: I wonder whether it wouldn’t make sense to maintain a version reference for external libraries in a way that at any point i

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-27 Thread Paul B Mahol
On Sat, Aug 27, 2022 at 9:30 AM Tomas Härdin wrote: > ons 2022-08-24 klockan 23:03 +0200 skrev Michael Niedermayer: > > On Wed, Aug 24, 2022 at 06:35:04PM +0200, Tomas Härdin wrote: > > [...] > > > > > > This goes especially for formats like MXF, which I have made the > > > case > > > on here mul

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-27 Thread Tomas Härdin
ons 2022-08-24 klockan 23:03 +0200 skrev Michael Niedermayer: > On Wed, Aug 24, 2022 at 06:35:04PM +0200, Tomas Härdin wrote: > [...] > > > > This goes especially for formats like MXF, which I have made the > > case > > on here multiple times that we should not maintain our own decoder > > for, >

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-27 Thread Tomas Härdin
ons 2022-08-24 klockan 22:54 +0200 skrev Michael Niedermayer: > On Wed, Aug 24, 2022 at 06:35:04PM +0200, Tomas Härdin wrote: > > But for some reason the notion > > that the same applies to *all* parsers, including decoders and > > demuxers, this notion is hard to swallow. And similarly for > > enc