Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000: Add support for High-Throughput JPEG 2000 (HTJ2K) decoding.

2022-09-21 Thread Caleb Etemesi
There is one with way better performance on its way, especially with images with magnitude refinement passes. here @https://github.com/etemesi254/FFmpeg/tree/my-profile And the associated runtime profile from running `perf record -g -F 999 ./ffmpeg_g -i ~/jpeg2000/meridian.ht.j2c -v 32

[FFmpeg-devel] [PATCH v2 7/7] avcodec/avcodec: Escape Doxygen reference

2022-09-21 Thread Marvin Scholz
The # is interpreted as explicit reference request by Doxygen which is not desired here. Additionally use a typewriter font to make the inline code easier to distinguish. --- libavcodec/avcodec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/avcodec.h

[FFmpeg-devel] [PATCH v2 6/7] avformat/avformat: Improve doxy style

2022-09-21 Thread Marvin Scholz
Mostly re-indenting and adding some missing references. --- libavformat/avformat.h | 180 +++-- 1 file changed, 103 insertions(+), 77 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index c695cfc6de..1d97d56ac5 100644 ---

[FFmpeg-devel] [PATCH v2 5/7] swresample/swresample: Fix mismatching argument names

2022-09-21 Thread Marvin Scholz
--- libswresample/swresample.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libswresample/swresample.h b/libswresample/swresample.h index 980be65783..4c26468c63 100644 --- a/libswresample/swresample.h +++ b/libswresample/swresample.h @@ -354,8 +354,8 @@ int

[FFmpeg-devel] [PATCH v2 4/7] avutil: Fix mismatching argument names

2022-09-21 Thread Marvin Scholz
--- libavutil/hwcontext.h | 2 +- libavutil/mathematics.h | 6 -- libavutil/mem.h | 3 ++- libavutil/rational.h| 3 ++- 4 files changed, 9 insertions(+), 5 deletions(-) diff --git a/libavutil/hwcontext.h b/libavutil/hwcontext.h index c18b7e1e8b..efca17585e 100644 ---

[FFmpeg-devel] [PATCH v2 3/7] avformat/avformat: Fix mismatching argument names

2022-09-21 Thread Marvin Scholz
--- libavformat/avformat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 9d46875cce..c695cfc6de 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -2003,7 +2003,7 @@ AVProgram

[FFmpeg-devel] [PATCH v2 2/7] avdevice/avdevice: Fix mismatching argument name

2022-09-21 Thread Marvin Scholz
--- libavdevice/avdevice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/avdevice.h b/libavdevice/avdevice.h index 0b32e59fed..185593053f 100644 --- a/libavdevice/avdevice.h +++ b/libavdevice/avdevice.h @@ -494,7 +494,7 @@ int avdevice_list_devices(struct

[FFmpeg-devel] [PATCH v2 1/7] avcodec: Fix Doxygen trailing brief comments

2022-09-21 Thread Marvin Scholz
The //< comment is not any magic comment supported by Doxygen, instead use //!< to mark them as brief doc for the members. --- libavcodec/avcodec.h | 8 libavcodec/codec_par.h | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/avcodec.h

[FFmpeg-devel] [PATCH 2/2] avutil/dict: Use av_dict_iterate in av_dict_get

2022-09-21 Thread Marvin Scholz
--- libavutil/dict.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/libavutil/dict.c b/libavutil/dict.c index 2f690a5b8e..1a348d6710 100644 --- a/libavutil/dict.c +++ b/libavutil/dict.c @@ -60,18 +60,14 @@ AVDictionaryEntry *av_dict_iterate(const

[FFmpeg-devel] [PATCH 1/2] avutil/dict: Add av_dict_iterate

2022-09-21 Thread Marvin Scholz
This is a more explicit iteration API rather than using the "magic" av_dict_get(d, "", t, AV_DICT_IGNORE_SUFFIX) which is not really trivial to grasp what it does when casually reading through code. --- libavutil/dict.c| 19 +++ libavutil/dict.h| 27

Re: [FFmpeg-devel] [PATCH] lavc: export flag for MPEG audio dual channel

2022-09-21 Thread Scott Theisen
On 9/21/22 15:51, James Almer wrote: On 9/21/2022 4:44 PM, Rémi Denis-Courmont wrote: Le keskiviikkona 21. syyskuuta 2022, 22.26.11 EEST Scott Theisen a écrit : diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 7db5d1b1c5..bcf3a845a8 100644 --- a/libavcodec/avcodec.h +++

Re: [FFmpeg-devel] [PATCH] Media 100i decoder

2022-09-21 Thread Andreas Rheinhardt
Paul B Mahol: > Subject: [PATCH] avcodec: add Media 100i decoder > > Signed-off-by: Paul B Mahol > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/codec_desc.c | 7 ++ > libavcodec/codec_id.h | 1 + > libavcodec/media100.c | 216

[FFmpeg-devel] [PATCH] Media 100i decoder

2022-09-21 Thread Paul B Mahol
Patch attached. From 05c426fe110d788830ab322433ed12319a921b05 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Wed, 21 Sep 2022 18:22:33 +0200 Subject: [PATCH] avcodec: add Media 100i decoder Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 +

[FFmpeg-devel] [PATCH] avutil/channel_layout: mention how the API user should treat channel orders it does not understand

2022-09-21 Thread James Almer
In case new orders are added in the future, existing library users can still use the layout simply by ignoring everything but the channel count in it, so make this explicit. Signed-off-by: James Almer --- libavutil/channel_layout.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH] lavc: export flag for MPEG audio dual channel

2022-09-21 Thread Andreas Rheinhardt
Rémi Denis-Courmont: > Le keskiviikkona 21. syyskuuta 2022, 22.26.11 EEST Scott Theisen a écrit : >> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h >> index 7db5d1b1c5..bcf3a845a8 100644 >> --- a/libavcodec/avcodec.h >> +++ b/libavcodec/avcodec.h >> @@ -2076,6 +2076,17 @@ typedef struct

Re: [FFmpeg-devel] [PATCH] lavc: export flag for MPEG audio dual channel

2022-09-21 Thread James Almer
On 9/21/2022 4:44 PM, Rémi Denis-Courmont wrote: Le keskiviikkona 21. syyskuuta 2022, 22.26.11 EEST Scott Theisen a écrit : diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 7db5d1b1c5..bcf3a845a8 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -2076,6 +2076,17 @@

Re: [FFmpeg-devel] [PATCH] lavc: export flag for MPEG audio dual channel

2022-09-21 Thread Rémi Denis-Courmont
Le keskiviikkona 21. syyskuuta 2022, 22.26.11 EEST Scott Theisen a écrit : > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index 7db5d1b1c5..bcf3a845a8 100644 > --- a/libavcodec/avcodec.h > +++ b/libavcodec/avcodec.h > @@ -2076,6 +2076,17 @@ typedef struct AVCodecContext { > *

[FFmpeg-devel] [PATCH] lavc: export flag for MPEG audio dual channel

2022-09-21 Thread Scott Theisen
From: ulmus-scott The flag identifies two independant mono channels recorded as stereo. This change has been kicking around in the MythTV modifications since 2006. See https://github.com/MythTV/mythtv/commit/435540c9e8ac245ceca968791c67431f37c8d617 I have changed the names and comment. For

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha

2022-09-21 Thread James Zern
On Tue, Sep 20, 2022 at 2:17 PM Vignesh Venkatasubramanian wrote: > > According to the HEIF specification (ISO/IEC 23008-12) Section > 7.5.3.1, tracks with handler_type 'auxv' must contain a 'auxi' box > in its SampleEntry to notify the nature of the auxiliary track to the > decoder. > > The

Re: [FFmpeg-devel] [PATCH 02/13] avformat/mxfdec: Check run_in to fit in int and be valid

2022-09-21 Thread Marton Balint
On Wed, 21 Sep 2022, Tomas Härdin wrote: ons 2022-09-21 klockan 11:35 +0200 skrev Michael Niedermayer: On Tue, Sep 20, 2022 at 01:20:00PM +0200, Tomas Härdin wrote: > tis 2022-09-20 klockan 13:07 +0200 skrev Tomas Härdin: > > sön 2022-09-18 klockan 19:13 +0200 skrev Michael Niedermayer: > >

Re: [FFmpeg-devel] [PATCH 2/7] sws: add jobs option, distinct from threads

2022-09-21 Thread James Almer
On 9/20/2022 2:50 PM, rcombs wrote: This allows for more efficient use of asymmetric-multiprocessing systems. --- libswscale/options.c | 2 ++ libswscale/swscale_internal.h | 1 + libswscale/utils.c| 9 ++--- libswscale/version.h | 2 +- 4 files changed,

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/snow: Move ff_snow_inner_add_yblock() to snow_dwt.c

2022-09-21 Thread Michael Niedermayer
On Wed, Sep 21, 2022 at 01:00:07PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Mon, Sep 19, 2022 at 11:27:49PM +0200, Andreas Rheinhardt wrote: > >> Only used there and by x86 snow asm code as fallback. > >> > >> Signed-off-by: Andreas Rheinhardt > >> --- > >>

Re: [FFmpeg-devel] [PATCH 02/13] avformat/mxfdec: Check run_in to fit in int and be valid

2022-09-21 Thread Michael Niedermayer
On Wed, Sep 21, 2022 at 03:25:33PM +0200, Tomas Härdin wrote: > ons 2022-09-21 klockan 11:35 +0200 skrev Michael Niedermayer: > > On Tue, Sep 20, 2022 at 01:20:00PM +0200, Tomas Härdin wrote: > > > tis 2022-09-20 klockan 13:07 +0200 skrev Tomas Härdin: > > > > sön 2022-09-18 klockan 19:13 +0200

Re: [FFmpeg-devel] [PATCH 02/13] avformat/mxfdec: Check run_in to fit in int and be valid

2022-09-21 Thread Michael Niedermayer
On Wed, Sep 21, 2022 at 03:23:21PM +0200, Tomas Härdin wrote: > ons 2022-09-21 klockan 11:35 +0200 skrev Michael Niedermayer: > > On Tue, Sep 20, 2022 at 01:20:00PM +0200, Tomas Härdin wrote: > > > tis 2022-09-20 klockan 13:07 +0200 skrev Tomas Härdin: > > > > sön 2022-09-18 klockan 19:13 +0200

[FFmpeg-devel] [PATCH] fate/subtitles: Ignore line endings in sub-pgs-remux test

2022-09-21 Thread Andreas Rheinhardt
Should fix ticket #9934. Signed-off-by: Andreas Rheinhardt --- tests/fate/subtitles.mak | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/fate/subtitles.mak b/tests/fate/subtitles.mak index e6684a814b..6c8ddf0d96 100644 --- a/tests/fate/subtitles.mak +++ b/tests/fate/subtitles.mak @@

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cavsdsp: Remove unused function parameter

2022-09-21 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cavs.c| 2 +- > libavcodec/cavsdsp.c | 7 +++ > libavcodec/cavsdsp.h | 6 +++--- > libavcodec/x86/cavsdsp.c | 7 +++ > 4 files changed, 10 insertions(+), 12 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cavsdsp: Remove unused function parameter

2022-09-21 Thread Rémi Denis-Courmont
FWIW, set LGTM -- Реми Дёни-Курмон http://www.remlab.net/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

Re: [FFmpeg-devel] [PATCH] libavformat\matroskadec.c: crop support for matroska demuxer.

2022-09-21 Thread Andreas Rheinhardt
OvchinnikovDmitrii: > In webm specification, it supports cropping information. > (https://www.webmproject.org/docs/container/) So does Matroska; actually, the only reason WebM supports this type of cropping is because it is part of the subset of Matroska that WebM kept. > In ffmpeg, the

[FFmpeg-devel] [PATCH 22 bis/26] lavc/fmtconvert: RISC-V V int32_to_float_fmul_scalar

2022-09-21 Thread remi
From: Rémi Denis-Courmont --- libavcodec/fmtconvert.c| 2 ++ libavcodec/fmtconvert.h| 1 + libavcodec/riscv/Makefile | 2 ++ libavcodec/riscv/fmtconvert_init.c | 39 + libavcodec/riscv/fmtconvert_rvv.S | 40

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000: Add support for High-Throughput JPEG 2000 (HTJ2K) decoding.

2022-09-21 Thread Tomas Härdin
ons 2022-09-21 klockan 12:30 +0200 skrev Tomas Härdin: > Tested this locally on some 4k sample files and it achieved 19 fps > with > -lowres 2 on an Intel(R) Core(TM) i5-3317U CPU @ 1.70GHz (4 cores). > I'm > getting access to a better machine to test this on as well. Ran some tests on a

Re: [FFmpeg-devel] [PATCH 09/17] avcodec/libcodec2: Remove dead channel count check

2022-09-21 Thread Tomas Härdin
sön 2022-09-18 klockan 22:27 +0200 skrev Andreas Rheinhardt: > This encoder has AVCodec.ch_layouts set, so that this is checked > generically. > > Signed-off-by: Andreas Rheinhardt > --- >  libavcodec/libcodec2.c | 1 - >  1 file changed, 1 deletion(-) > > diff --git a/libavcodec/libcodec2.c

Re: [FFmpeg-devel] [PATCH 02/13] avformat/mxfdec: Check run_in to fit in int and be valid

2022-09-21 Thread Tomas Härdin
ons 2022-09-21 klockan 11:35 +0200 skrev Michael Niedermayer: > On Tue, Sep 20, 2022 at 01:20:00PM +0200, Tomas Härdin wrote: > > tis 2022-09-20 klockan 13:07 +0200 skrev Tomas Härdin: > > > sön 2022-09-18 klockan 19:13 +0200 skrev Michael Niedermayer: > > > > Fixes: signed integer overflow:

Re: [FFmpeg-devel] [PATCH 02/13] avformat/mxfdec: Check run_in to fit in int and be valid

2022-09-21 Thread Tomas Härdin
ons 2022-09-21 klockan 11:35 +0200 skrev Michael Niedermayer: > On Tue, Sep 20, 2022 at 01:20:00PM +0200, Tomas Härdin wrote: > > tis 2022-09-20 klockan 13:07 +0200 skrev Tomas Härdin: > > > sön 2022-09-18 klockan 19:13 +0200 skrev Michael Niedermayer: > > > > Fixes: signed integer overflow:

[FFmpeg-devel] [PATCH] avformat/cafenc: derive Opus frame size from the relevant stream parameters

2022-09-21 Thread James Almer
Use the stream duration as last resort, as an off-by-one result of the "st->duration / (caf->packets - 1)" calculation can break playback on some devices. Fixes ticket #9930. Signed-off-by: James Almer --- libavformat/cafenc.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-)

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: Fix crash by uninitialized value

2022-09-21 Thread Thilo Borgmann
Am 15.09.22 um 20:42 schrieb Thilo Borgmann: If create_cv_pixel_buffer() fails, pixel_buffer_info might get into CFRelease() containing an arbitrary value. --- libavcodec/videotoolboxenc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/videotoolboxenc.c

[FFmpeg-devel] [PATCH] libavformat\matroskadec.c: crop support for matroska demuxer.

2022-09-21 Thread OvchinnikovDmitrii
In webm specification, it supports cropping information. (https://www.webmproject.org/docs/container/) In ffmpeg, the implementation of webm is a subset of matroska. In matroskadec.c, those cropping related four fields are forced to 0. for the sample file with crop (crop_bottom =8,

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/snow: Move ff_snow_inner_add_yblock() to snow_dwt.c

2022-09-21 Thread Andreas Rheinhardt
Michael Niedermayer: > On Mon, Sep 19, 2022 at 11:27:49PM +0200, Andreas Rheinhardt wrote: >> Only used there and by x86 snow asm code as fallback. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/snow.c | 33 - >> libavcodec/snow.h | 3 --- >>

Re: [FFmpeg-devel] [PATCH v1 3/3] swscale/la: Add output_lasx.c file.

2022-09-21 Thread Andreas Rheinhardt
Shiyou Yin: > > >> 2022年9月11日 10:06,Shiyou Yin 写道: >> >> >> >>> 2022年9月9日 21:11,Andreas Rheinhardt >> > 写道: >>> >>> Shiyou Yin: > 2022年9月6日 16:12,Shiyou Yin > 写道: > >> >> 2022年8月29日

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000: Add support for High-Throughput JPEG 2000 (HTJ2K) decoding.

2022-09-21 Thread Tomas Härdin
ons 2022-09-21 klockan 11:13 +0300 skrev Caleb Etemesi: > > > Please separate struct renaming into a separate patch > > Will do in the next patch > > > > Corresponds to µ_start, right? > > Not sure what  µ_start here relates to, but this is the zero bit > plane > information in *B.10.5* > of

Re: [FFmpeg-devel] [PATCH 0/3] Provide neon implementations

2022-09-21 Thread Martin Storsjö
On Tue, 20 Sep 2022, Hubert Mazur wrote: This fixes issues addressed in previous patchset: - move sub instruction in vsad8_intra, - remove unnecessary mov instructions, - remove single lane extraction in loop and place it at the end. Removing mov instructions from pix_median_abs functions

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mjpegdec: Check for unsupported bayer case

2022-09-21 Thread Michael Niedermayer
On Sun, Sep 18, 2022 at 11:57:03PM +0200, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 51462/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-662559341582745 > > Found-by: continuous fuzzing process >

[FFmpeg-devel] [PATCH v4] libavcodec/cbs_av1: Add size check before parse obu

2022-09-21 Thread Wenbin Chen
cbs_av1_write_obu() check pbc size after parsing obu frame, and return AVERROR(ENOSPC) if pbc is small. pbc will be reallocated and this obu frame will be parsed again, but this may cause error because CodedBitstreamAV1Context has already been updated, for example ref_order_hint is updated and

Re: [FFmpeg-devel] [PATCH 02/13] avformat/mxfdec: Check run_in to fit in int and be valid

2022-09-21 Thread Michael Niedermayer
On Tue, Sep 20, 2022 at 01:20:00PM +0200, Tomas Härdin wrote: > tis 2022-09-20 klockan 13:07 +0200 skrev Tomas Härdin: > > sön 2022-09-18 klockan 19:13 +0200 skrev Michael Niedermayer: > > > Fixes: signed integer overflow: 9223372036854775807 - -2146905566 > > > cannot be represented in type

Re: [FFmpeg-devel] [PATCH v3] libavcodec/cbs_av1: Add size check before parse obu

2022-09-21 Thread Chen, Wenbin
> > cbs_av1_write_unit() check pbc size after parsing obu frame, and return > > It is cbs_av1_write_obu(), not cbs_av1_write_unit(), right ? > > Thanks > Haihao > Sorry, it is typo. cbs_av1_write_obu is assigned to write_unit function pointer. I will fix it and resubmit patch. Thanks Wenbin

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/snow: Move ff_snow_inner_add_yblock() to snow_dwt.c

2022-09-21 Thread Michael Niedermayer
On Mon, Sep 19, 2022 at 11:27:49PM +0200, Andreas Rheinhardt wrote: > Only used there and by x86 snow asm code as fallback. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/snow.c | 33 - > libavcodec/snow.h | 3 --- > libavcodec/snow_dwt.c | 32

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/avfilter: Make ff_command_queue_pop() static

2022-09-21 Thread Nicolas George
Andreas Rheinhardt (12022-09-21): > Only used here. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/avfilter.c | 6 +++--- > libavfilter/internal.h | 2 -- > 2 files changed, 3 insertions(+), 5 deletions(-) Both patches look ok. Regards, -- Nicolas George signature.asc

Re: [FFmpeg-devel] [PATCH 2/7] sws: add jobs option, distinct from threads

2022-09-21 Thread Michael Niedermayer
On Wed, Sep 21, 2022 at 10:37:04AM +0200, Michael Niedermayer wrote: > On Tue, Sep 20, 2022 at 12:50:16PM -0500, rcombs wrote: > > This allows for more efficient use of asymmetric-multiprocessing systems. > > --- > > libswscale/options.c | 2 ++ > > libswscale/swscale_internal.h | 1 + >

Re: [FFmpeg-devel] [PATCH 2/7] sws: add jobs option, distinct from threads

2022-09-21 Thread Michael Niedermayer
On Tue, Sep 20, 2022 at 12:50:16PM -0500, rcombs wrote: > This allows for more efficient use of asymmetric-multiprocessing systems. > --- > libswscale/options.c | 2 ++ > libswscale/swscale_internal.h | 1 + > libswscale/utils.c| 9 ++--- > libswscale/version.h |

Re: [FFmpeg-devel] [PATCH v3] libavcodec/cbs_av1: Add size check before parse obu

2022-09-21 Thread Xiang, Haihao
> cbs_av1_write_unit() check pbc size after parsing obu frame, and return It is cbs_av1_write_obu(), not cbs_av1_write_unit(), right ? Thanks Haihao > AVERROR(ENOSPC) if pbc is small. pbc will be reallocated and this obu > frame will be parsed again, but this may cause error because >

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000: Add support for High-Throughput JPEG 2000 (HTJ2K) decoding.

2022-09-21 Thread Caleb Etemesi
>> Please separate struct renaming into a separate patch Will do in the next patch >> Corresponds to µ_start, right? Not sure what µ_start here relates to, but this is the zero bit plane information in *B.10.5* of the jpeg2000 spec (ITU Rec. T.800 (06/2019)) >> Could also be called Lcup and

[FFmpeg-devel] [PATCH] A-pac demuxer and decoder

2022-09-21 Thread Paul B Mahol
Patches attached. From 751526c456d09bd22a6316196219d79876ae74f1 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Mon, 19 Sep 2022 22:14:05 +0200 Subject: [PATCH 1/2] avcodec: add APAC decoder Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 +

Re: [FFmpeg-devel] [PATCH 14/17] avcodec/mlpenc: Simplify channel layout comparisons

2022-09-21 Thread Paul B Mahol
On 9/18/22, Andreas Rheinhardt wrote: > These encoders have AVCodec.ch_layouts set, so ff_encode_preinit() > has already checked that the used channel layout is equivalent > to one of these native layouts. Therefore one can simply > compare the channel masks (with the added complication > that

Re: [FFmpeg-devel] [PATCH 15/17] avcodec/mlpenc: Remove dead channel layout checks

2022-09-21 Thread Paul B Mahol
On 9/18/22, Andreas Rheinhardt wrote: > ff_encode_preinit() has already checked that the channel layout > is equivalent to one of the layouts in AVCodec.ch_layouts. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mlpenc.c | 11 +-- > 1 file changed, 5 insertions(+), 6

Re: [FFmpeg-devel] [PATCH 13/17] avcodec/mlpenc: Fix channel layouts

2022-09-21 Thread Paul B Mahol
On 9/18/22, Andreas Rheinhardt wrote: > The encoder actually creates files with side channels, not back > channels. See thd_layout in mlp_parse.h. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mlpenc.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > lgtm > diff

Re: [FFmpeg-devel] [PATCH] avformat/mov: get the correct fragment stsd_id when decrypting the sample

2022-09-21 Thread Steven Liu
Zhao Zhili 于2022年9月16日周五 17:28写道: > > > > From: Wang Yaqiang > > > > When determining whether a packet should be decrypted, > > should use the stsd_id of the fragment where the current packet is located. > > > > Signed-off-by: Wang Yaqiang > > --- > > libavformat/isom.h | 1 + > >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/dashdec: Fix crash on invalid input/ENOMEM, fix leak

2022-09-21 Thread Steven Liu
Andreas Rheinhardt 于2022年9月21日周三 04:25写道: > > In case a SupplementalProperty node exists in an adaptationset, > it is searched for a "schemeIdUri" property via xmlGetProp(). > Whatever xmlGetProp() returns is then compared via av_strcasecmp() > to a string literal. xmlGetProp() can return NULL,