[FFmpeg-devel] linker error

2022-10-19 Thread Helmut K. C. Tessarek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 I compile the static ffmpeg binaries for macOS and I have noticed just now the following error: duplicate symbol '_read_file' in: fftools/ffmpeg_opt.o /Users/Shared/ffmpeg/sw/lib/libass.a(ass.o) ld: 1 duplicate symbol for architecture

Re: [FFmpeg-devel] [PATCH] avformat/hls: fix spelling and grammar on wrap warning

2022-10-19 Thread Gyan Doshi
On 2022-10-19 08:33 pm, Tristan Matthews wrote: On Fri, Oct 7, 2022 at 1:41 AM Gyan Doshi wrote: On 2022-10-05 08:59 pm, Steven Liu wrote: Tristan Matthews 于2022年10月5日周三 22:44写道: --- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH v1] avcodec/sbc_parser: Fix parser error when reading data slowly.

2022-10-19 Thread javashu2012
From: bevis When reading data is slow, such as 10 bytes at a time, the header bytes will be overwritten by the body data, resulting in an error in parsing the header. Signed-off-by: bevis --- libavcodec/sbc_parser.c | 34 -- 1 file changed, 24 insertions(+),

Re: [FFmpeg-devel] [PATCHv2 3/4] avcodec/svq1enc: output ident string in extradata field

2022-10-19 Thread James Almer
On 10/19/2022 10:30 PM, Peter Ross wrote: This will enable the acurate identification of FFmpeg produced SVQ1 streams, should there be new bugs found in the encoder. --- libavcodec/svq1enc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/svq1enc.c

[FFmpeg-devel] [PATCHv2 4/4] avcodec/svq1dec: detect buggy FFmpeg encoder and apply correction to interframe mean symbols

2022-10-19 Thread Peter Ross
--- libavcodec/svq1dec.c | 32 +++- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/libavcodec/svq1dec.c b/libavcodec/svq1dec.c index 828b38b93d..c7269456e2 100644 --- a/libavcodec/svq1dec.c +++ b/libavcodec/svq1dec.c @@ -73,6 +73,8 @@ typedef struct

[FFmpeg-devel] [PATCHv2 3/4] avcodec/svq1enc: output ident string in extradata field

2022-10-19 Thread Peter Ross
This will enable the acurate identification of FFmpeg produced SVQ1 streams, should there be new bugs found in the encoder. --- libavcodec/svq1enc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/svq1enc.c b/libavcodec/svq1enc.c index 9bd5a04368..6aacaef88d 100644 ---

[FFmpeg-devel] [PATCHv2 2/4] avcodec/svq1enc: do not use ambiguous interframe mean symbols

2022-10-19 Thread Peter Ross
Don't emit interframe mean symbols -128 and 128 to maintain compatibility with older versions of FFmpeg that incorrectly interpret these symbols. --- libavcodec/svq1enc.c | 5 + tests/ref/seek/vsynth_lena-svq1 | 28 ++-- tests/ref/vsynth/vsynth1-svq1

[FFmpeg-devel] [PATCHv2 1/4] avcodec/svq1: fix interframe mean VLC symbols

2022-10-19 Thread Peter Ross
Fixes ticket #128. The SVQ1 interframe mean VLC symbols -128 and 128 are incorrectly swapped in our SVQ1 implementation, resulting in visible artifacts for some videos. This patch unswaps the order of these two symbols. The most noticable example of the artiacts caused by this error can be

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/libsvtav1: replace vbv_bufsize with maximum_buffer_size_ms

2022-10-19 Thread Christopher Degawa
On Wed, Oct 19, 2022 at 7:00 PM James Almer wrote: > On 10/19/2022 7:47 PM, Christopher Degawa wrote: > > From: Christopher Degawa > > diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c > > index 28da206cf8..74dad9892b 100644 > > --- a/libavcodec/libsvtav1.c > > +++

Re: [FFmpeg-devel] [PATCH v1 03/11] avcodec: enable cbs for H266/VVC

2022-10-19 Thread James Almer
On 10/19/2022 4:25 AM, thomas...@spin-digital.com wrote: From: Thomas Siedel Add ff_cbs_type_h266 to cbs types tables and AV_CODEC_ID_H266 to cbs codec ids. Change CBS_MAX_UNIT_TYPES to 8 as VVC implements 8 different slice types Signed-off-by: Thomas Siedel --- libavcodec/Makefile |

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/libsvtav1: replace vbv_bufsize with maximum_buffer_size_ms

2022-10-19 Thread James Almer
On 10/19/2022 7:47 PM, Christopher Degawa wrote: From: Christopher Degawa svt-av1 v1.2.0 has deprecated vbv_bufsize in favor of using - maximum_buffer_size_ms (--buf-sz) - starting_buffer_level_ms (--buf-initial-sz) - optimal_buffer_level_ms (--buf-optimal-sz) and vbv_bufsize has not been in

[FFmpeg-devel] [PATCH 2/2] avcodec/libsvtav1: replace vbv_bufsize with maximum_buffer_size_ms

2022-10-19 Thread Christopher Degawa
From: Christopher Degawa svt-av1 v1.2.0 has deprecated vbv_bufsize in favor of using - maximum_buffer_size_ms (--buf-sz) - starting_buffer_level_ms (--buf-initial-sz) - optimal_buffer_level_ms (--buf-optimal-sz) and vbv_bufsize has not been in use since svt-av1 v0.8.6 Signed-off-by:

[FFmpeg-devel] [PATCH 1/2] avcodec/libsvtav1: remove compressed_ten_bit_format and simplify alloc_buffer

2022-10-19 Thread Christopher Degawa
From: Christopher Degawa compressed_ten_bit_format has been deprecated upstream and has no effect and can be removed. Plus, technically it was never used in the first place since it would require the app (ffmpeg) to set it and do additional processing of the input frames. Also simplify

[FFmpeg-devel] [PATCH 2/2] avocdec/cbs_internal: Rename CBS_MAX_UNIT_TYPES->CBS_MAX_LIST_UNIT_TYPES

2022-10-19 Thread Andreas Rheinhardt
This makes it clearer that this limit does not apply to CBS_UNIT_TYPE_RANGE units. Signed-off-by: Andreas Rheinhardt --- Inspired by https://ffmpeg.org/pipermail/ffmpeg-devel/2022-October/303005.html libavcodec/cbs_internal.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

Re: [FFmpeg-devel] [PATCH] avformat/hls: fix spelling and grammar on wrap warning

2022-10-19 Thread Tristan Matthews
On Fri, Oct 7, 2022 at 1:41 AM Gyan Doshi wrote: > > > On 2022-10-05 08:59 pm, Steven Liu wrote: > > Tristan Matthews 于2022年10月5日周三 22:44写道: > >> --- > >> libavformat/hls.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/libavformat/hls.c b/libavformat/hls.c

[FFmpeg-devel] [PATCH 1/2] avcodec/cbs: Remove CBS_CONTENT_TYPE_POD

2022-10-19 Thread Andreas Rheinhardt
It is equivalent to CBS_CONTENT_TYPE_INTERNAL_REFS with nb_offsets equal to zero. Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs.c | 18 -- libavcodec/cbs_internal.h | 21 - 2 files changed, 16 insertions(+), 23 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/mpegvideo_motion: Move mspel/gmc motion to mpeg4videodec.c

2022-10-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > It is the only codec for which mcsel is ever set. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpeg4videodec.c| 168 ++ > libavcodec/mpeg4videodec.h| 3 + > libavcodec/mpegvideo_motion.c | 166

Re: [FFmpeg-devel] [PATCH 1/9] avcodec/(ffv1|h264|png|snow)dec: Remove comment out DRAW_HORIZ_BAND cap

2022-10-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ffv1dec.c | 2 +- > libavcodec/h264dec.c | 2 +- > libavcodec/pngdec.c | 4 ++-- > libavcodec/snowdec.c | 2 +- > 4 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/ffv1dec.c

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/mpegvideo: Ignore skip_idct for encoders

2022-10-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > It is documented to be unused for encoders. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpegvideo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c > index 5095149eaa..448b65bb96 100644

Re: [FFmpeg-devel] [PATCH v1 06/11] avformat: add demuxer and probe support for H266/VVC

2022-10-19 Thread Michael Niedermayer
On Wed, Oct 19, 2022 at 09:25:03AM +0200, thomas...@spin-digital.com wrote: > From: Thomas Siedel > > Add demuxer to probe raw vvc and parse vvcc byte stream format. > > Signed-off-by: Thomas Siedel > --- > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + >

Re: [FFmpeg-devel] [PATCH v7 0/2] ffmpeg: Add display_{rotation, hflip, vflip} options

2022-10-19 Thread Thilo Borgmann
Am 19.10.22 um 12:04 schrieb Thilo Borgmann: Am 15.10.22 um 12:25 schrieb Thilo Borgmann: Hi, this is an almost identical rebased version of Jan's patchset discussed in [1], now v7... Should fix #8329 and #6370. Fixed with two more nits, OK'd by Anton via Jitsi. Pushed with... Thanks,

Re: [FFmpeg-devel] [PATCH v7 0/2] ffmpeg: Add display_{rotation, hflip, vflip} options

2022-10-19 Thread Thilo Borgmann
Am 15.10.22 um 12:25 schrieb Thilo Borgmann: Hi, this is an almost identical rebased version of Jan's patchset discussed in [1], now v7... Should fix #8329 and #6370. Fixed with two more nits, OK'd by Anton via Jitsi. Thanks, Thilo ___

[FFmpeg-devel] [PATCH] avcodec/dpx: fix check of minimal data size for unpadded content

2022-10-19 Thread Jerome Martinez
stride value is not relevant with unpadded content and the total count of pixels (width x height) must be used instead of the rounding based on width only then multiplied by height unpadded_10bit value computing is moved sooner in the code in order to be able to use it during computing of

[FFmpeg-devel] [PATCH] lavc/pthread_frame: set worker thread names

2022-10-19 Thread Anton Khirnov
--- Yes, the space is limited and we could bikeshed until christmas about the best way to use it. Here's an attempt with an 'av' prefix, 'ft' (frame thread) changed to df (decoder - frame thread), and only two characters guranteed for thread index. --- libavcodec/pthread_frame.c | 13

[FFmpeg-devel] [PATCH] configure: Remove a leftover comment about MSVC C99 support

2022-10-19 Thread Martin Storsjö
Support for building with older versions of MSVC (with the c99wrap/c99conv frontend) was removed in ce943dd6acbfdfc40223c0fb24d4cad438e6499c. Signed-off-by: Martin Storsjö --- configure | 6 -- 1 file changed, 6 deletions(-) diff --git a/configure b/configure index 6712d045d9..ed52212f93

[FFmpeg-devel] [PATCH v4] avformat/hls: Add option to retry failed segments for hls

2022-10-19 Thread gnattu
Current HLS implementation simply skip a failed segment to catch up the stream, but this is not optimal for some use cases like livestream recording. Add an option to retry a failed segment to ensure the output file is a complete stream. Signed-off-by: gnattu --- v4 added documentation for the

[FFmpeg-devel] [PATCH v1 08/11] avcodec: add external decoder libvvdec for H266/VVC

2022-10-19 Thread thomas . ff
From: Thomas Siedel Add external decoder VVdeC for H266/VVC decoding. Register new decoder libvvdec Add vvc_parse_extradata to support parse/probe of vvcC stream input Add vvc_paramset that implements the parser of vvcC configuration boxes Add libvvdec to wrap the vvdec interface into ffmpeg

[FFmpeg-devel] [PATCH v1 09/11] avcodec: add external encoder libvvenc for H266/VVC

2022-10-19 Thread thomas . ff
From: Thomas Siedel Add external encoder VVenC for H266/VVC encoding. Register new encoder libvvencc Add libvvenc to wrap the vvenc interface into ffmpeg libvvenc implements encoder option: preset,qp,period,subjopt,vvenc-params,levelidc,tier Enable encoder by adding --enable-libvvenc in

[FFmpeg-devel] [PATCH v1 07/11] avformat: add muxer support for H266/VVC

2022-10-19 Thread thomas . ff
From: Thomas Siedel Add muxer for vvcc byte stream format. Add AV_CODEC_ID_VVC to ff_mp4_obj_type Add AV_CODEC_ID_VVC to ISO Media codec (VvcConfigurationBox vvi1, vvc1 defined in ISO/IEC 14496-15:2021) Add VvcConfigurationBox vvcC which extends FullBox type in ISO/IEC 14496-15:2021 Add

[FFmpeg-devel] [PATCH v1 06/11] avformat: add demuxer and probe support for H266/VVC

2022-10-19 Thread thomas . ff
From: Thomas Siedel Add demuxer to probe raw vvc and parse vvcc byte stream format. Signed-off-by: Thomas Siedel --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/demux.c | 7 +- libavformat/vvc.c| 918 +++

[FFmpeg-devel] [PATCH v1 11/11] avcodec: increase minor version for H266/VVC

2022-10-19 Thread thomas . ff
From: Thomas Siedel Increase avcodec minor version for vvc support. Signed-off-by: Thomas Siedel --- libavcodec/version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/version.h b/libavcodec/version.h index f8abc803b6..86ac0f3871 100644 ---

[FFmpeg-devel] [PATCH v1 10/11] avformat: add ts stream types for H266/VVC

2022-10-19 Thread thomas . ff
From: Thomas Siedel Add transport stream stream type 0x33 for vvc. Add STREAM_TYPE_VIDEO_VVC to MPEG-1/2 and MPEG-2 transport stream Add basic transport stream support for TS mux/demux Signed-off-by: Thomas Siedel --- configure | 2 +- libavformat/mpeg.c | 3 ++

[FFmpeg-devel] [PATCH v1 05/11] avcodec: add MP4 to annexb support for H266/VVC

2022-10-19 Thread thomas . ff
From: Thomas Siedel Add parser for VVC MP4 to Annex B byte stream format. Signed-off-by: Thomas Siedel --- configure| 1 + libavcodec/Makefile | 2 + libavcodec/bitstream_filters.c | 2 + libavcodec/h266_metadata_bsf.c | 145 ++

[FFmpeg-devel] [PATCH v1 04/11] avcodec: add bitstream parser for H266/VVC

2022-10-19 Thread thomas . ff
From: Thomas Siedel Add nal parser ff_vvc_parser to parse vvc elementary bitstreams. Signed-off-by: Thomas Siedel --- configure| 3 + libavcodec/Makefile | 1 + libavcodec/h2645_parse.c | 71 - libavcodec/parsers.c | 1 + libavcodec/vvc_parser.c | 588

[FFmpeg-devel] [PATCH v1 03/11] avcodec: enable cbs for H266/VVC

2022-10-19 Thread thomas . ff
From: Thomas Siedel Add ff_cbs_type_h266 to cbs types tables and AV_CODEC_ID_H266 to cbs codec ids. Change CBS_MAX_UNIT_TYPES to 8 as VVC implements 8 different slice types Signed-off-by: Thomas Siedel --- libavcodec/Makefile | 1 + libavcodec/cbs.c | 6 ++

[FFmpeg-devel] [PATCH v1 01/11] avcodec: add enum types for H266/VVC

2022-10-19 Thread thomas . ff
From: Thomas Siedel Add needed types as nal unit types, slice types and vvc typedefs needed for parsing vvc high-level syntax Signed-off-by: Thomas Siedel --- libavcodec/vvc.h | 142 +++ 1 file changed, 142 insertions(+) create mode 100644

[FFmpeg-devel] [PATCH v1 00/11] Add support for H266/VVC

2022-10-19 Thread thomas . ff
From: Thomas Siedel This patch set adds H266/VVC support. This includes parsing, muxing, demuxing, decoding and encoding. Decoding is done using the external library VVdeC (https://github.com/fraunhoferhhi/vvdec.git) and can be enabled with --enable-libvvdec. Encoding is done using the external