Re: [FFmpeg-devel] [PATCH] libavformat/aea EOF Patch

2023-03-08 Thread asivery
Thank you very much, indeed that works as well. Here's the updated patch. Best regards. --- diff --git a/libavformat/aea.c b/libavformat/aea.c index f4b39e4f9e..d16217381b 100644 --- a/libavformat/aea.c +++ b/libavformat/aea.c @@ -90,13 +90,7 @@ static int aea_read_header(AVFormatContext *s)

Re: [FFmpeg-devel] [PATCH] libavformat/img2dec: fix unable to find svg format when the svg resources start with "

2023-03-08 Thread Marton Balint
On Tue, 7 Mar 2023, 1035567...@qq.com wrote: From: Wang Yaqiang svg is xml, but --- libavformat/img2dec.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index 5a63d7c81d..448a574b59 100644 ---

Re: [FFmpeg-devel] [PATCH] libavformat/aea EOF Patch

2023-03-08 Thread Marton Balint
On Sat, 4 Mar 2023, asivery wrote: Could someone please take a look? This would improve AEA demuxing, right now every AEA file makes ffmpeg crash with an error. The way I see it, you could simply replace the whole body of aea_read_packet() with this single line: return

Re: [FFmpeg-devel] [PATCH v2 1/3] decklink: Don't take for granted that first frame to decklink output will be PTS 0

2023-03-08 Thread Marton Balint
On Fri, 3 Mar 2023, Devin Heitmueller wrote: The existing code assumed that the first frame received by the decklink output would always be PTS zero. However if running in other timing modes than the default of CBR, items such as frame dropping at the beginning may result in starting at a

Re: [FFmpeg-devel] [PATCH] libavformat/http.c: cookie path attribute should be optional not compulsory

2023-03-08 Thread Marton Balint
On Fri, 3 Mar 2023, Michael J. Walsh wrote: The path attribute in the Set-Cookie header is optional but treated by ffmpeg as being compulsory. Signed-off-by: Michael J. Walsh —-- libavformat/http.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Thanks, will apply. Regards,

Re: [FFmpeg-devel] [PATCH] libavforamt/tls: Memory allocation failure check

2023-03-08 Thread Marton Balint
On Fri, 3 Mar 2023, jackarain wrote: Signed-off-by: jackarain --- libavformat/tls.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) Thanks, will apply. Regards, Marton diff --git a/libavformat/tls.c b/libavformat/tls.c index e42d399862..b9d3426331

Re: [FFmpeg-devel] [PATCH] libavforamt/udp: Memory allocation failure check

2023-03-08 Thread Marton Balint
On Fri, 3 Mar 2023, jackarain wrote: Signed-off-by: jackarain --- libavformat/udp.c | 4 1 file changed, 4 insertions(+) Thanks, will apply. Regards, Marton diff --git a/libavformat/udp.c b/libavformat/udp.c index e8980b29d8..909213a467 100644 --- a/libavformat/udp.c +++

[FFmpeg-devel] [PATCH] avcodec/cscd: Check for CamStudio Lossless Codec 1.0 behavior in end check

2023-03-08 Thread Michael Niedermayer
Alternatively the check could be simply made more tolerant Fixes: Ticket10227 Signed-off-by: Michael Niedermayer --- libavcodec/cscd.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/cscd.c b/libavcodec/cscd.c index b4ed3332a9..5d55f6e4d1 100644 ---

Re: [FFmpeg-devel] [PATCH] Fix issue when invalid nb_index_entries value is read - SPONSORED BY INA (Institut National de l'Audiovisuel)

2023-03-08 Thread Marton Balint
On Wed, 8 Mar 2023, Cédric Le Barz wrote: Fix issue when invalid nb_index_entries value is read : in case of false nb_index_entries value, ffmpeg exit. This patch fix this problem. What do you mean invalid? Is the value wrong, or is the file truncated in the middle of the index segment?

Re: [FFmpeg-devel] [PATCH 2/2] fftools: enable long path support on Windows

2023-03-08 Thread Ridley Combs
> On Mar 8, 2023, at 15:35, Martin Storsjö wrote: > > On Wed, 8 Mar 2023, rcombs wrote: > >> This allows use of filesystem paths longer than MAX_PATH (260 characters) >> on Windows 10 version 1607 and later. >> >> This _may_ be a no-op if a "LongPathsEnabled" isn't set in the registry. >>

[FFmpeg-devel] [PATCH 2/2] lavc/ass: error if not passed exactly 1 rect

2023-03-08 Thread rcombs
This never produced valid output. --- libavcodec/assenc.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/libavcodec/assenc.c b/libavcodec/assenc.c index db6fd25dd7..41332d33fb 100644 --- a/libavcodec/assenc.c +++ b/libavcodec/assenc.c @@ -45,27

[FFmpeg-devel] [PATCH 1/2] ffmpeg: send only one rect per packet when encoding ASS

2023-03-08 Thread rcombs
The packet and rect formats are identical, so there's no support for multiple rects per packet. --- fftools/ffmpeg.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index d721a5e721..438bee8fef 100644 ---

Re: [FFmpeg-devel] [PATCH 2/2] fftools: enable long path support on Windows

2023-03-08 Thread Martin Storsjö
On Wed, 8 Mar 2023, rcombs wrote: This allows use of filesystem paths longer than MAX_PATH (260 characters) on Windows 10 version 1607 and later. This _may_ be a no-op if a "LongPathsEnabled" isn't set in the registry. --- fftools/fftools.manifest | 1 + 1 file changed, 1 insertion(+) Are you

[FFmpeg-devel] [PATCH 2/2] fftools: enable long path support on Windows

2023-03-08 Thread rcombs
This allows use of filesystem paths longer than MAX_PATH (260 characters) on Windows 10 version 1607 and later. This _may_ be a no-op if a "LongPathsEnabled" isn't set in the registry. --- fftools/fftools.manifest | 1 + 1 file changed, 1 insertion(+) diff --git a/fftools/fftools.manifest

[FFmpeg-devel] [PATCH 1/2] fftools: set process code page to UTF-8 on Windows

2023-03-08 Thread rcombs
This causes char-based filesystem and other API calls to accept and produce UTF-8 strings instead of locale-dependent legacy code page strings, when running on Win10 or newer. By and large, ffmpeg uses the wide-character equivalents of these APIs, so this shouldn't have any effect on most usage.

[FFmpeg-devel] [PATCH] avformat/matroska: Write WebVTT subtitles according to MKV specs

2023-03-08 Thread Gwyneth Morgan
When writing WebMs, FFmpeg muxes WebVTT subtitles with the D_WEBVTT/* codec tags from the WebM specs [1]. However, it does the same when muxing MKV files, and the Matroska specifications instead use S_TEXT/WEBVTT tags for WebVTT subtitles [2], which FFmpeg currently doesn't understand. Support

[FFmpeg-devel] [PATCH v2 2/2] avcodec/pngenc: write sBIT chunks

2023-03-08 Thread Leo Izen
Add support for writing sBIT chunks, which mark the significant bit depth of the PNG file. This obtains the metadata using the field bits_per_raw_sample of AVCodecContext. Signed-off-by: Leo Izen --- libavcodec/pngenc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[FFmpeg-devel] [PATCH v2 1/2] avcodec/pngdec: support sBIT chunks

2023-03-08 Thread Leo Izen
Add support for reading sBIT chunks, which mark the significant bit depth of the PNG file. This passes the metadata using the field bits_per_raw_sample of AVCodecContext. Signed-off-by: Leo Izen --- libavcodec/pngdec.c | 45 libavcodec/version.h |

[FFmpeg-devel] [PATCH v2 0/2] PNG sBIT chunk support

2023-03-08 Thread Leo Izen
Add support to the PNG decoder and encoder to support sBIT chunks, by using AVCodecContext->bits_per_raw_sample. Leo Izen (2): avcodec/pngdec: support sBIT chunks avcodec/pngenc: write sBIT chunks libavcodec/pngdec.c | 45 libavcodec/pngenc.c |

Re: [FFmpeg-devel] PRIx64 and msvc

2023-03-08 Thread info
Le 2023-03-08 09:38, Hendrik Leppkes a écrit : On Wed, Mar 8, 2023 at 5:34 PM wrote: Le 2023-03-08 09:10, Hendrik Leppkes a écrit : > On Wed, Mar 8, 2023 at 4:02 PM wrote: >> >> I'm compiling with msvc and get some errors with PRIx64 and similars. >> For example: >> snprintf(name,

Re: [FFmpeg-devel] PRIx64 and msvc

2023-03-08 Thread Hendrik Leppkes
On Wed, Mar 8, 2023 at 5:34 PM wrote: > > Le 2023-03-08 09:10, Hendrik Leppkes a écrit : > > On Wed, Mar 8, 2023 at 4:02 PM wrote: > >> > >> I'm compiling with msvc and get some errors with PRIx64 and similars. > >> For example: > >> snprintf(name, sizeof(name), "0x%"PRIx64, ch_layout); > >> >

Re: [FFmpeg-devel] PRIx64 and msvc

2023-03-08 Thread info
Le 2023-03-08 09:10, Hendrik Leppkes a écrit : On Wed, Mar 8, 2023 at 4:02 PM wrote: I'm compiling with msvc and get some errors with PRIx64 and similars. For example: snprintf(name, sizeof(name), "0x%"PRIx64, ch_layout); won't compile, but this work (with the extra space): snprintf(name,

Re: [FFmpeg-devel] PRIx64 and msvc

2023-03-08 Thread Hendrik Leppkes
On Wed, Mar 8, 2023 at 4:02 PM wrote: > > I'm compiling with msvc and get some errors with PRIx64 and similars. > For example: > snprintf(name, sizeof(name), "0x%"PRIx64, ch_layout); > > won't compile, but this work (with the extra space): > snprintf(name, sizeof(name), "0x%" PRIx64, ch_layout);

[FFmpeg-devel] [PATCH] Fix issue when invalid nb_index_entries value is read - SPONSORED BY INA (Institut National de l'Audiovisuel)

2023-03-08 Thread Cédric Le Barz
Fix issue when invalid nb_index_entries value is read : in case of false nb_index_entries value, ffmpeg exit. This patch fix this problem. Signed-off-by: Cedric Le Barz --- ffmpeg/libavformat/mxfdec.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git

[FFmpeg-devel] PRIx64 and msvc

2023-03-08 Thread info
I'm compiling with msvc and get some errors with PRIx64 and similars. For example: snprintf(name, sizeof(name), "0x%"PRIx64, ch_layout); won't compile, but this work (with the extra space): snprintf(name, sizeof(name), "0x%" PRIx64, ch_layout); Can this be included in the sources without

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libdav1d: export Dynamic HDR10+ frame metadata

2023-03-08 Thread James Almer
On 3/3/2023 1:37 PM, James Almer wrote: As defined in https://aomediacodec.github.io/av1-hdr10plus/ Signed-off-by: James Almer --- A sample is available in https://github.com/AOMediaCodec/av1-hdr10plus/wiki libavcodec/libdav1d.c | 35 +++ 1 file changed, 31

[FFmpeg-devel] [PATCH] avfilter/stack_internal: add missing header includes

2023-03-08 Thread James Almer
Fixes make checkheaders Signed-off-by: James Almer --- Untested. libavfilter/Makefile | 2 +- libavfilter/stack_internal.h | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/libavfilter/Makefile b/libavfilter/Makefile index b3d3d981dd..fc75d705e0 100644 ---