Re: [FFmpeg-devel] [PATCH] avcodec: add VMX1 decoder

2023-06-08 Thread Jean-Baptiste Kempf
On Thu, 8 Jun 2023, at 19:39, Paul B Mahol wrote: > Attached. Missing version bumping? -- Jean-Baptiste Kempf - President +33 672 704 734 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: fix CODECS attribute of H.264

2023-06-08 Thread Lance Wang
On Thu, Jun 8, 2023 at 10:47 AM Zhao Zhili wrote: > From: Zhao Zhili > > 1. Add avcc extradata support. > 2. Add non-standard annexb support with 0 0 1 as prefix for SPS. > > LGTM > Signed-off-by: Zhao Zhili > --- > v2: Describe what the patch does. > > libavformat/hlsenc.c | 14

Re: [FFmpeg-devel] [PATCH] avformat/mov: Don't allocate unnecessarily large blocks of memory

2023-06-08 Thread zhilizhao(赵志立)
> On Jun 9, 2023, at 07:51, Hendi wrote: > > mov_try_read_block is regularly called with sizes such as 48 bytes, > but would allocate 1 MiB each time, hogging more and more memory > until playback ends. > > Fixes #7641 and #9243. It’s a quick fix, but I’m afraid the two tickets are caused by

Re: [FFmpeg-devel] [PATCH 4/5] avformat/jpegxl_probe: inline various ret < 0 checks

2023-06-08 Thread James Almer
On 6/8/2023 11:32 PM, Anton Khirnov wrote: Quoting Leo Izen (2023-06-08 16:26:36) Inlines some ret < 0 checks to look like: if ((ret = func()) < 0) return ret; which clarifies code slightly. FWIW I find this variant less readable. But it's your code, so up to you. Agree. It's

Re: [FFmpeg-devel] [PATCH 4/5] avformat/jpegxl_probe: inline various ret < 0 checks

2023-06-08 Thread Anton Khirnov
Quoting Leo Izen (2023-06-08 16:26:36) > Inlines some ret < 0 checks to look like: > if ((ret = func()) < 0) > return ret; > > which clarifies code slightly. FWIW I find this variant less readable. But it's your code, so up to you. -- Anton Khirnov

Re: [FFmpeg-devel] [PATCH 5/5] avformat/jpegxl_anim_dec: avoid overrun with jxlp boxes in container

2023-06-08 Thread Anton Khirnov
Quoting Leo Izen (2023-06-08 16:26:37) > This should avoid overrunning buffers with jxlp boxes if the size is > zero or if the size is so small the box is invalid. > > Signed-off-by: Leo Izen > --- > libavformat/jpegxl_anim_dec.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) >

[FFmpeg-devel] [PATCH Resubmission] avformat/mov: Don't allocate unnecessarily large blocks of memory

2023-06-08 Thread Hendi
Attached this time, Thunderbird trashed the first one.From 46cef86a0ffd5f9e0bbf74c99e4ee32120823cb1 Mon Sep 17 00:00:00 2001 From: Hendi Date: Fri, 9 Jun 2023 01:13:25 +0200 Subject: [PATCH] avformat/mov: Don't allocate unnecessarily large blocks of memory mov_try_read_block is regularly

[FFmpeg-devel] [PATCH] avformat/mov: Don't allocate unnecessarily large blocks of memory

2023-06-08 Thread Hendi
mov_try_read_block is regularly called with sizes such as 48 bytes, but would allocate 1 MiB each time, hogging more and more memory until playback ends. Fixes #7641 and #9243. Signed-off-by: Hendi --- libavformat/mov.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mov.c

[FFmpeg-devel] [PATCH] avcodec: add VMX1 decoder

2023-06-08 Thread Paul B Mahol
Attached. From 2e0bbbc73afeac43e8cb7e2d5c78647725c764ba Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sun, 4 Jun 2023 20:30:59 +0200 Subject: [PATCH] avcodec: add VMX1 decoder Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 +

[FFmpeg-devel] [PATCH 3/3] avcodec/mpegvideo_dec: Add NULL pointer checks to MPV_motion_lowres()

2023-06-08 Thread Michael Niedermayer
This makes the null pointer checks match mpv_motion_internal() Fixes: NULL pointer dereference Fixes: 59671/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG1VIDEO_fuzzer-4993004566609920 Fixes: 59678/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEGVIDEO_fuzzer-4893168991338496

[FFmpeg-devel] [PATCH 2/3] avcodec/mpegvideo_dec: consider interlaced lowres 4:2:0 chroma in edge emulation check better

2023-06-08 Thread Michael Niedermayer
Fixes: out of array read Fixes: 59673/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG1VIDEO_fuzzer-5194311374077952 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mpegvideo_dec.c | 4

[FFmpeg-devel] [PATCH 1/3] avcodec/rka: use unsigned for buf0 additions

2023-06-08 Thread Michael Niedermayer
Fixes: signed integer overflow: -38912000 + -2109276160 cannot be represented in type 'int' Fixes: 59670/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RKA_fuzzer-4987563245699072 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 5/5] avformat/jpegxl_anim_dec: avoid overrun with jxlp boxes in container

2023-06-08 Thread Leo Izen
This should avoid overrunning buffers with jxlp boxes if the size is zero or if the size is so small the box is invalid. Signed-off-by: Leo Izen --- libavformat/jpegxl_anim_dec.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavformat/jpegxl_anim_dec.c

[FFmpeg-devel] [PATCH 4/5] avformat/jpegxl_probe: inline various ret < 0 checks

2023-06-08 Thread Leo Izen
Inlines some ret < 0 checks to look like: if ((ret = func()) < 0) return ret; which clarifies code slightly. Signed-off-by: Leo Izen --- libavformat/jpegxl_probe.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libavformat/jpegxl_probe.c

[FFmpeg-devel] [PATCH 3/5] avformat/jpegxl_probe: Forward error codes

2023-06-08 Thread Leo Izen
From: Michael Niedermayer Signed-off-by: Michael Niedermayer --- libavformat/jpegxl_probe.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavformat/jpegxl_probe.c b/libavformat/jpegxl_probe.c index e15e9eee49..88492cb772 100644 ---

[FFmpeg-devel] [PATCH 2/5] avformat/jpegxl_probe: check length instead of blindly reading

2023-06-08 Thread Leo Izen
From: Michael Niedermayer Enable the checked bitreader to avoid overread. Also add a few checks in loops and between blocks so we exit instead of continued execution. Alternatively we could add manual checks so that no overread can happen. This would be slightly faster but a bit more work and

[FFmpeg-devel] [PATCH 1/5] avformat/jpegxl_probe: Remove intermediate macro obfuscation around get_bits*()

2023-06-08 Thread Leo Izen
From: Michael Niedermayer Signed-off-by: Michael Niedermayer --- libavformat/jpegxl_probe.c | 169 +++-- 1 file changed, 85 insertions(+), 84 deletions(-) diff --git a/libavformat/jpegxl_probe.c b/libavformat/jpegxl_probe.c index a3845b037d..1d9c014f19 100644

[FFmpeg-devel] [PATCH 0/5] JPEG XL Animation Changes

2023-06-08 Thread Leo Izen
Three patches from michalni copied exactly as is from the ML just placed here for clarity. The two authored by me, the probe change is cosmetic, and the animation dec change fixes the issue referenced a cvslog email: <20230608002033.GF870501@pb2> Leo Izen (2): avformat/jpegxl_probe: inline

[FFmpeg-devel] [PATCH v1 4/4] avcodec/webp: make init_canvas_frame static

2023-06-08 Thread Thilo Borgmann
--- libavcodec/webp.c | 143 +++--- 1 file changed, 71 insertions(+), 72 deletions(-) diff --git a/libavcodec/webp.c b/libavcodec/webp.c index bee43fcf19..d3e3f85dd3 100644 --- a/libavcodec/webp.c +++ b/libavcodec/webp.c @@ -1337,7 +1337,77 @@ static int

[FFmpeg-devel] [PATCH v1 3/4] libavcodec/webp: add support for animated WebP decoding

2023-06-08 Thread Thilo Borgmann
From: Josef Zlomek Fixes: 4907 Adds support for decoding of animated WebP. The WebP decoder adds the animation related features according to the specs: https://developers.google.com/speed/webp/docs/riff_container#animation The frames of the animation may be smaller than the image canvas.

[FFmpeg-devel] [PATCH v1 2/4] avcodec/webp_parser: parse each frame into one packet

2023-06-08 Thread Thilo Borgmann
--- libavcodec/webp_parser.c | 132 ++- 1 file changed, 90 insertions(+), 42 deletions(-) diff --git a/libavcodec/webp_parser.c b/libavcodec/webp_parser.c index bd5f94dac5..d10d06bd0e 100644 --- a/libavcodec/webp_parser.c +++ b/libavcodec/webp_parser.c @@

[FFmpeg-devel] [PATCH v1 1/4] avcodec/webp: move definitions into header

2023-06-08 Thread Thilo Borgmann
--- libavcodec/webp.c | 17 +-- libavcodec/webp.h | 55 +++ 2 files changed, 56 insertions(+), 16 deletions(-) create mode 100644 libavcodec/webp.h diff --git a/libavcodec/webp.c b/libavcodec/webp.c index d35cb66f8d..15152ec8fb 100644 ---

[FFmpeg-devel] [PATCH v1 0/4] webp: add support for animated WebP decoding

2023-06-08 Thread Thilo Borgmann
Follow-up to [1], the decoder only. In [1] we found a hanging sample. In frame-threading, this led to an infinite wait, damaged frames otherwise. So warn acordingly and do best-effort in single-thread mode. Also split into more patches to make reviewing easier. [1]

Re: [FFmpeg-devel] [PATCH 1/2] lavc/riffenc: Fix msrle support on Windows 95

2023-06-08 Thread Tomas Härdin
tor 2023-06-08 klockan 13:27 +0200 skrev Paul B Mahol: > But does this break it on other platforms? That is a good question. What other RIFF decoders are there for which MSRLE support is important and depends on behavior different from VfW? mpv and vlc work just fine. /Tomas

Re: [FFmpeg-devel] [PATCH] avformat/hls: Forward stream metadata from subdemuxer

2023-06-08 Thread Armin Hasitzka
Hi all, just checking; do you consider this for merge into the upstream? It does feel like a lot of upside without any downside. Thanks Armin On Tue, 23 May 2023 at 11:26, Armin Hasitzka wrote: > We found this when we were looking for language information that the > mpegts demuxer knew about,

Re: [FFmpeg-devel] [PATCH 1/2] lavc/riffenc: Fix msrle support on Windows 95

2023-06-08 Thread Paul B Mahol
But does this break it on other platforms? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/2] lavc/msrleenc: Add msrle encoder

2023-06-08 Thread Tomas Härdin
Please check that I got the palette handling correct. Else this producing output of similar size to the VfW encoder. /Tomas From ab9bb1aca7ddda8f4788b0a63460470fce021e72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Thu, 8 Jun 2023 11:57:53 +0200 Subject: [PATCH 2/2]

[FFmpeg-devel] [PATCH 1/2] lavc/riffenc: Fix msrle support on Windows 95

2023-06-08 Thread Tomas Härdin
This is important for the GoldSrc community among others. /Tomas From c5c2d535b3e5dc94b063e13359e475e9ce18e1b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Thu, 8 Jun 2023 11:55:28 +0200 Subject: [PATCH 1/2] lavc/riffenc: Fix msrle support on Windows 95 ---

Re: [FFmpeg-devel] [PATCH v5 5/5] lavfi/format: add a hwmap auto conversion filter

2023-06-08 Thread Wu, Tong1
>On 25 Apr 2023, at 9:26, Tong Wu wrote: > >> When two formats lists cannot be merged, a scale filter is >> auto-inserted. However, when it comes to hardware map, we have to >> manually add a hwmap filter to do the conversion. This patch introduces >> an auto hwmap filter to do the hwmap

Re: [FFmpeg-devel] [PATCH] lavc/qsvdec: respect AVCodecContext->{width, height}

2023-06-08 Thread zhilizhao(赵志立)
> On Jun 8, 2023, at 13:47, Xiang, Haihao > wrote: > > From: Haihao Xiang > > width and height may be known from the container > > Signed-off-by: Haihao Xiang > --- > libavcodec/qsvdec.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavcodec/qsvdec.c

[FFmpeg-devel] vulkan build fix

2023-06-08 Thread Wang Bin
2023-06-08T02:04:18.3926210Z CC libavcodec/vulkan_decode.o 2023-06-08T02:04:18.5384903Z src/libavcodec/vulkan_decode.c:148:26: error: incompatible pointer to integer conversion assigning to 'VkImageView' (aka 'unsigned long long') from 'void *' [-Wint-conversion] 2023-06-08T02:04:18.5388615Z