Re: [FFmpeg-devel] [PATCH] avformat/avcodec: Add DTS-UHD demuxer and parser, movenc support.

2023-06-13 Thread Paul B Mahol
On Wed, Jun 14, 2023 at 2:00 AM Roy Funderburk wrote: > > On 6/13/23 11:35 AM, Paul B Mahol wrote: > > Doing allocation in probe? > > Probing should be very fast. > > In line 143 of the avformat patch, memory allocation is removed from the > probe > > >>+int dtsuhd_frame(DTSUHD *h, const uint8_t

Re: [FFmpeg-devel] [PATCH v1 3/3] lavfi/{denoise, procamp, scale, sharpness}_vaapi: Add passthrough mode

2023-06-13 Thread Wang, Fei W
On Tue, 2023-06-13 at 16:17 +, Eoff, Ullysses A wrote: > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Fei Wang > > Sent: Monday, May 29, 2023 8:30 PM > > To: ffmpeg-devel@ffmpeg.org > > Subject: [FFmpeg-devel] [PATCH v1 3/3] lavfi/{denoise, procamp, > > scale,

Re: [FFmpeg-devel] [PATCH v1 3/3] lavfi/{denoise, procamp, scale, sharpness}_vaapi: Add passthrough mode

2023-06-13 Thread Wang, Fei W
On Mon, 2023-06-12 at 07:25 +, Xiang, Haihao wrote: > On Di, 2023-05-30 at 08:29 +0800, Fei Wang wrote: > > Signed-off-by: Fei Wang > > --- > > libavfilter/vaapi_vpp.c| 15 --- > > libavfilter/vaapi_vpp.h| 2 ++ > > libavfilter/vf_misc_vaapi.c| 9 + >

Re: [FFmpeg-devel] [PATCH v1 4/4] avcodec/webp: make init_canvas_frame static

2023-06-13 Thread James Zern
On Thu, Jun 8, 2023 at 7:21 AM Thilo Borgmann wrote: > > --- > libavcodec/webp.c | 143 +++--- > 1 file changed, 71 insertions(+), 72 deletions(-) > lgtm. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v1 3/4] libavcodec/webp: add support for animated WebP decoding

2023-06-13 Thread James Zern
On Thu, Jun 8, 2023 at 7:21 AM Thilo Borgmann wrote: > > From: Josef Zlomek > > Fixes: 4907 > > Adds support for decoding of animated WebP. > > The WebP decoder adds the animation related features according to the specs: > https://developers.google.com/speed/webp/docs/riff_container#animation >

Re: [FFmpeg-devel] [PATCH v1 0/4] webp: add support for animated WebP decoding

2023-06-13 Thread James Zern
On Thu, Jun 8, 2023 at 7:20 AM Thilo Borgmann wrote: > > Follow-up to [1], the decoder only. > > In [1] we found a hanging sample. In frame-threading, this led to an > infinite wait, damaged frames otherwise. So warn acordingly and do > best-effort in single-thread mode. > > Also split into more

Re: [FFmpeg-devel] [PATCH v1 1/4] avcodec/webp: move definitions into header

2023-06-13 Thread James Zern
On Thu, Jun 8, 2023 at 7:20 AM Thilo Borgmann wrote: > > --- > libavcodec/webp.c | 17 +-- > libavcodec/webp.h | 55 +++ > 2 files changed, 56 insertions(+), 16 deletions(-) > create mode 100644 libavcodec/webp.h > lgtm.

Re: [FFmpeg-devel] [PATCH v24 6/9] avformat/mov_muxer: Extended MOV muxer to handle EVC video content

2023-06-13 Thread James Almer
On 6/13/2023 9:23 PM, Michael Niedermayer wrote: On Mon, Jun 12, 2023 at 02:30:27PM +0200, Dawid Kozinski wrote: - Changes in mov_write_video_tag function to handle EVC elementary stream - Provided structure EVCDecoderConfigurationRecord that specifies the decoder configuration information for

Re: [FFmpeg-devel] [PATCH v24 6/9] avformat/mov_muxer: Extended MOV muxer to handle EVC video content

2023-06-13 Thread Michael Niedermayer
On Mon, Jun 12, 2023 at 02:30:27PM +0200, Dawid Kozinski wrote: > - Changes in mov_write_video_tag function to handle EVC elementary stream > - Provided structure EVCDecoderConfigurationRecord that specifies the decoder > configuration information for ISO/IEC 23094-1 video content > >

Re: [FFmpeg-devel] [PATCH] avformat/avcodec: Add DTS-UHD demuxer and parser, movenc support.

2023-06-13 Thread Roy Funderburk
On 6/13/23 11:35 AM, Paul B Mahol wrote: > Doing allocation in probe? > Probing should be very fast. In line 143 of the avformat patch, memory allocation is removed from the probe >>+int dtsuhd_frame(DTSUHD *h, const uint8_t *data, size_t data_bytes, >>+DTSUHDFrameInfo *fi,

[FFmpeg-devel] [PATCH] avcodec: add RFBW video decoder

2023-06-13 Thread Paul B Mahol
Attached. From 1ecc4dc72119de4b0fb23c85eba35341b4329dea Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Fri, 9 Jun 2023 23:57:01 +0200 Subject: [PATCH] avcodec: add RFBW decoder Signed-off-by: Paul B Mahol --- configure | 1 + libavcodec/Makefile | 1 +

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/avcodec: Add DTS-UHD demuxer and parser, movenc support.

2023-06-13 Thread Anton Khirnov
Quoting Roy Funderburk (2023-06-13 19:43:25) > > > On 6/13/23 7:26 AM, Paul B Mahol wrote: > > Why we need new av_* calls, can you elaborate logic behind such approach to > > implement parser? > > > There is common code for dtsuhd audio frame parsing (dtsuhd_common.c) used by > the libavcodec

Re: [FFmpeg-devel] [PATCH] avformat/avcodec: Add DTS-UHD demuxer and parser, movenc support.

2023-06-13 Thread Paul B Mahol
On Fri, Apr 14, 2023 at 6:01 PM Roy Funderburk wrote: > Parsing and demuxing of DTS-UHD input files per ETSI TS 102 114 is added > as demuxer "dtsuhd". movenc supports DTS-UHD audio track. > > Signed-off-by: Roy Funderburk > --- > Changelog | 1 + > configure

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/avcodec: Add DTS-UHD demuxer and parser, movenc support.

2023-06-13 Thread Paul B Mahol
On Mon, Apr 17, 2023 at 6:14 AM Roy Funderburk wrote: > Demuxing of DTS-UHD input files per ETSI TS 102 114 is added as > demuxer "dtsuhd". movenc supports DTS-UHD audio track. > > Signed-off-by: Roy Funderburk > --- > Changelog | 1 + > configure | 1 + >

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/avcodec: Add DTS-UHD demuxer and parser, movenc support.

2023-06-13 Thread Roy Funderburk
On 6/13/23 11:09 AM, Paul B Mahol wrote: > Parser just splits bitstream into packets and packets are then passed to > decoders. Demuxer in such case pass fixed packet sizes to parser minus > optional header/trailer bytes. > There should be no reason for such complexity in parser and/or demuxer

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/avcodec: Add DTS-UHD demuxer and parser, movenc support.

2023-06-13 Thread Paul B Mahol
On Tue, Jun 13, 2023 at 7:43 PM Roy Funderburk wrote: > > > On 6/13/23 7:26 AM, Paul B Mahol wrote: > > Why we need new av_* calls, can you elaborate logic behind such approach > to > > implement parser? > > > There is common code for dtsuhd audio frame parsing (dtsuhd_common.c) used > by the

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/avcodec: Add DTS-UHD demuxer and parser, movenc support.

2023-06-13 Thread Roy Funderburk
On 6/13/23 7:26 AM, Paul B Mahol wrote: > Why we need new av_* calls, can you elaborate logic behind such approach to > implement parser? There is common code for dtsuhd audio frame parsing (dtsuhd_common.c) used by the libavcodec and libavformat DTS-UHD modules. It is complex enough that we

Re: [FFmpeg-devel] [RFC] [PATCH 1/5] hwcontext: add a new AVHWFramesContext.opaque field

2023-06-13 Thread Lynne
Jun 13, 2023, 18:56 by andreas.rheinha...@outlook.com: > Lynne: > >> +dst->opaque= av_buffer_ref(src->opaque); >> +if (!dst->opaque) { >> +ret = AVERROR(ENOMEM); >> +goto fail; >> +} >> > > According to the doxy, opaque can be left unset (and will be given that >

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/hevc_parse: check the size of hvcC is at least 23

2023-06-13 Thread Zhao Zhili
> -Original Message- > From: ffmpeg-devel On Behalf Of Lance Wang > Sent: 2023年6月13日 22:10 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 2/4] avcodec/hevc_parse: check the size of > hvcC is at least 23 > > On Tue, Jun 13, 2023 at 3:37 PM Zhao

Re: [FFmpeg-devel] [RFC] [PATCH 1/5] hwcontext: add a new AVHWFramesContext.opaque field

2023-06-13 Thread Andreas Rheinhardt
Lynne: > +dst->opaque= av_buffer_ref(src->opaque); > +if (!dst->opaque) { > +ret = AVERROR(ENOMEM); > +goto fail; > +} According to the doxy, opaque can be left unset (and will be given that it is a new field), yet av_buffer_ref(NULL) will crash. We have

Re: [FFmpeg-devel] [PATCH v1 3/3] lavfi/{denoise, procamp, scale, sharpness}_vaapi: Add passthrough mode

2023-06-13 Thread Eoff, Ullysses A
> -Original Message- > From: ffmpeg-devel On Behalf Of Fei Wang > Sent: Monday, May 29, 2023 8:30 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v1 3/3] lavfi/{denoise, procamp, scale, > sharpness}_vaapi: Add passthrough mode > @@ -188,11 +194,14 @@ static av_cold int

[FFmpeg-devel] [RFC] [PATCH] avfilter/avfilter: add flag to signal filters that support w/h change

2023-06-13 Thread Paul B Mahol
Attached. From 440616b9400d6d6a4705b6feedcd5439cd9e54c2 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Tue, 13 Jun 2023 16:39:12 +0200 Subject: [PATCH] avfilter/avfilter: add flag to signal filters that support w/h change Signed-off-by: Paul B Mahol --- libavfilter/avfilter.h | 6 ++ 1

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_enc: Prevent duplicate A53 Closed Captions at frame rate up-conversion

2023-06-13 Thread Gyan Doshi
On 2023-06-13 07:46 pm, Devin Heitmueller wrote: On Sat, Jun 10, 2023 at 11:55 PM Anton Khirnov wrote: I don't think there's a fundamental reason -r handling could not be moved to lavfi, but it's a nontrivial task. E.g. the dup/drop counts are integrated with the CLI and would have to be

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/avcodec: Add DTS-UHD demuxer and parser, movenc support.

2023-06-13 Thread Paul B Mahol
On Mon, May 15, 2023 at 11:15 PM Roy Funderburk wrote: > On 5/15/23 1:35 PM, Michael Niedermayer wrote: > > Seems iam unable to download this. google complains about some 3rd party > cookies > > being disabled when i try to download. This seems new > > > Hi, > > Since google drive is not working

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_enc: Prevent duplicate A53 Closed Captions at frame rate up-conversion

2023-06-13 Thread Devin Heitmueller
On Sat, Jun 10, 2023 at 11:55 PM Anton Khirnov wrote: > I don't think there's a fundamental reason -r handling could not be > moved to lavfi, but it's a nontrivial task. E.g. the dup/drop counts are > integrated with the CLI and would have to be exported from lavfi somehow > if you wanted to keep

Re: [FFmpeg-devel] [External Sender] Re: [PATCH] fftools/ffmpeg_enc: Prevent duplicate A53 Closed Captions at frame rate up-conversion

2023-06-13 Thread Devin Heitmueller
On Fri, Jun 9, 2023 at 12:33 PM Artem Smorodin wrote: > The behavior that adds this patch was there before, but was removed after > about 5.1.1, so I think it's safe to restore it until a better solution is > implemented. I have to admit that I'm hesitant about introducing a patch that only

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/hevc_parse: check the size of hvcC is at least 23

2023-06-13 Thread Lance Wang
On Tue, Jun 13, 2023 at 3:37 PM Zhao Zhili wrote: > From: Zhao Zhili > > The code after the check skip 21 bytes and then read two bytes. > > Signed-off-by: Zhao Zhili > --- > libavcodec/hevc_parse.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 2/5] vulkan_decode: use the new AVHWFramesContext.opaque field

2023-06-13 Thread Lynne
Jun 13, 2023, 14:29 by an...@khirnov.net: > Quoting Lynne (2023-06-13 06:19:34) > >> This depends on the previous patch, and allows moving the codec >> profile to the new AVHWFramesContext.opaque field. >> >> Patch attached. >> >> >> From f992905250062711fab7522906a573ff8ab5f716 Mon Sep 17

Re: [FFmpeg-devel] [PATCH 2/5] vulkan_decode: use the new AVHWFramesContext.opaque field

2023-06-13 Thread Anton Khirnov
Quoting Lynne (2023-06-13 06:19:34) > This depends on the previous patch, and allows moving the codec > profile to the new AVHWFramesContext.opaque field. > > Patch attached. > > > From f992905250062711fab7522906a573ff8ab5f716 Mon Sep 17 00:00:00 2001 > From: Lynne > Date: Tue, 13 Jun 2023

[FFmpeg-devel] Cannot decode aac_latm audio file

2023-06-13 Thread Deepak Jain
Hello everyone, I have a capture stream that contains below audio and video streams. video: h264(high) audio: aac_latm(HE-AACv2) ([17][0][0][0] / 0x0011), 48000 Hz, stereo, fltp We are using Ffmpeg to decode this stream. Video can be decoded easily, but audio is giving error. Below error is

[FFmpeg-devel] [PATCH 3/4] avformat/asfdec_f: support bmp_tags_unofficial

2023-06-13 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavformat/asfdec_f.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c index bdbd4271c8..1e3eb33fd6 100644 --- a/libavformat/asfdec_f.c +++ b/libavformat/asfdec_f.c @@ -445,6 +445,8 @@ static

[FFmpeg-devel] [PATCH 4/4] avformat/asfdec_f: fix need_parsing flag for codec mpeg4

2023-06-13 Thread Zhao Zhili
From: Zhao Zhili AVSTREAM_PARSE_FULL_ONCE is only implemented for H.264. Signed-off-by: Zhao Zhili --- libavformat/asfdec_f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c index 1e3eb33fd6..5405956467 100644 ---

[FFmpeg-devel] [PATCH 1/4] avcodec/hevc_parse: restrict configurationVersion to 0 and 1

2023-06-13 Thread Zhao Zhili
From: Zhao Zhili The standard only defined configurationVersion 1. configurationVersion 0 is for backward compatibility predates the standard. This patch reduces the chance that some malformated streams being detected as hvcC. Signed-off-by: Zhao Zhili --- libavcodec/hevc_parse.c | 10

[FFmpeg-devel] [PATCH 2/4] avcodec/hevc_parse: check the size of hvcC is at least 23

2023-06-13 Thread Zhao Zhili
From: Zhao Zhili The code after the check skip 21 bytes and then read two bytes. Signed-off-by: Zhao Zhili --- libavcodec/hevc_parse.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/hevc_parse.c b/libavcodec/hevc_parse.c index 1f3beed183..7bc28fd081 100644