Re: [FFmpeg-devel] [PATCH] avcodec/internal: Move AVCodecInternal to a header of its own

2023-07-10 Thread James Almer
On 7/10/2023 10:26 PM, Andreas Rheinhardt wrote: James Almer: On 7/10/2023 10:10 PM, Andreas Rheinhardt wrote: This allows to avoid exposing AVCodecInternal to files that don't need it and only include internal.h for something else (like the avpriv functions which are of course included

Re: [FFmpeg-devel] [PATCH] avcodec/internal: Move AVCodecInternal to a header of its own

2023-07-10 Thread Andreas Rheinhardt
James Almer: > On 7/10/2023 10:10 PM, Andreas Rheinhardt wrote: >> This allows to avoid exposing AVCodecInternal to files that >> don't need it and only include internal.h for something else >> (like the avpriv functions which are of course included outside >> of libavcodec where AVCodecInternal

Re: [FFmpeg-devel] [PATCH] avcodec/internal: Move AVCodecInternal to a header of its own

2023-07-10 Thread James Almer
On 7/10/2023 10:10 PM, Andreas Rheinhardt wrote: This allows to avoid exposing AVCodecInternal to files that don't need it and only include internal.h for something else (like the avpriv functions which are of course included outside of libavcodec where AVCodecInternal should never be visible).

[FFmpeg-devel] [PATCH] avcodec/internal: Move AVCodecInternal to a header of its own

2023-07-10 Thread Andreas Rheinhardt
This allows to avoid exposing AVCodecInternal to files that don't need it and only include internal.h for something else (like the avpriv functions which are of course included outside of libavcodec where AVCodecInternal should never be visible). Signed-off-by: Andreas Rheinhardt ---

[FFmpeg-devel] [PATCH v5 4/4] fate/jpegxl_anim: add demuxer fate test for jpegxl_anim

2023-07-10 Thread Leo Izen
Adds a fate test for the jpegxl_anim demuxer, that should allow testing for true positives and false positives for animated jpegxl files. Note that two of the test cases are not animated, in order to help sort out false positives. Signed-off-by: Leo Izen --- tests/Makefile

[FFmpeg-devel] [PATCH v5 2/4] avcodec/jpegxl_parser: add JPEG XL parser

2023-07-10 Thread Leo Izen
Add a parser to libavcodec for AV_CODEC_ID_JPEGXL. It doesn't find the end of the stream in order to packetize the codec, but it does look at the headers to set preliminary information like dimensions and pixel format. Note that much of this code is duplicated from avformat/jpegxl_probe.c, but

[FFmpeg-devel] [PATCH v5 3/4] avformat/jpegxl: remove jpegxl_probe, instead call avcodec/jpegxl_parse

2023-07-10 Thread Leo Izen
This prevents code duplication in the source form by calling the parse code that was moved to avcodec last commit. The code will be duplicated in binary form for shared builds (it's not that large), but for source code it will only exist in one location now. Signed-off-by: Leo Izen ---

[FFmpeg-devel] [PATCH v5 1/4] avcodec/libjxldec: use internal AVFrame as buffered space

2023-07-10 Thread Leo Izen
Before this commit, the decoder erroneously assumes that the AVFrame passed to the receive_frame is the same one each time. Now it keeps an internal AVFrame to write into, and copies it over when it's done. Signed-off-by: Leo Izen --- libavcodec/libjxldec.c | 36

[FFmpeg-devel] [PATCH v5 0/4] JPEG XL Parser

2023-07-10 Thread Leo Izen
Changes from v4: - Added an entropy decoder and full parser, which finds the boundaries between files correctly - Removed unnecessary logging in libjxldec Changes from v3: - Don't remove AV_CODEC_CAP_DR1 from libjxldec - jpegxl_parse.o added to STLIBOBJS in avcodec/Makefile - add pipe

[FFmpeg-devel] [PATCH 3/3] avcodec/decode: prevent discarding skip_samples side data if the decoder didn't generate a frame

2023-07-10 Thread James Almer
Accumulate it instead, to be applied once a frame is returned. This change also prevents decoder set values from being potentially overwritten by side data. Signed-off-by: James Almer --- libavcodec/decode.c | 18 ++ libavcodec/internal.h | 2 +- 2 files changed, 11

[FFmpeg-devel] [PATCH v3 2/3] avcodec/decode: fill missing frame fields for all decoders

2023-07-10 Thread James Almer
And not just those with the old decode() API. Signed-off-by: James Almer --- No changes since last version. libavcodec/decode.c | 65 - 1 file changed, 34 insertions(+), 31 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index

[FFmpeg-devel] [PATCH v3 1/3] avcodec/decode: move processing discard samples to its own function

2023-07-10 Thread James Almer
Signed-off-by: James Almer --- libavcodec/decode.c | 270 +++- 1 file changed, 140 insertions(+), 130 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index a47abeca06..c9da8f685c 100644 --- a/libavcodec/decode.c +++

Re: [FFmpeg-devel] [PATCH] avcodec/decode: Return EAGAIN instead of overwriting unused packet

2023-07-10 Thread Marton Balint
On Mon, 10 Jul 2023, Anton Khirnov wrote: Quoting Andreas Rheinhardt (2023-07-10 01:36:41) Should fix #10457, a regression caused by 69516ab3e917a6e91d26e38d04183c60fd71cbab. Signed-off-by: Andreas Rheinhardt --- I am not sure about this one. The problem is that avcodec_send_packet() and

Re: [FFmpeg-devel] [PATCH v2 13/14] vvcdec: add CTU thread logical

2023-07-10 Thread Rémi Denis-Courmont
Le sunnuntaina 9. heinäkuuta 2023, 0.41.35 EEST Michael Niedermayer a écrit : > On Fri, Jul 07, 2023 at 10:05:39PM +0800, Nuo Mi wrote: > > This is the main entry point for the CTU (Coding Tree Unit) decoder. > > The code will divide the CTU decoder into several stages. > > It will check the stage

Re: [FFmpeg-devel] [PATCH] avcodec/decode: Return EAGAIN instead of overwriting unused packet

2023-07-10 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2023-07-10 01:36:41) >> Should fix #10457, a regression caused by >> 69516ab3e917a6e91d26e38d04183c60fd71cbab. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> I am not sure about this one. The problem is that avcodec_send_packet() >> and

Re: [FFmpeg-devel] [PATCH] lavu: add AVVideoHint API

2023-07-10 Thread Carotti, Elias
On Mon, 2023-07-10 at 08:13 +, Carotti, Elias wrote: > > AVVideoHint is a bad name for something like this. > Could you borrow some wording from graphics and call it > AVVideoDamagedHint or maybe AVVideoChangedAreaHint or a combination > of both? > I'd prefer the former, damage is standard

Re: [FFmpeg-devel] [PATCH] avcodec/decode: Return EAGAIN instead of overwriting unused packet

2023-07-10 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2023-07-10 01:36:41) > Should fix #10457, a regression caused by > 69516ab3e917a6e91d26e38d04183c60fd71cbab. > > Signed-off-by: Andreas Rheinhardt > --- > I am not sure about this one. The problem is that avcodec_send_packet() > and avcodec_receive_frame() must not

Re: [FFmpeg-devel] [PATCH] lavu/random_seed: use getrandom() when available

2023-07-10 Thread James Almer
On 7/9/2023 7:06 AM, Anton Khirnov wrote: It is a better interface for /dev/u?random on Linux, which avoids the issues associated with opening files. --- configure | 2 ++ libavutil/random_seed.c | 16 2 files changed, 18 insertions(+) diff --git

[FFmpeg-devel] [PATCH] fftools/ffmpeg_mux: forward EOF from the sync queue

2023-07-10 Thread Anton Khirnov
EOF from sq_receive() means no packets will ever be output by the sync queue. Since the muxing sync queue is always used by all interleaved (i.e. non-attachment) streams, this means no further packets can make it to the muxer and we can terminate muxing now. --- fftools/ffmpeg_mux.c | 10

Re: [FFmpeg-devel] [PATCH] lavu: add AVVideoHint API

2023-07-10 Thread Carotti, Elias
-Original Message- From: ffmpeg-devel On Behalf Of Lynne Sent: Sunday, July 9, 2023 3:11 PM To: FFmpeg development discussions and patches Subject: RE: [EXTERNAL][FFmpeg-devel] [PATCH] lavu: add AVVideoHint API CAUTION: This email originated from outside of the organization. Do not

Re: [FFmpeg-devel] [PATCH] lavu: add AVVideoHint API

2023-07-10 Thread Carotti, Elias
-Original Message- From: ffmpeg-devel On Behalf Of Anton Khirnov Sent: Sunday, July 9, 2023 1:05 PM To: ffmpeg-devel@ffmpeg.org Subject: [EXTERNAL] [FFmpeg-devel] [PATCH] lavu: add AVVideoHint API CAUTION: This email originated from outside of the organization. Do not click links or

[FFmpeg-devel] [PATCH] avutil/error: uniformize errbuf size by macro

2023-07-10 Thread Li Kai
Signed-off-by: likai --- libavdevice/bktr.c| 2 +- libavdevice/jack.c| 2 +- libavformat/crypto.c | 2 +- libavformat/network.c | 6 +++--- libavutil/file.c | 2 +- tools/aviocat.c | 2 +- tools/ismindex.c | 4 ++-- tools/sidxindex.c | 2 +- 8 files changed, 11

Re: [FFmpeg-devel] [PATCH v2 03/14] vvcdec: add sps, pps, sh parser

2023-07-10 Thread Nuo Mi
On Sat, Jul 8, 2023 at 12:30 AM James Almer wrote: > On 7/7/2023 12:48 PM, Nuo Mi wrote: > > Hi James, > > thank you for the review. > > > > On Fri, Jul 7, 2023 at 10:28 PM James Almer wrote: > > > >> On 7/7/2023 11:05 AM, Nuo Mi wrote: > >>> --- > >>>libavcodec/vvc/Makefile |4 +- >

Re: [FFmpeg-devel] [PATCH v2 13/14] vvcdec: add CTU thread logical

2023-07-10 Thread Nuo Mi
On Sun, Jul 9, 2023 at 9:03 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Michael Niedermayer: > > On Fri, Jul 07, 2023 at 10:05:39PM +0800, Nuo Mi wrote: > >> This is the main entry point for the CTU (Coding Tree Unit) decoder. > >> The code will divide the CTU decoder into

Re: [FFmpeg-devel] [PATCH v2 01/14] vvcdec: add thread executor

2023-07-10 Thread Nuo Mi
On Sun, Jul 9, 2023 at 5:52 AM Michael Niedermayer wrote: > On Fri, Jul 07, 2023 at 10:05:27PM +0800, Nuo Mi wrote: > > The executor design pattern was inroduced by java > > < > https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/util/concurrent/Executor.html > > > > it also

[FFmpeg-devel] [PATCH v1 6/6] lavc/vaapi_encode: Add VAAPI AV1 encoder

2023-07-10 Thread Fei Wang
Signed-off-by: Fei Wang --- Changelog |1 + configure |3 + doc/encoders.texi | 13 + libavcodec/Makefile |1 + libavcodec/allcodecs.c|1 + libavcodec/vaapi_encode.c | 125 +++- libavcodec/vaapi_encode.h

[FFmpeg-devel] [PATCH v1 5/6] lavc/vaapi_encode: Separate reference frame into previous/future list

2023-07-10 Thread Fei Wang
To support more reference frames from different directions. Signed-off-by: Fei Wang --- libavcodec/vaapi_encode.c | 112 +--- libavcodec/vaapi_encode.h | 15 +++-- libavcodec/vaapi_encode_h264.c | 94 +--

[FFmpeg-devel] [PATCH v1 4/6] lavc/vaapi_encode: Extract set output pkt timestamp function

2023-07-10 Thread Fei Wang
Signed-off-by: Fei Wang --- libavcodec/vaapi_encode.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index 8c9f14df66..c8545cd8db 100644 --- a/libavcodec/vaapi_encode.c +++

[FFmpeg-devel] [PATCH v1 3/6] lavc/vaapi_encode: Init pic at the beginning of API

2023-07-10 Thread Fei Wang
Signed-off-by: Fei Wang --- libavcodec/vaapi_encode.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index bfca315a7a..8c9f14df66 100644 --- a/libavcodec/vaapi_encode.c +++ b/libavcodec/vaapi_encode.c @@ -1205,7

[FFmpeg-devel] [PATCH v1 2/6] lavc/av1: Add common code and unit test for level handling

2023-07-10 Thread Fei Wang
Signed-off-by: Fei Wang --- libavcodec/Makefile| 4 +- libavcodec/av1_profile_level.c | 91 libavcodec/av1_profile_level.h | 58 +++ libavcodec/tests/.gitignore| 1 + libavcodec/tests/av1_levels.c | 124 +

[FFmpeg-devel] [PATCH v1 1/6] avcodec/cbs_av1: Add tx mode enum values

2023-07-10 Thread Fei Wang
Signed-off-by: Fei Wang --- libavcodec/av1.h | 7 +++ libavcodec/cbs_av1_syntax_template.c | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/libavcodec/av1.h b/libavcodec/av1.h index 384f7cddc7..8704bc41c1 100644 --- a/libavcodec/av1.h +++

[FFmpeg-devel] vcodec_open2 error: Internal bug, should not have happened

2023-07-10 Thread ????????????
I am trying to implement the OpenMax IL Video Decoder on ffmpeg. But I meet some problems. When I use the codec with ffmpeg on Chrome by force, it raised a error of bug ffmpeg_video_decoder.cc(491)] avcodec_open2 error: Internal bug, should not have happened I 'm not familiar with the version

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-10 Thread Lynne
Jul 3, 2023, 00:46 by mich...@niedermayer.cc: > On Mon, Jul 03, 2023 at 12:03:10AM +0200, Lynne wrote: > >> Jul 2, 2023, 23:15 by mich...@niedermayer.cc: >> >> > On Sun, Jul 02, 2023 at 08:55:40PM +0200, Lynne wrote: >> > >> >> Jul 2, 2023, 13:01 by mich...@niedermayer.cc: >> >> >> >> > On Fri,