[FFmpeg-devel] [PATCH 2/2] lavc/videotoolboxenc: Get the encoder supported properties

2023-09-03 Thread Jun Zhao
Get the encoder supported properties list, it will be used for feature support checks. Signed-off-by: Jun Zhao --- libavcodec/videotoolboxenc.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index

[FFmpeg-devel] [PATCH 1/2] lavc/videotoolboxenc: Dump the encoder

2023-09-03 Thread Jun Zhao
Dump the encoder, it's will help debug some case Signed-off-by: Jun Zhao --- libavcodec/videotoolboxenc.c | 20 1 file changed, 20 insertions(+) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index bfc03787a0..5633640a30 100644 ---

Re: [FFmpeg-devel] [PATCH v2] avformat/vpcc: fix VP9 metadata in FLV and RTMP

2023-09-03 Thread James Almer
On 9/3/2023 1:45 PM, aler9 wrote: I looked again at your previous comment and you suggested to explicitly mention that this patch will affect FLV too, which i did in the title. I didn't see any request to change the code. Do you have any suggestion regarding the code? I see the change in the

Re: [FFmpeg-devel] [PATCH v2] avformat/vpcc: fix VP9 metadata in FLV and RTMP

2023-09-03 Thread aler9
I looked again at your previous comment and you suggested to explicitly mention that this patch will affect FLV too, which i did in the title. I didn't see any request to change the code. Do you have any suggestion regarding the code? Il giorno dom 3 set 2023 alle ore 18:17 James Almer ha

Re: [FFmpeg-devel] [PATCH] lsws/swscale.h: introduce sws_get_gaussian_vec

2023-09-03 Thread Michael Niedermayer
On Sun, Sep 03, 2023 at 02:25:07AM +0200, Stefano Sabatini wrote: > On date Saturday 2023-09-02 22:07:53 +0200, Michael Niedermayer wrote: > > On Fri, Sep 01, 2023 at 08:38:26PM +0200, Stefano Sabatini wrote: > > > On date Friday 2023-09-01 18:54:40 +0200, Michael Niedermayer wrote: > > > > On

Re: [FFmpeg-devel] [PATCH 4/6] doc/developer: add a code behaviour section to development policy

2023-09-03 Thread Michael Niedermayer
On Sun, Sep 03, 2023 at 11:29:32AM +0300, Rémi Denis-Courmont wrote: > Le lauantaina 2. syyskuuta 2023, 23.03.32 EEST Michael Niedermayer a écrit : > > > And yes, UB is a very well known accronym in this context. In my > > > experience, people who don't know the accronym don't know the concept > >

Re: [FFmpeg-devel] [PATCH v2] avformat/vpcc: fix VP9 metadata in FLV and RTMP

2023-09-03 Thread James Almer
On 9/3/2023 1:15 PM, aler9 wrote: sorry, to git add what? You say you integrated my comment, but the contents of the patch are exactly the same. Il giorno dom 3 set 2023 alle ore 18:02 James Almer ha scritto: On 9/3/2023 1:00 PM, Alessandro Ros wrote: I integrated James A. comment and

Re: [FFmpeg-devel] [PATCH v2] avformat/vpcc: fix VP9 metadata in FLV and RTMP

2023-09-03 Thread aler9
sorry, to git add what? Il giorno dom 3 set 2023 alle ore 18:02 James Almer ha scritto: > On 9/3/2023 1:00 PM, Alessandro Ros wrote: > > I integrated James A. comment and fixed patch format. > > I think you forgot to git add. > > > > > In order to send VP9 tracks with FLV or RTMP, the enhanced

Re: [FFmpeg-devel] Trac spam

2023-09-03 Thread Michael Niedermayer
On Sun, Sep 03, 2023 at 02:39:54PM +0200, Michael Koch wrote: > please remove the spammers from tickets 1920, 2104, 2776, 3720, 4748 and > 5154. removed what i found, not sure had the feeling someone else was also already deleting them thx [...] -- Michael GnuPG fingerprint:

[FFmpeg-devel] [PATCH v2] avformat/vpcc: fix VP9 metadata in FLV and RTMP

2023-09-03 Thread Alessandro Ros
I integrated James A. comment and fixed patch format. In order to send VP9 tracks with FLV or RTMP, the enhanced RTMP specification tells that VPCodecConfigurationRecord, a.k.a. vpcC ISO-BMFF box, must be inserted into a metadata message. However, the function responsible for generating vpcCs

Re: [FFmpeg-devel] [PATCH v2] avformat/vpcc: fix VP9 metadata in FLV and RTMP

2023-09-03 Thread James Almer
On 9/3/2023 1:00 PM, Alessandro Ros wrote: I integrated James A. comment and fixed patch format. I think you forgot to git add. In order to send VP9 tracks with FLV or RTMP, the enhanced RTMP specification tells that VPCodecConfigurationRecord, a.k.a. vpcC ISO-BMFF box, must be inserted

[FFmpeg-devel] [PATCH v2] avformat/vpcc: fix VP9 metadata in FLV and RTMP

2023-09-03 Thread Alessandro Ros
I integrated James A. comment and fixed patch format. In order to send VP9 tracks with FLV or RTMP, the enhanced RTMP specification tells that VPCodecConfigurationRecord, a.k.a. vpcC ISO-BMFF box, must be inserted into a metadata message. However, the function responsible for generating vpcCs

[FFmpeg-devel] [PATCH 11/11] avfilter/f_select: Also deprecate "pos" variable name

2023-09-03 Thread Andreas Rheinhardt
Forgotten in 27f8c9b27bce42a4a6a4c64e03fab769579c8683. Signed-off-by: Andreas Rheinhardt --- libavfilter/f_select.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/f_select.c b/libavfilter/f_select.c index 49fcdc31ff..64599f085a 100644 --- a/libavfilter/f_select.c +++

[FFmpeg-devel] [PATCH 10/11] avfilter/af_volume: Also deprecate position enum value

2023-09-03 Thread Andreas Rheinhardt
Forgotten in 27f8c9b27bce42a4a6a4c64e03fab769579c8683. Signed-off-by: Andreas Rheinhardt --- libavfilter/af_volume.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/af_volume.h b/libavfilter/af_volume.h index c97902969e..c3756ee969 100644 --- a/libavfilter/af_volume.h +++

[FFmpeg-devel] Trac spam

2023-09-03 Thread Michael Koch
please remove the spammers from tickets 1920, 2104, 2776, 3720, 4748 and 5154. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH 01/13] avfilter: Remove unnecessary emms_c for ff_scene_sad_get_fn

2023-09-03 Thread Andreas Rheinhardt
Andreas Rheinhardt: > ff_scene_sad_get_fn() does not return functions that use > MMX at all. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/f_select.c| 1 - > libavfilter/vf_framerate.c| 1 - > libavfilter/vf_freezedetect.c | 1 - > libavfilter/vf_minterpolate.c | 1 - >

Re: [FFmpeg-devel] [PATCH 8/8] all: Replace __FUNCTION__ by __func__

2023-09-03 Thread Andreas Rheinhardt
James Almer: > On 9/2/2023 8:12 PM, Andreas Rheinhardt wrote: >> Only the former is valid ISO C. > > Don't you mean "the latter"? > Yes. Thanks for noticing. >> >> Signed-off-by: Andreas Rheinhardt >> --- >>   libavdevice/opengl_enc.c | 2 +- >>   libavformat/apngdec.c    | 2 +- >>  

Re: [FFmpeg-devel] [PATCH 4/6] doc/developer: add a code behaviour section to development policy

2023-09-03 Thread Rémi Denis-Courmont
Le lauantaina 2. syyskuuta 2023, 23.03.32 EEST Michael Niedermayer a écrit : > > And yes, UB is a very well known accronym in this context. In my > > experience, people who don't know the accronym don't know the concept > > either, so spelling it out wouldn't even help. > > "Undefined behavior"

Re: [FFmpeg-devel] [PATCH 5/7] avutil: Move error.h from avutil.h to common.h

2023-09-03 Thread Paul B Mahol
Probably OK ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 9/9] avcodec/vp8data: Use <> for inclusion of stdint.h

2023-09-03 Thread Paul B Mahol
OK ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 6/7] avutil/mem: Don't include avutil.h

2023-09-03 Thread Paul B Mahol
probably ok ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 5/6] doc/examples/transcode: use av_buffersrc_add_frame()

2023-09-03 Thread Paul B Mahol
See no real gain in this. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 11/11] doc/examples/transcode: fix selection of sample format if not set in encoder

2023-09-03 Thread Paul B Mahol
Decoder formats may not relate to encoder formats, thus this one looks too hackish to me to accept. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH 4/6] doc/examples/transcode: improve reporting when the encoder is not found

2023-09-03 Thread Paul B Mahol
On Sat, Sep 2, 2023 at 1:15 AM Stefano Sabatini wrote: > Also return EINVAL in place of INVALIDDATA. > Better return also name, id number is meaningless to user. > --- > doc/examples/transcode.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 06/11] doc/examples/transcode: use av_buffersrc_add_frame()

2023-09-03 Thread Paul B Mahol
This simplify nothing at all. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 08/11] doc/examples/transcode: use more meaningful labels for filtergraph sinks and sources

2023-09-03 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 01/11] lavc/avcodec.h: fix typos in AVCodecContext.pkt_timebase description

2023-09-03 Thread Paul B Mahol
OK ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".