Sep 12, 2023, 23:25 by tfo...@gmail.com:
> On Tue, Sep 12, 2023 at 9:25 AM Lynne wrote:
>
>> Sep 12, 2023, 09:43 by andreas.rheinha...@outlook.com:
>>
>> > Lynne:
>> >
>> >> For some reason, this was never set, which meant all **raw** AAC in ADTS
>> >> streams, except faac, had extra samples at
For some reason, this was never set, which meant all **raw** AAC in ADTS
streams, except faac, had extra samples at the start.
Despite this being a standard MDCT-based codec with a frame size of 1024,
hence a delay of 1024 samples at the start, all major encoders, excluding
faac and FFmpeg, use
On 10/2/2023 7:23 PM, Michael Niedermayer wrote:
Hi
On Tue, Sep 05, 2023 at 09:25:45PM +, Paul B Mahol wrote:
ffmpeg | branch: master | Paul B Mahol | Tue Sep 5 23:14:58
2023 +0200| [d464a687c9dd03246795d62151809167e8381932] | committer: Paul B Mahol
avcodec/hcadec: support decoding
Leo Izen:
> On 10/2/23 16:40, Andreas Rheinhardt wrote:
>> Leo Izen:
>>> The spec caps the prefix alphabet size to 32768 (i.e. 1 << 15) so we
>>> need to check for that and reject alphabets that are too large.
>>
>> No, we don't "need to", we can. FFmpeg is not a validator tool.
>
> We need to
On 10/2/23 16:40, Andreas Rheinhardt wrote:
Leo Izen:
The spec caps the prefix alphabet size to 32768 (i.e. 1 << 15) so we
need to check for that and reject alphabets that are too large.
No, we don't "need to", we can. FFmpeg is not a validator tool.
We need to because we risk
Andreas Rheinhardt:
> Fixes segfaults with -debug +nomc -flags +gray (presuming
> a build with --enable-gray).
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/mpegvideo_dec.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/mpegvideo_dec.c
On Thu, 28 Sep 2023 17:10:39 +0200 Niklas Haas wrote:
> From: Niklas Haas
>
> Buggy ICCv4 profiles are unfortunately used in the wild, and it's quite
> easy to work around them by just forcing the white point to the correct
> value. Display a warning just in case.
>
> See-Also:
On Thu, 28 Sep 2023 23:08:48 +0200 Niklas Haas wrote:
> From: Niklas Haas
>
> This is mathematically equivalent to what we were doing before, but
> gives subtly different results due to rounding (rows first vs columns
> first). Doing it this way makes our film grain database generation match
>
Hi
On Tue, Sep 05, 2023 at 09:25:45PM +, Paul B Mahol wrote:
> ffmpeg | branch: master | Paul B Mahol | Tue Sep 5
> 23:14:58 2023 +0200| [d464a687c9dd03246795d62151809167e8381932] | committer:
> Paul B Mahol
>
> avcodec/hcadec: support decoding with extradata provided in first packet
I
Leo Izen:
> The spec caps the prefix alphabet size to 32768 (i.e. 1 << 15) so we
> need to check for that and reject alphabets that are too large.
No, we don't "need to", we can. FFmpeg is not a validator tool.
>
> Additionally, there's no need to allocate buffers that are as large as
> the
The spec caps the prefix alphabet size to 32768 (i.e. 1 << 15) so we
need to check for that and reject alphabets that are too large.
Additionally, there's no need to allocate buffers that are as large as
the maximum alphabet size as these aren't stack-allocated, they're heap
allocated and thus
On 10/2/2023 6:25 AM, Anton Khirnov wrote:
Quoting Tomas Härdin (2023-09-28 13:27:53)
Yes, a typed union like this should work nicely. This way we keep
things related to each type of stream group separate.
I agree that this seems like a better solution than repurposing
AVCodecParameters, but
On 27/09/2023 03:16, Wang, Fei W wrote:
On Tue, 2023-09-26 at 21:30 +0100, Mark Thompson wrote:
This is an option to modify the behaviour of the writer, not a syntax
field.
---
On 26/09/2023 03:34, Wang, Fei W wrote:
On Mon, 2023-09-25 at 14:53 +0100, Mark Thompson wrote:
...
diff --git
On 10/2/23, Michael Niedermayer wrote:
> Hi Paul
>
> On Mon, Oct 02, 2023 at 04:23:54PM +0200, Paul B Mahol wrote:
>> On 9/30/23, Paul B Mahol wrote:
>> > Attached.
>> >
>>
>> Gonna apply soon.
>
> Did you look at
> "avcodec/lcldec: Make PNG filter addressing match the code afterwards"
>
> You
On Mon, Oct 02, 2023 at 11:07:47AM +0200, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2023-10-01 00:28:56)
> > On Sat, Sep 30, 2023 at 10:18:38PM +0200, Anton Khirnov wrote:
> > > Quoting Michael Niedermayer (2023-09-30 16:31:43)
> > > > On Sat, Sep 30, 2023 at 04:04:03PM +0200, Michael
Hi Paul
On Mon, Oct 02, 2023 at 04:23:54PM +0200, Paul B Mahol wrote:
> On 9/30/23, Paul B Mahol wrote:
> > Attached.
> >
>
> Gonna apply soon.
Did you look at
"avcodec/lcldec: Make PNG filter addressing match the code afterwards"
You patch is simpler (which is good)
but it leaves some pixel
Avoids allocations and therefore error checks; also avoids
indirections and allows to remove the boilerplate code
for creating an object with a dedicated free function.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/v4l2_buffers.c | 7 +++
libavcodec/v4l2_buffers.h | 6 +++---
Avoids boilerplate code when creating the context
and avoids allocations and therefore whole error paths
when creating references to it. Also avoids an indirection
and improves type-safety.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/rkmppdec.c | 46
This frame will be freed in the next line.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/v4l2_m2m.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavcodec/v4l2_m2m.c b/libavcodec/v4l2_m2m.c
index 602efb7a16..bac3eb0588 100644
--- a/libavcodec/v4l2_m2m.c
+++ b/libavcodec/v4l2_m2m.c
@@
Avoids an allocation and therefore one error path.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/rkmppdec.c | 39 +++
1 file changed, 15 insertions(+), 24 deletions(-)
diff --git a/libavcodec/rkmppdec.c b/libavcodec/rkmppdec.c
index dd0b9c5a4d..5998b6edef
Signed-off-by: Andreas Rheinhardt
---
libavcodec/rkmppdec.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavcodec/rkmppdec.c b/libavcodec/rkmppdec.c
index 2ca368e0a9..4cca65d8fb 100644
--- a/libavcodec/rkmppdec.c
+++ b/libavcodec/rkmppdec.c
@@ -449,6 +449,10 @@ static int
After having created the AVBuffer that is put into frame->buf[0],
ownership of several objects (namely an AVDRMFrameDescriptor,
an MppFrame and some AVBufferRefs framecontextref and decoder_ref)
has passed to the AVBuffer and therefore to the frame.
Yet it has nevertheless been freed manually on
Avoids allocations and therefore error checks and cleanup code;
also avoids indirections.
Signed-off-by: Andreas Rheinhardt
---
Would be nice if someone could test these additional patches;
I only ensured that they compile properly.
Here is current branch (there will be merge conflicts with
> Hi,
> please find attached a patch to propagate the SSE for a frame into
> the
> encoder stats.
> Since libx264 already provides PSNR values, this is done by basically
> inverting the formula to recover the SSE values.
>
> Would it be possible to also append other values to the errors
> vector?
This patch makes the libkvazaar encoder respect color settings that are
present on the codec context, including color range, primaries, transfer
function and colorspace.
---
This addresses the issues raised in v2.
* The unspecified conditions have been removed as they were
unnecessary.
*
0cd8769207f utilized the rc_algorithm member of the kvz_config struct, which
was introduced in Kvazaar 2.0.0. This patch bumps the minimum version of
Kvazaar to 2.0.0 so that FFmpeg compiles successfully.
Signed-off-by: John Mather
---
configure | 2 +-
1 file changed, 1 insertion(+), 1
Paul B Mahol (12023-10-02):
> But that would break SDR seeking.
> And also break bunch of avdevice, and make Nicolas sad.
I would be very happy if devices were turned into lavfi sources and
sink. So if you're unable to make sarcasm that's actually relevant, next
time just shut up.
Anyway:
(1)
---
libavcodec/ac3dsp.c| 2 ++
libavcodec/ac3dsp.h| 1 +
libavcodec/riscv/Makefile | 2 ++
libavcodec/riscv/ac3dsp_init.c | 38 ++
libavcodec/riscv/ac3dsp_rvb.S | 38 ++
5 files changed, 81
On 10/2/23, Anton Khirnov wrote:
> Quoting Asahi Lina via ffmpeg-devel (2023-09-29 09:52:23)
>> V4L2 provides a line stride to the client for hardware that has
>> alignment requirements. rawvideo cannot represent this, so switch to
>> wrapped_avframe for raw video formats and calculate the plane
Signed-off-by: Michael Niedermayer
---
libavformat/flacdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/flacdec.c b/libavformat/flacdec.c
index 5104f231105..ab9ef052f9f 100644
--- a/libavformat/flacdec.c
+++ b/libavformat/flacdec.c
@@ -78,7 +78,7 @@ static
Signed-off-by: Michael Niedermayer
---
libavfilter/vf_vidstabdetect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/vf_vidstabdetect.c b/libavfilter/vf_vidstabdetect.c
index a2c6d895037..641040008a6 100644
--- a/libavfilter/vf_vidstabdetect.c
+++
Signed-off-by: Michael Niedermayer
---
libavcodec/vaapi_encode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c
index e3820956d16..6c3e41fb318 100644
--- a/libavcodec/vaapi_encode.c
+++ b/libavcodec/vaapi_encode.c
@@
---
libavcodec/nvenc.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c
index 65b96d6cf6..feda0ca4a5 100644
--- a/libavcodec/nvenc.c
+++ b/libavcodec/nvenc.c
@@ -94,7 +94,11 @@ const AVCodecHWConfigInternal *const
On 9/30/23, Paul B Mahol wrote:
> Attached.
>
Gonna apply soon.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with
Hi,
On Fri, Sep 29, 2023 at 4:32 AM Dawid Kozinski
wrote:
> Signed-off-by: Dawid Kozinski
> ---
> libavcodec/hevcpred_template.c | 11 ---
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/libavcodec/hevcpred_template.c
> b/libavcodec/hevcpred_template.c
> index
Sep 19, 2023, 21:58 by andreas.rheinha...@outlook.com:
> Avoids allocations, error checks and indirections.
> Also increases type-safety.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/vulkan_av1.c| 2 +-
> libavcodec/vulkan_decode.c | 49 --
>
Sep 19, 2023, 21:58 by andreas.rheinha...@outlook.com:
> Avoids allocations and therefore error checks: Syncing
> hwaccel_picture_private across threads can't fail any more.
> Also gets rid of an unnecessary pointer in structures and
> in the parameter list of ff_hwaccel_frame_priv_alloc().
>
>
On 10/2/2023 6:37 AM, Anton Khirnov wrote:
Quoting James Almer (2023-09-06 16:38:32)
Signed-off-by: James Almer
---
This is an initial proof of concept for AVStream groups, something that's
needed for quite a few existing and upcoming formats that lavf has no way to
currently export. Said
Michael Niedermayer (12023-10-01):
> Fixes: signed integer overflow: 9154241445400 - -915424149454600
> cannot be represented in type 'long'
> Fixes:
> 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_CONCAT_fuzzer-4739147999084544
>
> Found-by: continuous fuzzing process
>
On Thu, 28 Sep 2023, Martin Storsjö wrote:
When linking the main tools, the object files to link are set up
via the variable OBJS-, but for the tools, we've only
used the target's list of dependencies.
In most cases, this has been fine, but it has caused specifying
the libraries to link in a
Anton Khirnov:
> Quoting Andreas Rheinhardt (2023-09-19 21:57:06)
>> avcodec/hevcdec: Use RefStruct API for RefPicListTap buffer
> ^
> b
>
>> Given that the RefStruct API relies on the user to
Quoting Andreas Rheinhardt (2023-09-19 21:57:07)
> Avoids allocations and error checks and allows to remove
> cleanup code for earlier allocations. Also avoids casts
> and indirections.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> I actually intend to remove the ThreadFrame API in the not-so
>
Quoting Andreas Rheinhardt (2023-09-19 21:57:08)
> Avoids allocations and error checks as well as the boilerplate
> code for creating an AVBuffer with a custom free callback.
> Also increases type safety.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/nvdec.c | 50
Possible now that the IDCT is already initialized at this point.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/h263dec.c | 7 ---
libavcodec/mpeg4videodec.c | 9 +
libavcodec/mpegvideo.h | 1 -
3 files changed, 9 insertions(+), 8 deletions(-)
diff --git
It has currently not been done for H263, H263P and MPEG4.
Doing so avoids having to initialize the IDCT permutation
lateron when decoding packets in order to be able to parse
a quant matrix; it means that every mpegvideo decoder always
has an initialized IDCTDSPContext after init.
Initializing is
Up until now, ff_mpeg_update_thread_context() zeroes
the context to initialize on initialization failure.
This has been added in e1d7d4bd13cdd8856a3611d1ea387ac733a7aebf.
Just as now, ff_mpeg_update_thread_context() simply
copied the src MpegEncContext over the dst MpegEncContext
to initialize
Before 998c9f15d1ca8c7489775ebcca51623b915988f1, the IDCTDSPContext
has only been initialized in ff_mpv_common_init() which is deferred
until immediately before decoding a picture; to nevertheless parse
the quant matrices in sequence headers or quant matrix extensions,
a dummy (identity)
Quoting Andreas Rheinhardt (2023-09-19 21:57:06)
>avcodec/hevcdec: Use RefStruct API for RefPicListTap buffer
^
b
> Given that the RefStruct API relies on the user to know
> the size of the
Quoting Andreas Rheinhardt (2023-09-19 21:57:04)
> diff --git a/libavcodec/h264dec.h b/libavcodec/h264dec.h
> index 513856749a..7436e0a54f 100644
> --- a/libavcodec/h264dec.h
> +++ b/libavcodec/h264dec.h
> @@ -117,7 +117,6 @@ typedef struct H264Picture {
> AVBufferRef *mb_type_buf;
>
Quoting Asahi Lina via ffmpeg-devel (2023-09-29 09:52:23)
> V4L2 provides a line stride to the client for hardware that has
> alignment requirements. rawvideo cannot represent this, so switch to
> wrapped_avframe for raw video formats and calculate the plane strides
> manually.
>
> This is
Quoting Andreas Rheinhardt (2023-10-02 12:04:02)
> Anton Khirnov:
> > Quoting Andreas Rheinhardt (2023-09-19 21:56:58)
> >> @@ -139,11 +138,7 @@ static int vp8_ref_frame(VP8Context *s, VP8Frame
> >> *dst, const VP8Frame *src)
> >>
> >> if ((ret = ff_thread_ref_frame(>tf, >tf)) < 0)
> >>
Rémi Denis-Courmont (12023-09-29):
> We can't just --disable-whatever. We do support building against
> distribution-provided FFmpeg afterall, where we have no influence on
> the build settings. We try to be nice and cooperative upstreams and
> downstreams.
Oh, but if you rely on FFmpeg from
Rémi Denis-Courmont (12023-09-29):
> First, I don't *represent* any downstream. I just happen to be one of
> several maintainers of one such project.
And you write here about them: you decide to represent them.
> In my experience,
> what you claim
Vittorio Giovara (12023-09-29):
> In a previous thread you said SDR shouldn't be a separate library because
> it wastes downstream time to package and bundle it separately.
No, it wastes Michael's time.
It also wastes downstream time, indeed, but that is not our problem.
Yet, it shows how
Anton Khirnov:
> Quoting Andreas Rheinhardt (2023-09-19 21:56:58)
>> @@ -139,11 +138,7 @@ static int vp8_ref_frame(VP8Context *s, VP8Frame *dst,
>> const VP8Frame *src)
>>
>> if ((ret = ff_thread_ref_frame(>tf, >tf)) < 0)
>> return ret;
>> -if (src->seg_map &&
>> -
Kyle Swanson (12023-09-24):
> AVFrame Subtitles
> -
>
> - Lynne cares about this, and hasn't done work on this yet.
> - Lynee suggests she could make time to collaborate with others on this.
> - Anton, others, say it makes sense to do this to avoid special handling
> of
Quoting Andreas Rheinhardt (2023-09-19 21:57:00)
> It avoids allocations and the corresponding error checks.
> Also avoids casts and indirections.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/dovi_rpu.c | 54 ++-
> libavcodec/dovi_rpu.h | 4
Quoting Andreas Rheinhardt (2023-09-19 21:56:59)
> It avoids allocations and the corresponding error checks.
> It also avoids indirections and casts.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/wavpack.c | 25 -
> 1 file changed, 8 insertions(+), 17
Quoting Andreas Rheinhardt (2023-09-19 21:56:58)
> @@ -139,11 +138,7 @@ static int vp8_ref_frame(VP8Context *s, VP8Frame *dst,
> const VP8Frame *src)
>
> if ((ret = ff_thread_ref_frame(>tf, >tf)) < 0)
> return ret;
> -if (src->seg_map &&
> -!(dst->seg_map =
Quoting Andreas Rheinhardt (2023-09-28 17:49:15)
> Anton Khirnov:
> > Quoting Andreas Rheinhardt (2023-09-19 21:56:56)
> >> diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c
> >> index 5657327f0c..632f5b23b2 100644
> >> --- a/libavcodec/h264_slice.c
> >> +++ b/libavcodec/h264_slice.c
Quoting James Almer (2023-09-06 16:38:32)
> Signed-off-by: James Almer
> ---
> This is an initial proof of concept for AVStream groups, something that's
> needed for quite a few existing and upcoming formats that lavf has no way to
> currently export. Said formats define a single video or audio
Quoting Tomas Härdin (2023-09-28 13:27:53)
> Yes, a typed union like this should work nicely. This way we keep
> things related to each type of stream group separate.
I agree that this seems like a better solution than repurposing
AVCodecParameters, but the union members probably need to be
From: headshog
---
libavformat/svs.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/libavformat/svs.c b/libavformat/svs.c
index b91d29f5a6..bdfb856184 100644
--- a/libavformat/svs.c
+++ b/libavformat/svs.c
@@ -42,6 +42,7 @@ static int svs_read_header(AVFormatContext
Quoting Michael Niedermayer (2023-10-01 00:28:56)
> On Sat, Sep 30, 2023 at 10:18:38PM +0200, Anton Khirnov wrote:
> > Quoting Michael Niedermayer (2023-09-30 16:31:43)
> > > On Sat, Sep 30, 2023 at 04:04:03PM +0200, Michael Niedermayer wrote:
> > > > On Sat, Sep 30, 2023 at 11:35:19AM +0200,
Quoting Andreas Rheinhardt (2023-10-01 15:18:30)
> Anton Khirnov:
> > In this case any timestamps are guessed by compute_pkt_fields() in
> > libavformat. Since we are decoding the stream, we have more accurate
> > information from the decoder and do not need any guesses.
> >
> > Eliminates
Quoting Andreas Rheinhardt (2023-10-01 15:14:49)
> Anton Khirnov:
> > Improves timestamps for fate-m4v*
>
> What makes the new cfr timestamps better?
The framerate, and frame durations derived from it, are no longer
garbage, so the last frame has a larger timestamps and does not get
dropped.
--
On 10/2/23, Umberto Boccioni wrote:
>>
>> something like
>> freezedetect,metadata=mode=select:key=lavfi.freezedetect.freeze_amount:value=some_frozen_amount:function=greater
>>
>> You just need to export frozen value from freezedetect filter for each
>> output frame metadata.
>>
>>
> Thanks for
67 matches
Mail list logo
