Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for demuxing still HEIC images

2023-10-03 Thread Vittorio Giovara
On Wed, Oct 4, 2023 at 12:02 AM Vignesh Venkat via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: > On Tue, Oct 3, 2023 at 6:32 PM Vittorio Giovara > wrote: > > > > On Tue, Oct 3, 2023 at 8:30 PM Steven Liu > wrote: > > > > > > > 2.42.0.515.g380fc7ccd1-goog > > > > > > > > > > > > > Any comments

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for demuxing still HEIC images

2023-10-03 Thread Vignesh Venkat via ffmpeg-devel
On Tue, Oct 3, 2023 at 5:30 PM Steven Liu wrote: > > Vignesh Venkat via ffmpeg-devel 于2023年10月4日 > 周三06:57写道: > > > On Tue, Sep 26, 2023 at 10:37 AM Vignesh Venkatasubramanian > > wrote: > > > > > > They are similar to AVIF images (both use the HEIF container). > > > The only additional work need

Re: [FFmpeg-devel] [PATCH 3/5] avformat/mov: Better check for duplicate iloc

2023-10-03 Thread Vignesh Venkat via ffmpeg-devel
On Tue, Oct 3, 2023 at 3:56 PM Vignesh Venkat wrote: > > On Fri, Sep 29, 2023 at 12:21 PM Michael Niedermayer > wrote: > > > > On Tue, Apr 25, 2023 at 03:22:50PM -0700, Vignesh Venkatasubramanian wrote: > > > On Mon, Apr 17, 2023 at 4:18 PM Michael Niedermayer > > > wrote: > > > > > > > > On Mon

[FFmpeg-devel] [PATCH v2] avformat/mov: Add support for demuxing still HEIC images

2023-10-03 Thread Vignesh Venkatasubramanian via ffmpeg-devel
They are similar to AVIF images (both use the HEIF container). The only additional work needed is to parse the hvcC box and put it in the extradata. With this patch applied, ffmpeg (when built with an HEVC decoder) is able to decode the files in https://github.com/nokiatech/heif/tree/gh-pages/cont

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for demuxing still HEIC images

2023-10-03 Thread Vignesh Venkat via ffmpeg-devel
On Tue, Oct 3, 2023 at 7:35 PM Leo Izen wrote: > > On 9/26/23 13:37, Vignesh Venkatasubramanian via ffmpeg-devel wrote: > > They are similar to AVIF images (both use the HEIF container). > > The only additional work needed is to parse the hvcC box and put > > it in the extradata. > > > > With this

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for demuxing still HEIC images

2023-10-03 Thread Vignesh Venkat via ffmpeg-devel
On Tue, Oct 3, 2023 at 6:32 PM Vittorio Giovara wrote: > > On Tue, Oct 3, 2023 at 8:30 PM Steven Liu wrote: > > > > > 2.42.0.515.g380fc7ccd1-goog > > > > > > > > > > Any comments/objections on merging this? > > > > > > Can this patch support tiled hevc coded or sequence heif?= > > > > I believe t

Re: [FFmpeg-devel] [PATCH 09/11] avcodec/decode: check for global side data in AVCodecContext side data

2023-10-03 Thread James Almer
On 10/3/2023 3:46 PM, James Almer wrote: On 10/3/2023 9:34 AM, Anton Khirnov wrote: Quoting James Almer (2023-09-27 15:12:40) avcodec/decode: check for global side data in AVCodecContext side data I don't think this makes it clear what this commit actually does. Make it something like 'prop

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for demuxing still HEIC images

2023-10-03 Thread Leo Izen
On 9/26/23 13:37, Vignesh Venkatasubramanian via ffmpeg-devel wrote: They are similar to AVIF images (both use the HEIF container). The only additional work needed is to parse the hvcC box and put it in the extradata. With this patch applied, ffmpeg (when built with an HEVC decoder) is able to d

Re: [FFmpeg-devel] [PATCH] avformat/mov: Disallow more than one meta box for AVIF

2023-10-03 Thread Vittorio Giovara
On Tue, Oct 3, 2023 at 7:05 PM Vignesh Venkatasubramanian via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: > This is not allowed per the spec. > > Signed-off-by: Vignesh Venkatasubramanian > --- > libavformat/mov.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/mov.c b/

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for demuxing still HEIC images

2023-10-03 Thread Vittorio Giovara
On Tue, Oct 3, 2023 at 8:30 PM Steven Liu wrote: > > > 2.42.0.515.g380fc7ccd1-goog > > > > > > > Any comments/objections on merging this? > > > Can this patch support tiled hevc coded or sequence heif?= > I believe that will be possible only after AVStreamGroup is implemented. Vignesh is there

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for demuxing still HEIC images

2023-10-03 Thread Steven Liu
Vignesh Venkat via ffmpeg-devel 于2023年10月4日 周三06:57写道: > On Tue, Sep 26, 2023 at 10:37 AM Vignesh Venkatasubramanian > wrote: > > > > They are similar to AVIF images (both use the HEIF container). > > The only additional work needed is to parse the hvcC box and put > > it in the extradata. > > >

[FFmpeg-devel] [PATCH] avformat/mov: Disallow more than one meta box for AVIF

2023-10-03 Thread Vignesh Venkatasubramanian via ffmpeg-devel
This is not allowed per the spec. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/mov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 294c864fbd..a8f57f9281 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4892,6 +4892,8 @@

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for demuxing still HEIC images

2023-10-03 Thread Vignesh Venkat via ffmpeg-devel
On Tue, Sep 26, 2023 at 10:37 AM Vignesh Venkatasubramanian wrote: > > They are similar to AVIF images (both use the HEIF container). > The only additional work needed is to parse the hvcC box and put > it in the extradata. > > With this patch applied, ffmpeg (when built with an HEVC decoder) > is

Re: [FFmpeg-devel] [PATCH 3/5] avformat/mov: Better check for duplicate iloc

2023-10-03 Thread Vignesh Venkat via ffmpeg-devel
On Fri, Sep 29, 2023 at 12:21 PM Michael Niedermayer wrote: > > On Tue, Apr 25, 2023 at 03:22:50PM -0700, Vignesh Venkatasubramanian wrote: > > On Mon, Apr 17, 2023 at 4:18 PM Michael Niedermayer > > wrote: > > > > > > On Mon, Apr 17, 2023 at 12:36:26PM +0200, Anton Khirnov wrote: > > > > Quoting

[FFmpeg-devel] [PATCH] avcodec/svt-av1: Set force_key_frames only when gop_size == 1

2023-10-03 Thread Vignesh Venkatasubramanian via ffmpeg-devel
SVT-AV1 does not support requesting keyframes at arbitrary points by setting pic_type to EB_AV1_KEY_PICTURE. So set force_key_frames to 1 only when gop_size == 1. Please see the comments in https://gitlab.com/AOMediaCodec/SVT-AV1/-/issues/2076 for a bit more details. Signed-off-by: Vignesh Venkat

Re: [FFmpeg-devel] [PATCH] avcodec/svt-av1: Set pic_type only when gop_size == 1

2023-10-03 Thread Vignesh Venkat via ffmpeg-devel
On Thu, Sep 28, 2023 at 2:05 AM Ronald S. Bultje wrote: > > Hi Vignesh, > > On Thu, Sep 28, 2023 at 12:14 AM Vignesh Venkatasubramanian via ffmpeg-devel > wrote: >> >> SVT-AV1 does not support requesting keyframes at arbitrary points >> by setting pic_type to EB_AV1_KEY_PICTURE. >> >> This patch

Re: [FFmpeg-devel] [PATCH 5/8] avcodec/mpeg12dec: Don't initialize IDCT more than once

2023-10-03 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Before 998c9f15d1ca8c7489775ebcca51623b915988f1, the IDCTDSPContext > has only been initialized in ff_mpv_common_init() which is deferred > until immediately before decoding a picture; to nevertheless parse > the quant matrices in sequence headers or quant matrix extensions, >

[FFmpeg-devel] [PATCH 2/2] lavu/fixed_dsp: R-V V vector_fmul_add

2023-10-03 Thread Rémi Denis-Courmont
vector_fmul_add_fixed_c: 2.7 vector_fmul_add_fixed_rvv_i64: 0.7 --- libavutil/riscv/fixed_dsp_init.c | 6 +- libavutil/riscv/fixed_dsp_rvv.S | 22 ++ 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/libavutil/riscv/fixed_dsp_init.c b/libavutil/riscv/fixed_ds

[FFmpeg-devel] [PATCH 1/2] lavu/fixed_dsp: R-V V scalarproduct

2023-10-03 Thread Rémi Denis-Courmont
--- libavutil/riscv/fixed_dsp_init.c | 6 +- libavutil/riscv/fixed_dsp_rvv.S | 22 ++ 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/libavutil/riscv/fixed_dsp_init.c b/libavutil/riscv/fixed_dsp_init.c index d4ca2e2064..409b6d7b55 100644 --- a/libavutil/ris

Re: [FFmpeg-devel] VDD 2023, FFmpeg meeting notes, (23-11-2023, 4pm, Dublin)

2023-10-03 Thread Leo Izen
On 10/3/23 14:50, Nicolas George wrote: As the project grows, democracy gives an increasing weight to people who came late to contribute to the project in specialized ways I have more than 20 commits in the last year, although my contributions are almost entirely to one specific module that I

Re: [FFmpeg-devel] VDD 2023, FFmpeg meeting notes, (23-11-2023, 4pm, Dublin)

2023-10-03 Thread Rémi Denis-Courmont
Le tiistaina 3. lokakuuta 2023, 21.50.25 EEST Nicolas George a écrit : > More precisely, I now strongly believe that democracy is a terrible way > to run a project like FFmpeg. > > As the project grows, democracy gives an increasing weight to people who > came late to contribute to the project in

Re: [FFmpeg-devel] VDD 2023, FFmpeg meeting notes, (23-11-2023, 4pm, Dublin)

2023-10-03 Thread Kieran Kunhya via ffmpeg-devel
On Tue, Oct 3, 2023 at 7:50 PM Nicolas George wrote: > More precisely, I now strongly believe that democracy is a terrible way > to run a project like FFmpeg. Why are you part of a community project if you don't believe the community is capable of running a project? Why not start your own project

Re: [FFmpeg-devel] [RFC] Release 6.1

2023-10-03 Thread Michael Niedermayer
On Tue, Sep 26, 2023 at 08:14:37PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-09-26 19:16:30) > > On Tue, Sep 26, 2023 at 05:30:19PM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2023-09-26 17:09:47) > > > > On Tue, Sep 26, 2023 at 11:13:40AM +0200, Anton Khirn

Re: [FFmpeg-devel] VDD 2023, FFmpeg meeting notes, (23-11-2023, 4pm, Dublin)

2023-10-03 Thread Vittorio Giovara
On Tue, Oct 3, 2023 at 2:50 PM Nicolas George wrote: > Vittorio Giovara (12023-09-27): > > This is basically saying that you don't trust the community to make the > > best decisions for itself, or that the community is not mature enough to > > stand on its own to support the project. > > You are

Re: [FFmpeg-devel] [PATCH 08/11] avcodec/hevcdec: check for DOVI configuration record in AVCodecContext side data

2023-10-03 Thread James Almer
On 10/3/2023 7:18 AM, Anton Khirnov wrote: Quoting James Almer (2023-09-27 15:12:39) Signed-off-by: James Almer --- libavcodec/avcodec.h | 2 +- libavcodec/decode.c | 10 ++ libavcodec/decode.h | 3 +++ libavcodec/hevcdec.c | 15 ++- 4 files changed, 28 insertions(

Re: [FFmpeg-devel] [PATCH 1/6] avformat/avidec: support huge durations

2023-10-03 Thread Michael Niedermayer
On Tue, Oct 03, 2023 at 11:10:20AM +0200, Tomas Härdin wrote: > mån 2023-10-02 klockan 21:03 +0200 skrev Michael Niedermayer: > > On Mon, Oct 02, 2023 at 11:07:47AM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2023-10-01 00:28:56) > > > > On Sat, Sep 30, 2023 at 10:18:38PM +0200,

Re: [FFmpeg-devel] VDD 2023, FFmpeg meeting notes, (23-11-2023, 4pm, Dublin)

2023-10-03 Thread Nicolas George
Vittorio Giovara (12023-09-27): > This is basically saying that you don't trust the community to make the > best decisions for itself, or that the community is not mature enough to > stand on its own to support the project. You are twisting the words to make it sound bad, but it is roughly what I

Re: [FFmpeg-devel] [PATCH 09/11] avcodec/decode: check for global side data in AVCodecContext side data

2023-10-03 Thread James Almer
On 10/3/2023 9:34 AM, Anton Khirnov wrote: Quoting James Almer (2023-09-27 15:12:40) avcodec/decode: check for global side data in AVCodecContext side data I don't think this makes it clear what this commit actually does. Make it something like 'propagate global side data to frames'. Signed-

Re: [FFmpeg-devel] VDD 2023, FFmpeg meeting notes, (23-11-2023, 4pm, Dublin)

2023-10-03 Thread Nicolas George
Kyle Swanson (12023-09-24): > DNS > --- > > - Currently the DNS of ffmpeg.org is managed by Fabrice > - Michael was asked if he has control over the ffmpeg.org DNS register. > - Michael says he thinks he has some. > - Ronald would be curious to know what "some" means. > - Ronald proposes

Re: [FFmpeg-devel] [PATCH avcodec/amfenc:, 10, bit, support, v3, 1/3] avcodec/amfenc: Fixes the color information in the output.

2023-10-03 Thread Michael Niedermayer
On Wed, Jul 26, 2023 at 01:39:27PM +0200, Evgeny Pavlov wrote: > From: Michael Fabian 'Xaymar' Dirks > > added 10 bit support for amf hevc. > > before: > > command - ffmpeg.exe -hide_banner -y -hwaccel d3d11va -hwaccel_output_format > d3d11 -i test_10bit_file.mkv -an -c:v h264_amf res.dx11_hw_

[FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: add some icc profile checks

2023-10-03 Thread Leo Izen
This patch will cause the parser to abort if it detects an icc profile with an invalid size. This is particularly important if the icc profile is entropy-encoded with zero bits per symbol, as it can prevent a seemingly infinite loop during parsing. Fixes: infinite loop Fixes: 62374/clusterfuzz-tes

Re: [FFmpeg-devel] [PATCH] aacdec: padding skip improvements

2023-10-03 Thread Andreas Rheinhardt
Lynne: > The FFmpeg encoder will be modified to also output 2048 samples of > padding at the start, to make it in line with other encoders. Once again: What is the advantage? Doing what lots of other codecs do is not a real advantage. > > +{ "padding", "Override the padding at the start of a

[FFmpeg-devel] [PATCH 12/12] avcodec/mpegvideo: Move allocating new_picture to the encoder

2023-10-03 Thread Andreas Rheinhardt
It is only used by encoders; this unfortunately necessitated to add separate allocations to the SVQ1 encoder which uses motion estimation without being a full member of mpegvideo. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.c | 5 + libavcodec/mpegvideo_enc.c | 3 ++- liba

[FFmpeg-devel] [PATCH 11/12] avcodec/h261dec, mpeg12dec, vc1dec: Remove setting write-only flags

2023-10-03 Thread Andreas Rheinhardt
These flags will be overwritten later in ff_mpv_frame_start(). Signed-off-by: Andreas Rheinhardt --- libavcodec/h261dec.c | 7 --- libavcodec/mpeg12dec.c | 10 -- libavcodec/vc1dec.c| 7 --- 3 files changed, 24 deletions(-) diff --git a/libavcodec/h261dec.c b/libavcodec/

[FFmpeg-devel] [PATCH 10/12] avcodec/rv10: Replace switch by LUT

2023-10-03 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/rv10.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/libavcodec/rv10.c b/libavcodec/rv10.c index 3f9d5ff242..216328ffe7 100644 --- a/libavcodec/rv10.c +++ b/libavcodec/rv10.c @@ -158,25 +158,14 @@ static

[FFmpeg-devel] [PATCH 09/12] avcodec/rv10: Remove dead code

2023-10-03 Thread Andreas Rheinhardt
Dead since 248a1aa54c08b14e8bd49147f59d954c41b5b3a3. Signed-off-by: Andreas Rheinhardt --- libavcodec/rv10.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/rv10.c b/libavcodec/rv10.c index fbecfdae9f..3f9d5ff242 100644 --- a/libavcodec/rv10.c +++ b/libavcodec/rv10.c @@ -176,9 +

Re: [FFmpeg-devel] [PATCH] [RFC]avformat: introduce AVStreamGroup

2023-10-03 Thread Anton Khirnov
Quoting James Almer (2023-10-02 14:10:11) > > I figured it would be nice to have it for the sake of convenience. For > formats like HEIF, new streams should in theory be created once the > group they will belong to is known. > I have no strong attachment to this function, so it can go if you thi

[FFmpeg-devel] [PATCH 10/12] fftools/ffmpeg_enc: move fps conversion code to ffmpeg_filter

2023-10-03 Thread Anton Khirnov
Its function is analogous to that of the fps filter, so filtering is a more appropriate place for this. The main practical reason for this move is that it places the encoding sync queue right at the boundary between filters and encoders. This will be important when switching to threaded scheduling

[FFmpeg-devel] [PATCH 11/12] fftools/ffmpeg_filter: fail on filtering errors

2023-10-03 Thread Anton Khirnov
These should be considered serious errors - don't just print a log message and continue as if nothing happened. --- fftools/ffmpeg_filter.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 0df284c334.

[FFmpeg-devel] [PATCH 09/12] fftools/ffmpeg_enc: move framerate conversion state into a separate struct

2023-10-03 Thread Anton Khirnov
Makes it more clear what state is specific to framerate conversion, which will be useful in the following commit. --- fftools/ffmpeg_enc.c | 65 1 file changed, 35 insertions(+), 30 deletions(-) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c

[FFmpeg-devel] [PATCH 08/12] fftools/ffmpeg: stop accessing OutputStream.last_dropped in print_report()

2023-10-03 Thread Anton Khirnov
That field is used by the framerate code to track whether any output has been generated for the last input frame(*). Its use in the last invocation of print_report() is meant to account for the very last filtered frame being dropped in the number of dropped frames printed in the log. However, that

[FFmpeg-devel] [PATCH 03/12] fftools/ffmpeg_enc: simplify adjust_frame_pts_to_encoder_tb() signature

2023-10-03 Thread Anton Khirnov
It does not need an OutputFile and an OutputStream, only the target timebase and the timestamp offset. --- fftools/ffmpeg_enc.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index 0c51d9f0c6..b928bf208c 1

[FFmpeg-devel] [PATCH 07/12] fftools/ffmpeg_enc: merge -force_key_frames source/source_no_drop

2023-10-03 Thread Anton Khirnov
Always use the functionality of the latter, which makes more sense as it avoids losing keyframes due to vsync code dropping frames. Deprecate the 'source_no_drop' value, as it is now redundant. --- doc/ffmpeg.texi | 5 - fftools/ffmpeg.h

[FFmpeg-devel] [PATCH 12/12] fftools/ffmpeg_enc: constify the frame passed to enc_open()

2023-10-03 Thread Anton Khirnov
--- fftools/ffmpeg.h | 2 +- fftools/ffmpeg_enc.c | 7 +++ 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index 15790d3e0c..0983d026cd 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@ -817,7 +817,7 @@ int dec_packet(InputStream *is

[FFmpeg-devel] [PATCH 06/12] fftools/ffmpeg_enc: unbreak -force_key_frames source_no_drop

2023-10-03 Thread Anton Khirnov
Unlike the 'source' mode, which preserves source keyframe-marking as-is, the 'source_no_drop' mode attempts to keep track of keyframes dropped by framerate conversion and mark the next output frame as key in such cases. However, * c75be061487 broke this functionality entirely, and made it equivalen

[FFmpeg-devel] [PATCH 05/12] tests/fate/ffmpeg: add tests for -force_key_frames source

2023-10-03 Thread Anton Khirnov
--- tests/fate/ffmpeg.mak | 20 + tests/ref/fate/force_key_frames-source | 397 + tests/ref/fate/force_key_frames-source-drop | 22 + tests/ref/fate/force_key_frames-source-dup | 617 4 files changed, 1056 insertions(+) create mode 10

[FFmpeg-devel] [PATCH 04/12] ffools/ffmpeg_filter: stop trying to handle an unreachable state

2023-10-03 Thread Anton Khirnov
ifilter_send_eof() will fail if the input has no real or fallback parameters, so there is no need to handle the case of some inputs being in EOF state yet having no parameters. --- fftools/ffmpeg.c| 2 +- fftools/ffmpeg.h| 2 -- fftools/ffmpeg_filter.c | 10 +- 3 files ch

[FFmpeg-devel] [PATCH 02/12] fftools/ffmpeg_enc: move remaining vsync-related code to video_sync_process()

2023-10-03 Thread Anton Khirnov
--- fftools/ffmpeg_enc.c | 46 +++- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index 8ae36294ce..0c51d9f0c6 100644 --- a/fftools/ffmpeg_enc.c +++ b/fftools/ffmpeg_enc.c @@ -1048,6 +1048,30 @@ f

[FFmpeg-devel] [PATCH 01/12] fftools/ffmpeg_enc: move handling video frame duration to video_sync_process()

2023-10-03 Thread Anton Khirnov
That is a more appropriate place for this. --- fftools/ffmpeg_enc.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index ec9cebbd96..8ae36294ce 100644 --- a/fftools/ffmpeg_enc.c +++ b/fftools/ffmpeg_enc.c @@ -965,12 +9

[FFmpeg-devel] [PATCH v2] avcodec/jpegxl_parser: fix various memory issues

2023-10-03 Thread Leo Izen
The spec caps the prefix alphabet size to 32768 (i.e. 1 << 15) so we should check for that and reject alphabets that are too large, in order to prevent over-allocating. Additionally, there's no need to allocate buffers that are as large as the maximum alphabet size as these aren't stack-allocated,

Re: [FFmpeg-devel] [PATCH 08/15] avformat/sbgdec: Check for negative duration or un-representable end pts

2023-10-03 Thread Nicolas George
Michael Niedermayer (12023-10-01): > Fixes: signed integer overflow: 9230955872951340 - -9223372036854775808 > cannot be represented in type 'long' > Fixes: > 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_SBG_fuzzer-6330481893572608 > > Found-by: continuous fuzzing process > https://github.co

Re: [FFmpeg-devel] [PATCH 1/5] tools/target_dec_fuzzer: Adjust wmapro threshold

2023-10-03 Thread Michael Niedermayer
On Tue, Sep 19, 2023 at 12:35:30AM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 62266/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMAPRO_fuzzer-5125460729921536 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Sign

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/wavarc: Fix integer overflwo in do_stereo()

2023-10-03 Thread Michael Niedermayer
On Thu, Sep 21, 2023 at 08:09:08PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 148676193 - -2006512262 cannot be represented > in type 'int' > Fixes: > 62164/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVARC_fuzzer-5963163952349184 > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 3/4] avutil/tx_template: Fix some signed integer overflows in DECL_FFT5()

2023-10-03 Thread Michael Niedermayer
On Fri, Sep 15, 2023 at 03:11:46PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -1364715454 + -1468954671 cannot be > represented in type 'int' > Fixes: > 62093/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5538774254485504 > > Found-by: continuous fuz

Re: [FFmpeg-devel] [PATCH 1/3] tools/target_dec_fuzzer: Adjust threshold for MVHA

2023-10-03 Thread Michael Niedermayer
On Thu, Sep 14, 2023 at 01:47:32AM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 62120/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MVHA_fuzzer-5647877768347648 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/flacdec: Fix overflow in "33bit" decorrelate

2023-10-03 Thread Michael Niedermayer
On Wed, Sep 20, 2023 at 02:30:30AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 538976288 - -9223372036854775808 cannot be > represented in type 'long' > Fixes: > 62164/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLAC_fuzzer-6275845531238400 > > Found-by: continuous

Re: [FFmpeg-devel] [PATCH 07/15] avformat/sbgdec: Check for period overflow

2023-10-03 Thread Michael Niedermayer
On Tue, Oct 03, 2023 at 01:06:43PM +0200, Nicolas George wrote: > Michael Niedermayer (12023-10-01): > > Fixes: signed integer overflow: 448124699617300 - -47785768200 > > cannot be represented in type 'long' > > Fixes: > > 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_SBG_fuzzer-50

Re: [FFmpeg-devel] [PATCH 01/15] avformat/concatdec: Check in/outpoint for overflow

2023-10-03 Thread Michael Niedermayer
On Mon, Oct 02, 2023 at 02:03:27PM +0200, Nicolas George wrote: > Michael Niedermayer (12023-10-01): > > Fixes: signed integer overflow: 9154241445400 - -915424149454600 > > cannot be represented in type 'long' > > Fixes: > > 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_CONCAT_fuzzer-4

Re: [FFmpeg-devel] [PATCH 2/2] avformat/westwood_vqa: Check chunk size

2023-10-03 Thread Michael Niedermayer
On Wed, Sep 28, 2022 at 05:17:44PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2022-09-22 20:08:52) > > the type is also changed to int as it is interpreted as int in > > av_get_packet() > > > > Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in > > type 'int'

Re: [FFmpeg-devel] [PATCH] configure: warn when threading is disabled

2023-10-03 Thread Anton Khirnov
Quoting James Almer (2023-10-03 15:40:12) > On 10/3/2023 10:37 AM, Anton Khirnov wrote: > > Explicitly state what the implications of this are. > > --- > > configure | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/configure b/configure > > index 8a1a1b8584..5ba2698798 10075

[FFmpeg-devel] avfilter/vf_decimate: Improve decimation factor precision

2023-10-03 Thread Vladimir Petrov
Sent separately, as Patchwork doesn't accept multiple patches, attached on single message. Please check these: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_decimate: Improve decimation factor precision [FFmpeg-devel] [PATCH 2/2] avfilter/vf_decimate: Add compatibility option Patches are exactly the sam

Re: [FFmpeg-devel] [PATCH] avcodec/lcldec: fix uncompressed buffer size calculation

2023-10-03 Thread Michael Niedermayer
On Mon, Oct 02, 2023 at 09:42:25PM +0200, Paul B Mahol wrote: > On 10/2/23, Michael Niedermayer wrote: > > Hi Paul > > > > On Mon, Oct 02, 2023 at 04:23:54PM +0200, Paul B Mahol wrote: > >> On 9/30/23, Paul B Mahol wrote: > >> > Attached. > >> > > >> > >> Gonna apply soon. > > > > Did you look at

Re: [FFmpeg-devel] [PATCH] configure: warn when threading is disabled

2023-10-03 Thread James Almer
On 10/3/2023 10:37 AM, Anton Khirnov wrote: Explicitly state what the implications of this are. --- configure | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configure b/configure index 8a1a1b8584..5ba2698798 100755 --- a/configure +++ b/configure @@ -7493,6 +7493,12 @@ check_deps $C

[FFmpeg-devel] [PATCH] configure: warn when threading is disabled

2023-10-03 Thread Anton Khirnov
Explicitly state what the implications of this are. --- configure | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configure b/configure index 8a1a1b8584..5ba2698798 100755 --- a/configure +++ b/configure @@ -7493,6 +7493,12 @@ check_deps $CONFIG_LIST \ enabled threads && ! enabl

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_decimate: Add compatibility option

2023-10-03 Thread Vladimir Petrov
Adds compatibility with the old behaviour. Added a new option 'compat'. When set to 'true', no metrics recalculation will be done when marking a new frame to be dropped. In case of scene change detection, the last one per batch will be prioritized, instead of the best one. In mixed mode, checking f

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_decimate: Improve decimation factor precision

2023-10-03 Thread Vladimir Petrov
Currently, decimate video filter supports dropping of only single frame per cycle, limiting the range of available framerate decimation factors. Now, adding a new option 'dropcount' allows increasing of drop count, so more fractional factors could be chosen. Also added an option 'spread' to set per

Re: [FFmpeg-devel] [PATCH 01/11] avcodec/packet: add generic side data helpers

2023-10-03 Thread Anton Khirnov
Quoting James Almer (2023-09-27 15:12:32) > +static AVPacketSideData *packet_side_data_add(AVPacketSideData **psd, int > *pnb_sd, > + enum AVPacketSideDataType type, > + void *data, size_t size) > +{ > +A

Re: [FFmpeg-devel] [PATCH v1] avcodec/hevcpred_template: Removed unreachable code

2023-10-03 Thread Ronald S. Bultje
Hi, On Tue, Oct 3, 2023 at 4:15 AM Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics wrote: > > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Ronald > > S. Bultje > > Sent: poniedziałek, 2 października 2023 15:49 > > To: FFmpeg development discussi

Re: [FFmpeg-devel] [PATCH 09/11] avcodec/decode: check for global side data in AVCodecContext side data

2023-10-03 Thread Anton Khirnov
Quoting James Almer (2023-09-27 15:12:40) > avcodec/decode: check for global side data in AVCodecContext side data I don't think this makes it clear what this commit actually does. Make it something like 'propagate global side data to frames'. > Signed-off-by: James Almer > --- > libavcodec/dec

[FFmpeg-devel] avfilter/vf_decimate: Improve decimation factor precision

2023-10-03 Thread Vladimir Petrov
Currently, decimate video filter supports dropping of only single frame per cycle, limiting the range of available framerate decimation factors. Now, adding a new option 'dropcount' allows increasing of drop count, so more fractional factors could be chosen. Also added an option 'spread' to set per

Re: [FFmpeg-devel] [PATCH 05/11] fftools/ffmpeg: stop using AVStream.side_data

2023-10-03 Thread Anton Khirnov
Quoting James Almer (2023-09-27 15:12:36) > Signed-off-by: James Almer > --- > fftools/ffmpeg_demux.c| 12 > fftools/ffmpeg_enc.c | 31 +-- > fftools/ffmpeg_filter.c | 6 +- > fftools/ffmpeg_mux_init.c | 21 - > 4 files

Re: [FFmpeg-devel] [PATCH 03/11] avformat/avformat: use the side data from AVStream.codecpar

2023-10-03 Thread Anton Khirnov
Quoting James Almer (2023-09-27 15:12:34) > @@ -807,11 +808,14 @@ static int mov_read_dac3(MOVContext *c, AVIOContext > *pb, MOVAtom atom) > return 0; > st = c->fc->streams[c->fc->nb_streams-1]; > > -ast = (enum AVAudioServiceType*)av_stream_new_side_data(st, > AV_PKT_DATA_AUD

Re: [FFmpeg-devel] [PATCH 11/11] fftools/ffplay: stop injecting stream side data in packets

2023-10-03 Thread Anton Khirnov
Quoting Anton Khirnov (2023-10-03 12:11:52) > Quoting James Almer (2023-09-27 15:12:42) > > This is no longer needed as the side data is available for decoders in the > > AVCodecContext. > > > > Signed-off-by: James Almer > > --- > > fftools/ffplay.c | 2 -- > > 1 file changed, 2 deletions(-) >

Re: [FFmpeg-devel] [PATCH 02/11] avcodec/codec_par: add side data to AVCodecParameters

2023-10-03 Thread Anton Khirnov
Quoting James Almer (2023-09-27 15:12:33) > This will simplify the propagation of side data to decoders and from encoders. > Global side data will now reside in the AVCodecContext, thus be available > during init(), removing the need to propagate it inside packets. > > Global and frame specific si

Re: [FFmpeg-devel] [PATCH 07/15] avformat/sbgdec: Check for period overflow

2023-10-03 Thread Nicolas George
Michael Niedermayer (12023-10-01): > Fixes: signed integer overflow: 448124699617300 - -47785768200 > cannot be represented in type 'long' > Fixes: > 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_SBG_fuzzer-5063670588899328 > > Found-by: continuous fuzzing process > https://github

Re: [FFmpeg-devel] [PATCH 10/11] fftools/ffmpeg: stop injecting stream side data in packets

2023-10-03 Thread Anton Khirnov
Quoting James Almer (2023-09-27 15:12:41) > This is no longer needed as the side data is available for decoders in the > AVCodecContext. > The tests affected reflect the removal of useless CPB and Stereo 3D side > data in packets. > > Signed-off-by: James Almer > --- > fftools/ffmpeg_demux.c

Re: [FFmpeg-devel] [PATCH 04/11] avcodec/packet: add some documentation for AVPacketSideData

2023-10-03 Thread Anton Khirnov
Quoting James Almer (2023-09-27 15:12:35) > Explaining what or who may use it, and in what scenarios. > > Signed-off-by: James Almer > --- > libavcodec/packet.h | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/libavcodec/packet.h b/libavcodec/packet.h > index 96fc0084d6

Re: [FFmpeg-devel] [PATCH 08/11] avcodec/hevcdec: check for DOVI configuration record in AVCodecContext side data

2023-10-03 Thread Anton Khirnov
Quoting James Almer (2023-09-27 15:12:39) > Signed-off-by: James Almer > --- > libavcodec/avcodec.h | 2 +- > libavcodec/decode.c | 10 ++ > libavcodec/decode.h | 3 +++ > libavcodec/hevcdec.c | 15 ++- > 4 files changed, 28 insertions(+), 2 deletions(-) > > diff --git a/

Re: [FFmpeg-devel] [PATCH 11/11] fftools/ffplay: stop injecting stream side data in packets

2023-10-03 Thread Anton Khirnov
Quoting James Almer (2023-09-27 15:12:42) > This is no longer needed as the side data is available for decoders in the > AVCodecContext. > > Signed-off-by: James Almer > --- > fftools/ffplay.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fftools/ffplay.c b/fftools/ffplay.c > index

Re: [FFmpeg-devel] [PATCH 1/6] avformat/avidec: support huge durations

2023-10-03 Thread Tomas Härdin
mån 2023-10-02 klockan 21:03 +0200 skrev Michael Niedermayer: > On Mon, Oct 02, 2023 at 11:07:47AM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2023-10-01 00:28:56) > > > On Sat, Sep 30, 2023 at 10:18:38PM +0200, Anton Khirnov wrote: > > > > Quoting Michael Niedermayer (2023-09-30 1

Re: [FFmpeg-devel] [PATCH v3] avformat/mxfdec: Remove this_partition

2023-10-03 Thread Tomas Härdin
lör 2023-09-30 klockan 01:32 +0200 skrev Michael Niedermayer: > On Fri, Sep 29, 2023 at 06:55:22PM +0200, Michael Niedermayer wrote: > [...] > > ok will apply with that > > fixing this issue caused ossfuzz to reveal 24 unrelated unfixed > issues > that where hidden in the same issue number as this

Re: [FFmpeg-devel] [PATCH v1] avcodec/hevcpred_template: Removed unreachable code

2023-10-03 Thread Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
> -Original Message- > From: ffmpeg-devel On Behalf Of Ronald > S. Bultje > Sent: poniedziałek, 2 października 2023 15:49 > To: FFmpeg development discussions and patches > Cc: Dawid Kozinski ; d.frankie...@samsung.com > Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/hevcpred_template: