Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_vpp_qsv: apply 3D LUT from file.

2023-10-22 Thread Chen Yufei
Thanks for your comments. I'll use MFX_RESOURCE_SYSTEM_SURFACE and send another patch. While implementing this feature, I noticed that vpp_set_frame_ext_params is called multiple times. If using system memory for storing 3D LUT, is it possible the LUT table copying to gfx memory will occur

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_lut3d: expose 3D LUT file parse function.

2023-10-22 Thread Chen Yufei
Thanks for reviewing this patch. Do you mean this should be merged with the change to vf_vpp_qsv file and send only one patch file? On Mon, Oct 16, 2023 at 3:51 PM Xiang, Haihao wrote: > > On Sa, 2023-09-23 at 23:36 +0800, Chen Yufei wrote: > > Signed-off-by: Chen Yufei > > --- > >

Re: [FFmpeg-devel] [PATCH 1/9] avcodec/vlc: merge lost 16bit end of array check

2023-10-22 Thread Paul B Mahol
I have no time to review these hacks. Make sure you do not break >8 bit support in utvideo and magicyuv decoders. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above,

[FFmpeg-devel] [PATCH] avcodec: remove special casing CACHED_BITSTREAM_READER

2023-10-22 Thread Michael Niedermayer
after the vlc multi cleanup patchset today i see no fate failure but i do not know why exactly these special cases where there Signed-off-by: Michael Niedermayer --- libavcodec/magicyuv.c | 2 +- libavcodec/utvideodec.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[FFmpeg-devel] [PATCH 9/9] avcodec/vlc: simplify min/maxbits in multi VLC

2023-10-22 Thread Michael Niedermayer
nothing uses maxbits, so its removed minbits is just the last entry (verified with assert on fate) This basically reverts 58d9b5caf3d332c6495f9af437158bf45531a05e for the minbits computation Signed-off-by: Michael Niedermayer --- libavcodec/vlc.c | 13 - 1 file changed, 4

[FFmpeg-devel] [PATCH 8/9] Revert "avcodec/vlc: fix off by one in limit check for multi"

2023-10-22 Thread Michael Niedermayer
This with the last revert results in a table with additional entries This reverts commit b23eaf968e375f2d38865d90a788221caead3324. --- libavcodec/vlc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vlc.c b/libavcodec/vlc.c index 79544006677..ceabeba5408 100644

[FFmpeg-devel] [PATCH 7/9] Revert "avcodec/vlc: add correct upper limit for recursive function"

2023-10-22 Thread Michael Niedermayer
This reverts commit fa20f5cd9e131f22da06ef57bf5aedd87ff51a90. --- libavcodec/vlc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vlc.c b/libavcodec/vlc.c index 4c96fcddc9b..79544006677 100644 --- a/libavcodec/vlc.c +++ b/libavcodec/vlc.c @@ -432,7 +432,7 @@ static

[FFmpeg-devel] [PATCH 6/9] avcodec/vlc: Remove mysterious jitter loop in multi VLC

2023-10-22 Thread Michael Niedermayer
No difference in my testcase in the tables content Signed-off-by: Michael Niedermayer --- libavcodec/vlc.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libavcodec/vlc.c b/libavcodec/vlc.c index 4adec2da705..4c96fcddc9b 100644 --- a/libavcodec/vlc.c +++

[FFmpeg-devel] [PATCH 5/9] avcodec/vlc: Pass VLC_MULTI_ELEM directly not by pointer

2023-10-22 Thread Michael Niedermayer
This makes the code more testable as uninitialized fields are 0 and not random values from the last call Signed-off-by: Michael Niedermayer --- libavcodec/vlc.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavcodec/vlc.c b/libavcodec/vlc.c index

[FFmpeg-devel] [PATCH 4/9] avcodec/vlc: Replace mysterious max computation code in multi vlc

2023-10-22 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/vlc.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/libavcodec/vlc.c b/libavcodec/vlc.c index 65883a506ff..9b7a42f79a3 100644 --- a/libavcodec/vlc.c +++ b/libavcodec/vlc.c @@ -359,7 +359,7 @@ static void

[FFmpeg-devel] [PATCH 3/9] avcodec/vlc: Skip subtable entries in multi VLC

2023-10-22 Thread Michael Niedermayer
These entries do not correspond to VLC symbols that can be used they do corrupt various variables like min/max bits This also no longer assumes that there is a single non subtable entry Probably fixes some infinite loops too Signed-off-by: Michael Niedermayer --- libavcodec/vlc.c | 16

[FFmpeg-devel] [PATCH 2/9] avcodec/vlc: dont pass nb_elems into multi vlc code

2023-10-22 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/vlc.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libavcodec/vlc.c b/libavcodec/vlc.c index 4f62eddf0fb..77860430861 100644 --- a/libavcodec/vlc.c +++ b/libavcodec/vlc.c @@ -350,7 +350,7 @@ fail: return

[FFmpeg-devel] [PATCH 1/9] avcodec/vlc: merge lost 16bit end of array check

2023-10-22 Thread Michael Niedermayer
Also cleanup related code Signed-off-by: Michael Niedermayer --- libavcodec/vlc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/vlc.c b/libavcodec/vlc.c index e4bbf2945e1..4f62eddf0fb 100644 --- a/libavcodec/vlc.c +++ b/libavcodec/vlc.c @@ -358,8 +358,8

Re: [FFmpeg-devel] [PATCH] avcodec/librsvgdec: fix memory leaks and deprecated functions

2023-10-22 Thread Leo Izen
On 10/15/23 08:06, Leo Izen wrote: On 10/7/23 21:36, Leo Izen wrote: At various points through the function librsvg_decode_frame, errors are returned from immediately without deallocating any allocated structs. This patch both fixes those leaks, and also fixes the use of functions that are

[FFmpeg-devel] [PATCH] cbs_av1: Reject thirty-two zero bits in uvlc code

2023-10-22 Thread Mark Thompson
The spec allows at least thirty-two zero bits followed by a one to mean 2^32-1, with no constraint on the number of zeroes. The libaom reference decoder does not match this, instead reading thirty-two zeroes but not the following one to mean 2^32-1. These two interpretations are incompatible

Re: [FFmpeg-devel] [PATCH] MULTI VLC decoding boost

2023-10-22 Thread Michael Niedermayer
On Mon, Aug 28, 2023 at 07:36:17PM +0200, Paul B Mahol wrote: > Patches attached. > > Thanks for kurosu for pointing unmerged branches. > [...] > +static void add_level(VLC_MULTI_ELEM *table, const int nb_elems, > + const int num, const int numbits, > +

Re: [FFmpeg-devel] [PATCH 1/4] lavc/aarch64: new optimization for 8-bit hevc_epel_v

2023-10-22 Thread Martin Storsjö
On Sun, 22 Oct 2023, Logan.Lyu wrote: Hi, Martin, Could you please review these patches and let me know if there are any changes needed. Did you see the message from Michael on Oct 14th? Your patches have corrupted whitespace and can't be applied. Earlier you've submitted some patches as

[FFmpeg-devel] [PATCH 3/3] avcodec/magicyuv: remove redundant check in inner loop

2023-10-22 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/magicyuv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/magicyuv.c b/libavcodec/magicyuv.c index d813f209203..3f6348b531e 100644 --- a/libavcodec/magicyuv.c +++ b/libavcodec/magicyuv.c @@ -125,10 +125,9 @@

[FFmpeg-devel] [PATCH 2/3] avcodec/magicyuv: correct end of array check in multi VLC parsing

2023-10-22 Thread Michael Niedermayer
Fixes: out of array write Fixes: 63390/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MAGICYUV_fuzzer-5144552979431424.fuzz Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/magicyuv.c | 2

[FFmpeg-devel] [PATCH 1/3] avcodec/bitstream_template: Basic documentation for read_vlc_multi()

2023-10-22 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/bitstream_template.h | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/libavcodec/bitstream_template.h b/libavcodec/bitstream_template.h index cf4aeff4feb..4f3d07275fb 100644 --- a/libavcodec/bitstream_template.h

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/magicyuv: add vlc multi support

2023-10-22 Thread Michael Niedermayer
On Sun, Oct 22, 2023 at 11:21:28AM +0200, Paul B Mahol wrote: > On Sun, Oct 22, 2023 at 9:06 AM Michael Niedermayer > wrote: > > > On Sun, Oct 22, 2023 at 12:56:40AM +0200, Michael Niedermayer wrote: > > > On Sat, Oct 21, 2023 at 11:00:19AM +0200, Paul B Mahol wrote: > > > > On Sat, Oct 21, 2023

Re: [FFmpeg-devel] [PATCH] libavcodec/amfenc: Add more pixel formats support

2023-10-22 Thread Mark Thompson
On 20/10/2023 09:13, Evgeny Pavlov wrote: On Tue, Jul 18, 2023 at 10:32 AM Evgeny Pavlov wrote: This commit adds BGRA, RGBA and ARGB pixel formats for AMF encoders Signed-off-by: Evgeny Pavlov --- libavcodec/amfenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[FFmpeg-devel] [PATCH 2/2] lavfi/ddagrab: Fix 8-bit BGR output to not advertise an alpha component

2023-10-22 Thread Mark Thompson
There is never an alpha component here, so the actual format is BGR0 rather than BGRA. This fixes cases which maintain the alpha component and therefore generate unexpected results. --- E.g. fixes download and encode with PNG to make an RGB PNG as expected, rather than an RGBA PNG with nothing

[FFmpeg-devel] [PATCH 1/2] hwcontext_d3d11: Add BGR0 support

2023-10-22 Thread Mark Thompson
The 8-bit four-component DXGI container is also used for three-component RGB without alpha. --- This list is only used for AV->DXGI mapping, so it doesn't matter that there are duplicate DXGI formats in the list. libavutil/hwcontext_d3d11va.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/cbs: Do not assert on traces beyond 255 bits

2023-10-22 Thread Mark Thompson
On 22/10/2023 01:35, Michael Niedermayer wrote: Fixes: Assertion length < 256 failed at libavcodec/cbs.c:517 Fixes: 62673/clusterfuzz-testcase-minimized-ffmpeg_BSF_TRACE_HEADERS_fuzzer-6490971837431808 Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH] amfenc: Use a blocking call instead of sleeping and polling

2023-10-22 Thread Mark Thompson
On 19/10/2023 17:13, Evgeny Pavlov wrote: On Wed, Oct 18, 2023 at 10:36 PM Mark Thompson wrote: --- On 17/10/2023 18:11, Evgeny Pavlov wrote: The reason for using av_usleep() here is that AMF API doesn’t provide an API for explicit wait. There are two modes to get output from encoder: 1.

Re: [FFmpeg-devel] [PATCH] lavc/webp: Remove frame threading

2023-10-22 Thread Andreas Rheinhardt
Thilo Borgmann via ffmpeg-devel: > Revealed by the patch to support animated webp, the current > frame threading implementation contains a data race. No, it doesn't: The current implementation does not call ff_thread_finish_setup() in vp8.c for webp: if

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/rv60: RealVideo 6.0 decoder

2023-10-22 Thread Andreas Rheinhardt
Peter Ross: > --- > diff --git a/libavformat/matroska.c b/libavformat/matroska.c > index 5878594e68..1674806f29 100644 > --- a/libavformat/matroska.c > +++ b/libavformat/matroska.c > @@ -95,6 +95,7 @@ const CodecTags ff_mkv_codec_tags[]={ > {"V_REAL/RV20" , AV_CODEC_ID_RV20}, >

Re: [FFmpeg-devel] [PATCH 1/4] lavc/aarch64: new optimization for 8-bit hevc_epel_v

2023-10-22 Thread Logan.Lyu
Hi, Martin, Could you please review these patches and let me know if there are any changes needed. Thanks. Logan Lyu 在 2023/10/14 16:45, Logan.Lyu 写道: checkasm bench: put_hevc_epel_v4_8_c: 79.9 put_hevc_epel_v4_8_neon: 25.7 put_hevc_epel_v6_8_c: 151.4 put_hevc_epel_v6_8_neon: 46.4

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h266: fix SPS VUI extension data leak

2023-10-22 Thread Andreas Rheinhardt
Nuo Mi: > Fixes: VUI extension leak > Fixes: > 63004/clusterfuzz-testcase-minimized-ffmpeg_BSF_VVC_METADATA_fuzzer-4928832253329408 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > --- > libavcodec/cbs_h2645.c | 10 +- > 1 file

[FFmpeg-devel] [PATCH] lavc/webp: Remove frame threading

2023-10-22 Thread Thilo Borgmann via ffmpeg-devel
Revealed by the patch to support animated webp, the current frame threading implementation contains a data race. vp8_lossy_decode_frame() calls ff_vp8_decode_frame() wich calls ff_thread_finish_setup() to sync its internal slice threading. The race is happens because vp8_lossy_decode_frame() has

Re: [FFmpeg-devel] [PATCH] avfilter/vidstab: add option for file format specification

2023-10-22 Thread Gyan Doshi
On 2023-10-22 05:36 pm, Timo Rothenpieler wrote: On 22.10.2023 13:57, Gyan Doshi wrote: On 2023-10-22 05:04 pm, Timo Rothenpieler wrote: On 22.10.2023 13:24, Gyan Doshi wrote: The vidstab library added support in Nov 2020 for writing/reading the transforms data in binary in addition to

Re: [FFmpeg-devel] [PATCH] avfilter/vidstab: add option for file format specification

2023-10-22 Thread Timo Rothenpieler
On 22.10.2023 13:57, Gyan Doshi wrote: On 2023-10-22 05:04 pm, Timo Rothenpieler wrote: On 22.10.2023 13:24, Gyan Doshi wrote: The vidstab library added support in Nov 2020 for writing/reading the transforms data in binary in addition to ASCII. The library default was changed to binary

Re: [FFmpeg-devel] [PATCH] avfilter/vidstab: add option for file format specification

2023-10-22 Thread Gyan Doshi
On 2023-10-22 05:04 pm, Timo Rothenpieler wrote: On 22.10.2023 13:24, Gyan Doshi wrote: The vidstab library added support in Nov 2020 for writing/reading the transforms data in binary in addition to ASCII. The library default was changed to binary format but no changes were made to the

[FFmpeg-devel] [PATCH v2] avfilter/vidstab: add option for file format specification

2023-10-22 Thread Gyan Doshi
The vidstab library added support in Nov 2020 for writing/reading the transforms data in binary in addition to ASCII. The library default was changed to binary format but no changes were made to the AVfilters resulting in data file for writing or reading being always opened as text. This

Re: [FFmpeg-devel] [PATCH] avfilter/vidstab: add option for file format specification

2023-10-22 Thread Timo Rothenpieler
On 22.10.2023 13:24, Gyan Doshi wrote: The vidstab library added support in Nov 2020 for writing/reading the transforms data in binary in addition to ASCII. The library default was changed to binary format but no changes were made to the AVfilters resulting in data file for writing or reading

[FFmpeg-devel] [PATCH] avfilter/vidstab: add option for file format specification

2023-10-22 Thread Gyan Doshi
The vidstab library added support in Nov 2020 for writing/reading the transforms data in binary in addition to ASCII. The library default was changed to binary format but no changes were made to the AVfilters resulting in data file for writing or reading being always opened as text. This

[FFmpeg-devel] [PATCH] fftools: Check HAVE_GETSTDHANDLE before using GetStdHandle

2023-10-22 Thread Martin Storsjö
GetStdHandle is unavailable outside of the desktop API subset. This didn't use to be a problem with earlier WinSDKs, as kbhit also used to be available only for desktop apps, and this whole section is wrapped in #if HAVE_KBHIT. With newer WinSDKs, kbhit() is available also for non-desktop apps,

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/magicyuv: add vlc multi support

2023-10-22 Thread Paul B Mahol
On Sun, Oct 22, 2023 at 9:06 AM Michael Niedermayer wrote: > On Sun, Oct 22, 2023 at 12:56:40AM +0200, Michael Niedermayer wrote: > > On Sat, Oct 21, 2023 at 11:00:19AM +0200, Paul B Mahol wrote: > > > On Sat, Oct 21, 2023 at 2:13 AM Michael Niedermayer < > mich...@niedermayer.cc> > > > wrote: >

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/magicyuv: add vlc multi support

2023-10-22 Thread Michael Niedermayer
On Sun, Oct 22, 2023 at 12:56:40AM +0200, Michael Niedermayer wrote: > On Sat, Oct 21, 2023 at 11:00:19AM +0200, Paul B Mahol wrote: > > On Sat, Oct 21, 2023 at 2:13 AM Michael Niedermayer > > wrote: > > > > > On Wed, Sep 06, 2023 at 10:19:27PM +, Paul B Mahol wrote: > > > > ffmpeg | branch: