Re: [FFmpeg-devel] [PATCH] Extract av_hls_codec_attr

2023-11-02 Thread Zhao Zhili
> 在 2023年11月3日,下午1:21,Romain Beauxis 写道: > > Le mar. 31 oct. 2023 à 11:47, Zhao Zhili a écrit : >> >> >>> From: ffmpeg-devel On Behalf Of Romain >>> Beauxis >>> Sent: 2023年10月30日 9:06 >>> To: ffmpeg-devel@ffmpeg.org >>> Cc: Romain Beauxis >>> Subject: [FFmpeg-devel] [PATCH] Extract

Re: [FFmpeg-devel] [PATCH] Extract av_hls_codec_attr

2023-11-02 Thread Romain Beauxis
Le mar. 31 oct. 2023 à 11:47, Zhao Zhili a écrit : > > > > From: ffmpeg-devel On Behalf Of Romain > > Beauxis > > Sent: 2023年10月30日 9:06 > > To: ffmpeg-devel@ffmpeg.org > > Cc: Romain Beauxis > > Subject: [FFmpeg-devel] [PATCH] Extract av_hls_codec_attr > > > > The logic for extracting HLS

Re: [FFmpeg-devel] [PATCH] Extract av_hls_codec_attr

2023-11-02 Thread Romain Beauxis
Le mar. 31 oct. 2023 à 08:28, Michael Niedermayer a écrit : > > On Sun, Oct 29, 2023 at 08:05:50PM -0500, Romain Beauxis wrote: > > The logic for extracting HLS codec attribute strings is very useful and > > can be re-used in many different situations when working with HLS > > streams using

[FFmpeg-devel] [PATCH v2] Extract av_hls_codec_attr

2023-11-02 Thread Romain Beauxis
The logic for extracting HLS codec attribute strings is very useful and can be re-used in many different situations when working with HLS streams using libavcodec/libavformat. This patch extracts the function's code and places it into a publicly available function. Differences since v1: -

[FFmpeg-devel] [PATCH] avformat/hlsenc: Only append postfix to fmp4 init filename if not in the subdir

2023-11-02 Thread Dave Johansen
--- libavformat/hlsenc.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 4ef84c05c1..dd1a461cce 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -1931,6 +1931,30 @@ fail: return

Re: [FFmpeg-devel] [PATCH 4/4] avformat/lafdec: Check for 0 parameters

2023-11-02 Thread Sean McGovern
On Thu, Nov 2, 2023, 19:50 Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 63661/clusterfuzz-testcase-minimized-ffmpeg_dem_LAF_fuzzer-6615365234589696 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by >

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/flicvideo: consider width in copy loops

2023-11-02 Thread Sean McGovern
On Thu, Nov 2, 2023, 19:50 Michael Niedermayer wrote: > Fixes: out of array write > Fixes: > 63520/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLIC_fuzzer-4876198087622656 > Regression since: c7f8d42c12582b0626ea38117df6c9aea9fcf5b1 (was not posted > to ffmpeg-devel) > > Found-by:

Re: [FFmpeg-devel] [PATCH 2/4] avfilter/buffersink: cuddle () closer around =

2023-11-02 Thread Sean McGovern
On Thu, Nov 2, 2023, 19:50 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavfilter/buffersink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/buffersink.c b/libavfilter/buffersink.c > index 9426ded7ee3..ca2af1bc077 100644 > ---

[FFmpeg-devel] [PATCH 4/4] avformat/lafdec: Check for 0 parameters

2023-11-02 Thread Michael Niedermayer
Fixes: Timeout Fixes: 63661/clusterfuzz-testcase-minimized-ffmpeg_dem_LAF_fuzzer-6615365234589696 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/lafdec.c | 4 +++- 1 file changed, 3

[FFmpeg-devel] [PATCH 3/4] avcodec/flicvideo: consider width in copy loops

2023-11-02 Thread Michael Niedermayer
Fixes: out of array write Fixes: 63520/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLIC_fuzzer-4876198087622656 Regression since: c7f8d42c12582b0626ea38117df6c9aea9fcf5b1 (was not posted to ffmpeg-devel) Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH 2/4] avfilter/buffersink: cuddle () closer around =

2023-11-02 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavfilter/buffersink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/buffersink.c b/libavfilter/buffersink.c index 9426ded7ee3..ca2af1bc077 100644 --- a/libavfilter/buffersink.c +++ b/libavfilter/buffersink.c @@ -293,7

[FFmpeg-devel] [PATCH 1/4] avfilter/framesync: cuddle () closer around =

2023-11-02 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavfilter/framesync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/framesync.c b/libavfilter/framesync.c index c748262ba6a..6cb4b21fed8 100644 --- a/libavfilter/framesync.c +++ b/libavfilter/framesync.c @@ -288,7 +288,7

Re: [FFmpeg-devel] [PATCH v3 6/8] avfilter/vf_scale: simplify color matrix parsing logic

2023-11-02 Thread Michael Niedermayer
On Tue, Oct 31, 2023 at 03:54:48PM +0100, Niklas Haas wrote: > From: Niklas Haas > > No need to write a custom string parser when we can just use an integer > option with preset values. The various bits of fallback logic are wholly > redundant with equivalent logic already inside

Re: [FFmpeg-devel] [PATCH v3 2/8] swscale: don't omit ff_sws_init_range_convert for high-bit

2023-11-02 Thread Michael Niedermayer
On Tue, Oct 31, 2023 at 03:54:44PM +0100, Niklas Haas wrote: > From: Niklas Haas > > This was a complete hack seemingly designed to work around a different > bug, which was fixed in the previous commit. As such, there is no more > reason not to do this, as it simply breaks changing color range

Re: [FFmpeg-devel] [PATCH] lavc/opusdsp: rewrite R-V V postfilter

2023-11-02 Thread Rémi Denis-Courmont
Le torstaina 2. marraskuuta 2023, 23.07.03 EET Rémi Denis-Courmont a écrit : > This uses a more traditional approach allowing up processing of up to > period minus two elements per iteration. This also allows the algorithm > to work for all and any vector length. > > As the T-Head C908 device

[FFmpeg-devel] [PATCH] lavc/opusdsp: rewrite R-V V postfilter

2023-11-02 Thread Rémi Denis-Courmont
This uses a more traditional approach allowing up processing of up to period minus two elements per iteration. This also allows the algorithm to work for all and any vector length. As the T-Head C908 device under test can load 16 elements loop, there is unsurprisingly a little performance drop

Re: [FFmpeg-devel] [PATCH] avfillter/buffersrc: activate and EOF fix

2023-11-02 Thread Tristan Matthews
On Thu, Nov 2, 2023 at 6:10 AM Paul B Mahol wrote: > > On Thu, Nov 2, 2023 at 11:03 AM Nicolas George wrote: > > > Paul B Mahol (12023-11-02): > > > I analyzed it already, It is very sorry state of libavfilter that > > buffersrc > > > keeps sending frames to EOF filtergraph. > > > > So, Paul, I

Re: [FFmpeg-devel] [ANNOUNCE] upcoming GA vote

2023-11-02 Thread Michael Niedermayer
On Sun, Oct 29, 2023 at 10:33:12AM +0100, Anton Khirnov wrote: > Hi all, > updating the answers according to received comments: > > vote question (unchanged): > How do we update the list of active members of the general assembly? > > Available answers: > * twice a year (1st Jan & 1st July,

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: extend available actions on signal loss

2023-11-02 Thread Michael Riedl
> Hi Michael, > > I haven't tried your patch, but a quick review suggests that while > you've declared the option as deprecated that it no longer works. > Presumably somewhere in there should be a line of code that says > something like "if (ctx->draw_bars == 0) then ctx->signal_loss_action > =

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: extend available actions on signal loss

2023-11-02 Thread Devin Heitmueller
Hi Michael, I haven't tried your patch, but a quick review suggests that while you've declared the option as deprecated that it no longer works. Presumably somewhere in there should be a line of code that says something like "if (ctx->draw_bars == 0) then ctx->signal_loss_action =

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: extend available actions on signal loss

2023-11-02 Thread Michael Riedl
On 9/25/23 13:58, Michael Riedl wrote: > Deprecate the option 'draw_bars' in favor of the new option > 'signal_loss_action', > which controls the behavior when the input signal is not available > (including the behavior previously available through draw_bars). > The default behavior remains

[FFmpeg-devel] [PATCH] avutil/hwcontext_vulkan: get VkFormatFeatureFlagBits2

2023-11-02 Thread Víctor Manuel Jáquez Leal
Rather than the VkFormatFeatureFlagBits enum Signed-off-by: Víctor Manuel Jáquez Leal --- libavutil/hwcontext_vulkan.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 8481427b42..506a218a42 100644

Re: [FFmpeg-devel] [PATCH] avfillter/buffersrc: activate and EOF fix

2023-11-02 Thread Nicolas George
Paul B Mahol (12023-11-02): > I do not understand. What proof you need? That the patch is correct and necessary. First, explain how the current triggers the problem. In the commit message. -- Nicolas George ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] avfillter/buffersrc: activate and EOF fix

2023-11-02 Thread Paul B Mahol
On Thu, Nov 2, 2023 at 11:03 AM Nicolas George wrote: > Paul B Mahol (12023-11-02): > > I analyzed it already, It is very sorry state of libavfilter that > buffersrc > > keeps sending frames to EOF filtergraph. > > So, Paul, I will explain this to you one last time. > > Remember high school,

Re: [FFmpeg-devel] [PATCH] avfillter/buffersrc: activate and EOF fix

2023-11-02 Thread Nicolas George
Paul B Mahol (12023-11-02): > I analyzed it already, It is very sorry state of libavfilter that buffersrc > keeps sending frames to EOF filtergraph. So, Paul, I will explain this to you one last time. Remember high school, when you had math test, and if you just gave the result you got almost no

Re: [FFmpeg-devel] [PATCH] avfillter/buffersrc: activate and EOF fix

2023-11-02 Thread Paul B Mahol
On Thu, Nov 2, 2023 at 10:50 AM Nicolas George wrote: > Paul B Mahol (12023-11-02): > > You applied both patches? At correct order? > > Duh. > There are two patches, OOM is fixed only if both are applied. > > > I probably should merge patches into single one. > > You need to analyze the bug

Re: [FFmpeg-devel] [PATCH] avfillter/buffersrc: activate and EOF fix

2023-11-02 Thread Nicolas George
Paul B Mahol (12023-11-02): > You applied both patches? At correct order? Duh. > I probably should merge patches into single one. You need to analyze the bug and produce a proof that it is correct. A change to activate is not acceptable without a proof that it is necessary. The proof should be

Re: [FFmpeg-devel] [PATCH] avfillter/buffersrc: activate and EOF fix

2023-11-02 Thread Paul B Mahol
On Wed, Nov 1, 2023 at 3:13 PM Nicolas George wrote: > Paul B Mahol (12023-11-01): > > It fixes it for me, ffmpeg no longer keeps sending frames to EOF > > filtergraph. > > And no more memory is allocated and never freed. > > And that is just LUCK because you changed unrelated things. You have

Re: [FFmpeg-devel] [PATCH v2] lavc/libaribcaption: Fix mistake in document decoders.texi

2023-11-02 Thread zheng qian
On Thu, Nov 2, 2023 at 5:40 PM Gyan Doshi wrote: > > > > On 2023-11-02 01:21 am, Gyan Doshi wrote: > > > > > > On 2023-11-01 08:54 pm, zheng qian wrote: > >> Fix the mistake in the description of `-caption_encoding > >> encoding_scheme` option. > > Will fix commit message and push. > > Pushed as

Re: [FFmpeg-devel] [PATCH v2] lavc/libaribcaption: Fix mistake in document decoders.texi

2023-11-02 Thread Gyan Doshi
On 2023-11-02 01:21 am, Gyan Doshi wrote: On 2023-11-01 08:54 pm, zheng qian wrote: Fix the mistake in the description of `-caption_encoding encoding_scheme` option. Will fix commit message and push. Pushed as 4dbfb52230c4993e58598386ac79b964589dc00e and

Re: [FFmpeg-devel] FFmpeg at NAB 2024

2023-11-02 Thread Rémi Denis-Courmont
Hi, FWIW, FFmpeg will most probably be granted a free community booth at the next SCaLE in 21x a month earlier also in South-Western USA. If this unfolds as it usually does, we will get confirmation in January. There are no hidden costs *there*. But of course it's a very different crowd of