[FFmpeg-devel] [PATCH] libavcodec/mlpdec: add missing correction to ch_layout when downmixing

2023-11-25 Thread Geoffrey McRae via ffmpeg-devel
This fixes corrupted audio for applications relying on ch_layout when codec downmixing is active. Signed-off-by: Geoffrey McRae --- libavcodec/mlpdec.c | 17 + 1 file changed, 17 insertions(+) diff --git a/libavcodec/mlpdec.c b/libavcodec/mlpdec.c index f1524b95a6..18e0f47864

[FFmpeg-devel] [PATCH] libavcodec/dcadec: adjust the `ch_layout` when downmix is active

2023-11-25 Thread Geoffrey McRae via ffmpeg-devel
Applications making use of this codec with the `downmix` option are segfaulting unless the `ch_layout` is overridden after `avcodec_open2` as can be seen in projects like MythTV[1] This patch fixes this by overriding the ch_layout as done in other decoders such as AC3. 1:

[FFmpeg-devel] [PATCH 7/9] avcodec/packet: add IAMF Parameters side data types

2023-11-25 Thread James Almer
Signed-off-by: James Almer --- libavcodec/avpacket.c | 3 +++ libavcodec/packet.h | 24 2 files changed, 27 insertions(+) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index e29725c2d2..0f8c9b77ae 100644 --- a/libavcodec/avpacket.c +++

[FFmpeg-devel] [PATCH 9/9] avformat: Immersive Audio Model and Formats muxer

2023-11-25 Thread James Almer
Signed-off-by: James Almer --- libavformat/Makefile |1 + libavformat/allformats.c |1 + libavformat/iamfenc.c| 1091 ++ 3 files changed, 1093 insertions(+) create mode 100644 libavformat/iamfenc.c diff --git a/libavformat/Makefile

[FFmpeg-devel] [PATCH 6/9] ffmpeg: add support for muxing AVStreamGroups

2023-11-25 Thread James Almer
Starting with IAMF support. Signed-off-by: James Almer --- fftools/ffmpeg.h | 2 + fftools/ffmpeg_mux_init.c | 327 ++ fftools/ffmpeg_opt.c | 2 + 3 files changed, 331 insertions(+) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index

[FFmpeg-devel] [PATCH 5/9] avformat: introduce AVStreamGroup

2023-11-25 Thread James Almer
Signed-off-by: James Almer --- doc/fftools-common-opts.texi | 17 +++- libavformat/avformat.c | 185 ++- libavformat/avformat.h | 169 libavformat/dump.c | 147 +++-

[FFmpeg-devel] [PATCH 8/9] avformat: Immersive Audio Model and Formats demuxer

2023-11-25 Thread James Almer
Signed-off-by: James Almer --- libavformat/Makefile |1 + libavformat/allformats.c |1 + libavformat/iamf.c | 1149 ++ libavformat/iamf.h | 167 ++ libavformat/iamfdec.c| 495 5 files changed, 1813

[FFmpeg-devel] [PATCH 4/9] avutil: introduce an Immersive Audio Model and Formats API

2023-11-25 Thread James Almer
Signed-off-by: James Almer --- libavutil/Makefile | 2 + libavutil/iamf.c | 582 + libavutil/iamf.h | 377 + 3 files changed, 961 insertions(+) create mode 100644 libavutil/iamf.c create mode 100644 libavutil/iamf.h

[FFmpeg-devel] [PATCH 3/9] avformat/aviobuf: add ffio_read_leb() and ffio_write_leb()

2023-11-25 Thread James Almer
Signed-off-by: James Almer --- libavformat/avio_internal.h | 4 libavformat/aviobuf.c | 37 + 2 files changed, 41 insertions(+) diff --git a/libavformat/avio_internal.h b/libavformat/avio_internal.h index bd58499b64..6b6cd6e8b3 100644 ---

[FFmpeg-devel] [PATCH 2/9] avcodec/get_bits: add get_leb()

2023-11-25 Thread James Almer
Signed-off-by: James Almer --- libavcodec/bitstream.h | 2 ++ libavcodec/bitstream_template.h | 22 ++ libavcodec/get_bits.h | 23 +++ 3 files changed, 47 insertions(+) diff --git a/libavcodec/bitstream.h b/libavcodec/bitstream.h index

[FFmpeg-devel] [PATCH 1/9] avutil/mem: add av_dynarray2_add_nofree

2023-11-25 Thread James Almer
Signed-off-by: James Almer --- libavutil/mem.c | 17 + libavutil/mem.h | 32 +--- 2 files changed, 46 insertions(+), 3 deletions(-) diff --git a/libavutil/mem.c b/libavutil/mem.c index 36b8940a0c..bd37710968 100644 --- a/libavutil/mem.c +++

[FFmpeg-devel] [PATCH v5 0/9] avformat: introduce AVStreamGroup

2023-11-25 Thread James Almer
Addressed Marton's comments regarding documentation for the stream specifier changes, moved the IAMF API to libavutil as packet side data can't depend on structs and API defined in libavformat (And future bsfs may make use of it too), and moved the leb reading and writing functions to get_bits and

Re: [FFmpeg-devel] [PATCH] mips/ac3dsp_mips: add missing stddef.h header include

2023-11-25 Thread Sean McGovern
On Sat, Nov 25, 2023, 19:52 James Almer wrote: > On 11/25/2023 9:35 PM, Michael Niedermayer wrote: > > On Fri, Nov 24, 2023 at 08:59:19PM -0300, James Almer wrote: > >> Fixes compilation failures after > 567c67c6c8cb9be083f56198bfa979e4bda84c99. > >> > >> Signed-off-by: James Almer > >> --- >

Re: [FFmpeg-devel] [PATCH] mips/ac3dsp_mips: add missing stddef.h header include

2023-11-25 Thread James Almer
On 11/25/2023 9:35 PM, Michael Niedermayer wrote: On Fri, Nov 24, 2023 at 08:59:19PM -0300, James Almer wrote: Fixes compilation failures after 567c67c6c8cb9be083f56198bfa979e4bda84c99. Signed-off-by: James Almer --- libavcodec/mips/ac3dsp_mips.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [FFmpeg-devel] [PATCH] mips/ac3dsp_mips: add missing stddef.h header include

2023-11-25 Thread Michael Niedermayer
On Fri, Nov 24, 2023 at 08:59:19PM -0300, James Almer wrote: > Fixes compilation failures after 567c67c6c8cb9be083f56198bfa979e4bda84c99. > > Signed-off-by: James Almer > --- > libavcodec/mips/ac3dsp_mips.c | 2 ++ > 1 file changed, 2 insertions(+) LGTM thx [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: Only log the EncoderID on macOS >= 10.13.

2023-11-25 Thread David Bohman
On Fri, Nov 24, 2023 at 8:09 PM Zhao Zhili wrote: > > > > > On Nov 25, 2023, at 05:32, David Bohman wrote: > > > > On Fri, Nov 24, 2023 at 9:01 AM Zhao Zhili wrote: > >> > >>> On Nov 24, 2023, at 23:40, David Bohman wrote: > >>> > >>> This is to fix a build failure on macOS < 10.13. > >>> > >>

[FFmpeg-devel] [PATCH] avfilter/vf_bwdif: consider chroma subsampling when enforcing minimum dimensions

2023-11-25 Thread Cosmin Stejerean via ffmpeg-devel
Fixes #10688 Signed-off-by: Cosmin Stejerean --- libavfilter/vf_bwdif.c | 12 1 file changed, 12 insertions(+) diff --git a/libavfilter/vf_bwdif.c b/libavfilter/vf_bwdif.c index 137cd5ef13..bce11c39f7 100644 --- a/libavfilter/vf_bwdif.c +++ b/libavfilter/vf_bwdif.c @@ -197,6

[FFmpeg-devel] [PATCH 13/13 v2] fftools/ffmpeg: convert to a threaded architecture

2023-11-25 Thread Anton Khirnov
Change the main loop and every component (demuxers, decoders, filters, encoders, muxers) to use the previously added transcode scheduler. Every instance of every such component was already running in a separate thread, but now they can actually run in parallel. Changes the results of

Re: [FFmpeg-devel] [PATCH 05/13] fftools/ffmpeg_filter: move filtering to a separate thread

2023-11-25 Thread James Almer
On 11/24/2023 7:56 PM, Michael Niedermayer wrote: On Thu, Nov 23, 2023 at 08:15:00PM +0100, Anton Khirnov wrote: As previously for decoding, this is merely "scaffolding" for moving to a fully threaded architecture and does not yet make filtering truly parallel - the main thread will currently

[FFmpeg-devel] [PATCH 05/13 v2] fftools/ffmpeg_filter: move filtering to a separate thread

2023-11-25 Thread Anton Khirnov
As previously for decoding, this is merely "scaffolding" for moving to a fully threaded architecture and does not yet make filtering truly parallel - the main thread will currently wait for the filtering thread to finish its work before continuing. That will change in future commits after encoders

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2023-11-25 Thread Paul B Mahol
On Sun, Oct 25, 2020 at 1:41 PM Paul B Mahol wrote: > > > On Thu, Apr 25, 2019 at 9:14 PM Nicolas George wrote: > >> Paul B Mahol (12019-04-25): >> > Not really, it works with 2x/3x/4x/5x.. sample rate or 1/2 / 1/3 / 1/4 >> / 1/5 >> > o sample rate in other direction. >> >> I do not think so:

Re: [FFmpeg-devel] [PATCH 1/5] avformat: introduce AVStreamGroup

2023-11-25 Thread James Almer
On 11/21/2023 6:57 PM, Marton Balint wrote: On Tue, 21 Nov 2023, James Almer wrote: Signed-off-by: James Almer --- libavformat/avformat.c | 178 +++-- libavformat/avformat.h | 163 + libavformat/dump.c |  33 ++--

[FFmpeg-devel] [IMPORTANT] Serious fault in bwdif filter

2023-11-25 Thread Paul B Mahol
See related trac ticket in trac.ffmpeg.org and fix it ASAP! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject