Re: [FFmpeg-devel] [PATCH] avfilter/select: initialize prev_selected_n to NAN

2023-12-09 Thread Gyan Doshi
On 2023-12-10 06:03 am, Stefano Sabatini wrote: On date Friday 2023-12-08 13:05:43 +0530, Gyan Doshi wrote: As per the doc, prev_selected_n should be NAN at the start. However, this was never set. --- libavfilter/f_select.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [FFmpeg-devel] [PATCH] [WIP] [RFC] dvdvideo: initial contribution (DVD demuxer)

2023-12-09 Thread Marth64
> What is a yuv-to-rgb function doing inside a dvd-video demuxer? DVD subtitle palette is YUV. However, when stored in modern formats such as matroska or MP4, the "convention" is to store in RGB. In fact, mp4/mov muxer has a similar routine. > This function is pointless. I'm opening the MPEG-PS

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2023-12-09 Thread Marth64
Thank you! On Sat, Dec 9, 2023 at 9:06 PM Leo Izen wrote: > On 12/9/23 20:35, Marth64 wrote: > > --- > > doc/bitstream_filters.texi | 18 ++ > > 1 file changed, 18 insertions(+) > > > > Make sure when you generate the second version of a patch with git > format-patch you pass

Re: [FFmpeg-devel] [PATCH] [WIP] [RFC] dvdvideo: initial contribution (DVD demuxer)

2023-12-09 Thread Marth64
Hi Leo, Thank you for the feedback and review. I will work through the code style issues. Please do let me know what else you find - I will fix. Here is some responses on the conceptual issues, > my biggest question is why this is not a protocol that produces an mpeg-ps stream. Protocol handler

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2023-12-09 Thread Leo Izen
On 12/9/23 20:35, Marth64 wrote: --- doc/bitstream_filters.texi | 18 ++ 1 file changed, 18 insertions(+) Make sure when you generate the second version of a patch with git format-patch you pass the -v2 argument, e.g. git format-patch -v2 -o outgoing/ master Otherwise

[FFmpeg-devel] [PATCH] avformat/options_table, doc/formats: clarify meaning of igndts as per definition in avformat.h

2023-12-09 Thread Marth64
This confused me for a long time, hopefully this is helpful to others. The definition in avformat.h says "Ignore DTS on frames that contain both DTS & PTS" Signed-off-by: Marth64 --- doc/formats.texi| 2 +- libavformat/options_table.h | 2 +- 2 files changed, 2 insertions(+), 2

Re: [FFmpeg-devel] [PATCH] [WIP] [RFC] dvdvideo: initial contribution (DVD demuxer)

2023-12-09 Thread Leo Izen
On 12/9/23 05:06, Marth64 wrote: Hello, I am happy to share a DVD demuxer for ffmpeg powered by libdvdread and libdvdnav. I have been working on this on/off throughout the year and think it is in a good spot to share at the ML now. This was a major learning experience for me in many ways and

[FFmpeg-devel] [PATCH] doc/ffprobe: add a useful one-liner example to get essential input information as JSON

2023-12-09 Thread Marth64
Signed-off-by: Marth64 This could be useful for folks who are just learning ffmpeg or have simple needs for parsing input information as JSON. --- doc/ffprobe.texi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/ffprobe.texi b/doc/ffprobe.texi index b74ff650ac..ed88e619f6 100644

Re: [FFmpeg-devel] [PATCH] [WIP] [RFC] dvdvideo: initial contribution (DVD demuxer)

2023-12-09 Thread Marth64
Realizing this late, but in full transparency there are some portions adapted from VLC player (which is LGPL), namely chapter and time conversions, and small number of lines adopted from Handbrake (which is GPL), specifically one if statement validation and a constant value. For the latter I will

[FFmpeg-devel] [PATCH] ffmpeg_opt: clarify that -ab is deprecated

2023-12-09 Thread Marth64
diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 304471dd03..837bef8161 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -1722,7 +1722,7 @@ const OptionDef options[] = { OPT_SPEC | OPT_OUTPUT, { .off =

[FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2023-12-09 Thread Marth64
--- doc/bitstream_filters.texi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index c63c20370f..d2ad6e78ff 100644 --- a/doc/bitstream_filters.texi +++ b/doc/bitstream_filters.texi @@ -213,6 +213,24 @@ To remove all

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2023-12-09 Thread Marth64
Appreciate the good feedback, will update. Thank you. On Sat, Dec 9, 2023 at 6:53 PM Stefano Sabatini wrote: > On date Saturday 2023-12-09 13:31:13 -0600, Marth64 wrote: > > --- > > doc/bitstream_filters.texi | 17 + > > 1 file changed, 17 insertions(+) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2023-12-09 Thread Stefano Sabatini
On date Saturday 2023-12-09 13:31:13 -0600, Marth64 wrote: > --- > doc/bitstream_filters.texi | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi > index 145aa8684e..b01ede0c93 100644 > ---

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: add setts example

2023-12-09 Thread Stefano Sabatini
On date Saturday 2023-12-09 13:23:04 -0600, Marth64 wrote: > --- > doc/bitstream_filters.texi | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi > index c63c20370f..145aa8684e 100644 > --- a/doc/bitstream_filters.texi > +++

Re: [FFmpeg-devel] [PATCH] doc/ffmpeg: AV_FMT_DISCONT typo should be AVFMT_TS_DISCONT

2023-12-09 Thread Stefano Sabatini
On date Saturday 2023-12-09 13:17:55 -0600, Marth64 wrote: > --- > doc/ffmpeg.texi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi > index 145cbb1032..6bcedd76d5 100644 > --- a/doc/ffmpeg.texi > +++ b/doc/ffmpeg.texi > @@ -1860,7

Re: [FFmpeg-devel] [PATCH] avfilter/select: initialize prev_selected_n to NAN

2023-12-09 Thread Stefano Sabatini
On date Friday 2023-12-08 13:05:43 +0530, Gyan Doshi wrote: > As per the doc, prev_selected_n should be NAN at the start. > However, this was never set. > --- > libavfilter/f_select.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavfilter/f_select.c b/libavfilter/f_select.c > index

Re: [FFmpeg-devel] [PATCH] doc/filters: expand documentation on libvmaf filter

2023-12-09 Thread Stefano Sabatini
On date Friday 2023-12-08 18:47:28 +, ffmpeg-devel Mailing List wrote: > Attached. > From e2b98c2dec1248f5000a9291bd6f1177de2a4d0f Mon Sep 17 00:00:00 2001 > From: nilfm > Date: Fri, 8 Dec 2023 14:28:12 + > Subject: [PATCH] doc/filters: expand documentation on libvmaf filter > >

[FFmpeg-devel] [PATCH] lavc/libopenh264: Drop openh264 runtime version checks

2023-12-09 Thread Kalev Lember
With the way the runtime checks are currently set up, every single openh264 release, no matter how minor, is considered an ABI break and requires ffmpeg recompilation. This is unnecessarily strict because it doesn't allow downstream distributions to ship any openh264 bug fix version updates

Re: [FFmpeg-devel] [PATCH] lavc/libopenh264: Drop openh264 runtime version checks

2023-12-09 Thread Kalev Lember
On Fri, Dec 8, 2023 at 9:34 PM Martin Storsjö wrote: > If that was when the soname version was introduced, that sounds reasonable > - since then, there's at least an intent not to break it (even if mistakes > always can happen). > Yep, 1.3.0 is when the soname version was introduced. Let's go

Re: [FFmpeg-devel] [PATCH 0/1] fate/jpegxl: add multiframe permuted TOC image parser

2023-12-09 Thread Thilo Borgmann via ffmpeg-devel
Am 09.12.23 um 20:49 schrieb Leo Izen: This patch requires a sample that hasn't been uploaded yet. It can be found at [1] and it should be placed at jxl/orange.jxl once uploaded. It's 262k, which is not very large, but large enough that I did not want to attach it to this email. [1]:

[FFmpeg-devel] [PATCH 1/1] fate/jpegxl: add multiframe permuted TOC image parser test

2023-12-09 Thread Leo Izen
This test verifies the parser's handling of multiframe JXL files that have an entropy-encoded permuted table of contents for each frame. The testcase is actually six JXL codestreams concatenated together, and the parser needs to be able to find the boundaries. Signed-off-by: Leo Izen ---

[FFmpeg-devel] [PATCH 0/1] fate/jpegxl: add multiframe permuted TOC image parser

2023-12-09 Thread Leo Izen
This patch requires a sample that hasn't been uploaded yet. It can be found at [1] and it should be placed at jxl/orange.jxl once uploaded. It's 262k, which is not very large, but large enough that I did not want to attach it to this email. [1]: https://buzo.us/O.jxl sample sha256sum:

Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: inform user about -b:a and -b:v instead of legacy form

2023-12-09 Thread Marth64
Roger, will update. Thanks! On Sat, Dec 9, 2023 at 1:25 PM James Almer wrote: > On 12/9/2023 4:10 PM, Marth64 wrote: > > --- > > fftools/ffmpeg_opt.c | 8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c > > index

[FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2023-12-09 Thread Marth64
--- doc/bitstream_filters.texi | 17 + 1 file changed, 17 insertions(+) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index 145aa8684e..b01ede0c93 100644 --- a/doc/bitstream_filters.texi +++ b/doc/bitstream_filters.texi @@ -213,6 +213,23 @@ To remove all

[FFmpeg-devel] [PATCH v3 6/7] avutil/imgutils: add new function av_image_fill_color()

2023-12-09 Thread Marton Balint
v3: added flags argument. Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavutil/imgutils.c | 6 +++--- libavutil/imgutils.h | 31 +++ libavutil/version.h | 2 +- 4 files changed, 38 insertions(+), 4 deletions(-) diff --git a/doc/APIchanges

Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: inform user about -b:a and -b:v instead of legacy form

2023-12-09 Thread James Almer
On 12/9/2023 4:10 PM, Marth64 wrote: --- fftools/ffmpeg_opt.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 304471dd03..5e50e5efa2 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -1721,8 +1721,8 @@

[FFmpeg-devel] [PATCH] doc/bitstream_filters: add setts example

2023-12-09 Thread Marth64
--- doc/bitstream_filters.texi | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index c63c20370f..145aa8684e 100644 --- a/doc/bitstream_filters.texi +++ b/doc/bitstream_filters.texi @@ -882,6 +882,11 @@ The sample rate of stream

[FFmpeg-devel] [PATCH] doc/ffmpeg: AV_FMT_DISCONT typo should be AVFMT_TS_DISCONT

2023-12-09 Thread Marth64
--- doc/ffmpeg.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 145cbb1032..6bcedd76d5 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -1860,7 +1860,7 @@ of seconds. The timestamp discontinuity correction enabled by this

[FFmpeg-devel] [PATCH] ffmpeg_opt: inform user about -b:a and -b:v instead of legacy form

2023-12-09 Thread Marth64
--- fftools/ffmpeg_opt.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 304471dd03..5e50e5efa2 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -1721,8 +1721,8 @@ const OptionDef options[] = { {

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: add qrencodesrc source

2023-12-09 Thread Stefano Sabatini
On date Thursday 2023-11-30 01:49:14 +0100, Stefano Sabatini wrote: > --- > configure | 4 + > libavfilter/Makefile| 1 + > libavfilter/allfilters.c| 1 + > libavfilter/vsrc_qrencode.c | 435 > 4 files changed, 441

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: introduce textutils

2023-12-09 Thread Stefano Sabatini
On date Sunday 2023-12-03 16:05:40 +0100, Stefano Sabatini wrote: > On date Thursday 2023-11-30 01:49:13 +0100, Stefano Sabatini wrote: > > Generalize drawtext utilities to make them usable in other filters. > > This will be needed to introduce the QR code source and filter without > > duplicating

[FFmpeg-devel] [PATCH] avdevice/audiotoolbox: silence warning with new api

2023-12-09 Thread xufuji456 via ffmpeg-devel
Building with macOS platform, the compiler has a warning: 'kAudioObjectPropertyElementMaster' is deprecated in macOS 12.0 Signed-off-by: xufuji456 <839789...@qq.com> --- libavdevice/audiotoolbox.m | 4 1 file changed, 4 insertions(+) diff --git a/libavdevice/audiotoolbox.m

[FFmpeg-devel] [PATCH] avdevice/avfoundation: replace deprecated AVCaptureDevice

2023-12-09 Thread xufuji456 via ffmpeg-devel
Building with iOS platform, the compiler has a warning: "'devicesWithMediaType:' is deprecated: first deprecated in iOS 10.0 - Use AVCaptureDeviceDiscoverySession instead" Signed-off-by: xufuji456 <839789...@qq.com> --- libavdevice/avfoundation.m | 65 +++--- 1

Re: [FFmpeg-devel] [PATCH 1/2] checkasm: test for abs_pow34

2023-12-09 Thread flow gg
To express clearly,I mean remove libavcodec/aacenc.c:1429 FF_CODEC_ENCODE_CB(aac_encode_frame) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH 1/2] checkasm: test for abs_pow34

2023-12-09 Thread flow gg
There's a strange issue: Adding tests can compile successfully on x86 and lichee4a (risc v), but it results in an error on k230. > collect2: fatal error: ld terminated with signal 9 [Killed] > compilation terminated. > > [32833.539109]

Re: [FFmpeg-devel] [PATCH 2/2] lavc/aacencdsp: R-V V abs_pow34

2023-12-09 Thread flow gg
Updated the patch to resolve conflicts, updated m4 to m8, using c908's benchmark. flow gg 于2023年11月29日周三 01:00写道: > c910: > abs_pow34_c: 24610.7 > abs_pow34_rvv_f32: 6177.7 > > (need use "[FFmpeg-devel] [PATCH 1/2] checkasm: test for abs_pow34" first) > From

[FFmpeg-devel] [PATCH] [WIP] [RFC] dvdvideo: initial contribution (DVD demuxer)

2023-12-09 Thread Marth64
Hello, I am happy to share a DVD demuxer for ffmpeg powered by libdvdread and libdvdnav. I have been working on this on/off throughout the year and think it is in a good spot to share at the ML now. This was a major learning experience for me in many ways and am open to any feedback on how I