Re: [FFmpeg-devel] [PATCH] configure: autodetect libdrm

2024-01-04 Thread Zhao Zhili
> On Dec 29, 2023, at 12:23, Xiang, Haihao > wrote: > > From: Haihao Xiang > > option kernel_driver for vaapi device creation can be used to choose the > desired device on Linux, which is more convenient than DRM render node > in a multiple-device system (e.g. Intel iGPU + AMD dGPU or

Re: [FFmpeg-devel] [PATCH] configure: autodetect libdrm

2024-01-04 Thread Xiang, Haihao
On Vr, 2023-12-29 at 12:23 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > option kernel_driver for vaapi device creation can be used to choose the > desired device on Linux, which is more convenient than DRM render node > in a multiple-device system (e.g. Intel iGPU + AMD dGPU or inverse),

Re: [FFmpeg-devel] [PATCH v2 1/5] avcodec/d3d12va_vp9: fix vp9 max_num_refs value

2024-01-04 Thread Xiang, Haihao
On Di, 2024-01-02 at 05:21 +, Xiang, Haihao wrote: > On Do, 2023-12-28 at 11:10 +0800, Tong Wu wrote: > > Previous max_num_refs was based on pp.frame_refs plus 1 and it could > > possibly > > reaches the size limit. Actually it should be the size of pp.ref_frame_map > > plus 1. > > > >

Re: [FFmpeg-devel] [PATCH v2] avcodec/d3d12va_decode: don't change the resource state if the referenced frame is the same as the current frame

2024-01-04 Thread Xiang, Haihao
On Do, 2023-12-28 at 02:35 +, Wu, Tong1 wrote: > > From: ffmpeg-devel On Behalf Of Wu > > Jianhua > > Sent: Wednesday, December 27, 2023 9:44 PM > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: [FFmpeg-devel] [PATCH v2] avcodec/d3d12va_decode: don't change

Re: [FFmpeg-devel] [PATCH 1/2] doc/ffmpeg: update the documentation about qsv device creation

2024-01-04 Thread Xiang, Haihao
On Di, 2024-01-02 at 19:00 +0300, Dennis Mungai wrote: > On Tue, 2 Jan 2024, 08:27 Xiang, Haihao, < > haihao.xiang-at-intel@ffmpeg.org> wrote: > > > On Vr, 2023-12-29 at 12:23 +0800, Xiang, Haihao wrote: > > > From: Haihao Xiang > > > > > > Signed-off-by: Haihao Xiang > > > --- > > >  

[FFmpeg-devel] [PATCH v2 2/2] doc/ffmpeg: update the documentation about vaapi device creation

2024-01-04 Thread Xiang, Haihao
From: Haihao Xiang Signed-off-by: Haihao Xiang --- doc/ffmpeg.texi | 23 +++ 1 file changed, 23 insertions(+) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index f095f402bd..8fb165c5df 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -1385,6 +1385,29 @@ If not

[FFmpeg-devel] [PATCH v2 1/2] doc/ffmpeg: update the documentation about qsv device creation

2024-01-04 Thread Xiang, Haihao
From: Haihao Xiang Signed-off-by: Haihao Xiang --- doc/ffmpeg.texi | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 7246a46d2f..f095f402bd 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -1406,16

Re: [FFmpeg-devel] [PATCH 3/3] lavc/svq1enc: R-V V ssd_int8_vs_int16

2024-01-04 Thread flow gg
One vset can be reduced, but vwsub should not be used in this case. I modified it in this reply. Rémi Denis-Courmont 于2024年1月5日周五 00:00写道: > Le lauantaina 30. joulukuuta 2023, 18.20.15 EET flow gg a écrit : > > I mistook it, seeing the vector length as the length of the vector > register > > ..

Re: [FFmpeg-devel] [PATCH v3] avcodec/cbs_vp8: Use little endian in fixed() and improve the pos check

2024-01-04 Thread Dai, Jianhui J
> -Original Message- > From: ffmpeg-devel On Behalf Of Dai, > Jianhui J > Sent: Friday, January 5, 2024 8:35 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v3] avcodec/cbs_vp8: Use little endian in > fixed() > and improve the pos check > > This commit adds value

[FFmpeg-devel] [PATCH v3] avcodec/cbs_vp8: Use little endian in fixed() and improve the pos check

2024-01-04 Thread Dai, Jianhui J
This commit adds value range checks to cbs_vp8_read_unsigned_le, migrates fixed() to use it, and enforces little-endian consistency for all read methods. The VP8 compressed header may not be byte-aligned due to boolean coding. Use bitwise comparison to prevent the potential overread. TETS:

Re: [FFmpeg-devel] [PATCH v1 2/5] avformat: add muxer support for H266/VVC

2024-01-04 Thread James Almer
On 11/3/2023 6:57 AM, Thomas Siedel wrote: Add muxer for vvcc byte stream format. Add AV_CODEC_ID_VVC to ff_mp4_obj_type. Add AV_CODEC_ID_VVC to ISO Media codec (VvcConfigurationBox vvi1, vvc1 defined in ISO/IEC 14496-15:2021). Add VvcConfigurationBox vvcC which extends FullBox type in ISO/IEC

Re: [FFmpeg-devel] [PATCH v1 2/5] avformat: add muxer support for H266/VVC

2024-01-04 Thread Nuo Mi
On Fri, Nov 3, 2023 at 5:58 PM Thomas Siedel wrote: > Add muxer for vvcc byte stream format. > Add AV_CODEC_ID_VVC to ff_mp4_obj_type. > Add AV_CODEC_ID_VVC to ISO Media codec (VvcConfigurationBox vvi1, > vvc1 defined in ISO/IEC 14496-15:2021). > Add VvcConfigurationBox vvcC which extends

Re: [FFmpeg-devel] [PATCH v9 09/13] vvcdec: add LMCS, Deblocking, SAO, and ALF filters

2024-01-04 Thread Nuo Mi
On Thu, Jan 4, 2024 at 10:53 PM James Almer wrote: > On 1/4/2024 10:57 AM, Nuo Mi wrote: > > On Thu, Jan 4, 2024 at 8:07 PM Martin Storsjö wrote: > > > >> On Thu, 4 Jan 2024, Nuo Mi wrote: > >> > >>> On Thu, Jan 4, 2024 at 2:38 AM Michael Niedermayer < > >> mich...@niedermayer.cc> > >>> wrote:

Re: [FFmpeg-devel] [PATCH] avfilter: Temporary hack to fix format negotiation for hw formats

2024-01-04 Thread Mark Thompson
On 03/01/2024 20:46, Mark Thompson wrote: hw_frames_ctx on the input link is only set when the input link is configured, which hasn't happened yet.  This temporarily hacks around the problem (in a way no worse than before the format negotiation changes) until a proper fix can be applied. ---

[FFmpeg-devel] [PATCH v2 3/3] fftools/ffmpeg_filter: log an information message about filter graph reconfigurations

2024-01-04 Thread Marton Balint
Filter graph reconfigurations can cause nontrivial issues, e.g. PTS discontinuities, so it is better to warn the user about them. v2: A recent change extended the video parameters check with color space and color range, so let's include that in the log, and also make the log message more clear.

Re: [FFmpeg-devel] [PATCH v2] avcodec/cbs_vp8: Apply clang-format and fix typos.

2024-01-04 Thread Andreas Rheinhardt
Dai, Jianhui J: > This commit applies clang-format to the source and fixes typos. > > TETS: ffmpeg -i fate-suite/vp8-test-vectors-r1/* -vcodec copy -bsf:v > trace_headers -f null - > > Signed-off-by: Jianhui Dai > --- > libavcodec/cbs_vp8.c | 52 ++-- >

Re: [FFmpeg-devel] [PATCH] doc/faq: replace non-breaking spaces (0xA0) with normal space

2024-01-04 Thread Marth64
I understand now and that makes sense. If no objections, I am happy to make a patch to revert! On Thu, Jan 4, 2024 at 1:46 AM Jean-Baptiste Kempf wrote: > > > On Wed, 3 Jan 2024, at 23:21, Marth64 wrote: > > Hi, > > I felt that it was strange in all of documentation, this is the only > >

Re: [FFmpeg-devel] [PATCH] avutil/imgutils: fix half-float representation of 0.0625

2024-01-04 Thread Marton Balint
On Thu, 28 Dec 2023, Marton Balint wrote: We don't have a 16bps float Y format, so no fate changes. Will apply. Regards, Marton Signed-off-by: Marton Balint --- libavutil/imgutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/imgutils.c

Re: [FFmpeg-devel] [PATCH v2 00/15] YUV colorspace filter negotiation

2024-01-04 Thread Dong, Ruijing via ffmpeg-devel
[AMD Official Use Only - General] I found out this change caused page fault as well. 8c7934f73ab6c568acaa47c821a6833f9145fdbb is the first bad commit commit 8c7934f73ab6c568acaa47c821a6833f9145fdbb Author: Niklas Haas Date: Sun Dec 31 13:35:03 2023 -0800 avfilter: add negotiation

Re: [FFmpeg-devel] [PATCH 3/3] lavc/svq1enc: R-V V ssd_int8_vs_int16

2024-01-04 Thread Rémi Denis-Courmont
Le lauantaina 30. joulukuuta 2023, 18.20.15 EET flow gg a écrit : > I mistook it, seeing the vector length as the length of the vector register > .. > I have modified it in this reply. Setting element size to 8-bit is unnecessary, and a widening subtraction can presumably avoid the sign

Re: [FFmpeg-devel] [PATCH v9 09/13] vvcdec: add LMCS, Deblocking, SAO, and ALF filters

2024-01-04 Thread James Almer
On 1/4/2024 10:57 AM, Nuo Mi wrote: On Thu, Jan 4, 2024 at 8:07 PM Martin Storsjö wrote: On Thu, 4 Jan 2024, Nuo Mi wrote: On Thu, Jan 4, 2024 at 2:38 AM Michael Niedermayer < mich...@niedermayer.cc> wrote: On Tue, Jan 02, 2024 at 05:47:53PM +0800, Nuo Mi wrote: [...] maintainer, and

Re: [FFmpeg-devel] [PATCH v9 09/13] vvcdec: add LMCS, Deblocking, SAO, and ALF filters

2024-01-04 Thread Nuo Mi
On Thu, Jan 4, 2024 at 8:07 PM Martin Storsjö wrote: > On Thu, 4 Jan 2024, Nuo Mi wrote: > > > On Thu, Jan 4, 2024 at 2:38 AM Michael Niedermayer < > mich...@niedermayer.cc> > > wrote: > > > >> On Tue, Jan 02, 2024 at 05:47:53PM +0800, Nuo Mi wrote: > >> [...] > >> > maintainer, and any HEVC

Re: [FFmpeg-devel] [PATCH] fftool/ffplay: avoid same name in local variable

2024-01-04 Thread Zhao Zhili
> On Dec 30, 2023, at 23:21, Zhao Zhili wrote: > >> -Original Message- >> From: ffmpeg-devel On Behalf Of xufuji456 >> via ffmpeg-devel >> Sent: 2023年12月30日 16:41 >> To: ffmpeg-devel@ffmpeg.org >> Cc: xufuji456 <839789...@qq.com> >> Subject: [FFmpeg-devel] [PATCH] fftool/ffplay:

Re: [FFmpeg-devel] [PATCH 3/3] fftools/ffmpeg_filter: log an information message about filter graph reconfigurations

2024-01-04 Thread Marton Balint
On Fri, 29 Dec 2023, Marton Balint wrote: Filter graph reconfigurations can cause nontrivial issues, e.g. PTS discontinuities, so it is better to warn the user about them. Will apply soon. Regards, Marton Signed-off-by: Marton Balint --- fftools/ffmpeg_filter.c | 50

Re: [FFmpeg-devel] [PATCH] configure: Disable inline assembly with nonlocal labels with LTO on Clang on Windows

2024-01-04 Thread Martin Storsjö
On Wed, 20 Dec 2023, Martin Storsjö wrote: The file libavcodec/x86/mlpdsp_init.c uses inline assembly with nonlocal labels that are referenced outside of the assembly in C. This fails to link with LTO when built with Clang when targeting Windows. The root cause has been reported upstream at

Re: [FFmpeg-devel] [PATCH] configure: Don't pass -mfp16-format to MSVC on ARM

2024-01-04 Thread Martin Storsjö
On Fri, 22 Dec 2023, Martin Storsjö wrote: The check for this option does succeed - MSVC accepts the option, but prints a warning about it being unknown and ignored, for each compiled object file: cl : Command line warning D9002 : ignoring unknown option '-mfp16-format=ieee' The configure

Re: [FFmpeg-devel] [PATCH] avformat/ffrtmpcrypt: Fix int-conversion warning

2024-01-04 Thread Martin Storsjö
On Fri, 22 Dec 2023, Frank Plowman wrote: Hi Martin, Thanks for the review. On 22/12/2023 12:15, Martin Storsjö wrote: The change LGTM, but the wording here is slightly confusing IMO. The problem isn't with using per se AVERROR, that's just a macro for generating suitable integers, the

Re: [FFmpeg-devel] [PATCH v9 09/13] vvcdec: add LMCS, Deblocking, SAO, and ALF filters

2024-01-04 Thread Martin Storsjö
On Thu, 4 Jan 2024, Nuo Mi wrote: On Thu, Jan 4, 2024 at 2:38 AM Michael Niedermayer wrote: On Tue, Jan 02, 2024 at 05:47:53PM +0800, Nuo Mi wrote: [...] > maintainer, and any HEVC code change requires a very long review time. I think changes that just move code around or rename functions

Re: [FFmpeg-devel] [PATCH v9 09/13] vvcdec: add LMCS, Deblocking, SAO, and ALF filters

2024-01-04 Thread Nuo Mi
On Thu, Jan 4, 2024 at 2:38 AM Michael Niedermayer wrote: > On Tue, Jan 02, 2024 at 05:47:53PM +0800, Nuo Mi wrote: > [...] > > maintainer, and any HEVC code change requires a very long review time. > > I think changes that just move code around or rename functions would be > quickly reviewed >

Re: [FFmpeg-devel] [PATCH] fate: add VVC decoder tests

2024-01-04 Thread Nuo Mi
On Thu, Jan 4, 2024 at 8:20 AM James Almer wrote: > Signed-off-by: James Almer > --- > tests/Makefile| 1 + > tests/fate/vvc.mak| 50 +++ > tests/ref/fate/vvc-conformance-APSALF_A_2 | 13 ++ >

[FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: Remove write-only variable

2024-01-04 Thread Zhao Zhili
From: Zhao Zhili Fix warning: variable 'time_incr' set but not used. --- libavcodec/mpeg4videodec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c index 7485c5618b..9024559829 100644 --- a/libavcodec/mpeg4videodec.c

[FFmpeg-devel] [PATCH 1/2] avcodec/mediacodec_wrapper: add async mode support

2024-01-04 Thread Zhao Zhili
From: Zhao Zhili Only support NDK mediacodec. --- libavcodec/mediacodec_wrapper.c | 127 libavcodec/mediacodec_wrapper.h | 25 +++ 2 files changed, 152 insertions(+) diff --git a/libavcodec/mediacodec_wrapper.c b/libavcodec/mediacodec_wrapper.c index

[FFmpeg-devel] [PATCH 2/2] avcodec/mediacodecenc: add async mode support

2024-01-04 Thread Zhao Zhili
From: Zhao Zhili --- configure | 2 +- libavcodec/mediacodecenc.c | 289 + 2 files changed, 258 insertions(+), 33 deletions(-) diff --git a/configure b/configure index d15cfa4703..4f0bdd8c7b 100755 --- a/configure +++ b/configure @@