Re: [FFmpeg-devel] [PATCH] avformat/nutenc: Fix indentation

2024-02-03 Thread Leo Izen
On 2/3/24 14:20, Andreas Rheinhardt wrote: Forgotten after 82beb46e65e5f820b187355bf757725c22a59c45. Also use loop-scope for iterators while at it. Signed-off-by: Andreas Rheinhardt --- libavformat/nutenc.c | 30 +++--- 1 file changed, 15 insertions(+), 15

[FFmpeg-devel] [PATCH 3/3 v4] fate/mov: test remuxing all stream heif items

2024-02-03 Thread James Almer
Signed-off-by: James Almer --- No changes since last version. tests/fate/mov.mak | 2 +- tests/ref/fate/mov-heic-demux-still-image-multiple-items | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/fate/mov.mak

[FFmpeg-devel] [PATCH 2/3 v5] avformat/mov: add support for tile HEIF still images

2024-02-03 Thread James Almer
Export each tile as its own stream, and the grid information as a Stream Group of type TILE_GRID. This also enables exporting other stream items like thumbnails, which may be present in non tiled HEIF images too. For those, the primary stream will be tagged with the default disposition. Based on

[FFmpeg-devel] [PATCH 1/3 v7] avformat: add a Tile Grid stream group type

2024-02-03 Thread James Almer
This will be used to support tiled image formats like HEIF. Signed-off-by: James Almer --- Fixed comment about sizeof(AVStreamGroupTileGrid). libavformat/avformat.c | 5 +++ libavformat/avformat.h | 100 + libavformat/dump.c | 29

Re: [FFmpeg-devel] [RFC] Vote STF/SPI 2024-02

2024-02-03 Thread Michael Niedermayer
On Sat, Feb 03, 2024 at 04:37:54AM +0100, Michael Niedermayer wrote: > On Thu, Feb 01, 2024 at 05:29:26AM +0100, Michael Niedermayer wrote: > > Hi all > > > > To do the STF/SPI thing properly, and make sure we do what the Community > > wants. > > We should do this vote: (unless lots of people

Re: [FFmpeg-devel] GA changes

2024-02-03 Thread Michael Niedermayer
On Sat, Feb 03, 2024 at 11:21:53PM +0100, Michael Niedermayer wrote: > Hi all > > before doing the vote about the STF/SPI id like to document that the GA > changed according to our script this way: > (I presume this must have happened on january 1st and we should probably > do a vote about

[FFmpeg-devel] GA changes

2024-02-03 Thread Michael Niedermayer
Hi all before doing the vote about the STF/SPI id like to document that the GA changed according to our script this way: (I presume this must have happened on january 1st and we should probably do a vote about adding the removed people as extra members, but there is not enough time before teh

Re: [FFmpeg-devel] [PATCH 1/3] lavc/dxv: move tag definitions to common header

2024-02-03 Thread Connor Worley
Any objections to merging this series? -- Connor Worley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

[FFmpeg-devel] [PATCH 2/2] tests/fate/ffmpeg: add a test for the issue fixed in previous commit

2024-02-03 Thread Anton Khirnov
--- tests/fate/ffmpeg.mak | 8 1 file changed, 8 insertions(+) diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak index 8c2f008d04..3f21815ba2 100644 --- a/tests/fate/ffmpeg.mak +++ b/tests/fate/ffmpeg.mak @@ -271,3 +271,11 @@ fate-ffmpeg-filter-in-eof: CMD = framecrc -f

[FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_mux: fix terminating muxer on streamcopy with -t

2024-02-03 Thread Anton Khirnov
Reported-by: Andreas Rheinhardt --- fftools/ffmpeg_mux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c index ab86abee14..962d0b2882 100644 --- a/fftools/ffmpeg_mux.c +++ b/fftools/ffmpeg_mux.c @@ -300,6 +300,7 @@ static int

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: support of 2 fields in 1 AVPacket

2024-02-03 Thread Tomas Härdin
lör 2024-02-03 klockan 20:58 +0100 skrev Tomas Härdin: > lör 2024-02-03 klockan 11:51 +0100 skrev Jerome Martinez: > > On 03/02/2024 11:00, Tomas Härdin wrote: > > > fre 2024-02-02 klockan 16:55 +0100 skrev Jerome Martinez: > > > > Before this patch, the FFmpeg MXF parser correctly detects > > > >

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: support of 2 fields in 1 AVPacket

2024-02-03 Thread Tomas Härdin
lör 2024-02-03 klockan 11:51 +0100 skrev Jerome Martinez: > On 03/02/2024 11:00, Tomas Härdin wrote: > > fre 2024-02-02 klockan 16:55 +0100 skrev Jerome Martinez: > > > Before this patch, the FFmpeg MXF parser correctly detects > > > content > > > with > > > 2 fields in 1 AVPacket as e.g.

[FFmpeg-devel] [PATCH 4/5] avformat/avformat: Avoid av_strdup(NULL)

2024-02-03 Thread Andreas Rheinhardt
It is not documented to be safe. Also copy these lists in a more generic manner. Signed-off-by: Andreas Rheinhardt --- libavformat/avformat.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/libavformat/avformat.c b/libavformat/avformat.c index

[FFmpeg-devel] [PATCH 5/5] avformat/mux: Don't allocate priv_pts separately

2024-02-03 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/avformat.c | 1 - libavformat/internal.h | 2 +- libavformat/mux.c | 17 ++--- libavformat/mux_utils.c | 5 + 4 files changed, 8 insertions(+), 17 deletions(-) diff --git a/libavformat/avformat.c

[FFmpeg-devel] [PATCH] avcodec/indeo3: Round dimensions up in allocate_frame_buffers()

2024-02-03 Thread Michael Niedermayer
Fixes: Ticket6581 Signed-off-by: Michael Niedermayer --- libavcodec/indeo3.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/indeo3.c b/libavcodec/indeo3.c index 5f1014f0d49..7bb0235bdb5 100644 --- a/libavcodec/indeo3.c +++ b/libavcodec/indeo3.c @@ -171,6 +171,9 @@ static

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/yadif_common: fix timestamps with very small timebases

2024-02-03 Thread Marton Balint
On Thu, 1 Feb 2024, Marton Balint wrote: On Thu, 1 Feb 2024, Michael Niedermayer wrote: On Wed, Jan 31, 2024 at 03:42:46AM +0100, Marton Balint wrote: On Wed, 31 Jan 2024, Michael Niedermayer wrote: On Sun, Jan 28, 2024 at 04:01:36AM +0100, Marton Balint wrote: Yadif filter

[FFmpeg-devel] [PATCH] avformat/nutenc: Fix indentation

2024-02-03 Thread Andreas Rheinhardt
Forgotten after 82beb46e65e5f820b187355bf757725c22a59c45. Also use loop-scope for iterators while at it. Signed-off-by: Andreas Rheinhardt --- libavformat/nutenc.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/libavformat/nutenc.c

[FFmpeg-devel] [PATCH] lavc/vvc: Validate alf_list indexes

2024-02-03 Thread post
From: Frank Plowman Fixes crashes when decoding illegal bitstreams found by fuzzing. Signed-off-by: Frank Plowman --- libavcodec/vvc/vvc_ctu.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/libavcodec/vvc/vvc_ctu.c b/libavcodec/vvc/vvc_ctu.c index

[FFmpeg-devel] [RFC/PATCH] Require compilers to support C11.

2024-02-03 Thread Anton Khirnov
It should be available in all relevant modern compilers and will allow us to use features like anonymous unions. --- As discussed at the developer meeting at FOSDEM, and also in various places before that. The main blocker until now was MSVC, which should now support C11. Only tested on Linux

Re: [FFmpeg-devel] [PATCH v2 4/5] avutil/channel_layout: add av_channel_layout_retype()

2024-02-03 Thread Anton Khirnov
Quoting Marton Balint (2024-02-01 21:36:31) > > What exactly is the rule for when the change succeeds or not? I would > > expect it to be when all the channels can be represented in the new > > order, but that is not the case for conversion to unspec. > > Yes, you are right. Converting to unspec

Re: [FFmpeg-devel] [PATCH] avformat/avlanguage: add the 6 deprecated DVD languages

2024-02-03 Thread Marth64
Thank you Stefano. Respectfully, On Sat, Feb 3, 2024 at 05:57 Stefano Sabatini wrote: > On date Sunday 2024-01-28 23:27:10 +0100, Stefano Sabatini wrote: > > On date Tuesday 2024-01-23 20:03:19 -0600, Marth64 wrote: > > > There are 6 deprecated ISO language codes that are still valid for >

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h266_syntax_template: check aps_adaptation_parameter_set_id

2024-02-03 Thread Nuo Mi
On Sat, Jan 27, 2024 at 11:13 AM Michael Niedermayer wrote: > From: James Almer > > "When aps_params_type is equal to ALF_APS or SCALING_APS, the value of > aps_adaptation_parameter_set_id shall be > in the range of 0 to 7, inclusive. > When aps_params_type is equal to LMCS_APS, the value of >

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Error pps_single_slice_per_subpic_flag

2024-02-03 Thread Nuo Mi
On Sat, Feb 3, 2024 at 11:51 PM Frank Plowman wrote: > On 03/02/2024 15:46, Nuo Mi wrote: > > On Sat, Feb 3, 2024 at 9:54 PM Frank Plowman > wrote: > > > >> On 02/02/2024 14:39, Nuo Mi wrote: > >>> On Thu, Feb 1, 2024 at 10:01 PM wrote: > >>> > From: Frank Plowman > >

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Error pps_single_slice_per_subpic_flag

2024-02-03 Thread Frank Plowman
On 03/02/2024 15:46, Nuo Mi wrote: On Sat, Feb 3, 2024 at 9:54 PM Frank Plowman wrote: On 02/02/2024 14:39, Nuo Mi wrote: On Thu, Feb 1, 2024 at 10:01 PM wrote: From: Frank Plowman pps_single_slice_per_subpic_flag is not yet supported. Support is WIP, but in the meantime throw an error

Re: [FFmpeg-devel] [PATCH 1/7 v2] avcodec: add an Immersive Audio Model and Formats frame split bsf

2024-02-03 Thread Andreas Rheinhardt
James Almer: > On 1/30/2024 7:11 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 1/30/2024 6:47 PM, Andreas Rheinhardt wrote: > +    *obu_size = get_leb(); This stuff here should not a GetBitContext at all, as basically everything is byte-aligned (and the flags above are in

Re: [FFmpeg-devel] [PATCH 6/6 v2] avformat/movenc: add support for Immersive Audio Model and Formats in ISOBMFF

2024-02-03 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > configure| 2 +- > libavformat/movenc.c | 323 ++- > libavformat/movenc.h | 7 + > 3 files changed, 269 insertions(+), 63 deletions(-) > > diff --git a/configure b/configure > index

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Error pps_single_slice_per_subpic_flag

2024-02-03 Thread Nuo Mi
On Sat, Feb 3, 2024 at 9:54 PM Frank Plowman wrote: > On 02/02/2024 14:39, Nuo Mi wrote: > > On Thu, Feb 1, 2024 at 10:01 PM wrote: > > > >> From: Frank Plowman > >> > >> pps_single_slice_per_subpic_flag is not yet supported. Support is WIP, > >> but in the meantime throw an error when trying

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp8: Enforce key-frame only for WebP

2024-02-03 Thread Andreas Rheinhardt
Andreas Rheinhardt: > VP8-in-WebP only uses key frame encoding (see [1]), yet this > is currently not enforced. This commit does so in order to > make output reproducible with frame-threading as the VP8 decoder's > update_thread_context is not called at all when using decoding > VP8-in-WebP (as

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Error pps_single_slice_per_subpic_flag

2024-02-03 Thread Frank Plowman
On 02/02/2024 14:39, Nuo Mi wrote: On Thu, Feb 1, 2024 at 10:01 PM wrote: From: Frank Plowman pps_single_slice_per_subpic_flag is not yet supported. Support is WIP, but in the meantime throw an error when trying to decode a bitstream with it set, avoiding an out-of-bounds array access.

Re: [FFmpeg-devel] [PATCH v9 2/6] avcodec/webp: separate VP8 decoding

2024-02-03 Thread Andreas Rheinhardt
Thilo Borgmann via ffmpeg-devel: > Am 28.01.24 um 11:29 schrieb Anton Khirnov: >> Quoting Thilo Borgmann via ffmpeg-devel (2024-01-25 16:39:19) >>> Am 25.01.24 um 11:04 schrieb Anton Khirnov: Quoting Thilo Borgmann via ffmpeg-devel (2023-12-31 13:30:14) > --- >    libavcodec/webp.c |

[FFmpeg-devel] [PATCH 2/2] avfilter/ccfifo: Improve included headers

2024-02-03 Thread Andreas Rheinhardt
We don't need to include fifo.h, because we don't need AVFifo as a complete type. Also add the other used headers directly. Signed-off-by: Andreas Rheinhardt --- libavfilter/ccfifo.c | 1 + libavfilter/ccfifo.h | 10 ++ 2 files changed, 7 insertions(+), 4 deletions(-) diff --git

[FFmpeg-devel] [PATCH 1/2] avfilter/ccfifo: Inline trivial functions

2024-02-03 Thread Andreas Rheinhardt
Besides being extremly simple this also avoids including ff_ccfifo_ccdetected() unnecessarily (it is only used by decklink). This is possible because this is not avpriv, but duplicated into lavd if necessary. Signed-off-by: Andreas Rheinhardt --- libavfilter/ccfifo.c | 11 ---

Re: [FFmpeg-devel] [PATCH 4/5] avutil/channel_layout: add av_channel_layout_retype()

2024-02-03 Thread James Almer
On 2/3/2024 7:38 AM, Anton Khirnov wrote: Quoting James Almer (2024-02-02 13:56:31) I wrote a function like this some time ago, but i lost the patch by accident during a migration. The way i approached it was making the return codes reflect if the conversion was lossless or not, as in, custom

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: fix seeking for open GOP

2024-02-03 Thread Nuo Mi
On Sat, Feb 3, 2024 at 8:21 PM James Almer wrote: > On 2/3/2024 9:17 AM, Nuo Mi wrote: > > On Sat, Feb 3, 2024 at 7:54 PM James Almer wrote: > > > >> On 2/3/2024 7:34 AM, Nuo Mi wrote: > >>> how to reproduce: > >>> wget https://media.xiph.org/video/derf/y4m/students_cif.y4m > >>> vvencapp

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: fix seeking for open GOP

2024-02-03 Thread James Almer
On 2/3/2024 9:17 AM, Nuo Mi wrote: On Sat, Feb 3, 2024 at 7:54 PM James Almer wrote: On 2/3/2024 7:34 AM, Nuo Mi wrote: how to reproduce: wget https://media.xiph.org/video/derf/y4m/students_cif.y4m vvencapp --input students_cif.y4m --preset faster --output students.266 MP4Box -add

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: fix seeking for open GOP

2024-02-03 Thread Nuo Mi
On Sat, Feb 3, 2024 at 7:54 PM James Almer wrote: > On 2/3/2024 7:34 AM, Nuo Mi wrote: > > how to reproduce: > > wget https://media.xiph.org/video/derf/y4m/students_cif.y4m > > vvencapp --input students_cif.y4m --preset faster --output students.266 > > MP4Box -add

Re: [FFmpeg-devel] [RFC] Vote STF/SPI 2024-02

2024-02-03 Thread Stefano Sabatini
On date Saturday 2024-02-03 04:37:54 +0100, Michael Niedermayer wrote: > On Thu, Feb 01, 2024 at 05:29:26AM +0100, Michael Niedermayer wrote: > > Hi all > > > > To do the STF/SPI thing properly, and make sure we do what the Community > > wants. > > We should do this vote: (unless lots of people

[FFmpeg-devel] [PATCH 1/3] avformat/avformat: Remove dead check, write-only assignment

2024-02-03 Thread Andreas Rheinhardt
For muxers, the internal AVCodecContext is basically unused except in avformat_transfer_internal_stream_timing_info() (which sets time_base and ticks_per_frame) and av_stream_get_codec_timebase() (a getter for time_base). This makes ticks_per_frame write-only, so don't set it. Also remove an

Re: [FFmpeg-devel] [PATCH] avformat/avlanguage: add the 6 deprecated DVD languages

2024-02-03 Thread Stefano Sabatini
On date Sunday 2024-01-28 23:27:10 +0100, Stefano Sabatini wrote: > On date Tuesday 2024-01-23 20:03:19 -0600, Marth64 wrote: > > There are 6 deprecated ISO language codes that are still valid for DVDs. > > This patch allows avlanguage to recognize them correctly. The codes are: > > (1) "in" -

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: fix seeking for open GOP

2024-02-03 Thread James Almer
On 2/3/2024 7:34 AM, Nuo Mi wrote: how to reproduce: wget https://media.xiph.org/video/derf/y4m/students_cif.y4m vvencapp --input students_cif.y4m --preset faster --output students.266 MP4Box -add students.266:fps=3/1001:par=12:11 -new students.mp4 Can't you do this with ffmpeg? mp4 muxing

[FFmpeg-devel] [PATCH 3/3] avformat/options: Only allocate AVCodecContext for demuxers

2024-02-03 Thread Andreas Rheinhardt
The muxer's AVCodecContext is currently used for exactly one thing: To store a time base in it that has been derived via heuristics in avformat_transfer_internal_stream_timing_info(); said time base can then be read back via av_stream_get_codec_timebase(). But one does not need a whole

[FFmpeg-devel] [PATCH 2/3] avformat/avformat: Remove obsolete comment

2024-02-03 Thread Andreas Rheinhardt
Forgotten in 3f991325b5ef472cf51b7d8433a2380bef2c94ff, obsolete since 3749eede66c3774799766b1f246afae8a6ffc9bb. Signed-off-by: Andreas Rheinhardt --- libavformat/avformat.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/avformat.c b/libavformat/avformat.c index

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/vf_vpp_qsv: apply 3D LUT from file.

2024-02-03 Thread Chen Yufei
On Tue, Jan 30, 2024 at 10:59 AM Chen Yufei wrote: > > On Tue, Jan 30, 2024 at 1:07 AM Anton Khirnov wrote: > > > > Quoting Chen Yufei (2024-01-29 04:01:51) > > > On Sun, Jan 28, 2024 at 10:10 PM Anton Khirnov wrote: > > > > > > > > Quoting Zhao Zhili (2024-01-28 14:51:58) > > > > > > > > > > >

[FFmpeg-devel] [PATCH] avcodec/vvcdec: fix seeking for open GOP

2024-02-03 Thread Nuo Mi
how to reproduce: wget https://media.xiph.org/video/derf/y4m/students_cif.y4m vvencapp --input students_cif.y4m --preset faster --output students.266 MP4Box -add students.266:fps=3/1001:par=12:11 -new students.mp4 ffplay testudents.mp4 --- libavcodec/vvc/vvc_refs.c | 6 ++

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: support of 2 fields in 1 AVPacket

2024-02-03 Thread Jerome Martinez
On 03/02/2024 11:00, Tomas Härdin wrote: fre 2024-02-02 klockan 16:55 +0100 skrev Jerome Martinez: Before this patch, the FFmpeg MXF parser correctly detects content with 2 fields in 1 AVPacket as e.g. interlaced 720x486 but the FFmpeg JPEG 2000 decoder reads the JPEG 2000 SIZ header without

Re: [FFmpeg-devel] [PATCH 4/5] avutil/channel_layout: add av_channel_layout_retype()

2024-02-03 Thread Anton Khirnov
Quoting James Almer (2024-02-02 13:56:31) > I wrote a function like this some time ago, but i lost the patch by > accident during a migration. > > The way i approached it was making the return codes reflect if the > conversion was lossless or not, as in, custom -> native is lossless only > if

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: support of 2 fields in 1 AVPacket

2024-02-03 Thread Tomas Härdin
fre 2024-02-02 klockan 16:55 +0100 skrev Jerome Martinez: > Before this patch, the FFmpeg MXF parser correctly detects content > with > 2 fields in 1 AVPacket as e.g. interlaced 720x486 but the FFmpeg JPEG > 2000 decoder reads the JPEG 2000 SIZ header without understanding > that > the indicated