[FFmpeg-devel] [PATCH] lavc/libopenh264: Check for noopenh264

2024-02-10 Thread Akihiko Odaki
: ERR("Codec %s has unknown cb_type\n"); continue; --- base-commit: 81c2557691b12ceb79b3ba92aa496f2301ab4d18 change-id: 20240210-noopenh264-650461efbc33 Best regards, -- Akihiko Odaki ___ ffmpeg-devel mailing list ffmpeg

Re: [FFmpeg-devel] [PATCH] avcodec/vc1dec: Fix vc1_hwaccel_pixfmt_list_420

2024-02-10 Thread Andreas Rheinhardt
*/ > +int coefs[2][7]; > + > +int effect_type, effect_flag; > +int effect_pcount1, effect_pcount2; ///< amount of effect parameters > stored in effect_params > +int effect_params1[15], effect_params2[10]; ///< effect parameters in > 16.16 fixed poi

[FFmpeg-devel] [PATCH] avcodec/vc1dec: Fix vc1_hwaccel_pixfmt_list_420

2024-02-10 Thread Akihiko Odaki
_val(GetBitContext* gb) { return (get_bits_long(gb, 30) - (1 << 29)) << 1; --- base-commit: 81c2557691b12ceb79b3ba92aa496f2301ab4d18 change-id: 20240210-vc1dec-dc6d7b31f795 Best regards, -- Akihiko Odaki ___ ffmpeg-devel mailing list ffmpeg-d

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-02-10 Thread Nuo Mi
On Sun, Feb 11, 2024 at 9:35 AM Michael Niedermayer wrote: > On Sat, Feb 10, 2024 at 06:03:57PM -0300, James Almer wrote: > > On 1/23/2024 4:22 PM, Michael Niedermayer wrote: > > > Hi all > > > > > > As it was a little difficult for me to not loose track of what is > > > blocking a release. I

Re: [FFmpeg-devel] [PATCH v4 1/8] avcodec/vvc/vvc_inter_template: move put/put_luma/put_chroma template to h2656_inter_template.c

2024-02-10 Thread Nuo Mi
On Fri, Feb 2, 2024 at 9:40 PM Nuo Mi wrote: > > > On Thu, Feb 1, 2024 at 9:14 PM James Almer wrote: > >> On 2/1/2024 9:15 AM, Nuo Mi wrote: >> > On Wed, Jan 24, 2024 at 2:17 AM wrote: >> > >> >> From: Wu Jianhua >> >> >> >> Signed-off-by: Wu Jianhua >> >> --- >> >>

[FFmpeg-devel] [PATCH] avcodec/hevcdec: fix out of bounds index -1 for inter prediction

2024-02-10 Thread Nuo Mi
It's a false positive. We use -1 to index an array, but it's not actually used. This patch will make the "GCC UndefinedBehaviorSanitizer" happy. Found by: checkasm-hevc_pel in https://fate.ffmpeg.org/report.cgi?time=20240211011905=x86_64-archlinux-gcc-ubsan Reported-by: James Almer ---

[FFmpeg-devel] [RFC PATCH] avformat/rtpdec: Audio level RTP extension RFC6464

2024-02-10 Thread jon
From: Jonathan Baudanza libwebrtc will add audio level (in decibels) and VAD status to each RTP packet. This patch will add both values to the packet sidedata. I've been using this patch in production for about a year on live audio RTP streams to detect when users are speaking without needing

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-02-10 Thread Michael Niedermayer
On Sat, Feb 10, 2024 at 06:03:57PM -0300, James Almer wrote: > On 1/23/2024 4:22 PM, Michael Niedermayer wrote: > > Hi all > > > > As it was a little difficult for me to not loose track of what is > > blocking a release. I suggest that for all release blocking issues > > open a ticket and set

Re: [FFmpeg-devel] [REFUND-REQUEST] FOSDEM'24 Travel

2024-02-10 Thread Michael Niedermayer
On Wed, Feb 07, 2024 at 12:34:02AM +0100, Stefano Sabatini wrote: > On date Tuesday 2024-02-06 14:35:31 +0100, Niklas Haas wrote: > > Hi, > > > > Due to unforeseen circumstances (DB cancelling my train), I had to take > > an Uber to the train station to just barely get there in time for the > >

Re: [FFmpeg-devel] [REFUND-REQUEST] FOSDEM '24 Expenses

2024-02-10 Thread Michael Niedermayer
On Wed, Feb 07, 2024 at 12:36:54AM +0100, Stefano Sabatini wrote: > On date Tuesday 2024-02-06 17:36:40 +, Frank Plowman wrote: > > Hello, > > > > I am requesting reimbursement for the following expenses made attending > > FOSDEM 2024, where I delivered a talk about the FFmpeg VVC decoder and

[FFmpeg-devel] [PATCH 4/4] fate/mov: add tests for HEIF samples with derived images

2024-02-10 Thread James Almer
Map the group to remux all streams in it. Signed-off-by: James Almer --- tests/fate/mov.mak| 8 + .../ref/fate/mov-heic-demux-still-image-grid | 32 +++ .../ref/fate/mov-heic-demux-still-image-iovl | 18 +++ 3 files changed, 58

Re: [FFmpeg-devel] [PATCH v2 3/3] lavc/dxv: remove ctx fields that can be derived from texdsp ctxs

2024-02-10 Thread Lynne
Feb 10, 2024, 23:59 by connorbwor...@gmail.com: > Signed-off-by: Connor Worley > --- > libavcodec/dxv.c | 53 > 1 file changed, 9 insertions(+), 44 deletions(-) > > diff --git a/libavcodec/dxv.c b/libavcodec/dxv.c > index cd78de3e0d..82c493f1de

[FFmpeg-devel] [PATCH] avformat: add a disposition field to AVStreamGroup

2024-02-10 Thread James Almer
The existing (and upcoming) available group types are meant to combine several streams for presentation, with the result being treated as if it was a stream itself. For example, a file could export two stream groups of the same type with one of them as the "default". Signed-off-by: James Almer

[FFmpeg-devel] [PATCH 35/35] avfilter/avfilter: Reorder structure fields

2024-02-10 Thread Andreas Rheinhardt
Move related fields closer together and try to plug holes. Signed-off-by: Andreas Rheinhardt --- libavfilter/avfilter.h | 41 - 1 file changed, 20 insertions(+), 21 deletions(-) diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h index

[FFmpeg-devel] [PATCH 34/35] avcodec/avcodec: Reorder AVCodecContext and AVSubtitleRect fields

2024-02-10 Thread Andreas Rheinhardt
Move related fields closer together and try to plug holes. Signed-off-by: Andreas Rheinhardt --- libavcodec/avcodec.h | 585 +-- 1 file changed, 292 insertions(+), 293 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index

[FFmpeg-devel] [PATCH 33/35] avfilter/avfilter: Move AVFilterGraph private fields to FFFilterGraph

2024-02-10 Thread Andreas Rheinhardt
(These fields were in AVFilterGraph although AVFilterGraphInternal existed for years.) Signed-off-by: Andreas Rheinhardt --- libavfilter/avfilter.h | 12 libavfilter/avfilter_internal.h | 6 ++ libavfilter/avfiltergraph.c | 32 +--- 3

[FFmpeg-devel] [PATCH 32/35] avfilter/af_hdcd: Drop a redundant log

2024-02-10 Thread Andreas Rheinhardt
avfilter_insert_filter() already reports (also with AV_LOG_VERBOSE) when a filter is auto-inserted. Signed-off-by: Andreas Rheinhardt --- Can be applied at any time. libavfilter/af_hdcd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c index

[FFmpeg-devel] [PATCH 31/35] avfilter/avfiltergraph: Avoid allocation for AVFilterGraphInternal

2024-02-10 Thread Andreas Rheinhardt
To do this, allocate AVFilterGraphInternal jointly with AVFilterGraph and rename it to FFFilterGraph in the process (similarly to AVStream/FFStream). Signed-off-by: Andreas Rheinhardt --- libavfilter/avfilter.c | 6 +++--- libavfilter/avfilter.h | 7 ---

[FFmpeg-devel] [PATCH 30/35] avfilter/avfiltergraph: Avoid indirection when freeing filtergraph

2024-02-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/avfiltergraph.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c index c6f94bf0a8..193fafe61c 100644 --- a/libavfilter/avfiltergraph.c +++

[FFmpeg-devel] [PATCH 29/35] avfilter: Add a header for internal generic-layer APIs

2024-02-10 Thread Andreas Rheinhardt
This commit moves the generic-layer stuff (that is not used by filters) to a new header of its own, similarly to 5e7b5b0090bdf68e0897fe55ee657fdccc0cbca2 for libavcodec. Signed-off-by: Andreas Rheinhardt --- If buffersrc/sink were to be treated as part of the generic layer, the declarations of

[FFmpeg-devel] [PATCH 28/35] avfilter/avfilter: Avoid allocation for AVFilterInternal

2024-02-10 Thread Andreas Rheinhardt
To do this, allocate AVFilterInternal jointly with AVFilterContext and rename it to FFFilterContext in the process (similarly to AVStream/FFStream). Signed-off-by: Andreas Rheinhardt --- libavfilter/avfilter.c| 22 ++ libavfilter/avfilter.h| 7 ---

[FFmpeg-devel] [PATCH v2 3/3] lavc/dxv: remove ctx fields that can be derived from texdsp ctxs

2024-02-10 Thread Connor Worley
Signed-off-by: Connor Worley --- libavcodec/dxv.c | 53 1 file changed, 9 insertions(+), 44 deletions(-) diff --git a/libavcodec/dxv.c b/libavcodec/dxv.c index cd78de3e0d..82c493f1de 100644 --- a/libavcodec/dxv.c +++ b/libavcodec/dxv.c @@ -39,20

[FFmpeg-devel] [PATCH v2 2/3] lavc/dvx: use texdsp funcs for texture block decompression

2024-02-10 Thread Connor Worley
Signed-off-by: Connor Worley --- libavcodec/dxv.c | 289 --- 1 file changed, 75 insertions(+), 214 deletions(-) diff --git a/libavcodec/dxv.c b/libavcodec/dxv.c index 16c34fff3b..cd78de3e0d 100644 --- a/libavcodec/dxv.c +++ b/libavcodec/dxv.c @@

[FFmpeg-devel] [PATCH v2 1/3] lavc/dxv: move tag definitions to common header

2024-02-10 Thread Connor Worley
Signed-off-by: Connor Worley --- libavcodec/dxv.c| 9 + libavcodec/dxv.h| 34 ++ libavcodec/dxvenc.c | 7 ++- 3 files changed, 41 insertions(+), 9 deletions(-) create mode 100644 libavcodec/dxv.h diff --git a/libavcodec/dxv.c

[FFmpeg-devel] [PATCH v3 2/2] lavc/vulkan_av1: port to the new stable API

2024-02-10 Thread Lynne
Most of this patch was written by Dave Airlie , with some additions by me. >From be1b73147c92a8f74e5cdf30e5325382a6f77799 Mon Sep 17 00:00:00 2001 From: Lynne Date: Fri, 19 Jan 2024 10:49:02 +1000 Subject: [PATCH v3 2/2] lavc/vulkan_av1: port to the new stable API Most of this patch was written

[FFmpeg-devel] [PATCH v3 1/2] lavc/cbs_av1: fill in ref_frame_sign_bias and order_hints

2024-02-10 Thread Lynne
Needed for Vulkan AV1. >From 841ede35a2fdb76ef31a5018a98a16384837d50a Mon Sep 17 00:00:00 2001 From: Lynne Date: Fri, 2 Feb 2024 03:54:06 +0100 Subject: [PATCH v3 1/2] lavc/cbs_av1: fill in ref_frame_sign_bias and order_hints Needed for Vulkan AV1. --- libavcodec/cbs_av1.h |

Re: [FFmpeg-devel] Call for SOWs [due Feb 10 at 23:59 UTC]

2024-02-10 Thread Michael Niedermayer
Hi all just a reminder, please submit your SoWs! thx On Wed, Feb 07, 2024 at 10:02:43PM -0800, Pierre-Anthony Lemieux wrote: > Hi all, > > Below is a proposal for creating a proposal to the STF -- I offered to > Michael to help, and here we are. > > The objective, as I understand it, is to

Re: [FFmpeg-devel] [PATCH v2 1/2] lavu/hashtable: create generic robin hood hash table

2024-02-10 Thread Connor Worley
On Wed, Feb 7, 2024 at 2:16 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Connor Worley: > > +#define ENTRY_PSL(entry) (entry) > > +#define ENTRY_OCC(entry) (ENTRY_PSL(entry) + sizeof(size_t)) > > +#define ENTRY_KEY(entry) (ENTRY_OCC(entry) + 4) > > +#define ENTRY_VAL(entry)

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-02-10 Thread James Almer
On 1/23/2024 4:22 PM, Michael Niedermayer wrote: Hi all As it was a little difficult for me to not loose track of what is blocking a release. I suggest that for all release blocking issues open a ticket and set Blocking to 7.0 that way this: https://trac.ffmpeg.org/query?blocking=~7.0 or for

[FFmpeg-devel] [PATCH] avcodec/avcodec: don't print coded dimensions if not set

2024-02-10 Thread James Almer
The avctx passed to avcodec_string() may have unset coded dimensions, as is the case when called by av_dump_format() where the streams had all the needed information at the container level, and as such no frames were decoded internally. Signed-off-by: James Almer --- libavcodec/avcodec.c | 1 +

Re: [FFmpeg-devel] [PATCH 2/4] lavc/rv34dsp: R-V V rv34_inv_transform_dc

2024-02-10 Thread flow gg
Happy new year ~ Yes, I've tried reordering. Rémi Denis-Courmont 于2024年2月10日周六 17:18写道: > Happy new year, > > The gains are -unsurprisingly- modest here. Did you try to reorder > instructions to improve scheduling? > > -- > Rémi Denis-Courmont > http://www.remlab.net/ > > > >

[FFmpeg-devel] [PATCH 27/27] avformat/demux: Use enum AVCodecID for raw_codec_id

2024-02-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/demux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/demux.h b/libavformat/demux.h index 41d1318f75..4e8d042e75 100644 --- a/libavformat/demux.h +++ b/libavformat/demux.h @@ -37,7 +37,7 @@ typedef struct

[FFmpeg-devel] [PATCH 26/27] avutil/opt: Don't use AV_OPT_TYPE_FLAGS for sentinels

2024-02-10 Thread Andreas Rheinhardt
Make AVOptionType start with 1 instead. Signed-off-by: Andreas Rheinhardt --- One could also add an AV_OPT_TYPE_NONE. libavutil/opt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/opt.h b/libavutil/opt.h index 3ceb4f86eb..0f84cc53e1 100644 --- a/libavutil/opt.h

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/vvc_mp4toannexb: check bytes left for nalu_len

2024-02-10 Thread Andreas Rheinhardt
Nuo Mi: > On Fri, Feb 9, 2024 at 7:40 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Nuo Mi: >>> Fixes: fuzzer timeout >>> Fixes: >> 65253/clusterfuzz-testcase-minimized-ffmpeg_BSF_VVC_MP4TOANNEXB_fuzzer-4972412487467008 >>> >>> Found-by: continuous fuzzing process >>

[FFmpeg-devel] [PATCH] avfilter/vf_setparams: use YUV colorspace negotiation API

2024-02-10 Thread Niklas Haas
From: Niklas Haas When this filter overrides frame properties, the outgoing frames have a different YUV colorspace than the incoming ones. This requires signalling the new colorspace on the outlink, and in particular, making sure it's *not* set to a common ref with the input - otherwise the

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/vvc_mp4toannexb: check bytes left for nalu_len

2024-02-10 Thread Nuo Mi
On Fri, Feb 9, 2024 at 7:40 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Nuo Mi: > > Fixes: fuzzer timeout > > Fixes: > 65253/clusterfuzz-testcase-minimized-ffmpeg_BSF_VVC_MP4TOANNEXB_fuzzer-4972412487467008 > > > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/hevc_mp4toannexb: check bytes left for nalu_len

2024-02-10 Thread Nuo Mi
On Fri, Feb 9, 2024 at 7:47 PM Martin Storsjö wrote: > On Fri, 9 Feb 2024, Nuo Mi wrote: > > > similar issue as in the previous commit > > --- > > libavcodec/bsf/hevc_mp4toannexb.c | 6 -- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > Keep in mind, that while the patches are posted

Re: [FFmpeg-devel] [PATCH 2/4] lavc/rv34dsp: R-V V rv34_inv_transform_dc

2024-02-10 Thread Rémi Denis-Courmont
Happy new year, The gains are -unsurprisingly- modest here. Did you try to reorder instructions to improve scheduling? -- Rémi Denis-Courmont http://www.remlab.net/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/7] lavc/me_cmp: R-V V pix_abs

2024-02-10 Thread Rémi Denis-Courmont
Le lauantaina 10. helmikuuta 2024, 11.14.11 EET Rémi Denis-Courmont a écrit : > But your patchset seems to leave those out anyway. Nevermind that bit, I missed other mails -- レミ・デニ-クールモン http://www.remlab.net/ ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 1/7] lavc/me_cmp: R-V V pix_abs

2024-02-10 Thread Rémi Denis-Courmont
Le perjantaina 9. helmikuuta 2024, 17.34.40 EET flow gg a écrit : > The issue here is that any load greater than e8 will fail the test(Bus > error), so it cannot use vlse64 or similar methods... AFAICT, data is aligned on 16 bytes here, so using larger element sizes should not be a problem. That

Re: [FFmpeg-devel] [PATCH v3] lavc/libvpxenc: add screen-content-mode option

2024-02-10 Thread Dariusz Marcinkiewicz via ffmpeg-devel
Hello. On Fri, Feb 9, 2024 at 7:28 PM James Zern wrote: > Just sent v4, which addresses the below comments. Thank you. > On Thu, Feb 8, 2024 at 1:58 PM Dariusz Marcinkiewicz via ffmpeg-devel > wrote: ... > > --- a/libavcodec/libvpxenc.c > > +++ b/libavcodec/libvpxenc.c > > @@ -114,6 +114,7 @@

[FFmpeg-devel] [PATCH v4] lavc/libvpxenc: add screen-content-mode option

2024-02-10 Thread Dariusz Marcinkiewicz via ffmpeg-devel
This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. Co-authored-by: Erik Språng Signed-off-by: Dariusz Marcinkiewicz --- doc/encoders.texi | 3 +++ libavcodec/libvpxenc.c | 11 +++ libavcodec/version.h | 2 +- 3 files changed, 15 insertions(+), 1 deletion(-) diff