Re: [FFmpeg-devel] [RFC] fateserver

2024-02-24 Thread Marth64
I'm willing to help. I have experience with Node.JS and Express (the rewrite). Thank you, On Sat, Feb 24, 2024 at 11:49 AM Michael Niedermayer wrote: > Hi all > > Both fateserver and the fateserver rewrite lack a mainteiner > > The original: > https://fate.ffmpeg.org/ > perl code here: >

Re: [FFmpeg-devel] [PATCH v3] avcodec/jpeg2000dec: support of 2 fields in 1 AVPacket

2024-02-24 Thread Jerome Martinez
On 24/02/2024 13:26, Tomas Härdin wrote: [...] It should be possible to have ffmpeg set up the necessary plumbing for this. But is it how it works elsewhere in FFmpeg? Would such complex and deep modifications be accepted by others? Good question. I would propose something like the following:

Re: [FFmpeg-devel] [PATCH 11/11] avcodec/vvcdec: add Intra Block Copy decoder

2024-02-24 Thread Nuo Mi
On Sat, Feb 24, 2024 at 9:20 PM Ronald S. Bultje wrote: > Hi, > > On Thu, Feb 22, 2024 at 2:15 AM Nuo Mi wrote: > >> +static void ibc_fill_vir_buf(const VVCLocalContext *lc, const CodingUnit >> *cu) >> [..] >> > +av_image_copy_plane(ibc_buf, ibc_stride, src, src_stride, >> cu->cb_width

[FFmpeg-devel] [PATCH 2/2] mov: parse track-based udta name tags

2024-02-24 Thread Водянников А . В .
>From 1833111ec9fe0350e9cf206bb33ca573b6b8c4b5 Mon Sep 17 00:00:00 2001 From: Aleksoid Date: Sun, 25 Feb 2024 11:59:03 +1000 Subject: [PATCH 2/2] mov: parse track-based udta name tags Signed-off-by: Aleksoid --- libavformat/mov.c | 15 +-- 1 file changed, 13 insertions(+), 2

[FFmpeg-devel] [PATCH 1/2] Add support d3d11va Intel Hevc Rext decoder.

2024-02-24 Thread Водянников А . В . via ffmpeg-devel
>From ed8fda62bbdbc62f7565891c935966c931d001ca Mon Sep 17 00:00:00 2001 From: Aleksoid Date: Thu, 22 Feb 2024 19:15:48 +1000 Subject: [PATCH 1/2] Add support d3d11va Intel Hevc Rext decoder. Signed-off-by: Aleksoid --- libavcodec/d3d12va_hevc.c | 2 +- libavcodec/dxva2.c| 68

[FFmpeg-devel] [PATCH v2] avcodec/h2645_sei: validate Mastering Display Colour Volume SEI values

2024-02-24 Thread Kacper Michajłow
As we can read in ST 2086: Values outside the specified ranges of luminance and chromaticity values are not reserved by SMPTE, and can be used for purposes outside the scope of this standard. This is further acknowledged by ITU-T H.264 and ITU-T H.265. Which says that values out of range are

Re: [FFmpeg-devel] [PATCH] mov: parse track-based udta name tags

2024-02-24 Thread James Almer
On 2/24/2024 10:59 PM, Водянников А.В. via ffmpeg-devel wrote: Signed-off-by: Aleksoid ---  libavformat/mov.c | 15 +--  1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 1a1b104615..c7b6919433 100644 --- a/libavformat/mov.c

Re: [FFmpeg-devel] [PATCH] Add float user_rdiv[4] to allow user options to apply correctly

2024-02-24 Thread Marton Balint
On Sat, 24 Feb 2024, Stone Chen wrote: On Sat, Feb 24, 2024 at 6:34 PM Marton Balint wrote: On Sat, 24 Feb 2024, Stone Chen wrote: On Sat, Feb 24, 2024 at 3:56 PM Marton Balint wrote: On Sat, 24 Feb 2024, Stone Chen wrote: Previously to support dynamic reconfigurations of the

[FFmpeg-devel] [PATCH] avcodec/h2645_sei: validate Mastering Display Colour Volume SEI values

2024-02-24 Thread Kacper Michajłow
As we can read in ST 2086: Values outside the specified ranges of luminance and chromaticity values are not reserved by SMPTE, and can be used for purposes outside the scope of this standard. This is further acknowledged by ITU-T H.264 and ITU-T H.265. Which says that values out of range are

[FFmpeg-devel] [PATCH] mov: parse track-based udta name tags

2024-02-24 Thread Водянников А . В . via ffmpeg-devel
Signed-off-by: Aleksoid --- libavformat/mov.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 1a1b104615..c7b6919433 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -301,6 +301,16 @@ static int

[FFmpeg-devel] [PATCH] Add support d3d11va Intel Hevc Rext decoder.

2024-02-24 Thread Водянников А . В . via ffmpeg-devel
Signed-off-by: Aleksoid --- libavcodec/d3d12va_hevc.c | 2 +- libavcodec/dxva2.c| 68 +-- libavcodec/dxva2_hevc.c | 41 ++--- libavcodec/dxva2_internal.h | 38 +++- libavcodec/hevcdec.c | 16

[FFmpeg-devel] [PATCH] avcodec/cbs_h2645: Avoid function pointer casts, fix UB

2024-02-24 Thread Andreas Rheinhardt
The SEI message read/write functions are called via function pointers where the SEI message-specific context is passed as void*. But the actual function definitions use a pointer to their proper context in place of void*, making the calls undefined behaviour. Clang UBSan 17 warns about this. This

Re: [FFmpeg-devel] [PATCH] Set native order for wav channel layouts up until 8 channels.

2024-02-24 Thread Michael Niedermayer
On Fri, Feb 23, 2024 at 02:41:06PM -0600, Romain Beauxis wrote: > The new default channel layout for the various RIFF/WAV decoders is not > backward compatible. > > Historically, most decoders will expect the channel layouts to follow > the native layout up-to a reasonable number of channels. >

Re: [FFmpeg-devel] [PATCH] Add float user_rdiv[4] to allow user options to apply correctly

2024-02-24 Thread Stone Chen
On Sat, Feb 24, 2024 at 6:34 PM Marton Balint wrote: > > > On Sat, 24 Feb 2024, Stone Chen wrote: > > > On Sat, Feb 24, 2024 at 3:56 PM Marton Balint wrote: > > > >> > >> > >> On Sat, 24 Feb 2024, Stone Chen wrote: > >> > >> > Previously to support dynamic reconfigurations of the matrix string

[FFmpeg-devel] [PATCH] avfilter/avfilter: Suppress warning for variable only used in av_assert1

2024-02-24 Thread Andreas Rheinhardt
Forgotten in e7f9edb4698e94135aab24c302226734713548f0. Signed-off-by: Andreas Rheinhardt --- libavfilter/avfilter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 3aa20085ed..daa7c3672a 100644 ---

Re: [FFmpeg-devel] [PATCH] Add float user_rdiv[4] to allow user options to apply correctly

2024-02-24 Thread Marton Balint
On Sat, 24 Feb 2024, Stone Chen wrote: On Sat, Feb 24, 2024 at 3:56 PM Marton Balint wrote: On Sat, 24 Feb 2024, Stone Chen wrote: > Previously to support dynamic reconfigurations of the matrix string (e.g. 0m), the rdiv values would always be cleared to 0.f, causing the rdiv to be

[FFmpeg-devel] [PATCH] fftools/ffmpeg_mux: Fix use of uninitialized variable

2024-02-24 Thread Andreas Rheinhardt
Broken in a2fc86378a18b2c2966ce3438df8f27f646438e5. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg_mux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c index 2c01aec665..335b8b42ca 100644 --- a/fftools/ffmpeg_mux.c +++

Re: [FFmpeg-devel] [PATCH 14/38] lavu/opt: factor per-type dispatch out of av_opt_set()

2024-02-24 Thread James Almer
On 2/23/2024 7:50 PM, Michael Niedermayer wrote: Hi Anton On Fri, Feb 23, 2024 at 02:58:36PM +0100, Anton Khirnov wrote: Will be useful in following commits. --- breaks: ./ffmpeg -y -request_channel_layout 3 -i bug/401/mlp_5point1_downmixof6channel.mlp -bitexact

Re: [FFmpeg-devel] [PATCH] Add float user_rdiv[4] to allow user options to apply correctly

2024-02-24 Thread Stone Chen
On Sat, Feb 24, 2024 at 3:56 PM Marton Balint wrote: > > > On Sat, 24 Feb 2024, Stone Chen wrote: > > > Previously to support dynamic reconfigurations of the matrix string > (e.g. 0m), the rdiv values would always be cleared to 0.f, causing the rdiv > to be recalculated based on the new filter.

Re: [FFmpeg-devel] [PATCH] fate/mxf: fix mxf-probe-j2k on big endian systems

2024-02-24 Thread Marton Balint
On Fri, 23 Feb 2024, Tomas Härdin wrote: tor 2024-02-22 klockan 00:34 +0100 skrev Marton Balint: Jpeg2000 decoder is decoding in native endian, so let's use the same workaround as in fate-mxf-probe-applehdr10. Fixes ticket #10868. OK I suppose Ok, thanks, will apply. Regards, Marton

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: use SRT_EPOLL_IN for waiting for an incoming connection

2024-02-24 Thread Marton Balint
On Tue, 20 Feb 2024, Marton Balint wrote: This is the proper poll mode for waiting for an incoming connection according to the SRT API docs. Fixes ticket #9142. Will apply. Regards, Marton Signed-off-by: Marton Balint --- libavformat/libsrt.c | 17 ++--- 1 file changed, 10

Re: [FFmpeg-devel] [PATCH] Add float user_rdiv[4] to allow user options to apply correctly

2024-02-24 Thread Marton Balint
On Sat, 24 Feb 2024, Stone Chen wrote: Previously to support dynamic reconfigurations of the matrix string (e.g. 0m), the rdiv values would always be cleared to 0.f, causing the rdiv to be recalculated based on the new filter. This however had the side effect of always ignoring user

[FFmpeg-devel] [PATCH v4 2/2] lavc/dxvenc: migrate DXT1 encoder to lavu hashtable

2024-02-24 Thread Connor Worley
Offers a modest performance gain due to the switch from naive linear probling to robin hood. Signed-off-by: Connor Worley --- libavcodec/dxvenc.c | 121 1 file changed, 33 insertions(+), 88 deletions(-) diff --git a/libavcodec/dxvenc.c

[FFmpeg-devel] [PATCH v4 1/2] lavu/hashtable: create generic robin hood hash table

2024-02-24 Thread Connor Worley
Signed-off-by: Connor Worley --- libavutil/Makefile | 2 + libavutil/hashtable.c | 192 libavutil/hashtable.h | 40 libavutil/tests/hashtable.c | 110 + 4 files changed, 344 insertions(+) create mode

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/x86: disable hevc 12b luma deblock

2024-02-24 Thread J. Dekker
Martin Storsjö writes: > [...] > > Are you sure the input is within valid range? It's always possible that > checkasm produces inputs that the real decoder wouldn't - but it's also > possible that this is a real decoder bug that just hasn't been triggered by > any > other test yet. > > //

Re: [FFmpeg-devel] [PATCH] doc: Add infra.txt

2024-02-24 Thread Ronald S. Bultje
Hi, On Sat, Feb 24, 2024 at 1:28 PM Michael Niedermayer wrote: > so if i had to maintain a public list, that list would never be reliable > I can continue updating it. The current list is: $ ssh ffmpeg.org cat /etc/group|grep samples|tr ':' '\n'|grep ,|tr ',' ' ' compn cehoyos reimar beastd

Re: [FFmpeg-devel] [PATCH] doc: Add infra.txt

2024-02-24 Thread Michael Niedermayer
Hi On Sat, Feb 24, 2024 at 10:56:49AM -0500, Ronald S. Bultje wrote: > Hi, > > On Thu, Feb 22, 2024 at 3:54 PM Michael Niedermayer > wrote: > > > +Fate: > > +~ > > +fatesamples are provided via rsync. Every FFmpeg developer who has a > > shell account in ffmepg.org > > +should be in the

[FFmpeg-devel] [RFC] fateserver

2024-02-24 Thread Michael Niedermayer
Hi all Both fateserver and the fateserver rewrite lack a mainteiner The original: https://fate.ffmpeg.org/ perl code here: https://git.ffmpeg.org/fateserver The rewrite (from Timothy Gu unmaintained since 2016) https://fatebeta.ffmpeg.org/ https://github.com/TimothyGu/fateserver-node Really

Re: [FFmpeg-devel] [PATCH] Add float user_rdiv[4] to allow user options to apply correctly

2024-02-24 Thread Stone Chen
Sorry I just realized I messed up my git commit (new to git), I've attached a patch file with that correction. On Sat, Feb 24, 2024 at 10:49 AM Stone Chen wrote: > Previously to support dynamic reconfigurations of the matrix string (e.g. > 0m), the rdiv values would always be cleared to 0.f,

Re: [FFmpeg-devel] [PATCH] doc: Add infra.txt

2024-02-24 Thread Ronald S. Bultje
Hi, On Thu, Feb 22, 2024 at 3:54 PM Michael Niedermayer wrote: > +Fate: +~ > +fatesamples are provided via rsync. Every FFmpeg developer who has a > shell account in ffmepg.org > +should be in the samples group and be able to upload samples. > +See >

[FFmpeg-devel] [PATCH] Add float user_rdiv[4] to allow user options to apply correctly

2024-02-24 Thread Stone Chen
Previously to support dynamic reconfigurations of the matrix string (e.g. 0m), the rdiv values would always be cleared to 0.f, causing the rdiv to be recalculated based on the new filter. This however had the side effect of always ignoring user specified rdiv values. Instead float user_rdiv[0]

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/cbs_h2645: Avoid function pointer casts, fix UB

2024-02-24 Thread Andreas Rheinhardt
Mark Thompson: > On 21/02/2024 23:32, Andreas Rheinhardt wrote: >> The SEI message read/write functions are called >> via function pointers where the SEI message-specific >> context is passed as void*. But the actual function >> definitions use a pointer to their proper context >> in place of

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: add h264_mp4toannexb bitstream filter if needed when muxing h264

2024-02-24 Thread Andreas Rheinhardt
Tomas Härdin: +static int mxf_check_bitstream(AVFormatContext *s, AVStream *st, const AVPacket *pkt) +{ +    if (st->codecpar->codec_id == AV_CODEC_ID_H264) { +    if (pkt->size >= 5 && AV_RB32(pkt->data) != 0x001 && + 

Re: [FFmpeg-devel] [PATCH] doc: Add infra.txt

2024-02-24 Thread Michael Niedermayer
On Thu, Feb 22, 2024 at 10:05:36PM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > --- > > doc/infra.txt | 99 +++ > > 1 file changed, 99 insertions(+) > > create mode 100644 doc/infra.txt > > > > diff --git a/doc/infra.txt

Re: [FFmpeg-devel] [PATCH 11/11] avcodec/vvcdec: add Intra Block Copy decoder

2024-02-24 Thread Ronald S. Bultje
Hi, On Thu, Feb 22, 2024 at 2:15 AM Nuo Mi wrote: > +static void ibc_fill_vir_buf(const VVCLocalContext *lc, const CodingUnit > *cu) > [..] > +av_image_copy_plane(ibc_buf, ibc_stride, src, src_stride, > cu->cb_width >> hs << ps , cu->cb_height >> vs); > I'm admittedly not

[FFmpeg-devel] [PATCH] configure: select iamfenc as movenc dep

2024-02-24 Thread Gyan Doshi
Unbreaks movenc compilation in minimal configuration. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 197f762b58..2d0e6a444a 100755 --- a/configure +++ b/configure @@ -3554,7 +3554,7 @@ mlp_demuxer_select="mlp_parser"

Re: [FFmpeg-devel] [PATCH 11/11] avcodec/vvcdec: add Intra Block Copy decoder

2024-02-24 Thread Nuo Mi
On Fri, Feb 23, 2024 at 9:03 PM Nuo Mi wrote: > > > On Thu, Feb 22, 2024 at 3:15 PM Nuo Mi wrote: > >> From: Wu Jianhua >> >> Introduction at https://ieeexplore.ieee.org/document/9408666 >> >> passed files: >> 10b444_A_Kwai_3.bit >> 10b444_B_Kwai_3.bit >>

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000dec: support of 2 fields in 1 AVPacket

2024-02-24 Thread Tomas Härdin
ons 2024-02-21 klockan 15:27 +0100 skrev Jerome Martinez: > On 21/02/2024 14:11, Tomas Härdin wrote: > > > mxfdec can detect cases where there will be two separate fields in > > one > > KLV, > > In practice the issue is not to detect I2 case in mxfdec (it saves us > only a little during probing

Re: [FFmpeg-devel] [PATCH 2/3] avutil/opt: Use correct function pointer type

2024-02-24 Thread Mark Thompson
On 21/02/2024 23:32, Andreas Rheinhardt wrote: av_get_sample/pix_fmt() return their respective enums and are therefore not of the type int (*)(const char*), yet they are called as-if they were of this type. This works in practice, but is actually undefined behaviour. With Clang 17 UBSan these

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/cbs_h2645: Avoid function pointer casts, fix UB

2024-02-24 Thread Mark Thompson
On 21/02/2024 23:32, Andreas Rheinhardt wrote: The SEI message read/write functions are called via function pointers where the SEI message-specific context is passed as void*. But the actual function definitions use a pointer to their proper context in place of void*, making the calls undefined

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: add h264_mp4toannexb bitstream filter if needed when muxing h264

2024-02-24 Thread Tomas Härdin
> > > +static int mxf_check_bitstream(AVFormatContext *s, AVStream *st, > > > const AVPacket *pkt) > > > +{ > > > +    if (st->codecpar->codec_id == AV_CODEC_ID_H264) { > > > +    if (pkt->size >= 5 && AV_RB32(pkt->data) != 0x001 && > > > +  AV_RB24(pkt->data)

Re: [FFmpeg-devel] Add protocol for Android content providers

2024-02-24 Thread Matthieu Bouron
On Thu, Feb 15, 2024 at 10:13:03AM +0100, Matthieu Bouron wrote: > Le jeu. 15 févr. 2024, 9:46 AM, Zhao Zhili a > écrit : > > > > > > 在 2024年2月15日,下午3:57,Matthieu Bouron 写道: > > > > > > On Thu, Feb 15, 2024 at 12:13:59PM +0800, Zhao Zhili wrote: > > >> > > >> > > On Feb 14, 2024, at

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-24 Thread Paul B Mahol
Send warmly welcomes to old/new tyrants of FFmpeg. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/x86: disable hevc 12b luma deblock

2024-02-24 Thread Martin Storsjö
On Sat, 24 Feb 2024, J. Dekker wrote: Nuo Mi writes: On Wed, Feb 21, 2024 at 7:10 PM J. Dekker wrote: Over/underflow in some cases. Signed-off-by: J. Dekker --- libavcodec/x86/hevcdsp_init.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: remove options deprecated before 6.0

2024-02-24 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-02-21 17:59:16) > Anton Khirnov: > > --- > > diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak > > index 3f21815ba2..669c878c7f 100644 > > --- a/tests/fate/ffmpeg.mak > > +++ b/tests/fate/ffmpeg.mak > > @@ -1,28 +1,3 @@ > > -FATE_MAPCHAN-$(call

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/x86: disable hevc 12b luma deblock

2024-02-24 Thread J. Dekker
Andreas Rheinhardt writes: > J. Dekker: >> SAO_BAND_INIT(12, sse2); >> SAO_EDGE_INIT(12, sse2); >> > > If you disable them here, you should also ensure that they are not > assembled at all. > > - Andreas Sure, will do on push if no other things to resolve in the

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/x86: disable hevc 12b luma deblock

2024-02-24 Thread J. Dekker
Nuo Mi writes: > On Wed, Feb 21, 2024 at 7:10 PM J. Dekker wrote: > >> Over/underflow in some cases. >> >> Signed-off-by: J. Dekker >> --- >> libavcodec/x86/hevcdsp_init.c | 9 + >> 1 file changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/libavcodec/x86/hevcdsp_init.c

Re: [FFmpeg-devel] [PATCH 1/3] lavc/vp8dsp: R-V V put_bilin_h

2024-02-24 Thread flow gg
Okay, Thanks for clarifying. I have used many fractional multipliers, mostly not for correctness, but often for performance improvements (though I don't know why), and there are no obvious downsides, How about leaving this code? Rémi Denis-Courmont 于2024年2月24日周六 15:39写道: > Hi, > > Le 24