Re: [FFmpeg-devel] [PATCH v2 2/6] avformat: add Android content resolver protocol support

2024-03-16 Thread Zhao Zhili
Sorry for the long delay of review. > On Mar 5, 2024, at 03:37, Matthieu Bouron wrote: > > On Tue, Feb 27, 2024 at 03:50:38PM +0100, Matthieu Bouron wrote: >> Handles Android content-uri starting with content://. >> --- > > [...] > > Handles Android content-uri starting with content://. > ---

[FFmpeg-devel] [PATCH v4] avformat/rcwtdec: add RCWT Closed Captions demuxer

2024-03-16 Thread Marth64
Raw Captions With Time (RCWT) is a format native to ccextractor, a commonly used open source tool for processing 608/708 Closed Captions (CC) sources. RCWT can be used to archive the original CC bitstream. The muxer was added in January 2024. In this commit, add the demuxer. One can now demux RCWT

Re: [FFmpeg-devel] [PATCH v3 3/6] avcodec/ccaption_dec: ignore leading non-breaking spaces

2024-03-16 Thread Marth64
Hi Stefano, I would like to withdraw this patch for now. I have found content where this breaks center justified text further (which is already not supported). I will instead try to implement center justification and incorporate this through that route. Please ignore it. Thank you for understan

Re: [FFmpeg-devel] [PATCH v5] avcodec/libx264: fix extradata when config annexb=0

2024-03-16 Thread Zhao Zhili
> On Mar 14, 2024, at 21:14, Andreas Rheinhardt > wrote: > > Zhao Zhili: >> From: Zhao Zhili >> >> --- >> v5: Decode chroma_format_idc directly instead of >> ff_h264_decode_seq_parameter_set >> v4: Fix missing SEI in set_avcc_extradata >> v3: Remove unnecessary inclusion >> >> libavcodec/l

[FFmpeg-devel] [PATCH v6] avcodec/libx264: fix extradata when config annexb=0

2024-03-16 Thread Zhao Zhili
From: Zhao Zhili --- v6: use av_assert2 select golomb in configure conditional compile in case of CONFIG_LIBX264_ENCODER=0 v5: Decode chroma_format_idc directly instead of ff_h264_decode_seq_parameter_set v4: Fix missing SEI in set_avcc_extradata v3: Remove unnecessary inclusion config

[FFmpeg-devel] [PATCH] avformat/hls: update current segment reference before use

2024-03-16 Thread Kacper Michajłow
It may be invalidated by the time it is used. Fixes use after free when accessing current segment. Fixes: #10825 --- libavformat/hls.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/hls.c b/libavformat/hls.c index f6b44c2e35..94bc6bc064 100644 --- a/libavformat/hls.c +++ b/li

[FFmpeg-devel] [PATCH v4] avcodec/h2645_sei: validate Mastering Display Colour Volume SEI values

2024-03-16 Thread Kacper Michajłow
As we can read in ST 2086: Values outside the specified ranges of luminance and chromaticity values are not reserved by SMPTE, and can be used for purposes outside the scope of this standard. This is further acknowledged by ITU-T H.264 and ITU-T H.265. Which says that values out of range are unkn

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: mark scale2ref as supporting dynamic sizes

2024-03-16 Thread Michael Niedermayer
On Wed, Mar 13, 2024 at 01:24:24PM +0100, Niklas Haas wrote: > From: Niklas Haas > > Analogous to the "scale" filter, which this is practically identical > with. > --- > libavfilter/avfilter.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/avfilter.c b/li

[FFmpeg-devel] [PATCH 3/3] tools/target_dec_fuzzer: adjust threshold for AV_CODEC_ID_IFF_ILBM

2024-03-16 Thread Michael Niedermayer
Fixes: timeout Fixes: 66444/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-4812862400823296 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 2 +- 1 file cha

[FFmpeg-devel] [PATCH 2/3] avcodec/iff: dont add into unused pointers

2024-03-16 Thread Michael Niedermayer
Fixes: overflowing pointers Fixes: 66444/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-4812862400823296 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/iff.c | 12 ++---

[FFmpeg-devel] [PATCH 1/3] tools/target_dem_fuzzer: add libavformat/demux.h

2024-03-16 Thread Michael Niedermayer
needed for FFInputFormat Signed-off-by: Michael Niedermayer --- tools/target_dem_fuzzer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/target_dem_fuzzer.c b/tools/target_dem_fuzzer.c index 76eed9f6a2..fe69eb9be0 100644 --- a/tools/target_dem_fuzzer.c +++ b/tools/targ

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-16 Thread Helmut K. C. Tessarek
Hi, On 2024-03-16 10:26, Christopher Degawa wrote: Seems the conflict comes from https://code.videolan.org/videolan/libbluray/-/blob/master/src/libbluray/disc/dec.c?ref_type=heads#L287 and https://github.com/FFmpeg/FFmpeg/commit/c4de5778bceab3c15f1239f1f16816749a7fd3b6 Perhaps you could also

Re: [FFmpeg-devel] [PATCH] doc/filters: Change rdiv (vf_convolution) documentation to reflect actual behavior

2024-03-16 Thread Marton Balint
On Thu, 14 Mar 2024, Stone Chen wrote: The documentation correctly states that the rdiv is a multiplier but incorrectly states the default behavior is to multiply by the sum of all matrix elements - it multiplies by 1/sum. This changes the documentation to match the code. Address trac #10

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-16 Thread James Almer
On 3/16/2024 11:26 AM, Christopher Degawa wrote: On Sat, Mar 16, 2024 at 09:08 Gnattu OC via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: If you are using Xcode >= 15 then you will need to add `-Wl,-ld_classic` to LDFLAGS. During configure you will also need to set `--host-ldflags='-Wl,-ld_c

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-16 Thread Helmut K. C. Tessarek
Hello, On 2024-03-16 10:07, Gnattu OC via ffmpeg-devel wrote: If you are using Xcode >= 15 then you will need to add `-Wl,-ld_classic` to LDFLAGS. I've already been using it since I switched to Xcode 15. Cheers, K. C. -- regards Helmut K. C. Tessarek KeyID 0x172380A011EF4944

[FFmpeg-devel] [PATCH] x86: Update x86inc.asm

2024-03-16 Thread Henrik Gramner via ffmpeg-devel
Makes things up-to-date with the upstream at https://code.videolan.org/videolan/x86inc.asm Specifying every individual change is difficult as there have been divergences and cherry-picks over time, but the full upstream change log can be found at https://code.videolan.org/videolan/x86inc.asm/-/com

Re: [FFmpeg-devel] [PATCH 1/7] avformat/iamf: Mark symbols as hidden

2024-03-16 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Avoids .got entries for ff_iamf_scalable_ch_layouts and > ff_iamf_sound_system_map (whether they would have been > created otherwise depends upon the compiler and compiler > options). > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/iamf.h | 3 +++ > 1 file changed

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: signal channel layouts using the new channel layout api

2024-03-16 Thread Marton Balint
On Thu, 14 Mar 2024, Tomas Härdin wrote: fre 2024-03-08 klockan 21:13 +0100 skrev Marton Balint: Signed-off-by: Marton Balint ---  libavformat/mxfdec.c | 129 ++--- --  1 file changed, 53 insertions(+), 76 deletions(-) No idea how the new API works, but i

Re: [FFmpeg-devel] Fixes #10509

2024-03-16 Thread Marton Balint
On Sun, 17 Mar 2024, Poorva wrote: On Mon, Mar 11, 2024 at 1:10 AM Leo Izen wrote: On 3/9/24 15:49, Poorva wrote: I have attached the git patch containing the changes for your review. This patch is submitted as part of my qualification task for Google Summer of Code (GSoC) Your editor

Re: [FFmpeg-devel] Fixes #10509

2024-03-16 Thread Poorva
On Mon, Mar 11, 2024 at 1:10 AM Leo Izen wrote: > > On 3/9/24 15:49, Poorva wrote: > > I have attached the git patch containing the changes for your review. > > > > This patch is submitted as part of my qualification task for Google Summer > > of Code (GSoC) > > > > Your editor appears to have str

Re: [FFmpeg-devel] [PATCH] vvcdec: Mark as experimental

2024-03-16 Thread Nuo Mi
On Fri, Mar 15, 2024 at 11:05 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Frank Plowman: > > On 15/03/2024 10:22, Kieran Kunhya wrote: > >> On Thu, 14 Mar 2024, 22:54 Michael Niedermayer, > > >> wrote: > >> > >>> On Wed, Feb 07, 2024 at 10:55:18PM +, Kieran Kunhya wrote:

Re: [FFmpeg-devel] [PATCH] vvcdec: Mark as experimental

2024-03-16 Thread Nuo Mi
On Fri, Mar 15, 2024 at 11:01 PM Frank Plowman wrote: > On 15/03/2024 10:22, Kieran Kunhya wrote: > > On Thu, 14 Mar 2024, 22:54 Michael Niedermayer, > > wrote: > > > >> On Wed, Feb 07, 2024 at 10:55:18PM +, Kieran Kunhya wrote: > >>> On Wed, 7 Feb 2024 at 22:06, Paul B Mahol wrote: > >>> >

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-16 Thread Christopher Degawa
On Sat, Mar 16, 2024 at 09:08 Gnattu OC via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: > If you are using Xcode >= 15 then you will need to add `-Wl,-ld_classic` > to LDFLAGS. During configure you will also need to set > `--host-ldflags='-Wl,-ld_classic’`. > > > On Mar 16, 2024, at 09:04, Hel

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-16 Thread Gnattu OC via ffmpeg-devel
If you are using Xcode >= 15 then you will need to add `-Wl,-ld_classic` to LDFLAGS. During configure you will also need to set `--host-ldflags='-Wl,-ld_classic’`. > On Mar 16, 2024, at 09:04, Helmut K. C. Tessarek wrote: > > Hello, > > It's me again - the dude who compiles ffmpeg for macOS.

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: correct bitstream check

2024-03-16 Thread Gyan Doshi
On 2024-03-16 02:02 pm, Marton Balint wrote: On Sat, 16 Mar 2024, Gyan Doshi wrote: 8559cce3c3 made the bitstream check generic using a LUT. However, one of the comparisons which involves a bitwise AND and equality check is faulty due to operator precedence. First reported and analysed at

Re: [FFmpeg-devel] [PATCH v3 7/9] avformat/pcm: factorize and improve determining the default packet size

2024-03-16 Thread Marton Balint
On Fri, 15 Mar 2024, Marton Balint wrote: - Remove the 1024 cap on the number of samples, for high sample rate audio it was suboptimal, calculate the low neighbour power of two for the number of samples (audio blocks) instead. - Make the function work correctly also for non-pcm codecs by us

Re: [FFmpeg-devel] [PATCH 1/7] avutil/channel_layout: add AV_CHANNEL_LAYOUT_RETYPE_FLAG_CANONICAL

2024-03-16 Thread Marton Balint
On Sat, 9 Mar 2024, Marton Balint wrote: Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavutil/channel_layout.c | 30 ++ libavutil/channel_layout.h | 7 +++ libavutil/version.h| 2 +- 4 files changed, 41 insertions(+), 1 deletio

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: correct bitstream check

2024-03-16 Thread Marton Balint
On Sat, 16 Mar 2024, Gyan Doshi wrote: 8559cce3c3 made the bitstream check generic using a LUT. However, one of the comparisons which involves a bitwise AND and equality check is faulty due to operator precedence. First reported and analysed at https://github.com/streamlink/streamlink/issues