Re: [FFmpeg-devel] [PATCHSET] AAC decoder refactor

2024-04-10 Thread Lynne
Apr 10, 2024, 23:57 by mich...@niedermayer.cc: > On Wed, Apr 10, 2024 at 08:18:11PM +0200, Michael Niedermayer wrote: > >> On Wed, Apr 10, 2024 at 06:48:26PM +0200, Lynne wrote: >> > Apr 8, 2024, 09:36 by d...@lynne.ee: >> > >> > > The following patchset refactors the AAC decoder step by step,

Re: [FFmpeg-devel] Query from Reuters on XZ, open source, and Microsoft

2024-04-10 Thread Vittorio Giovara
On Wed, Apr 10, 2024 at 9:19 PM Michael Niedermayer wrote: > Hi > > On Tue, Apr 09, 2024 at 03:57:02PM -0500, Romain Beauxis wrote: > > [Apologies for continuing the conversation, Rémi] > > > > Le mar. 9 avr. 2024 à 14:05, Tomas Härdin a écrit : > > > > > mån 2024-04-08 klockan 13:13 -0500

Re: [FFmpeg-devel] [PATCH 1/7 v5] avutil/frame: add helper for adding side data w/ AVBufferRef to array

2024-04-10 Thread James Almer
On 3/30/2024 2:39 PM, James Almer wrote: On 3/28/2024 1:52 PM, James Almer wrote: Signed-off-by: James Almer ---   libavutil/frame.c | 19 +++   libavutil/frame.h | 24   2 files changed, 43 insertions(+) diff --git a/libavutil/frame.c

Re: [FFmpeg-devel] [PATCH 1/2] doc/utils/eval: clarify meaning of random* seed value

2024-04-10 Thread Michael Niedermayer
On Wed, Apr 10, 2024 at 03:47:42PM +0200, Stefano Sabatini wrote: > Possible address trac issue: > http://trac.ffmpeg.org/ticket/10763 Some of the things in this ticket are specific to the buggy LCG we no longer use > --- > doc/utils.texi | 12 > 1 file changed, 12 insertions(+)

Re: [FFmpeg-devel] Query from Reuters on XZ, open source, and Microsoft

2024-04-10 Thread Michael Niedermayer
Hi On Tue, Apr 09, 2024 at 03:57:02PM -0500, Romain Beauxis wrote: > [Apologies for continuing the conversation, Rémi] > > Le mar. 9 avr. 2024 à 14:05, Tomas Härdin a écrit : > > > mån 2024-04-08 klockan 13:13 -0500 skrev Romain Beauxis: [...] > > > Also as someone who had to maintain a

Re: [FFmpeg-devel] [PATCH] avformat/lc3: Add file format for LC3/LC3plus transport

2024-04-10 Thread Antoine Soulier via ffmpeg-devel
Sure, I thought these warnings were disabled while looking at codec2.c Sorry for the bad merge of the doc. From 975040408f32431efc3fae0a0b8c048f02159515 Mon Sep 17 00:00:00 2001 From: Antoine SOULIER Date: Thu, 4 Apr 2024 22:38:03 + Subject: [PATCH] avformat/lc3: Add file format for

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: bump minimum required version to 160

2024-04-10 Thread Michael Niedermayer
On Wed, Apr 10, 2024 at 03:47:48PM +0200, Niklas Haas wrote: > On Wed, 10 Apr 2024 15:18:52 +0200 Michael Niedermayer > wrote: > > On Tue, Apr 09, 2024 at 02:53:28PM +0200, Niklas Haas wrote: > > > On Sat, 06 Apr 2024 22:28:26 +0200 Michael Niedermayer > > > wrote: > > > > On Fri, Apr 05, 2024

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: bump minimum required version to 160

2024-04-10 Thread Michael Niedermayer
On Wed, Apr 10, 2024 at 03:30:23PM +0200, Hendrik Leppkes wrote: > On Wed, Apr 10, 2024 at 3:19 PM Michael Niedermayer > wrote: > > > > On Tue, Apr 09, 2024 at 02:53:28PM +0200, Niklas Haas wrote: > > > On Sat, 06 Apr 2024 22:28:26 +0200 Michael Niedermayer > > > wrote: > > > > On Fri, Apr 05,

Re: [FFmpeg-devel] [PATCH 01/11] avcodec: add avcodec_get_supported_config()

2024-04-10 Thread Michael Niedermayer
On Mon, Apr 08, 2024 at 11:55:02PM +0200, Niklas Haas wrote: > On Mon, 08 Apr 2024 22:18:33 +0200 Michael Niedermayer > wrote: > > On Fri, Apr 05, 2024 at 08:57:11PM +0200, Niklas Haas wrote: > > > From: Niklas Haas > > > > > > This replaces the myriad of existing lists in AVCodec by a unified

Re: [FFmpeg-devel] [PATCHSET] AAC decoder refactor

2024-04-10 Thread Michael Niedermayer
On Wed, Apr 10, 2024 at 08:18:11PM +0200, Michael Niedermayer wrote: > On Wed, Apr 10, 2024 at 06:48:26PM +0200, Lynne wrote: > > Apr 8, 2024, 09:36 by d...@lynne.ee: > > > > > The following patchset refactors the AAC decoder step by step, > > > removing all large-scale templating and abstracting

Re: [FFmpeg-devel] [PATCHSET] AAC decoder refactor

2024-04-10 Thread Michael Niedermayer
On Wed, Apr 10, 2024 at 08:18:11PM +0200, Michael Niedermayer wrote: > On Wed, Apr 10, 2024 at 06:48:26PM +0200, Lynne wrote: > > Apr 8, 2024, 09:36 by d...@lynne.ee: > > > > > The following patchset refactors the AAC decoder step by step, > > > removing all large-scale templating and abstracting

Re: [FFmpeg-devel] [PATCH] bsf: use standard include paths

2024-04-10 Thread Andreas Rheinhardt
Andrew Kelley: > On 4/10/24 07:11, Andreas Rheinhardt wrote: >> I don't >> see a simplification of the Makefile. > > Relevant part from the diff: > > --- a/libavcodec/bsf/Makefile > +++ b/libavcodec/bsf/Makefile > @@ -45,5 +45,3 @@ OBJS-$(CONFIG_VP9_SUPERFRAME_BSF) += >

Re: [FFmpeg-devel] [PATCH] avformat/lc3: Add file format for LC3/LC3plus transport

2024-04-10 Thread Stefano Sabatini
On date Wednesday 2024-04-10 20:26:01 +0200, Andreas Rheinhardt wrote: > Antoine Soulier via ffmpeg-devel: [...] > > +#if CONFIG_LC3_DEMUXER > > +const FFInputFormat ff_lc3_demuxer = { > > +.p.name = "lc3", > > +.p.long_name= NULL_IF_CONFIG_SMALL("LC3 (Low Complexity > >

Re: [FFmpeg-devel] [PATCH] bsf: use standard include paths

2024-04-10 Thread Andrew Kelley
On 4/10/24 07:11, Andreas Rheinhardt wrote: I don't see a simplification of the Makefile. Relevant part from the diff: --- a/libavcodec/bsf/Makefile +++ b/libavcodec/bsf/Makefile @@ -45,5 +45,3 @@ OBJS-$(CONFIG_VP9_SUPERFRAME_BSF) += bsf/vp9_superframe.o

Re: [FFmpeg-devel] [PATCH] bsf: use standard include paths

2024-04-10 Thread Paul B Mahol
And the New Dictator have Risen! On Wed, Apr 10, 2024 at 4:12 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Andrew Kelley: > > Removes the special -I flag specified in the avcodec/bsf/ subdirectory. > > > > This makes code copy-pastable to other parts of the ffmpeg codebase,

Re: [FFmpeg-devel] [PATCH] avformat/lc3: Add file format for LC3/LC3plus transport

2024-04-10 Thread Andreas Rheinhardt
Antoine Soulier via ffmpeg-devel: > Sorry for that, I missed the rebasing. > I have followed your recommendations, and put the muxer/demuxer in the same > file. > Here is the patch: > Send your patch either with git send-email or attach it to your mail; do not copy the file produced by git

Re: [FFmpeg-devel] [PATCHSET] AAC decoder refactor

2024-04-10 Thread Michael Niedermayer
On Wed, Apr 10, 2024 at 06:48:26PM +0200, Lynne wrote: > Apr 8, 2024, 09:36 by d...@lynne.ee: > > > The following patchset refactors the AAC decoder step by step, > > removing all large-scale templating and abstracting away typed > > DSP functions from symbol parsing. > > > > This series saves

Re: [FFmpeg-devel] [PATCH] avformat/lc3: Add file format for LC3/LC3plus transport

2024-04-10 Thread Antoine Soulier via ffmpeg-devel
Sorry for that, I missed the rebasing. I have followed your recommendations, and put the muxer/demuxer in the same file. Here is the patch: >From f85989288a99130eb3583d5ae9c5bf441e961ed4 Mon Sep 17 00:00:00 2001 From: Antoine SOULIER Date: Thu, 4 Apr 2024 22:38:03 + Subject: [PATCH]

Re: [FFmpeg-devel] [PATCHSET] AAC decoder refactor

2024-04-10 Thread Lynne
Apr 8, 2024, 09:36 by d...@lynne.ee: > The following patchset refactors the AAC decoder step by step, > removing all large-scale templating and abstracting away typed > DSP functions from symbol parsing. > > This series saves 110Kib of binary data from libavcodec.so > when compiled with Clang 18

Re: [FFmpeg-devel] [PATCH] bsf: use standard include paths

2024-04-10 Thread Andreas Rheinhardt
Andrew Kelley: > Removes the special -I flag specified in the avcodec/bsf/ subdirectory. > > This makes code copy-pastable to other parts of the ffmpeg codebase, as > well as simplifying the build script. If you want to make the code copy-pastable to other parts, you need to disallow using the

Re: [FFmpeg-devel] [PATCH] bsf: use standard include paths

2024-04-10 Thread Lynne
Apr 10, 2024, 06:54 by an...@khirnov.net: > Quoting James Almer (2024-04-10 03:23:46) > >> On 4/9/2024 10:11 PM, Andrew Kelley wrote: >> > On 4/9/24 17:04, Lynne wrote: >> >> LGTM. >> >> That's how I wrote the AAC patchset as well. >> > >> > Thank you for the review, Lynne. >> > >> > What is the

[FFmpeg-devel] [PATCH 2/2] doc/utils/eval: review and extend, clarify ld/st index meaning

2024-04-10 Thread Stefano Sabatini
Prefer idx in place of id for functions accessing the internal variables, and add a short introduction to mention them. --- doc/utils.texi | 60 +++--- 1 file changed, 33 insertions(+), 27 deletions(-) diff --git a/doc/utils.texi b/doc/utils.texi index

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: bump minimum required version to 160

2024-04-10 Thread Niklas Haas
On Wed, 10 Apr 2024 15:18:52 +0200 Michael Niedermayer wrote: > On Tue, Apr 09, 2024 at 02:53:28PM +0200, Niklas Haas wrote: > > On Sat, 06 Apr 2024 22:28:26 +0200 Michael Niedermayer > > wrote: > > > On Fri, Apr 05, 2024 at 07:44:52PM +0200, Niklas Haas wrote: > > > > From: Niklas Haas > > >

[FFmpeg-devel] [PATCH 1/2] doc/utils/eval: clarify meaning of random* seed value

2024-04-10 Thread Stefano Sabatini
Possible address trac issue: http://trac.ffmpeg.org/ticket/10763 --- doc/utils.texi | 12 1 file changed, 12 insertions(+) diff --git a/doc/utils.texi b/doc/utils.texi index 76e704fc3c..edf3ae24b0 100644 --- a/doc/utils.texi +++ b/doc/utils.texi @@ -944,11 +944,23 @@ Return a pseudo

Re: [FFmpeg-devel] [PATCH 09/10] lavc/hevc_ps: reduce the size of ShortTermRPS.used

2024-04-10 Thread James Almer
On 4/10/2024 10:31 AM, Anton Khirnov wrote: It is currently an array of 32 uint8_t, each storing a single flag. A single uint32_t is sufficient. Reduces sizeof(HEVCSPS) by 1792 bytes. --- libavcodec/hevc_ps.c | 33 +++-- libavcodec/hevc_ps.h | 2 +-

[FFmpeg-devel] [PATCH 06/10] lavc/hevc_ps/HEVCSPS: change flags into size-1 bitfields

2024-04-10 Thread Anton Khirnov
Reduces sizeof(HEVCSPS) by 96 bytes. Also improve flag names: drop redundant suffixes and prefixes, and consistently use disabled/enabled. --- libavcodec/dxva2_hevc.c| 24 - libavcodec/hevc_cabac.c| 36 ++--- libavcodec/hevc_filter.c | 8 +--

[FFmpeg-devel] [PATCH 10/10] lavc/hevc_ps: compactify ShortTermRPS

2024-04-10 Thread Anton Khirnov
Do not use larger fields than needed, use size-1 bitfields for flags. Reduces sizeof(HEVCSPS) by 1280 bytes. --- libavcodec/hevc_ps.c | 6 +++--- libavcodec/hevc_ps.h | 19 +++ libavcodec/vulkan_hevc.c | 2 +- 3 files changed, 15 insertions(+), 12 deletions(-) diff

[FFmpeg-devel] [PATCH 09/10] lavc/hevc_ps: reduce the size of ShortTermRPS.used

2024-04-10 Thread Anton Khirnov
It is currently an array of 32 uint8_t, each storing a single flag. A single uint32_t is sufficient. Reduces sizeof(HEVCSPS) by 1792 bytes. --- libavcodec/hevc_ps.c | 33 +++-- libavcodec/hevc_ps.h | 2 +- libavcodec/hevc_refs.c | 6 +++---

[FFmpeg-devel] [PATCH 08/10] lavc/hevc_ps: do not store delta_poc_s[01] in ShortTermRPS

2024-04-10 Thread Anton Khirnov
They are only used in vulkan_hevc and are not actually needed, as they can be computed from delta_poc. Reduces sizeof(HEVCSPS) by 16kB. --- libavcodec/hevc_ps.c | 4 ++-- libavcodec/hevc_ps.h | 2 -- libavcodec/vulkan_hevc.c | 7 +-- 3 files changed, 7 insertions(+), 6 deletions(-)

[FFmpeg-devel] [PATCH 07/10] lavc/hevc_ps: fix variable signedness in ff_hevc_decode_short_term_rps()

2024-04-10 Thread Anton Khirnov
It is actually supposed to go negative in the loop over num_negative pics, but underflow does not break anything as the result is then assigned to a signed int. --- libavcodec/hevc_ps.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/hevc_ps.c

[FFmpeg-devel] [PATCH 05/10] lavc/hevc_ps: reduce the size of used_by_curr_pic_lt_sps_flag

2024-04-10 Thread Anton Khirnov
It is currently an array of 32 uint8_t, each storing a single flag. A single uint32_t is sufficient. --- libavcodec/hevc_ps.c | 4 +++- libavcodec/hevc_ps.h | 2 +- libavcodec/hevcdec.c | 2 +- libavcodec/vulkan_hevc.c | 3 +-- 4 files changed, 6 insertions(+), 5 deletions(-) diff

[FFmpeg-devel] [PATCH 03/10] lavc/hevcdec: allocate local_ctx as array of structs rather than pointers

2024-04-10 Thread Anton Khirnov
It is more efficient and easier to manage. --- libavcodec/hevcdec.c | 57 +--- libavcodec/hevcdec.h | 2 +- 2 files changed, 33 insertions(+), 26 deletions(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index 55f72af972..47226ef0ab 100644 ---

[FFmpeg-devel] [PATCH 04/10] lavc/hevcdec: drop a useless execute() call with 1 job

2024-04-10 Thread Anton Khirnov
--- libavcodec/hevcdec.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index 47226ef0ab..6b2c0b75ee 100644 --- a/libavcodec/hevcdec.c +++ b/libavcodec/hevcdec.c @@ -2526,9 +2526,8 @@ static void

[FFmpeg-devel] [PATCH 02/10] lavc/hevcdec: track local context count separately from WPP thread count

2024-04-10 Thread Anton Khirnov
The latter can be lowered while decoding, which would lead to memleaks. --- libavcodec/hevcdec.c | 7 +-- libavcodec/hevcdec.h | 2 ++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index c70937a756..55f72af972 100644 ---

[FFmpeg-devel] [PATCH 01/10] lavc/hevcdec: rename HEVCContext.HEVClcList to local_ctx

2024-04-10 Thread Anton Khirnov
It is more consistent with our naming conventions. --- libavcodec/hevcdec.c | 30 +++--- libavcodec/hevcdec.h | 2 +- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index d3b668af00..c70937a756 100644 ---

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: bump minimum required version to 160

2024-04-10 Thread Hendrik Leppkes
On Wed, Apr 10, 2024 at 3:19 PM Michael Niedermayer wrote: > > On Tue, Apr 09, 2024 at 02:53:28PM +0200, Niklas Haas wrote: > > On Sat, 06 Apr 2024 22:28:26 +0200 Michael Niedermayer > > wrote: > > > On Fri, Apr 05, 2024 at 07:44:52PM +0200, Niklas Haas wrote: > > > > From: Niklas Haas > > > >

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: bump minimum required version to 160

2024-04-10 Thread Michael Niedermayer
On Tue, Apr 09, 2024 at 02:53:28PM +0200, Niklas Haas wrote: > On Sat, 06 Apr 2024 22:28:26 +0200 Michael Niedermayer > wrote: > > On Fri, Apr 05, 2024 at 07:44:52PM +0200, Niklas Haas wrote: > > > From: Niklas Haas > > > > > > This version is four years old, and present in Debian oldstable,

Re: [FFmpeg-devel] Query from Reuters on XZ, open source, and Microsoft

2024-04-10 Thread Gyan Doshi
On 2024-04-10 02:57 pm, Stefano Sabatini wrote: On date Tuesday 2024-04-09 10:36:05 +0200, Nicolas George wrote: [...] I am pointing that for the burden, I am not offering to do the same for free for the people who are so short-sighted they feel entitled to block software-defined radio,

Re: [FFmpeg-devel] [PATCH v2 16/17] fftools/ffmpeg_filter: propagate codec yuv metadata to filters

2024-04-10 Thread Nicolas George
Niklas Haas (12024-04-10): > I think a greedy algorithm (not requiring juggling multiple random > passes) can still work, It does not work for audio. Have you studied what works for audio? It is quite subtle and full of pitfalls. Regards, -- Nicolas George

Re: [FFmpeg-devel] [PATCH v2 16/17] fftools/ffmpeg_filter: propagate codec yuv metadata to filters

2024-04-10 Thread Niklas Haas
On Wed, 10 Apr 2024 14:59:15 +0200 Michael Niedermayer wrote: > On Wed, Apr 10, 2024 at 12:29:06PM +0200, Niklas Haas wrote: > > On Wed, 10 Apr 2024 03:25:45 +0200 Michael Niedermayer > > wrote: > > > On Mon, Apr 08, 2024 at 02:57:20PM +0200, Niklas Haas wrote: > > > > From: Niklas Haas > > >

Re: [FFmpeg-devel] [PATCH v2 16/17] fftools/ffmpeg_filter: propagate codec yuv metadata to filters

2024-04-10 Thread Michael Niedermayer
On Wed, Apr 10, 2024 at 12:29:06PM +0200, Niklas Haas wrote: > On Wed, 10 Apr 2024 03:25:45 +0200 Michael Niedermayer > wrote: > > On Mon, Apr 08, 2024 at 02:57:20PM +0200, Niklas Haas wrote: > > > From: Niklas Haas > > > > > > To convert between color spaces/ranges, if needed by the codec > >

Re: [FFmpeg-devel] Query from Reuters on XZ, open source, and Microsoft

2024-04-10 Thread Ronald S. Bultje
Hi Paul, On Tue, Apr 9, 2024 at 7:47 PM Paul B Mahol wrote: > Kieran's criticism is unfounded one. As I, originally 'volunteered' in that > now 'famous' ticket about Certain Big Corpo bug report and kindly replied > in friendly manner to bug reporter and give reporter free support, me still >

Re: [FFmpeg-devel] [PATCH v2] tests/checkasm: add exclude_guest for non-x86 linux perf

2024-04-10 Thread J. Dekker
Martin Storsjö writes: > On Wed, 10 Apr 2024, J. Dekker wrote: > >> The exclude_guest option only has an effect on x86. Omitting >> 'exclude_guest' defaults to zero which implies that you can count guest >> events should you run one. Some non-x86 kernels just ignore it, while >> others (e.g.

Re: [FFmpeg-devel] Query from Reuters on XZ, open source, and Microsoft

2024-04-10 Thread Tomas Härdin
tis 2024-04-09 klockan 15:57 -0500 skrev Romain Beauxis: > [Apologies for continuing the conversation, Rémi] > > Le mar. 9 avr. 2024 à 14:05, Tomas Härdin a écrit : > > > mån 2024-04-08 klockan 13:13 -0500 skrev Romain Beauxis: > > > On Wed, Apr 3, 2024, 11:39 Kieran Kunhya via ffmpeg-devel < >

Re: [FFmpeg-devel] [PATCH v1] lavfi/dnn_backend_torch: Include mem.h

2024-04-10 Thread Andreas Rheinhardt
fei.w.wang-at-intel@ffmpeg.org: > From: Fei Wang > > Fix build fail since 790f793844. > > Signed-off-by: Fei Wang > --- > libavfilter/dnn/dnn_backend_torch.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavfilter/dnn/dnn_backend_torch.cpp >

Re: [FFmpeg-devel] [PATCH v2 14/17] fftools/ffmpeg_filter: simplify choose_pix_fmts

2024-04-10 Thread Niklas Haas
On Wed, 10 Apr 2024 03:13:02 +0200 Michael Niedermayer wrote: > On Mon, Apr 08, 2024 at 02:57:18PM +0200, Niklas Haas wrote: > > From: Niklas Haas > > > > The only meaningful difference between choose_pix_fmts and the default > > code was the inclusion of an extra branch for `keep_pix_fmt`

Re: [FFmpeg-devel] [PATCH 4/5] avformat/mxfdec: Check index_edit_rate

2024-04-10 Thread Tomas Härdin
tis 2024-04-09 klockan 22:58 +0200 skrev Marton Balint: > > > On Tue, 9 Apr 2024, Tomas Härdin wrote: > > > mån 2024-04-08 klockan 21:46 +0200 skrev Marton Balint: > > > > > > > > > On Mon, 8 Apr 2024, Tomas Härdin wrote: > > > > > > > tor 2024-04-04 klockan 00:51 +0200 skrev Michael

Re: [FFmpeg-devel] [PATCH v1] lavfi/dnn_backend_torch: Include mem.h

2024-04-10 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > fei.w.wang-at-intel@ffmpeg.org > Sent: Tuesday, April 2, 2024 11:02 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Wang, Fei W > Subject: [FFmpeg-devel] [PATCH v1] lavfi/dnn_backend_torch: Include mem.h > > From: Fei Wang > > Fix

Re: [FFmpeg-devel] [PATCH v2 16/17] fftools/ffmpeg_filter: propagate codec yuv metadata to filters

2024-04-10 Thread Niklas Haas
On Wed, 10 Apr 2024 12:29:06 +0200 Niklas Haas wrote: > On Wed, 10 Apr 2024 03:25:45 +0200 Michael Niedermayer > wrote: > > On Mon, Apr 08, 2024 at 02:57:20PM +0200, Niklas Haas wrote: > > > From: Niklas Haas > > > > > > To convert between color spaces/ranges, if needed by the codec > > >

Re: [FFmpeg-devel] [PATCH v2 16/17] fftools/ffmpeg_filter: propagate codec yuv metadata to filters

2024-04-10 Thread Niklas Haas
On Wed, 10 Apr 2024 03:25:45 +0200 Michael Niedermayer wrote: > On Mon, Apr 08, 2024 at 02:57:20PM +0200, Niklas Haas wrote: > > From: Niklas Haas > > > > To convert between color spaces/ranges, if needed by the codec > > properties. > > --- > > fftools/ffmpeg_filter.c | 34

Re: [FFmpeg-devel] Query from Reuters on XZ, open source, and Microsoft

2024-04-10 Thread Stefano Sabatini
On date Tuesday 2024-04-09 10:36:05 +0200, Nicolas George wrote: [...] > I am pointing that for the burden, I am not offering to do the same for > free for the people who are so short-sighted they feel entitled to block > software-defined radio, break real-time display devices, prevent me from >

Re: [FFmpeg-devel] [PATCH v2] tests/checkasm: add exclude_guest for non-x86 linux perf

2024-04-10 Thread Martin Storsjö
On Wed, 10 Apr 2024, J. Dekker wrote: The exclude_guest option only has an effect on x86. Omitting 'exclude_guest' defaults to zero which implies that you can count guest events should you run one. Some non-x86 kernels just ignore it, while others (e.g. the Asahi Linux kernels) require the user

Re: [FFmpeg-devel] [PATCH] lavf/matroskaenc: sort options by name

2024-04-10 Thread Stefano Sabatini
On date Sunday 2024-04-07 16:01:27 +0800, Zhao Zhili wrote: > > > On Apr 7, 2024, at 14:16, Anton Khirnov wrote: > > > > Quoting Andreas Rheinhardt (2024-04-06 13:25:49) > >> See https://ffmpeg.org/pipermail/ffmpeg-devel/2024-February/320849.html > >> Additionally I do not agree that sorting

Re: [FFmpeg-devel] [PATCH] avformat/lc3: Add file format for LC3/LC3plus transport

2024-04-10 Thread Stefano Sabatini
On date Monday 2024-04-08 22:27:33 +, ffmpeg-devel Mailing List wrote: > From: Antoine SOULIER > > A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for > test purpose. This is the format implemented here. > --- > Changelog| 1 + > doc/muxers.texi

Re: [FFmpeg-devel] [PATCH 5/7] doc/muxers: add kvag

2024-04-10 Thread Stefano Sabatini
On date Saturday 2024-04-06 13:04:38 +0200, Stefano Sabatini wrote: > --- > doc/muxers.texi | 8 > 1 file changed, 8 insertions(+) > > diff --git a/doc/muxers.texi b/doc/muxers.texi > index 6b85befb43..6eea856a40 100644 > --- a/doc/muxers.texi > +++ b/doc/muxers.texi > @@ -2717,6

[FFmpeg-devel] [PATCH v2] tests/checkasm: add exclude_guest for non-x86 linux perf

2024-04-10 Thread J. Dekker
The exclude_guest option only has an effect on x86. Omitting 'exclude_guest' defaults to zero which implies that you can count guest events should you run one. Some non-x86 kernels just ignore it, while others (e.g. the Asahi Linux kernels) require the user to explicitly set the option to 1, i.e.

Re: [FFmpeg-devel] [PATCH] movenc: Allow writing timed ID3 metadata

2024-04-10 Thread Martin Storsjö
On Tue, 9 Apr 2024, James Almer wrote: On 4/4/2024 7:29 AM, Martin Storsjö wrote: This is based on a spec at https://aomediacodec.github.io/id3-emsg/, further based on ISO/IEC 23009-1:2019. Within libavformat, timed ID3 metadata (already supported by the mpegts demuxer and muxer) is handled

Re: [FFmpeg-devel] [PATCH v2 02/27] avcodec/decode: Add new ProgressFrame API

2024-04-10 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2024-04-10 10:02:55) >> Anton Khirnov: >>> Quoting Andreas Rheinhardt (2024-04-10 09:09:00) Anton Khirnov: > Quoting Andreas Rheinhardt (2024-04-08 22:13:40) >> diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c >>

Re: [FFmpeg-devel] [PATCH v2 02/27] avcodec/decode: Add new ProgressFrame API

2024-04-10 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-04-10 10:02:55) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2024-04-10 09:09:00) > >> Anton Khirnov: > >>> Quoting Andreas Rheinhardt (2024-04-08 22:13:40) > diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c > index

Re: [FFmpeg-devel] [PATCH v2 02/27] avcodec/decode: Add new ProgressFrame API

2024-04-10 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2024-04-10 09:09:00) >> Anton Khirnov: >>> Quoting Andreas Rheinhardt (2024-04-08 22:13:40) diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c index fd356bd190..6b2c4312e0 100644 --- a/libavcodec/pthread_frame.c +++

Re: [FFmpeg-devel] [PATCH v2 02/27] avcodec/decode: Add new ProgressFrame API

2024-04-10 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-04-10 09:09:00) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2024-04-08 22:13:40) > >> diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c > >> index fd356bd190..6b2c4312e0 100644 > >> --- a/libavcodec/pthread_frame.c > >> +++

Re: [FFmpeg-devel] [PATCH] tests/movenc: Validate that normal muxer usage doesn't print warnings

2024-04-10 Thread Martin Storsjö
On Thu, 4 Apr 2024, Martin Storsjö wrote: We have test to make sure that certain configurations do print warnings. However, the normal operation of the muxer within this test always printed a warning, so those tests to check for extra warnings didn't essentially guard anything. The warning

Re: [FFmpeg-devel] [PATCH] movenc: Remove a leftover commented out line

2024-04-10 Thread Martin Storsjö
On Thu, 4 Apr 2024, Martin Storsjö wrote: This line originates from 6f69f7a8bf6a0d013985578df2ef42ee6b1c7994. --- libavformat/movenc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 46a5b3a62f..ccdd2dbfc9 100644 --- a/libavformat/movenc.c

Re: [FFmpeg-devel] [PATCH] aarch64: Factorize code for CPU feature detection on Apple platforms

2024-04-10 Thread Martin Storsjö
On Tue, 12 Mar 2024, Martin Storsjö wrote: --- libavutil/aarch64/cpu.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/libavutil/aarch64/cpu.c b/libavutil/aarch64/cpu.c index 7a05391343..196bdaf6b0 100644 --- a/libavutil/aarch64/cpu.c +++

Re: [FFmpeg-devel] [PATCH v2 02/27] avcodec/decode: Add new ProgressFrame API

2024-04-10 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2024-04-08 22:13:40) >> diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c >> index fd356bd190..6b2c4312e0 100644 >> --- a/libavcodec/pthread_frame.c >> +++ b/libavcodec/pthread_frame.c >> @@ -779,6 +779,7 @@ static av_cold int

Re: [FFmpeg-devel] [PATCH v2 06/27] avcodec/vp9: Fix race when attaching side-data for show-existing frame

2024-04-10 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-04-08 22:13:44) > When outputting a show-existing frame, the VP9 decoder simply > created a reference to said frame and returned it immediately to > the caller, without waiting for it to have finished decoding. > In case of frame-threading it is possible for the

Re: [FFmpeg-devel] [PATCH v2 02/27] avcodec/decode: Add new ProgressFrame API

2024-04-10 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-04-08 22:13:40) > diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c > index fd356bd190..6b2c4312e0 100644 > --- a/libavcodec/pthread_frame.c > +++ b/libavcodec/pthread_frame.c > @@ -779,6 +779,7 @@ static av_cold int init_thread(PerThreadContext

Re: [FFmpeg-devel] [PATCH v2 01/27] avcodec/threadprogress: Add new API for frame-threaded progress

2024-04-10 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-04-08 21:51:59) > +/** > + * ThreadProgress is an API to easily notify other threads about progress > + * of any kind as long as it can be packaged into an int and is consistent > + * with the natural ordering of integers. > + * > + * Each initialized

Re: [FFmpeg-devel] [PATCH 01/17] avcodec/ac3enc: Don't presume ch_layout to be AV_CHANNEL_ORDER_NATIVE

2024-04-10 Thread Andreas Rheinhardt
Andreas Rheinhardt: > It is perfectly legal for users to use a custom layout > that is equivalent to a supported native one. > In this case the union in AVChannelLayout is not an uint64_t mask, > but a pointer to a custom map. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ac3enc.c |