[FFmpeg-devel] [PATCH] avformat/mov: free the infe allocated item data on failure

2024-04-26 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index e52a83c82e..49dd82a4d1 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -84,6 +84,7 @@ typedef

[FFmpeg-devel] [PATCH] avformat/mov: free the infe allocated streams on private data allocation failure

2024-04-26 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index e52a83c82e..7f81419bd8 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -84,6 +84,7 @@ typedef struct

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mov: Check if heif item name is already allocated

2024-04-26 Thread James Almer
On 4/26/2024 9:03 PM, Michael Niedermayer wrote: On Fri, Apr 26, 2024 at 08:57:02PM -0300, James Almer wrote: On 4/26/2024 8:52 PM, Michael Niedermayer wrote: Fixes: memleak Fixes: 68212/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4963488540721152 Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: allow setting which side data parameters are printed

2024-04-26 Thread James Almer
On 4/26/2024 9:17 PM, Michael Niedermayer wrote: On Thu, Apr 25, 2024 at 11:34:59AM -0300, James Almer wrote: For some side data types, the size is dependent on the arch at runtime, which is not good for FATE tests. Which are not bit exact ? All the AV_PKT_DATA_IAMF_* ones, and

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: allow setting which side data parameters are printed

2024-04-26 Thread Michael Niedermayer
On Thu, Apr 25, 2024 at 11:34:59AM -0300, James Almer wrote: > For some side data types, the size is dependent on the arch at runtime, which > is not good for FATE tests. Which are not bit exact ? I guess its pointer size or something. Either way i have some local improvments for framecrc that

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mov: Check if heif item name is already allocated

2024-04-26 Thread Michael Niedermayer
On Fri, Apr 26, 2024 at 08:57:02PM -0300, James Almer wrote: > On 4/26/2024 8:52 PM, Michael Niedermayer wrote: > > Fixes: memleak > > Fixes: > > 68212/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4963488540721152 > > > > Found-by: continuous fuzzing process > >

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mov: Check if heif item name is already allocated

2024-04-26 Thread James Almer
On 4/26/2024 8:52 PM, Michael Niedermayer wrote: Fixes: memleak Fixes: 68212/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4963488540721152 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 5/5] avformat/mov: Check if heif item name is already allocated

2024-04-26 Thread Michael Niedermayer
Fixes: memleak Fixes: 68212/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4963488540721152 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 3 +++ 1 file changed, 3

[FFmpeg-devel] [PATCH 4/5] avcodec/hevcdec: Check ref frame

2024-04-26 Thread Michael Niedermayer
Fixes: NULL pointer dereferences Fixes: 68197/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-6382538823106560 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/hevcdec.c | 4 ++--

[FFmpeg-devel] [PATCH 3/5] avcodec/decode: Check progress before dereferencing

2024-04-26 Thread Michael Niedermayer
Fixes: NULL pointer dereference Fixes: 68192/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP8_fuzzer-6180311026171904 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/decode.c | 2 ++ 1

[FFmpeg-devel] [PATCH 2/5] avcodec/vp3: Call ff_progress_frame_unref() before ff_progress_frame_get_buffer()

2024-04-26 Thread Michael Niedermayer
Fixes: Assertion !f->f && !f->progress failed at libavcodec/decode.c:1688 Fixes: 68190/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_THEORA_fuzzer-5942090287611904 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 1/5] avcodec/pngdec: Check last AVFrame before deref

2024-04-26 Thread Michael Niedermayer
Fixes: NULL pointer dereference Fixes: 68184/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APNG_fuzzer-4926478069334016 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/pngdec.c | 2 +- 1

[FFmpeg-devel] [PATCH] avcodec/bsf/noise: fix av_log format specifier

2024-04-26 Thread Marcus B Spencer
Replace the "%d" specifier corresponding to the 2nd argument of av_log starting on line 176 with "%u", due to the fact that the 2nd argument is an unsigned int. Without this patch, if the second argument exceeded the maximum value of an int, the behavior would be undefined. Signed-off-by:

Re: [FFmpeg-devel] [PATCH] fix av_log format specifier

2024-04-26 Thread marcus
This patch does not meet the guidelines of commit messages. On Thursday, April 25th, 2024 at 6:02 PM, Marcus B Spencer wrote: > > > Signed-off-by: Marcus B Spencer mar...@marcusspencer.xyz > > --- > libavcodec/bsf/noise.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

[FFmpeg-devel] [PATCH 2/2] avformat/mov: support SpatialAudioBox ambisonic layouts with non-diegetic channels

2024-04-26 Thread James Almer
According to https://github.com/google/spatial-media/blob/master/docs/spatial-audio-rfc.md the first bit in ambisonic_type is a flag to signal the presence of non-diegetic channels in the audio track in addition to the ambisonic ones, so support this case too. Signed-off-by: James Almer ---

[FFmpeg-devel] [PATCH 1/2] avformat/mov: support SpatialAudioBox ambisonic layouts with arbitrary channel mapping

2024-04-26 Thread James Almer
We can safely export custom channels layout now, so there's no reason to reject valid layouts defined in this box. Signed-off-by: James Almer --- Untested. libavformat/mov.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/libavformat/mov.c

Re: [FFmpeg-devel] [PATCH 1/6] avutil/frame: add av_frame_remove_side_data_changed

2024-04-26 Thread epirat07
On 26 Apr 2024, at 14:27, Niklas Haas wrote: > From: Niklas Haas > > Many filters modify certain aspects of frame data, e.g. through resizing > (vf_*scale* family), color volume mapping (vf_lut*, vf_tonemap*), or > possibly others. > > When this happens, we should strip all frame side data that

Re: [FFmpeg-devel] [PATCH 4/6] avformat/iamfdec: Files without streams cannot have packets

2024-04-26 Thread James Almer
On 4/26/2024 12:08 AM, Michael Niedermayer wrote: Fixes: Assertion pkt->stream_index < (unsigned)s->nb_streams && "Invalid stream index.\n" failed at libavformat/demux.c:572 Fixes: 67890/clusterfuzz-testcase-minimized-ffmpeg_dem_IAMF_fuzzer-5166340789829632.fuzz Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 1/6] avutil/frame: add av_frame_remove_side_data_changed

2024-04-26 Thread Niklas Haas
On Fri, 26 Apr 2024 14:27:58 +0200 Niklas Haas wrote: > From: Niklas Haas > > Many filters modify certain aspects of frame data, e.g. through resizing > (vf_*scale* family), color volume mapping (vf_lut*, vf_tonemap*), or > possibly others. > > When this happens, we should strip all frame side

Re: [FFmpeg-devel] [PATCH 1/6] avformat/mov: Check tile_item_list

2024-04-26 Thread James Almer
On 4/26/2024 12:08 AM, Michael Niedermayer wrote: Fixes: Null pointer dereference Fixes: 67861/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5352628142800896 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 6/6] avfilter/vf_lut*: strip color volume metadata

2024-04-26 Thread Niklas Haas
From: Niklas Haas These filters, in general, will apply some arbitrary color volume transformation. Strip corresponding metadata to be conservative/safe. --- libavfilter/vf_lut.c | 2 ++ libavfilter/vf_lut2.c | 1 + libavfilter/vf_lut3d.c | 2 ++ 3 files changed, 5 insertions(+) diff --git

[FFmpeg-devel] [PATCH 5/6] avfilter/vf_colorspace: strip color volume metadata

2024-04-26 Thread Niklas Haas
From: Niklas Haas --- libavfilter/vf_colorspace.c | 4 1 file changed, 4 insertions(+) diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c index 7bacd7892a..46c442f3fb 100644 --- a/libavfilter/vf_colorspace.c +++ b/libavfilter/vf_colorspace.c @@ -750,6 +750,10 @@ static

[FFmpeg-devel] [PATCH 4/6] avfilter/vf_libplacebo: update metadata stripping logic

2024-04-26 Thread Niklas Haas
From: Niklas Haas Switches to av_frame_remove_side_data_changed(), covering a number of cases that we previously ignored. Additionally, stop stripping metadata when merely changing colorspace or color range, since these do not affect the actual color volume of the image data, only the encoding.

[FFmpeg-devel] [PATCH 3/6] avfilter/vf_zscale: strip metadata on change

2024-04-26 Thread Niklas Haas
From: Niklas Haas Required for both size chnages and color volume changes (as a result of changing primaries/transfer). --- libavfilter/vf_zscale.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index

[FFmpeg-devel] [PATCH 2/6] avfilter/vf_scale*: strip metadata on size change

2024-04-26 Thread Niklas Haas
From: Niklas Haas --- libavfilter/vf_scale.c| 2 ++ libavfilter/vf_scale_cuda.c | 3 +++ libavfilter/vf_scale_npp.c| 3 +++ libavfilter/vf_scale_vaapi.c | 3 +++ libavfilter/vf_scale_vt.c | 3 +++ libavfilter/vf_scale_vulkan.c | 3 +++ 6 files changed, 17 insertions(+) diff

[FFmpeg-devel] [PATCH 1/6] avutil/frame: add av_frame_remove_side_data_changed

2024-04-26 Thread Niklas Haas
From: Niklas Haas Many filters modify certain aspects of frame data, e.g. through resizing (vf_*scale* family), color volume mapping (vf_lut*, vf_tonemap*), or possibly others. When this happens, we should strip all frame side data that will no longer be correct/relevant after the operation.

[FFmpeg-devel] [PATCH v1] scale: Bring back the old yuv2yuvX, use it when disable-x86asm.

2024-04-26 Thread heng . hu . 1989
From: huheng rename old inline yuv2yuvX to yuv2yuv_X, to avoid conflicts with the names of standalone asm functions. When ffmpeg is compiled with --disable-x86asm, using the scale function will cause the video to be blurred. The reason is that when disable-x86asm, INLINE_MMXEXT is 1 and

Re: [FFmpeg-devel] [PATCH v3 0/2] HTTP Retry-After Support

2024-04-26 Thread Derek Buitenhuis
On 4/25/2024 9:22 PM, Martin Storsjö wrote: > Thanks, these patches LGTM. Pushed, thanks. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email