Re: [FFmpeg-devel] [PATCH WIP v2 1/9] avfilter/dnn: Refactor DNN parameter configuration system

> -Original Message- > From: ffmpeg-devel On Behalf Of Zhao > Zhili > Sent: Sunday, April 28, 2024 2:47 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Zhao Zhili > Subject: [FFmpeg-devel] [PATCH WIP v2 1/9] avfilter/dnn: Refactor DNN > parameter configuration system > > From: Zhao Zhili > + >

Re: [FFmpeg-devel] [PATCH WIP 0/9] Refactor DNN

> > On Apr 29, 2024, at 18:29, Guo, Yejun > wrote: > > > > > > > >> -Original Message- > >> From: ffmpeg-devel On Behalf Of > Zhao > >> Zhili > >> Sent: Sunday, April 28, 2024 6:55 PM > >> To: FFmpeg development discussions and patches >> de...@ffmpeg.org> > >> Subject: Re:

Re: [FFmpeg-devel] [PATCH 1/2] checkasm/blockdsp: add fill_block test

Since there is no 8x16, not test 8x16, and updated it in the reply flow gg 于2024年4月29日周一 15:09写道： > > From fc7c28cb78e0c90880f31c0b8d6f2fc16d0fe581 Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Mon, 29 Apr 2024 14:18:23 +0800 Subject: [PATCH 1/2] checkasm/blockdsp: add fill_block test ---

Re: [FFmpeg-devel] [PATCH 2/2] lavc/blockdsp: R-V V fill_block

Since there is no 8x16, I changed m8 to m4, and updated it in the reply flow gg 于2024年4月30日周二 08:26写道： > Hi, I initially used a loop, but according to libavcodec/blockdsp.h, > > the maximum is 8x16 = 128 bytes, so using ff_get_rv_vlenb() >= 16 and m8 > does not require a loop. > > ``` > /*

[FFmpeg-devel] [PATCH 3/3] avutil/opt: Preserve nb_channels in opt_free

Fixes: division by 0 Fixes: decoder modifying demuxer channels on failure Fixes: -sseof -5 -i zgclab/ffmpeg_crash/poc3 Found-by: Wang Dawei and Zhou Geng, from Zhongguancun Laboratory Signed-off-by: Michael Niedermayer --- libavutil/opt.c | 6 -- 1 file changed, 4 insertions(+), 2

[FFmpeg-devel] [PATCH 2/3] avformat/concatdec: Check file

Fixes: null pointer dereference Fixes: -stream_loop 1 -ss 00:00:05 -i zgclab/ffmpeg_crash/poc2 -codec:v copy -codec:a aac -y output.mp4 Found-by: Wang Dawei and Zhou Geng, from Zhongguancun Laboratory Signed-off-by: Michael Niedermayer --- libavformat/concatdec.c | 5 + 1 file changed, 5

[FFmpeg-devel] [PATCH 1/3] avformat/kvag: Check sample_rate

Fixes: Division by 0 Fixes: -copyts -start_at_zero -itsoffset 00:00:01 -itsscale 1 -ss 00:00:02 -i zgclab/ffmpeg_crash/poc1 output.mp4 Found-by: Wang Dawei and Zhou Geng, from Zhongguancun Laboratory Signed-off-by: Michael Niedermayer --- libavformat/kvag.c | 5 - 1 file changed, 4

Re: [FFmpeg-devel] [PATCH 2/2] lavc/blockdsp: R-V V fill_block

Hi, I initially used a loop, but according to libavcodec/blockdsp.h, the maximum is 8x16 = 128 bytes, so using ff_get_rv_vlenb() >= 16 and m8 does not require a loop. ``` /* add and put pixel (decoding) * Block sizes for op_pixels_func are 8x4,8x8 16x8 16x16. * h for op_pixels_func is limited

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

On Mon, Apr 29, 2024 at 6:44 PM Ondřej Fiala wrote: > > I would really suggest you look at SourceHut. While SourceHut might be a slight improvement over the current situation (and only slight), it being fundamentally still based on email makes it inherit a lot of limitations and problems, and

Re: [FFmpeg-devel] [PATCH 2/4] lavc/vp9dsp: R-V V ipred vert

updated it in the reply and https://github.com/hleft/FFmpeg/tree/vp8vp9 Rémi Denis-Courmont 于2024年4月30日周二 01:57写道： > Le perjantaina 22. maaliskuuta 2024, 8.02.38 EEST flow gg a écrit : > > Because the previous patch was updated, so it was updated in this > response > > Seemingly needs rebase

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/atrac9dec: Check init_get_bits8() for failure

On Mon, Apr 29, 2024 at 08:52:32AM +0200, Paul B Mahol wrote: > On Sun, Apr 28, 2024 at 11:31 PM Michael Niedermayer > wrote: > > > Fixes: CID1439569 Unchecked return value > > Fixes: CID1439578 Unchecked return value > > > > Sponsored-by: Sovereign Tech Fund > > > > And they paid you for this

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/aaccoder: assert that escape case len is not causing issues

On Mon, Apr 29, 2024 at 12:26:24AM +0200, Lynne wrote: > Apr 28, 2024, 23:57 by mich...@niedermayer.cc: > > > On Sun, Apr 28, 2024 at 11:41:20PM +0200, Lynne wrote: > > > >> Apr 28, 2024, 23:31 by mich...@niedermayer.cc: > >> > >> > Inspired by CID1465483 Unintentional integer overflow > >> > >

Re: [FFmpeg-devel] [PATCH] libavdevice: Improve example in deprecation message for opengl and sdl

On 2024-04-14 21:24 +0200, Nicolas George wrote: > Nicolas George (12024-04-14): > > Either we find options to make ffplay display frames as fast as > > possible, or we must document to the user that no adequate replacement > > exists. > > Please add “-vf setpts=0”. It still has a little more

[FFmpeg-devel] [PATCH v2] libavdevice: Improve example in deprecation message for opengl and sdl

When piping ffmpeg into ffplay both programs write a status line in the terminal. That causes flickering and invisibility of one or the other status line. As compromise set ffplay log level to warning, so it doesn't show the status line. The user is usually testing ffmpeg command lines and

[FFmpeg-devel] [PATCH 57/57] avcodec/ituh263enc: Remove redundant check

It is redundant due to the identical check in ff_mpv_encode_init(). Signed-off-by: Andreas Rheinhardt --- libavcodec/ituh263enc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/libavcodec/ituh263enc.c b/libavcodec/ituh263enc.c index b65a1c069a..c17303bff9 100644 ---

[FFmpeg-devel] [PATCH 56/57] avcodec/mpegvideo: Use enum for msmpeg4_version

Improves readability. Signed-off-by: Andreas Rheinhardt --- libavcodec/h263dec.c | 34 ++-- libavcodec/motion_est.c | 8 +-- libavcodec/mpegvideo.c | 6 +-- libavcodec/mpegvideo.h | 10 +++-

[FFmpeg-devel] [PATCH 55/57] avcodec/mpegvideo: Remove pblocks

It has been added in a579db0c4fe026d49c71d1ff64a2d1d07c152d68 due to XvMC, but today it is only used to swap U and V for VCR2, a MPEG-2 variant with U and V swapped. This can be done in a simpler fashion, namely by simply swapping the U and V pointers of the corresponding MPVWorkPictures.

[FFmpeg-devel] [PATCH 54/57] avcodec/mpeg12dec: Don't initialize inter_scantable

MPEG-1/2 only needs one scantable and therefore all code already uses the intra one. So stop initializing the inter one altogether. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12dec.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavcodec/mpeg12dec.c

[FFmpeg-devel] [PATCH 53/57] avcodec/mpeg12dec: Pass Mpeg1Context* in mpeg_field_start()

Avoids a cast. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12dec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 0d5540fd2f..52f98986f6 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@

[FFmpeg-devel] [PATCH 52/57] avcodec/mpegvideo_dec: Don't sync encoder-only coded_picture_number

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.c | 1 - libavcodec/mpegvideo_dec.c | 1 - 2 files changed, 2 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index b5c3de85f3..17516f6fab 100644 --- a/libavcodec/mpegvideo.c +++ b/libavcodec/mpegvideo.c @@

[FFmpeg-devel] [PATCH 51/57] avcodec/mpegvideo_dec: Simplify check for "does pic exist?"

The days in which an MPVPicture* is set with the corresponding frame being blank are over; this allows to simplify some checks. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_dec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[FFmpeg-devel] [PATCH 50/57] avcodec/mpeg12enc: Simplify writing startcodes

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12enc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c index ea193e007a..5f9974ba21 100644 --- a/libavcodec/mpeg12enc.c +++ b/libavcodec/mpeg12enc.c @@ -271,11 +271,10

[FFmpeg-devel] [PATCH 49/57] avcodec/mpegvideo_enc: Unify initializing PutBitContexts

This also rids us of the requirement to preserve the PutBitContext in ff_update_duplicate_context(). Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.c | 1 - libavcodec/mpegvideo_enc.c | 42 +- 2 files changed, 19 insertions(+), 24

[FFmpeg-devel] [PATCH 48/57] avcodec/mpegpicture: Avoid MotionEstContext in ff_mpeg_framesize_alloc()

Only set the ScratchpadContext and let the users that need it (i.e. encoders) set the MotionEstContext stuff themselves. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegpicture.c | 18 +++--- libavcodec/mpegpicture.h | 7 +++ libavcodec/mpegvideo.c | 10 +++---

[FFmpeg-devel] [PATCH 47/57] avcodec/mpegpicture: Use union for b_scratchpad and rd_scratchpad

These pointers point to the same buffers, so one can just use a union for them and avoid synchronising one of them. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegpicture.c | 1 - libavcodec/mpegpicture.h | 6 -- libavcodec/mpegvideo.c | 1 - 3 files changed, 4 insertions(+), 4

[FFmpeg-devel] [PATCH 46/57] avcodec/mpegpicture: Avoid loop and branch when setting motion_val

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegpicture.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavcodec/mpegpicture.c b/libavcodec/mpegpicture.c index d175bbc924..234bf45735 100644 --- a/libavcodec/mpegpicture.c +++ b/libavcodec/mpegpicture.c @@

[FFmpeg-devel] [PATCH 45/57] avcodec/mpegpicture: Use ThreadProgress instead of ThreadFrame API

Given that MPVPictures are already directly shared between threads in case of frame-threaded decoding, one can simply use it to pass decoding progress information between threads. This allows to avoid one level of indirection; it also means avoids allocations (of the ThreadFrameProgress structure)

[FFmpeg-devel] [PATCH 44/57] avcodec/mpeg4videoenc: Simplify writing startcodes

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg4videoenc.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/libavcodec/mpeg4videoenc.c b/libavcodec/mpeg4videoenc.c index 31307cc8dd..f89f29690a 100644 --- a/libavcodec/mpeg4videoenc.c +++

[FFmpeg-devel] [PATCH 43/57] avcodec/mpeg4videoenc: Avoid branch for writing stuffing

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg4videoenc.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/mpeg4videoenc.c b/libavcodec/mpeg4videoenc.c index e853282b4b..31307cc8dd 100644 --- a/libavcodec/mpeg4videoenc.c +++

[FFmpeg-devel] [PATCH 42/57] avcodec/mpegpicture: Make MPVPicture refcounted

Up until now, an initialized MpegEncContext had an array of MPVPictures (way more than were ever needed) and the MPVPicture* contained in the MPVWorkPictures as well as the input_picture and reordered_input_picture arrays (for the encoder) pointed into this array. Several of the pointers could

[FFmpeg-devel] [PATCH 41/57] avcodec/mpegvideo_dec: Add close function for mpegvideo-decoders

Currently identical to the H.261 and H.263 close functions (which it replaces). It will be extended in future commits. Signed-off-by: Andreas Rheinhardt --- libavcodec/flvdec.c| 4 ++-- libavcodec/h261dec.c | 11 +-- libavcodec/h263dec.c | 12 ++--

[FFmpeg-devel] [PATCH 40/57] avformat/riff: Declare VCR2 to be MPEG-2

This brings it in line with mpeg12dec.c. (This entry has been added before the MPEG2VIDEO codec id existed.) Signed-off-by: Andreas Rheinhardt --- libavformat/riff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/riff.c b/libavformat/riff.c index

[FFmpeg-devel] [PATCH 39/57] avcodec/mpeg12dec: Set out_format only once

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12dec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index e573d3cdff..0e2012b324 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -794,6 +794,8 @@

[FFmpeg-devel] [PATCH 38/57] avcodec/mpeg12dec: Remove write-only assignment

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12dec.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 3cd706de36..e573d3cdff 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -2788,8 +2788,6 @@ static int

[FFmpeg-devel] [PATCH 37/57] avcodec/mpeg12dec: Only initialize IDCT for IPU

This is all that is used. This is in preparation for further commits that will extend ff_mpv_decode_init() in a way that will make it possible to fail and require cleanup. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12dec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[FFmpeg-devel] [PATCH 36/57] avcodec/mpeg12dec: Don't initialize inter tables for IPU

IPU is intra-only. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12dec.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index e3f2dd8af7..097e4ba19a 100644 --- a/libavcodec/mpeg12dec.c +++

[FFmpeg-devel] [PATCH 35/57] avcodec/mpegvideo_enc: Reindentation

Also try to use loop-scope for iterators. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 193 ++--- 1 file changed, 96 insertions(+), 97 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index

[FFmpeg-devel] [PATCH 34/57] avcodec/mpegvideo_enc: Return early when getting length of B frame chain

Possible now that this is a function of its own. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index c0b7769ccd..5b0a2edfa6 100644 ---

[FFmpeg-devel] [PATCH 33/57] avcodec/mpegvideo_enc: Factor setting length of B frame chain out

It already avoids a goto and will be useful in the future to be able to specify each functions tasks and obligations. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 33 + 1 file changed, 25 insertions(+), 8 deletions(-) diff --git

[FFmpeg-devel] [PATCH 32/57] avcodec/error_resilience: Deduplicate cleanup code

Signed-off-by: Andreas Rheinhardt --- libavcodec/error_resilience.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/libavcodec/error_resilience.c b/libavcodec/error_resilience.c index efbacb8760..66d03987b6 100644 --- a/libavcodec/error_resilience.c +++

[FFmpeg-devel] [PATCH 31/57] avcodec/mpegpicture: Split MPVPicture into WorkPicture and ordinary Pic

There are two types of MPVPictures: Three (cur_pic, last_pic, next_pic) that are directly part of MpegEncContext and an array of MPVPictures that are separately allocated and are mostly accessed via pointers (cur|last|next)_pic_ptr; they are also used to store AVFrames in the encoder (necessary

[FFmpeg-devel] [PATCH 30/57] avcodec/mpegpicture: Rename Picture->MPVPicture

Picture is just too generic. Signed-off-by: Andreas Rheinhardt --- libavcodec/dxva2_mpeg2.c | 2 +- libavcodec/dxva2_vc1.c| 4 ++-- libavcodec/intrax8.c | 2 +- libavcodec/intrax8.h | 2 +- libavcodec/ituh263dec.c | 4 ++-- libavcodec/mpeg4videoenc.c

[FFmpeg-devel] [PATCH 29/57] avcodec/mpegvideo_enc: Move copying properties to alloc_picture()

This way said function sets everything (except for the actual contents of the frame's data). Also rename it to prepare_picture() given its new role. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-)

[FFmpeg-devel] [PATCH 28/57] avcodec/mpegvideo_enc: Pass AVFrame*, not Picture* to alloc_picture()

It now only deals with the AVFrame and no longer with the accessories. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index

[FFmpeg-devel] [PATCH 27/57] avcodec/mpegpicture: Split ff_alloc_picture() into check and alloc part

ff_alloc_picture() currently does two things: It checks the consistency of the linesize (which should not be necessary, but is) and it allocates certain buffers. (It does not actually allocate the picture buffers, so its name is misleading.) This commit splits it into two separate functions. The

[FFmpeg-devel] [PATCH 26/57] avcodec/mpegpicture: Improve error messages and code

Make it clear that this is not a failure of get_buffer/the user, but a deficit of mpegvideo. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegpicture.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libavcodec/mpegpicture.c b/libavcodec/mpegpicture.c index

[FFmpeg-devel] [PATCH 25/57] avcodec/vc1_pred: Remove unused function parameter

Signed-off-by: Andreas Rheinhardt --- libavcodec/vc1_pred.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavcodec/vc1_pred.c b/libavcodec/vc1_pred.c index f5e80fe0ef..9141290d26 100644 --- a/libavcodec/vc1_pred.c +++ b/libavcodec/vc1_pred.c @@ -66,7

[FFmpeg-devel] [PATCH 24/57] avcodec/mpegvideo: Add const where appropriate

Specifically, add const to the pointed-to-type of pointers that point to something static or that belong to last_pic or next_pic (because modifying these might lead to data races). Signed-off-by: Andreas Rheinhardt --- libavcodec/h261dec.c| 2 +- libavcodec/h261enc.c| 2 +-

[FFmpeg-devel] [PATCH 23/57] avcodec/rv30, rv34, rv40: Avoid indirection

Use the cached values from MpegEncContext.(cur|last|next)_pic instead of the corresponding *_pic_ptr. Also do the same in wmv2dec.c and mpegvideo_enc.c. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 2 +- libavcodec/rv30.c | 18 +++--- libavcodec/rv34.c

[FFmpeg-devel] [PATCH 22/57] avcodec/mpegpicture: Cache AVFrame.data and linesize values

This avoids an indirection and is in preparation for removing the AVFrame from MpegEncContext.(cur|last|next)_pic altogether. Signed-off-by: Andreas Rheinhardt --- libavcodec/motion_est.c | 16 +++ libavcodec/mpeg12dec.c | 14 +++--- libavcodec/mpeg_er.c

[FFmpeg-devel] [PATCH 21/57] avcodec/mpegpicture: Reduce value of MAX_PLANES define

No mpegvideo based codec supports alpha. While just at it, also make the define shorter. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegpicture.h | 2 +- libavcodec/mpegvideo.h | 2 +- libavcodec/mpegvideo_enc.c | 7 +++ 3 files changed, 5 insertions(+), 6 deletions(-) diff

[FFmpeg-devel] [PATCH 19/57] avcodec/mpegpicture: Use RefStruct-pool API

It involves less allocations and therefore has less potential errors to be checked. One consequence thereof is that updating the picture tables can no longer fail. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegpicture.c | 81 ++--

[FFmpeg-devel] [PATCH 18/57] avcodec/mpegpicture: Reindent after the previous commit

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegpicture.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libavcodec/mpegpicture.c b/libavcodec/mpegpicture.c index bd4ddc6b55..b83fee67f8 100644 --- a/libavcodec/mpegpicture.c +++ b/libavcodec/mpegpicture.c @@

[FFmpeg-devel] [PATCH 17/57] avcodec/mpegvideo, mpegpicture: Add buffer pool

This avoids constant allocations+frees and will also allow to simply switch to the RefStruct API, thereby avoiding the overhead of the AVBuffer API. It also simplifies the code, because it removes the "needs_realloc" field: It was added in 435c0b87d28b48dc2e0360adc404a0e2d66d16a0, before the

[FFmpeg-devel] [PATCH 16/57] avcodec/mpegvideo: Redo aligning mb_height for VC-1

VC-1 can switch from between being progressive and interlaced on a per-frame basis. In the latter case, the number of macroblocks is aligned to two (or equivalently, the height to 32); therefore certain buffers are allocated for the bigger mb_height (see 950fb8acb42f4dab9b1638721992991c0584dbf5

[FFmpeg-devel] [PATCH 15/57] avcodec/mpegpicture: Always reset motion val buffer

Codecs call ff_find_unused_picture() to get the index of an unused picture; said picture may have buffers left from using it previously (these buffers are intentionally not unreferenced so that it might be possible to reuse them; this is mpegvideo's version of a bufferpool). They should not make

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: only check index_edit_rate when calculating the index tables

mån 2024-04-15 klockan 21:34 +0200 skrev Marton Balint: > Commit ed49391961999f028e0bc55767d0eef6eeb15e49 started rejecting > negative > index segment edit rates to avoid negative av_rescale parameters. > There are two > problems with this: > > 1) there is already a validation for zero

Re: [FFmpeg-devel] [PATCH 6/6] avformat/mxfdec: Check body_offset

fre 2024-04-26 klockan 05:08 +0200 skrev Michael Niedermayer: > Fixes: signed integer overflow: 538976288 - -9223372036315799520 > cannot be represented in type 'long' > Fixes: 68060/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer- > 5523457266745344 > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

Le maanantaina 29. huhtikuuta 2024, 22.04.00 EEST Davy Durham a écrit : > Presently do you not have to create an account on the devel mailing list to > contribute to ffmpeg? Yes, but subscribing to a mailing list is much easier than creating a Gitlab account (especially if 2FA is needed), and

Re: [FFmpeg-devel] [PATCH] avcodec/riscv/vp9dsp: Fix inclusion guard

On Mon, Apr 29, 2024 at 9:33 PM Andreas Rheinhardt wrote: > > Fixes fate-source. > > Signed-off-by: Andreas Rheinhardt > --- > I intend to apply this soon. Verified that this fixes fate-source, LGTM. Thanks for noticing this. Jan ___ ffmpeg-devel

[FFmpeg-devel] [PATCH 2/2] lavc/ac3dsp: R-V V sum_square_butterfly_float

As we do not need to widen accumulators to 64 bits, we effectively get double capacity for unrolling compared to the integer function. This explains the slightly better performance gains. ac3_sum_square_bufferfly_float_c: 65.2 ac3_sum_square_bufferfly_float_rvv_f32: 12.2 ---

[FFmpeg-devel] [PATCH 1/2] lavc/ac3dsp: R-V V sum_square_butterfly_int32

ac3_sum_square_bufferfly_int32_c: 61.0 ac3_sum_square_bufferfly_int32_rvv_i64: 14.7 --- libavcodec/riscv/ac3dsp_init.c | 6 + libavcodec/riscv/ac3dsp_rvv.S | 41 ++ 2 files changed, 47 insertions(+) diff --git a/libavcodec/riscv/ac3dsp_init.c

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

Presently do you not have to create an account on the devel mailing list to contribute to ffmpeg? So on the flip side, I (actually) find it just as annoying to have to create such accounts at every project rather than my having one account at GitHub (or a relatively few for other hosting sites)

[FFmpeg-devel] [PATCH] avcodec/riscv/vp9dsp: Fix inclusion guard

Fixes fate-source. Signed-off-by: Andreas Rheinhardt --- I intend to apply this soon. libavcodec/riscv/vp9dsp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/riscv/vp9dsp.h b/libavcodec/riscv/vp9dsp.h index 0540c7303d..25047ed507 100644 ---

Re: [FFmpeg-devel] [REFUND-REQUEST] Vulkan F2F travel

Apr 29, 2024, 19:30 by gsean...@gmail.com: > Hi, > > On Mon, Apr 29, 2024 at 12:58 PM Michael Niedermayer > wrote: > >> >> Hi >> >> On Sat, Apr 27, 2024 at 02:16:36PM +0200, Lynne wrote: >> > Hi, >> > >> > I'm requesting a reimbursement for attending the Khronos F2F >> > event in Brussels on

Re: [FFmpeg-devel] [PATCH 2/4] lavc/vp9dsp: R-V V ipred vert

Le perjantaina 22. maaliskuuta 2024, 8.02.38 EEST flow gg a écrit : > Because the previous patch was updated, so it was updated in this response Seemingly needs rebase since April 7. -- レミ・デニ-クールモン http://www.remlab.net/ ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH v3 0/1] avformat/demux: fix accurate probing of durations in mpegts/ps

>Envoyé : lundi 22 avril 2024 14:32 >À : ffmpeg-devel@ffmpeg.org >Objet : Re: [FFmpeg-devel] [PATCH v3 0/1] avformat/demux: fix accurate probing >of durations in mpegts/ps > >>De : Nicolas Gaullier Envoyé : mardi 2 >>avril 2024 23:26 Objet : [PATCH v3 0/1] avformat/demux: fix accurate

Re: [FFmpeg-devel] [PATCH 2/2] lavc/blockdsp: R-V V fill_block

Le maanantaina 29. huhtikuuta 2024, 10.09.41 EEST flow gg a écrit : > Are you sure that this works with all vector lengths? The block8 code looks odd. -- レミ・デニ-クールモン http://www.remlab.net/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [REFUND-REQUEST] Vulkan F2F travel

Hi, On Mon, Apr 29, 2024 at 12:58 PM Michael Niedermayer wrote: > > Hi > > On Sat, Apr 27, 2024 at 02:16:36PM +0200, Lynne wrote: > > Hi, > > > > I'm requesting a reimbursement for attending the Khronos F2F > > event in Brussels on 2024-04-26, where I gave a talk about the > > current status of

Re: [FFmpeg-devel] [REFUND-REQUEST] Vulkan F2F travel

Hi On Sat, Apr 27, 2024 at 02:16:36PM +0200, Lynne wrote: > Hi, > > I'm requesting a reimbursement for attending the Khronos F2F > event in Brussels on 2024-04-26, where I gave a talk about the > current status of Vulkan Video integration into FFmpeg: >  - Currently implemented decoding features

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

On Mon Apr 29, 2024 at 6:37 PM CEST, Ondřej Fiala wrote: > $ git format-patch master > $ git send-email ~username/project-de...@lists.sr.ht Should have checked what I'm writing. The second line should be $ git send-email --to ~username/project-de...@lists.sr.ht *.patch Oops.

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

On Mon Apr 29, 2024 at 8:03 AM CEST, Davy Durham wrote: > On 4/19/24 09:50, Niklas Haas wrote: > +1 from me too.  Please oh, please oh, /please/ modernize the patch > management.  I don't know what the opposition/inability to use github is > all about.  But gitlab should be a great improvement

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/x86/vvc: add alf filter luma and chroma avx2 optimizations

toq...@outlook.com: > vvc_alf_filter_chroma_16x12_10_c: 7235.5 > vvc_alf_filter_chroma_16x12_10_avx2: 9751.0 Are these numbers correct? If so, the avx2 version should not be committed. - Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 2/4] tests/checkasm: add checkasm_check_vvc_alf and check_alf_filter

Apr 29, 2024, 17:25 by toq...@outlook.com: > From: Wu Jianhua > > Signed-off-by: Wu Jianhua > --- > tests/checkasm/Makefile | 2 +- > tests/checkasm/checkasm.c | 3 +- > tests/checkasm/checkasm.h | 1 + > tests/checkasm/vvc_alf.c | 133 ++ > 4 files

[FFmpeg-devel] [PATCH 4/4] tests/checkasm/vvc_alf: add check_alf_classify

From: Wu Jianhua Perforamnce Test: clip before (fps)after (fps) delta Tango2_3840x2160_60_10_420_27_LD.266 56 115 105.36% RitualDance_1920x1080_60_10_420_32_LD.266272 481 76.83%

[FFmpeg-devel] [PATCH 2/4] tests/checkasm: add checkasm_check_vvc_alf and check_alf_filter

From: Wu Jianhua Signed-off-by: Wu Jianhua --- tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 3 +- tests/checkasm/checkasm.h | 1 + tests/checkasm/vvc_alf.c | 133 ++ 4 files changed, 137 insertions(+), 2 deletions(-) create mode

[FFmpeg-devel] [PATCH 1/4] avcodec/x86/vvc: add alf filter luma and chroma avx2 optimizations

From: Wu Jianhua vvc_alf_filter_chroma_4x4_10_c: 657.0 vvc_alf_filter_chroma_4x4_10_avx2: 138.0 vvc_alf_filter_chroma_4x8_10_c: 1264.7 vvc_alf_filter_chroma_4x8_10_avx2: 253.5 vvc_alf_filter_chroma_4x12_10_c: 1841.7 vvc_alf_filter_chroma_4x12_10_avx2: 375.5 vvc_alf_filter_chroma_4x16_10_c:

[FFmpeg-devel] [PATCH v2 2/14] avcodec/mpegpicture: Store linesize in ScratchpadContext

The mpegvideo-based codecs currently require the linesize to be constant (except when the frame dimensions change); one reason for this is that certain scratch buffers whose size depend on linesize are only allocated once and are presumed to be correctly sized if the pointers are != NULL. This

Re: [FFmpeg-devel] [PATCH v2] avformat: enable UDP IPv6 multicast interface selection using zone index

Apr 29, 2024, 13:34 by r...@remlab.net: > > > Le 29 avril 2024 13:32:41 GMT+03:00, Lynne a écrit : > >Apr 29, 2024, 11:56 by r...@remlab.net: > >>> >>> >>> Le 29 avril 2024 11:20:24 GMT+03:00, Lynne a écrit : >>> > >They were they deprecated? > > They caused more bugs than they

[FFmpeg-devel] [PATCH] avformat/file: fail for non-numerical arguments to pipe:

Before this patch, the implementation of pipe: inputs/outputs would silently fall back to stdin/stdout for any argument not successfully parsed by strtol(). This patch introduces an explicit error for any non-numerical arguments, which should avoid user confusion as in #10977. New behavior: $

Re: [FFmpeg-devel] [PATCH WIP 0/9] Refactor DNN

> On Apr 29, 2024, at 18:29, Guo, Yejun > wrote: > > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Zhao >> Zhili >> Sent: Sunday, April 28, 2024 6:55 PM >> To: FFmpeg development discussions and patches > de...@ffmpeg.org> >> Subject: Re: [FFmpeg-devel] [PATCH WIP 0/9]

Re: [FFmpeg-devel] [PATCH v2] avformat: enable UDP IPv6 multicast interface selection using zone index

Le 29 avril 2024 13:32:41 GMT+03:00, Lynne a écrit : >Apr 29, 2024, 11:56 by r...@remlab.net: > >> >> >> Le 29 avril 2024 11:20:24 GMT+03:00, Lynne a écrit : >> >They were they deprecated? They caused more bugs than they solved problems (because what we need is to add IPv6

Re: [FFmpeg-devel] [PATCH v2] avformat: enable UDP IPv6 multicast interface selection using zone index

Apr 29, 2024, 11:56 by r...@remlab.net: > > > Le 29 avril 2024 11:20:24 GMT+03:00, Lynne a écrit : > >>> >They were they deprecated? >>> >>> They caused more bugs than they solved problems (because what we need is to >>> add IPv6 to IPv4 apps, not IPv4 to IPv6 apps). >>> > >What bugs did they

Re: [FFmpeg-devel] [PATCH WIP 0/9] Refactor DNN

> -Original Message- > From: ffmpeg-devel On Behalf Of Zhao > Zhili > Sent: Sunday, April 28, 2024 6:55 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH WIP 0/9] Refactor DNN > > > > > On Apr 28, 2024, at 18:34, Guo, Yejun

Re: [FFmpeg-devel] [PATCH v2] avformat: enable UDP IPv6 multicast interface selection using zone index

Le 29 avril 2024 11:20:24 GMT+03:00, Lynne a écrit : >> >They were they deprecated? >> >> They caused more bugs than they solved problems (because what we need is to >> add IPv6 to IPv4 apps, not IPv4 to IPv6 apps). >> > >What bugs did they cause? Obviously anything that assumes IPv6

[FFmpeg-devel] G729 encoding

Hi to all, when will be available the g729 encoding features ? Thanks Marco Marco Garbin Net Reply Via Robert Koch, 1/4 20152 - Milano - ITALY phone: +39 02 535761 m.gar...@reply.it www.reply.it [https://images.reply.eu/img2/net.png]

[FFmpeg-devel] [PATCH v4 4/4] lavf: Add documentation for private "Context" classes

Doxygen thinks any text like "Context for foo" is a link to a struct called "Context". Add a description and a better link, to avoid confusing readers. --- libavformat/async.c | 3 +++ libavformat/cache.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/libavformat/async.c

[FFmpeg-devel] [PATCH v4 3/4] all: Link to "context" from all contexts with documentation

Some headings needed to be rewritten to accomodate the text, (hopefully) without changing the meaning. --- libavcodec/aac/aacdec.h| 2 +- libavcodec/aacenc.h| 2 +- libavcodec/ac3enc.h| 2 +- libavcodec/amfenc.h| 2 +-

[FFmpeg-devel] [PATCH v4 2/4] lavu: Clarify relationship between AVClass, AVOption and context

--- libavutil/log.h | 11 --- libavutil/opt.h | 7 --- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/libavutil/log.h b/libavutil/log.h index ab7ceabe22..cfbf416679 100644 --- a/libavutil/log.h +++ b/libavutil/log.h @@ -59,9 +59,14 @@ typedef enum { struct

[FFmpeg-devel] [PATCH v4 1/4] doc: Explain what "context" means

Derived from detailed explanations kindly provided by Stefano Sabatini: https://ffmpeg.org/pipermail/ffmpeg-devel/2024-April/325903.html --- doc/context.md | 308 + 1 file changed, 308 insertions(+) create mode 100644 doc/context.md diff --git

Re: [FFmpeg-devel] [PATCH v3 1/3] doc: Explain what "context" means

On Mon, Apr 22, 2024 at 07:05:12PM +0200, Stefano Sabatini wrote: > On date Monday 2024-04-22 16:56:48 +0100, Andrew Sayers wrote: > > Derived from detailed explanations kindly provided by Stefano Sabatini: > > https://ffmpeg.org/pipermail/ffmpeg-devel/2024-April/325903.html > > --- > >

Re: [FFmpeg-devel] [PATCH] doc/Doxfyile: Refactor for maintainability

On Sun, Apr 28, 2024 at 11:46:18PM +0200, Michael Niedermayer wrote: > Hi > > On Sun, Apr 28, 2024 at 11:10:22AM +0100, Andrew Sayers wrote: > [...] > > Ping ? > > > > Michael, this is in response to your request[0]. I've queued up some more > > patches that depend on this and would help

Re: [FFmpeg-devel] [PATCH v2] avformat: enable UDP IPv6 multicast interface selection using zone index

Apr 29, 2024, 09:34 by r...@remlab.net: > > > Le 28 avril 2024 23:11:48 GMT+03:00, Lynne a écrit : > >Apr 28, 2024, 20:15 by r...@remlab.net: > >>> Le torstaina 11. huhtikuuta 2024, 10.50.01 EEST Lynne a écrit : >>> Is there a reason why we can't switch to IPv4 addresses mapped in IPv6

Re: [FFmpeg-devel] [PATCH v2] avformat: enable UDP IPv6 multicast interface selection using zone index

Le 28 avril 2024 23:11:48 GMT+03:00, Lynne a écrit : >Apr 28, 2024, 20:15 by r...@remlab.net: > >> Le torstaina 11. huhtikuuta 2024, 10.50.01 EEST Lynne a écrit : >> >>> Is there a reason why we can't switch to IPv4 addresses mapped >>> in IPv6 and just use the IPv6 API everywhere? >>> >> >>

[FFmpeg-devel] [PATCH 2/2] lavc/blockdsp: R-V V fill_block

From 4315f4e4774e3006d7cc55b6d235cb80e0173cf9 Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Wed, 6 Mar 2024 12:46:03 +0800 Subject: [PATCH 2/2] lavc/blockdsp: R-V V fill_block C908: blockdsp.fill_block_tab[0]_c: 550.0 blockdsp.fill_block_tab[0]_rvv_i64: 48.2 blockdsp.fill_block_tab[1]_c: 148.7

[FFmpeg-devel] [PATCH 1/2] checkasm/blockdsp: add fill_block test

From 0c196a37cb4036d8c618c06c02a011b910cc56ce Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Mon, 29 Apr 2024 14:18:23 +0800 Subject: [PATCH 1/2] checkasm/blockdsp: add fill_block test --- tests/checkasm/blockdsp.c | 32 1 file changed, 32 insertions(+) diff

Re: [FFmpeg-devel] [PATCH 2/2] lavc/vc1dsp: R-V V mspel_pixels

Happy to see you back :) Rémi Denis-Courmont 于2024年4月29日周一 02:06写道： > Le sunnuntaina 7. huhtikuuta 2024, 8.38.54 EEST flow gg a écrit : > > ping > > I have been away for a while, and catching up takes time, sorry. > > -- > レミ・デニ-クールモン > http://www.remlab.net/ >

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/atrac9dec: Check init_get_bits8() for failure

On Sun, Apr 28, 2024 at 11:31 PM Michael Niedermayer wrote: > Fixes: CID1439569 Unchecked return value > Fixes: CID1439578 Unchecked return value > > Sponsored-by: Sovereign Tech Fund > And they paid you for this low effort work! Applause! > Signed-off-by: Michael Niedermayer > --- >

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

On 4/19/24 09:50, Niklas Haas wrote: So, rather than all of the above, what I think we should do is contract somebody to set up, manage, host and maintain a GitLab instance for us. This would probably be the single most cost effective boost to both community growth and innovation I can think