Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: av1 decoding not copying the sequence header obu into the bitstream

On Mon, May 6, 2024 at 3:45 PM Черненко Руслан wrote: > > Signed-off-by: Chernenko Ruslan > --- > libavcodec/videotoolbox_av1.c | 102 -- > 1 file changed, 72 insertions(+), 30 deletions(-) > > diff --git a/libavcodec/videotoolbox_av1.c

[FFmpeg-devel] [PATCH] MAINTAINERS: add myself as *BSD maintainer

MAINTAINERS: add myself as *BSD maintainer I try to help out with *BSD patches or build related issues where I can. Signed-off-by: Brad Smith --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index dd633f37e8..41a98744ad 100644 --- a/MAINTAINERS +++

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/lpc: copy levenson coeffs only when they have been computed

On 12/05/2024 02:18, Michael Niedermayer wrote: On Sun, May 12, 2024 at 02:13:06AM +0200, Lynne via ffmpeg-devel wrote: On 12/05/2024 02:03, Michael Niedermayer wrote: Fixes: CID1473514 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer ---

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/lpc: copy levenson coeffs only when they have been computed

On Sun, May 12, 2024 at 02:13:06AM +0200, Lynne via ffmpeg-devel wrote: > On 12/05/2024 02:03, Michael Niedermayer wrote: > > Fixes: CID1473514 Uninitialized scalar variable > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/lpc.c | 5 +++--

Re: [FFmpeg-devel] [PATCH] avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD

On 2024-05-11 8:13 p.m., Michael Niedermayer wrote: Hi On Sat, May 11, 2024 at 06:24:32PM -0400, Brad Smith wrote: On 2024-05-11 5:49 p.m., Michael Niedermayer wrote: On Sat, May 11, 2024 at 03:55:44PM -0400, Brad Smith wrote: On 2024-05-06 10:24 p.m., Michael Niedermayer wrote: On Sun, May

Re: [FFmpeg-devel] [PATCH] avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD

Hi On Sat, May 11, 2024 at 06:24:32PM -0400, Brad Smith wrote: > On 2024-05-11 5:49 p.m., Michael Niedermayer wrote: > > On Sat, May 11, 2024 at 03:55:44PM -0400, Brad Smith wrote: > > > On 2024-05-06 10:24 p.m., Michael Niedermayer wrote: > > > > On Sun, May 05, 2024 at 11:21:58PM -0400, Brad

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/lpc: copy levenson coeffs only when they have been computed

On 12/05/2024 02:03, Michael Niedermayer wrote: Fixes: CID1473514 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/lpc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/lpc.c

[FFmpeg-devel] [PATCH 5/5] avcodec/mscc & mwsc: Check loop counts before use

This could cause timeouts Fixes: CID1439568 Untrusted loop bound Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/mscc.c | 6 ++ libavcodec/mwsc.c | 11 +++ 2 files changed, 17 insertions(+) diff --git a/libavcodec/mscc.c b/libavcodec/mscc.c

[FFmpeg-devel] [PATCH 4/5] avcodec/mpegvideo_enc: Fix potential overflow in RD

Fixes: CID1500285 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/mpegvideo_enc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index

[FFmpeg-devel] [PATCH 3/5] avcodec/mpeg4videodec: assert impossible wrap points

Helps: CID1473517 Uninitialized scalar variable Helps: CID1473497 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/mpeg4videodec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/mpeg4videodec.c

[FFmpeg-devel] [PATCH 2/5] avcodec/mpeg12dec: Use 64bit in bit computation

I dont think this can actually overflow but 64bit seems reasonable to use Fixes: CID1521983 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/mpeg12dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH 1/5] avcodec/lpc: copy levenson coeffs only when they have been computed

Fixes: CID1473514 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/lpc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/lpc.c b/libavcodec/lpc.c index 8305cc0596a..981dacce8a5 100644 ---

Re: [FFmpeg-devel] [PATCH 3/3] lavc/speedhqdec: Set AV_PICTURE_TYPE_I

fre 2024-05-10 klockan 14:48 +0200 skrev Andreas Rheinhardt: > Tomas Härdin: > > ons 2024-05-08 klockan 17:06 -0300 skrev James Almer: > > > On 5/8/2024 5:01 PM, Marton Balint wrote: > > > > > > > > > > > > On Wed, 8 May 2024, Tomas Härdin wrote: > > > > > > > > > > > > > > > > > > > > > >

Re: [FFmpeg-devel] [PATCH] avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD

On 2024-05-11 5:49 p.m., Michael Niedermayer wrote: On Sat, May 11, 2024 at 03:55:44PM -0400, Brad Smith wrote: On 2024-05-06 10:24 p.m., Michael Niedermayer wrote: On Sun, May 05, 2024 at 11:21:58PM -0400, Brad Smith wrote: avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD Use

Re: [FFmpeg-devel] [PATCH] avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD

On Sat, May 11, 2024 at 03:55:44PM -0400, Brad Smith wrote: > On 2024-05-06 10:24 p.m., Michael Niedermayer wrote: > > On Sun, May 05, 2024 at 11:21:58PM -0400, Brad Smith wrote: > > > avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD > > > > > > Use the machdep.altivec sysctl on

[FFmpeg-devel] [PATCH v2 49/71] avcodec/mpeg12dec: Only initialize IDCT for IPU

This is all that is used. This is in preparation for further commits that will extend ff_mpv_decode_init() in a way that will make it possible to fail and require cleanup. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12dec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[FFmpeg-devel] [PATCH v2 26/71] avcodec/h263: Move encoder-only part out of ff_h263_update_motion_val()

Signed-off-by: Andreas Rheinhardt --- libavcodec/h263.c | 9 - libavcodec/h263enc.h | 2 +- libavcodec/ituh263enc.c| 14 ++ libavcodec/mpegvideo_enc.c | 4 ++-- 4 files changed, 17 insertions(+), 12 deletions(-) diff --git a/libavcodec/h263.c

[FFmpeg-devel] [PATCH v2 13/71] avcodec/mpegvideo_motion: Optimize check away

Only MPEG-2 can have field motion vectors with coded fields. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_motion.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo_motion.c b/libavcodec/mpegvideo_motion.c index 01c8d82e98..5b72196395

[FFmpeg-devel] [PATCH v2 71/71] avcodec/vc1_pred: Fix indentation

Forgotten after 41f974205317f6f40e72c9689374ab52d490dc6a. Signed-off-by: Andreas Rheinhardt --- libavcodec/vc1_pred.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/libavcodec/vc1_pred.c b/libavcodec/vc1_pred.c index 6e260fa053..87d9b6d6dc

[FFmpeg-devel] [PATCH v2 70/71] avcodec/mpegvideo_enc: Binarize reference

The H.264 decoder used reference to store its picture_structure into it; yet it does not use mpegvideo any more since commit 2c541554076cc8a72e7145d4da30389ca763f32f. Afterwards commit 629259bdb58061b7b7c1ae4cdc44599f6c0bb050 removed the last remnants. Signed-off-by: Andreas Rheinhardt ---

[FFmpeg-devel] [PATCH v2 69/71] avcodec/ituh263enc: Remove redundant check

It is redundant due to the identical check in ff_mpv_encode_init(). Signed-off-by: Andreas Rheinhardt --- libavcodec/ituh263enc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/libavcodec/ituh263enc.c b/libavcodec/ituh263enc.c index b7c9f124a9..4b3c55896f 100644 ---

[FFmpeg-devel] [PATCH v2 68/71] avcodec/mpegvideo: Use enum for msmpeg4_version

Improves readability. Signed-off-by: Andreas Rheinhardt --- libavcodec/h263dec.c | 34 ++-- libavcodec/motion_est.c | 8 +-- libavcodec/mpegvideo.c | 6 +-- libavcodec/mpegvideo.h | 10 +++-

[FFmpeg-devel] [PATCH v2 67/71] avcodec/mpegvideo: Remove pblocks

It has been added in a579db0c4fe026d49c71d1ff64a2d1d07c152d68 due to XvMC, but today it is only used to swap U and V for VCR2, a MPEG-2 variant with U and V swapped. This can be done in a simpler fashion, namely by simply swapping the U and V pointers of the corresponding MPVWorkPictures.

[FFmpeg-devel] [PATCH v2 66/71] avcodec/mpeg12dec: Don't initialize inter_scantable

MPEG-1/2 only needs one scantable and therefore all code already uses the intra one. So stop initializing the inter one altogether. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12dec.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavcodec/mpeg12dec.c

[FFmpeg-devel] [PATCH v2 65/71] avcodec/mpeg12dec: Pass Mpeg1Context* in mpeg_field_start()

Avoids a cast. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12dec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 0d5540fd2f..52f98986f6 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@

[FFmpeg-devel] [PATCH v2 64/71] avcodec/mpegvideo_dec: Don't sync encoder-only coded_picture_number

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.c | 1 - libavcodec/mpegvideo_dec.c | 1 - 2 files changed, 2 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index 93df8a315d..8a8ff2fbd9 100644 --- a/libavcodec/mpegvideo.c +++ b/libavcodec/mpegvideo.c @@

[FFmpeg-devel] [PATCH v2 63/71] avcodec/mpegvideo_dec, rv34: Simplify check for "does pic exist?"

The days in which an MPVPicture* is set with the corresponding frame being blank are over; this allows to simplify some checks. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_dec.c | 10 +- libavcodec/rv34.c | 3 +-- 2 files changed, 6 insertions(+), 7 deletions(-)

[FFmpeg-devel] [PATCH v2 62/71] avcodec/mpeg12enc: Simplify writing startcodes

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12enc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c index 304cfb9046..ba56f0c37a 100644 --- a/libavcodec/mpeg12enc.c +++ b/libavcodec/mpeg12enc.c @@ -271,11 +271,10

[FFmpeg-devel] [PATCH v2 61/71] avcodec/mpegvideo_enc: Unify initializing PutBitContexts

This also rids us of the requirement to preserve the PutBitContext in ff_update_duplicate_context(). Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.c | 1 - libavcodec/mpegvideo_enc.c | 42 +- 2 files changed, 19 insertions(+), 24

[FFmpeg-devel] [PATCH v2 60/71] avcodec/mpegpicture: Avoid MotionEstContext in ff_mpeg_framesize_alloc()

Only set the ScratchpadContext and let the users that need it (i.e. encoders) set the MotionEstContext stuff themselves. Also add an explicit pointer to ScratchpadContext to point to the allocated buffer so that none of the other scratchpad pointers is singled out as being used for the

[FFmpeg-devel] [PATCH v2 59/71] avcodec/mpegpicture: Use union for b_scratchpad and rd_scratchpad

These pointers point to the same buffers, so one can just use a union for them and avoid synchronising one of them. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegpicture.c | 1 - libavcodec/mpegpicture.h | 6 -- libavcodec/mpegvideo.c | 1 - 3 files changed, 4 insertions(+), 4

[FFmpeg-devel] [PATCH v2 58/71] avcodec/mpegpicture: Avoid loop and branch when setting motion_val

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegpicture.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavcodec/mpegpicture.c b/libavcodec/mpegpicture.c index ea5d54c670..9308fce97c 100644 --- a/libavcodec/mpegpicture.c +++ b/libavcodec/mpegpicture.c @@

[FFmpeg-devel] [PATCH v2 57/71] avcodec/mpegpicture: Use ThreadProgress instead of ThreadFrame API

Given that MPVPictures are already directly shared between threads in case of frame-threaded decoding, one can simply use it to pass decoding progress information between threads. This allows to avoid one level of indirection; it also means avoids allocations (of the ThreadFrameProgress structure)

[FFmpeg-devel] [PATCH v2 56/71] avcodec/mpeg4videoenc: Simplify writing startcodes

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg4videoenc.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/libavcodec/mpeg4videoenc.c b/libavcodec/mpeg4videoenc.c index 76960c2ced..583ea9de6f 100644 --- a/libavcodec/mpeg4videoenc.c +++

[FFmpeg-devel] [PATCH v2 55/71] avcodec/mpeg4videoenc: Avoid branch for writing stuffing

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg4videoenc.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/mpeg4videoenc.c b/libavcodec/mpeg4videoenc.c index 2f4b1a1d52..76960c2ced 100644 --- a/libavcodec/mpeg4videoenc.c +++

[FFmpeg-devel] [PATCH v2 54/71] avcodec/mpegpicture: Make MPVPicture refcounted

Up until now, an initialized MpegEncContext had an array of MPVPictures (way more than were ever needed) and the MPVPicture* contained in the MPVWorkPictures as well as the input_picture and reordered_input_picture arrays (for the encoder) pointed into this array. Several of the pointers could

[FFmpeg-devel] [PATCH v2 53/71] avcodec/mpegvideo_dec: Add close function for mpegvideo-decoders

Currently identical to the H.261 and H.263 close functions (which it replaces). It will be extended in future commits. Signed-off-by: Andreas Rheinhardt --- libavcodec/flvdec.c| 4 ++-- libavcodec/h261dec.c | 11 +-- libavcodec/h263dec.c | 12 ++--

[FFmpeg-devel] [PATCH v2 52/71] avformat/riff: Declare VCR2 to be MPEG-2

This brings it in line with mpeg12dec.c. (This entry has been added before the MPEG2VIDEO codec id existed.) Signed-off-by: Andreas Rheinhardt --- libavformat/riff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/riff.c b/libavformat/riff.c index

[FFmpeg-devel] [PATCH v2 51/71] avcodec/mpeg12dec: Set out_format only once

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12dec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index e573d3cdff..0e2012b324 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -794,6 +794,8 @@

[FFmpeg-devel] [PATCH v2 50/71] avcodec/mpeg12dec: Remove write-only assignment

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12dec.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 3cd706de36..e573d3cdff 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -2788,8 +2788,6 @@ static int

[FFmpeg-devel] [PATCH v2 48/71] avcodec/mpeg12dec: Don't initialize inter tables for IPU

IPU is intra-only. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12dec.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index e3f2dd8af7..097e4ba19a 100644 --- a/libavcodec/mpeg12dec.c +++

[FFmpeg-devel] [PATCH v2 47/71] avcodec/mpegvideo_enc: Reindentation

Also try to use loop-scope for iterators. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 193 ++--- 1 file changed, 96 insertions(+), 97 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index

[FFmpeg-devel] [PATCH v2 46/71] avcodec/mpegvideo_enc: Return early when getting length of B frame chain

Possible now that this is a function of its own. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 025204f395..610067eaef 100644 ---

[FFmpeg-devel] [PATCH v2 45/71] avcodec/mpegvideo_enc: Factor setting length of B frame chain out

It already avoids a goto and will be useful in the future to be able to specify each functions tasks and obligations. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 33 + 1 file changed, 25 insertions(+), 8 deletions(-) diff --git

[FFmpeg-devel] [PATCH v2 44/71] avcodec/error_resilience: Deduplicate cleanup code

Signed-off-by: Andreas Rheinhardt --- libavcodec/error_resilience.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/libavcodec/error_resilience.c b/libavcodec/error_resilience.c index efbacb8760..66d03987b6 100644 --- a/libavcodec/error_resilience.c +++

[FFmpeg-devel] [PATCH v2 43/71] avcodec/mpegpicture: Split MPVPicture into WorkPicture and ordinary Pic

There are two types of MPVPictures: Three (cur_pic, last_pic, next_pic) that are directly part of MpegEncContext and an array of MPVPictures that are separately allocated and are mostly accessed via pointers (cur|last|next)_pic_ptr; they are also used to store AVFrames in the encoder (necessary

[FFmpeg-devel] [PATCH v2 42/71] avcodec/vc1_mc: Don't check AVFrame INTERLACE flags

Instead cache these values in VC1Context to avoid the indirection and AND. Signed-off-by: Andreas Rheinhardt --- libavcodec/vc1.h| 1 + libavcodec/vc1_mc.c | 20 +--- libavcodec/vc1dec.c | 2 ++ 3 files changed, 12 insertions(+), 11 deletions(-) diff --git

[FFmpeg-devel] [PATCH v2 41/71] avcodec/mpegpicture: Rename Picture->MPVPicture

Picture is just too generic. Signed-off-by: Andreas Rheinhardt --- libavcodec/dxva2_mpeg2.c | 2 +- libavcodec/dxva2_vc1.c| 4 ++-- libavcodec/intrax8.c | 2 +- libavcodec/intrax8.h | 2 +- libavcodec/ituh263dec.c | 4 ++-- libavcodec/mpeg4videoenc.c

[FFmpeg-devel] [PATCH v2 40/71] avcodec/mpegvideo_enc: Move copying properties to alloc_picture()

This way said function sets everything (except for the actual contents of the frame's data). Also rename it to prepare_picture() given its new role. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-)

[FFmpeg-devel] [PATCH v2 39/71] avcodec/mpegvideo_enc: Pass AVFrame*, not Picture* to alloc_picture()

It now only deals with the AVFrame and no longer with the accessories. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index

[FFmpeg-devel] [PATCH v2 38/71] avcodec/mpegpicture: Split ff_alloc_picture() into check and alloc part

ff_alloc_picture() currently does two things: It checks the consistency of the linesize (which should not be necessary, but is) and it allocates certain buffers. (It does not actually allocate the picture buffers, so its name is misleading.) This commit splits it into two separate functions. The

[FFmpeg-devel] [PATCH v2 37/71] avcodec/mpegpicture: Improve error messages and code

Make it clear that this is not a failure of get_buffer/the user, but a deficit of mpegvideo. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegpicture.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libavcodec/mpegpicture.c b/libavcodec/mpegpicture.c index

[FFmpeg-devel] [PATCH v2 36/71] avcodec/vc1_pred: Remove unused function parameter

Signed-off-by: Andreas Rheinhardt --- libavcodec/vc1_pred.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavcodec/vc1_pred.c b/libavcodec/vc1_pred.c index f5e80fe0ef..9141290d26 100644 --- a/libavcodec/vc1_pred.c +++ b/libavcodec/vc1_pred.c @@ -66,7

[FFmpeg-devel] [PATCH v2 35/71] avcodec/mpegvideo: Add const where appropriate

Specifically, add const to the pointed-to-type of pointers that point to something static or that belong to last_pic or next_pic (because modifying these might lead to data races). Signed-off-by: Andreas Rheinhardt --- libavcodec/h261dec.c | 2 +- libavcodec/h261enc.c

[FFmpeg-devel] [PATCH v2 34/71] avcodec/rv30, rv34, rv40: Avoid indirection

Use the cached values from MpegEncContext.(cur|last|next)_pic instead of the corresponding *_pic_ptr. Also do the same in wmv2dec.c and mpegvideo_enc.c. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 2 +- libavcodec/rv30.c | 18 +++--- libavcodec/rv34.c

[FFmpeg-devel] [PATCH v2 33/71] avcodec/mpegpicture: Cache AVFrame.data and linesize values

This avoids an indirection and is in preparation for removing the AVFrame from MpegEncContext.(cur|last|next)_pic altogether. Signed-off-by: Andreas Rheinhardt --- libavcodec/motion_est.c | 16 +++ libavcodec/mpeg12dec.c | 14 +++--- libavcodec/mpeg_er.c

[FFmpeg-devel] [PATCH v2 32/71] avcodec/mpegpicture: Reduce value of MAX_PLANES define

No mpegvideo based codec supports alpha. While just at it, also make the define shorter. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegpicture.h | 2 +- libavcodec/mpegvideo.h | 2 +- libavcodec/mpegvideo_enc.c | 7 +++ 3 files changed, 5 insertions(+), 6 deletions(-) diff

[FFmpeg-devel] [PATCH v2 30/71] avcodec/mpegvideo: Restrict resetting mbskip_table to MPEG-4 decoder

This is done due to invalid input and therefore the encoder is not affected by it. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index d82a89566c..4b1f882105 100644

[FFmpeg-devel] [PATCH v2 29/71] avcodec/h263: Move setting mbskip_table to decoder/encoders

This removes a branch from H.263 based decoders. Signed-off-by: Andreas Rheinhardt --- libavcodec/h263.c | 3 --- libavcodec/ituh263enc.c| 3 +++ libavcodec/mpeg4videodec.c | 4 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/libavcodec/h263.c

[FFmpeg-devel] [PATCH v2 28/71] avcodec/mpegvideo: Reindent after the previous commit

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index 5c6ec7db55..d82a89566c 100644 --- a/libavcodec/mpegvideo.c +++ b/libavcodec/mpegvideo.c @@ -617,12

[FFmpeg-devel] [PATCH v2 27/71] avcodec/h263, mpeg(picture|video): Only allocate mbskip_table for MPEG-4

It is the only user of said table and doing so is especially important given that this buffer is zeroed every time. Signed-off-by: Andreas Rheinhardt --- libavcodec/h263.c| 3 ++- libavcodec/mpegpicture.c | 3 ++- libavcodec/mpegvideo.c | 19 +++ 3 files changed, 15

[FFmpeg-devel] [PATCH v2 25/71] avcodec/mpegpicture: Use RefStruct-pool API

It involves less allocations and therefore has less potential errors to be checked. One consequence thereof is that updating the picture tables can no longer fail. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegpicture.c | 82 ++--

[FFmpeg-devel] [PATCH v2 24/71] avcodec/mpegpicture: Reindent after the previous commit

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegpicture.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libavcodec/mpegpicture.c b/libavcodec/mpegpicture.c index 2d3cc247c4..32ca037526 100644 --- a/libavcodec/mpegpicture.c +++ b/libavcodec/mpegpicture.c @@

[FFmpeg-devel] [PATCH v2 23/71] avcodec/mpegvideo, mpegpicture: Add buffer pool

This avoids constant allocations+frees and will also allow to simply switch to the RefStruct API, thereby avoiding the overhead of the AVBuffer API. It also simplifies the code, because it removes the "needs_realloc" field: It was added in 435c0b87d28b48dc2e0360adc404a0e2d66d16a0, before the

[FFmpeg-devel] [PATCH v2 22/71] avcodec/mpegvideo: Redo aligning mb_height for VC-1

VC-1 can switch from between being progressive and interlaced on a per-frame basis. In the latter case, the number of macroblocks is aligned to two (or equivalently, the height to 32); therefore certain buffers are allocated for the bigger mb_height (see 950fb8acb42f4dab9b1638721992991c0584dbf5

[FFmpeg-devel] [PATCH v2 21/71] avcodec/mpegpicture: Always reset mbskip_table

Codecs call ff_find_unused_picture() to get the index of an unused picture; said picture may have buffers left from using it previously (these buffers are intentionally not unreferenced so that it might be possible to reuse them; they are only reused when they are writable, otherwise they are

[FFmpeg-devel] [PATCH v2 20/71] avcodec/mpegpicture: Always reset motion val buffer

Codecs call ff_find_unused_picture() to get the index of an unused picture; said picture may have buffers left from using it previously (these buffers are intentionally not unreferenced so that it might be possible to reuse them; this is mpegvideo's version of a bufferpool). They should not make

[FFmpeg-devel] [PATCH v2 19/71] avcodec/mpegvideo: Only allocate cbp_table, pred_dir_table when needed

Namely for the MPEG-4 decoder. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index ca6e637920..2ef69a5224 100644 --- a/libavcodec/mpegvideo.c +++

[FFmpeg-devel] [PATCH v2 18/71] avcodec/mpegvideo: Don't reset coded_block unnecessarily

coded_block is only used for I-frames, so it is unnecessary to reset it in ff_clean_intra_table_entries() (which cleans certain tables for a non-intra MB). Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git

[FFmpeg-devel] [PATCH v2 17/71] avcodec/mpegvideo: Only allocate coded_block when needed

It is only needed for msmpeg4v3, wmv1, wmv2 and VC-1. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index 130ccb4c97..74be22346d 100644 ---

[FFmpeg-devel] [PATCH v2 16/71] avcodec/msmpeg4enc: Only calculate coded_cbp when used

With this patch, msmpeg4v1 and msmpeg4v2 no longer use MpegEncContext.coded_block. Signed-off-by: Andreas Rheinhardt --- libavcodec/msmpeg4enc.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/libavcodec/msmpeg4enc.c b/libavcodec/msmpeg4enc.c

[FFmpeg-devel] [PATCH v2 15/71] avcodec/mpegvideo_motion: Avoid constant function argument

Always 8. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_motion.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/mpegvideo_motion.c b/libavcodec/mpegvideo_motion.c index ccda20c0f1..56bdce59c0 100644 --- a/libavcodec/mpegvideo_motion.c

[FFmpeg-devel] [PATCH v2 14/71] avcodec/mpegvideo_motion: Optimize check away

When !CONFIG_SMALL, we create separate functions for FMT_MPEG1 (i.e. for MPEG-1/2); given that there are only three possibilities for out_format (FMT_MPEG1, FMT_H263 and FMT_H261 -- MJPEG and SpeedHQ are both intra-only and do not have motion vectors at all, ergo they don't call this function),

[FFmpeg-devel] [PATCH v2 12/71] avcodec/mpegvideo_motion: Remove dead checks for existence of reference

These references now always exist due to dummy frames. Also remove the corresponding checks in the lowres code in mpegvideo_dec.c. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_dec.c| 12 libavcodec/mpegvideo_motion.c | 12 2 files changed, 8

[FFmpeg-devel] [PATCH v2 11/71] avcodec/mpeg12dec: Allocate dummy frames for non-I fields

MPEG-2 allows to pair an intra field (as first field) together with a P-field. In this case a conformant bitstream has to satisfy certain restrictions in order to ensure that only the I field is used for prediction. See section 7.6.3.5 of the MPEG-2 specifications. We do not check these

[FFmpeg-devel] [PATCH v2 10/71] avcodec/mpegpicture: Mark dummy frames as such

This will allow to avoid outputting them. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegpicture.c | 2 ++ libavcodec/mpegpicture.h | 1 + libavcodec/mpegvideo_dec.c | 2 ++ 3 files changed, 5 insertions(+) diff --git a/libavcodec/mpegpicture.c b/libavcodec/mpegpicture.c index

[FFmpeg-devel] [PATCH v2 09/71] avcodec/mpegvideo_dec: Factor allocating dummy frames out

This will allow to reuse it to allocate dummy frames for the second field (which can be a P-field even if the first field was an intra field). Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_dec.c | 85 +++--- libavcodec/mpegvideodec.h | 4 ++ 2

[FFmpeg-devel] [PATCH v2 08/71] avcodec/mpegvideo_dec: Sync linesize and uvlinesize between threads

linesize and uvlinesize are supposed to be the common linesize of all the Y/UV-planes of all the currently cached pictures. ff_mpeg_update_thread_context() syncs the pictures, yet it did not sync linesize and uvlinesize. This mostly works, because ff_alloc_picture() only accepts new pictures if

[FFmpeg-devel] [PATCH v2 07/71] avcodec/mpegpicture: Store linesize in ScratchpadContext

The mpegvideo-based codecs currently require the linesize to be constant (except when the frame dimensions change); one reason for this is that certain scratch buffers whose size depend on linesize are only allocated once and are presumed to be correctly sized if the pointers are != NULL. This

[FFmpeg-devel] [PATCH v2 06/71] avcodec/get_buffer: Remove redundant check

It is unnecessary to check for whether the number of planes of an already existing audio pool coincides with the number of planes to use for the frame: If the common format of both is planar, then the number of planes coincides with the number of channels for which there is already a check*; if

[FFmpeg-devel] [PATCH v2 05/71] avcodec/ratecontrol: Avoid padding in RateControlEntry

Signed-off-by: Andreas Rheinhardt --- libavcodec/ratecontrol.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/ratecontrol.h b/libavcodec/ratecontrol.h index 1b49889f75..4d71a181b5 100644 --- a/libavcodec/ratecontrol.h +++ b/libavcodec/ratecontrol.h @@ -39,6

[FFmpeg-devel] [PATCH v2 02/71] avcodec/ratecontrol: Pass RCContext directly in ff_rate_control_uninit()

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 2 +- libavcodec/ratecontrol.c | 5 ++--- libavcodec/ratecontrol.h | 2 +- libavcodec/snowenc.c | 2 +- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c

[FFmpeg-devel] [PATCH v2 04/71] avcodec/mpegvideo, ratecontrol: Remove write-only skip_count

Write-only since 6cf0cb8935f515a7b5f79d2e3cf02bd0764943bf. Signed-off-by: Andreas Rheinhardt --- libavcodec/h261enc.c | 1 - libavcodec/ituh263enc.c| 1 - libavcodec/mpeg12enc.c | 1 - libavcodec/mpeg4videoenc.c | 3 --- libavcodec/mpegvideo.h | 1 -

[FFmpeg-devel] [PATCH v2 03/71] avcodec/ratecontrol: Don't call ff_rate_control_uninit() ourselves

It is currently done inconsistently: Only one error path (namely the one from init_pass2()) made ff_rate_control_init() call ff_rate_control_uninit(); in other error paths cleanup was left to the caller. Given that the only caller of this function already performs the necessary cleanup this

[FFmpeg-devel] [PATCH 2/2 v2] checkasm/flacdsp: sanitize lpc arguments

Fixes signed integer overflows as reported by ubsan. Signed-off-by: James Almer --- Now allowing negative values. tests/checkasm/flacdsp.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/tests/checkasm/flacdsp.c b/tests/checkasm/flacdsp.c index

[FFmpeg-devel] [PATCH v2 01/71] avcodec/ratecontrol: Fix double free on error

Happens on init_pass2() failure. Signed-off-by: Andreas Rheinhardt --- libavcodec/ratecontrol.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/ratecontrol.c b/libavcodec/ratecontrol.c index 9ee08ecb88..27017d7976 100644 --- a/libavcodec/ratecontrol.c +++

Re: [FFmpeg-devel] [PATCH v4 1/2] checkasm: add test for fdct

On Sat, May 11, 2024 at 10:32 AM Ramiro Polla wrote: > On Mon, May 6, 2024 at 7:46 PM Rémi Denis-Courmont wrote: [...] > > No objections from me, but it would be nice and seemingly trivial to add 9 > > and > > 10 bits while at it. [...] > I'll add checks for the 9 and 10 bits later. Apparently

Re: [FFmpeg-devel] [PATCH] avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD

On 2024-05-06 10:24 p.m., Michael Niedermayer wrote: On Sun, May 05, 2024 at 11:21:58PM -0400, Brad Smith wrote: avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD Use the machdep.altivec sysctl on NetBSD for AltiVec detection as is done with OpenBSD. Signed-off-by: Brad Smith ---

[FFmpeg-devel] [PATCH 2/2] checkasm/flacdsp: sanitize lpc arguments

Fixes signed integer overflows as reported by ubsan. Signed-off-by: James Almer --- tests/checkasm/flacdsp.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/tests/checkasm/flacdsp.c b/tests/checkasm/flacdsp.c index 6561b4ed20..bf25cea39c 100644 ---

[FFmpeg-devel] [PATCH 1/2] checkasm/flacdsp: run lpc benchmarks with an unmodified buffer

Signed-off-by: James Almer --- tests/checkasm/flacdsp.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/checkasm/flacdsp.c b/tests/checkasm/flacdsp.c index b308237db1..6561b4ed20 100644 --- a/tests/checkasm/flacdsp.c +++ b/tests/checkasm/flacdsp.c @@ -58,6 +58,7

[FFmpeg-devel] [PATCH] lavu/riscv: remove bogus B extension

The B Bit manipulation extension was not defined to this day, and probably never will. Instead it was broken down into Zba, Zbb, Zbc and Zbs with no particular blessed set to make up B. This removes the bogus field test. Linux never set this bit, nor (AFAICT) did FreeBSD or any other OS. We can

Re: [FFmpeg-devel] [PATCH v3 1/9] lavc/vp8dsp: R-V put_vp8_pixels

Wow, got it Rémi Denis-Courmont 于2024年5月11日周六 22:39写道： > Le maanantaina 6. toukokuuta 2024, 6.38.01 EEST u...@foxmail.com a écrit : > > From: sunyuechi > > > > C908: > > vp8_put_pixels4_c: 78.0 > > vp8_put_pixels4_rvi: 33.7 > > vp8_put_pixels8_c: 278.0 > > vp8_put_pixels8_rvi: 55.0 > >

[FFmpeg-devel] [PATCH 2/2] lavc/vp8dsp: restrict RVI optimisations

They are actually awfully slow if the CPU does not support misaligned accesses natively, so only use them if misaligned accesses are fast. --- libavcodec/riscv/vp8dsp_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/riscv/vp8dsp_init.c

[FFmpeg-devel] [PATCH 1/2] lavu/riscv: CPU flag for fast misaligned accesses

--- libavutil/cpu.c | 1 + libavutil/cpu.h | 1 + libavutil/riscv/cpu.c | 3 +++ libavutil/tests/cpu.c | 3 ++- tests/checkasm/checkasm.c | 1 + 5 files changed, 8 insertions(+), 1 deletion(-) diff --git a/libavutil/cpu.c b/libavutil/cpu.c index 396eeb38d6..9ac2f01c20

[FFmpeg-devel] [PATCH] lavu/riscv: fallback to raw hwprobe() system call

Not all C run-times support this, and even then, it will be a while before distributions provide recent enough versions thereof. Since this is a trivial system call wrapper, we might just as well call the corresponding kernel system call directly where the C run-time lacks support but the kernel

Re: [FFmpeg-devel] [PATCH v3 1/9] lavc/vp8dsp: R-V put_vp8_pixels

Le maanantaina 6. toukokuuta 2024, 6.38.01 EEST u...@foxmail.com a écrit : > From: sunyuechi > > C908: > vp8_put_pixels4_c: 78.0 > vp8_put_pixels4_rvi: 33.7 > vp8_put_pixels8_c: 278.0 > vp8_put_pixels8_rvi: 55.0 > vp8_put_pixels16_c: 999.0 > vp8_put_pixels16_rvi: 86.7 Actually, I do think that

[FFmpeg-devel] [PATCH v2 2/2][GSoC 2024] Terminal tests/checkasm: Add check_vvc_sad to vvc_mc.c

Adds checkasm for DMVR SAD AVX2 implementation. Benchmarks ( AMD 7940HS ) vvc_sad_8x8_c: 63.0 vvc_sad_8x8_avx2: 3.0 vvc_sad_16x16_c: 263.0 vvc_sad_16x16_avx2: 23.0 vvc_sad_32x32_c: 1003.0 vvc_sad_32x32_avx2: 83.0 vvc_sad_64x64_c: 3923.0 vvc_sad_64x64_avx2: 373.0 vvc_sad_128x128_c: 17533.0

[FFmpeg-devel] [PATCH v2 1/2][GSoC] libavcodec/x86/vvc: Add AVX2 DMVR SAD functions for VVC

Implements AVX2 DMVR (decoder-side motion vector refinement) SAD functions. DMVR SAD is only calculated if w >= 8, h >= 8, and w * h > 128. To reduce complexity, SAD is only calculated on even rows. This is calculated for all video bitdepths, but the values passed to the function are always

Re: [FFmpeg-devel] [PATCH v2] libavfilter: add PipeWire-based grab

(only reviewing the documentation, not the code itself) On Fri, May 10, 2024 at 05:12:19PM -0400, François-Simon Fauteux-Chapleau wrote: > This is a revised version of the "pipewiregrab" patch submitted by > Abhishek Ojha a few months ago: >

Re: [FFmpeg-devel] [PATCH] avfilter/src_movie: Remove align dimension to fix crash

On Sat, May 11, 2024 at 3:24 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Paul B Mahol: > > On Sat, May 11, 2024 at 5:28 AM James Almer wrote: > > > >> On 5/10/2024 6:26 PM, Paul B Mahol wrote: > >>> On Fri, May 10, 2024 at 10:56 AM Zhao Zhili > >> wrote: > >>> > From:

  1   2   >