Re: [FFmpeg-devel] [PATCH] tiff: fix leaking yuv_line

On 16.02.2017 03:15, Michael Niedermayer wrote: > On Thu, Feb 16, 2017 at 12:23:28AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >> --- >> libavcodec/tiff.c | 1 + >> 1 file changed, 1 insertion(+) >&

Re: [FFmpeg-devel] [PATCH] mpegaudiodec_template: fix leaking fdsp for mp3on4float

On 16.02.2017 03:12, Michael Niedermayer wrote: > On Thu, Feb 16, 2017 at 12:39:17AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >> --- >> libavcodec/mpegaudiodec_template.c | 3 +++ >> 1 file changed,

Re: [FFmpeg-devel] [PATCH] wmaprodec: fix leaking fdsp on init failure

On 16.02.2017 03:04, Michael Niedermayer wrote: > On Thu, Feb 16, 2017 at 12:56:38AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >> --- >> libavcodec/wmaprodec.c | 7 --- >> 1 file changed, 4 insertio

[FFmpeg-devel] [PATCH] bink: fix leaking last frame on error

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavcodec/bink.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/bink.c b/libavcodec/bink.c index cc55870114..91004a6ae5 100644 --- a/libavcodec/bink.c +++ b/libavcodec/

[FFmpeg-devel] [PATCH] mpegaudiodec_template: fix leaking fdsp for mp3on4float

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavcodec/mpegaudiodec_template.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/mpegaudiodec_template.c b/libavcodec/mpegaudiodec_template.c index 1114428f33..53c09edced 100644 --- a/liba

[FFmpeg-devel] [PATCH] tiff: fix leaking yuv_line

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavcodec/tiff.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index efbd9791a5..474ea90015 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@ -1386,6 +1386,7 @@

Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

On 01.02.2017 17:25, Steinar H. Gunderson wrote: > On Wed, Feb 01, 2017 at 02:17:05AM +0100, Andreas Cadhalpun wrote: >>> Would you mind sharing an input where this actually triggers? None of the >>> samples I have seem to trigger this, so I suppose it's some sort of fuzzed

Re: [FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

On 31.01.2017 13:45, Ronald S. Bultje wrote: > I don't want this patch. I also don't want to discuss it further. Please > remove the log message. Thank you. For the sake of ending this, I've removed them. Please avoid complaining about log messages for my future patches. Thank you. Best regards,

Re: [FFmpeg-devel] [PATCH] pgssubdec: reset rle_data_len/rle_remaining_len on allocation error

On 31.01.2017 15:13, Michael Niedermayer wrote: > On Tue, Jan 31, 2017 at 01:59:38AM +0100, Andreas Cadhalpun wrote: >> The code relies on their validity and otherwise can try to access a NULL >> object->rle pointer, causing segmentation faults. >> >> Si

Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

On 31.01.2017 09:43, Steinar H. Gunderson wrote: > On Tue, Jan 31, 2017 at 01:57:31AM +0100, Andreas Cadhalpun wrote: >>> This sounds like a strangeness in constructing the table, which shouldn't be >>> papered over in the inner loop of the decoder. >> Maybe, I d

Re: [FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

On 30.01.2017 17:17, Ronald S. Bultje wrote: > On Sun, Jan 29, 2017 at 7:37 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> On 29.01.2017 04:46, Ronald S. Bultje wrote: >>> Hm ... So I guess I wasn't clear about this, but the reason I didn't

Re: [FFmpeg-devel] [PATCH 4/9] ircamdec: prevent overflow during block alignment calculation

On 30.01.2017 09:52, Paul B Mahol wrote: > On 1/30/17, Andreas Cadhalpun <andreas.cadhal...@googlemail.com> wrote: >> On 29.01.2017 02:34, Michael Niedermayer wrote: >>> On Thu, Jan 26, 2017 at 02:12:19AM +0100, Andreas Cadhalpun wrote: >>>> Signed-off-b

[FFmpeg-devel] [PATCH] pgssubdec: reset rle_data_len/rle_remaining_len on allocation error

The code relies on their validity and otherwise can try to access a NULL object->rle pointer, causing segmentation faults. Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavcodec/pgssubdec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) d

Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

On 31.01.2017 00:59, Steinar H. Gunderson wrote: > On Tue, Jan 31, 2017 at 12:49:56AM +0100, Andreas Cadhalpun wrote: >>> How can you get a negative run, which would be required for this to happen? >> Some values in ff_dc_alpha_run_vlc_le.table are negative, e.g.: >> ff_d

Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

On 30.01.2017 09:23, Steinar H. Gunderson wrote: > How can you get a negative run, which would be required for this to happen? Some values in ff_dc_alpha_run_vlc_le.table are negative, e.g.: ff_dc_alpha_run_vlc_le.table[32] = {-1, 0} Best regards, Andreas

[FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

Fixes out-of-bounds writes. Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavcodec/speedhq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/speedhq.c b/libavcodec/speedhq.c index 385f779f83..6ae1e0f8df 100644 --- a/libavcodec/spe

Re: [FFmpeg-devel] [PATCH 8/9] xvag: prevent overflow during block alignment calculation

On 29.01.2017 09:51, Paul B Mahol wrote: > On 1/29/17, Michael Niedermayer <michae...@gmx.at> wrote: >> On Thu, Jan 26, 2017 at 02:13:48AM +0100, Andreas Cadhalpun wrote: >>> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >>> --- >

Re: [FFmpeg-devel] [PATCH 3/9] genh: prevent overflow during block alignment calculation

On 29.01.2017 09:52, Paul B Mahol wrote: > On 1/29/17, Michael Niedermayer <michae...@gmx.at> wrote: >> On Thu, Jan 26, 2017 at 02:11:54AM +0100, Andreas Cadhalpun wrote: >>> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >>> --- >

Re: [FFmpeg-devel] [PATCH 7/9] epafdec: prevent overflow during block alignment calculation

On 29.01.2017 09:51, Paul B Mahol wrote: > On 1/29/17, Michael Niedermayer <michae...@gmx.at> wrote: >> On Thu, Jan 26, 2017 at 02:13:33AM +0100, Andreas Cadhalpun wrote: >>> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >>> --- >>

Re: [FFmpeg-devel] [PATCH 4/9] ircamdec: prevent overflow during block alignment calculation

On 29.01.2017 02:34, Michael Niedermayer wrote: > On Thu, Jan 26, 2017 at 02:12:19AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >> --- >> libavformat/ircamdec.c | 6 ++ >> 1 file changed, 6 insertions

Re: [FFmpeg-devel] [PATCH 5/9] nistspheredec: prevent overflow during block alignment calculation

On 29.01.2017 04:02, Marton Balint wrote: > > On Sun, 29 Jan 2017, Andreas Cadhalpun wrote: > >> On 28.01.2017 12:44, Marton Balint wrote: >>> If we reduce the number of extra lines (not at any cost), I think that >>> helps. >>> There is also a sol

Re: [FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

On 29.01.2017 04:46, Ronald S. Bultje wrote: > Hm ... So I guess I wasn't clear about this, but the reason I didn't reply > to other patches with log messages was not because I'm OK with, but simply > to keep the discussion contained in a single thread and not spam the list. > I'd prefer if the

Re: [FFmpeg-devel] [PATCH 2/9] electronicarts: prevent overflow during block alignment calculation

On 27.01.2017 01:44, Michael Niedermayer wrote: > On Thu, Jan 26, 2017 at 02:11:31AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >> --- >> libavformat/electronicarts.c | 2 +- >> 1 file changed, 1 inse

Re: [FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

On 27.01.2017 03:27, Michael Niedermayer wrote: > On Thu, Jan 26, 2017 at 02:14:09AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >> --- >> libavformat/boadec.c | 14 +- >> 1 file chan

Re: [FFmpeg-devel] [PATCH 6/9] pvfdec: prevent overflow during block alignment calculation

On 26.01.2017 09:37, Paul B Mahol wrote: > On 1/26/17, Andreas Cadhalpun <andreas.cadhal...@googlemail.com> wrote: >> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >> --- >> libavformat/pvfdec.c | 4 +++- >> 1 file changed, 3 insertions

Re: [FFmpeg-devel] [PATCH 1/9] 4xm: prevent overflow during block alignment calculation

On 26.01.2017 03:21, Michael Niedermayer wrote: > On Thu, Jan 26, 2017 at 02:11:02AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >> --- >> libavformat/4xm.c | 5 - >> 1 file changed, 4 insertions(+),

Re: [FFmpeg-devel] [PATCH 5/9] nistspheredec: prevent overflow during block alignment calculation

On 29.01.2017 00:26, Paul B Mahol wrote: > On 1/29/17, Andreas Cadhalpun <andreas.cadhal...@googlemail.com> wrote: >> On 28.01.2017 12:44, Marton Balint wrote: >>> If we reduce the number of extra lines (not at any cost), I think that >>> helps. >>

Re: [FFmpeg-devel] [PATCH 5/9] nistspheredec: prevent overflow during block alignment calculation

On 28.01.2017 12:44, Marton Balint wrote: > If we reduce the number of extra lines (not at any cost), I think that helps. > There is also a solution which keeps the traditional C syntax, and is easy to > undestand even at first glance. > > if (st->codecpar->channels > FF_SANE_NB_CHANNELS) >

Re: [FFmpeg-devel] [PATCH 5/9] nistspheredec: prevent overflow during block alignment calculation

On 28.01.2017 03:48, Ronald S. Bultje wrote: > I agree a macro here doesn't help. My concern wasn't with the check itself, > I agree a file with 100 channels should error out. My concern is that these > files will universally be the result of fuzzing, so I don't want to spam > stderr with messages

Re: [FFmpeg-devel] [PATCH 5/9] nistspheredec: prevent overflow during block alignment calculation

On 27.01.2017 02:56, Marton Balint wrote: > I see 3 problems (wm4 explicitly named them, but I also had them in mind) > - Little benefit, yet > - Makes the code less clean, more cluttered > - Increases binary size > > The ideas I proposed (use macros, use common / factorized checks for common >

Re: [FFmpeg-devel] [PATCH 1/3] mpeg12dec: validate color space

On 26.01.2017 13:59, Ronald S. Bultje wrote: > On Wed, Jan 25, 2017 at 8:56 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: >> On 26.01.2017 02:26, Ronald S. Bultje wrote: >>> The question is not whether changing A or B towards the other makes the

Re: [FFmpeg-devel] [PATCH 5/9] nistspheredec: prevent overflow during block alignment calculation

On 26.01.2017 02:29, Ronald S. Bultje wrote: > On Wed, Jan 25, 2017 at 8:12 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >> --- >> libavformat/nistspheredec.c

Re: [FFmpeg-devel] [PATCH 1/3] mpeg12dec: validate color space

On 26.01.2017 02:26, Ronald S. Bultje wrote: > Hi, > > On Wed, Jan 25, 2017 at 8:20 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> On 07.01.2017 13:44, Ronald S. Bultje wrote: >>> Doesn't this destroy exporting of newly added colorspac

Re: [FFmpeg-devel] [PATCH 1/3] mpeg12dec: validate color space

On 07.01.2017 13:44, Ronald S. Bultje wrote: > On Fri, Jan 6, 2017 at 9:35 PM, Michael Niedermayer <mich...@niedermayer.cc> > wrote: > >> On Fri, Jan 06, 2017 at 09:43:24PM +0100, Andreas Cadhalpun wrote: >>> On 23.12.2016 00:57, Andreas Cadhalpun wrote: >>

[FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/boadec.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/libavformat/boadec.c b/libavformat/boadec.c index ac2a33b3f0..6055effcad 100644 --- a/libavformat/boadec.c

[FFmpeg-devel] [PATCH 8/9] xvag: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/xvag.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/xvag.c b/libavformat/xvag.c index 5ef4fb0900..22e4f1e3c8 100644 --- a/libavformat/xvag.c +++ b/libavformat/xvag.c @@

[FFmpeg-devel] [PATCH 7/9] epafdec: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/epafdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/epafdec.c b/libavformat/epafdec.c index 29190fff72..0cd9627a4b 100644 --- a/libavformat/epafdec.c +++ b/libav

[FFmpeg-devel] [PATCH 6/9] pvfdec: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/pvfdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/pvfdec.c b/libavformat/pvfdec.c index b9f6d4f2c2..c6652b9b43 100644 --- a/libavformat/pvfdec.c +++ b/libavformat/pv

[FFmpeg-devel] [PATCH 5/9] nistspheredec: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/nistspheredec.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavformat/nistspheredec.c b/libavformat/nistspheredec.c index 782d1dfbfb..3386497682 100644 --- a/libavformat/nistspher

[FFmpeg-devel] [PATCH 4/9] ircamdec: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/ircamdec.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/ircamdec.c b/libavformat/ircamdec.c index 59f3a49411..e3196db84a 100644 --- a/libavformat/ircamdec.c +++ b/libavformat/irca

[FFmpeg-devel] [PATCH 3/9] genh: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/genh.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/genh.c b/libavformat/genh.c index b683e026d1..dd4e76d3d9 100644 --- a/libavformat/genh.c +++ b/libavformat/genh.c @@

[FFmpeg-devel] [PATCH 2/9] electronicarts: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/electronicarts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/electronicarts.c b/libavformat/electronicarts.c index 30eb723bd5..bfd3fed3a2 100644 --- a/libav

[FFmpeg-devel] [PATCH 1/9] 4xm: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/4xm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/4xm.c b/libavformat/4xm.c index 2758b69d29..ead6d2b424 100644 --- a/libavformat/4xm.c +++ b/libavformat/4xm.c @@

Re: [FFmpeg-devel] [PATCH 3/9] electronicarts: prevent overflow during block alignment calculation

On 07.01.2017 09:32, Paul B Mahol wrote: > On 1/7/17, Michael Niedermayer <mich...@niedermayer.cc> wrote: >> On Fri, Jan 06, 2017 at 08:47:39PM +0100, Andreas Cadhalpun wrote: >>> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >>> --

Re: [FFmpeg-devel] [PATCH 2/9] 4xm: prevent overflow during block alignment calculation

On 07.01.2017 02:31, Michael Niedermayer wrote: > On Fri, Jan 06, 2017 at 09:27:29PM +0100, Andreas Cadhalpun wrote: >> 4xm.c |1 + >> 1 file changed, 1 insertion(+) >> 4b27cb10f25865014fac1666956f7040d65113f9 >> 0002-4xm-prevent-overflow-during-block-align

Re: [FFmpeg-devel] [PATCH] h264_ps: validate chroma sample location

On 07.01.2017 01:41, Michael Niedermayer wrote: > On Fri, Jan 06, 2017 at 11:33:13PM +0100, Andreas Cadhalpun wrote: >> On 06.01.2017 22:47, Kieran Kunhya wrote: >>> On Fri, 6 Jan 2017 at 20:44 Andreas Cadhalpun < >>> andreas.cadhal...@googlemail.com> wrote

Re: [FFmpeg-devel] [PATCH] h264_ps: validate chroma sample location

On 06.01.2017 22:47, Kieran Kunhya wrote: > On Fri, 6 Jan 2017 at 20:44 Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >> --- >> libavcodec/h264_ps.c | 4 >>

Re: [FFmpeg-devel] [PATCH 6/9] nistspheredec: prevent overflow during block alignment calculation

On 06.01.2017 22:30, Ronald S. Bultje wrote: > On Fri, Jan 6, 2017 at 2:48 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >> --- >> libavformat/nistspheredec.

Re: [FFmpeg-devel] [PATCH 5/9] ircamdec: prevent overflow during block alignment calculation

On 06.01.2017 22:31, Ronald S. Bultje wrote: > On Fri, Jan 6, 2017 at 2:48 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >> --- >> libavformat/ircamdec.

[FFmpeg-devel] [PATCH] h264_ps: validate chroma sample location

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavcodec/h264_ps.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c index 8218e3a010..089bfc650a 100644 --- a/libavcodec/h264_ps.c +++ b/libavcodec/h264_ps.c @@

Re: [FFmpeg-devel] [PATCH 1/3] mpeg12dec: validate color space

On 23.12.2016 00:57, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> > --- > libavcodec/mpeg12dec.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c > index 63

Re: [FFmpeg-devel] [PATCH 2/9] 4xm: prevent overflow during block alignment calculation

On 06.01.2017 20:58, Ronald S. Bultje wrote: > Hi, > > On Fri, Jan 6, 2017 at 2:47 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >> --- >> libavforma

[FFmpeg-devel] [PATCH 2/9] 4xm: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/4xm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/4xm.c b/libavformat/4xm.c index 2758b69d29..45949c4e97 100644 --- a/libavformat/4xm.c +++ b/libavformat/4xm.c @@ -187,6 +187,7 @@ stat

[FFmpeg-devel] [PATCH 8/9] epafdec: prevent overflow during block alignment calculation

--- libavformat/epafdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/epafdec.c b/libavformat/epafdec.c index 29190fff72..b28f035cdf 100644 --- a/libavformat/epafdec.c +++ b/libavformat/epafdec.c @@ -83,6 +83,7 @@ static int epaf_read_header(AVFormatContext *s) }

[FFmpeg-devel] [PATCH 9/9] xvag: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/xvag.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/xvag.c b/libavformat/xvag.c index 5ef4fb0900..1f28df7b89 100644 --- a/libavformat/xvag.c +++ b/libavformat/xvag.c @@ -74,6 +74,7 @@ stat

[FFmpeg-devel] [PATCH 6/9] nistspheredec: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/nistspheredec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/nistspheredec.c b/libavformat/nistspheredec.c index 782d1dfbfb..9023ed7fc7 100644 --- a/libavformat/nistspheredec.c +++ b/libav

[FFmpeg-devel] [PATCH 7/9] pvfdec: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/pvfdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/pvfdec.c b/libavformat/pvfdec.c index b9f6d4f2c2..94ef20c249 100644 --- a/libavformat/pvfdec.c +++ b/libavformat/pvfdec.c @@ -56,6

[FFmpeg-devel] [PATCH 5/9] ircamdec: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/ircamdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/ircamdec.c b/libavformat/ircamdec.c index 59f3a49411..f3cf4d0dc9 100644 --- a/libavformat/ircamdec.c +++ b/libavformat/ircamdec.c @@

[FFmpeg-devel] [PATCH 4/9] genh: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/genh.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/genh.c b/libavformat/genh.c index b683e026d1..6ce2588ed3 100644 --- a/libavformat/genh.c +++ b/libavformat/genh.c @@ -74,6 +74,7 @@ stat

[FFmpeg-devel] [PATCH 3/9] electronicarts: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/electronicarts.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/electronicarts.c b/libavformat/electronicarts.c index 30eb723bd5..03422e5b2c 100644 --- a/libavformat/electronicarts.c

[FFmpeg-devel] [PATCH 1/9] avutil: add FF_RETURN_ON_OVERFLOW

Suggested-by: Rodger Combs <rodger.co...@gmail.com> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- Changed the name as suggested by wm4 and the return value as suggested by Muhammad Faiz. There are also two new overflow checks at the end of the series. --

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

On 11.12.2016 21:45, Andreas Cadhalpun wrote: > On 11.12.2016 21:03, Hendrik Leppkes wrote: >> On Sun, Dec 11, 2016 at 7:48 PM, Andreas Cadhalpun >> <andreas.cadhal...@googlemail.com> wrote: >>> On 11.12.2016 10:04, Hendrik Leppkes wrote: >>>> I still

Re: [FFmpeg-devel] [PATCH 1/3] omadec: fix overflows during bit rate calculation

On 15.12.2016 01:53, Andreas Cadhalpun wrote: > On 14.12.2016 11:16, Moritz Barsnick wrote: >> On Wed, Dec 14, 2016 at 01:02:41 +0100, Andreas Cadhalpun wrote: >>> On 13.12.2016 08:11, Paul B Mahol wrote: >>>>> -st->codecpar->bit_rate

Re: [FFmpeg-devel] [PATCH 1/2] wmavoice: truncate spillover_nbits if too large

On 02.01.2017 04:14, Ronald S. Bultje wrote: > On Sun, Jan 1, 2017 at 5:55 PM, Andreas Cadhalpun > <andreas.cadhal...@googlemail.com> wrote: > So what would you do instead? > > I'd just remove the message, but otherwise what you're doing (truncate > spillover_nbits)

Re: [FFmpeg-devel] [PATCH 2/2] wmavoice: prevent division by zero crash

On 02.01.2017 04:09, Ronald S. Bultje wrote: > On Sun, Jan 1, 2017 at 5:51 PM, Andreas Cadhalpun > <andreas.cadhal...@googlemail.com> wrote: > Fine for me. Patch doing that is attached. > > > LGTM. Pushed. Best regards, Andreas

Re: [FFmpeg-devel] [PATCH 1/2] wmavoice: truncate spillover_nbits if too large

On 01.01.2017 23:27, Ronald S. Bultje wrote: > On Sun, Jan 1, 2017 at 5:18 PM, Andreas Cadhalpun > <andreas.cadhal...@googlemail.com <mailto:andreas.cadhal...@googlemail.com>> > wrote: > > This fixes triggering the av_assert0(ret <= tmp.size). > > Th

Re: [FFmpeg-devel] [PATCH 2/2] wmavoice: prevent division by zero crash

On 01.01.2017 23:23, Ronald S. Bultje wrote: > On Sun, Jan 1, 2017 at 5:19 PM, Andreas Cadhalpun > <andreas.cadhal...@googlemail.com <mailto:andreas.cadhal...@googlemail.com>> > wrote: > > The problem was introduced by commit > 3deb4b54a24f8cddce463d9f575

[FFmpeg-devel] [PATCH 1/2] wmavoice: truncate spillover_nbits if too large

This fixes triggering the av_assert0(ret <= tmp.size). The problem was reintroduced by commit 7b27dd5c16de785297ce4de4b88afa0b6685f61d and originally fixed by 2a4700a4f03280fa8ba4fc0f8a9987bb550f0d1e. Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavcodec/w

[FFmpeg-devel] [PATCH 2/2] wmavoice: prevent division by zero crash

The problem was introduced by commit 3deb4b54a24f8cddce463d9f5751b01efeb976af. Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavcodec/wmavoice.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/wmavoice.c b/libavcodec/wmavoice.c

[FFmpeg-devel] [PATCH] libopenmpt: add missing avio_read return value check

This fixes heap-buffer-overflows in libopenmpt caused by interpreting the negative size value as unsigned size_t. Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/libopenmpt.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/libopenm

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec: add Apple Pixlet decoder

On 23.12.2016 09:17, Paul B Mahol wrote: > On 12/23/16, Andreas Cadhalpun <andreas.cadhal...@googlemail.com> wrote: >> On 22.12.2016 22:52, Paul B Mahol wrote: >>> +xflag = flag + cnt1; >>> +yflag = xflag; >>> + >>> +

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec: add Apple Pixlet decoder

On 22.12.2016 22:52, Paul B Mahol wrote: > ffmpeg | branch: master | Paul B Mahol | Fri Dec 2 > 20:30:50 2016 +0100| [73651090ca1183f37753ee30a7e206ca4fb9f4f0] | committer: > Paul B Mahol > > avcodec: add Apple Pixlet decoder > > Signed-off-by: Paul B Mahol

[FFmpeg-devel] [PATCH 2/3] mpeg12dec: validate color primaries

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavcodec/mpeg12dec.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index d3dc67ad6a..89aecd4de4 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg1

[FFmpeg-devel] [PATCH 3/3] mpeg12dec: validate color transfer characteristics

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavcodec/mpeg12dec.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 89aecd4de4..964f498f3b 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg1

[FFmpeg-devel] [PATCH 1/3] mpeg12dec: validate color space

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavcodec/mpeg12dec.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 63979079c8..d3dc67ad6a 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg1

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add FF_BAIL_ON_OVERFLOW

On 21.12.2016 13:46, wm4 wrote: > On Wed, 21 Dec 2016 01:43:46 +0100 > Andreas Cadhalpun <andreas.cadhal...@googlemail.com> wrote: >> On 20.12.2016 15:22, wm4 wrote: >>> On Mon, 19 Dec 2016 23:36:11 +0100 >>> Andreas Cadhalpun <andreas.cadhal...@googlemail.co

Re: [FFmpeg-devel] [PATCH 1/6] lavfi/buffersink: add accessors for the stream properties.

On 20.12.2016 15:46, wm4 wrote: > In general, replacing public fields with macro-generated accessors is > really just a rename. Admittedly, it removes a confusing indirection > (though ->inputs[0]) in this case, but in general the improvements are > very minor. What does it matter if whether there

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add FF_BAIL_ON_OVERFLOW

On 20.12.2016 15:22, wm4 wrote: > On Mon, 19 Dec 2016 23:36:11 +0100 > Andreas Cadhalpun <andreas.cadhal...@googlemail.com> wrote: > >> On 16.12.2016 17:22, wm4 wrote: >>> On Fri, 16 Dec 2016 03:32:07 +0100 >>> Andreas Cadhalpun <andreas.cadhal...@go

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add FF_BAIL_ON_OVERFLOW

On 20.12.2016 10:23, Muhammad Faiz wrote: > On 12/20/16, Andreas Cadhalpun <andreas.cadhal...@googlemail.com> wrote: >> On 16.12.2016 07:36, Muhammad Faiz wrote: >>> On 12/16/16, Andreas Cadhalpun <andreas.cadhal...@googlemail.com> wrote: >>>> Suggeste

Re: [FFmpeg-devel] [PATCH] swscale: also save ebx register when using PIE

On 20.12.2016 03:04, Michael Niedermayer wrote: > On Mon, Dec 19, 2016 at 11:28:44PM +0100, Andreas Cadhalpun wrote: >> On 16.12.2016 04:08, Michael Niedermayer wrote: >>> On Fri, Dec 16, 2016 at 02:36:53AM +0100, Andreas Cadhalpun wrote: >>>> Otherwise th

Re: [FFmpeg-devel] [PATCH 1/6] lavfi/buffersink: add accessors for the stream properties.

On 18.12.2016 13:22, Nicolas George wrote: > av_buffersink_get_frame_rate() did already exist; its argument becomes const. > > TODO minor version bump > > API-Change: libavfilter > Signed-off-by: Nicolas George > --- > libavfilter/buffersink.c | 25 +++-- >

Re: [FFmpeg-devel] [PATCH 2/2] wmavoice: don't error out if we're skipping more bits than available.

On 20.12.2016 00:59, Carl Eugen Hoyos wrote: > 2016-12-19 23:45 GMT+01:00 Andreas Cadhalpun > <andreas.cadhal...@googlemail.com>: >> On 16.12.2016 14:19, Ronald S. Bultje wrote: >>> This reverts 2a4700a4f03280fa8ba4fc0f8a9987bb550f0d1e and implements it >>>

Re: [FFmpeg-devel] [PATCH 2/2] wmavoice: don't error out if we're skipping more bits than available.

On 16.12.2016 14:19, Ronald S. Bultje wrote: > This reverts 2a4700a4f03280fa8ba4fc0f8a9987bb550f0d1e and implements it > correctly so streams actually decode the way the encoder intended them > to. Why is it correct? Is this behavior defined in a specification or reference decoder? > --- >

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add FF_BAIL_ON_OVERFLOW

On 16.12.2016 17:22, wm4 wrote: > On Fri, 16 Dec 2016 03:32:07 +0100 > Andreas Cadhalpun <andreas.cadhal...@googlemail.com> wrote: > >> Suggested-by: Rodger Combs <rodger.co...@gmail.com> >> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.co

Re: [FFmpeg-devel] [PATCH] swscale: also save ebx register when using PIE

On 16.12.2016 04:08, Michael Niedermayer wrote: > On Fri, Dec 16, 2016 at 02:36:53AM +0100, Andreas Cadhalpun wrote: >> Otherwise the build fails when configuring with --toolchain=hardened >> --disable-pic on i386 using gcc 4.8: >> error: PIC register clobbered by '%ebx' in '

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add FF_BAIL_ON_OVERFLOW

On 16.12.2016 07:36, Muhammad Faiz wrote: > On 12/16/16, Andreas Cadhalpun <andreas.cadhal...@googlemail.com> wrote: >> Suggested-by: Rodger Combs <rodger.co...@gmail.com> >> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >> --- >>

Re: [FFmpeg-devel] [PATCH 2/7] 4xm: prevent overflow during block alignment calculation

On 16.12.2016 03:33, Rodger Combs wrote: > >> On Dec 15, 2016, at 20:32, Andreas Cadhalpun >> <andreas.cadhal...@googlemail.com> wrote: >> >> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >> --- >> libavformat/4xm.c | 1 +

[FFmpeg-devel] [PATCH 6/7] nistspheredec: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/nistspheredec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/nistspheredec.c b/libavformat/nistspheredec.c index 782d1df..b5ebcb8 100644 --- a/libavformat/nistspheredec.c +++ b/libav

[FFmpeg-devel] [PATCH 7/7] pvfdec: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/pvfdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/pvfdec.c b/libavformat/pvfdec.c index b9f6d4f..868ef0b 100644 --- a/libavformat/pvfdec.c +++ b/libavformat/pvfdec.c @@ -56,6 +56,7 @@

[FFmpeg-devel] [PATCH 4/7] genh: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/genh.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/genh.c b/libavformat/genh.c index b683e02..e23c1b2 100644 --- a/libavformat/genh.c +++ b/libavformat/genh.c @@ -74,6 +74,7 @@ stat

[FFmpeg-devel] [PATCH 5/7] ircamdec: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/ircamdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/ircamdec.c b/libavformat/ircamdec.c index 59f3a49..3f92b6c 100644 --- a/libavformat/ircamdec.c +++ b/libavformat/ircamdec.c @@ -96,6

[FFmpeg-devel] [PATCH 3/7] electronicarts: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/electronicarts.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/electronicarts.c b/libavformat/electronicarts.c index 30eb723..9088fe1 100644 --- a/libavformat/electronicarts.c +++ b/libav

[FFmpeg-devel] [PATCH 2/7] 4xm: prevent overflow during block alignment calculation

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavformat/4xm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/4xm.c b/libavformat/4xm.c index 2758b69..9332f78 100644 --- a/libavformat/4xm.c +++ b/libavformat/4xm.c @@ -187,6 +187,7 @@ stat

[FFmpeg-devel] [PATCH 1/7] avutil: add FF_BAIL_ON_OVERFLOW

Suggested-by: Rodger Combs <rodger.co...@gmail.com> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libavutil/common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/common.h b/libavutil/common.h index 8142b31..00b7504 100644 --- a/libavutil/co

Re: [FFmpeg-devel] [PATCH 1/3] 4xm: prevent overflow during bit rate calculation

On 16.12.2016 02:29, Rodger Combs wrote: >> On Dec 15, 2016, at 19:21, Andreas Cadhalpun >> <andreas.cadhal...@googlemail.com> wrote: >> On 15.12.2016 14:02, Ronald S. Bultje wrote: >>> - if for whatever reason some things cannot be done in generic code or by &

[FFmpeg-devel] [PATCH] swscale: also save ebx register when using PIE

Otherwise the build fails when configuring with --toolchain=hardened --disable-pic on i386 using gcc 4.8: error: PIC register clobbered by '%ebx' in 'asm' Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libswscale/x86/hscale_fast_bilinear_simd.

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Avoid heap allocation wrap in mov_read_hdlr

On 15.12.2016 03:25, James Almer wrote: > On 12/14/2016 10:39 PM, Andreas Cadhalpun wrote: >> On 15.12.2016 00:34, Matthew Wolenetz wrote: >>> >>> From fd878457cd55690d4a27d74411b68a30c9fb2313 Mon Sep 17 00:00:00 2001 >>> From: Matt Wolenetz <wolen...@chromi

Re: [FFmpeg-devel] [PATCH 1/3] 4xm: prevent overflow during bit rate calculation

On 15.12.2016 14:02, Ronald S. Bultje wrote: > On Wed, Dec 14, 2016 at 7:11 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: >> On 14.12.2016 02:46, Ronald S. Bultje wrote: >>> Not wanting to discourage you, but I wonde

Re: [FFmpeg-devel] [PATCH] lavc/libopusdec.c Fix ff_vorbis_channel_layouts OOB

On 15.12.2016 00:39, Matthew Wolenetz wrote: > From 141e56ccf7fc56646424484d357b6c74a486d2e2 Mon Sep 17 00:00:00 2001 > From: Matt Wolenetz > Date: Mon, 21 Nov 2016 17:30:50 -0800 > Subject: [PATCH] lavc/libopusdec.c Fix ff_vorbis_channel_layouts OOB > > Similar to

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Avoid heap allocation wraps and OOB in mov_read_{senc, saiz, udta_string}()

On 15.12.2016 00:37, Matthew Wolenetz wrote: > From 8622f9398e7c89a664c4c2ceff9d35b89ff17bb5 Mon Sep 17 00:00:00 2001 > From: Matt Wolenetz > Date: Tue, 6 Dec 2016 12:54:23 -0800 > Subject: [PATCH] lavf/mov.c: Avoid heap allocation wraps and OOB in >

  1   2   3   4   5   6   7   8   9   10   >