[FFmpeg-devel] Re: [PATCH 1/7] matroskaenc: remove unused MaxBlockAdditionID

2025-09-20 Thread James Almer via ffmpeg-devel
On 9/9/2025 9:38 AM, Jerome Martinez via ffmpeg-devel wrote: diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 8142d9125e..5339b6fd33 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@ -1706,16 +1706,16 @@ static void mkv_write_blockadditionmapping(A

[FFmpeg-devel] [PATCH] avformat/movenc: clear subsample information on fragment flush (PR #20538)

2025-09-16 Thread James Almer via ffmpeg-devel
PR #20538 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20538 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20538.patch Don't keep around information from a previous traf atom. Fixes issue #20492. >From 9c18a8d1802726c7d59c5d067890b7f2f8c7

[FFmpeg-devel] [PATCH] avcodec/decode: sync initial_pict_type and intra_only_flag with thread worker's avctx (PR #20535)

2025-09-16 Thread James Almer via ffmpeg-devel
PR #20535 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20535 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20535.patch Regression since 5acbdd2264d3b90dc11369f9e031e762f260882e, which removed setting both values from PerThreadContext. Given the

[FFmpeg-devel] [PATCH] tests/fate/image: add Exif rotation metadata tests (PR #20522)

2025-09-14 Thread James Almer via ffmpeg-devel
PR #20522 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20522 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20522.patch >From f0e1180c15e63711ad9a8a0237cf8918af906a40 Mon Sep 17 00:00:00 2001 From: James Almer Date: Mon, 15 Sep 2025 00:21:39 -0

[FFmpeg-devel] [PATCH] avutil/aes_ctr: reintroduce the block offset state (PR #20479)

2025-09-09 Thread James Almer via ffmpeg-devel
PR #20479 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20479 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20479.patch Wrongly removed in fe73b84879a560d69affca88ce21e61108e7c38d, it's required for calls with a payload smaller than a full

[FFmpeg-devel] [PATCH] avfilter/buffersink: add missing checks for alphamodes (PR #20469)

2025-09-08 Thread James Almer via ffmpeg-devel
PR #20469 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20469 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20469.patch >From b186d5443afc5eda3c478c61eb8a29fc3821a898 Mon Sep 17 00:00:00 2001 From: James Almer Date: Mon, 8 Sep 2025 15:07:20 -0

[FFmpeg-devel] [PATCH] avutil/samplefmt: add a sample format descriptor API (PR #20461)

2025-09-07 Thread James Almer via ffmpeg-devel
PR #20461 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20461 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20461.patch Including some basic helpers. This will be useful among other things to ensure API users don't use AV_SAMPLE_FMT_NB.

[FFmpeg-devel] [PATCH] avcodec/codec_par: remove alpha_mode (PR #20414)

2025-09-03 Thread James Almer via ffmpeg-devel
PR #20414 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20414 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20414.patch It's not a value signaled at the container level, so it doesn't belong in this struct. As this field is barely a day o

[FFmpeg-devel] Re: [PATCH v3 2/2] avcodec/libaom: Add test for HDR10+ metadata support

2025-09-02 Thread James Almer via ffmpeg-devel
On 9/2/2025 10:30 AM, Michael Niedermayer via ffmpeg-devel wrote: On Wed, Aug 27, 2025 at 01:06:42PM +0200, Maryla Ustarroz via ffmpeg-devel wrote: On Mon, Aug 11, 2025 at 2:01 PM Maryla Ustarroz wrote: On Mon, Aug 11, 2025 at 1:57 PM Maryla Ustarroz-Calonge wrote: Signed-off-by: Maryla U

[FFmpeg-devel] [PATCH] configure: bump LCEVCdec minimum required version to 4.0.0 (PR #20331)

2025-08-24 Thread James Almer via ffmpeg-devel
PR #20331 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20331 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20331.patch The project introduced API breaking changes to some of their public functions, and given the library is relatively new, just bump

[FFmpeg-devel] [PATCH] configure: support linking to base profile libxev{d,e} (PR #20329)

2025-08-24 Thread James Almer via ffmpeg-devel
PR #20329 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20329 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20329.patch Addresses issue #20328. >From 5a95e5db18341c23584a8c13bdc134d5dcc9b05a Mon Sep 17 00:00:00 2001 From: James Almer Date: Sun,

[FFmpeg-devel] [PATCH] avcodec/exif: make the get and remove helpers take a flag argument (PR #20324)

2025-08-23 Thread James Almer via ffmpeg-devel
PR #20324 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20324 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20324.patch This makes the functions extensible, as future behavior change flags can be introduced. This is strictly speaking not an API break

[FFmpeg-devel] [PATCH] avformat: add container level Exif metadata support (PR #20321)

2025-08-23 Thread James Almer via ffmpeg-devel
PR #20321 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20321 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20321.patch Includes Exif packet side data, and starting with support in Heif. >From 962fea2d2cb56450d5325969cb655543895d4885 Mon Sep 17 00

[FFmpeg-devel] [PATCH] Assorted Exif changes (PR #20297)

2025-08-20 Thread James Almer via ffmpeg-devel
PR #20297 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20297 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20297.patch >From 7fe00d8941072a62da0f21440bed8eda288d4db3 Mon Sep 17 00:00:00 2001 From: James Almer Date: Tue, 19 Aug 2025 13:18:18 -0

Re: [FFmpeg-devel] Mailman3 Upgrade

2025-08-18 Thread James Almer via ffmpeg-devel
On 8/18/2025 7:08 PM, Timo Rothenpieler via ffmpeg-devel wrote: Hi! As you might have noticed, a bunch of big Mail-Hosters have introduced new, even stricter, requirements. Primarily it's Microsoft, but others seem to already have followed suit. So we had to configure the list to send all mail

[FFmpeg-devel] [PATCH] fftools/ffmpeg_demux: ensure the display_rotation option is honored (PR #20276)

2025-08-18 Thread James Almer via ffmpeg-devel
PR #20276 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20276 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20276.patch If requested, it should have priotity over any coded value Fixes trac ticket #11649. >F

[FFmpeg-devel] [PATCH] avformat/mov: don't use an allocated array for sample_size with HEIF images (PR #20258)

2025-08-16 Thread James Almer via ffmpeg-devel
PR #20258 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20258 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20258.patch The array is only ever needed for streams where each sample entry may have a different value. Given that for non animated HEIF

Re: [FFmpeg-devel] [PATCH] lavc/mfenc: set output packet duration

2025-08-14 Thread James Almer via ffmpeg-devel
On 8/13/2025 8:39 PM, Pavel Koshevoy wrote: On Tue, Aug 12, 2025 at 7:59 AM James Almer wrote: On 8/4/2025 4:50 PM, Pavel Koshevoy wrote: --- libavcodec/mfenc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c index 30531fe3e8

Re: [FFmpeg-devel] Pushing without approval avfilter/vf_vignette: use AVFilterContext for logging

2025-08-12 Thread James Almer
On 8/12/2025 6:53 AM, Nicolas George wrote: Niklas Haas (HE12025-08-12): I see that, but note: 1) the PR *was* approved How do you know that approval was worth anything? Insulting other devs right as we move to a forge to attract new contributors sounds counterproductive. Not to mention una

[FFmpeg-devel] [PATCH] testa/fate/cbs: move redundant_pps tests to the proper location

2025-08-12 Thread James Almer
cbs.mak is meant to contain tests strictly for the CBS framework, not for any bsf that happens to use it under the hood. Signed-off-by: James Almer --- tests/fate/cbs.mak| 40 +-- tests/fate/h264.mak | 17 ...s

Re: [FFmpeg-devel] [PATCH] lavc/mfenc: set output packet duration

2025-08-12 Thread James Almer
On 8/4/2025 4:50 PM, Pavel Koshevoy wrote: --- libavcodec/mfenc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c index 30531fe3e8..942c75cb9d 100644 --- a/libavcodec/mfenc.c +++ b/libavcodec/mfenc.c @@ -148,6 +148,15 @@ static int64_t mf

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself for libavfilter

2025-08-12 Thread James Almer
On 8/12/2025 6:58 AM, Nicolas George wrote: I have been maintaining the framework and orphaned filters for ages but apparently it was never recorded in this file. Signed-off-by: Nicolas George --- MAINTAINERS | 4 1 file changed, 4 insertions(+) … but it was common knowledge. diff -

[FFmpeg-devel] [PATCH] avcodec/cbs_apv: store derived tile information in a per frame basis (PR #20216)

2025-08-11 Thread James Almer
PR #20216 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20216 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20216.patch If a single fragment contains more than one frame unit, the tile information stored in the private context will only correspond to

Re: [FFmpeg-devel] rebase bugs?

2025-08-08 Thread James Almer
On 8/8/2025 8:09 PM, Michael Niedermayer wrote: git log --grep "Clear state on alloc" origin/master --oneline 85a2beaa811 avcodec/ffv1: Clear state on alloc 70fc46d1856 avcodec/ffv1: Clear state on alloc Yeah, that's not good. The second commit is an empty duplicate. also not signed, not ev

[FFmpeg-devel] [PATCH] Assorted Vulkan fixes (PR #20179)

2025-08-08 Thread James Almer
PR #20179 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20179 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20179.patch >From 4f255ce62431eb70545beebb1ff0fcb818909f97 Mon Sep 17 00:00:00 2001 From: James Almer Date: Fri, 8 Aug 2025 12:00:10 -0

Re: [FFmpeg-devel] [RFC] AAC (USAC) bug

2025-08-08 Thread James Almer
On 8/8/2025 10:28 AM, Michael Niedermayer wrote: Hi AAC USAC conatains a double free since 6 month (https://issues.oss-fuzz.com/issues/393523547) A WIP fix is here: WIP how? Is it incomplete? https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2025-February/339564.html what do people prefer he

Re: [FFmpeg-devel] [PATCH] avfilter/vf_alphamerge: use refcounting for planar formats

2025-08-07 Thread James Almer
On 8/7/2025 4:58 PM, Jorge Estrada wrote: Use reference plane when handling planar formats. Should address https://code.ffmpeg.org/FFmpeg/FFmpeg/issues/20153 Example: ffmpeg -f lavfi -i "color=red:s=640x480:d=5,format=yuva420p" \ -f lavfi -i "color=black:s=640x480:d=5,format=yuv420p,geq

[FFmpeg-devel] [PATCH] avcodec/av1*: don't overwrite color information values if not it's coded (PR #20122)

2025-08-05 Thread James Almer
PR #20122 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20122 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20122.patch Fixes issue #20121 >From accb9128272882d713bfd1e8b87aa46ba5b8197c Mon Sep 17 00:00:00 2001 From: James Almer Date: Tue, 5 Aug 2

[FFmpeg-devel] [PATCH] avformat/iff: fix EOF check

2025-08-04 Thread James Almer
The check to return on EOF should not be inside a block that will not be entered after reaching EOF. Should fix "libavcodec/bytestream.h:144:27: runtime error: applying zero offset to null pointer". Signed-off-by: James Almer --- libavformat/iff.c | 6 +++--- 1 file changed, 3

Re: [FFmpeg-devel] git.videolan.org -> git.ffmpeg.org migration

2025-08-03 Thread James Almer
On 8/3/2025 3:55 PM, Marton Balint wrote: On Thu, 31 Jul 2025, Timo Rothenpieler wrote: Hi! We will migrate away from using git.videolan.org to hosting the two repos there on our own infrastructure. To accomplish this, the source.ffmpeg.org domain will be shifted to point to git.ffmpeg.o

[FFmpeg-devel] [PATCH] avformat/mov: set primary extradata based on the first Sample only if it's not already in place (PR #20098)

2025-08-03 Thread James Almer
PR #20098 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20098 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20098.patch If the first Sample references the first stsd entry, then setting it here is redundant. >F

Re: [FFmpeg-devel] rebasing security

2025-08-03 Thread James Almer
On 8/3/2025 12:38 PM, Timo Rothenpieler wrote: On 8/3/2025 5:31 PM, Michael Niedermayer wrote: Hi The "on server rebase" process that we are using with forgejo looks a bit insecure Previously we wrote code, discussed and then signed and pushed In this setup the code coming from a develo

Re: [FFmpeg-devel] forgejo merge vs approve

2025-08-03 Thread James Almer
On 8/3/2025 8:45 AM, Timo Rothenpieler wrote: On 8/3/2025 9:41 AM, Michael Niedermayer wrote: Hi can we have a tag that causes "automerge on approve" ? so that if i open a pr i can set that tag and if someone approves it, its merged and i dont have to come back and click that button ? That i

Re: [FFmpeg-devel] forgejo merge vs approve

2025-08-03 Thread James Almer
On 8/3/2025 10:26 AM, Michael Niedermayer wrote: On Sun, Aug 03, 2025 at 01:45:17PM +0200, Timo Rothenpieler wrote: On 8/3/2025 9:41 AM, Michael Niedermayer wrote: Hi can we have a tag that causes "automerge on approve" ? so that if i open a pr i can set that tag and if someone approves it, i

Re: [FFmpeg-devel] forgejo merge vs approve

2025-08-03 Thread James Almer
On 8/3/2025 10:28 AM, Michael Niedermayer wrote: On Sun, Aug 03, 2025 at 03:26:00PM +0200, Michael Niedermayer wrote: On Sun, Aug 03, 2025 at 01:45:17PM +0200, Timo Rothenpieler wrote: On 8/3/2025 9:41 AM, Michael Niedermayer wrote: Hi can we have a tag that causes "automerge on approve" ? s

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/mov: export the correct initial extratada from samples with multiple stsd

2025-08-02 Thread James Almer
On 8/2/2025 3:33 PM, Michael Niedermayer wrote: Hi This breaks: ./ffmpeg -i 'tickets//1666/avc-intra-panasonic-AG-HPX301E.mov' -f null - after this patch theres a lot of errors: ... [vist#0:0/h264 @ 0x55837b5fd6c0] [dec:h264 @ 0x55837b62c6c0] Error submitting packet to decoder: Invalid data

[FFmpeg-devel] [PATCH] avformat/mov: don't unnecesarely replace extradata with the same one

2025-07-31 Thread James Almer
If the first STSC entry refers to the first extradata buffer, then don't bother replacing the output stream's extradata as it's already set to it. Signed-off-by: James Almer --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.

Re: [FFmpeg-devel] [IMPORTANT] AI written TLS Code in WHIP patch

2025-07-29 Thread James Almer
On 7/29/2025 5:56 PM, Kacper Michajlow wrote: On Tue, 29 Jul 2025 at 22:11, James Almer wrote: On 7/29/2025 5:02 PM, Kieran Kunhya via ffmpeg-devel wrote: Hello, It seem there is strong evidence that AI wrote TLS code as part of the WHIP patch. It goes without saying why this is bad

Re: [FFmpeg-devel] [IMPORTANT] AI written TLS Code in WHIP patch

2025-07-29 Thread James Almer
On 7/29/2025 5:02 PM, Kieran Kunhya via ffmpeg-devel wrote: Hello, It seem there is strong evidence that AI wrote TLS code as part of the WHIP patch. It goes without saying why this is bad. Further discussion here: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20053 This patch was pushed without

Re: [FFmpeg-devel] [PATCH 0/2] Support the new APMP boxes and spherical metadata

2025-07-28 Thread James Almer
On 7/28/2025 10:50 PM, Vittorio Giovara wrote: From a244d96e045439f9e3a4db99e2f479e8686221da Mon Sep 17 00:00:00 2001 From: Vittorio Giovara Date: Wed, 23 Jul 2025 23:42:14 +0200 Subject: [PATCH 2/2] lavu/spherical: Add support for Spherical Immersive type --- libavformat/mov.c | 3 +++ li

Re: [FFmpeg-devel] forgejo PR vs git send email questions

2025-07-28 Thread James Almer
On 7/28/2025 8:13 PM, Michael Niedermayer wrote: Hi with git send email i can send 5 independant patches with git send-email --to='FFmpeg development discussions and patches ' -5 and have some CC: tags to make sure people (like bug reporter or security researcher) get notified Does our for

Re: [FFmpeg-devel] Authorize BtbN

2025-07-25 Thread James Almer
On 7/25/2025 2:14 PM, Derek Buitenhuis wrote: https://0x0.st/85bn.png Yeah, not ideal. I know who BtbN is, random contributor does not. Appears sketchy. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listi

[FFmpeg-devel] [PATCH] avfilter/af_channelmap: always set out_channel in the map

2025-07-24 Thread James Almer
Fixes use-of-uninitialized-value. Signed-off-by: James Almer --- libavfilter/af_channelmap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/af_channelmap.c b/libavfilter/af_channelmap.c index a883934fa6..b864317312 100644 --- a/libavfilter/af_channelmap.c +++ b/libavfilter

Re: [FFmpeg-devel] FFmpeg 8.0 Release

2025-07-23 Thread James Almer
On 7/23/2025 11:01 AM, Niklas Haas wrote: On Wed, 23 Jul 2025 16:01:14 +0200 Niklas Haas wrote: On Wed, 23 Jul 2025 13:43:43 +0200 Michael Niedermayer wrote: Hi everyone I intend to create the release/8.0 branch in the next 1-2 weeks after that i intend to make teh 8.0 release in the follow

Re: [FFmpeg-devel] Notifications for the new monolithic tool

2025-07-23 Thread James Almer
On 7/23/2025 4:24 PM, Nicolas George wrote: Hi. I just saw somebody mention this on trac: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20025 But I have no trace of it in my inbox. If this is now an accepted way of getting contributions, then either the devel mailing-list should receive notificat

[FFmpeg-devel] [PATCH] avcodec/opus/silk: don't assume stereo when calling silk_decode_frame()

2025-07-22 Thread James Almer
Fixes use-of-uninitialized-value under MSAN. Signed-off-by: James Almer --- libavcodec/opus/silk.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/opus/silk.c b/libavcodec/opus/silk.c index 97bb95037c..ffa2ec996b 100644 --- a/libavcodec/opus/silk.c +++ b

[FFmpeg-devel] [PATCH 3/3] avfilter: use the getters for xGA font data arrays

2025-07-21 Thread James Almer
Signed-off-by: James Almer --- libavfilter/af_aiir.c | 2 +- libavfilter/avf_showcqt.c | 3 ++- libavfilter/avf_showspectrum.c | 2 +- libavfilter/avf_showvolume.c | 2 +- libavfilter/f_ebur128.c| 4 ++-- libavfilter/f_graphmonitor.c | 2 +- libavfilter

[FFmpeg-devel] [PATCH 2/3] avcodec: use the getters for xGA font data arrays

2025-07-21 Thread James Almer
Signed-off-by: James Almer --- libavcodec/ansi.c| 12 ++-- libavcodec/bintext.c | 4 ++-- libavcodec/tmv.c | 3 ++- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/libavcodec/ansi.c b/libavcodec/ansi.c index b58b72ef49..bde9edbe60 100644 --- a/libavcodec/ansi.c

[FFmpeg-devel] [PATCH 1/3] avutil/xga_font_data: add getters to access the shared arrays

2025-07-21 Thread James Almer
And stop exposing the arrays on the next major bump. Signed-off-by: James Almer --- libavutil/xga_font_data.c | 16 libavutil/xga_font_data.h | 6 ++ 2 files changed, 22 insertions(+) diff --git a/libavutil/xga_font_data.c b/libavutil/xga_font_data.c index 3aed3142cf

Re: [FFmpeg-devel] [PATCH 0/2] Fix Nikon HEIF decoding error

2025-07-19 Thread James Almer
On 7/19/2025 3:09 AM, compn wrote: On Fri, 18 Jul 2025 10:58:18 -0700, Eric Joyner wrote: On 7/17/2025 8:54 AM, compn wrote: do we have a nikon heif/ hif file sample for our samples repository? http://samples.ffmpeg.org we like to keep some files around for testing , to make sure we dont brea

Re: [FFmpeg-devel] [FFmpeg-cvslog] fate/lavf-container: add test for APV in MP4

2025-07-19 Thread James Almer
On 7/19/2025 5:00 AM, Martin Storsjö wrote: On Fri, 18 Jul 2025, James Almer wrote: ffmpeg | branch: master | James Almer | Tue Jul 15 19:00:21 2025 -0300| [3cd5672bfeb796342d24228a78f2e733c0a40e7d] | committer: James Almer fate/lavf-container: add test for APV in MP4 Signed-off-by: James

[FFmpeg-devel] [PATCH] avformat/hevc: don't print parameter_set_id for any NALU

2025-07-18 Thread James Almer
It's not a value stored in the hvcC structure. Fixes use of uninitialized variable errors under sanitizer when the input extradata is already hvcC formatted, given we don't parse parameter sets for those. Signed-off-by: James Almer --- libavformat/hevc.c | 4 1 file changed, 4

[FFmpeg-devel] [PATCH] avcodec/ffv1dec: don't add offsets to more NULL pointers

2025-07-18 Thread James Almer
Fixes: libavcodec/ffv1dec.c:453:43: runtime error: applying zero offset to null pointer Signed-off-by: James Almer --- libavcodec/ffv1dec.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c index d613aa5395

[FFmpeg-devel] [PATCH] avcodec/ffv1dec: don't add offsets to more NULL pointer

2025-07-18 Thread James Almer
Fixes: libavcodec/ffv1dec.c:453:43: runtime error: applying zero offset to null pointer Signed-off-by: James Almer --- libavcodec/ffv1dec.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c index d613aa5395

Re: [FFmpeg-devel] [PATCH] avcodec/motion_est: don't add offsets to NULL pointers

2025-07-18 Thread James Almer
On 7/18/2025 8:01 PM, Michael Niedermayer wrote: On Tue, Jul 15, 2025 at 10:33:10AM -0300, James Almer wrote: Fixes: libavcodec/motion_est.c:94:31: runtime error: applying zero offset to null pointer Signed-off-by: James Almer --- libavcodec/motion_est.c | 6 +++--- 1 file changed, 3

Re: [FFmpeg-devel] [PATCH 1/2] libavformat: Support multiple thumbnails in HEIF

2025-07-17 Thread James Almer
On 7/16/2025 11:30 PM, Eric Joyner wrote: Prevents ffmpeg/ffprobe from erroring out when reading an HEIF that contains multiple hvcC thumbnails (e.g. from a Nikon Z6III camera). Before, move_read_iref_thmb() would always override the stored thmb_item_id in the MOVContext with each new read thumb

[FFmpeg-devel] [PATCH] avformat/mov: don't assume iloc and iinf entries for each item_id will be in the same order

2025-07-17 Thread James Almer
Nothing forbids them to be in any order the muxer desires. Fixes demuxing heif samples generated by S1II. Signed-off-by: James Almer --- libavformat/mov.c | 41 ++--- 1 file changed, 26 insertions(+), 15 deletions(-) diff --git a/libavformat/mov.c b

Re: [FFmpeg-devel] [PATCH 2/2] libavformat: Enable jpeg streams in HEIF MOVContext

2025-07-17 Thread James Almer
On 7/17/2025 8:54 AM, Lynne wrote: Thanks. Patchset LGTM. This also helps HEIF files generated by the S1II, but sadly they still fail: > [mjpeg @ 0x55a49a0e29c0] No JPEG data found in image And for the main stream: > [hevc @ 0x55a49a0fe880] Failed to parse header of NALU (type 34): "Inval

Re: [FFmpeg-devel] [PATCH v2 2/3] tests/checkasm: add check for vf_colordetect

2025-07-16 Thread James Almer
On 7/16/2025 1:24 PM, Niklas Haas wrote: From: Niklas Haas --- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 3 + tests/checkasm/checkasm.h | 1 + tests/checkasm/vf_colordetect.c | 137 4 files changed, 142 insertions

Re: [FFmpeg-devel] [PATCH v2 3/3] avfilter/vf_colordetect: add x86 SIMD implementation

2025-07-16 Thread James Almer
On 7/16/2025 6:49 PM, Niklas Haas wrote: On Wed, 16 Jul 2025 17:25:12 -0300 James Almer wrote: On 7/16/2025 1:24 PM, Niklas Haas wrote: +cglobal detect_alpha%1_%3, 6, 7, 6, color, color_stride, alpha, alpha_stride, width, height, x +pxor m0, m0 +add colorq, widthq +add alphaq

Re: [FFmpeg-devel] [PATCH v2 3/3] avfilter/vf_colordetect: add x86 SIMD implementation

2025-07-16 Thread James Almer
On 7/16/2025 1:24 PM, Niklas Haas wrote: +cglobal detect_alpha%1_%3, 6, 7, 6, color, color_stride, alpha, alpha_stride, width, height, x +pxor m0, m0 +add colorq, widthq +add alphaq, widthq +neg widthq +%ifidn %3, limited +%if ARCH_X86_64 +movq xm3, r6mp ; p +movq xm4, r7

Re: [FFmpeg-devel] [PATCH v4] avformat/mov_muxer: Extended MOV muxer to handle APV video content

2025-07-15 Thread James Almer
On 7/14/2025 6:18 AM, Dawid Kozinski wrote: - Changes in mov_write_video_tag function to handle APV elementary stream - Provided structure APVDecoderConfigurationRecord that specifies the decoder configuration information for APV video content Signed-off-by: Dawid Kozinski --- libavcodec/cbs

[FFmpeg-devel] [PATCH] avcodec/motion_est: don't add offsets to NULL pointers

2025-07-15 Thread James Almer
Fixes: libavcodec/motion_est.c:94:31: runtime error: applying zero offset to null pointer Signed-off-by: James Almer --- libavcodec/motion_est.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/motion_est.c b/libavcodec/motion_est.c index 93be712cc0

[FFmpeg-devel] [PATCH] avcodec/motion_est: don't add offsets to NULL pointers

2025-07-13 Thread James Almer
Fixes: libavcodec/motion_est.c:94:31: runtime error: applying zero offset to null pointer Signed-off-by: James Almer --- libavcodec/motion_est.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/motion_est.c b/libavcodec/motion_est.c index 93be712cc0

[FFmpeg-devel] [PATCH] avcodec/ffv1dec: don't add offsets to NULL pointers

2025-07-13 Thread James Almer
Fixes: libavcodec/ffv1dec.c:452:43: runtime error: applying zero offset to null pointer Signed-off-by: James Almer --- libavcodec/ffv1dec.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c index 8d10d2cf8b..d613aa5395

[FFmpeg-devel] [PATCH] swscale/swscale_unscaled: don't add offsets to NULL pointers

2025-07-13 Thread James Almer
Fixes: libswscale/swscale_unscaled.c:916:20: runtime error: applying zero offset to null pointer Signed-off-by: James Almer --- libswscale/swscale_unscaled.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/swscale_unscaled.c b/libswscale/swscale_unscaled.c index

[FFmpeg-devel] [PATCH v3] avformat/tls_schannel: add check for Windows 10 only types and defines

2025-07-13 Thread James Almer
Old Mingw-w64 releases provided by some distros seemingly don't have them, so check for them and disable the dtls protocol if unavailable. Signed-off-by: James Almer --- configure | 4 libavformat/tls_schannel.c | 33 +++-- 2 files change

[FFmpeg-devel] [PATCH v2] avformat/tls_schannel: add check for Windows 10 only types and defines

2025-07-13 Thread James Almer
Old Mingw-w64 releases provided by some distros seemingly don't have them, so check for them and disable the dtls protocol if unavailable. Signed-off-by: James Almer --- configure | 4 libavformat/tls_schannel.c | 29 +++-- 2 files change

[FFmpeg-devel] [PATCH] avformat/tls_schannel: add check for Windows 10 only types and defines

2025-07-13 Thread James Almer
Old Mingw-w64 releases provided by supported distros seemingly don't have them, so check for them and disable the dtls protocol if unavailable. Signed-off-by: James Almer --- configure | 3 +++ libavformat/tls_schannel.c | 33 +++-- 2 files ch

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/tls_schannel: add DTLS support

2025-07-13 Thread James Almer
On 7/13/2025 8:35 AM, Timo Rothenpieler wrote: On 7/13/2025 4:59 AM, James Almer wrote: On 7/12/2025 9:32 PM, Michael Niedermayer wrote: On Fri, Jul 11, 2025 at 04:04:17PM +, Timo Rothenpieler wrote: ffmpeg | branch: master | Timo Rothenpieler | Tue Jun 24 19:30:19 2025 +0200

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/tls_schannel: add DTLS support

2025-07-13 Thread James Almer
On 7/12/2025 11:59 PM, James Almer wrote: On 7/12/2025 9:32 PM, Michael Niedermayer wrote: On Fri, Jul 11, 2025 at 04:04:17PM +, Timo Rothenpieler wrote: ffmpeg | branch: master | Timo Rothenpieler | Tue Jun 24 19:30:19 2025 +0200| [90fa9636efff84ec5a4b06815722c08188dca551] | committer

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/tls_schannel: add DTLS support

2025-07-12 Thread James Almer
On 7/12/2025 9:32 PM, Michael Niedermayer wrote: On Fri, Jul 11, 2025 at 04:04:17PM +, Timo Rothenpieler wrote: ffmpeg | branch: master | Timo Rothenpieler | Tue Jun 24 19:30:19 2025 +0200| [90fa9636efff84ec5a4b06815722c08188dca551] | committer: Timo Rothenpieler avformat/tls_schannel: a

[FFmpeg-devel] [PATCH] fftools/ffmpeg_demux: don't flag timestamps as unreliable if they are generated

2025-07-08 Thread James Almer
Regardless of the source being an AVFMT_NOTIMESTAMPS format, if the timestamps are generated like when using the use_wallclock_as_timestamps demuxer option, then they are reliable. Fixes ticket #11268 Signed-off-by: James Almer --- fftools/ffmpeg_demux.c | 11 ++- 1 file changed, 10

Re: [FFmpeg-devel] [PATCH v2] avformat/mov_muxer: Extended MOV muxer to handle APV video content

2025-07-07 Thread James Almer
On 5/8/2025 7:30 AM, Dawid Kozinski wrote: - Changes in mov_write_video_tag function to handle APV elementary stream - Provided structure APVDecoderConfigurationRecord that specifies the decoder configuration information for APV video content Signed-off-by: Dawid Kozinski --- libavformat/Mak

Re: [FFmpeg-devel] [PATCH v1] avformat/mov_demuxer: Extended MOV demuxer to handle APV video content

2025-07-07 Thread James Almer
On 5/6/2025 6:28 AM, Dawid Kozinski wrote: - Added apv extension to the list of extensions for ff_mov_demuxer Signed-off-by: Dawid Kozinski --- libavformat/demux.c | 1 + libavformat/mov.c | 7 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/libavformat/demux.c b/lib

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/aac_ac3_parser: remove dead code

2025-07-07 Thread James Almer
On 7/7/2025 10:19 AM, Nicolas Gaullier wrote: ff_adts_header_parse() gets the object_type from only 2 bits. See also 696ea1c2236842572df88d573e24a39be3f19c98. Introduced in 64bb91fd3b5a00a8849531c7e8dd207f2a626096. Signed-off-by: Nicolas Gaullier --- libavcodec/aac_ac3_parser.c | 7 +++

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/aac_ac3_parser: do not override the profile set by the decoder

2025-07-07 Thread James Almer
On 7/7/2025 10:19 AM, Nicolas Gaullier wrote: Parsing the ADTS header is not enough to detect HE-AAC v1/v2. Regression since 64bb91fd3b5a00a8849531c7e8dd207f2a626096. Fixes #11600 Signed-off-by: Nicolas Gaullier --- libavcodec/aac_ac3_parser.c | 3 ++- 1 file changed, 2 insertions(+), 1 de

Re: [FFmpeg-devel] [PATCH] Macroblocks modes extraction

2025-07-04 Thread James Almer
On 7/2/2025 7:57 AM, Timothee wrote: Hello, I am working on a modification toextract per-macroblock prediction modes (H.264 for now). The goal is to make this information available to vf_codecview and print it in a log file (for now). This are what I have added: 1.    A new H264MBInfostru

Re: [FFmpeg-devel] [PATCH] libavformat.v, libavutil.v: tighten export whitelist

2025-07-03 Thread James Almer
On 7/3/2025 1:28 PM, Andreas Rheinhardt wrote: Scott Theisen: This matches how the other libraries define their exported symbols. --- libavformat/libavformat.v | 5 - libavutil/libavutil.v | 4 +++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/libavformat/libavforma

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add an API to handle 3D Reference Displays Information

2025-07-01 Thread James Almer
On 7/1/2025 3:49 PM, Timo Rothenpieler wrote: On 23.06.2025 17:44, Timo Rothenpieler wrote: On 16.06.2025 20:26, Andreas Rheinhardt wrote: Timo Rothenpieler: On 16.06.2025 14:55, James Almer wrote: On 6/16/2025 9:38 AM, Timo Rothenpieler wrote: On 13/06/2025 16:07, Timo Rothenpieler wrote

Re: [FFmpeg-devel] [PATCH] avcodec/speexdec: consider differing frame sizes in remaining space check

2025-06-27 Thread James Almer
On 6/27/2025 1:14 PM, Michael Niedermayer wrote: Fixes: talk109-q5.spx Can this file be added to FATE? Regression since: f6986e75be87f512f65d64ac91ba19d505a8d210 Signed-off-by: Michael Niedermayer --- libavcodec/speexdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH] avformat/apvdec: add framerate option

2025-06-26 Thread James Almer
Based on code from rawvideo demuxer. Signed-off-by: James Almer --- libavformat/apvdec.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/libavformat/apvdec.c b/libavformat/apvdec.c index 1e5497bcd3..70f6babbb7 100644 --- a/libavformat/apvdec.c

[FFmpeg-devel] [PATCH] avformat/iamf_parse: prevent overreads in update_extradata

2025-06-23 Thread James Almer
process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: James Almer --- libavformat/iamf_parse.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/libavformat/iamf_parse.c b/libavformat/iamf_parse.c index 71497876ac..46a74ea679 100644 ---

Re: [FFmpeg-devel] [PATCH 1/4] avformat/iamf_parse: Check extradata size

2025-06-23 Thread James Almer
On 6/23/2025 12:14 PM, James Almer wrote: On 6/23/2025 9:57 AM, Andreas Rheinhardt wrote: James Almer: On 6/23/2025 9:44 AM, Michael Niedermayer wrote: On Fri, Jun 20, 2025 at 12:28:13AM +0200, Andreas Rheinhardt wrote: Michael Niedermayer: Fixes: Assertion n>=0 && n<

Re: [FFmpeg-devel] [PATCH 1/4] avformat/iamf_parse: Check extradata size

2025-06-23 Thread James Almer
On 6/23/2025 9:57 AM, Andreas Rheinhardt wrote: James Almer: On 6/23/2025 9:44 AM, Michael Niedermayer wrote: On Fri, Jun 20, 2025 at 12:28:13AM +0200, Andreas Rheinhardt wrote: Michael Niedermayer: Fixes: Assertion n>=0 && n<=32 failed at ./libavcodec/get_bits.h:406 Fi

Re: [FFmpeg-devel] [PATCH 1/5] avformat/mov: Check that sample_count is allocated in mov_parse_heif_items()

2025-06-23 Thread James Almer
On 6/21/2025 6:15 PM, Michael Niedermayer wrote: Fixes: NULL pointer dereference Fixes: 416811958/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5425269114732544 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nie

Re: [FFmpeg-devel] [PATCH 1/4] avformat/iamf_parse: Check extradata size

2025-06-23 Thread James Almer
On 6/23/2025 9:44 AM, Michael Niedermayer wrote: On Fri, Jun 20, 2025 at 12:28:13AM +0200, Andreas Rheinhardt wrote: Michael Niedermayer: Fixes: Assertion n>=0 && n<=32 failed at ./libavcodec/get_bits.h:406 Fixes: 398527871/clusterfuzz-testcase-minimized-ffmpeg_dem_IAMF_fuzzer-6602025714647040

[FFmpeg-devel] [PATCH 2/2] avcodec/mss2dsp: use FF_PTR_ADD to add offsets to a pointer

2025-06-23 Thread James Almer
Fixes: libavcodec/mss2dsp.c:59:14: runtime error: applying zero offset to null pointer Signed-off-by: James Almer --- Untested, as gcc-usan on Linux x86_64 doesn't complain about it, but it can be seen in https://fate.ffmpeg.org/report.cgi?time=20250622122557&slot=amd64-clang-cl-

[FFmpeg-devel] [PATCH v2 2/2] avcodec/mss2dsp: use FF_PTR_ADD to add offsets to a pointer

2025-06-22 Thread James Almer
Fixes: libavcodec/mss2dsp.c:59:14: runtime error: applying zero offset to null pointer Signed-off-by: James Almer --- Untested, as gcc-usan on Linux x86_64 doesn't complain about it, but it can be seen in https://fate.ffmpeg.org/report.cgi?time=20250622122557&slot=amd64-clang-cl-

[FFmpeg-devel] [PATCH] avcodec/ffv1enc_template: use FF_PTR_ADD to add offsets to a pointer

2025-06-22 Thread James Almer
Fixes: libavcodec\ffv1enc_template.c:75:79: runtime error: applying zero offset to null pointer Signed-off-by: James Almer --- Untested, as gcc-usan on Linux x86_64 doesn't complain about it, but it can be seen in https://fate.ffmpeg.org/report.cgi?time=20250622122557&slot=amd64-clan

Re: [FFmpeg-devel] [PATCH v5 07/13] avfilter/x86/f_ebur128: add x86 AVX implementation

2025-06-20 Thread James Almer
On 6/20/2025 10:21 AM, Niklas Haas wrote: From: Niklas Haas Processes two channels in parallel, using 128-bit XMM registers. In theory, we could go up to YMM registers to process 4 channels, but this is not a gain except for relatively high channel counts (e.g. 7.1), and also complicates the s

Re: [FFmpeg-devel] [PATCH 5/8] avformat/mov: Check that sample_sizes is allocated in mov_parse_heif_items()

2025-06-19 Thread James Almer
On 6/19/2025 9:32 PM, Michael Niedermayer wrote: Fixes: NULL pointer dereference Fixes: 416811958/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5425269114732544 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nie

Re: [FFmpeg-devel] [PATCH 1/2] configure: cbs_apv depends on cbs

2025-06-17 Thread James Almer
On 6/17/2025 8:19 PM, Peter Ross wrote: --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index e2e9fc26d8..bfe5f5bbee 100755 --- a/configure +++ b/configure @@ -2869,6 +2869,7 @@ w32threads_deps="atomics_native" threads_if_any="$THREADS_LIST" # sub

[FFmpeg-devel] [PATCH 9/9] avformat/iamf_writer: use named constants in more places

2025-06-17 Thread James Almer
Signed-off-by: James Almer --- libavformat/iamf_writer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c index ad40871fa1..4302df7931 100644 --- a/libavformat/iamf_writer.c +++ b/libavformat/iamf_writer.c @@ -783,7

[FFmpeg-devel] [PATCH 8/9] avformat/iamf_writer: reindent after previous commit

2025-06-17 Thread James Almer
Signed-off-by: James Almer --- libavformat/iamf_writer.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c index 37e75dc01a..ad40871fa1 100644 --- a/libavformat/iamf_writer.c +++ b/libavformat/iamf_writer.c

[FFmpeg-devel] [PATCH 7/9] avformat/iamf_writer: add extra constrains for Parameter Sets in Audio Elements

2025-06-17 Thread James Almer
Signed-off-by: James Almer --- libavformat/iamf_writer.c | 40 --- 1 file changed, 33 insertions(+), 7 deletions(-) diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c index 635d1989ef..37e75dc01a 100644 --- a/libavformat/iamf_writer.c +++ b

[FFmpeg-devel] [PATCH 6/9] avformat/iamf_writer: factorize out getting loudspeaker_layout values

2025-06-17 Thread James Almer
Signed-off-by: James Almer --- libavformat/iamf_writer.c | 65 +++ 1 file changed, 39 insertions(+), 26 deletions(-) diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c index 86d09c3308..635d1989ef 100644 --- a/libavformat/iamf_writer.c +++ b

[FFmpeg-devel] [PATCH 5/9] avformat/iamf: fix setting channel layout for Scalable layers

2025-06-17 Thread James Almer
stereo, fltp (dependent) Stream #0:5[0x5]: Audio: opus, 48000 Hz, stereo, fltp (dependent) Signed-off-by: James Almer --- libavformat/iamf_parse.c | 77 +-- libavformat/iamf_writer.c | 28 +-- libavformat/iamfdec.c

[FFmpeg-devel] [PATCH 4/9] tests/iamf: rename BACK to SIDE filterchain labels in the 5.1.4 iamf tests

2025-06-17 Thread James Almer
Cosmetic change to reflect the actual channels used in the layouts. Signed-off-by: James Almer --- tests/fate/iamf.mak | 2 +- tests/fate/mov.mak| 2 +- tests/filtergraphs/iamf_5_1_4 | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/fate/iamf.mak

[FFmpeg-devel] [PATCH 3/9] tests/iamf: reorder muxed streams

2025-06-17 Thread James Almer
Follows the proper order defined by the spec, even if mostly cosmetic, and is also preparation for a following change. Signed-off-by: James Almer --- tests/fate/iamf.mak | 4 +- tests/fate/mov.mak| 4 +- tests/ref/fate/iamf-9_1_6 | 82 +++ 3

  1   2   3   4   5   6   7   8   9   10   >