Re: [FFmpeg-devel] [PATCH v4 0/4] Fix MSVC build without optimizations

On Fri, 28 Jul 2023 at 20:55, Nicolas George wrote: > Reimar Döffinger (12023-07-28): > > I assume the issue is missing symbols during linking? > > If you really want this, why not create a file that provides dummy > > symbols for all that are missing, concentrating the #if mess in > > a single

Re: [FFmpeg-devel] [PATCH 1/2] lavfi/Makefile: Dont compile unused files.

On Sun, 12 Feb 2023 at 04:00, Nicolas George wrote: > Hi. > > Matt Oliver (12023-01-15): > > vf_nlmeans and vf_atadenoisedont contain any code on 32bit x86 so dont > > build them. > > Hi > > This sentence seems to be missing a few words. > &g

Re: [FFmpeg-devel] [PATCH 1/2] lavfi/Makefile: Dont compile unused files.

On Sun, 15 Jan 2023 at 19:08, Matt Oliver wrote: > vf_nlmeans and vf_atadenoisedont contain any code on 32bit x86 so dont > build them. > > --- > libavfilter/x86/Makefile | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavfilter/x86/Makefile b/libavfil

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/Makefile: Dont compile unused files.

On Sun, 15 Jan 2023 at 19:09, Matt Oliver wrote: > Multiple asm files dont contain any valid code when compiled under 32bit > x86 so they should be skipped. > > --- > libavcodec/x86/Makefile | 8 > 1 file changed, 8 insertions(+) > > diff --git a/libavcodec/x

[FFmpeg-devel] [PATCH 2/2] avcodec/Makefile: Dont compile unused files.

Multiple asm files dont contain any valid code when compiled under 32bit x86 so they should be skipped. --- libavcodec/x86/Makefile | 8 1 file changed, 8 insertions(+) diff --git a/libavcodec/x86/Makefile b/libavcodec/x86/Makefile index 118daca333..bafba207ca 100644 ---

[FFmpeg-devel] [PATCH 1/2] lavfi/Makefile: Dont compile unused files.

vf_nlmeans and vf_atadenoisedont contain any code on 32bit x86 so dont build them. --- libavfilter/x86/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/libavfilter/x86/Makefile b/libavfilter/x86/Makefile index e87481bd7a..9a68b9204b 100644 --- a/libavfilter/x86/Makefile +++

[FFmpeg-devel] [PATCH v7] libx264: Set min build version to 158

From: Matt Oliver Was "[PATCH] libx264: Do not explicitly set X264_API_IMPORTS" Setting X264_API_IMPORTS only affects msvc builds and it breaks linking to static builds (although is required for shared builds). This flag is set by x264 in its pkgconfig as required since

[FFmpeg-devel] [PATCH v6] libx264: Set min build version to 158

From: Matt Oliver Was "[PATCH] libx264: Do not explicitly set X264_API_IMPORTS" Setting X264_API_IMPORTS only affects msvc builds and it breaks linking to static builds (although is required for shared builds). This flag is set by x264 in its pkgconfig as required since

[FFmpeg-devel] [PATCH v5] libx264: Set min build version to 158

From: Matt Oliver Was "[PATCH] libx264: Do not explicitly set X264_API_IMPORTS" Setting X264_API_IMPORTS only affects msvc builds and it breaks linking to static builds (although is required for shared builds). This flag is set by x264 in its pkgconfig as required since

[FFmpeg-devel] [PATCH v4] libx264: Set min build version to 158

From: Matt Oliver Was "[PATCH] libx264: Do not explicitly set X264_API_IMPORTS" Setting X264_API_IMPORTS only affects msvc builds and it breaks linking to static builds (although is required for shared builds). This flag is set by x264 in its pkgconfig as required since

[FFmpeg-devel] [PATCH v3] libx264: Set min build version to 158

From: Matt Oliver Was "[PATCH] libx264: Do not explicitly set X264_API_IMPORTS" Setting X264_API_IMPORTS only affects msvc builds and it breaks linking to static builds (although is required for shared builds). This flag is set by x264 in its pkgconfig as required since

[FFmpeg-devel] [PATCH] libx264: Set min build version to 158

From: Matt Oliver Was "[PATCH] libx264: Do not explicitly set X264_API_IMPORTS" Setting X264_API_IMPORTS only affects msvc builds and it breaks linking to static builds (although is required for shared builds). This flag is set by x264 in its pkgconfig as required since

Re: [FFmpeg-devel] [PATCH] libx264: Set min build version to 158

On Wed, 29 Dec 2021 at 23:37, Michael Niedermayer wrote: > On Wed, Dec 29, 2021 at 05:16:25PM +1100, Matt Oliver wrote: > > Was "[PATCH] libx264: Do not explicitly set X264_API_IMPORTS" > > > > Setting X264_API_IMPORTS only affects msvc builds and it breaks

[FFmpeg-devel] [PATCH] libx264: Set min build version to 158

g (to keep the old behaviour) but that requires some complex configure changes. Signed-off-by: Matt Oliver --- configure| 8 +++- libavcodec/libx264.c | 4 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/configure b/configure index ede8f9777b..b35728a

Re: [FFmpeg-devel] [PATCH] libx264: Do not explicitly set X264_API_IMPORTS

On Sat, 30 Oct 2021 at 14:16, Matt Oliver wrote: > Setting X264_API_IMPORTS only affects msvc builds and it breaks linking to > static builds (although is required for shared builds). This flag is set by > x264 in its pkgconfig as required since

Re: [FFmpeg-devel] [PATCH] libvpxdec: Correct linking against variables.

On Thu, 4 Nov 2021 at 15:44, Matt Oliver wrote: > Instead link against the function that returns the correct variable. This > fixes linking errors with dlls with msvc. > --- > libavcodec/libvpxdec.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > di

[FFmpeg-devel] [PATCH] libvpxdec: Correct linking against variables.

Instead link against the function that returns the correct variable. This fixes linking errors with dlls with msvc. --- libavcodec/libvpxdec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c index

Re: [FFmpeg-devel] [PATCH] libaom: Dont use aom_codec_av1_dx_algo.

On Tue, 2 Nov 2021 at 04:41, James Zern wrote: > On Fri, Oct 29, 2021 at 8:51 PM Matt Oliver wrote: > > > > On Sat, 30 Oct 2021 at 14:13, Matt Oliver wrote: > > > > > Does this compile and link with libaom 1.0.0? We unfortunately still > > >> support

Re: [FFmpeg-devel] [PATCH] libaom: Dont use aom_codec_av1_dx_algo.

On Sat, 30 Oct 2021 at 14:13, Matt Oliver wrote: > Does this compile and link with libaom 1.0.0? We unfortunately still >> support that version (despite being unusable speed wise) because distros >> like Debian still ship it. >> > > Just looked it up and yes version

[FFmpeg-devel] [PATCH] libx264: Do not explicitly set X264_API_IMPORTS

changes that I'm not sure how best to do (assistance welcome). Signed-off-by: Matt Oliver --- configure| 8 +++- libavcodec/libx264.c | 4 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/configure b/configure index ede8f9777b..b35728aace 100755 --- a/configure

Re: [FFmpeg-devel] [PATCH] libaom: Dont use aom_codec_av1_dx_algo.

> > Does this compile and link with libaom 1.0.0? We unfortunately still > support that version (despite being unusable speed wise) because distros > like Debian still ship it. > Just looked it up and yes version 1.0.0 includes the required aom_codec_av1_dx() function (line 37 of aomdx.h for

Re: [FFmpeg-devel] [PATCH] libaom: Dont use aom_codec_av1_dx_algo.

> > lgtm. > Thanks, I will push this assuming no other comments. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with

[FFmpeg-devel] [PATCH] libaom: Dont use aom_codec_av1_dx_algo.

This fixes linking errors where variables cannot be correctly linked in from an external shared library such as with msvc (requires dllimport which is not used by libaom). Instead just call the function that returns the same variable. --- libavcodec/libaomdec.c | 2 +- 1 file changed, 1

[FFmpeg-devel] [PATCH 1/2] cuda_runtime.h: Correct ushort4 to use ushort.

--- compat/cuda/cuda_runtime.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/cuda/cuda_runtime.h b/compat/cuda/cuda_runtime.h index 0bf3de85d3..c5450b2542 100644 --- a/compat/cuda/cuda_runtime.h +++ b/compat/cuda/cuda_runtime.h @@ -73,7 +73,7 @@ typedef struct

[FFmpeg-devel] [PATCH 2/2] configure: Use no-narrowing for cuda_llvm compilation.

This fixes llvm compiler generating errors about narrowing conversion with recent releases. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index df298b4b9b..e716f6f932 100755 --- a/configure +++ b/configure @@ -6242,7 +6242,7 @@ fi if

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_d3d11va: Use secure dlopen.

final ping. If no objections still ill apply this later. On Sun, 12 Jan 2020 at 06:50, Matt Oliver wrote: > On Tue, 31 Dec 2019 at 03:37, Andriy Gelman > wrote: > >> On Mon, 30. Dec 11:31, Andriy Gelman wrote: >> > On Tue, 31. Dec 03:02, Matt Oliver wrote: >>

Re: [FFmpeg-devel] [PATCH 4/4] avformat/udp: do not use thread cancellation when receiving data

On Thu, 23 Jan 2020 at 08:12, Marton Balint wrote: > > > On Wed, 22 Jan 2020, Nicolas George wrote: > > > Marton Balint (12020-01-16): > >> It is not supported by every threading implementation, and the only > thing we > >> gain with it is an immediate shutdown of receiving packets on close and

Re: [FFmpeg-devel] [PATCHv2] avutil/thread: Add pthread_cond_timedwait function

On Mon, 20 Jan 2020 at 11:14, Marton Balint wrote: > From: Matt Oliver > > v2: fix calculating milisecond times and use SleepConditionVariableSRW. > > Signed-off-by: Matt Oliver > --- > compat/os2threads.h | 25 + > c

Re: [FFmpeg-devel] [PATCH 4/4] avformat/udp: do not use thread cancellation when receiving data

On Fri, 17 Jan 2020 at 18:44, Hendrik Leppkes wrote: > On Fri, Jan 17, 2020 at 12:30 AM Michael Niedermayer > wrote: > > > > On Thu, Jan 16, 2020 at 01:20:16AM +0100, Marton Balint wrote: > > > It is not supported by every threading implementation, and the only > thing we > > > gain with it is

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_d3d11va: Use secure dlopen.

On Tue, 31 Dec 2019 at 03:37, Andriy Gelman wrote: > On Mon, 30. Dec 11:31, Andriy Gelman wrote: > > On Tue, 31. Dec 03:02, Matt Oliver wrote: > > > dlopen contains additional security to prevent dll hijacking compared > to > > > standard LoadLibra

Re: [FFmpeg-devel] [PATCH] compat/avisynth: Fix unicode compilation.

On Tue, 31 Dec 2019 at 14:16, Stephen Hutchinson wrote: > On 12/30/2019 11:11 AM, Matt Oliver wrote: > > --- > > compat/avisynth/avisynth_c.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/compat/avisynth/avisynth_c.h b/compa

[FFmpeg-devel] [PATCH] compat/avisynth: Fix unicode compilation.

--- compat/avisynth/avisynth_c.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/avisynth/avisynth_c.h b/compat/avisynth/avisynth_c.h index 8d17125adc..9ff9321552 100644 --- a/compat/avisynth/avisynth_c.h +++ b/compat/avisynth/avisynth_c.h @@ -1096,7 +1096,7 @@

[FFmpeg-devel] [PATCH] avutil/hwcontext_d3d11va: Use secure dlopen.

dlopen contains additional security to prevent dll hijacking compared to standard LoadLibrary. --- libavutil/hwcontext_d3d11va.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavutil/hwcontext_d3d11va.c b/libavutil/hwcontext_d3d11va.c index 6670c47579..c8ae58f908

[FFmpeg-devel] ffplay: Fix realloc_texture when input texture is NULL.

SDL_QueryTexture and SDL_DestroyTexture require that the input texture pointer be non-null. Debug builds of SDL will correctly check for this and break program execution. This patch fixes this by checking the status of the texture pointer. Signed-off-by: Matt Oliver <protogo...@gmail.

Re: [FFmpeg-devel] [PATCH] libavformat: LibreSSL (libtls) support

On 5 November 2017 at 02:11, Stefan _ wrote: > Attached patch adds support for LibreSSL. Instead of trying to implement > support into the existing tls_openssl.c using lots of #ifdefs (which was > rejected previously(?)) this adds a new TLS backend making use of the > new libtls

Re: [FFmpeg-devel] Don't use _tzcnt instrinics with clang for windows w/o BMI.

On 25 October 2017 at 07:15, Dale Curtis wrote: > Technically _tzcnt* intrinsics are only available when the BMI > instruction set is present. However the instruction encoding > degrades to "rep bsf" on older processors. > > Clang for Windows debatably restricts the

[FFmpeg-devel] [PATCH] lavc/makefile: Add missing file dependencies.

ac3dsp.c uses tables from ac3.c ac3.c uses tables from ac3tab.c hevc_ps uses tables from hevc_data.c intrax8.c uses tables from msmpeg4data.c --- libavcodec/Makefile | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

On 17 July 2017 at 01:12, Derek Buitenhuis <derek.buitenh...@gmail.com> wrote: > On 7/16/2017 3:15 PM, Matt Oliver wrote: > > Im getting the same error. The patch had an error in it as this line is > > wrong: > > +vmaf_filter_deps="libvmaf" > > > >

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

On 16 July 2017 at 23:01, Henrik Gramner wrote: > `./configure && make` results in "libavfilter/vf_libvmaf.c:29:21: > fatal error: libvmaf.h: No such file or directory". > > I don't have libvmaf installed, but it configures it as enabled and > detects it as installed anyway.

Re: [FFmpeg-devel] [PATCH] win32_dlfcn: Support WinRT/UWP.

On 12 July 2017 at 20:31, wm4 <nfx...@googlemail.com> wrote: > On Sat, 1 Jul 2017 23:18:25 +1000 > Matt Oliver <protogo...@gmail.com> wrote: > > > This only enables dlls that are packaged with the application to be > > loaded. Due to the limitations of Wi

Re: [FFmpeg-devel] [PATCH] lavf/os_support: Use existing WinRT config value.

On 12 July 2017 at 20:27, wm4 <nfx...@googlemail.com> wrote: > On Wed, 12 Jul 2017 20:05:08 +1000 > Matt Oliver <protogo...@gmail.com> wrote: > > > --- > > libavformat/os_support.h | 14 +- > > 1 file changed, 1 insertion(+), 13 deleti

[FFmpeg-devel] [PATCH] lavf/os_support: Use existing WinRT config value.

--- libavformat/os_support.h | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/libavformat/os_support.h b/libavformat/os_support.h index 6e245a88d8..91220e9716 100644 --- a/libavformat/os_support.h +++ b/libavformat/os_support.h @@ -146,18 +146,6 @@ int

Re: [FFmpeg-devel] [PATCH] win32_dlfcn: Support WinRT/UWP.

On 2 July 2017 at 00:29, Matt Oliver <protogo...@gmail.com> wrote: > On 2 July 2017 at 00:14, Hendrik Leppkes <h.lepp...@gmail.com> wrote: > >> On Sat, Jul 1, 2017 at 3:18 PM, Matt Oliver <protogo...@gmail.com> wrote: >> > This only enables dlls

Re: [FFmpeg-devel] [PATCH] win32_dlfcn: Support WinRT/UWP.

On 2 July 2017 at 00:14, Hendrik Leppkes <h.lepp...@gmail.com> wrote: > On Sat, Jul 1, 2017 at 3:18 PM, Matt Oliver <protogo...@gmail.com> wrote: > > This only enables dlls that are packaged with the application to be > > loaded. Due to the limitations of WinRT/UW

[FFmpeg-devel] [PATCH] win32_dlfcn: Support WinRT/UWP.

This only enables dlls that are packaged with the application to be loaded. Due to the limitations of WinRT/UWP it is not allowed to load external/system dlls so this cannot be used as a complete replacement for normal win32 dll loading. --- compat/w32dlfcn.h | 9 - 1 file changed, 8

[FFmpeg-devel] [PATCH] configure: Correct detection of pre-processor defines for configure _LISTS.

Currently the find_things configure function will scan a code file (e.g. allfilters.c) and then create a list of pre-processor values to be added to configure. Unfortunately the way it currently does it is incorrect with what the original c code expects. For example the following exists in

Re: [FFmpeg-devel] [PATCH] configure: Correct detection of pre-processor defines for configure _LISTS.

On 22 April 2017 at 21:09, Matt Oliver <protogo...@gmail.com> wrote: > Currently the find_things configure function will scan a code file (e.g. > allfilters.c) and then create a list of pre-processor values to be added > to configure. > Unfortunately the way it currently do

Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

On 14 April 2017 at 03:31, Hendrik Leppkes <h.lepp...@gmail.com> wrote: > On Thu, Apr 13, 2017 at 7:16 PM, Matt Oliver <protogo...@gmail.com> wrote: > > On 14 April 2017 at 02:11, Rostislav Pehlivanov <atomnu...@gmail.com> > wrote: > > > >>

Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

On 14 April 2017 at 02:11, Rostislav Pehlivanov <atomnu...@gmail.com> wrote: > > > On 13 April 2017 at 16:51, wm4 <nfx...@googlemail.com> wrote: > >> On Thu, 13 Apr 2017 17:39:57 +1000 >> Matt Oliver <protogo...@gmail.com> wrote: >> >&

Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

On 13 April 2017 at 17:20, Aaron Levinson wrote: > I wanted to build a debug build of ffmpeg using Visual C++ today, one > without any optimizations. This implies the use of the -Od compiler > option. Unfortunately, I quickly discovered that the build fails soon > after

Re: [FFmpeg-devel] [PATCH 2/2] configure: instruct MSVC 2015 to properly process UTF-8 string literals

On 4 February 2017 at 21:23, Hendrik Leppkes wrote: > On Sat, Feb 4, 2017 at 10:29 AM, Carl Eugen Hoyos > wrote: > > 2017-02-04 10:25 GMT+01:00 Hendrik Leppkes : > > > >> Another MSVC workaround is an undocumented compiler pragma,

Re: [FFmpeg-devel] [PATCH 2/2] configure: instruct MSVC 2015 to properly process UTF-8 string literals

On 4 February 2017 at 02:32, Hendrik Leppkes wrote: > On Fri, Feb 3, 2017 at 3:05 PM, James Almer wrote: > > On 2/3/2017 5:41 AM, Hendrik Leppkes wrote: > >> Without the /UTF-8 switch, the MSVC compiler treats all files as in the > >> system codepage,

Re: [FFmpeg-devel] [PATCH] lavf/tls_openssl: Support building with LibreSSL

On 29 January 2017 at 01:00, Marek Behun wrote: > On Sat, 28 Jan 2017 14:07:45 +0100 > wm4 wrote: > > > On Sat, 28 Jan 2017 13:01:54 + > > Mark Thompson wrote: > > > > > On 28/01/17 11:28, wm4 wrote: > > > > On Fri, 27 Jan 2017

Re: [FFmpeg-devel] Removing DCE

On 23 December 2016 at 19:40, Nicolas George wrote: > Le primidi 1er nivôse, an CCXXV, Michael Niedermayer a écrit : > > how hard would it be to write a preprocessor like tool to convert > > all if (ARCH/HAVE/CONFIG_SYMBOL ...) > > to > > #if > > ? > > For a very general case,

Re: [FFmpeg-devel] Removing DCE

On 23 December 2016 at 15:35, Matt Oliver <protogo...@gmail.com> wrote: > On 21 December 2016 at 23:55, wm4 <nfx...@googlemail.com> wrote: > >> On Fri, 16 Dec 2016 13:48:16 +1100 >> Matt Oliver <protogo...@gmail.com> wrote: >> >> > Recently we

Re: [FFmpeg-devel] Removing DCE

On 21 December 2016 at 23:55, wm4 <nfx...@googlemail.com> wrote: > On Fri, 16 Dec 2016 13:48:16 +1100 > Matt Oliver <protogo...@gmail.com> wrote: > > > Recently we have again received several patches that are trying to add > > workarounds for ffmpegs use o

Re: [FFmpeg-devel] Removing DCE

On 21 December 2016 at 19:26, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2016-12-16 3:48 GMT+01:00 Matt Oliver <protogo...@gmail.com>: > > > For DCE: > > 1) Ends up with a horrible mess of ifdefs. > > This argument alone has often been sufficient to refus

Re: [FFmpeg-devel] Removing DCE

On 16 December 2016 at 13:48, Matt Oliver <protogo...@gmail.com> wrote: > Recently we have again received several patches that are trying to add > workarounds for ffmpegs use of DCE. This is not the first time this has > happened and wont be the last until a decision is mad

Re: [FFmpeg-devel] [PATCH] lavfi/framequeue: avoid empty structs.

On 19 December 2016 at 18:58, Nicolas George wrote: > Le nonidi 29 frimaire, an CCXXV, Nicolas George a écrit : > > Fix compilation on MSVC. > > Forgot to write in the comment beore sending: this is obviously > untested. > tested and it fixes the issue. LGTM.

[FFmpeg-devel] Removing DCE

Recently we have again received several patches that are trying to add workarounds for ffmpegs use of DCE. This is not the first time this has happened and wont be the last until a decision is made about the use of DCE. So I think its time that we made a official decision on the use of DCE. This

Re: [FFmpeg-devel] [PATCH 3/3] avformat/udp: Enable FIFO when using windows sockets.

On 15 December 2016 at 21:42, Nicolas George <geo...@nsup.org> wrote: > Le duodi 22 frimaire, an CCXXV, Matt Oliver a écrit : > > --- > > libavformat/udp.c | 17 - > > 1 file changed, 16 insertions(+), 1 deletion(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] lavf/wavdec.c: Fix unresolved symbols on Mac and VS2015 Update 3

On 16 December 2016 at 09:54, Hendrik Leppkes wrote: > On Thu, Dec 15, 2016 at 8:43 PM, Matthew Wolenetz > wrote: > >> > >> This seems like a rather odd issue to be toolchain specific. Can you > >> please provide a configure command line that would

Re: [FFmpeg-devel] [PATCH] configure: fix linking with MSVC when using --disable-optimizations

On 16 December 2016 at 11:20, Carl Eugen Hoyos wrote: > 2016-12-14 16:47 GMT+01:00 Steve Lhomme : > > From: Steve Lhomme > > > > Without any optimization flags, MSVC does no dead code elimination (DCE) > at > > all, even for the most

Re: [FFmpeg-devel] [PATCH 3/3] avformat/udp: Enable FIFO when using windows sockets.

--- libavformat/udp.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index f8c861d..3cafb32 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c @@ -64,6 +64,14 @@ #define HAVE_PTHREAD_CANCEL 0 #endif +#if

Re: [FFmpeg-devel] [PATCH 2/3] avformat/udp: Use avutil compat pthread_cond_timedwait.

On 11 December 2016 at 00:21, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2016-12-07 7:04 GMT+01:00 Matt Oliver <protogo...@gmail.com>: > > > -#if HAVE_PTHREAD_CANCEL > > -#include > > -#endif > > - > > > #ifndef HAVE_PTHREAD_CANCEL >

Re: [FFmpeg-devel] [PATCH 3/3] avformat/udp: Enable FIFO when using windows sockets.

On 8 December 2016 at 04:49, Nicolas George wrote: > Le septidi 17 frimaire, an CCXXV, Hendrik Leppkes a écrit : > > I'm not sure you can safely avoid that in this design when dealing > > with a fully generic library and no information or control whats going > > on in other

Re: [FFmpeg-devel] [PATCH 3/3] avformat/udp: Enable FIFO when using windows sockets.

On 7 December 2016 at 21:19, Mark Thompson <s...@jkqxz.net> wrote: > On 07/12/16 06:05, Matt Oliver wrote: > > Signed-off-by: Matt Oliver <protogo...@gmail.com> > > --- > > libavformat/udp.c | 19 +-- > > 1 file changed, 17 insertion

Re: [FFmpeg-devel] [PATCH 1/3] avutil/thread: Add pthread_cond_timedwait function.

On 7 December 2016 at 21:32, Hendrik Leppkes <h.lepp...@gmail.com> wrote: > On Wed, Dec 7, 2016 at 7:04 AM, Matt Oliver <protogo...@gmail.com> wrote: > > Signed-off-by: Matt Oliver <protogo...@gmail.com> > > --- > > compat/os2threads.h | 24 +++

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

On 4 December 2016 at 01:56, Matt Oliver <protogo...@gmail.com> wrote: > Indeed, in theory that would work. I always forget about these options. >> In my experience they do not work reliably, and I would argue against >> their use in portable code. For example, st

Re: [FFmpeg-devel] [PATCH] Fix build with LibreSSL

On 30 October 2016 at 17:57, Michael Forney <mfor...@mforney.org> wrote: > On 10/29/16, Matt Oliver <protogo...@gmail.com> wrote: > > This also seems a bit odd, why is libreSSL setting an openssl version > > number of 1.1.0 or higher when it doesnt actually confo

[FFmpeg-devel] [PATCH 3/3] avformat/udp: Enable FIFO when using windows sockets.

Signed-off-by: Matt Oliver <protogo...@gmail.com> --- libavformat/udp.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index f8c861d..0e4766f 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c @@ -64,6

[FFmpeg-devel] [PATCH 2/3] avformat/udp: Use avutil compat pthread_cond_timedwait.

Signed-off-by: Matt Oliver <protogo...@gmail.com> --- libavformat/udp.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index 3835f98..f8c861d 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c @@ -60,14 +60,14 @@ #

[FFmpeg-devel] [PATCH 1/3] avutil/thread: Add pthread_cond_timedwait function.

Signed-off-by: Matt Oliver <protogo...@gmail.com> --- compat/os2threads.h | 24 compat/w32pthreads.h | 50 ++ libavutil/thread.h | 6 ++ 3 files changed, 80 insertions(+) diff --git a/compat/os2threads.h b/

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

> > Indeed, in theory that would work. I always forget about these options. > In my experience they do not work reliably, and I would argue against > their use in portable code. For example, starting there: > http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_socket.h.html > can you tell

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

On 3 December 2016 at 23:40, Hendrik Leppkes <h.lepp...@gmail.com> wrote: > On Sat, Dec 3, 2016 at 1:33 PM, Matt Oliver <protogo...@gmail.com> wrote: > > > > I havent fully tested Hendriks idea as the msdn docs dont recommend > calling > > multiple win

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

On 3 December 2016 at 22:33, Nicolas George <geo...@nsup.org> wrote: > Le tridi 13 frimaire, an CCXXV, Matt Oliver a écrit : > > I was just writing an email to rephrase but you beet me to it (sorry i > > wasnt faster) > > No problem. > > > I sho

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

On 3 December 2016 at 22:05, Nicolas George <geo...@nsup.org> wrote: > Le tridi 13 frimaire, an CCXXV, Matt Oliver a écrit : > > That was because the pthread wrappers dont set errno, so its a required > > change to remove dependency on pthread. > > The pthread wra

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

On 2 December 2016 at 22:16, Nicolas George <geo...@nsup.org> wrote: > Le duodi 12 frimaire, an CCXXV, Matt Oliver a écrit : > > --- > > configure | 6 -- > > libavformat/udp.c | 48 +++- > > 2 files change

[FFmpeg-devel] [PATCH 1/2] avutil/thread: Add pthread_cond_timedwait function.

Signed-off-by: Matt Oliver <protogo...@gmail.com> --- compat/os2threads.h | 24 compat/w32pthreads.h | 50 ++ libavutil/thread.h | 6 ++ 3 files changed, 80 insertions(+) diff --git a/compat/os2threads.h b/

[FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

--- configure | 6 -- libavformat/udp.c | 48 +++- 2 files changed, 19 insertions(+), 35 deletions(-) diff --git a/configure b/configure index b5bfad6..cec94c4 100755 --- a/configure +++ b/configure @@ -1934,7 +1934,6 @@ SYSTEM_FUNCS="

Re: [FFmpeg-devel] [PATCH] lavf/os_support: Add safe win32 dlopen/dlclose/dlsym functions.

On 31 October 2016 at 05:30, James Almer <jamr...@gmail.com> wrote: > On 10/30/2016 8:31 AM, Matt Oliver wrote: > > From 1dc1f59158cfb12d9160ee47342f5742d67ad864 Mon Sep 17 00:00:00 2001 > > From: Matt Oliver <protogo...@gmail.com> > > Date: Sun, 30 Oct 2016 1

Re: [FFmpeg-devel] [PATCH] lavf/os_support: Add safe win32 dlopen/dlclose/dlsym functions.

On 30 October 2016 at 20:21, Hendrik Leppkes <h.lepp...@gmail.com> wrote: > On Sun, Oct 30, 2016 at 5:13 AM, Matt Oliver <protogo...@gmail.com> wrote: > > On 30 October 2016 at 03:41, Stephen Hutchinson <qyo...@gmail.com> > wrote: > > > >> On 1

Re: [FFmpeg-devel] [PATCH] lavf/os_support: Add safe win32 dlopen/dlclose/dlsym functions.

On 30 October 2016 at 03:41, Stephen Hutchinson <qyo...@gmail.com> wrote: > On 10/29/2016 11:22 AM, Michael Niedermayer wrote: > >> On Sat, Oct 29, 2016 at 06:35:19PM +1100, Matt Oliver wrote: >> >>> configure |5 + >>> libavform

Re: [FFmpeg-devel] [PATCH] Fix build with LibreSSL

On 30 October 2016 at 09:39, Michael Niedermayer wrote: > On Fri, Oct 28, 2016 at 12:47:08AM -0700, Michael Forney wrote: > > Signed-off-by: Michael Forney > > --- > > libavformat/tls_openssl.c | 12 ++-- > > 1 file changed, 6 insertions(+),

Re: [FFmpeg-devel] [PATCH] lavf/os_support: Add safe win32 dlopen/dlclose/dlsym functions.

On 29 October 2016 at 23:54, Moritz Barsnick <barsn...@gmx.net> wrote: > On Sat, Oct 29, 2016 at 18:35:19 +1100, Matt Oliver wrote: > > > +#endif /* COMPAT_W32DLFCN_H */ > > \ No newline at end of file > > This shouldn't happen.

Re: [FFmpeg-devel] [PATCH] lavf/os_support: Add safe win32 dlopen/dlclose/dlsym functions.

> > FYI, last time i tried to include this file from libavcodec i was told >> not to since it's libavformat specific. >> >> The proper place for these wrappers is probably the compat folder, in >> a new file similar to w32threads.h >> > OK finally updated the patch. it now adds the safe dll

Re: [FFmpeg-devel] [PATCH] openssl: Support version 1.1.0.

On 15 October 2016 at 14:22, Matt Oliver <protogo...@gmail.com> wrote: > --- > configure | 3 +- > libavformat/tls_openssl.c | 163 -- > > 2 files changed, 102 insertions(+), 64 deletions(-) > > diff --

Re: [FFmpeg-devel] [PATCH] openssl: Support version 1.1.0.

On 10 October 2016 at 05:48, Lou Logan <l...@lrcd.com> wrote: > On Sun, Oct 9, 2016, at 07:39 AM, Matt Oliver wrote: > > --- > > configure | 3 +- > > libavformat/tls_openssl.c | 159 > > -- > >

Re: [FFmpeg-devel] [PATCH] openssl: Support version 1.1.0.

>From ad4d838ed6673c6d12aeaa7b00036b66371b4d63 Mon Sep 17 00:00:00 2001 From: Matt Oliver <protogo...@gmail.com> Date: Mon, 10 Oct 2016 06:49:54 +1100 Subject: [PATCH] openssl: Support version 1.1.0. Fixes #5675 Signed-off-by: Matt Oliver <protogo...@gmail.com>

Re: [FFmpeg-devel] [PATCH] openssl: Support version 1.1.0.

On 10 October 2016 at 03:18, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Mon, Oct 10, 2016 at 02:39:51AM +1100, Matt Oliver wrote: > > --- > > configure | 3 +- > > libavformat/tls_openssl.c | 159 > > ++

[FFmpeg-devel] [PATCH] openssl: Support version 1.1.0.

--- configure | 3 +- libavformat/tls_openssl.c | 159 -- 2 files changed, 98 insertions(+), 64 deletions(-) diff --git a/configure b/configure index df6ffa2..750684a 100755 --- a/configure +++ b/configure @@ -5813,7 +5813,8 @@

Re: [FFmpeg-devel] [PATCH 0/3] Include headers for cuvid

On 21 September 2016 at 15:28, Philip Langdale <phil...@overt.org> wrote: > On Wed, 21 Sep 2016 15:09:36 +1000 > Matt Oliver <protogo...@gmail.com> wrote: > > > On 21 September 2016 at 14:38, Philip Langdale <phil...@overt.org> > > wrote: > > > >

Re: [FFmpeg-devel] [PATCH 0/3] Include headers for cuvid

On 21 September 2016 at 14:38, Philip Langdale wrote: > The cuvid header situation is a mess - the only feature-complete headers > are > in the Video SDK and not in the cuda header collection. The headers in the > Video SDK are MIT licenced, and so we can bundle them like we

Re: [FFmpeg-devel] Patch for fixing of nvenc.c compilation using msvc tools

On 14 September 2016 at 20:22, Yogender Kumar Gupta < yogender.gu...@gmail.com> wrote: > Currently libavcodec.c/nvenc.c is not compilable using MSVC tools. I am > attaching a patch that fixes this issue. > > Thanks, > Yogender > What version of msvc are you using? 2015 and 2013 all work fine

Re: [FFmpeg-devel] [PATCH] lavf/os_support: Add safe win32 dlopen/dlclose/dlsym functions.

30 August 2016 at 02:26, Jean-Baptiste Kempf <j...@videolan.org> wrote: > On 28 Aug, Matt Oliver wrote : > > The dlopen function is modified to prevent loading dll's from the current > > directory for improved program security for library users. This extends > >

Re: [FFmpeg-devel] [PATCH] configure: Remove fifo muxers dependency on pthreads.

On 29 August 2016 at 17:28, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > Hi! > > 2016-08-29 9:00 GMT+02:00 Matt Oliver <protogo...@gmail.com>: > > On 29 August 2016 at 16:43, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > > > >

Re: [FFmpeg-devel] [PATCH] configure: Remove fifo muxers dependency on pthreads.

On 29 August 2016 at 16:43, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > Hi! > > 2016-08-29 8:17 GMT+02:00 Matt Oliver <protogo...@gmail.com>: > > The fifo muxer works without pthreads due to the existing pthread > > wrappers already available within ffmpeg f

Re: [FFmpeg-devel] [PATCH] lavf/os_support: Add safe win32 dlopen/dlclose/dlsym functions.

On 28 August 2016 at 19:58, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Sun, Aug 28, 2016 at 06:50:58PM +1000, Matt Oliver wrote: > > The dlopen function is modified to prevent loading dll's from the current > > directory for improved program security for librar

[FFmpeg-devel] [PATCH] configure: Remove fifo muxers dependency on pthreads.

The fifo muxer works without pthreads due to the existing pthread wrappers already available within ffmpeg for other platforms. --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index 5c11040..e225b7d 100755 --- a/configure +++ b/configure @@ -2834,7 +2834,6

[FFmpeg-devel] [PATCH] lavf/os_support: Add safe win32 dlopen/dlclose/dlsym functions.

The dlopen function is modified to prevent loading dll's from the current directory for improved program security for library users. This extends similar functionality from the recently applied SetDllDirectory patch except that it adds additional security for library users as well (as opposed to

  1   2   >