This message has been marked as Public on 04/19/2024 10:23Z.
On Thursday, April 11, 2024 3:01 PM Ignjatović, Lazar (RS) wrote:
> avformat: enable UDP IPv6 multicast interface selection using zone index
>
> Enabled IPv6 interface selection using zone index. Properly resolved
> int
avformat: enable UDP IPv6 multicast interface selection using zone index
Enabled IPv6 interface selection using zone index. Properly resolved
interface index in places where default 0 interface index is used
(marked with TODO: within udp.c). Adjusted binding for multicast sockets
that are used
This message has been marked as Public on 04/11/2024 07:58Z.
On Thursday, April 11, 2024 9:50 AM Lynne wrote:
> Is there a reason why we can't switch to IPv4 addresses mapped in IPv6 and
> just use the IPv6 API everywhere?
I'm not the person to give you that answer.
My guess is that due to API
avformat: enable UDP IPv6 multicast interface selection using zone index
Enabled IPv6 interface selection using zone index. Properly resolved
interface index in places where default 0 interface index is used
(marked with TODO: within udp.c). Adjusted binding for multicast sockets
that are used
avformat: enable UDP IPv6 multicast interface selection using zone index
Enabled IPv6 interface selection using zone index. Properly resolved
interface index in places where default 0 interface index is used
(marked with TODO: within udp.c). Adjusted binding for multicast sockets
that are used
This message has been marked as Public on 03/27/2024 08:53Z.
On Tuesday, March 26, 2024 7:26 PM Rémi Denis-Courmont wrote:
> Both patches -1 for same reasons as before and that's unnecessary,
> functionally incorrect and potentially racy, enumeration of local interfaces.
Enumeration of
avformat: enable UDP IPv6 multicast interface selection using zone index
Enabled IPv6 interface selection using zone index. Properly resolved
interface index in places where default 0 interface index is used
(marked with TODO: within udp.c). Adjusted binding for multicast sockets
that are used
avformat: enable UDP IPv6 multicast interface selection using localaddr
localaddr option now properly works with IPv6 addresses. Properly
resolved interface index in places where default 0 interface index is
used (marked with TODO: within udp.c). Adjusted binding for multicast
sockets that are
This message has been marked as Public on 03/22/2024 10:16Z.
On Friday, March 22, 2024 10:55 AM Rémi Denis-Courmont wrote:
> So why are you arguing now?
Because I still belive that using localaddr is the better approach.
However, I will create and submit v3 of this patch and also create
another
>> I've compared ffmpeg 5.1.2 against my MR on IPv6 multicast. Here are
>> the
>> results:
>
> I don't care. That does not make your MR any less counter-sensical.
If I may cite Marton Balint
```
d3bda871f033be4825ecb69d444b3396bf2a2eb7
avformat/udp: specify the local address for some source
> Your MR makes even less sense for multicast. For multicast there is no local
> address to match to an interface. So you just have to have the interface
> specified explicitly in addition to the LL group address. This is true for
> both egress and ingress.
I've compared ffmpeg 5.1.2 against
This message has been marked as Public on 03/20/2024 12:35Z.
On Wednesday, March 20, 2024 1:18 PM Rémi Denis-Courmont wrote:
>> In all other cases, determining the interface ID by address should be
>> ok,
>
> No! The only other case is non-LL addressing, which does not require link ID
> at all.
This message has been marked as Public on 03/20/2024 11:45Z.
On Wednesday, March 20, 2024 12:30 PM Rémi Denis-Courmont wrote:
> You're not supposed to guess the link ID from the local address. This is
> counter-sensical. And it's entirely possible to have the same LL address
> assigned to two
This message has been marked as Public on 03/20/2024 11:09Z.
On Wednesday, March 20, 2024 11:51 AM Rémi Denis-Courmont wrote:
> Same fundamental problem as previous version, AFAICT.
>
> -1
Would you mind being more specific?
There are 2 problems you pointed out, one about SO_BINDTODEVICE, and
avformat: enable UDP IPv6 multicast interface selection
localaddr option now properly works with IPv6 addresses. Properly
resolved interface index in places where default 0 interface index is
used (marked with TODO: within udp.c). Adjusted binding for multicast
sockets that are used for reading
This message has been marked as Public on 03/19/2024 09:40Z.
On Friday, March 15, 2024 5:27 PM Rémi Denis-Courmont wrote:
>>
>> localaddr option now properly works with IPv6 addresses. Properly
>> resolved interface index in places where default 0 interface index is
>> used (marked with TODO:
This message has been marked as Public on 03/18/2024 13:45Z.
On Thursday, March 14, 2024 10:14 PM, Michael Niedermayer wrote:
> breaks mingw64 build
>
> CC libavformat/ip.o
> src/libavformat/ip.c: In function ‘ff_ip_resolve_interface_index’:
> src/libavformat/ip.c:206:1: error: control
localaddr option now properly works with IPv6 addresses. Properly
resolved interface index in places where default 0 interface index is
used (marked with TODO: within udp.c). Added SO_BINDTODEVICE for mcast
sockets that are used for reading from the network. Need for this
arises from the fact that
>> +if (if_indextoname(iface, ifr.ifr_name)) {
>> +if (setsockopt(udp_fd, SOL_SOCKET, SO_BINDTODEVICE, (void
>> *), sizeof(ifr)) < 0) {
>> +perror("setsockopt SO_BINDTODEVICE");
>
> This should use the proper av_log logging instead.
Will fix and
avformat: enable UDP IPv6 multicast interface selection
localaddr option now properly works with IPv6 addresses. Properly resolved
interface index in places where default 0 interface index is used (marked with
TODO: within udp.c). Added SO_BINDTODEVICE for mcast sockets that are used for
reading
20 matches
Mail list logo
