Re: [FFmpeg-devel] [PATCH] avformat/movenc: fix recognization of cover image streams

On Wed, 13 Jun 2018 17:18:51 +0200 Carl Eugen Hoyos wrote: > 2018-06-13 16:57 GMT+02:00, Timo Teras : > > On Tue, 12 Jun 2018 23:09:47 +0200 > > Michael Niedermayer wrote: > > > >> On Mon, Jun 04, 2018 at 05:36:19PM +0300, Timo Teräs wrote: > >> >

Re: [FFmpeg-devel] [PATCH] avformat/movenc: fix recognization of cover image streams

On Tue, 12 Jun 2018 23:09:47 +0200 Michael Niedermayer wrote: > On Mon, Jun 04, 2018 at 05:36:19PM +0300, Timo Teräs wrote: > > For chapter images, the mov demux produces streams with disposition > > set to attached_pic+timed_thumbnails. This patch fixes to properly > > recognize streams that

Re: [FFmpeg-devel] [PATCH] avformat/movenc: fix recognization of cover image streams

On Mon, 4 Jun 2018 17:36:19 +0300 Timo Teräs wrote: > For chapter images, the mov demux produces streams with disposition > set to attached_pic+timed_thumbnails. This patch fixes to properly > recognize streams that should be encoded as cover image (ones with > only and only attached_pic

Re: [FFmpeg-devel] [PATCH v2] avformat/movenc: properly handle cover image codecs

On Sat, 2 Jun 2018 02:15:29 +0300 Timo Teras wrote: > On Sat, 2 Jun 2018 00:46:30 +0200 > Michael Niedermayer wrote: > > > input can be found here: > > https://guiltyfeminist.libsyn.com/97-repeal-the-eighth-with-helen-linehan > > This has been broken all time,

Re: [FFmpeg-devel] [PATCH v2] avformat/movenc: properly handle cover image codecs

On Sat, 2 Jun 2018 00:46:30 +0200 Michael Niedermayer wrote: > On Fri, Jun 01, 2018 at 02:24:39AM +0300, Timo Teräs wrote: > > Find codec tag for attached images using appropriate list of > > supported image formats. > > > > This fixes writing the cover image to m4v/m4a and other container > >

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

On Tue, 17 Apr 2018 11:06:58 +0200 Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Tue, Apr 17, 2018 at 08:32:57AM +0300, Timo Teras wrote: > > See my earlier patch that changes it to report as "N/A". This is > > what > > i meant the function.

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

On Tue, 17 Apr 2018 01:02:43 +0200 Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Mon, Apr 16, 2018 at 07:56:34PM +0200, Marton Balint wrote: > > > > On Mon, 16 Apr 2018, Timo Teras wrote: > > > > >On Sun, 15 Apr 2018 16:42:01 +0200 (CEST) >

Re: [FFmpeg-devel] [PATCH v2] avformat/movenc: support writing iTunes cover image

On Tue, 17 Apr 2018 00:01:42 +0100 Rostislav Pehlivanov <atomnu...@gmail.com> wrote: > On 16 April 2018 at 15:05, Timo Teras <timo.te...@iki.fi> wrote: > > > On Mon, 16 Apr 2018 10:53:43 -0300 > > James Almer <jamr...@gmail.com> wrote: > > &g

Re: [FFmpeg-devel] [PATCH v2] avformat/movenc: support writing iTunes cover image

On Mon, 16 Apr 2018 10:53:43 -0300 James Almer wrote: > On 4/14/2018 3:32 PM, Timo Teräs wrote: > > Fixes https://trac.ffmpeg.org/ticket/2798 > > > > This makes movenc handle AV_DISPOSITION_ATTACHED_PIC and write > > the associated pictures in iTunes cover atom. This

Re: [FFmpeg-devel] FFmpeg 3.5 / 4.0

On Mon, 16 Apr 2018 13:24:48 +0200 Michael Niedermayer wrote: > release/4.0 branched > next is the release in a few days. > If theres something i should wait for please say so and CC me > also please backport all bugfixes to 4.0 I was hoping to get my patches in for the

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

On Sun, 15 Apr 2018 16:42:01 +0200 (CEST) Marton Balint wrote: > On Sun, 15 Apr 2018, Timo Teräs wrote: > > > Calculate DAR with assumed SAR 1:1 when SAR is undefined. Same > > assumption is done in ffplay to create the play window. Usually > > DAR is more useful metadata than

Re: [FFmpeg-devel] [PATCH] ffprobe: report unavailable SAR correctly in stream info

On Thu, 12 Apr 2018 11:07:36 +0300 Timo Teräs wrote: > av_guess_sample_aspect_ratio() will return undefined or missing > value as {0,1}. This fixes show_stream() to check numerator to > display 'N/A' when appropriate. show_frame() does this already > correctly. > >

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: support writing iTunes cover image

On Wed, 11 Apr 2018 14:25:15 +0100 Rostislav Pehlivanov wrote: > On 11 April 2018 at 06:22, Timo Teräs wrote: > > > Ping. > > > > Any comments on this? > > > > There was also recently the flacenc support for cover images, and > > the question if some of

Re: [FFmpeg-devel] [PATCH] avformat/movenc: use correct iTunes copyright atom

On Tue, 3 Apr 2018 09:05:18 +0300 Timo Teräs wrote: > Support for writing copyright metadata was added in commit bed4fc54c9 > for 3GP, MOV and iTunes metadata. 3GP and MOV cases are formally > specified. However, iTunes format does not have specification, and > it seems to

Re: [FFmpeg-devel] [PATCH] avformat/flacenc: support writing attached pictures

On Wed, 4 Apr 2018 02:30:34 -0300 James Almer <jamr...@gmail.com> wrote: > On 4/4/2018 2:11 AM, Timo Teras wrote: > > On Wed, 4 Apr 2018 01:30:54 -0300 > > James Almer <jamr...@gmail.com> wrote: > > > >> From: Rodger Combs <rodger.co...@gmail.co

Re: [FFmpeg-devel] [PATCH] avformat/flacenc: support writing attached pictures

On Wed, 4 Apr 2018 01:30:54 -0300 James Almer wrote: > From: Rodger Combs > > Signed-off-by: James Almer > --- > Now using the packet list API instead of duplicating the code locally. > > libavformat/flacenc.c | 274 >

Re: [FFmpeg-devel] [PATCH 1/1] avformat/movenc: use modern iTunes copyright atom

On Fri, 30 Mar 2018 04:06:03 +0300 Timo Teras <timo.te...@iki.fi> wrote: > On Fri, 30 Mar 2018 02:39:13 +0200 > Michael Niedermayer <mich...@niedermayer.cc> wrote: > > > git log points to > > bed4fc54c947b9e36d2103b400d438bfb4dd80dd > > > > This co

Re: [FFmpeg-devel] [PATCH] [RFC] avformat/movenc: support writing iTunes cover image

Hi On Sat, 31 Mar 2018 02:13:14 +0200 Michael Niedermayer wrote: > On Thu, Mar 29, 2018 at 09:45:13AM +0300, Timo Teräs wrote: > > Fixes https://trac.ffmpeg.org/ticket/2798 > > > > This makes movenc handle AV_DISPOSITION_ATTACHED_PIC and write > > the associated

Re: [FFmpeg-devel] [PATCH 1/1] avformat/movenc: use modern iTunes copyright atom

On Fri, 30 Mar 2018 03:54:59 +0300 Jan Ekström wrote: > On Fri, Mar 30, 2018 at 3:39 AM, Michael Niedermayer > wrote: > > > > If it was a typo or something like that, i agree that it should be > > removed/replaced. I was assuming it come from some

Re: [FFmpeg-devel] [PATCH 1/1] avformat/movenc: use modern iTunes copyright atom

On Fri, 30 Mar 2018 02:39:13 +0200 Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Thu, Mar 29, 2018 at 10:12:50PM +0300, Timo Teras wrote: > > On Thu, 29 Mar 2018 20:29:44 +0200 > > Michael Niedermayer <mich...@niedermayer.cc> wrote: > > > > >

Re: [FFmpeg-devel] [PATCH 1/1] avformat/movenc: use modern iTunes copyright atom

On Thu, 29 Mar 2018 20:29:44 +0200 Michael Niedermayer wrote: > On Wed, Mar 28, 2018 at 07:02:48PM +0300, Timo Teräs wrote: > > iTunes currently uses the 'cprt' atom to store the copyright notice > > and this patch fixes compatibility with majority of software that > >

[FFmpeg-devel] Writing iTunes cover images to mp4 files

Hi ffmpeg-devel, I am looking into and happy to write the code to write iTunes cover images to mp4 files. It seems there's a bug tracking this at: https://trac.ffmpeg.org/ticket/2798 And apparently there was already patches posted some years ago. The best patch around seems to be:

[FFmpeg-devel] mpegtsenc cbr mode pcr accuracy

Hi, While the pcr is accuracte, I was measuring the cbr pcr frequence with opencaster suite's tspcmeasure tool, and it says that the frequency is not that accurate. With default options (just muxrate specified) the pcr should appear every 20ms. But it appears every 19-22.5ms (also there some