[FFmpeg-devel] [PATCH] avformat: Add v210 demuxer

/null +++ b/libavformat/v210.c @@ -0,0 +1,133 @@ +/* + * Raw v210 video demuxer + * Copyright (c) 2015 Tiancheng "Timothy" Gu + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser Gene

Re: [FFmpeg-devel] [PATCH] avformat: Add v210 demuxer

On Sat, Nov 07, 2015 at 10:22:34PM -0300, James Almer wrote: > On 11/7/2015 9:45 PM, Timothy Gu wrote: > > +#define OFFSET(x) offsetof(V210DemuxerContext, x) > > +#define DEC AV_OPT_FLAG_DECODING_PARAM > > +static const AVOption v210_options[] = { > > +{ "video

[FFmpeg-devel] [PATCH 2/2] genh: Removed unused variable coef_splitted

--- libavformat/genh.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/genh.c b/libavformat/genh.c index 260e320..44862b3 100644 --- a/libavformat/genh.c +++ b/libavformat/genh.c @@ -40,7 +40,6 @@ static int genh_read_header(AVFormatContext *s) { unsigned

[FFmpeg-devel] [PATCH 1/2] aaccoder_twoloop: Mark sfdiff as av_unused

--- libavcodec/aaccoder_twoloop.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aaccoder_twoloop.h b/libavcodec/aaccoder_twoloop.h index e53257f..328d7c8 100644 --- a/libavcodec/aaccoder_twoloop.h +++ b/libavcodec/aaccoder_twoloop.h @@ -691,7 +691,7 @@ static void

Re: [FFmpeg-devel] [PATCH] Add pixblockdsp checkasm tests

On Sun, Nov 08, 2015 at 03:04:21AM +0100, Michael Niedermayer wrote: > On Sat, Nov 07, 2015 at 03:58:28PM -0800, Timothy Gu wrote: > > --- > > > > Consolidates BUF_SIZE macros > > > > --- > > tests/checkasm/Makefile | 1 + > > tests/checka

Re: [FFmpeg-devel] [PATCH] web/download: point to the official Debian/Ubuntu packages

On Fri, Nov 06, 2015 at 08:18:39PM +0100, Andreas Cadhalpun wrote: [...] > diff --git a/src/download b/src/download > index 5691fbd..6d3517e 100644 > --- a/src/download > +++ b/src/download > @@ -53,13 +53,22 @@ > > Linux Packages > > +

Re: [FFmpeg-devel] [PATCH 1/2] pixblockdsp: x86: Condense diff_pixels_* to a shared macro

On Sun, Nov 1, 2015 at 8:59 AM Timothy Gu <timothyg...@gmail.com> wrote: > --- > libavcodec/x86/pixblockdsp.asm | 66 > -- > 1 file changed, 31 insertions(+), 35 deletions(-) > Ping set. Timothy _

Re: [FFmpeg-devel] [PATCH] jvdec: avoid unsized overflow in comparison

On Fri, Nov 06, 2015 at 09:11:40PM +0100, Andreas Cadhalpun wrote: > Subject: [FFmpeg-devel] [PATCH] jvdec: avoid unsized overflow in comparison *unsigned [...] Timothy ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] swresample/resample: improve bessel function accuracy

On Tue, Nov 3, 2015 at 4:47 AM Ganesh Ajjanagadde > - GCC vectorization slows down compilation A LOT in all versions. The newer > > the worse. > > A ~ 20% slowdown on a build for a ~ 20% improvement in an overall FATE > bench - sounds like a win to me especially with ccache. Of course, but

Re: [FFmpeg-devel] [PATCH] swresample/resample: improve bessel function accuracy

On Mon, Nov 2, 2015 at 8:23 PM Rostislav Pehlivanov wrote: > >if one removes the crippling > >-fno-tree-vectorize > Yes, I think a config option to turn this flag on (like the unsafe > bitstream reader) would be good. Defaulting to off by default if it doesn't > break

[FFmpeg-devel] [PATCH 2/2] Add pixblockdsp checkasm tests

b/tests/checkasm/pixblockdsp.c new file mode 100644 index 000..d59d162 --- /dev/null +++ b/tests/checkasm/pixblockdsp.c @@ -0,0 +1,107 @@ +/* + * Copyright (c) 2015 Tiancheng "Timothy" Gu + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute

[FFmpeg-devel] [PATCH 1/2] pixblockdsp: x86: Condense diff_pixels_* to a shared macro

--- libavcodec/x86/pixblockdsp.asm | 66 -- 1 file changed, 31 insertions(+), 35 deletions(-) diff --git a/libavcodec/x86/pixblockdsp.asm b/libavcodec/x86/pixblockdsp.asm index 7c5377b..a7d9816 100644 --- a/libavcodec/x86/pixblockdsp.asm +++

[FFmpeg-devel] [PATCH] boxblur: Templatize blur{8,16}

--- libavfilter/vf_boxblur.c | 110 +++ 1 file changed, 44 insertions(+), 66 deletions(-) diff --git a/libavfilter/vf_boxblur.c b/libavfilter/vf_boxblur.c index ef01cf9..6934076 100644 --- a/libavfilter/vf_boxblur.c +++ b/libavfilter/vf_boxblur.c @@

Re: [FFmpeg-devel] [PATCH] boxblur: Templatize blur{8,16}

On Sun, Nov 1, 2015 at 4:45 PM Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Sun, Nov 01, 2015 at 10:40:03AM -0800, Timothy Gu wrote: > > --- > > libavfilter/vf_boxblur.c | 110 > +++ > > 1 file changed,

Re: [FFmpeg-devel] [PATCH] boxblur: Templatize blur{8,16}

On Sun, Nov 1, 2015 at 11:10 AM Ganesh Ajjanagadde wrote: > Have not tested, but just a general comment. Personally, I follow the > twice repition is ok, thrice means it is good to factor out. I would > have been happier if the diff-stat was better than 44+/66- in terms of >

Re: [FFmpeg-devel] [PATCH] pixblockdsp: Use memcpy for get_pixels_16_c

On Tue, Oct 20, 2015 at 11:29 PM Michael Niedermayer wrote: > > diff --git a/libavcodec/pixblockdsp.c b/libavcodec/pixblockdsp.c > > index 322e1dd..0f23d8a 100644 > > --- a/libavcodec/pixblockdsp.c > > +++ b/libavcodec/pixblockdsp.c > > @@ -23,12 +23,38 @@ > > #include

Re: [FFmpeg-devel] [PATCH] avcodec/huffman: replace qsort with AV_QSORT

On Thu, Oct 22, 2015 at 5:01 PM Ganesh Ajjanagadde wrote: > Sample benchmark (x86-64, Haswell, GNU/Linux), fraps-v2 from FATE: > new: > 280110 decicycles in qsort, 1 runs, 0 skips > 268260 decicycles in qsort, 2 runs, 0 skips > > old: > 1469910

Re: [FFmpeg-devel] [PATCH] huffyuvencdsp: Add ff_diff_bytes_{sse2, avx2}

On Wed, Oct 21, 2015 at 10:32 AM Timothy Gu <timothyg...@gmail.com> wrote: > On Tue, Oct 20, 2015 at 7:36 PM James Almer <jamr...@gmail.com> wrote: > >> On 10/20/2015 10:32 PM, Timothy Gu wrote: >> > > +; mov type used for src1q, dstq, first reg, second reg

Re: [FFmpeg-devel] [PATCH] huffyuvencdsp: Add ff_diff_bytes_{sse2, avx2}

On Tue, Oct 20, 2015 at 7:36 PM James Almer <jamr...@gmail.com> wrote: > On 10/20/2015 10:32 PM, Timothy Gu wrote: > > +; mov type used for src1q, dstq, first reg, second reg > > +%macro DIFF_BYTES_LOOP_CORE 4 > > +%if regsize != 16 > > %if mmsize != 16 >

Re: [FFmpeg-devel] [PATCH] vc1dsp: Port ff_vc1_put_ver_16b_shift2_mmx to yasm

On Wed, Oct 21, 2015 at 10:46 AM Christophe Gisquet < christophe.gisq...@gmail.com> wrote: > 2015-10-18 2:47 GMT+02:00 Timothy Gu <timothyg...@gmail.com>: > > This function is only used within other inline asm functions, hence the > > HAVE_MMX_INLINE guard. Per re

Re: [FFmpeg-devel] [PATCH 1/2] dnxhdenc: Optimize get_pixels_8x4_sym for 10-bit

On Tue, Oct 20, 2015 at 9:30 AM Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Sat, Oct 17, 2015 at 06:05:45PM -0700, Timothy Gu wrote: > > This reverts commit 628e6d0164febc8e69b0f10dfa487e8a2dd1a28a and uses > > a better fix. > > > > Before: > >

[FFmpeg-devel] [PATCH] pixblockdsp: Use memcpy for get_pixels_16_c

Before: 15543 decicycles in get_pixels, 4193214 runs, 1090 skips After: 5713 decicycles in get_pixels, 8387564 runs, 1044 skips --- libavcodec/pixblockdsp.c | 36 ++- libavcodec/pixblockdsp_template.c | 40 ---

[FFmpeg-devel] [PATCH] huffyuvencdsp: Add ff_diff_bytes_{sse2, avx2}

SSE2 version 4%-35% faster than MMX depending on the width. AVX2 version 1%-13% faster than SSE2 depending on the width. --- Addressed James's and Henrik's advices. Removed heuristics based on width. Made available both aligned and unaligned versions. For AVX2 version, gracefully fall back on

Re: [FFmpeg-devel] [PATCH] huffyuvencdsp: Convert ff_diff_bytes_mmx to yasm

On Tue, Oct 20, 2015 at 2:18 PM James Almer wrote: > Removing this will make the INLINE_MMXEXT if statement below fail to > compile on > builds with inline asm disabled (msvc, etc). Even with dead code > elimination in > mind you'd need at least a prototype for the relevant

Re: [FFmpeg-devel] forcing ints to be 64 bits, possible new FATE client idea

On Tue, Oct 20, 2015 at 7:09 PM Ganesh Ajjanagadde wrote: > Hi all, > > It is known that there exist at least certain parts of the codebase > that do not work correctly if ints are 64 bits. One of them I noticed > was in avutil/intmath.h: ff_ctz_c does not compute the right

[FFmpeg-devel] [PATCH 2/4] huffyuvencdsp: Convert ff_diff_bytes_mmx to yasm

* Conversion to NASM format by Tiancheng "Timothy" Gu <timothyg...@gmail.com> +;* +;* This file is part of FFmpeg. +;* +;* FFmpeg is free software; you can redistribute it and/or +;* modify it under the terms of the GNU Lesser General Public +;* License as published by the Free

[FFmpeg-devel] [PATCH 4/4] huffyuvencdsp: Add ff_diff_bytes_avx2

About 16% faster on large clips (>1200px width), more than 2x slower on small clips (352px). So using a heuristic to select with one to use. --- libavcodec/huffyuvenc.c| 6 +++--- libavcodec/huffyuvencdsp.c | 4 ++-- libavcodec/huffyuvencdsp.h | 4 ++--

Re: [FFmpeg-devel] [PATCH 4/4] huffyuvencdsp: Add ff_diff_bytes_avx2

On Mon, Oct 19, 2015 at 1:44 PM Ganesh Ajjanagadde <gajja...@mit.edu> wrote: > On Mon, Oct 19, 2015 at 4:41 PM, Hendrik Leppkes <h.lepp...@gmail.com> > wrote: > > On Mon, Oct 19, 2015 at 10:36 PM, Ganesh Ajjanagadde <gajja...@mit.edu> > wrote: > >> O

[FFmpeg-devel] [PATCH 3/4] huffyuvencdsp: Add ff_diff_bytes_sse2

4% to 35% faster depending on the width. --- libavcodec/x86/huffyuvencdsp.asm | 31 --- libavcodec/x86/huffyuvencdsp_mmx.c | 8 +++- 2 files changed, 27 insertions(+), 12 deletions(-) diff --git a/libavcodec/x86/huffyuvencdsp.asm

[FFmpeg-devel] [PATCH 1/4] huffyuvencdsp: Use intptr_t for width

It is done this way in huffyuvdsp as well. --- libavcodec/huffyuvencdsp.c | 4 ++-- libavcodec/huffyuvencdsp.h | 4 ++-- libavcodec/x86/huffyuvencdsp_mmx.c | 5 +++-- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/libavcodec/huffyuvencdsp.c

Re: [FFmpeg-devel] [PATCH 2/4] x86: fpel: Remove erroneous ff_put_pixels8_mmxext prototype

On Sat, Oct 17, 2015 at 6:31 PM Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Sat, Oct 17, 2015 at 04:48:59PM -0700, Timothy Gu wrote: > > This function does not exist. > > --- > > libavcodec/x86/fpel.h | 2 -- > > 1 file changed, 2 deletions(-) >

Re: [FFmpeg-devel] [PATCH 3/4] x86: vc1dsp_mmx: Move yasm initiation steps to vc1dsp_init

On Sat, Oct 17, 2015 at 4:49 PM Timothy Gu <timothyg...@gmail.com> wrote: > That's where all yasm initiation steps are. Also removes the overlap > between the two files. > --- > libavcodec/x86/vc1dsp_init.c | 36 +--- > libavcodec/x

Re: [FFmpeg-devel] [PATCH 1/4] huffyuvencdsp: Use intptr_t for width

On Mon, Oct 19, 2015 at 3:53 PM Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Mon, Oct 19, 2015 at 01:00:43PM -0700, Timothy Gu wrote: > > It is done this way in huffyuvdsp as well. > > --- > > libavcodec/huffyuvencdsp.c | 4 ++-- > > libav

Re: [FFmpeg-devel] [PATCH 1/4] x86: fpel: Move prototypes for 4-px block functions

On Sat, Oct 17, 2015 at 4:49 PM Timothy Gu <timothyg...@gmail.com> wrote: > --- > libavcodec/x86/fpel.h | 6 ++ > libavcodec/x86/h264_qpel.c | 4 > 2 files changed, 6 insertions(+), 4 deletions(-) > Pushed. Timothy ___

[FFmpeg-devel] [PATCH] huffyuvencdsp: Convert ff_diff_bytes_mmx to yasm

+;* Copyright (c) 2002-2004 Michael Niedermayer <michae...@gmx.at> +;* +;* MMX optimization by Nick Kurshev <nickol...@mail.ru> +;* Conversion to NASM format by Tiancheng "Timothy" Gu <timothyg...@gmail.com> +;* +;* This file is part of FFmpeg. +;* +;* FFmpeg is free so

[FFmpeg-devel] [PATCH] vc1dsp: Port ff_vc1_put_ver_16b_shift2_mmx to yasm

This function is only used within other inline asm functions, hence the HAVE_MMX_INLINE guard. Per recent discussions, we should not worry about the performance of inline asm-only builds. --- The conversion process has to start _somewhere_... Difference from previous version: use mova/h, correct

[FFmpeg-devel] [PATCH 1/2] dnxhdenc: Optimize get_pixels_8x4_sym for 10-bit

This reverts commit 628e6d0164febc8e69b0f10dfa487e8a2dd1a28a and uses a better fix. Before: 4483 decicycles in get_pixels_8x4_sym, 131032 runs, 40 skips After: 2569 decicycles in get_pixels_8x4_sym, 131054 runs, 18 skips --- libavcodec/dnxhdenc.c | 24 1 file

[FFmpeg-devel] [PATCH 4/4] vc1dsp: Port ff_vc1_put_ver_16b_shift2_mmx to yasm

This function is only used within other inline asm functions, hence the HAVE_MMX_INLINE guard. Per recent discussions, we should not worry about the performance of inline asm-only builds. --- libavcodec/x86/vc1dsp.asm | 89 -

[FFmpeg-devel] [PATCH 2/2] pixblockdsp: Use memcpy for get_pixels_16_c

Before: 15543 decicycles in get_pixels, 4193214 runs, 1090 skips After: 5713 decicycles in get_pixels, 8387564 runs, 1044 skips --- libavcodec/pixblockdsp.c | 38 - libavcodec/pixblockdsp_template.c | 40 ---

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/internal: Doxygen for ff_fmt_is_in

On Sat, Oct 17, 2015 at 7:59 AM Ganesh Ajjanagadde <gajjanaga...@gmail.com> wrote: > On Thu, Oct 15, 2015 at 6:26 AM, Ganesh Ajjanagadde > <gajjanaga...@gmail.com> wrote: > > On Thu, Oct 15, 2015 at 1:45 AM, Timothy Gu <timothyg...@gmail.com> > wrote: > >&

[FFmpeg-devel] [PATCH 3/4] x86: vc1dsp_mmx: Move yasm initiation steps to vc1dsp_init

That's where all yasm initiation steps are. Also removes the overlap between the two files. --- libavcodec/x86/vc1dsp_init.c | 36 +--- libavcodec/x86/vc1dsp_mmx.c | 27 --- 2 files changed, 25 insertions(+), 38 deletions(-) diff --git

[FFmpeg-devel] [PATCH 1/4] x86: fpel: Move prototypes for 4-px block functions

--- libavcodec/x86/fpel.h | 6 ++ libavcodec/x86/h264_qpel.c | 4 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/x86/fpel.h b/libavcodec/x86/fpel.h index 4d93959..625c47d 100644 --- a/libavcodec/x86/fpel.h +++ b/libavcodec/x86/fpel.h @@ -22,6 +22,10 @@

[FFmpeg-devel] [PATCH 2/4] x86: fpel: Remove erroneous ff_put_pixels8_mmxext prototype

This function does not exist. --- libavcodec/x86/fpel.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/x86/fpel.h b/libavcodec/x86/fpel.h index 625c47d..4e83cf7 100644 --- a/libavcodec/x86/fpel.h +++ b/libavcodec/x86/fpel.h @@ -40,8 +40,6 @@ void ff_put_pixels4_mmx(uint8_t

Re: [FFmpeg-devel] [PATCH] chromakey: Use the pixel descriptor API for chroma subsampling info

On Tue, Oct 13, 2015 at 9:33 PM Timothy Gu <timothyg...@gmail.com> wrote: > --- > libavfilter/vf_chromakey.c | 25 + > 1 file changed, 17 insertions(+), 8 deletions(-) > Reviewed by Timo on IRC and pushed. Timothy

Re: [FFmpeg-devel] [PATCH 1/4] opencl: Print error string when compilation fails

On Wed, Oct 14, 2015 at 2:21 PM Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Tue, Oct 13, 2015 at 09:48:35PM -0700, Timothy Gu wrote: > > --- > > libavutil/opencl.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > LGTM &

Re: [FFmpeg-devel] [PATCH] doc/ffmpeg: use stream_loop instead of loop

On Wed, Oct 14, 2015 at 8:08 PM Ganesh Ajjanagadde wrote: > pushed. Please let me know if such things are ok or not in the future > - technically I guess doc maintainers need to respond before I can > push, but as this change was trivial I thought I would do it.\ > As a

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/internal: Doxygen for ff_fmt_is_in

On Wed, Oct 14, 2015 at 8:05 PM Ganesh Ajjanagadde wrote: > This clarifies and Doxygen's the comment for ff_fmt_is_in. ^ gajjanag.c:1:23: error: unexpected token ‘adjective’ > > Signed-off-by: Ganesh Ajjanagadde > --- >

[FFmpeg-devel] [PATCH 1/4] opencl: Print error string when compilation fails

--- libavutil/opencl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavutil/opencl.c b/libavutil/opencl.c index 8686493..c2956fd 100644 --- a/libavutil/opencl.c +++ b/libavutil/opencl.c @@ -484,7 +484,8 @@ cl_program av_opencl_compile(const char *program_name, const

[FFmpeg-devel] [PATCH] chromakey: Use the pixel descriptor API for chroma subsampling info

--- libavfilter/vf_chromakey.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/libavfilter/vf_chromakey.c b/libavfilter/vf_chromakey.c index 47fdea631..3309748 100644 --- a/libavfilter/vf_chromakey.c +++ b/libavfilter/vf_chromakey.c @@ -35,6 +35,9 @@

Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration

p, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from ffmpeg_g...done. (gdb) r -loglevel debug -f lavfi -i allrgb -vf chromakey=green:opencl=1 -f null - Starting program: /home/timothy-gu/ffmpeg/ffmpeg/ffmpeg_g

[FFmpeg-devel] [PATCH 4/4] opencl: Force the use of 1.2 APIs

Silences warnings regarding `clCreateCommandQueue` being deprecated. Only a very limited number of products support 2.0. Since the replacement API (`clCreateCommandQueueWithProperties`) is only available in 2.0, we should not update it just yet. --- libavutil/opencl.h | 1 + 1 file changed, 1

Re: [FFmpeg-devel] [PATCH] .gitignore: some font temporaries

On Tue, Oct 13, 2015 at 6:24 PM Ganesh Ajjanagadde <gajja...@mit.edu> wrote: > On Tue, Oct 13, 2015 at 9:20 PM, Timothy Gu <timothyg...@gmail.com> wrote: > > Patch LGTM. > > Go ahead and push Pushed, thanks. Timothy __

[FFmpeg-devel] [PATCH 2/4] opencl: Print compilation log

Useful when debugging. --- libavutil/opencl.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/libavutil/opencl.c b/libavutil/opencl.c index c2956fd..f720ce0 100644 --- a/libavutil/opencl.c +++ b/libavutil/opencl.c @@ -449,12 +449,14 @@ end:

[FFmpeg-devel] [PATCH 3/4] opencl: Use "opencl" as log context name

All other classes use lowercase names. --- libavutil/opencl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/opencl.c b/libavutil/opencl.c index f720ce0..62706f3 100644 --- a/libavutil/opencl.c +++ b/libavutil/opencl.c @@ -84,7 +84,7 @@ static const AVOption

Re: [FFmpeg-devel] [PATCH] .gitignore: some font temporaries

El martes, 13 de octubre de 2015, Michael Niedermayer escribió: > On Sun, Oct 11, 2015 at 04:27:49PM -0400, Ganesh Ajjanagadde wrote: > > --- > > .gitignore | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/.gitignore b/.gitignore > > index 0b26f68..b215828

Re: [FFmpeg-devel] av_ctz optimization

On Sun, Oct 11, 2015 at 9:10 AM Ganesh Ajjanagadde wrote: > Isn't that an API change and not an ABI change (it was in doc/APIchanges)? > No, since intmath.h is not public. Timothy ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] setting up a proper Github mirror

On Sun, Oct 11, 2015 at 11:44 AM Ganesh Ajjanagadde wrote: > I noticed that the Github mirror: https://github.com/FFmpeg/FFmpeg is > over 3 hours out of sync with the main repos, making it unusable as a > fetch url for development. Anyone knows why this is the case? > It is

Re: [FFmpeg-devel] [PATCH] configure: fix configure when using gcc

On Sun, Oct 11, 2015 at 8:21 AM Ganesh Ajjanagadde wrote: > Fixes Ticket4922. > > Commit 060102389e572abb2beaed3b9f5e1036aeea43f1 broke configure. > > From: Jean-Yves Avenard > You might want to use `git commit --author` instead of manually adding

Re: [FFmpeg-devel] setting up a proper Github mirror

On Sun, Oct 11, 2015 at 12:16 PM Ganesh Ajjanagadde wrote: > Alternatively (for now, more sustainable is a proper hook), could you > post here your alias to do this? > git remote set-url origin --push --add g...@github.com:FFmpeg/FFmpeg.git Timothy

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

On Sun, Oct 11, 2015 at 11:29 AM Ronald S. Bultje wrote: > It's an a non-installed header and only used in one place (flacenc). > Since ff_ctz is static inline, it's fine to use that instead. > --- > libavcodec/flacenc.c | 2 +- > libavutil/intmath.c | 5 - >

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

On Sun, Oct 11, 2015 at 6:31 PM Ganesh Ajjanagadde wrote: > Just to make this clear: suppose (hypothetically) av_ctz was public. > If my application never used av_ctz, but I (or my distro) upgrades > libav*, then I don't need to recompile/relink my code? > If we are only

Re: [FFmpeg-devel] FFmpeg 2.8.1

On Sat, Oct 10, 2015 at 7:20 AM Ganesh Ajjanagadde wrote: > On Thu, Oct 8, 2015 at 8:37 AM, Michael Niedermayer > wrote: > > Hi > > > > ill make 2.8.1 soon from release/2.8 > > if you want something backported push it to release/2.8 soon! > > (or ask me

Re: [FFmpeg-devel] [PATCH] configure: disabling --enable-libmfx and --enable-gpl combination

On Thu, Oct 8, 2015 at 9:55 AM Ivan Uskov wrote: > Hello Hendrik, > > Thursday, October 8, 2015, 7:03:36 PM, you wrote: > > HL> That doesn't seem correct to me. The mfx dispatcher library has the BSD > HL> license plastered all over it. BSD is compatible with the GPL. >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/alacdec: split off decorrelate_stereo and append_extra_bits as alacdsp

On Sun, Oct 4, 2015 at 2:21 PM Michael Niedermayer wrote: > there is a spec ? > Don't think so for the codec itself. > i only know of soe reference source code and i looked yesterday > and it usesed the full 8 bits unless i missed something >

Re: [FFmpeg-devel] [PATCH 0/7] [RFC] x86 assembly constants

On Fri, Oct 2, 2015 at 10:08 AM James Darnley wrote: > The third patch uses them in the remaining inline assembly. > That's the crux of the problem: inline asm uses these constants, but will be unable to without yasm. Either we drop compatibility for inline asm for x86

Re: [FFmpeg-devel] pngdec failing with an assertion

El domingo, 27 de septiembre de 2015, Gonzalo escribió: > > > El 27/09/15 a las 22:45, Gonzalo escribió: > >> $ ffplay /media/Linux/anims/wildlife/wildlife.%04d.png >> ffplay version N-75563-g235381e Copyright (c) 2003-2015 the FFmpeg >> developers >> built with gcc 4.8

Re: [FFmpeg-devel] [PATCH] ffplay: add support for interactive volume control

On Sat, Sep 26, 2015 at 7:47 AM, Ganesh Ajjanagadde wrote: > diff --git a/ffplay.c b/ffplay.c > index d302793..4f3322b 100644 > --- a/ffplay.c > +++ b/ffplay.c > @@ -1348,6 +1353,25 @@ static void toggle_pause(VideoState *is) > is->step = 0; > } > > +static void

Re: [FFmpeg-devel] [PATCH 4/4] lavc: deprecate aac_adtstoasc BSF; remove warnings referencing it

On Mon, Sep 21, 2015 at 6:51 PM Rodger Combs wrote: > --- > doc/bitstream_filters.texi | 11 --- > libavcodec/aac_adtstoasc_bsf.c | 74 > ++ > libavformat/flvenc.c | 6 > libavformat/movenc.c | 6

Re: [FFmpeg-devel] [PATCH 1/4] lavc/aacdec: handle case where extradata is set between init and first packet

On Mon, Sep 21, 2015 at 6:50 PM Rodger Combs wrote: > --- > libavcodec/aacdec_template.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c > index c2d7d05..a999013 100644 > ---

Re: [FFmpeg-devel] [PATCH] avformat/mpjpegdec: silence unused variable/function warnings

On Wed, Sep 16, 2015 at 2:25 PM, Ganesh Ajjanagadde wrote: > Silences a -Wunused-variable and -Wunused-function observed under GCC 5.2. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavformat/mpjpegdec.c | 16 > 1 file changed,

Re: [FFmpeg-devel] [PATCH] swscale/swscale: silence unused function warning

On Wed, Sep 16, 2015 at 2:20 PM, Ganesh Ajjanagadde wrote: > gamma_convert is only used with the old code. Thus, it is > placed under a header guard. This patch silences a -Wunused-function > observed on GCC 5.2. > > Signed-off-by: Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH] avformat/format: silence -Wdiscarded-qualifiers

On Wed, Sep 16, 2015 at 3:50 PM, Ganesh Ajjanagadde wrote: > lpd.buf is non-const and discards the const qualifier of zerobuffer. > This fixes -Wdiscarded-qualifiers observed with GCC 5.2. > > Signed-off-by: Ganesh Ajjanagadde > --- >

Re: [FFmpeg-devel] [PATCH] avformat/format: silence -Wdiscarded-qualifiers

On Wed, Sep 16, 2015 at 6:09 PM Michael Niedermayer wrote: > this is wrong, the buffer is constant > if the content of the buffer would change that would be a serious > bug. > Before this change the compiler would detect direct changes done to > the buffer > Commit reverted

Re: [FFmpeg-devel] [PATCH] configure: Print large lists in more columns if the screen size allows

On Mon, Sep 14, 2015 at 5:09 PM Ganesh Ajjanagadde wrote: > Shouldn't this function be renamed, since it no longer necessarily > prints in 3 columns? > Applied with that change. Timothy ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] configure: make assignment of variable to '=' explicit

On Sat, Sep 12, 2015 at 11:28 PM Ganesh Ajjanagadde wrote: > op== is confusing, as it may easily be mistook for an equality check, > while in reality it is doing an assigment to '='. > This patch has the additional benefit of cleaning up 2 warnings from > shellcheck.net.

[FFmpeg-devel] [PATCH] configure: Print large lists in more columns if the screen size allows

--- configure | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure b/configure index da18e70..3dfbb91 100755 --- a/configure +++ b/configure @@ -425,7 +425,10 @@ if test -t 1 && which tput >/dev/null; then error_color=$(tput setaf 1)

Re: [FFmpeg-devel] [PATCH] configure: colorize error messages

On Wed, Sep 9, 2015 at 11:15 AM Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > configure | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index 056feea..4842b52 100755 > ---

Re: [FFmpeg-devel] [PATCH] configure: colorize warnings on Windows

On Tue, Sep 8, 2015 at 12:18 PM Ganesh Ajjanagadde wrote: > quotes='""' > -if test -t 1 && which tput >/dev/null; then > -ncolors=$(tput colors) > -if test -n "$ncolors" && test $ncolors -ge 8; then > -bold_color=$(tput bold) > -warn_color=$(tput

Re: [FFmpeg-devel] [PATCH] aacenc: set default coding tools by profile

On Tue, Sep 1, 2015 at 6:46 PM Rostislav Pehlivanov wrote: > /** > + * List of currently supported profiles, anything not listed isn't > supported. > + */ > > +struct AACProfileOptions aacenc_profiles[] = { > static const? > +{FF_PROFILE_AAC_LOW, > +{ /*

Re: [FFmpeg-devel] PATCH: better message that ffplay is not going to be built

On Thu, Aug 27, 2015 at 06:36:00PM -0400, Ganesh Ajjanagadde wrote: Please add the area (e.g configure:...) to the commit message. More generally, I suggest a slight cleanup of the commit message: first line- configure: print out enabled programs skip a blank line, body- This prints out a

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add hstack vstack filter

On Tue, Aug 25, 2015 at 7:37 AM Paul B Mahol one...@gmail.com wrote: +@section hstack +Stack streams horizontally. + +All streams must be of same pixel format and of same height. Add a new line here +Note: this filter is faster then using @ref{overlay} and @ref{pad} filter +to create

Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: Add -hwaccels option that lists all supported hwaccels

On Tue, Aug 25, 2015 at 5:06 PM Ganesh Ajjanagadde gajja...@mit.edu wrote: On Tue, Aug 25, 2015 at 7:47 PM, Timothy Gu timothyg...@gmail.com wrote: --- doc/ffmpeg.texi | 4 ffmpeg_opt.c| 14 ++ 2 files changed, 18 insertions(+) diff --git a/doc/ffmpeg.texi b

[FFmpeg-devel] [PATCH] ffmpeg_opt: Add -hwaccels option that lists all supported hwaccels

--- doc/ffmpeg.texi | 4 ffmpeg_opt.c| 14 ++ 2 files changed, 18 insertions(+) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 51a4ec5..e1d8562 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -698,6 +698,10 @@ is not specified, the value of the @var{DISPLAY}

Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: Add -hwaccels option that lists all supported hwaccels

On Tue, Aug 25, 2015 at 08:19:59PM -0400, Ganesh Ajjanagadde wrote: For consistency, prefix with an opt_? This name is chosen to be consistent with other show_ functions. opt_* are exclusively used for setting some options AFAICT. Maybe you could check the return value of printf? Absolutely

Re: [FFmpeg-devel] [PATCH] version: Fix two more typos

El viernes, 21 de agosto de 2015, Lou Logan l...@lrcd.com escribió: Good, of course. No need to send a patch for trivial comment typo fixes like these; you can just push. I don't think I have Git write access to git.v.o right now, or I have not been informed that it was given to me. I've

Re: [FFmpeg-devel] Make libavfilter/vf_drawtext.c build under uclibc environments

On Sat, Aug 22, 2015 at 1:18 PM Paul B Mahol one...@gmail.com wrote: On 8/22/15, Rene Rheaume rene.rhea...@gmail.com wrote: In function func_eval_expr_int_format inside libavfilter/vf_drawtext.c, the functions feclearexcept and fetestexcept are used. They are missing on uclibc. On that

[FFmpeg-devel] [PATCH 1/2] avcodec: Remove unused includes of lavu/intmath.h

--- libavcodec/mpegvideo_enc.c | 1 - libavcodec/proresdec_lgpl.c | 1 - libavcodec/snow.c | 1 - libavcodec/snowdec.c| 1 - libavcodec/snowenc.c| 1 - 5 files changed, 5 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index

[FFmpeg-devel] [PATCH 2/2] avutil: Move prototype of av_ctz to common.h

intmath.h is not installed so it cannot be considered public. Instead, handle av_ctz the same way as av_log2. --- libavcodec/flacenc.c | 2 +- libavutil/common.h | 10 ++ libavutil/intmath.c | 1 + libavutil/intmath.h | 8 +--- 4 files changed, 13 insertions(+), 8 deletions(-)

Re: [FFmpeg-devel] [PATCH 2/2] avutil: Move prototype of av_ctz to common.h

On Sat, Aug 22, 2015 at 10:31 AM Hendrik Leppkes h.lepp...@gmail.com wrote: On Sat, Aug 22, 2015 at 7:15 PM, Timothy Gu timothyg...@gmail.com wrote: intmath.h is not installed so it cannot be considered public. Instead, handle av_ctz the same way as av_log2. --- libavcodec/flacenc.c

Re: [FFmpeg-devel] [PATCH] version: Fix two more typos

On Fri, Aug 21, 2015 at 09:51:12PM -0800, Lou Logan wrote: On Fri, Aug 21, 2015, at 09:41 PM, Timothy Gu wrote: Same as cafba99b5146cf10d60ceed4257f6e82380a020e but applied to lavf and lavu. --- libavformat/version.h | 4 ++-- libavutil/version.h | 4 ++-- 2 files changed, 4

Re: [FFmpeg-devel] [PATCH 06/10] aacdec_fixed: Make exp2tab static const

On Fri, Aug 21, 2015 at 10:05:06PM -0400, Ganesh Ajjanagadde wrote: Also relatively recent, anyway LGTM. Pushed. Timothy ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 07/10] aacsbr_fixed: Make fixed_{exp, log}_table static const

On Fri, Aug 21, 2015 at 10:03:06PM -0400, Ganesh Ajjanagadde wrote: Relatively recent code essentially from f85bc147fb87de048ccc5767e186ac59ec0284ef. Been over a month, so LGTM. Pushed. Timothy ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 10/10] ffv1: Add missing ff_ prefixes

On Fri, Aug 21, 2015 at 09:46:57PM -0400, Ganesh Ajjanagadde wrote: LGTM Pushed. Timothy ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 08/10] vp9dsp: Add missing ff_ prefixes

On Fri, Aug 21, 2015 at 10:00:25PM -0400, Ganesh Ajjanagadde wrote: LGTM Pushed. Timothy ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 02/10] aacenc: Add missing ff_ prefixes

On Sat, Aug 22, 2015 at 01:05:18AM -0300, Claudio Freire wrote: When reviewing the patches with Rostislav, I actually tested to see whether those symbols were exported, and they weren't. exported ≠ nonstatic It's a project policy to use `ff_` prefix to signify non-exported, private, non-static

Re: [FFmpeg-devel] [PATCH 04/10] aacenctab: Add missing ff_ prefixes

(swb_size_1024); +const int swb_size_128_len = FF_ARRAY_ELEMS(ff_aac_swb_size_128); +const int swb_size_1024_len = FF_ARRAY_ELEMS(ff_aac_swb_size_1024); The attached patch rectifies that. Timothy From a281ab012357a5caa3ae2493527bcc57fb0dc2f5 Mon Sep 17 00:00:00 2001 From: Timothy Gu timothyg

[FFmpeg-devel] [PATCH] version: Fix two more typos

Same as cafba99b5146cf10d60ceed4257f6e82380a020e but applied to lavf and lavu. --- libavformat/version.h | 4 ++-- libavutil/version.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/version.h b/libavformat/version.h index e2b4b95..d21cd69 100644 ---

Re: [FFmpeg-devel] [PATCH 02/10] aacenc: Add missing ff_ prefixes

On Fri, Aug 21, 2015 at 10:49:01PM -0400, Ganesh Ajjanagadde wrote: There are too many entries here for me to verify which ones are exposed, etc. I trust you identified them correctly. To the best of my knowledge, yes. To anyone reading this message, I used the following command to get a list

[FFmpeg-devel] [PATCH 02/10] aacenc: Add missing ff_ prefixes

--- libavcodec/aaccoder.c| 64 libavcodec/aacenc_is.c | 2 +- libavcodec/aacenc_is.h | 2 +- libavcodec/aacenc_pred.c | 10 libavcodec/aacenc_pred.h | 10 libavcodec/aacenc_tns.c | 4 +-- libavcodec/aacenc_tns.h | 4

[FFmpeg-devel] [PATCH 00/10] avcodec: Properly namespace all nonstatic symbols

Timothy Gu (10): aacenc_is: Make calc_is_encoding_err static aacenc: Add missing ff_ prefixes aacenc: Harmonize multiple inclusion guards aacenctab: Add missing ff_ prefixes aacenctab: Use FF_ARRAY_ELEMS aacdec_fixed: Make exp2tab static const aacsbr_fixed: Make fixed_{exp,log}_table

<    1   2   3   4   5   6   >