[FFmpeg-devel] [PATCHv4] mov: Evaluate the movie display matrix

2016-11-03 Thread Vittorio Giovara
This matrix needs to be applied after all others have (currently only display matrix from trak), but cannot be handled in movie box, since streams are not allocated yet. So store it in main context, and apply it when appropriate, that is after parsing the tkhd one. Signed-off-by: Vittorio Giovara

[FFmpeg-devel] [PATCH 2/2] hevc: Support extradata changes

2016-11-02 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- Please CC. Vittorio libavcodec/hevc.c | 18 ++ libavformat/mov.c | 4 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/libavcodec/hevc.c b/libavcodec/hevc.c index 29e0d49..b50120e

[FFmpeg-devel] [PATCH 1/2] hevc: Move hevc_decode_extradata before frame decoding

2016-11-02 Thread Vittorio Giovara
Avoids a forward-declaration in the following commit. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- Please CC. Vittorio libavcodec/hevc.c | 148 +++--- 1 file changed, 74 insertions(+), 74 deletions(-) diff --git a/liba

[FFmpeg-devel] [PATCH] lavc: Add hevc main10 profile to ffmpeg cli

2016-11-01 Thread Vittorio Giovara
--- Please CC. Vittorio libavcodec/options_table.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h index 995906b..4323ae9 100644 --- a/libavcodec/options_table.h +++ b/libavcodec/options_table.h @@ -394,6 +394,7 @@ static const AVOption

Re: [FFmpeg-devel] [PATCH 3/3] vf_colorspace: Add support for smpte 431/432 (dci/display p3) primaries

2016-10-31 Thread Vittorio Giovara
On Mon, Oct 31, 2016 at 2:53 PM, Ronald S. Bultje <rsbul...@gmail.com> wrote: > Hi, > > On Mon, Oct 31, 2016 at 11:13 AM, Vittorio Giovara > <vittorio.giov...@gmail.com> wrote: >> >> On Mon, Oct 31, 2016 at 7:43 AM, Ronald S. Bultje <rsbul...@gmail.com> &

[FFmpeg-devel] [PATCH] vf_colorspace: Add support for film primaries

2016-10-31 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- This is the last easy picking, the remaining trc/prm require more convoluted changes to the filter that will need more discussion. Please CC. Vittorio libavfilter/vf_colorspace.c | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [FFmpeg-devel] [PATCH 3/3] vf_colorspace: Add support for smpte 431/432 (dci/display p3) primaries

2016-10-31 Thread Vittorio Giovara
On Mon, Oct 31, 2016 at 7:43 AM, Ronald S. Bultje wrote: > Hi, > > On Mon, Oct 31, 2016 at 5:50 AM, Kevin Wheatley > wrote: >> >> On Sun, Oct 30, 2016 at 1:18 PM, Ronald S. Bultje >> wrote: >> > Hmm... So, the wikipedia page

[FFmpeg-devel] [PATCH 2/3] vf_colorspace: Add support for ycgco color space

2016-10-30 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- This is a little hackish, not sure how to represent the matrix otherwise. Please CC. Vittorio libavfilter/vf_colorspace.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavfilter/vf_colorspa

[FFmpeg-devel] [PATCH 3/3] vf_colorspace: Add support for smpte 431/432 (dci/display p3) primaries

2016-10-30 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- I couldn't find any reference to the name of the whitepoint used for 431, so I came up with DCI, since it looks like it is only used there. Please CC. Vittorio libavfilter/vf_colorspace.c | 6 ++ 1 file changed, 6 inse

[FFmpeg-devel] [PATCH 1/3] vf_colorspace: Add support for iec61966-2.4 (xvYCC) transfer

2016-10-30 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- As described in http://www.color.org/chardata/rgb/xvycc.xalter Please CC. Vittorio libavfilter/vf_colorspace.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c

[FFmpeg-devel] [PATCH] vf_colorspace: Add support for iec61966-2.1 (sRGB) transfer

2016-10-18 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- Special thanks to Andrew Roland for helping me figure out these numbers. Please keep me in CC. Vittorio libavfilter/vf_colorspace.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter/vf_colorspace.c b/libav

Re: [FFmpeg-devel] [PATCHv2] vf_colorspace: Interpret unspecified color range as limited range

2016-10-17 Thread Vittorio Giovara
On Mon, Sep 19, 2016 at 8:36 AM, Ronald S. Bultje <rsbul...@gmail.com> wrote: > Hi, > > On Fri, Sep 16, 2016 at 9:27 AM, Clément Bœsch <u...@pkh.me> wrote: >> >> On Fri, Sep 16, 2016 at 03:20:49PM +0200, Vittorio Giovara wrote: >> > This is the assumption

Re: [FFmpeg-devel] [PATCHv3] mov: Evaluate the movie display matrix

2016-10-17 Thread Vittorio Giovara
On Thu, Oct 13, 2016 at 6:50 PM, Vittorio Giovara <vittorio.giov...@gmail.com> wrote: > This matrix needs to be applied after all others have (currently only > display matrix from trak), but cannot be handled in movie box, since > streams are not allocated yet. So store it

[FFmpeg-devel] [PATCHv3] mov: Evaluate the movie display matrix

2016-10-13 Thread Vittorio Giovara
This matrix needs to be applied after all others have (currently only display matrix from trak), but cannot be handled in movie box, since streams are not allocated yet. So store it in main context, and apply it when appropriate, that is after parsing the tkhd one. Signed-off-by: Vittorio Giovara

Re: [FFmpeg-devel] [PATCH] mov: Evaluate the movie display matrix

2016-10-07 Thread Vittorio Giovara
On Fri, Oct 7, 2016 at 8:38 PM, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Fri, Oct 07, 2016 at 03:31:46PM -0400, Vittorio Giovara wrote: >> This matrix needs to be applied after all others have (currently only >> display matrix from trak), but cannot be handle

[FFmpeg-devel] [PATCH] mov: Evaluate the movie display matrix

2016-10-07 Thread Vittorio Giovara
is identity and when it is not. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- Updated according review. Vittorio libavformat/isom.h | 2 ++ libavformat/mov.c | 63 +++-- tests/fate/mov.mak

Re: [FFmpeg-devel] [PATCH] mov: Evaluate the movie display matrix

2016-10-05 Thread Vittorio Giovara
On Wed, Oct 5, 2016 at 10:07 PM, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Wed, Oct 05, 2016 at 05:25:33PM -0400, Vittorio Giovara wrote: >> This matrix needs to be applied after all others have (currently only >> display matrix from trak), but cannot be handle

[FFmpeg-devel] [PATCH] mov: Evaluate the movie display matrix

2016-10-05 Thread Vittorio Giovara
is identity and when it is not. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- Please keep my in CC. Vittorio libavformat/isom.h | 2 ++ libavformat/mov.c | 63 +- 2 files changed, 55 insertions(+), 10 deletions(-) diff

[FFmpeg-devel] [PATCHv2] vf_colorspace: Interpret unspecified color range as limited range

2016-09-16 Thread Vittorio Giovara
This is the assumption that is made in pixel format conversion do throughout the code (in particular swscale), and BT-specifications mandate. Add a warning to inform the user that an automatic selection is being made. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libav

Re: [FFmpeg-devel] [PATCH 1/2] vf_colorspace: Interpret unspecified color range as limited range

2016-09-15 Thread Vittorio Giovara
> On Sep 15, 2016, at 2:45 PM, Ronald S. Bultje <rsbul...@gmail.com> wrote: > > Hi Vittorio, > >> On Thu, Sep 15, 2016 at 8:33 AM, Vittorio Giovara >> <vittorio.giov...@gmail.com> wrote: >> I agree we should always be very very careful about automati

Re: [FFmpeg-devel] [PATCH 1/2] vf_colorspace: Interpret unspecified color range as limited range

2016-09-15 Thread Vittorio Giovara
> Hi, On Wed, Sep 14, 2016 at 5:09 PM, Vittorio Giovara < vittorio.giovara at > gmail.com> wrote: > This is the assumption that is made in pixel format > conversion do > throughout the code (in particular swscale and > vf_colormatrix). > > Signed-off-b

[FFmpeg-devel] [PATCH 1/2] vf_colorspace: Interpret unspecified color range as limited range

2016-09-14 Thread Vittorio Giovara
This is the assumption that is made in pixel format conversion do throughout the code (in particular swscale and vf_colormatrix). Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavfilter/vf_colorspace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libav

[FFmpeg-devel] [PATCH 2/2] vf_colorspace: Add modern names for color range option

2016-09-14 Thread Vittorio Giovara
Allows to use values returned from API and from ffprobe directly. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavfilter/vf_colorspace.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c index 7e87cd8..b

[FFmpeg-devel] [PATCH] vf_colorspace: Add BT-names for gamma22/28 transfer option

2016-09-12 Thread Vittorio Giovara
Allows to use values returned from API and from ffprobe directly. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavfilter/vf_colorspace.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c index 45fd917..b

[FFmpeg-devel] [PATCHv3] vf_colorspace: Allow overriding input color properties

2016-09-03 Thread Vittorio Giovara
at once. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- Options moved at the bottom of the list as requested. Vittorio doc/filters.texi| 20 libavfilter/vf_colorspace.c | 40 +++- 2 files changed, 55 inse

Re: [FFmpeg-devel] [PATCH 3/3] vf_colorspace: Allow overriding input color properties

2016-08-30 Thread Vittorio Giovara
On Tue, Aug 30, 2016 at 10:54 AM, Paul B Mahol <one...@gmail.com> wrote: > > > On Tuesday, August 30, 2016, Vittorio Giovara <vittorio.giov...@gmail.com> > wrote: >> >> On Tue, Aug 30, 2016 at 4:13 AM, Paul B Mahol <one...@gmail.com> wrote: >> >

Re: [FFmpeg-devel] [PATCHv2] vf_colorspace: Allow overriding input color properties

2016-08-30 Thread Vittorio Giovara
On Tue, Aug 30, 2016 at 4:13 AM, Paul B Mahol <one...@gmail.com> wrote: > > > On Mon, Aug 29, 2016 at 5:53 PM, Ronald S. Bultje <rsbul...@gmail.com> > wrote: >> >> Hi, >> >> On Mon, Aug 29, 2016 at 11:23 AM, Vittorio Giovara < >> vittorio

[FFmpeg-devel] [PATCHv2] vf_colorspace: Allow overriding input color properties

2016-08-29 Thread Vittorio Giovara
at once. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- * added iall option * updated filter documentation Please CC. Vittorio doc/filters.texi| 20 libavfilter/vf_colorspace.c | 39 ++- 2 files chang

Re: [FFmpeg-devel] [PATCH 3/3] vf_colorspace: Allow overriding input color properties

2016-08-26 Thread Vittorio Giovara
On Fri, Aug 26, 2016 at 5:16 PM, Ronald S. Bultje <rsbul...@gmail.com> wrote: > Hi, > > On Fri, Aug 26, 2016 at 2:40 PM, Vittorio Giovara > <vittorio.giov...@gmail.com> wrote: >> >> On Fri, Aug 26, 2016 at 12:59 AM, Ronald S. Bultje <rsbul...@gmail.com> &g

Re: [FFmpeg-devel] [PATCH 3/3] vf_colorspace: Allow overriding input color properties

2016-08-26 Thread Vittorio Giovara
On Fri, Aug 26, 2016 at 12:59 AM, Ronald S. Bultje <rsbul...@gmail.com> wrote: > Hi Vittorio, > > On Thu, Aug 25, 2016 at 7:14 PM, Vittorio Giovara > <vittorio.giov...@gmail.com> wrote: >> >> The filter needs input frames with color properties filled out by >

Re: [FFmpeg-devel] [PATCH 3/3] vf_colorspace: Allow overriding input color properties

2016-08-26 Thread Vittorio Giovara
On Fri, Aug 26, 2016 at 3:52 AM, Paul B Mahol <one...@gmail.com> wrote: > On 8/26/16, Vittorio Giovara <vittorio.giov...@gmail.com> wrote: >> The filter needs input frames with color properties filled out by >> the decoder. Since this is not always possible, add input

[FFmpeg-devel] [PATCH 1/3] vf_colorspace: Check av_frame_copy_props() return value

2016-08-25 Thread Vittorio Giovara
This function can potentially allocate memory. --- Please keep me in CC. Vittorio libavfilter/vf_colorspace.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c index 3d39f13..bf51c83 100644 ---

[FFmpeg-devel] [PATCH 2/3] vf_colorspace: Add support for full range yuv

2016-08-25 Thread Vittorio Giovara
adding support to YUVJ* formats will allow skipping a conversion step, while providing completely identical results. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- Please keep me in CC. Vittorio libavfilter/vf_colorspace.c | 1 + 1 file changed, 1 insertion(+) diff

[FFmpeg-devel] [PATCH 3/3] vf_colorspace: Allow overriding input color properties

2016-08-25 Thread Vittorio Giovara
The filter needs input frames with color properties filled out by the decoder. Since this is not always possible, add input options to the filter so that user may override color space, color primaries, transfer characteristics, and color range. Signed-off-by: Vittorio Giovara <vittorio.g

Re: [FFmpeg-devel] [libav-devel] [PATCH] avcodec/cfhd: Fixes cfhd_odd.mov which has a resolution of 496x241

2016-03-05 Thread Vittorio Giovara
owpass_height * lowpass_width], > -- Confirmed to work with the sample. Here is an addendum to avoid displaying garbage (untested with other samples) commit 658fdd157f12633006533bc67ffb3b0d44a198df Author: Vittorio Giovara <vittorio.giov...@gmail.com> Date: Sat Mar 5 13:32:54 2016 -0

Re: [FFmpeg-devel] [libav-devel] [PATCHv3] avcodec: Cineform HD Decoder

2016-01-25 Thread Vittorio Giovara
On Sun, Jan 24, 2016 at 7:34 PM, Kieran Kunhya wrote: > Decodes YUV 4:2:2 10-bit and RGB 12-bit files. > Older files with more subbands, skips, Bayer, alpha not supported. > Alpha requires addition of GBRAP12 pixel format. Actually you could set AV_PIX_FMT_GBRAP16 and tweak

Re: [FFmpeg-devel] [libav-devel] [PATCH 1/2] avcodec: Add Cineform HD Decoder

2016-01-11 Thread Vittorio Giovara
On Sun, Jan 10, 2016 at 1:28 AM, Kieran Kunhya wrote: > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/cfhd.c | 565 > > libavcodec/cfhd.h |

Re: [FFmpeg-devel] [libav-devel] [PATCH] Cineform HD Decoder:

2016-01-04 Thread Vittorio Giovara
On Mon, Jan 4, 2016 at 1:04 AM, Kieran Kunhya wrote: > Decodes YUV422P10 samples in AVI and MOV (Gopro Studio) > Older files with more subbands, skips, Bayer not supported > --- > +static av_cold int cfhd_init_decoder(AVCodecContext *avctx) > +{ > +CFHDContext *s =

Re: [FFmpeg-devel] [PATCH] Adding frame side data about green metadata

2015-12-23 Thread Vittorio Giovara
On Wed, Dec 23, 2015 at 12:28 PM, Nicolas Derouineau wrote: > Hello, > Please find here enclosed a patch adding frame side data information about > green metadata. The logic is ok, but the introduction of av_greenmetadata_set is a no-go for me. This function is

Re: [FFmpeg-devel] GreenMetadata complexity metric access through high level API

2015-11-30 Thread Vittorio Giovara
On Mon, Nov 30, 2015 at 8:21 AM, Nicolas Derouineau wrote: > Hello > >>you should look at avframesidedata > > Actually the issue is that the green metadatadata are concerning the upcoming > frame (They are used to predict the upcoming complexity). > > The

Re: [FFmpeg-devel] [libav-devel] [PATCH] hqx: correct type and size check of info_offset

2015-11-16 Thread Vittorio Giovara
On Sun, Nov 15, 2015 at 10:50 AM, Andreas Cadhalpun wrote: > It is used as size argument of ff_canopus_parse_info_tag, which uses it > as size argument to bytestream2_init, which only supports sizes up to > INT_MAX. > Changing it's type to unsigned simplifies the

Re: [FFmpeg-devel] [libav-devel] [PATCH 3/4] dds: make sure pallete frame buffer exists before use

2015-11-13 Thread Vittorio Giovara
On Fri, Nov 13, 2015 at 10:01 PM, Andreas Cadhalpun <andreas.cadhal...@gmail.com> wrote: > On 13.11.2015 02:08, Vittorio Giovara wrote: >> oh I see, that can happen for a special crafted file, DDPF_FOURCC has >> been introduced recently while DDPF_PALETTE has been removed

Re: [FFmpeg-devel] [libav-devel] [PATCH 3/4] dds: make sure pallete frame buffer exists before use

2015-11-11 Thread Vittorio Giovara
On Wed, Nov 11, 2015 at 1:16 AM, Andreas Cadhalpun wrote: > Otherwise it causes a NULL pointer dereference of frame->data[1]. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/dds.c | 5 + > 1 file changed, 5

Re: [FFmpeg-devel] [libav-devel] [PATCH 2/4] dds: validate compressed source buffer size

2015-11-11 Thread Vittorio Giovara
On Wed, Nov 11, 2015 at 1:15 AM, Andreas Cadhalpun wrote: > A too small buffer will cause segfaults somewhere below > decompress_texture_thread. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/dds.c | 9 + > 1

Re: [FFmpeg-devel] [libav-devel] [PATCH 1/4] dds: validate source buffer size before copying

2015-11-11 Thread Vittorio Giovara
On Wed, Nov 11, 2015 at 1:14 AM, Andreas Cadhalpun wrote: > If it is too small av_image_copy_plane segfaults. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/dds.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff

Re: [FFmpeg-devel] [libav-devel] [PATCH 4/4] dds: add missing newline to log messages

2015-11-11 Thread Vittorio Giovara
On Wed, Nov 11, 2015 at 1:16 AM, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/dds.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/dds.c

Re: [FFmpeg-devel] [libav-devel] [PATCH 3/4] dds: make sure pallete frame buffer exists before use

2015-11-11 Thread Vittorio Giovara
On Wed, Nov 11, 2015 at 8:29 PM, Andreas Cadhalpun <andreas.cadhal...@googlemail.com> wrote: > On 11.11.2015 12:28, Vittorio Giovara wrote: >> On Wed, Nov 11, 2015 at 1:16 AM, Andreas Cadhalpun >> <andreas.cadhal...@googlemail.com> wrote: >>> Otherwise it causes

Re: [FFmpeg-devel] [libav-devel] [PATCH 20/20] Bump major versions of all libraries

2015-08-26 Thread Vittorio Giovara
On Wed, Aug 26, 2015 at 12:47 AM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: On 25.08.2015 11:03, Vittorio Giovara wrote: There is, consensus does not need to be unanimous, and so far only you have been expressing concerns (multiple times). That's not true. wm4, James

Re: [FFmpeg-devel] [libav-devel] [PATCH 20/20] Bump major versions of all libraries

2015-08-25 Thread Vittorio Giovara
On Mon, Aug 24, 2015 at 11:43 PM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: On 24.08.2015 13:44, Vittorio Giovara wrote: On Tue, Jul 28, 2015 at 6:54 PM, Luca Barbato lu_z...@gentoo.org wrote: On 28/07/15 15:41, Vittorio Giovara wrote: On Tue, Jul 28, 2015 at 2:40 PM, Luca

Re: [FFmpeg-devel] [libav-devel] [PATCH 4/6] avcodec: delay removal of avcodec_*_frame

2015-08-24 Thread Vittorio Giovara
On Sat, Aug 8, 2015 at 1:37 PM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: They are still widely used and have been deprecated for less than two years. are we talking about ad0c9f2? if so, it's dated 2012-10-08, so almost three years. -- Vittorio

Re: [FFmpeg-devel] GreenMetadata complexity metric access through high level API

2015-07-01 Thread Vittorio Giovara
On Wed, Jul 1, 2015 at 11:08 AM, Nicolas Derouineau nicolas.derouin...@vitec.com wrote: Hello, H264 GreenMetadata parsing is now supported in ffmpeg, but the informations are stored in the h264context, which is not available at a higher level. Is it possible to add a new field named

Re: [FFmpeg-devel] [PATCH] libavformat: Add H264 API test

2015-06-22 Thread Vittorio Giovara
On Mon, Jun 22, 2015 at 10:50 AM, Ludmila Glinskih lglins...@gmail.com wrote: +static int video_decode_example(const char *input_filename) +{ +AVCodec *codec = NULL; +AVCodecContext *origin_ctx = NULL, *ctx= NULL; +AVFrame *fr = NULL; +uint8_t *byte_buffer = NULL; +

Re: [FFmpeg-devel] [PATCH] libavformat: Add H264 API test

2015-06-22 Thread Vittorio Giovara
On Mon, Jun 22, 2015 at 2:50 PM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 6/22/2015 2:46 PM, Vittorio Giovara wrote: afaik in POSIX any non zero value is to be considered an error, also because value ranges on an unsigned byte. -1 ends up greater than 128, which is reserved

Re: [FFmpeg-devel] [PATCH] libavformat: Add H264 API test

2015-06-22 Thread Vittorio Giovara
On Mon, Jun 22, 2015 at 1:40 PM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 6/22/2015 1:32 PM, Vittorio Giovara wrote: video_decode_example can return -1 on error, and this is lost, so you'd better do return video_decode_example(argv[1]); to return the value to the caller. Also

Re: [FFmpeg-devel] [libav-devel] [PATCH] h264: check frame properties for consistency before copying

2015-06-15 Thread Vittorio Giovara
On Sun, Jun 14, 2015 at 11:40 AM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: Also use the frame pixel format instead of the one from the codec context, which is more robust. Does this fix anything in particular or is just as precaution? Signed-off-by: Andreas Cadhalpun

Re: [FFmpeg-devel] [libav-devel] [PATCH] h264: update avctx width/height when flushing

2015-06-12 Thread Vittorio Giovara
On Fri, Jun 12, 2015 at 9:01 PM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: On 12.06.2015 21:51, Hendrik Leppkes wrote: On Fri, Jun 12, 2015 at 9:23 PM, Andreas Cadhalpun I agree that it is not really elegant, but removing the assumption that the avctx width/height/pix_fmt are

[FFmpeg-devel] shared api for exposing a texture

2015-05-15 Thread Vittorio Giovara
Hi, following the positive trend as of late, here is a shared discussion on a proposed API. There are a couple of formats that are based on texture compression, usually called DXTn or BCn, and described here: http://en.wikipedia.org/wiki/S3_Texture_Compression. Currently in libavcodec only txd

Re: [FFmpeg-devel] [libav-devel] [PATCH] dss_sp: use lowercase codec name without whitespace

2015-04-22 Thread Vittorio Giovara
On Wed, Apr 22, 2015 at 1:42 PM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/dss_sp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dss_sp.c b/libavcodec/dss_sp.c

Re: [FFmpeg-devel] [libav-devel] [PATCH] aacsbr: break infinite loop in sbr_hf_calc_npatches

2015-04-22 Thread Vittorio Giovara
On Wed, Apr 22, 2015 at 5:31 PM, Claudio Freire klaussfre...@gmail.com wrote: On Wed, Apr 22, 2015 at 12:54 PM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: On 22.04.2015 17:35, Claudio Freire wrote: On Wed, Apr 22, 2015 at 10:23 AM, Andreas Cadhalpun

Re: [FFmpeg-devel] [libav-devel] [RFC] Exporting the alpha mode from decoders

2015-02-06 Thread Vittorio Giovara
On Fri, Feb 6, 2015 at 11:32 AM, wm4 nfx...@googlemail.com wrote: This is a proposal for an API extension. Currently, some pixel formats support alpha, but whether the alpha component contains something useful or just garbage is not part of the pixel format definition. This applies at least

Re: [FFmpeg-devel] [PATCH] avformat: add dump_metadata_lines

2014-12-10 Thread Vittorio Giovara
On Wed, Dec 10, 2014 at 1:23 PM, wm4 nfx...@googlemail.com wrote: On Wed, 10 Dec 2014 03:38:03 +0100 Lukasz Marek lukasz.m.lu...@gmail.com wrote: W dniu środa, 10 grudnia 2014 Vittorio Giovara vittorio.giov...@gmail.com napisał(a): On Tue, Dec 9, 2014 at 10:17 PM, wm4 nfx...@googlemail.com

Re: [FFmpeg-devel] [PATCH] avformat/mov: Disable XMP metadata by default

2014-12-10 Thread Vittorio Giovara
On Tue, Dec 9, 2014 at 10:15 PM, wm4 nfx...@googlemail.com wrote: On Tue, 9 Dec 2014 21:33:41 +0100 Reimar Döffinger reimar.doeffin...@gmx.de wrote: On Tue, Dec 09, 2014 at 12:59:24PM +, Vittorio Giovara wrote: On Tue, Dec 9, 2014 at 8:04 AM, wm4 nfx...@googlemail.com wrote: On Tue

Re: [FFmpeg-devel] [PATCH] avformat/mov: Disable XMP metadata by default

2014-12-09 Thread Vittorio Giovara
On Tue, Dec 9, 2014 at 8:04 AM, wm4 nfx...@googlemail.com wrote: On Tue, 9 Dec 2014 02:57:01 +0100 Michael Niedermayer michae...@gmx.at wrote: It seems very wrong to export this info optionally just because ffmpeg.c is too stupid to handle it correctly. Not exporting saves a little bit of

Re: [FFmpeg-devel] [PATCH] avformat: add dump_metadata_lines

2014-12-09 Thread Vittorio Giovara
On Tue, Dec 9, 2014 at 10:17 PM, wm4 nfx...@googlemail.com wrote: On Tue, 9 Dec 2014 14:10:22 +0100 Michael Niedermayer michae...@gmx.at wrote: TODO: bump version, update APIChanges Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavformat/avformat.h |8

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tinterlace: Favor using standard timebases for the output

2014-12-02 Thread Vittorio Giovara
On Mon, Dec 1, 2014 at 9:55 PM, Michael Niedermayer michae...@gmx.at wrote: I dont think the patch will apply cleanly there, also If correct timestamps are the main reason for vf_interlace, then why was tinterlace not fixed instead of taking a subset of its features and creating a new filter

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tinterlace: Favor using standard timebases for the output

2014-12-02 Thread Vittorio Giovara
On Tue, Dec 2, 2014 at 4:02 PM, Michael Niedermayer michae...@gmx.at wrote: If theres a problem in tinterlace as you keep hinting at, could you please explain what this problem is or provide a testcase that shows the problem? The problem is that tinterlace does not really interlace, not a

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tinterlace: Favor using standard timebases for the output

2014-12-02 Thread Vittorio Giovara
On Tue, Dec 2, 2014 at 5:31 PM, Michael Niedermayer michae...@gmx.at wrote: On Mon, Dec 01, 2014 at 11:01:05PM +0100, Michael Niedermayer wrote: Reported-by: Vittorio Giovara vittorio.giov...@gmail.com Inspired by discussion with Kieran Kunhya kier...@obe.tv Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tinterlace: Favor using standard timebases for the output

2014-12-01 Thread Vittorio Giovara
On Mon, Dec 1, 2014 at 8:04 PM, Michael Niedermayer michae...@gmx.at wrote: Inspired by discussion with kierank Signed-off-by: Michael Niedermayer michae...@gmx.at Missing a 'Reported by' tag I believe. --- libavfilter/tinterlace.h|1 + libavfilter/vf_tinterlace.c | 24

Re: [FFmpeg-devel] [PATCH] avfilter/vf_interlace: more accurate pts calculation

2014-11-30 Thread Vittorio Giovara
On 12/11/2014 23:38, Aleksey Vasenev wrote: Signed-off-by: Aleksey Vasenev margtu-f...@ya.ru --- libavfilter/vf_interlace.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavfilter/vf_interlace.c b/libavfilter/vf_interlace.c index e07963f..42e2c9a 100644 ---

Re: [FFmpeg-devel] [PATCH 0/6] Toward a SPS filter for H.264

2014-11-30 Thread Vittorio Giovara
On 30/11/2014 01:45, Christophe Gisquet wrote: Most of the code is actually not mine but originated from Direct264: http://forum.doom9.org/showthread.php?t=152419 https://svn.code.sf.net/p/direct264/code/Patches/ Therefore I've tried to split as best as possible the code I have added. There are

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tinterlace: fix frame rate

2014-11-30 Thread Vittorio Giovara
On 12/11/2014 23:39, Aleksey Vasenev wrote: Signed-off-by: Aleksey Vasenev margtu-f...@ya.ru --- libavfilter/vf_tinterlace.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/vf_tinterlace.c b/libavfilter/vf_tinterlace.c index 6bc55b5..7397beb 100644 ---

Re: [FFmpeg-devel] [PATCH] avfilter/vf_interlace: more accurate pts calculation

2014-11-30 Thread Vittorio Giovara
On Sun, Nov 30, 2014 at 1:39 PM, Aleksey Vasenev margtu-f...@ya.ru wrote: We keep only half source frames. Source: time_base 1/10 and ptss 0 1 2 3 4 5 6 7 8 9 Before change: time_base 1/5 and ptss 0 1 2 3 4 After change: time_base 1/10 and ptss 0 2 4 6 8 Yes, that's probably wrong, interlaced

Re: [FFmpeg-devel] [libav-devel] [PATCHv3] Deprecate AFD field and add AFD as side-data

2014-08-04 Thread Vittorio Giovara
On Sun, Aug 3, 2014 at 7:24 PM, Kieran Kunhya kier...@obe.tv wrote: --- doc/APIchanges|4 libavcodec/avcodec.h |5 - libavcodec/mpeg12dec.c| 20 +++- libavcodec/version.h |5 - libavfilter/vf_showinfo.c |3 +++

<    1   2   3   4   5   6