Re: [FFmpeg-devel] [PATCH 2/2] img2dec: Add mime_type to image formats

2016-02-29 Thread Carl Eugen Hoyos
Derek Buitenhuis gmail.com> writes: > On 2/26/2016 3:05 PM, Carl Eugen Hoyos wrote: > > Or in other words: Except for jpeg, there is no > > probe function that returns 0 although the decoder > > can decode the image. > > I'll take your word for it on this part. Please don't: Instead

Re: [FFmpeg-devel] [PATCH 2/2] img2dec: Add mime_type to image formats

2016-02-26 Thread Derek Buitenhuis
On 2/26/2016 3:05 PM, Carl Eugen Hoyos wrote: > Or in other words: Except for jpeg, there is no > probe function that returns 0 although the decoder > can decode the image. I'll take your word for it on this part. > So please provide your failing jpeg cases to > improve the probing. > I will

Re: [FFmpeg-devel] [PATCH 2/2] img2dec: Add mime_type to image formats

2016-02-26 Thread Carl Eugen Hoyos
Derek Buitenhuis gmail.com> writes: > I'm saying scoring should be as such: > > 1) Probing the file file itself: Highest score. > 2) Mime-type: Medium score. There is no format except jpeg where this ever can fix an issue. Or in other words: Except for jpeg, there is no probe function that

Re: [FFmpeg-devel] [PATCH 2/2] img2dec: Add mime_type to image formats

2016-02-26 Thread Derek Buitenhuis
On 2/26/2016 2:44 PM, Carl Eugen Hoyos wrote: > Derek Buitenhuis gmail.com> writes: > >> On 2/25/2016 4:30 PM, Carl Eugen Hoyos wrote: > You misunderstand: > Most "imageauto" demuxers return a score of 51. In all cases > when 51 is returned, the detection is nearly certain. Your > patch

Re: [FFmpeg-devel] [PATCH 2/2] img2dec: Add mime_type to image formats

2016-02-26 Thread Carl Eugen Hoyos
Derek Buitenhuis gmail.com> writes: > On 2/25/2016 4:30 PM, Carl Eugen Hoyos wrote: > >> In terms of how the score for a MIME type match compares with > >> those of the individual content matching probe functions, I'd > >> say it makes sense. The stronger probing functions have a > >> score

Re: [FFmpeg-devel] [PATCH 2/2] img2dec: Add mime_type to image formats

2016-02-25 Thread Carl Eugen Hoyos
Clément Bœsch pkh.me> writes: > http://lucy.pkh.me/samples/img.jpg?foo=bar Patch sent. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] img2dec: Add mime_type to image formats

2016-02-25 Thread Clément Bœsch
On Thu, Feb 25, 2016 at 10:37:40PM +0100, Clément Bœsch wrote: > On Thu, Feb 25, 2016 at 10:35:39PM +0100, Clément Bœsch wrote: > > On Thu, Feb 25, 2016 at 04:30:13PM +, Carl Eugen Hoyos wrote: > > > Justin Ruggles writes: > > > > > > > In terms of how the score for a MIME type match compares

Re: [FFmpeg-devel] [PATCH 2/2] img2dec: Add mime_type to image formats

2016-02-25 Thread Clément Bœsch
On Thu, Feb 25, 2016 at 10:35:39PM +0100, Clément Bœsch wrote: > On Thu, Feb 25, 2016 at 04:30:13PM +, Carl Eugen Hoyos wrote: > > Justin Ruggles writes: > > > > > In terms of how the score for a MIME type match compares with > > > those of the individual content matching probe functions,

Re: [FFmpeg-devel] [PATCH 2/2] img2dec: Add mime_type to image formats

2016-02-25 Thread Clément Bœsch
On Thu, Feb 25, 2016 at 04:30:13PM +, Carl Eugen Hoyos wrote: > Justin Ruggles writes: > > > In terms of how the score for a MIME type match compares with > > those of the individual content matching probe functions, I'd > > say it makes sense. The stronger probing functions have a > >

Re: [FFmpeg-devel] [PATCH 2/2] img2dec: Add mime_type to image formats

2016-02-25 Thread Derek Buitenhuis
On 2/25/2016 4:30 PM, Carl Eugen Hoyos wrote: > If this cannot be fixed differently, we should either increase > the score for the existing 32bit probe functions or reduce the > score for mime types before this gets applied. Several probe > functions (outside of img2dec.c) return MAX for 32

Re: [FFmpeg-devel] [PATCH 2/2] img2dec: Add mime_type to image formats

2016-02-25 Thread Derek Buitenhuis
On 2/25/2016 4:30 PM, Carl Eugen Hoyos wrote: Replies are mine. >> In terms of how the score for a MIME type match compares with >> those of the individual content matching probe functions, I'd >> say it makes sense. The stronger probing functions have a >> score which reflects their

Re: [FFmpeg-devel] [PATCH 2/2] img2dec: Add mime_type to image formats

2016-02-25 Thread Carl Eugen Hoyos
Justin Ruggles writes: > In terms of how the score for a MIME type match compares with > those of the individual content matching probe functions, I'd > say it makes sense. The stronger probing functions have a > score which reflects their reliability. But even _EXTENSION + 1 is correct in

Re: [FFmpeg-devel] [PATCH 2/2] img2dec: Add mime_type to image formats

2016-02-25 Thread Derek Buitenhuis
On 2/24/2016 3:19 PM, Carl Eugen Hoyos wrote: > (Do you have an example where the probing fails?) > > The idea of these additional demuxers is that they probe > the content instead of relying on the file suffix. > File suffix provides a score of _EXTENSION (50), so if probing > is possible and

Re: [FFmpeg-devel] [PATCH 2/2] img2dec: Add mime_type to image formats

2016-02-24 Thread Carl Eugen Hoyos
Derek Buitenhuis gmail.com> writes: > Improves probing, especially over http when there is a > Content-Type header (Do you have an example where the probing fails?) The idea of these additional demuxers is that they probe the content instead of relying on the file suffix. File suffix

[FFmpeg-devel] [PATCH 2/2] img2dec: Add mime_type to image formats

2016-02-24 Thread Derek Buitenhuis
From: Justin Ruggles Improves probing, especially over http when there is a Content-Type header Signed-off-by: Derek Buitenhuis --- libavformat/img2dec.c | 31 --- 1 file changed, 16 insertions(+), 15