Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: assert uninitialized pict_type

2018-12-03 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of James Almer > Sent: Friday, November 30, 2018 23:53 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: assert > uninitialized pict_ty

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: assert uninitialized pict_type

2018-11-30 Thread Nicolas George
James Almer (2018-11-30): > probably Clang. I could have guessed. Clang: "bogus warnings, gotta catch them all". The solution is not to make the code less convenient but to fix the compiler. Or ignore it. Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: assert uninitialized pict_type

2018-11-30 Thread James Almer
On 11/30/2018 12:54 PM, Nicolas George wrote: > James Almer (2018-11-30): >> And using string literals in an assert may generate warnings. > > [citation needed] > > Anyway, these warnings would be broken, the code is valid. https://code.videolan.org/videolan/dav1d/issues/196

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: assert uninitialized pict_type

2018-11-30 Thread Nicolas George
James Almer (2018-11-30): > And using string literals in an assert may generate warnings. [citation needed] Anyway, these warnings would be broken, the code is valid. Regards, -- Nicolas George signature.asc Description: Digital signature ___

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: assert uninitialized pict_type

2018-11-30 Thread James Almer
On 11/30/2018 12:42 PM, Carl Eugen Hoyos wrote: > 2018-11-30 10:54 GMT+01:00, Linjie Fu : >> ffmpeg | branch: master | Linjie Fu | Wed Nov 28 >> 10:41:55 2018 +0800| [67cdfcf694f840d215be940f82545c45c9be193a] | committer: >> Zhong Li >> >> lavc/qsvenc: assert uninitialized pict_type >> >> Assert

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: assert uninitialized pict_type

2018-11-30 Thread Carl Eugen Hoyos
2018-11-30 10:54 GMT+01:00, Linjie Fu : > ffmpeg | branch: master | Linjie Fu | Wed Nov 28 > 10:41:55 2018 +0800| [67cdfcf694f840d215be940f82545c45c9be193a] | committer: > Zhong Li > > lavc/qsvenc: assert uninitialized pict_type > > Assert in function ff_qsv_encode to avoid using uninitialized