Re: [FFmpeg-devel] [GSOC][PATCH 2/4] FFV1 p frames

2016-08-20 Thread Michael Niedermayer
On Sat, Aug 20, 2016 at 10:45:59PM +0200, Moritz Barsnick wrote: > On Sat, Aug 20, 2016 at 13:10:56 +0200, Michael Niedermayer wrote: > > On Thu, Aug 18, 2016 at 08:50:08PM +0200, Moritz Barsnick wrote: > > > This code is based on libavcodec/snowdec.c:static int decode_q_branch > > Fixing

Re: [FFmpeg-devel] [GSOC][PATCH 2/4] FFV1 p frames

2016-08-20 Thread Moritz Barsnick
On Sat, Aug 20, 2016 at 13:10:56 +0200, Michael Niedermayer wrote: > On Thu, Aug 18, 2016 at 08:50:08PM +0200, Moritz Barsnick wrote: > This code is based on libavcodec/snowdec.c:static int decode_q_branch > Fixing formating is very welcome but it should be in a seperate patch I thought it was

Re: [FFmpeg-devel] [GSOC][PATCH 2/4] FFV1 p frames

2016-08-20 Thread Станислав Долганов
More error handling based on snow decoder errors from patch 1 discussion. 2016-08-20 14:10 GMT+03:00 Michael Niedermayer : > On Thu, Aug 18, 2016 at 08:50:08PM +0200, Moritz Barsnick wrote: > > On Thu, Aug 18, 2016 at 14:49:28 +0300, Станислав Долганов wrote: > > > > >

Re: [FFmpeg-devel] [GSOC][PATCH 2/4] FFV1 p frames

2016-08-20 Thread Michael Niedermayer
On Thu, Aug 18, 2016 at 08:50:08PM +0200, Moritz Barsnick wrote: > On Thu, Aug 18, 2016 at 14:49:28 +0300, Станислав Долганов wrote: > > > +static int decode_q_branch(FFV1Context *f, int level, int x, int y){ > > +RangeCoder *const c = >slice_context[0]->c; > > +OBMCContext *s = >obmc; >

Re: [FFmpeg-devel] [GSOC][PATCH 2/4] FFV1 p frames

2016-08-19 Thread Станислав Долганов
Fix some problems. 2016-08-18 21:50 GMT+03:00 Moritz Barsnick : > On Thu, Aug 18, 2016 at 14:49:28 +0300, Станислав Долганов wrote: > > > +static int decode_q_branch(FFV1Context *f, int level, int x, int y){ > > +RangeCoder *const c = >slice_context[0]->c; > > +

Re: [FFmpeg-devel] [GSOC][PATCH 2/4] FFV1 p frames

2016-08-18 Thread Moritz Barsnick
On Thu, Aug 18, 2016 at 14:49:28 +0300, Станислав Долганов wrote: > +static int decode_q_branch(FFV1Context *f, int level, int x, int y){ > +RangeCoder *const c = >slice_context[0]->c; > +OBMCContext *s = >obmc; > +const int w= s->b_width << s->block_max_depth; This whole function

Re: [FFmpeg-devel] [GSOC][PATCH 2/4] FFV1 p frames

2016-08-18 Thread Станислав Долганов
Tried to tune up to newest version + some fixes. 2016-08-18 4:47 GMT+03:00 Michael Niedermayer : > On Wed, Aug 17, 2016 at 02:07:24PM +0300, Станислав Долганов wrote: > > Hello, > > > > I'm sending the patch set with implementation of GSoC project -- FFV1 P > > frame

Re: [FFmpeg-devel] [GSOC][PATCH 2/4] FFV1 p frames

2016-08-18 Thread Michael Niedermayer
On Wed, Aug 17, 2016 at 02:07:24PM +0300, Станислав Долганов wrote: > Hello, > > I'm sending the patch set with implementation of GSoC project -- FFV1 P > frame support. The current FFV1 uses the same OBMC code as the Snow codec. > Also new median_me_mp function has appeared. > > I'm attaching

Re: [FFmpeg-devel] [GSOC][PATCH 2/4] FFV1 p frames

2016-08-17 Thread Moritz Barsnick
On Wed, Aug 17, 2016 at 14:07:24 +0300, Станислав Долганов wrote: > +{ "pframe", "Using P frames", OFFSET(p_frame), AV_OPT_TYPE_BOOL, { .i64 > = 0 }, 0, 1, VE }, Nit: imperative wording, i.e. "Use P frames". Moritz ___ ffmpeg-devel mailing list