Re: [FFmpeg-devel] [PATCH] Add CONTRIBUTING.md

2016-09-18 Thread Josh de Kock
On 18/09/2016 01:29, James Almer wrote: On 9/17/2016 8:42 PM, Josh de Kock wrote: TimothyGu (https://github.com/FFmpeg/FFmpeg/pull/153#issuecomment-143274708) suggested doing this a while ago, but it was never done. As pull requests seem to be still coming through, I thought I'd send a patch

Re: [FFmpeg-devel] [PATCH] Add CONTRIBUTING.md

2016-09-17 Thread James Almer
On 9/17/2016 8:42 PM, Josh de Kock wrote: > TimothyGu (https://github.com/FFmpeg/FFmpeg/pull/153#issuecomment-143274708) > suggested doing this a while ago, but it was never done. As pull requests > seem to be still coming through, I thought I'd send a patch to add the notice. > >

Re: [FFmpeg-devel] [PATCH] Add CONTRIBUTING.md

2016-09-17 Thread Thilo Borgmann
> Am 18.09.2016 um 01:42 schrieb Josh de Kock : > > TimothyGu (https://github.com/FFmpeg/FFmpeg/pull/153#issuecomment-143274708) > suggested doing this a while ago, but it was never done. As pull requests > seem to be still coming through, I thought I'd send a patch to add

[FFmpeg-devel] [PATCH] Add CONTRIBUTING.md

2016-09-17 Thread Josh de Kock
TimothyGu (https://github.com/FFmpeg/FFmpeg/pull/153#issuecomment-143274708) suggested doing this a while ago, but it was never done. As pull requests seem to be still coming through, I thought I'd send a patch to add the notice. Signed-off-by: Josh de Kock ---

Re: [FFmpeg-devel] [PATCH] add CONTRIBUTING.md

2015-10-06 Thread Stefano Sabatini
On date Monday 2015-10-05 15:26:46 -0800, Lou Logan encoded: > For the Github users to ignore. > > Signed-off-by: Lou Logan > --- > CONTRIBUTING.md | 36 > 1 file changed, 36 insertions(+) > create mode 100644 CONTRIBUTING.md > > diff --git

Re: [FFmpeg-devel] [PATCH] add CONTRIBUTING.md

2015-10-06 Thread Lou Logan
On Tue, 6 Oct 2015 18:37:47 +0200, Stefano Sabatini wrote: > If we keep CONTRIBUTING.md, better to make it independent from Github > - that is I'm suggesting that we move all contributing indications to > README.md, or we keep them in a separate file CONTRIBUTING.md, as > proposed by this patch.

Re: [FFmpeg-devel] [PATCH] add CONTRIBUTING.md

2015-10-06 Thread Lou Logan
On Tue, Oct 6, 2015, at 07:07 AM, Stefano Sabatini wrote: > > I wonder if adding the contents to README.md is not a better choice > > Note also since we're writing about github, that the README.md will > have a better visibility there, since it is shown on the project main > page: >

Re: [FFmpeg-devel] [PATCH] add CONTRIBUTING.md

2015-10-06 Thread Stefano Sabatini
On date Tuesday 2015-10-06 08:20:11 -0800, Lou Logan encoded: > On Tue, Oct 6, 2015, at 07:07 AM, Stefano Sabatini wrote: > > > > I wonder if adding the contents to README.md is not a better choice > > > > Note also since we're writing about github, that the README.md will > > have a better

Re: [FFmpeg-devel] [PATCH] add CONTRIBUTING.md

2015-10-05 Thread Ganesh Ajjanagadde
On Mon, Oct 5, 2015 at 11:17 PM, Lou Logan wrote: > On Mon, Oct 5, 2015, at 05:46 PM, Ganesh Ajjanagadde wrote: >> Unless you have a good reason for this, please change the paragraph to >> be much more similar/identical with README.md. > > Why would that matter? It is just a minor

Re: [FFmpeg-devel] [PATCH] add CONTRIBUTING.md

2015-10-05 Thread Ganesh Ajjanagadde
On Mon, Oct 5, 2015 at 7:26 PM, Lou Logan wrote: > For the Github users to ignore. > > Signed-off-by: Lou Logan > --- > CONTRIBUTING.md | 36 > 1 file changed, 36 insertions(+) > create mode 100644 CONTRIBUTING.md > > diff

[FFmpeg-devel] [PATCH] add CONTRIBUTING.md

2015-10-05 Thread Lou Logan
For the Github users to ignore. Signed-off-by: Lou Logan --- CONTRIBUTING.md | 36 1 file changed, 36 insertions(+) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 000..4bccf25

Re: [FFmpeg-devel] [PATCH] add CONTRIBUTING.md

2015-10-05 Thread Lou Logan
On Mon, Oct 5, 2015, at 05:46 PM, Ganesh Ajjanagadde wrote: > Unless you have a good reason for this, please change the paragraph to > be much more similar/identical with README.md. Why would that matter? ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] add CONTRIBUTING.md

2015-10-05 Thread Simon Thelen
On 15-10-05 at 15:26, Lou Logan wrote: [..] > + > +**FFmpeg development, including patch reviews, occurs on the ffmpeg-devel > +mailing list, so most developers do not view Github pull requests. > +Therefore, Github pull requests should be avoided because they will > +likely be not be noticed.**