Signed-off-by: Paras Chadha
---
Add FATE coverage
Changelog | 1 +
doc/general.texi | 2 +
libavcodec/Makefile| 2 +
libavcodec/allcodecs.c | 1 +
libavcodec/avcodec.h | 1 +
Signed-off-by: Paras Chadha
---
Made the changes suggested.
Added a new file fits.c with common code
Changelog | 1 +
doc/general.texi| 2 +
libavcodec/Makefile | 2 +
libavcodec/allcodecs.c | 1 +
libavcodec/avcodec.h| 1 +
Le duodi 12 thermidor, an CCXXV, Paras Chadha a écrit :
> > > +if (strncmp(keyword, "BITPIX", 6)) {
> > > +av_log(avcl, AV_LOG_ERROR, "expected BITPIX keyword,
> > found %s = %s\n", keyword, value);
> > > +return AVERROR_INVALIDDATA;
> > > +}
On Fri, Jul 28, 2017 at 3:26 PM, Nicolas George wrote:
> Le decadi 10 thermidor, an CCXXV, Paras Chadha a écrit :
> > Signed-off-by: Paras Chadha
> > ---
> > Changelog | 1 +
> > doc/general.texi| 2 +
> > libavcodec/Makefile
Le decadi 10 thermidor, an CCXXV, Paras Chadha a écrit :
> Signed-off-by: Paras Chadha
> ---
> Changelog | 1 +
> doc/general.texi| 2 +
> libavcodec/Makefile | 1 +
> libavcodec/allcodecs.c | 1 +
> libavcodec/avcodec.h| 1 +
>
Signed-off-by: Paras Chadha
---
Changelog | 1 +
doc/general.texi| 2 +
libavcodec/Makefile | 1 +
libavcodec/allcodecs.c | 1 +
libavcodec/avcodec.h| 1 +
libavcodec/codec_desc.c | 7 +
libavcodec/fits.h | 79 +++
Le duodi 2 thermidor, an CCXXV, Paras Chadha a écrit :
> +int64_t t, size = 1;
> +if (!strncmp(keyword, "BLANK", 5) && sscanf(value, "%ld", ) == 1) {
This %ld is not the correct format specifier for int64_t. It would be
something like %"SCNd64".
Regards,
--
Nicolas George
On Thu, Jul 20, 2017 at 11:19 PM, Nicolas George wrote:
> Hi.
>
> Le duodi 2 thermidor, an CCXXV, Paras Chadha a écrit :
> > +size = abs(header->bitpix) >> 3;
>
> > +size *= header->naxisn[i];
>
> Can you explain why PCOUNT and GCOUNT are not taken into account here
Hi.
Le duodi 2 thermidor, an CCXXV, Paras Chadha a écrit :
> +size = abs(header->bitpix) >> 3;
> +size *= header->naxisn[i];
Can you explain why PCOUNT and GCOUNT are not taken into account here
while they are taken into account in the demuxer?
Regards,
--
Nicolas George
Signed-off-by: Paras Chadha
---
Fixed an issue with RGB48 and RGBA64 images.
Also simplified the RGB decoding code.
Changelog | 1 +
doc/general.texi| 2 +
libavcodec/Makefile | 1 +
libavcodec/allcodecs.c | 1 +
libavcodec/avcodec.h
On Tue, Jul 4, 2017 at 2:57 PM, Nicolas George wrote:
> Le quartidi 14 messidor, an CCXXV, Paras Chadha a écrit :
> > Made all the changes suggested
> > Added a new function which reads a header FITS line safely. It also
> makes it more modular
> > Added an option for the user
Le quartidi 14 messidor, an CCXXV, Paras Chadha a écrit :
> Made all the changes suggested
> Added a new function which reads a header FITS line safely. It also makes it
> more modular
> Added an option for the user to enter the value to be used in place of BLANK
> pixels
> Refactored code using
On Fri, Jun 30, 2017 at 6:38 PM, Nicolas George wrote:
> Hi. A few technical / cosmetic remarks below. I do not know the FITS
> format itself more than in passing.
>
> Le duodi 12 messidor, an CCXXV, Paras Chadha a écrit :
> > Made the changes suggested above
> >
> >
Made all the changes suggested
Added a new function which reads a header FITS line safely. It also makes it
more modular
Added an option for the user to enter the value to be used in place of BLANK
pixels
Refactored code using macros to make it short
Signed-off-by: Paras Chadha
On Fri, Jun 30, 2017 at 15:08:17 +0200, Nicolas George wrote:
> > + * function calculates the data_min and data_max values from the data.
>
> The style for doxygen comments is impersonal verbs: "Calculate the ...".
I don't want to nitpick, and I *may* be wrong, but the grammar freak in
me thinks
Hi. A few technical / cosmetic remarks below. I do not know the FITS
format itself more than in passing.
Le duodi 12 messidor, an CCXXV, Paras Chadha a écrit :
> Made the changes suggested above
>
> Signed-off-by: Paras Chadha
> ---
> Changelog | 1 +
>
Made the changes suggested above
Signed-off-by: Paras Chadha
---
Changelog | 1 +
doc/general.texi| 2 +
libavcodec/Makefile | 1 +
libavcodec/allcodecs.c | 1 +
libavcodec/avcodec.h| 1 +
libavcodec/codec_desc.c | 8 +
On Wed, Jun 28, 2017 at 07:22:01PM +0530, Paras Chadha wrote:
> Added code to export metadata as frame metadata
>
> Signed-off-by: Paras Chadha
> -
[...]
> +/**
> + * function reads the fits header and stores the values in FITSDecContext
> pointed by header
> + * @param
Added code to export metadata as frame metadata
Signed-off-by: Paras Chadha
---
Changelog | 1 +
doc/general.texi| 2 +
libavcodec/Makefile | 1 +
libavcodec/allcodecs.c | 1 +
libavcodec/avcodec.h| 1 +
libavcodec/codec_desc.c |
On 6/20/17, Paras Chadha wrote:
> Above changes done. Also fixed an issue with BLANK keyword.
>
> Signed-off-by: Paras Chadha
> ---
> Changelog | 1 +
> doc/general.texi| 2 +
> libavcodec/Makefile | 1 +
>
On Tue, Jun 20, 2017 at 2:44 PM, Paul B Mahol wrote:
> On 6/19/17, Paras Chadha wrote:
> > Added support for XTENSION keyword
> >
> > Signed-off-by: Paras Chadha
> > ---
> > Changelog | 1 +
> >
Above changes done. Also fixed an issue with BLANK keyword.
Signed-off-by: Paras Chadha
---
Changelog | 1 +
doc/general.texi| 2 +
libavcodec/Makefile | 1 +
libavcodec/allcodecs.c | 1 +
libavcodec/avcodec.h| 1 +
On 6/19/17, Paras Chadha wrote:
> Added support for XTENSION keyword
>
> Signed-off-by: Paras Chadha
> ---
> Changelog | 1 +
> doc/general.texi| 2 +
> libavcodec/Makefile | 1 +
> libavcodec/allcodecs.c | 1 +
Added support for XTENSION keyword
Signed-off-by: Paras Chadha
---
Changelog | 1 +
doc/general.texi| 2 +
libavcodec/Makefile | 1 +
libavcodec/allcodecs.c | 1 +
libavcodec/avcodec.h| 1 +
libavcodec/codec_desc.c | 8 +
On Tue, Jun 13, 2017 at 7:45 PM, Paul B Mahol wrote:
> On 6/13/17, Paras Chadha wrote:
> > Above mentioned changes have been done.
> >
> > Signed-off-by: Paras Chadha
> > ---
> > Changelog | 1 +
> >
On 6/13/17, Paras Chadha wrote:
> Above mentioned changes have been done.
>
> Signed-off-by: Paras Chadha
> ---
> Changelog | 1 +
> doc/general.texi| 2 +
> libavcodec/Makefile | 1 +
> libavcodec/allcodecs.c |
Above mentioned changes have been done.
Signed-off-by: Paras Chadha
---
Changelog | 1 +
doc/general.texi| 2 +
libavcodec/Makefile | 1 +
libavcodec/allcodecs.c | 1 +
libavcodec/avcodec.h| 1 +
libavcodec/codec_desc.c | 8 +
On 6/13/17, Paras Chadha wrote:
> Hi,
>
> Any other changes to be made to get this patch applied?
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
Use this style
Hi,
Any other changes to be made to get this patch applied?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On Fri, Jun 9, 2017 at 1:26 AM, Moritz Barsnick wrote:
> On Thu, Jun 08, 2017 at 22:34:15 +0530, Paras Chadha wrote:
> > +t64 = (((uint64_t) ptr8[0]) << 56) | (((uint64_t) ptr8[1])
> << 48) | (((uint64_t) ptr8[2]) << 40) | (((uint64_t) ptr8[3]) << 32) |
> (ptr8[4]
On Fri, Jun 9, 2017 at 4:19 PM, Michael Niedermayer
wrote:
> On Thu, Jun 08, 2017 at 10:34:15PM +0530, Paras Chadha wrote:
> > It supports all 2-d images alongwith bzero, bscale and blank keywords.
> > RGBA images are supported as NAXIS3 = 3 or 4 i.e. Planes in RGBA
All the changes mentioned above have been done.
Signed-off-by: Paras Chadha
---
Changelog | 1 +
doc/general.texi| 2 +
libavcodec/Makefile | 1 +
libavcodec/allcodecs.c | 1 +
libavcodec/avcodec.h| 1 +
libavcodec/codec_desc.c |
On Fri, Jun 9, 2017 at 3:08 AM, Martin Vignali
wrote:
> Hello,
>
> You can create a FipsContext struct to store decoding data
> instead of using Fips Header struct
> (you can take a look to other image decoder)
>
> Also you should need to split the patch for libavcodec
On Thu, Jun 08, 2017 at 10:34:15PM +0530, Paras Chadha wrote:
> It supports all 2-d images alongwith bzero, bscale and blank keywords.
> RGBA images are supported as NAXIS3 = 3 or 4 i.e. Planes in RGBA order. Also
> CTYPE = 'RGB ' should be present.
> It currently does not support XTENSION
Hello,
You can create a FipsContext struct to store decoding data
instead of using Fips Header struct
(you can take a look to other image decoder)
Also you should need to split the patch for libavcodec part and libavformat
part
Nit : The coding style for if/else is
if {
} else {
}
Not
if {
On 6/8/2017 4:56 PM, Moritz Barsnick wrote:
> On Thu, Jun 08, 2017 at 22:34:15 +0530, Paras Chadha wrote:
>> +t64 = (((uint64_t) ptr8[0]) << 56) | (((uint64_t) ptr8[1]) <<
>> 48) | (((uint64_t) ptr8[2]) << 40) | (((uint64_t) ptr8[3]) << 32) | (ptr8[4]
>> << 24) | (ptr8[5] << 16) |
On Thu, Jun 08, 2017 at 22:34:15 +0530, Paras Chadha wrote:
> +t64 = (((uint64_t) ptr8[0]) << 56) | (((uint64_t) ptr8[1]) <<
> 48) | (((uint64_t) ptr8[2]) << 40) | (((uint64_t) ptr8[3]) << 32) | (ptr8[4]
> << 24) | (ptr8[5] << 16) | (ptr8[6] << 8) | ptr8[7];
I think you can (or
It supports all 2-d images alongwith bzero, bscale and blank keywords.
RGBA images are supported as NAXIS3 = 3 or 4 i.e. Planes in RGBA order. Also
CTYPE = 'RGB ' should be present.
It currently does not support XTENSION keyword.
Signed-off-by: Paras Chadha
---
38 matches
Mail list logo