Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-07-07 Thread Carotti, Elias
On Mon, 2023-07-03 at 15:51 +, Carotti, Elias wrote: > On Sat, 2023-07-01 at 10:33 +0200, Anton Khirnov wrote: > > CAUTION: This email originated from outside of the organization. Do > > not click links or open attachments unless you can confirm the > > sender > > and know the content is safe.

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-07-03 Thread Carotti, Elias
On Sat, 2023-07-01 at 10:33 +0200, Anton Khirnov wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > Sorry to still nag you, but I just noticed that unlike >

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-07-01 Thread Anton Khirnov
Sorry to still nag you, but I just noticed that unlike video_enc_params, you do not store AVVideoRect size in AVVideoHint. This means that no new fields can be added to AVVideoRect without an ABI break. This seems suboptimal, since I do see potential use for per-block information. -- Anton

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-30 Thread Carotti, Elias
On Wed, 2023-06-28 at 14:55 +0200, Anton Khirnov wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > Quoting Carotti, Elias (2023-06-26 11:50:59) > > We can

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-28 Thread Anton Khirnov
Quoting Carotti, Elias (2023-06-26 11:50:59) > We can do whatever you want. However I am not clear on how that > would work. > > We could have a side data creation api with the standard parameters and > another method to allocate memory so that ownership is kept by > libavutil returns a pointer

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-26 Thread Carotti, Elias
On Sat, 2023-06-24 at 13:01 +0200, Anton Khirnov wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > Quoting Carotti, Elias (2023-06-22 19:23:05) > > On Thu,

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-24 Thread Anton Khirnov
Quoting Carotti, Elias (2023-06-22 19:23:05) > On Thu, 2023-06-22 at 10:44 +0200, Anton Khirnov wrote: > > CAUTION: This email originated from outside of the organization. Do > > not click links or open attachments unless you can confirm the sender > > and know the content is safe. > > > > > >

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-22 Thread Carotti, Elias
On Thu, 2023-06-22 at 10:44 +0200, Anton Khirnov wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > Quoting Carotti, Elias (2023-06-21 17:53:09) > > + > > +  

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-22 Thread Anton Khirnov
Quoting Carotti, Elias (2023-06-21 17:53:09) > + > +/** > + * Provide macro block encoder-specific hinting information for the > encoder > + * processing. It can be used to pass information about which macroblock > + * can be skipped because it hasn't changed from the

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-21 Thread Carotti, Elias
On Sun, 2023-06-18 at 12:18 +0200, Stefano Sabatini wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > On date Monday 2023-06-12 17:28:10 +, Carotti,

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-18 Thread Stefano Sabatini
On date Monday 2023-06-12 17:28:10 +, Carotti, Elias wrote: > Hi Stefano, > Here is the revised patch according to your suggestions. This should > allow for efficient inlining of the methods computing the map of > skipped macrobloks. > Best,  > Elias [...] > > From

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-18 Thread Stefano Sabatini
On date Monday 2023-06-12 17:38:43 +, Carotti, Elias wrote: > On Mon, 2023-06-12 at 18:23 +1000, Kieran Kunhya wrote: > > CAUTION: This email originated from outside of the organization. Do > > not click links or open attachments unless you can confirm the sender > > and know the content is

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-12 Thread Carotti, Elias
On Mon, 2023-06-12 at 18:23 +1000, Kieran Kunhya wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > > > > Looks good to me otherwise, maybe Michael/Anton or

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-12 Thread Carotti, Elias
Hi Stefano, Here is the revised patch according to your suggestions. This should allow for efficient inlining of the methods computing the map of skipped macrobloks. Best,  Elias On Sun, 2023-06-11 at 19:15 +0200, Stefano Sabatini wrote: > CAUTION: This email originated from outside of the

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-12 Thread Kieran Kunhya
> > Looks good to me otherwise, maybe Michael/Anton or someone else want > to have a look? > I don't think we should be adding what is essentially libx264 specific code to the public libavutil API. Kieran ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-11 Thread Stefano Sabatini
On date Monday 2023-06-05 15:32:35 +, Carotti, Elias wrote: > Hi, > please find attached the patch which I updated according to your > suggestions. > Best, > Elias [...] > From 8288d2bd36ffed29140d46c42b6f5515a9058836 Mon Sep 17 00:00:00 2001 > From: Elias Carotti > Date: Wed, 19 Apr 2023

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-05 Thread Carotti, Elias
Hi, please find attached the patch which I updated according to your suggestions. Best, Elias On Sun, 2023-06-04 at 17:29 +0200, Stefano Sabatini wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-04 Thread Stefano Sabatini
On date Monday 2023-05-29 17:56:55 +, Carotti, Elias wrote: [...] > From 7cb97ee977197e310a932b2d7a53bf5c6e0e Mon Sep 17 00:00:00 2001 > From: Elias Carotti > Date: Wed, 19 Apr 2023 11:49:39 +0200 > Subject: [PATCH] Add support for libx264's MB_INFO > > libx264's x264_image_properties_t,

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-05-29 Thread Carotti, Elias
Hi Stefano, hi all, please find the updated patch according to the suggestions. Now it is possible to specify whether the rectangles refer to the part we want to hint as P_SKIP or to the rest portion of the frame. Best, Elias On Mon, 2023-05-22 at 09:19 +, Carotti, Elias wrote: > Hi

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-05-22 Thread Carotti, Elias
Hi Stefano, thanks for checking the patch. Please find it attached in the required format. Best, Elias On Mon, 2023-05-22 at 01:17 +0200, Stefano Sabatini wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-05-21 Thread Stefano Sabatini
On date Friday 2023-05-19 10:19:03 +, Carotti, Elias wrote: > > Hi again, > I am sending this patch again (I had missed a check for NULL), could > somebody please have a look at it?  > > It is mainly an optimization when the encoder knows in advance that > only portions of the whole frame

[FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-05-19 Thread Carotti, Elias
Hi again, I am sending this patch again (I had missed a check for NULL), could somebody please have a look at it?  It is mainly an optimization when the encoder knows in advance that only portions of the whole frame changed and which areas actually did. The patch allows a user to pass down