Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: Check tiles sizes, fix assert, don't read bytes bitwise

2020-09-17 Thread Wang, Fei W
> -Original Message- > From: ffmpeg-devel On Behalf Of James > Almer > Sent: Thursday, September 17, 2020 11:37 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: Check tiles sizes, fix > assert, don't read bytes bitwise

Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: Check tiles sizes, fix assert, don't read bytes bitwise

2020-09-16 Thread James Almer
On 9/17/2020 12:19 AM, Andreas Rheinhardt wrote: > Tiles have a size field with a length from one to four bytes. As such it > is not possible to read it all at once with a call to get_bits() as this > only allows to read up to 25 bits; this is guarded by an av_assert2. Yet > this is done by the AV1

[FFmpeg-devel] [PATCH] avcodec/av1dec: Check tiles sizes, fix assert, don't read bytes bitwise

2020-09-16 Thread Andreas Rheinhardt
Tiles have a size field with a length from one to four bytes. As such it is not possible to read it all at once with a call to get_bits() as this only allows to read up to 25 bits; this is guarded by an av_assert2. Yet this is done by the AV1 decoder in get_tiles_info(). It has been done despite sa