Re: [FFmpeg-devel] [PATCH] avcodec/exr: tag gamma=1.0 output as linear light

2023-08-20 Thread Tomas Härdin
tor 2023-08-17 klockan 14:04 -0400 skrev Leo Izen: > On 8/17/23 08:59, Tomas Härdin wrote: > > ons 2023-08-16 klockan 01:20 -0400 skrev Leo Izen: > > > By default the OpenEXR decoder outputs linear light pixel data by > > > applying a gamma=1.0 transfer (i.e. a no-op). When it does so, it > > >

Re: [FFmpeg-devel] [PATCH] avcodec/exr: tag gamma=1.0 output as linear light

2023-08-17 Thread Leo Izen
On 8/17/23 08:59, Tomas Härdin wrote: ons 2023-08-16 klockan 01:20 -0400 skrev Leo Izen: By default the OpenEXR decoder outputs linear light pixel data by applying a gamma=1.0 transfer (i.e. a no-op). When it does so, it should tag the data as linear so color-managed filters or other tools can

Re: [FFmpeg-devel] [PATCH] avcodec/exr: tag gamma=1.0 output as linear light

2023-08-17 Thread Tomas Härdin
ons 2023-08-16 klockan 01:20 -0400 skrev Leo Izen: > By default the OpenEXR decoder outputs linear light pixel data by > applying a gamma=1.0 transfer (i.e. a no-op). When it does so, it > should tag the data as linear so color-managed filters or other tools > can work with it correctly. > >

Re: [FFmpeg-devel] [PATCH] avcodec/exr: tag gamma=1.0 output as linear light

2023-08-16 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avcodec/exr: tag gamma=1.0 output as linear light

2023-08-15 Thread Leo Izen
By default the OpenEXR decoder outputs linear light pixel data by applying a gamma=1.0 transfer (i.e. a no-op). When it does so, it should tag the data as linear so color-managed filters or other tools can work with it correctly. Signed-off-by: Leo Izen --- libavcodec/exr.c | 2 ++ 1 file

Re: [FFmpeg-devel] [PATCH] avcodec/exr: More strictly check dc_count

2021-05-27 Thread Michael Niedermayer
On Tue, May 25, 2021 at 10:22:02PM +0200, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: exr/deneme > > Found-by: Burak Çarıkçı > Signed-off-by: Michael Niedermayer > --- > libavcodec/exr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) will apply [...] --

[FFmpeg-devel] [PATCH] avcodec/exr: More strictly check dc_count

2021-05-25 Thread Michael Niedermayer
Fixes: out of array access Fixes: exr/deneme Found-by: Burak Çarıkçı Signed-off-by: Michael Niedermayer --- libavcodec/exr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index 9377a89169..4648ed7d62 100644 --- a/libavcodec/exr.c

Re: [FFmpeg-devel] [PATCH] avcodec/exr: simplify piz decompression

2021-02-23 Thread Paul B Mahol
will apply soon ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/exr: simplify piz decompression

2021-02-20 Thread Paul B Mahol
On Sat, Feb 20, 2021 at 11:11 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Paul B Mahol: > > Signed-off-by: Paul B Mahol > > --- > > libavcodec/exr.c | 212 +++ > > 1 file changed, 65 insertions(+), 147 deletions(-) > > > > diff

[FFmpeg-devel] [PATCH] avcodec/exr: simplify piz decompression

2021-02-20 Thread Paul B Mahol
Note that >32 codes are no longer supported, give proper error code if such scenario ever happens. Signed-off-by: Paul B Mahol --- libavcodec/exr.c | 251 +-- 1 file changed, 89 insertions(+), 162 deletions(-) diff --git a/libavcodec/exr.c

Re: [FFmpeg-devel] [PATCH] avcodec/exr: simplify piz decompression

2021-02-20 Thread Andreas Rheinhardt
Paul B Mahol: > Signed-off-by: Paul B Mahol > --- > libavcodec/exr.c | 212 +++ > 1 file changed, 65 insertions(+), 147 deletions(-) > > diff --git a/libavcodec/exr.c b/libavcodec/exr.c > index cacdff5774..625ee4680c 100644 > --- a/libavcodec/exr.c >

[FFmpeg-devel] [PATCH] avcodec/exr: simplify piz decompression

2021-02-19 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/exr.c | 212 +++ 1 file changed, 65 insertions(+), 147 deletions(-) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index cacdff5774..625ee4680c 100644 --- a/libavcodec/exr.c +++ b/libavcodec/exr.c @@ -91,6

[FFmpeg-devel] [PATCH] avcodec/exr: simplify piz decompression

2021-02-19 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/exr.c | 209 ++- 1 file changed, 63 insertions(+), 146 deletions(-) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index cacdff5774..9d86f6ea43 100644 --- a/libavcodec/exr.c +++ b/libavcodec/exr.c @@ -91,6

Re: [FFmpeg-devel] [PATCH] avcodec/exr: preserve half-float NaN bits and add fate test

2020-12-07 Thread Paul B Mahol
On Sun, Dec 6, 2020 at 4:20 AM Mark Reid wrote: > On Sun, Nov 22, 2020 at 8:32 PM wrote: > > > From: Mark Reid > > > > Hi, > > This patch handles NaNs more like the offical implentation handles them, > > preserving > > the original bits. > > > > > > >

Re: [FFmpeg-devel] [PATCH] avcodec/exr: preserve half-float NaN bits and add fate test

2020-12-05 Thread Mark Reid
On Sun, Nov 22, 2020 at 8:32 PM wrote: > From: Mark Reid > > Hi, > This patch handles NaNs more like the offical implentation handles them, > preserving > the original bits. > > > https://github.com/AcademySoftwareFoundation/openexr/blob/RB-2.5/IlmBase/Half/toFloat.cpp#L111 > > It also adds a

[FFmpeg-devel] [PATCH] avcodec/exr: preserve half-float NaN bits and add fate test

2020-11-22 Thread mindmark
From: Mark Reid Hi, This patch handles NaNs more like the offical implentation handles them, preserving the original bits. https://github.com/AcademySoftwareFoundation/openexr/blob/RB-2.5/IlmBase/Half/toFloat.cpp#L111 It also adds a fate test that is a 256x256 exr containing all possible

Re: [FFmpeg-devel] [PATCH] avcodec/exr: add cineon lin2log trc

2020-03-06 Thread Carl Eugen Hoyos
Am Fr., 6. März 2020 um 22:11 Uhr schrieb Paul B Mahol : > > On 3/6/20, Carl Eugen Hoyos wrote: > > Am Fr., 6. März 2020 um 00:25 Uhr schrieb : > > > >> +AVCOL_TRC_CINE_LIN2LOG = 19, ///< Default Cineon/DPX linear to log 1D > >> curve > > > > Isn't it possible to use a random large number

Re: [FFmpeg-devel] [PATCH] avcodec/exr: add cineon lin2log trc

2020-03-06 Thread Paul B Mahol
On 3/6/20, Carl Eugen Hoyos wrote: > Am Fr., 6. März 2020 um 00:25 Uhr schrieb : > >> +AVCOL_TRC_CINE_LIN2LOG = 19, ///< Default Cineon/DPX linear to log 1D >> curve > > Isn't it possible to use a random large number here? No, because that would be big hack on top of big pile of hacks that

Re: [FFmpeg-devel] [PATCH] avcodec/exr: add cineon lin2log trc

2020-03-06 Thread Carl Eugen Hoyos
Am Fr., 6. März 2020 um 00:25 Uhr schrieb : > +AVCOL_TRC_CINE_LIN2LOG = 19, ///< Default Cineon/DPX linear to log 1D > curve Isn't it possible to use a random large number here? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avcodec/exr: add cineon lin2log trc

2020-03-06 Thread Gonzalo Garramuño
El 06/03/20 a las 16:33, Mark Reid escribió: You would perhaps be better creating a specialist filter and implementing it using OCIO (as suggested https://github.com/AcademySoftwareFoundation/tac/tree/master/gsoc), or extending the current 3D LUT code to read Cinespace or other 3D LUT formats

Re: [FFmpeg-devel] [PATCH] avcodec/exr: add cineon lin2log trc

2020-03-06 Thread Mark Reid
On Fri, Mar 6, 2020 at 5:03 AM Kevin Wheatley wrote: > On Fri, Mar 6, 2020 at 10:19 AM Hendrik Leppkes > wrote: > > AVColorTransferCharacteristic should follow ISO/IEC 23001-8 and its > > following standards (ISO/IEC 23091 I believe). Not sure we have a > > solution for specialized variants,

Re: [FFmpeg-devel] [PATCH] avcodec/exr: add cineon lin2log trc

2020-03-06 Thread Kevin Wheatley
On Fri, Mar 6, 2020 at 10:19 AM Hendrik Leppkes wrote: > AVColorTransferCharacteristic should follow ISO/IEC 23001-8 and its > following standards (ISO/IEC 23091 I believe). Not sure we have a > solution for specialized variants, but adding one right there would > collide with the next addition

Re: [FFmpeg-devel] [PATCH] avcodec/exr: add cineon lin2log trc

2020-03-06 Thread Hendrik Leppkes
On Fri, Mar 6, 2020 at 12:25 AM wrote: > > From: Mark Reid > > Hi, > The following patch adds a cineon lin2log color transfer characteristic to > exr. > The purpose of this patch is to allow preserving of the dynamic range of an > exr file when converting to DPX or when using video filter such

Re: [FFmpeg-devel] [PATCH] avcodec/exr: add cineon lin2log trc

2020-03-06 Thread Paul B Mahol
On 3/5/20, mindm...@gmail.com wrote: > From: Mark Reid > > Hi, > The following patch adds a cineon lin2log color transfer characteristic to > exr. > The purpose of this patch is to allow preserving of the dynamic range of an > exr file when converting to DPX or when using video filter such as 3d

[FFmpeg-devel] [PATCH] avcodec/exr: add cineon lin2log trc

2020-03-05 Thread mindmark
From: Mark Reid Hi, The following patch adds a cineon lin2log color transfer characteristic to exr. The purpose of this patch is to allow preserving of the dynamic range of an exr file when converting to DPX or when using video filter such as 3d luts. I wasn't sure if adding it to the

Re: [FFmpeg-devel] [PATCH] avcodec/exr: Allow duplicate use of channel indexes

2019-10-09 Thread Michael Niedermayer
On Tue, Oct 08, 2019 at 05:13:42PM +0200, Paul B Mahol wrote: > Why are you not gonna apply this patch? > > Fix code you break! I did not treat this patch special it was on the mailing list waiting for a review like any other bugfix ill apply it with my next push Thanks for remining me [...]

Re: [FFmpeg-devel] [PATCH] avcodec/exr: Allow duplicate use of channel indexes

2019-10-08 Thread Paul B Mahol
Why are you not gonna apply this patch? Fix code you break! On 9/26/19, Michael Niedermayer wrote: > Fixes: Ticket #8203 > > Reported-by: durandal_1707 > Signed-off-by: Michael Niedermayer > --- > libavcodec/exr.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git

[FFmpeg-devel] [PATCH] avcodec/exr: Allow duplicate use of channel indexes

2019-09-26 Thread Michael Niedermayer
Fixes: Ticket #8203 Reported-by: durandal_1707 Signed-off-by: Michael Niedermayer --- libavcodec/exr.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index c12469cc28..29dab36409 100644 --- a/libavcodec/exr.c +++

Re: [FFmpeg-devel] [PATCH] avcodec/exr: Check remaining bits in last get code loop

2018-02-16 Thread Michael Niedermayer
On Wed, Feb 14, 2018 at 01:45:24PM +0100, Michael Niedermayer wrote: > Fixes: runtime error: shift exponent -7 is negative > Fixes: > 3902/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EXR_fuzzer-6081926122176512 > > Found-by: continuous fuzzing process >

[FFmpeg-devel] [PATCH] avcodec/exr: Check remaining bits in last get code loop

2018-02-14 Thread Michael Niedermayer
Fixes: runtime error: shift exponent -7 is negative Fixes: 3902/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EXR_fuzzer-6081926122176512 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avcodec/exr: Check buf_size more completely

2017-12-30 Thread Michael Niedermayer
On Fri, Dec 29, 2017 at 03:00:19AM +0100, Michael Niedermayer wrote: > Fixes: Out of heap array read > Fixes: 4683/clusterfuzz-testcase-minimized-6152313673613312 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael

[FFmpeg-devel] [PATCH] avcodec/exr: Check buf_size more completely

2017-12-28 Thread Michael Niedermayer
Fixes: Out of heap array read Fixes: 4683/clusterfuzz-testcase-minimized-6152313673613312 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/exr.c | 8 1 file

Re: [FFmpeg-devel] [PATCH] avcodec/exr detect invalid line offset table and recreate table

2017-03-25 Thread Martin Vignali
Hello, The latest patch appear to have a problem : fatal: corrupt patch at line 6 And it doesn't work for me (head variable seems to be important). I put in attach a patch, based on the previous one, who works for me. Martin 0001-libavcodec-exr-add-support-for-scanline-file-where-o.patch

Re: [FFmpeg-devel] [PATCH] avcodec/exr detect invalid line offset table and recreate table

2017-03-21 Thread Dzung Hoang
Sorry about the bad format for the patch. Here's another try. --- libavcodec/exr.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index 034920f..265d44d 100644 --- a/libavcodec/exr.c +++ b/libavcodec/exr.c @@ -1640,6 +1640,9 @@

Re: [FFmpeg-devel] [PATCH] avcodec/exr detect invalid line offset table and recreate table

2017-03-21 Thread Dzung Hoang
gmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Sent: Saturday, March 18, 2017 7:14 AM Subject: Re: [FFmpeg-devel] [PATCH] avcodec/exr detect invalid line offset table and recreate table Hello, I tested your patch on mac, seems to work, a

Re: [FFmpeg-devel] [PATCH] avcodec/exr detect invalid line offset table and recreate table

2017-03-18 Thread Martin Vignali
Hello, I tested your patch on mac, seems to work, and doesn't break exr fate test. Some comments : > --- > libavcodec/exr.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/libavcodec/exr.c b/libavcodec/exr.c > index 034920f..dec21af 100644 > ---

Re: [FFmpeg-devel] [PATCH] avcodec/exr detect invalid line offset table and recreate table

2017-03-17 Thread Dzung Hoang
hoo@ffmpeg.org> To: FFmpeg Development Discussions and Patches <ffmpeg-devel@ffmpeg.org> Sent: Tuesday, March 14, 2017 1:36 PM Subject: [FFmpeg-devel] [PATCH] avcodec/exr detect invalid line offset table and recreate table The EXR decoder cannot handle the image files included in NVid

[FFmpeg-devel] [PATCH] avcodec/exr detect invalid line offset table and recreate table

2017-03-14 Thread Dzung Hoang
The EXR decoder cannot handle the image files included in NVidia's HDR SDK. After debugging, I found that the line offset table in the image files contained 0's. Other EXR decoders, including the official OpenEXR decoder, can detect and reconstruct missing line offset tables, so I added some

Re: [FFmpeg-devel] [PATCH] avcodec/exr

2017-03-14 Thread Martin Vignali
Hello, Doesn't have time yet to take a look. Can you send a clean patch : https://ffmpeg.org/developer.html#Submitting-patches-1 Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/exr

2017-03-14 Thread Paul B Mahol
On 3/14/17, Dzung Hoang wrote: > What is the next step to get this issue resolved? Posting correct patch. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/exr

2017-03-14 Thread Dzung Hoang
What is the next step to get this issue resolved? Dzung Hoang From: Carl Eugen Hoyos <ceffm...@gmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Sent: Tuesday, March 7, 2017 2:02 AM Subject: Re: [FFmpeg-devel] [PATCH] avcodec/exr 2017

Re: [FFmpeg-devel] [PATCH] avcodec/exr

2017-03-11 Thread Michael Niedermayer
On Mon, Mar 06, 2017 at 05:00:22PM +, Dzung Hoang wrote: > The EXR decoder cannot handle the image files included in NVidia's HDR SDK. > After debugging, I found that the line offset table in the image files > contained 0's. Other EXR decoders, including the official OpenEXR decoder, > can

Re: [FFmpeg-devel] [PATCH] avcodec/exr

2017-03-07 Thread Dzung Hoang
in a blank image when processed by ffmpeg. Let me know if you need additional test images. Regards,- Dzung Hoang From: Paul B Mahol <one...@gmail.com> To: dtho...@yahoo.com Sent: Monday, March 6, 2017 11:37 AM Subject: Re: [FFmpeg-devel] [PATCH] avcodec/exr On 3/6/17, Dzung

Re: [FFmpeg-devel] [PATCH] avcodec/exr

2017-03-06 Thread Paul B Mahol
On 3/6/17, Dzung Hoang wrote: > The EXR decoder cannot handle the image files included in NVidia's HDR SDK. > After debugging, I found that the line offset table in the image files > contained 0's. Other EXR decoders, including the official OpenEXR decoder, > can

[FFmpeg-devel] [PATCH] avcodec/exr

2017-03-06 Thread Dzung Hoang
The EXR decoder cannot handle the image files included in NVidia's HDR SDK. After debugging, I found that the line offset table in the image files contained 0's. Other EXR decoders, including the official OpenEXR decoder, can detect and reconstruct missing line offset tables, so I added some

Re: [FFmpeg-devel] [PATCH] avcodec/exr/c Add support for applying a transfer characteristic curve to OpenEXR inputs.

2015-09-10 Thread Michael Niedermayer
On Tue, Sep 01, 2015 at 12:46:21PM +0100, Kevin Wheatley wrote: > This actually marks up the buffers as having the state given by the applied > trc, > > Kevin > > On Tue, Sep 1, 2015 at 12:04 PM, Kevin Wheatley > wrote: > > This adds the actual usage and allows for

[FFmpeg-devel] [PATCH] avcodec/exr/c Add support for applying a transfer characteristic curve to OpenEXR inputs.

2015-09-01 Thread Kevin Wheatley
This adds the actual usage and allows for command lines similar to this: ffmpeg -apply_trc bt709 -i linear.exr bt709.png ffmpeg -apply_trc smpte2084 -i linear.exr smpte2084.png ffmpeg -apply_trc iec61966_2_1 -i linear.exr sRGB.png Which assuming the correct primaries in the linear OpenEXR file

Re: [FFmpeg-devel] [PATCH] avcodec/exr/c Add support for applying a transfer characteristic curve to OpenEXR inputs.

2015-09-01 Thread Kevin Wheatley
This actually marks up the buffers as having the state given by the applied trc, Kevin On Tue, Sep 1, 2015 at 12:04 PM, Kevin Wheatley wrote: > This adds the actual usage and allows for command lines similar to this: > > ffmpeg -apply_trc bt709 -i linear.exr