Re: [FFmpeg-devel] [PATCH] avcodec/h264: support sps/pps AV_PKT_DATA_NEW_EXTRADATA

2020-07-06 Thread James Almer
On 6/19/2020 5:10 PM, Olly Woodman wrote: > On Tue, 2 Jun 2020 at 22:32, Olly Woodman wrote: > >> >> >> On Fri, 8 May 2020 at 03:10, Oliver Woodman wrote: >> >>> https://github.com/FFmpeg/FFmpeg/commit/601c238 added support >>> for AV_PKT_DATA_NEW_EXTRADATA, but only for avcC extradata. >>>

Re: [FFmpeg-devel] [PATCH] avcodec/h264: support sps/pps AV_PKT_DATA_NEW_EXTRADATA

2020-07-06 Thread Paul B Mahol
On 6/19/20, Olly Woodman wrote: > On Tue, 2 Jun 2020 at 22:32, Olly Woodman wrote: > >> >> >> On Fri, 8 May 2020 at 03:10, Oliver Woodman wrote: >> >>> https://github.com/FFmpeg/FFmpeg/commit/601c238 added support >>> for AV_PKT_DATA_NEW_EXTRADATA, but only for avcC extradata. >>> This commit

Re: [FFmpeg-devel] [PATCH] avcodec/h264: support sps/pps AV_PKT_DATA_NEW_EXTRADATA

2020-06-19 Thread Olly Woodman
On Tue, 2 Jun 2020 at 22:32, Olly Woodman wrote: > > > On Fri, 8 May 2020 at 03:10, Oliver Woodman wrote: > >> https://github.com/FFmpeg/FFmpeg/commit/601c238 added support >> for AV_PKT_DATA_NEW_EXTRADATA, but only for avcC extradata. >> This commit adds support for sps/pps extradata as well.

Re: [FFmpeg-devel] [PATCH] avcodec/h264: support sps/pps AV_PKT_DATA_NEW_EXTRADATA

2020-06-02 Thread Olly Woodman
On Fri, 8 May 2020 at 03:10, Oliver Woodman wrote: > https://github.com/FFmpeg/FFmpeg/commit/601c238 added support > for AV_PKT_DATA_NEW_EXTRADATA, but only for avcC extradata. > This commit adds support for sps/pps extradata as well. This > makes support consistent for passing new extradata

Re: [FFmpeg-devel] [PATCH] avcodec/h264: support sps/pps AV_PKT_DATA_NEW_EXTRADATA

2020-05-18 Thread Olly Woodman
Do I need to do anything else for someone to take a look? It would be great to get it merged, if possible, and I think the change itself is pretty trivial. Apologies if this is being pinged too soon; I'm trying to follow the guidance on the FFmpeg contributing page ("if some time passes without

[FFmpeg-devel] [PATCH] avcodec/h264: support sps/pps AV_PKT_DATA_NEW_EXTRADATA

2020-05-07 Thread Oliver Woodman
https://github.com/FFmpeg/FFmpeg/commit/601c238 added support for AV_PKT_DATA_NEW_EXTRADATA, but only for avcC extradata. This commit adds support for sps/pps extradata as well. This makes support consistent for passing new extradata consistent with the types of extradata that can be passed when